foreman_puppet 0.0.2 → 1.0.0

data/test/graphql/queries/environment_query_test.rb

@@ -0,0 +1,54 @@
+require 'test_puppet_helper'
+
+module Queries
+  class EnvironmentQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query (
+        $id: String!
+      ) {
+        environment(id: $id) {
+          id
+          createdAt
+          updatedAt
+          name
+          locations {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+          organizations {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:environment) { FactoryBot.create(:environment) }
+
+    let(:global_id) { Foreman::GlobalId.for(environment) }
+    let(:variables) { { id: global_id } }
+    let(:data) { result['data']['environment'] }
+
+    test 'fetching environment attributes' do
+      assert_empty result['errors']
+
+      assert_equal global_id, data['id']
+      assert_equal environment.created_at.utc.iso8601, data['createdAt']
+      assert_equal environment.updated_at.utc.iso8601, data['updatedAt']
+      assert_equal environment.name, data['name']
+
+      assert_collection environment.locations, data['locations']
+      assert_collection environment.organizations, data['organizations']
+    end
+  end
+end

data/test/graphql/queries/environments_query_test.rb

@@ -0,0 +1,43 @@
+require 'test_helper'
+
+module Queries
+  class EnvironmentsQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query {
+        environments {
+          totalCount
+          pageInfo {
+            startCursor
+            endCursor
+            hasNextPage
+            hasPreviousPage
+          }
+          edges {
+            cursor
+            node {
+              id
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:data) { result['data']['environments'] }
+
+    setup do
+      FactoryBot.create_list(:environment, 2)
+    end
+
+    test 'fetching environments attributes' do
+      assert_empty result['errors']
+
+      expected_count = ForemanPuppet::Environment.count
+
+      assert_not_equal 0, expected_count
+      assert_equal expected_count, data['totalCount']
+      assert_equal expected_count, data['edges'].count
+    end
+  end
+end

data/test/{qraphql → graphql}/queries/host_puppet_query_test.rb

@@ -12,9 +12,6 @@ module Queries
           environment {
             id
           }
-          puppetProxy {
-            id
-          }
         }
       }
       GRAPHQL
@@ -23,14 +20,12 @@ module Queries
     let(:host) { FactoryBot.create(:host, :with_puppet_enc) }
     let(:global_id) { Foreman::GlobalId.encode('Host', host.id) }
     let(:variables) { { id: global_id } }
+    let(:data) { result['data']['host'] }
 
     test 'fetching host attributes' do
-      skip 'GraphQL is TODO'
-      host_data = result['data']['host']
       assert_empty result['errors']
-      assert_equal global_id, host_data['id']
-      assert_record host.environment, host_data['environment']
-      assert_record host.puppet_proxy, host_data['puppetProxy']
+      assert_equal global_id, data['id']
+      assert_record host.environment, data['environment']
     end
   end
 end

data/test/{qraphql → graphql}/queries/hostgroup_puppet_query_test.rb

@@ -12,25 +12,20 @@ module Queries
           environment {
             id
           }
-          puppetProxy {
-            id
-          }
         }
       }
       GRAPHQL
     end
 
-    let(:hostgroup) { FactoryBot.create(:hostgroup, :with_puppet_enc) }
+    let(:hostgroup) { FactoryBot.create(:hostgroup, :with_puppet_enc, :with_puppetclass) }
     let(:global_id) { Foreman::GlobalId.encode('Hostgroup', hostgroup.id) }
     let(:variables) { { id: global_id } }
 
     test 'fetching host attributes' do
-      skip 'GraphQL is TODO'
       hostgroup_data = result['data']['hostgroup']
       assert_empty result['errors']
       assert_equal global_id, hostgroup_data['id']
       assert_record hostgroup.puppet.environment, hostgroup_data['environment']
-      assert_record hostgroup.puppet_proxy, hostgroup_data['puppetProxy']
     end
   end
 end

data/test/graphql/queries/location_query_test.rb

@@ -0,0 +1,52 @@
+require 'test_puppet_helper'
+
+module Queries
+  class LocationQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query (
+        $id: String!
+      ) {
+        location(id: $id) {
+          id
+          environments {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+          puppetclasses {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:environment) { FactoryBot.create(:environment) }
+    let(:location_object) { FactoryBot.create(:location, environments: [environment]) }
+
+    let(:global_id) { Foreman::GlobalId.for(location_object) }
+    let(:variables) { { id: global_id } }
+    let(:data) { result['data']['location'] }
+
+    setup do
+      FactoryBot.create(:puppetclass, environments: [environment])
+    end
+
+    test 'fetching location attributes' do
+      assert_empty result['errors']
+
+      assert_equal global_id, data['id']
+      assert_collection location_object.environments, data['environments']
+      assert_collection location_object.puppetclasses, data['puppetclasses']
+    end
+  end
+end

data/test/graphql/queries/organization_query_test.rb

@@ -0,0 +1,52 @@
+require 'test_puppet_helper'
+
+module Queries
+  class OrganizationQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query (
+        $id: String!
+      ) {
+        organization(id: $id) {
+          id
+          environments {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+          puppetclasses {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:environment) { FactoryBot.create(:environment) }
+    let(:organization_object) { FactoryBot.create(:organization, environments: [environment]) }
+
+    let(:global_id) { Foreman::GlobalId.for(organization_object) }
+    let(:variables) { { id: global_id } }
+    let(:data) { result['data']['organization'] }
+
+    setup do
+      FactoryBot.create(:puppetclass, environments: [environment])
+    end
+
+    test 'fetching organization attributes' do
+      assert_empty result['errors']
+
+      assert_equal global_id, data['id']
+      assert_collection organization_object.environments, data['environments']
+      assert_collection organization_object.puppetclasses, data['puppetclasses']
+    end
+  end
+end

data/test/graphql/queries/puppetclass_query_test.rb

@@ -0,0 +1,68 @@
+require 'test_puppet_helper'
+
+module Queries
+  class PuppetclassQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query (
+        $id: String!
+      ) {
+        puppetclass(id: $id) {
+          id
+          createdAt
+          updatedAt
+          name
+          environments {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+          locations {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+          organizations {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:environment) { FactoryBot.create(:environment) }
+    let(:puppetclass) { FactoryBot.create(:puppetclass) }
+
+    let(:global_id) { Foreman::GlobalId.for(puppetclass) }
+    let(:variables) { { id: global_id } }
+    let(:data) { result['data']['puppetclass'] }
+
+    setup do
+      FactoryBot.create(:environment_class, puppetclass: puppetclass, environment: environment)
+    end
+
+    test 'fetching puppetclass attributes' do
+      assert_empty result['errors']
+
+      assert_equal global_id, data['id']
+      assert_equal puppetclass.created_at.utc.iso8601, data['createdAt']
+      assert_equal puppetclass.updated_at.utc.iso8601, data['updatedAt']
+      assert_equal puppetclass.name, data['name']
+
+      assert_collection puppetclass.environments, data['environments']
+      assert_collection puppetclass.locations, data['locations']
+      assert_collection puppetclass.organizations, data['organizations']
+    end
+  end
+end

data/test/graphql/queries/puppetclasses_query_test.rb

@@ -0,0 +1,43 @@
+require 'test_puppet_helper'
+
+module Queries
+  class PuppetclassesQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query {
+        puppetclasses {
+          totalCount
+          pageInfo {
+            startCursor
+            endCursor
+            hasNextPage
+            hasPreviousPage
+          }
+          edges {
+            cursor
+            node {
+              id
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:data) { result['data']['puppetclasses'] }
+
+    setup do
+      FactoryBot.create_list(:puppetclass, 2)
+    end
+
+    test 'fetching puppetclasses attributes' do
+      assert_empty result['errors']
+
+      expected_count = ForemanPuppet::Puppetclass.count
+
+      assert_not_equal 0, expected_count
+      assert_equal expected_count, data['totalCount']
+      assert_equal expected_count, data['edges'].count
+    end
+  end
+end

data/test/integration/foreman_puppet/environment_js_test.rb

@@ -5,6 +5,9 @@ module ForemanPuppet
   class EnvironmentJSTest < IntegrationTestWithJavascript
     include ForemanPuppet::Engine.routes.url_helpers
 
+    let(:environment) { FactoryBot.create(:environment) }
+    setup { environment }
+
     test 'index page' do
       assert_index_page(environments_path, 'Environments', 'Create Puppet Environment')
     end
@@ -18,7 +21,7 @@ module ForemanPuppet
 
     test 'edit page' do
       visit environments_path
-      click_link 'production'
+      click_link environment.name
       fill_in 'environment_name', with: 'production222'
       assert_submit_button(environments_path)
       assert page.has_link? 'production222'

data/test/integration/foreman_puppet/host_js_test.rb

@@ -141,7 +141,7 @@ module ForemanPuppet
         click_on_inherit('puppet_proxy')
         select2(overridden_hostgroup.name, from: 'host_hostgroup_id')
 
-        assert find('#s2id_host_puppet_attributes_environment_id .select2-chosen').has_text? original_hostgroup.environment.name
+        assert find('#s2id_host_puppet_attributes_environment_id .select2-chosen').has_text? original_hostgroup.puppet.environment.name
 
         # On host group change, the disabled select will be reset to an empty value - disabled select2 is invisible on chrome
         assert find('#s2id_host_puppet_proxy_id .select2-chosen', visible: :all).has_text? ''

data/test/integration/foreman_puppet/puppetclass_js_test.rb

@@ -11,9 +11,11 @@ module ForemanPuppet
     let(:puppetclass) { FactoryBot.create(:puppetclass, environments: [environment]) }
 
     test 'edit page' do
+      FactoryBot.create(:puppetclass, name: 'vim', environments: [environment]) if ForemanPuppet.extracted_from_core?
       visit puppetclasses_path
       click_link 'vim'
       assert page.has_no_link? 'Common'
+      find(:xpath, "//a[@title='Select All']").hover
       find(:xpath, "//a[@data-original-title='Select All']").click
       assert_submit_button(puppetclasses_path)
       assert page.has_link? 'vim'
@@ -24,6 +26,7 @@ module ForemanPuppet
       smart_class_parameter_long = FactoryBot.create(:puppetclass_lookup_key, puppetclass: puppetclass, variable: 'a' * 50)
       visit edit_puppetclass_path(puppetclass)
       click_link 'Smart Class Parameter'
+      page.find("#pill_#{smart_class_parameter_long.id}-#{smart_class_parameter_long.key}").hover
       assert_equal smart_class_parameter_long.key, page.find("#pill_#{smart_class_parameter_long.id}-#{smart_class_parameter_long.key}")['data-original-title']
     end
 
@@ -31,6 +34,7 @@ module ForemanPuppet
       smart_class_parameter_short = FactoryBot.create(:puppetclass_lookup_key, puppetclass: puppetclass, variable: 'a' * 40)
       visit edit_puppetclass_path(puppetclass)
       click_link 'Smart Class Parameter'
+      page.find("#pill_#{smart_class_parameter_short.id}-#{smart_class_parameter_short.key}").hover
       assert_empty page.find("#pill_#{smart_class_parameter_short.id}-#{smart_class_parameter_short.key}")['data-original-title']
     end
   end

data/test/models/foreman_puppet/config_group_class_test.rb

@@ -4,6 +4,8 @@ module ForemanPuppet
   class ConfigGroupClassTest < ActiveSupport::TestCase
     should validate_presence_of(:config_group)
     should validate_presence_of(:puppetclass)
-    should validate_uniqueness_of(:config_group).scoped_to(:puppetclass_id)
+    # can not validate_uniqueness_of associations
+    # https://github.com/thoughtbot/shoulda-matchers/issues/814
+    # should validate_uniqueness_of(:config_group).scoped_to(:puppetclass_id)
   end
 end