foreman_patch 1.2.0.alpha1 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 900b05514ac7bb3e7cec9d95b0ad2b982feea0081dd73be23ab17041cb44c95d
-  data.tar.gz: ebdd75375aaf6acebd342f0f00e7be6658ec5399c9172f84b50263fe2b22573a
+  metadata.gz: 0e085e0af8a761e81fc5c3cddd51588babe0e0e6397d2f2448cbb7c346ef8b42
+  data.tar.gz: 752762b8b5a4f034e348500315e5a962ffd9e87b3875cc3943e4fbbeaad79a60
 SHA512:
-  metadata.gz: d01c259cd2d57f7e4febcac38b3d9161c5ae3bd9fa84df2ef3f8cb9443a79350b7f6cc007c47aab787478f5516a70661fdae4777e13e95f8e4f25b459da0b449
-  data.tar.gz: 78a7fd36dd08a76f613bbf839ebbff94d5e7e7d31766276ff3f1a4b42f4a2555a316cbf377a8ec6e63610914f51f37447f5b7446b987c29efb310a7fffc5dd7a
+  metadata.gz: 054e1ea317df4617f8c6748239c80401c45c3c61efb8f666e6495e7f502346bf612d55c9dca07f70ff5d3fafde7ec357e441dabe7721f67a566de965e28b33b3
+  data.tar.gz: 3c07b4f6f0d4b0fb154819a3f1f0c7e931bbe59beacfe4bdca42de9b3ca53b45a6864c5c855b011dc0d4947144e8ca58dbca4100c9a1db9b822010bca0a3d56e

data/app/lib/actions/foreman_patch/window/publish.rb

@@ -15,7 +15,7 @@ module Actions
 
           ticket.save
 
-          output.update(response: ticket.response)
+          output.update(response: ticket.to_h)
         end
 
         def window

data/app/services/foreman_patch/ticket/affected_items.rb

@@ -38,15 +38,36 @@ module ForemanPatch
       private
 
       def get_configuration_items(hosts)
+        ###
+        # This needs to be batched as too many hostnames will excede most server url limits
+        ###
         params = {
-          sysparm_query: "host_nameIN#{hosts.map(&:name).join(',')}",
           sysparm_exclude_reference_link: true,
           sysparm_fields: 'sys_id,host_name',
         }
 
-        get('/api/now/table/cmdb_ci_server', params)
+        uri = URI.join(Setting[:ticket_api_host], '/api/now/table/cmdb_ci_server')
 
-        response.nil? ? [] : response['result']
+        hosts.each_with_object([]) do |host, batches|
+          batches.push([]) if batches.empty?
+
+          batch = batches.last.push(host)
+
+          uri.query = URI.encode_www_form(params.merge({
+            sysparm_query: "host_nameIN#{batch.join(',')}",
+          }))
+
+          if uri.to_s.length > (Setting[:ticket_api_max_url_length] || 8000)
+            batch.pop
+            batches.push([host])
+          end
+        end.each_with_object([]) do |batch, items|
+          response = get(uri.path, params.merge({
+            sysparm_query: "host_nameIN#{batch.join(',')}",
+          }))
+
+          items.concat(response['result']) unless response.nil?
+        end
       end
 
       def get_affected_items
@@ -56,7 +77,7 @@ module ForemanPatch
           sysparm_fields: 'sys_id,task,ci_item',
         }
 
-        get('/api/now/table/task_ci', params)
+        response = get('/api/now/table/task_ci', params)
 
         response.nil? ? [] : response['result']
       end

data/app/services/foreman_patch/ticket/api.rb

@@ -1,18 +1,12 @@
 module ForemanPatch
   module Ticket
     module API
-      attr_reader :response, :errors
-
-      private
+      attr_reader :request
 
       def host
         Setting[:ticket_api_host]
       end
 
-      def url(path)
-        host + path
-      end
-
       def proxy
         return nil if Setting[:ticket_api_proxy].blank?
 
@@ -20,27 +14,27 @@ module ForemanPatch
       end
 
       def get(path, params = {})
-        request(:get, path, params)
+        send_request(:get, path, params)
       end
 
       def post(path, payload, params = {})
-        request(:post, path, params, payload)
+        send_request(:post, path, params, payload)
       end
 
       def put(path, payload, params = {})
-        request(:put, path, params, payload)
+        send_request(:put, path, params, payload)
       end
 
       def delete(path)
-        request(:delete, path)
+        send_request(:delete, path)
       end
 
-      def request(method, path, params = {}, payload = nil)
-        @response = nil
-
+      private 
+      
+      def send_request(method, path, params = {}, payload = nil)
         args = {
           method: method,
-          url: url(path),
+          url: URI.join(Setting[:ticket_api_host], path).to_s,
           headers: {
             accept: :json,
             content_type: :json,
@@ -53,15 +47,12 @@ module ForemanPatch
         args[:payload] = payload.to_json unless payload.nil?
         args[:proxy] = proxy
 
-        raw = RestClient::Request.execute(args)
-
-        @response = JSON.parse(raw)
+        JSON.parse(RestClient::Request.execute(args))
       rescue RestClient::ExceptionWithResponse => error
         Rails.logger.error(error.response)
       rescue => error
         Rails.logger.error(error)
       end
-
     end
   end
 end

data/app/services/foreman_patch/ticket/change_request.rb

@@ -5,42 +5,43 @@ module ForemanPatch
 
       attr_reader :window, :response, :affected_items
 
-      def self.publish(window)
-        ticket = Ticket.new(window)
-        ticket.save
-      end
-
       def initialize(window)
         @window = window
-        @hash = {}
+        @ticket = {}
         reload
       end
 
       def reload
         return if window.ticket_id.blank?
 
-        get(path)
-
-        @affected_items = AffectedItems.new(self)
+        response = get(path)
+        unless response.empty?
+          @ticket = response['result']
+        
+          @affected_items = AffectedItems.new(self)
+        end
 
-        ticket
+        @ticket
       end
 
       def save
+        response = {}
         if window.ticket_id.blank?
-          post(path, payload)
+          response = post(path, payload)
         else
-          put(path, payload)
+          response = put(path, payload)
         end
 
         unless response.empty?
+          @ticket = response['result']
+
+          window.update(ticket_id: id) if id != window.ticket_id
+
           @affected_items = AffectedItems.new(self)
           @affected_items.set(window.hosts)
         end
 
-        window.update(ticket_id: id)
-
-        ticket
+        @ticket
       end
 
       def payload
@@ -48,11 +49,11 @@ module ForemanPatch
       end
 
       def id
-        ticket.fetch(Setting[:ticket_id_field], window.ticket_id)
+        @ticket.fetch(Setting[:ticket_id_field], window.ticket_id)
       end
 
       def label
-        ticket.fetch(Setting[:ticket_label_field], window.name)
+        @ticket.fetch(Setting[:ticket_label_field], window.name)
       end
 
       def link
@@ -62,11 +63,15 @@ module ForemanPatch
       end
 
       def keys
-        ticket.keys
+        @ticket.keys
       end
 
       def [](key)
-        ticket[key]
+        @ticket[key]
+      end
+
+      def to_h
+        @ticket
       end
 
       class Jail < Safemode::Jail
@@ -75,12 +80,6 @@ module ForemanPatch
 
       private
 
-      def ticket
-        return {} if response.empty?
-
-        response['result']
-      end
-
       def path
         path = Setting[:ticket_api_path]
         path += "/#{window.ticket_id}" unless id.blank?

data/lib/foreman_patch/version.rb

@@ -1,3 +1,3 @@
 module ForemanPatch
-  VERSION = '1.2.0.alpha1'.freeze
+  VERSION = '1.2.1'.freeze
 end

data/public/assets/foreman_patch/foreman_patch.json

@@ -1 +1 @@
-{"files":{"foreman_patch/foreman_patch-ce5805a60c0d5f896f557ff5246e5a09172043004c850b39bea54e618df1c485.css":{"logical_path":"foreman_patch/foreman_patch.css","mtime":"2024-11-21T20:30:22+00:00","size":87,"digest":"d6fdcb3359ce0ca3edd9a493467bc366b5f2b52a0d3e2fd2b5d1dec121ef31ff","integrity":"sha256-1v3LM1nODKPt2aSTRnvDZrXytSoNPi/StdHewSHvMf8="},"foreman_patch/cycle_plans-e5667e178ba389908f5c815b24ec0ea77c340849d56bc39c5ce72bb626bd446a.scss":{"logical_path":"foreman_patch/cycle_plans.scss","mtime":"2024-11-21T20:30:22+00:00","size":106,"digest":"aa7bb2d36a98d83776b4dd9dd93431ba648b84a37478f93c445eb9bda0f84006","integrity":"sha256-qnuy02qY2Dd2tN2d2TQxumSLhKN0ePk8RF65vaD4QAY="},"foreman_patch/plan_edit_windows-e656ba411642a7f983b51958ab30ac49c056322d19295a603cff4d5e6c71c8ed.js":{"logical_path":"foreman_patch/plan_edit_windows.js","mtime":"2024-11-21T20:30:22+00:00","size":144,"digest":"be5de0eef57205a38f90eda24c8f8aed707f5d30e8a5abbc3ce9f198ea55a620","integrity":"sha256-vl3g7vVyBaOPkO2iTI+K7XB/XTDopau8POnxmOpVpiA="},"foreman_patch/foreman_patch-be2e2ba89548f4a490612e8a6cd1cdebc0473be89f8023a3df7612f05a75d301.css":{"logical_path":"foreman_patch/foreman_patch.css","mtime":"2024-11-21T20:42:30+00:00","size":87,"digest":"d6fdcb3359ce0ca3edd9a493467bc366b5f2b52a0d3e2fd2b5d1dec121ef31ff","integrity":"sha256-1v3LM1nODKPt2aSTRnvDZrXytSoNPi/StdHewSHvMf8="},"foreman_patch/cycle_plans-ff3d252119622a68828ff70f4a97328303963002237dbf850e92d6a706e93667.scss":{"logical_path":"foreman_patch/cycle_plans.scss","mtime":"2024-11-21T20:42:30+00:00","size":106,"digest":"aa7bb2d36a98d83776b4dd9dd93431ba648b84a37478f93c445eb9bda0f84006","integrity":"sha256-qnuy02qY2Dd2tN2d2TQxumSLhKN0ePk8RF65vaD4QAY="},"foreman_patch/plan_edit_windows-9ba20f84f3ecf2c4eb903acd57d30ee3e16f023a79db30bc614aa22f26442ce3.js":{"logical_path":"foreman_patch/plan_edit_windows.js","mtime":"2024-11-21T20:42:30+00:00","size":144,"digest":"be5de0eef57205a38f90eda24c8f8aed707f5d30e8a5abbc3ce9f198ea55a620","integrity":"sha256-vl3g7vVyBaOPkO2iTI+K7XB/XTDopau8POnxmOpVpiA="}},"assets":{"foreman_patch/foreman_patch.css":"foreman_patch/foreman_patch-be2e2ba89548f4a490612e8a6cd1cdebc0473be89f8023a3df7612f05a75d301.css","foreman_patch/cycle_plans.scss":"foreman_patch/cycle_plans-ff3d252119622a68828ff70f4a97328303963002237dbf850e92d6a706e93667.scss","foreman_patch/plan_edit_windows.js":"foreman_patch/plan_edit_windows-9ba20f84f3ecf2c4eb903acd57d30ee3e16f023a79db30bc614aa22f26442ce3.js"}}
+{"files":{"foreman_patch/cycle_plans-ff3d252119622a68828ff70f4a97328303963002237dbf850e92d6a706e93667.scss":{"logical_path":"foreman_patch/cycle_plans.scss","mtime":"2025-01-06T17:18:57+00:00","size":106,"digest":"aa7bb2d36a98d83776b4dd9dd93431ba648b84a37478f93c445eb9bda0f84006","integrity":"sha256-qnuy02qY2Dd2tN2d2TQxumSLhKN0ePk8RF65vaD4QAY="},"foreman_patch/foreman_patch-be2e2ba89548f4a490612e8a6cd1cdebc0473be89f8023a3df7612f05a75d301.css":{"logical_path":"foreman_patch/foreman_patch.css","mtime":"2025-01-06T17:18:57+00:00","size":87,"digest":"d6fdcb3359ce0ca3edd9a493467bc366b5f2b52a0d3e2fd2b5d1dec121ef31ff","integrity":"sha256-1v3LM1nODKPt2aSTRnvDZrXytSoNPi/StdHewSHvMf8="},"foreman_patch/plan_edit_windows-9ba20f84f3ecf2c4eb903acd57d30ee3e16f023a79db30bc614aa22f26442ce3.js":{"logical_path":"foreman_patch/plan_edit_windows.js","mtime":"2025-01-06T17:18:57+00:00","size":144,"digest":"be5de0eef57205a38f90eda24c8f8aed707f5d30e8a5abbc3ce9f198ea55a620","integrity":"sha256-vl3g7vVyBaOPkO2iTI+K7XB/XTDopau8POnxmOpVpiA="}},"assets":{"foreman_patch/cycle_plans.scss":"foreman_patch/cycle_plans-ff3d252119622a68828ff70f4a97328303963002237dbf850e92d6a706e93667.scss","foreman_patch/foreman_patch.css":"foreman_patch/foreman_patch-be2e2ba89548f4a490612e8a6cd1cdebc0473be89f8023a3df7612f05a75d301.css","foreman_patch/plan_edit_windows.js":"foreman_patch/plan_edit_windows-9ba20f84f3ecf2c4eb903acd57d30ee3e16f023a79db30bc614aa22f26442ce3.js"}}