foreman_openscap 8.0.2 → 9.0.0

data/webpack/routes/OvalPolicies/OvalPoliciesNew/__tests__/OvalPoliciesNew.fixtures.js

@@ -1,147 +0,0 @@
-import createOvalPolicy from '../../../../graphql/mutations/createOvalPolicy.gql';
-import hostgroupsQuery from '../../../../graphql/queries/hostgroups.gql';
-
-import { mockFactory, admin } from '../../../../testHelper';
-import { decodeId } from '../../../../helpers/globalIdHelper';
-import { ovalContents } from '../../../OvalContents/OvalContentsIndex/__tests__/OvalContentsIndex.fixtures';
-
-export const newPolicyName = 'test policy';
-export const newPolicyDescription = 'random description';
-export const newPolicyCronline = '5 5 5 5 5';
-export const newPolicyContentName = ovalContents.nodes[1].name;
-export const newPolicyContentId = ovalContents.nodes[1].id;
-const hostgroupId = 3;
-
-const createPolicyMockFactory = mockFactory(
-  'createOvalPolicy',
-  createOvalPolicy
-);
-const hostgroupsMockFactory = mockFactory('hostgroups', hostgroupsQuery);
-
-const foremanAnsiblePresent = {
-  id: 'foreman_ansible_present',
-  errors: null,
-  failMsg: null,
-  result: 'pass',
-};
-const rolePresent = {
-  id: 'foreman_scap_client_role_present',
-  errors: null,
-  failMsg: null,
-  result: 'pass',
-};
-const roleVarsPresent = {
-  id: 'foreman_scap_client_vars_present',
-  errors: null,
-  failMsg: null,
-  result: 'pass',
-};
-const serverVarOverriden = {
-  id: 'foreman_scap_client_server_overriden',
-  errors: null,
-  failMsg: null,
-  result: 'pass',
-};
-const portVarOverriden = {
-  id: 'foreman_scap_client_port_overriden',
-  errors: null,
-  failMsg: null,
-  result: 'pass',
-};
-const policiesVarOverriden = {
-  id: 'foreman_scap_client_policies_overriden',
-  errors: null,
-  failMsg: null,
-  result: 'pass',
-};
-const policyErrors = {
-  id: 'oval_policy_errors',
-  errors: { name: 'has already been taken' },
-  failMsg: null,
-  result: 'fail',
-};
-export const hgWithoutProxy = {
-  id: 'hostgroups_without_proxy',
-  errors: null,
-  failMsg: 'Assign openscap_proxy to first hostgroup before proceeding.',
-  result: 'fail',
-};
-export const roleAbsent = {
-  id: 'foreman_scap_client_role_present',
-  errors: null,
-  failMsg:
-    'theforeman.foreman_scap_client Ansible Role not found, please import it before running this action again.',
-  result: 'fail',
-};
-
-const varChecks = [
-  roleVarsPresent,
-  serverVarOverriden,
-  portVarOverriden,
-  policiesVarOverriden,
-];
-const checkCollectionPass = [foremanAnsiblePresent, rolePresent, ...varChecks];
-const checkCollectionPreconditionFail = [
-  foremanAnsiblePresent,
-  roleAbsent,
-  ...varChecks.map(check => ({ ...check, result: 'skip' })),
-];
-const ovalPolicy = {
-  name: newPolicyName,
-  id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsUG9saWN5LTcw',
-  period: 'custom',
-  cronLine: newPolicyCronline,
-  hostgroups: {
-    nodes: [],
-  },
-};
-
-const policyCreateSuccess = {
-  checkCollection: checkCollectionPass,
-  ovalPolicy,
-};
-
-const baseVariables = {
-  name: newPolicyName,
-  description: '',
-  ovalContentId: decodeId(newPolicyContentId),
-  cronLine: newPolicyCronline,
-  hostgroupIds: [],
-  period: 'custom',
-};
-
-export const firstHg = {
-  id: 'MDE6SG9zdGdyb3VwLTM=',
-  name: 'first hostgroup',
-};
-
-const successVariables = {
-  ...baseVariables,
-  description: newPolicyDescription,
-};
-
-export const policySuccessMock = createPolicyMockFactory(
-  successVariables,
-  policyCreateSuccess
-);
-
-export const policyValidationMock = createPolicyMockFactory(baseVariables, {
-  checkCollection: [...checkCollectionPass, policyErrors],
-  ovalPolicy,
-});
-
-export const policyPreconditionMock = createPolicyMockFactory(baseVariables, {
-  checkCollection: checkCollectionPreconditionFail,
-  ovalPolicy,
-});
-
-export const policyInvalidHgMock = createPolicyMockFactory(
-  { ...baseVariables, hostgroupIds: [hostgroupId] },
-  { checkCollection: [...checkCollectionPass, hgWithoutProxy], ovalPolicy }
-);
-
-export const hostgroupsMock = hostgroupsMockFactory(
-  { search: `name ~ first` },
-  { totalCount: 2, nodes: [firstHg] },
-  { currentUser: admin }
-);

data/webpack/routes/OvalPolicies/OvalPoliciesNew/__tests__/OvalPoliciesNew.test.js

@@ -1,172 +0,0 @@
-import React from 'react';
-import { render, screen } from '@testing-library/react';
-import '@testing-library/jest-dom';
-import userEvent from '@testing-library/user-event';
-
-import OvalPoliciesNew from '../';
-import { ovalPoliciesPath } from '../../../../helpers/pathsHelper';
-
-import { unpagedMocks as ovalContentMocks } from '../../../OvalContents/OvalContentsIndex/__tests__/OvalContentsIndex.fixtures';
-
-import {
-  withMockedProvider,
-  wait,
-  withRouter,
-  withRedux,
-} from '../../../../testHelper';
-
-import {
-  newPolicyName,
-  newPolicyDescription,
-  newPolicyCronline,
-  newPolicyContentName,
-  policySuccessMock,
-  policyValidationMock,
-  policyPreconditionMock,
-  policyInvalidHgMock,
-  hostgroupsMock,
-  firstHg,
-  roleAbsent as roleAbsentCheck,
-  hgWithoutProxy as withoutProxyCheck,
-} from './OvalPoliciesNew.fixtures';
-
-import * as toasts from '../../../../helpers/toastHelper';
-
-const TestComponent = withRouter(
-  withRedux(withMockedProvider(OvalPoliciesNew))
-);
-
-describe('OvalPoliciesNew', () => {
-  it('should create new OVAL policy', async () => {
-    const showToast = jest.fn();
-    jest.spyOn(toasts, 'showToast').mockImplementation(() => showToast);
-    const pushMock = jest.fn();
-
-    render(
-      <TestComponent
-        mocks={ovalContentMocks.concat(policySuccessMock)}
-        history={{
-          push: pushMock,
-        }}
-      />
-    );
-    expect(screen.getByText('Loading')).toBeInTheDocument();
-    await wait();
-    const submitBtn = screen.getByRole('button', { name: 'submit' });
-    expect(submitBtn).toBeDisabled();
-    userEvent.type(screen.getByLabelText(/name/), newPolicyName);
-    await wait();
-    expect(submitBtn).toBeDisabled();
-    userEvent.type(screen.getByLabelText(/cronLine/), 'foo');
-    userEvent.type(screen.getByLabelText(/description/), newPolicyDescription);
-    userEvent.selectOptions(
-      screen.getByLabelText(/ovalContentId/),
-      newPolicyContentName
-    );
-    await wait();
-    expect(screen.getByText('is not a valid cronline')).toBeInTheDocument();
-    expect(submitBtn).toBeDisabled();
-    userEvent.clear(screen.getByLabelText(/cronLine/));
-    userEvent.type(screen.getByLabelText(/cronLine/), newPolicyCronline);
-    await wait();
-    expect(
-      screen.queryByText('is not a valid cronline')
-    ).not.toBeInTheDocument();
-    expect(submitBtn).not.toBeDisabled();
-    userEvent.click(submitBtn);
-    await wait(2);
-    expect(pushMock).toHaveBeenCalledWith(ovalPoliciesPath);
-    expect(showToast).toHaveBeenCalledWith({
-      type: 'success',
-      message: 'OVAL Policy succesfully created.',
-    });
-  });
-  it('should not create new policy on validation error', async () => {
-    const showToast = jest.fn();
-    jest.spyOn(toasts, 'showToast').mockImplementation(() => showToast);
-    const pushMock = jest.fn();
-
-    render(
-      <TestComponent
-        mocks={ovalContentMocks.concat(policyValidationMock)}
-        history={{
-          push: pushMock,
-        }}
-      />
-    );
-    await wait();
-    userEvent.type(screen.getByLabelText(/name/), newPolicyName);
-    userEvent.type(screen.getByLabelText(/cronLine/), newPolicyCronline);
-    userEvent.selectOptions(
-      screen.getByLabelText(/ovalContentId/),
-      newPolicyContentName
-    );
-    await wait();
-    userEvent.click(screen.getByRole('button', { name: 'submit' }));
-    await wait(2);
-    expect(pushMock).not.toHaveBeenCalled();
-    expect(showToast).not.toHaveBeenCalled();
-    expect(screen.getByText('has already been taken')).toBeInTheDocument();
-  });
-  it('should not create policy on preconditions error', async () => {
-    const showToast = jest.fn();
-    jest.spyOn(toasts, 'showToast').mockImplementation(() => showToast);
-    const pushMock = jest.fn();
-
-    render(
-      <TestComponent
-        mocks={ovalContentMocks.concat(policyPreconditionMock)}
-        history={{
-          push: pushMock,
-        }}
-      />
-    );
-    await wait();
-    userEvent.type(screen.getByLabelText(/name/), newPolicyName);
-    userEvent.type(screen.getByLabelText(/cronLine/), newPolicyCronline);
-    userEvent.selectOptions(
-      screen.getByLabelText(/ovalContentId/),
-      newPolicyContentName
-    );
-    await wait();
-    userEvent.click(screen.getByRole('button', { name: 'submit' }));
-    await wait(2);
-    await wait();
-    expect(pushMock).not.toHaveBeenCalled();
-    expect(showToast).toHaveBeenCalledWith({
-      type: 'error',
-      message: roleAbsentCheck.failMsg,
-    });
-  });
-  it('should show hostgroup errros', async () => {
-    const showToast = jest.fn();
-    jest.spyOn(toasts, 'showToast').mockImplementation(() => showToast);
-    const pushMock = jest.fn();
-
-    render(
-      <TestComponent
-        mocks={ovalContentMocks
-          .concat(policyInvalidHgMock)
-          .concat(hostgroupsMock)}
-        history={{
-          push: pushMock,
-        }}
-      />
-    );
-    await wait();
-    userEvent.type(screen.getByLabelText(/name/), newPolicyName);
-    userEvent.type(screen.getByLabelText(/cronLine/), newPolicyCronline);
-    userEvent.selectOptions(
-      screen.getByLabelText(/ovalContentId/),
-      newPolicyContentName
-    );
-    userEvent.type(screen.getByLabelText(/hostgroup/), 'first');
-    await wait(500);
-    userEvent.click(screen.getByText(firstHg.name));
-    await wait();
-    userEvent.click(screen.getByRole('button', { name: 'submit' }));
-    await wait(2);
-    expect(pushMock).not.toHaveBeenCalled();
-    expect(screen.getByText(withoutProxyCheck.failMsg)).toBeInTheDocument();
-  });
-});

data/webpack/routes/OvalPolicies/OvalPoliciesNew/index.js

@@ -1,11 +0,0 @@
-import React from 'react';
-import { useDispatch } from 'react-redux';
-
-import { showToast } from '../../../helpers/toastHelper';
-import OvalPoliciesNew from './OvalPoliciesNew';
-
-const WrappedOvalPoliciesNew = props => (
-  <OvalPoliciesNew {...props} showToast={showToast(useDispatch())} />
-);
-
-export default WrappedOvalPoliciesNew;

data/webpack/routes/OvalPolicies/OvalPoliciesShow/CvesTab.js

@@ -1,49 +0,0 @@
-import React from 'react';
-import PropTypes from 'prop-types';
-import { translate as __ } from 'foremanReact/common/I18n';
-
-import { useQuery } from '@apollo/client';
-
-import CvesTable from './CvesTable';
-
-import cves from '../../../graphql/queries/cves.gql';
-import {
-  useParamsToVars,
-  useCurrentPagination,
-} from '../../../helpers/pageParamsHelper';
-
-const CvesTab = props => {
-  const useFetchFn = componentProps =>
-    useQuery(cves, {
-      variables: {
-        search: `oval_policy_id = ${componentProps.match.params.id}`,
-        ...useParamsToVars(componentProps.history),
-      },
-    });
-
-  const renameData = data => ({
-    cves: data.cves.nodes,
-    totalCount: data.cves.totalCount,
-  });
-
-  const pagination = useCurrentPagination(props.history);
-
-  return (
-    <CvesTable
-      {...props}
-      fetchFn={useFetchFn}
-      renameData={renameData}
-      resultPath="cves.nodes"
-      pagination={pagination}
-      emptyStateTitle={__('No CVEs found.')}
-      permissions={['view_oval_policies']}
-    />
-  );
-};
-
-CvesTab.propTypes = {
-  match: PropTypes.object.isRequired,
-  history: PropTypes.object.isRequired,
-};
-
-export default CvesTab;

data/webpack/routes/OvalPolicies/OvalPoliciesShow/CvesTable.js

@@ -1,63 +0,0 @@
-import React from 'react';
-import PropTypes from 'prop-types';
-import { translate as __ } from 'foremanReact/common/I18n';
-
-import { linkCell } from '../../../helpers/tableHelper';
-import { hostsPath } from '../../../helpers/pathsHelper';
-import { decodeModelId } from '../../../helpers/globalIdHelper';
-import { addSearch } from '../../../helpers/pageParamsHelper';
-
-import withLoading from '../../../components/withLoading';
-import IndexTable from '../../../components/IndexTable';
-
-const CvesTable = props => {
-  const columns = [
-    { title: __('Ref Id') },
-    { title: __('Has Errata?') },
-    { title: __('Hosts Count') },
-  ];
-
-  const cveRefId = cve => (
-    <a href={cve.refUrl} rel="noopener noreferrer" target="_blank">
-      {cve.refId}
-    </a>
-  );
-
-  const hostCount = cve =>
-    linkCell(
-      addSearch(hostsPath, { search: `cve_id = ${decodeModelId(cve)}` }),
-      cve.hosts.nodes.length
-    );
-
-  const rows = props.cves.map(cve => ({
-    cells: [
-      { title: cveRefId(cve) },
-      { title: cve.hasErrata ? __('Yes') : __('No') },
-      { title: hostCount(cve) },
-    ],
-    cve,
-  }));
-
-  const actions = [];
-
-  return (
-    <IndexTable
-      columns={columns}
-      rows={rows}
-      actions={actions}
-      pagination={props.pagination}
-      totalCount={props.totalCount}
-      history={props.history}
-      ariaTableLabel={__('Table of CVEs for OVAL policy')}
-    />
-  );
-};
-
-CvesTable.propTypes = {
-  cves: PropTypes.array.isRequired,
-  pagination: PropTypes.object.isRequired,
-  totalCount: PropTypes.number.isRequired,
-  history: PropTypes.object.isRequired,
-};
-
-export default withLoading(CvesTable);

data/webpack/routes/OvalPolicies/OvalPoliciesShow/DetailsTab.js

@@ -1,87 +0,0 @@
-import React from 'react';
-import PropTypes from 'prop-types';
-import { useMutation } from '@apollo/client';
-
-import {
-  TextList,
-  TextContent,
-  TextArea,
-  TextListItem,
-  TextListVariants,
-  TextListItemVariants,
-  TextInput,
-} from '@patternfly/react-core';
-
-import { translate as __ } from 'foremanReact/common/I18n';
-
-import EditableInput from '../../../components/EditableInput';
-
-import { onAttrUpdate, policySchedule } from './OvalPoliciesShowHelper';
-import updateOvalPolicyMutation from '../../../graphql/mutations/updateOvalPolicy.gql';
-
-const DetailsTab = props => {
-  const { policy, showToast } = props;
-
-  const [callMutation] = useMutation(updateOvalPolicyMutation);
-
-  return (
-    <TextContent className="pf-u-pt-md">
-      <TextList component={TextListVariants.dl}>
-        <TextListItem component={TextListItemVariants.dt}>
-          {__('Name')}
-        </TextListItem>
-        <TextListItem
-          aria-label="label text value"
-          component={TextListItemVariants.dd}
-          className="foreman-spaced-list"
-        >
-          <EditableInput
-            value={policy.name}
-            onConfirm={onAttrUpdate('name', policy, callMutation, showToast)}
-            component={TextInput}
-            attrName="name"
-            allowed={policy.meta.canEdit}
-          />
-        </TextListItem>
-        <TextListItem component={TextListItemVariants.dt}>
-          {__('Period')}
-        </TextListItem>
-        <TextListItem
-          aria-label="label text value"
-          component={TextListItemVariants.dd}
-          className="foreman-spaced-list"
-        >
-          {policySchedule(policy)}
-        </TextListItem>
-        <TextListItem component={TextListItemVariants.dt}>
-          {__('Description')}
-        </TextListItem>
-        <TextListItem
-          aria-label="label text value"
-          component={TextListItemVariants.dd}
-          className="foreman-spaced-list"
-        >
-          <EditableInput
-            value={policy.description}
-            onConfirm={onAttrUpdate(
-              'description',
-              policy,
-              callMutation,
-              showToast
-            )}
-            component={TextArea}
-            attrName="description"
-            allowed={policy.meta.canEdit}
-          />
-        </TextListItem>
-      </TextList>
-    </TextContent>
-  );
-};
-
-DetailsTab.propTypes = {
-  policy: PropTypes.object.isRequired,
-  showToast: PropTypes.func.isRequired,
-};
-
-export default DetailsTab;

data/webpack/routes/OvalPolicies/OvalPoliciesShow/HostgroupsTab.js

@@ -1,49 +0,0 @@
-import React from 'react';
-import PropTypes from 'prop-types';
-import { translate as __ } from 'foremanReact/common/I18n';
-
-import { useQuery } from '@apollo/client';
-
-import HostgroupsTable from './HostgroupsTable';
-
-import hostgroups from '../../../graphql/queries/hostgroups.gql';
-import {
-  useParamsToVars,
-  useCurrentPagination,
-} from '../../../helpers/pageParamsHelper';
-
-const HostgroupsTab = props => {
-  const useFetchFn = componentProps =>
-    useQuery(hostgroups, {
-      variables: {
-        search: `oval_policy_id = ${componentProps.match.params.id}`,
-        ...useParamsToVars(componentProps.history),
-      },
-    });
-
-  const renameData = data => ({
-    hostgroups: data.hostgroups.nodes,
-    totalCount: data.hostgroups.totalCount,
-  });
-
-  const pagination = useCurrentPagination(props.history);
-
-  return (
-    <HostgroupsTable
-      {...props}
-      fetchFn={useFetchFn}
-      renameData={renameData}
-      resultPath="hostgroups.nodes"
-      pagination={pagination}
-      emptyStateTitle={__('No Hostgroups found.')}
-      permissions={['view_hostgroups']}
-    />
-  );
-};
-
-HostgroupsTab.propTypes = {
-  match: PropTypes.object.isRequired,
-  history: PropTypes.object.isRequired,
-};
-
-export default HostgroupsTab;

data/webpack/routes/OvalPolicies/OvalPoliciesShow/HostgroupsTable.js

@@ -1,38 +0,0 @@
-import React from 'react';
-import PropTypes from 'prop-types';
-import { translate as __ } from 'foremanReact/common/I18n';
-
-import withLoading from '../../../components/withLoading';
-import IndexTable from '../../../components/IndexTable';
-
-const CvesTable = props => {
-  const columns = [{ title: __('Name') }];
-
-  const rows = props.hostgroups.map(hostgroup => ({
-    cells: [{ title: hostgroup.name }],
-    hostgroup,
-  }));
-
-  const actions = [];
-
-  return (
-    <IndexTable
-      columns={columns}
-      rows={rows}
-      actions={actions}
-      pagination={props.pagination}
-      totalCount={props.totalCount}
-      history={props.history}
-      ariaTableLabel={__('Table of hostgroups for OVAL policy')}
-    />
-  );
-};
-
-CvesTable.propTypes = {
-  hostgroups: PropTypes.array.isRequired,
-  pagination: PropTypes.object.isRequired,
-  totalCount: PropTypes.number.isRequired,
-  history: PropTypes.object.isRequired,
-};
-
-export default withLoading(CvesTable);

data/webpack/routes/OvalPolicies/OvalPoliciesShow/OvalPoliciesShow.js

@@ -1,82 +0,0 @@
-import React from 'react';
-import PropTypes from 'prop-types';
-import { Link } from 'react-router-dom';
-import { Helmet } from 'react-helmet';
-import { translate as __ } from 'foremanReact/common/I18n';
-import {
-  Button,
-  Grid,
-  GridItem,
-  Text,
-  TextVariants,
-  Tabs,
-  Tab,
-  TabTitleText,
-} from '@patternfly/react-core';
-
-import withLoading from '../../../components/withLoading';
-import CvesTab from './CvesTab';
-import HostgroupsTab from './HostgroupsTab';
-import DetailsTab from './DetailsTab';
-
-import { newJobFormPath } from './OvalPoliciesShowHelper';
-import { resolvePath } from '../../../helpers/pathsHelper';
-
-const OvalPoliciesShow = props => {
-  const { policy, match, history } = props;
-  const activeTab = match.params.tab ? match.params.tab : 'details';
-
-  const handleTabSelect = (event, value) => {
-    history.push(
-      resolvePath(match.path, { ':id': match.params.id, ':tab?': value })
-    );
-  };
-
-  return (
-    <React.Fragment>
-      <Helmet>
-        <title>{`${policy.name} | OVAL Policy`}</title>
-      </Helmet>
-      <Grid className="scap-page-grid">
-        <GridItem span={10}>
-          <Text component={TextVariants.h1}>{policy.name}</Text>
-        </GridItem>
-        <GridItem span={2}>
-          <Link to={newJobFormPath(policy, match.params.id)}>
-            <Button variant="secondary">{__('Scan All Hostgroups')}</Button>
-          </Link>
-        </GridItem>
-        <GridItem span={12}>
-          <Tabs mountOnEnter activeKey={activeTab} onSelect={handleTabSelect}>
-            <Tab
-              eventKey="details"
-              title={<TabTitleText>{__('Details')}</TabTitleText>}
-            >
-              <DetailsTab {...props} />
-            </Tab>
-            <Tab
-              eventKey="cves"
-              title={<TabTitleText>{__('CVEs')}</TabTitleText>}
-            >
-              <CvesTab {...props} />
-            </Tab>
-            <Tab
-              eventKey="hostgroups"
-              title={<TabTitleText>{__('Hostgroups')}</TabTitleText>}
-            >
-              <HostgroupsTab {...props} />
-            </Tab>
-          </Tabs>
-        </GridItem>
-      </Grid>
-    </React.Fragment>
-  );
-};
-
-OvalPoliciesShow.propTypes = {
-  match: PropTypes.object.isRequired,
-  history: PropTypes.object.isRequired,
-  policy: PropTypes.object.isRequired,
-};
-
-export default withLoading(OvalPoliciesShow);