foreman_openscap 4.3.2 → 5.2.0

data/webpack/helpers/permissionsHelper.js

@@ -0,0 +1,42 @@
+import { translate as __, sprintf } from 'foremanReact/common/I18n';
+
+export const permissionCheck = (user, permissionsRequired) => {
+  if (permissionsRequired.length === 0) {
+    return { allowed: true };
+  }
+
+  if (!user) {
+    throw new Error(
+      'No user data when loading the page - cannot determine if current user is allowed to view the page.'
+    );
+  }
+
+  if (user.admin) {
+    return { allowed: true };
+  }
+
+  const permList = permissionsRequired.reduce((memo, item) => {
+    const found = user.permissions.nodes.find(
+      permission => permission.name === item
+    );
+    memo.push({ name: item, present: !!found });
+    return memo;
+  }, []);
+
+  if (permList.reduce((memo, item) => memo && item.present, true)) {
+    return { allowed: true, permissions: permList };
+  }
+
+  return { allowed: false, permissions: permList };
+};
+
+export const permissionDeniedMsg = permissions => {
+  let msg = __('You are not authorized to view the page. ');
+  if (permissions?.length > 0) {
+    msg += sprintf(
+      __('Request the following permissions from administrator: %s.'),
+      permissions.join(', ')
+    );
+  }
+  return msg;
+};

data/webpack/helpers/toastHelper.js

@@ -0,0 +1,3 @@
+import { addToast } from 'foremanReact/components/ToastsList';
+
+export const showToast = dispatch => toast => dispatch(addToast(toast));

data/webpack/helpers/toastsHelper.js

@@ -0,0 +1,3 @@
+import { addToast } from 'foremanReact/redux/actions/toasts';
+
+export const showToast = dispatch => toast => dispatch(addToast(toast));

data/webpack/routes/OvalContents/OvalContentsIndex/OvalContentsIndex.js

@@ -4,12 +4,17 @@ import { useQuery } from '@apollo/client';
 import { translate as __ } from 'foremanReact/common/I18n';
 
 import IndexLayout from '../../../components/IndexLayout';
+import LinkButton from '../../../components/LinkButton';
 import OvalContentsTable from './OvalContentsTable';
+import { ovalContentsNewPath } from '../../../helpers/pathsHelper';
 import {
   useParamsToVars,
   useCurrentPagination,
 } from '../../../helpers/pageParamsHelper';
+
+import { submitDelete, prepareMutation } from '../../../helpers/mutationHelper';
 import ovalContentsQuery from '../../../graphql/queries/ovalContents.gql';
+import deleteOvalContentMutation from '../../../graphql/mutations/deleteOvalContent.gql';
 
 const OvalContentsIndex = props => {
   const useFetchFn = componentProps =>
@@ -33,6 +38,25 @@ const OvalContentsIndex = props => {
         resultPath="ovalContents.nodes"
         pagination={pagination}
         emptyStateTitle={__('No OVAL Contents found.')}
+        permissions={['view_oval_contents']}
+        confirmDeleteTitle={__('Delete OVAL Content')}
+        submitDelete={submitDelete}
+        prepareMutation={prepareMutation(
+          props.history,
+          props.showToast,
+          ovalContentsQuery,
+          'deleteOvalContent',
+          __('OVAL Content successfully deleted.'),
+          deleteOvalContentMutation,
+          __('OVAL Content')
+        )}
+        primaryButton={
+          <LinkButton
+            path={ovalContentsNewPath}
+            btnText={__('Create OVAL Content')}
+          />
+        }
+        shouldRefetch={props.location?.state?.refreshOvalContents}
       />
     </IndexLayout>
   );
@@ -40,6 +64,8 @@ const OvalContentsIndex = props => {
 
 OvalContentsIndex.propTypes = {
   history: PropTypes.object.isRequired,
+  showToast: PropTypes.func.isRequired,
+  location: PropTypes.object.isRequired,
 };
 
 export default OvalContentsIndex;

data/webpack/routes/OvalContents/OvalContentsIndex/OvalContentsTable.js

@@ -1,29 +1,73 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import { translate as __ } from 'foremanReact/common/I18n';
+import { Button } from '@patternfly/react-core';
 
 import withLoading from '../../../components/withLoading';
+import withDeleteModal from '../../../components/withDeleteModal';
 import IndexTable from '../../../components/IndexTable';
+import {
+  ovalContentsNewPath,
+  ovalContentsPath,
+  modelPath,
+} from '../../../helpers/pathsHelper';
+
+import { linkCell } from '../../../helpers/tableHelper';
 
 const OvalContentsTable = props => {
-  const columns = [{ title: __('Name') }];
+  const columns = [
+    { title: __('Name') },
+    { title: __('URL') },
+    { title: __('Original File Name') },
+  ];
 
   const rows = props.ovalContents.map(ovalContent => ({
-    cells: [{ title: ovalContent.name }],
+    cells: [
+      {
+        title: linkCell(
+          modelPath(ovalContentsPath, ovalContent),
+          ovalContent.name
+        ),
+      },
+      { title: ovalContent.url || '' },
+      { title: ovalContent.originalFilename || '' },
+    ],
     ovalContent,
   }));
 
-  const actions = [];
+  const actionResolver = (rowData, rest) => {
+    const actions = [];
+    if (rowData.ovalContent.meta.canDestroy) {
+      actions.push({
+        title: __('Delete OVAL Content'),
+        onClick: (event, rowId, rData, extra) => {
+          props.toggleModal(rData.ovalContent);
+        },
+      });
+    }
+    return actions;
+  };
+
+  const createBtn = (
+    <Button
+      onClick={() => props.history.push(ovalContentsNewPath)}
+      variant="primary"
+      aria-label="create_oval_content"
+    >
+      {__('Create OVAL Content')}
+    </Button>
+  );
 
   return (
     <IndexTable
       columns={columns}
       rows={rows}
-      actions={actions}
+      actionResolver={actionResolver}
       pagination={props.pagination}
       totalCount={props.totalCount}
       history={props.history}
       ariaTableLabel={__('OVAL Contents table')}
+      toolbarBtns={createBtn}
     />
   );
 };
@@ -33,6 +77,7 @@ OvalContentsTable.propTypes = {
   pagination: PropTypes.object.isRequired,
   totalCount: PropTypes.number.isRequired,
   history: PropTypes.object.isRequired,
+  toggleModal: PropTypes.func.isRequired,
 };
 
-export default withLoading(OvalContentsTable);
+export default withLoading(withDeleteModal(OvalContentsTable));

data/webpack/routes/OvalContents/OvalContentsIndex/__tests__/OvalContentsDestroy.fixtures.js

@@ -0,0 +1,105 @@
+import { admin } from '../../../../testHelper';
+
+import ovalContentsQuery from '../../../../graphql/queries/ovalContents.gql';
+import deleteOvalContent from '../../../../graphql/mutations/deleteOvalContent.gql';
+
+export const firstCall = {
+  data: {
+    ovalContents: {
+      totalCount: 5,
+      nodes: [
+        {
+          id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsQ29udGVudC0z',
+          name: 'ansible OVAL content',
+          url:
+            'http://oval-content-source/security/data/oval/ansible-2-including-unpatched.oval.xml.bz2',
+          originalFilename: '',
+          meta: { canDestroy: true },
+        },
+        {
+          id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsQ29udGVudC00',
+          name: 'dotnet OVAL content',
+          url:
+            'http://oval-content-source/security/data/oval/dotnet-2.2.oval.xml.bz2',
+          originalFilename: '',
+          meta: { canDestroy: true },
+        },
+      ],
+    },
+    currentUser: admin,
+  },
+};
+
+export const secondCall = {
+  data: {
+    ovalContents: {
+      totalCount: 4,
+      nodes: [
+        {
+          id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsQ29udGVudC00',
+          name: 'dotnet OVAL content',
+          url:
+            'http://oval-content-source/security/data/oval/dotnet-2.2.oval.xml.bz2',
+          originalFilename: '',
+          meta: { canDestroy: true },
+        },
+        {
+          id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsQ29udGVudC03',
+          name: 'jboss OVAL content',
+          url: '',
+          originalFilename: 'jboss.oval.xml.bz2',
+          meta: { canDestroy: true },
+        },
+      ],
+    },
+    currentUser: admin,
+  },
+};
+
+export const deleteMockFactory = (first, second, errors = null) => {
+  let called = false;
+
+  const deleteMocks = [
+    {
+      request: {
+        query: deleteOvalContent,
+        variables: {
+          id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsQ29udGVudC0z',
+        },
+      },
+      result: {
+        data: {
+          deleteOvalContent: {
+            id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsQ29udGVudC0z',
+            errors,
+          },
+        },
+      },
+    },
+    {
+      request: {
+        query: ovalContentsQuery,
+        variables: {
+          first: 2,
+          last: 2,
+        },
+      },
+      newData: () => {
+        if (called && !errors) {
+          return second;
+        } else if (called && errors) {
+          return first;
+        }
+        called = true;
+        return first;
+      },
+    },
+  ];
+  return deleteMocks;
+};
+
+export const pageParamsHistoryMock = {
+  location: {
+    search: '?page=1&perPage=2',
+  },
+};

data/webpack/routes/OvalContents/OvalContentsIndex/__tests__/OvalContentsDestroy.test.js

@@ -0,0 +1,124 @@
+import React from 'react';
+import { render, screen, waitFor } from '@testing-library/react';
+import '@testing-library/jest-dom';
+import userEvent from '@testing-library/user-event';
+
+import OvalContentsIndex from '../OvalContentsIndex';
+import {
+  withRouter,
+  withRedux,
+  withMockedProvider,
+  tick,
+  historyMock,
+} from '../../../../testHelper';
+import { mocks, noDeleteMocks } from './OvalContentsIndex.fixtures';
+import {
+  firstCall,
+  secondCall,
+  deleteMockFactory,
+  pageParamsHistoryMock,
+} from './OvalContentsDestroy.fixtures';
+
+const TestComponent = withRouter(
+  withRedux(withMockedProvider(OvalContentsIndex))
+);
+
+describe('OvalContentsIndex', () => {
+  it('should open and close delete modal', async () => {
+    render(
+      <TestComponent
+        history={historyMock}
+        location={{}}
+        mocks={mocks}
+        showToast={jest.fn()}
+      />
+    );
+    await waitFor(tick);
+    expect(screen.getByText('ansible OVAL content')).toBeInTheDocument();
+    userEvent.click(screen.getAllByRole('button', { name: 'Actions' })[0]);
+    userEvent.click(screen.getByText('Delete OVAL Content'));
+    await waitFor(tick);
+    expect(
+      screen.getByText('Are you sure you want to delete ansible OVAL content?')
+    ).toBeInTheDocument();
+    userEvent.click(screen.getByText('Cancel'));
+    await waitFor(tick);
+    expect(
+      screen.queryByText(
+        'Are you sure you want to delete ansible OVAL content?'
+      )
+    ).not.toBeInTheDocument();
+    expect(screen.getByText('ansible OVAL content')).toBeInTheDocument();
+  });
+  it('should delete OVAL content', async () => {
+    const mocked = deleteMockFactory(firstCall, secondCall);
+    const showToast = jest.fn();
+    render(
+      <TestComponent
+        history={pageParamsHistoryMock}
+        location={{}}
+        mocks={mocked}
+        showToast={showToast}
+      />
+    );
+    await waitFor(tick);
+    expect(screen.getByText('ansible OVAL content')).toBeInTheDocument();
+    expect(screen.queryByText('jboss OVAL content')).not.toBeInTheDocument();
+    userEvent.click(screen.getAllByRole('button', { name: 'Actions' })[0]);
+    userEvent.click(screen.getByText('Delete OVAL Content'));
+    await waitFor(tick);
+    userEvent.click(screen.getByText('Confirm'));
+    await waitFor(tick);
+    expect(showToast).toHaveBeenCalledWith({
+      type: 'success',
+      message: 'OVAL Content successfully deleted.',
+    });
+    await waitFor(tick);
+    expect(screen.queryByText('ansible OVAL content')).not.toBeInTheDocument();
+    expect(screen.getByText('jboss OVAL content')).toBeInTheDocument();
+  });
+  it('should show error when deleting OVAL content fails', async () => {
+    const showToast = jest.fn();
+    render(
+      <TestComponent
+        history={pageParamsHistoryMock}
+        location={{}}
+        mocks={deleteMockFactory(firstCall, secondCall, [
+          { message: 'is used by first policy', path: ['base'] },
+          { message: 'is used by second policy', path: ['base'] },
+        ])}
+        showToast={showToast}
+      />
+    );
+    await waitFor(tick);
+    expect(screen.getByText('ansible OVAL content')).toBeInTheDocument();
+    expect(screen.queryByText('jboss OVAL content')).not.toBeInTheDocument();
+    userEvent.click(screen.getAllByRole('button', { name: 'Actions' })[0]);
+    userEvent.click(screen.getByText('Delete OVAL Content'));
+    await waitFor(tick);
+    userEvent.click(screen.getByText('Confirm'));
+    await waitFor(tick);
+    expect(showToast).toHaveBeenCalledWith({
+      type: 'error',
+      message:
+        'There was a following error when deleting OVAL Content: is used by first policy, is used by second policy',
+    });
+    expect(screen.getByText('ansible OVAL content')).toBeInTheDocument();
+    expect(screen.queryByText('jboss OVAL content')).not.toBeInTheDocument();
+  });
+  it('should not show delete button when user does not have delete permissions', async () => {
+    render(
+      <TestComponent
+        history={historyMock}
+        location={{}}
+        mocks={noDeleteMocks}
+        showToast={jest.fn()}
+      />
+    );
+    await waitFor(tick);
+    expect(screen.getByText('ansible OVAL content')).toBeInTheDocument();
+    expect(
+      screen.queryByRole('button', { name: 'Actions' })
+    ).not.toBeInTheDocument();
+  });
+});

data/webpack/routes/OvalContents/OvalContentsIndex/__tests__/OvalContentsIndex.fixtures.js

@@ -1,98 +1,119 @@
 import ovalContentsQuery from '../../../../graphql/queries/ovalContents.gql';
 import { ovalContentsPath } from '../../../../helpers/pathsHelper';
-import { mockFactory } from '../../../../testHelper';
+import {
+  mockFactory,
+  admin,
+  intruder,
+  userFactory,
+} from '../../../../testHelper';
 
 const ovalContentMockFactory = mockFactory('ovalContents', ovalContentsQuery);
 
-export const mocks = [
+const viewer = userFactory('viewer', [
   {
-    request: {
-      query: ovalContentsQuery,
-      variables: {
-        first: 20,
-        last: 20,
-      },
-    },
-    result: {
-      data: {
-        ovalContents: {
-          totalCount: 4,
-          nodes: [
-            {
-              id: 'abc',
-              name: 'ansible OVAL content',
-              url:
-                'http://oval-content-source/security/data/oval/ansible-2-including-unpatched.oval.xml.bz2',
-              originalFilename: '',
-            },
-            {
-              id: 'bcd',
-              name: 'dotnet OVAL content',
-              url:
-                'http://oval-content-source/security/data/oval/dotnet-2.2.oval.xml.bz2',
-              originalFilename: '',
-            },
-            {
-              id: 'cde',
-              name: 'jboss OVAL content',
-              url: '',
-              originalFilename: 'jboss.oval.xml.bz2',
-            },
-            {
-              id: 'def',
-              name: 'openshift OVAL content',
-              url: '',
-              originalFilename: 'openshift.oval.xml.bz2',
-            },
-          ],
-        },
-      },
-    },
+    __typename: 'Permission',
+    id: 'MDE6UGVybWlzc2lvbi0yOTY=',
+    name: 'view_oval_contents',
   },
+]);
+
+const firstContent = (meta = { canDestroy: true }) => ({
+  id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsQ29udGVudC0z',
+  name: 'ansible OVAL content',
+  url:
+    'http://oval-content-source/security/data/oval/ansible-2-including-unpatched.oval.xml.bz2',
+  originalFilename: '',
+  meta,
+});
+
+const secondContent = (meta = { canDestroy: true }) => ({
+  id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsQ29udGVudC00',
+  name: 'dotnet OVAL content',
+  url: 'http://oval-content-source/security/data/oval/dotnet-2.2.oval.xml.bz2',
+  originalFilename: '',
+  meta,
+});
+
+const thirdContent = (meta = { canDestroy: true }) => ({
+  id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsQ29udGVudC03',
+  name: 'jboss OVAL content',
+  url: '',
+  originalFilename: 'jboss.oval.xml.bz2',
+  meta,
+});
+
+const fourthContent = (meta = { canDestroy: true }) => ({
+  id: 'MDE6Rm9yZW1hbk9wZW5zY2FwOjpPdmFsQ29udGVudC0zMw==',
+  name: 'openshift OVAL content',
+  url: '',
+  originalFilename: 'openshift.oval.xml.bz2',
+  meta,
+});
+
+const ovalContentNodes = [
+  firstContent(),
+  secondContent(),
+  thirdContent(),
+  fourthContent(),
 ];
 
-export const paginatedMocks = [
+export const ovalContents = {
+  totalCount: ovalContentNodes.length,
+  nodes: ovalContentNodes,
+};
+
+export const mocks = ovalContentMockFactory(
+  { first: 20, last: 20 },
   {
-    request: {
-      query: ovalContentsQuery,
-      variables: {
-        first: 10,
-        last: 5,
-      },
-    },
-    result: {
-      data: {
-        ovalContents: {
-          totalCount: 7,
-          nodes: [
-            {
-              id: 'bcd',
-              name: 'dotnet OVAL content',
-              url:
-                'http://oval-content-source/security/data/oval/dotnet-2.2.oval.xml.bz2',
-              originalFilename: '',
-            },
-            {
-              id: 'def',
-              name: 'openshift OVAL content',
-              url: '',
-              originalFilename: 'openshift.oval.xml.bz2',
-            },
-          ],
-        },
-      },
-    },
+    totalCount: 4,
+    nodes: [firstContent(), secondContent(), thirdContent(), fourthContent()],
   },
-];
+  { currentUser: admin }
+);
+
+export const unpagedMocks = ovalContentMockFactory({}, ovalContents, {
+  currentUser: admin,
+});
+
+export const paginatedMocks = ovalContentMockFactory(
+  { first: 10, last: 5 },
+  { totalCount: 7, nodes: [secondContent(), fourthContent()] },
+  { currentUser: admin }
+);
 
 export const emptyMocks = ovalContentMockFactory(
   { first: 20, last: 20 },
-  { totalCount: 0, nodes: [] }
+  { totalCount: 0, nodes: [] },
+  { currentUser: admin }
 );
 export const errorMocks = ovalContentMockFactory(
   { first: 20, last: 20 },
   { totalCount: 0, nodes: [] },
-  [{ message: 'Something very bad happened.' }]
+  { errors: [{ message: 'Something very bad happened.' }], currentUser: admin }
+);
+
+export const viewerMocks = ovalContentMockFactory(
+  { first: 20, last: 20 },
+  ovalContents,
+  { currentUser: viewer }
+);
+
+export const unauthorizedMocks = ovalContentMockFactory(
+  { first: 20, last: 20 },
+  ovalContents,
+  { currentUser: intruder }
+);
+
+export const noDeleteMocks = ovalContentMockFactory(
+  { first: 20, last: 20 },
+  {
+    totalCount: 2,
+    nodes: [
+      firstContent({ canDestroy: false }),
+      secondContent({ canDestroy: false }),
+    ],
+  },
+  { currentUser: admin }
 );
 
 export const pushMock = jest.fn();