foreman_openscap 0.5.4 → 0.6.0

data/test/test_plugin_helper.rb

@@ -5,53 +5,51 @@ require 'test_helper'
 FactoryGirl.definition_file_paths << File.join(File.dirname(__FILE__), 'factories')
 FactoryGirl.reload
 
-Spork.each_run do
-  module ScapClientPuppetclass
-    def skip_scap_callback
-      Host::Managed.any_instance.stubs(:update_scap_client).returns(nil)
-      Host::Managed.any_instance.stubs(:scap_client_class_present).returns(nil)
-      Hostgroup.any_instance.stubs(:update_scap_client).returns(nil)
-    end
+module ScapClientPuppetclass
+  def skip_scap_callback
+    Host::Managed.any_instance.stubs(:update_scap_client).returns(nil)
+    Host::Managed.any_instance.stubs(:scap_client_class_present).returns(nil)
+    Hostgroup.any_instance.stubs(:update_scap_client).returns(nil)
   end
+end
 
-  class ActionMailer::TestCase
-    include ScapClientPuppetclass
-    setup :skip_scap_callback
-  end
+class ActionMailer::TestCase
+  include ScapClientPuppetclass
+  setup :skip_scap_callback
+end
 
-  class ActionController::TestCase
-    include ScapClientPuppetclass
+class ActionController::TestCase
+  include ScapClientPuppetclass
 
-    setup :add_smart_proxy, :skip_scap_callback
+  setup :add_smart_proxy, :skip_scap_callback
 
-    private
+  private
 
-    def add_smart_proxy
-      FactoryGirl.create(:smart_proxy, :url => 'http://localhost:8443', :features => [FactoryGirl.create(:feature, :name => 'Openscap')])
-      ::ProxyAPI::Features.any_instance.stubs(:features).returns(%w(puppet openscap))
-      versions = { "version" => "1.11.0", "modules" => { "openscap" => "0.5.3" } }
-      ::ProxyAPI::Version.any_instance.stubs(:proxy_versions).returns(versions)
-      ProxyAPI::Openscap.any_instance.stubs(:validate_scap_content).returns({'errors' => []})
-      ProxyAPI::Openscap.any_instance.stubs(:fetch_policies_for_scap_content)
-          .returns({'xccdf_org.ssgproject.content_profile_common' => 'Common Profile for General-Purpose Fedora Systems'})
-    end
+  def add_smart_proxy
+    FactoryGirl.create(:smart_proxy, :url => 'http://localhost:8443', :features => [FactoryGirl.create(:feature, :name => 'Openscap')])
+    ::ProxyAPI::Features.any_instance.stubs(:features).returns(%w(puppet openscap))
+    versions = { "version" => "1.11.0", "modules" => { "openscap" => "0.5.3" } }
+    ::ProxyAPI::Version.any_instance.stubs(:proxy_versions).returns(versions)
+    ProxyAPI::Openscap.any_instance.stubs(:validate_scap_content).returns({'errors' => []})
+    ProxyAPI::Openscap.any_instance.stubs(:fetch_policies_for_scap_content)
+        .returns({'xccdf_org.ssgproject.content_profile_common' => 'Common Profile for General-Purpose Fedora Systems'})
   end
+end
 
-  class ActiveSupport::TestCase
-    include ScapClientPuppetclass
+class ActiveSupport::TestCase
+  include ScapClientPuppetclass
 
-    setup :add_smart_proxy, :skip_scap_callback
+  setup :add_smart_proxy, :skip_scap_callback
 
-    private
+  private
 
-    def add_smart_proxy
-      FactoryGirl.create(:smart_proxy, :url => 'http://localhost:8443', :features => [FactoryGirl.create(:feature, :name => 'Openscap')])
-      ::ProxyAPI::Features.any_instance.stubs(:features).returns(%w(puppet openscap))
-      versions = { "version" => "1.11.0", "modules" => { "openscap" => "0.5.3" } }
-      ::ProxyAPI::Version.any_instance.stubs(:proxy_versions).returns(versions)
-      ProxyAPI::Openscap.any_instance.stubs(:validate_scap_content).returns({'errors' => []})
-      ProxyAPI::Openscap.any_instance.stubs(:fetch_policies_for_scap_content)
-          .returns({'xccdf_org.ssgproject.content_profile_common' => 'Common Profile for General-Purpose Fedora Systems'})
-    end
+  def add_smart_proxy
+    FactoryGirl.create(:smart_proxy, :url => 'http://localhost:8443', :features => [FactoryGirl.create(:feature, :name => 'Openscap')])
+    ::ProxyAPI::Features.any_instance.stubs(:features).returns(%w(puppet openscap))
+    versions = { "version" => "1.11.0", "modules" => { "openscap" => "0.5.3" } }
+    ::ProxyAPI::Version.any_instance.stubs(:proxy_versions).returns(versions)
+    ProxyAPI::Openscap.any_instance.stubs(:validate_scap_content).returns({'errors' => []})
+    ProxyAPI::Openscap.any_instance.stubs(:fetch_policies_for_scap_content)
+        .returns({'xccdf_org.ssgproject.content_profile_common' => 'Common Profile for General-Purpose Fedora Systems'})
   end
 end

data/test/unit/concerns/openscap_proxy_extenstions_test.rb

@@ -0,0 +1,21 @@
+require 'test_plugin_helper'
+
+class OpenscapProxyExtensionsTest < ActiveSupport::TestCase
+
+  setup do
+    @host = FactoryGirl.create(:compliance_host)
+  end
+
+  test "should return proxy api for openscap" do
+    arf = FactoryGirl.create(:arf_report,
+                             :host_id => @host.id,
+                             :openscap_proxy => @host.openscap_proxy)
+    api = arf.openscap_proxy_api
+    assert_equal (@host.openscap_proxy.url + "/compliance/"), api.url
+  end
+
+  test "should raise exception when no openscap proxy asociated" do
+    arf = FactoryGirl.create(:arf_report, :host_id => @host.id)
+    assert_raises(Foreman::Exception) { arf.openscap_proxy_api }
+  end
+end

data/test/unit/openscap_host_test.rb

@@ -5,6 +5,7 @@ class OpenscapHostTest < ActiveSupport::TestCase
     disable_orchestration
     User.current = users :admin
     ForemanOpenscap::Policy.any_instance.stubs(:ensure_needed_puppetclasses).returns(true)
+    ForemanOpenscap::Policy.any_instance.stubs(:find_scap_puppetclass).returns(FactoryGirl.create(:puppetclass, :name => 'foreman_scap_client'))
     @policy = FactoryGirl.create(:policy)
   end
 
@@ -19,7 +20,8 @@ class OpenscapHostTest < ActiveSupport::TestCase
   test 'Host has policies via its hostgroup' do
     host = FactoryGirl.create(:host, :with_hostgroup)
     hostgroup = host.hostgroup
-    assert(@policy.hostgroup_ids = ["#{hostgroup.id}"])
+    @policy.hostgroup_ids = ["#{hostgroup.id}"]
+    assert @policy.save
     refute_empty(host.combined_policies)
     assert_includes(host.combined_policies, @policy)
   end

data/test/unit/policy_test.rb

@@ -0,0 +1,125 @@
+require 'test_plugin_helper'
+
+class PolicyTest < ActiveSupport::TestCase
+  setup do
+    ForemanOpenscap::Policy.any_instance.stubs(:ensure_needed_puppetclasses).returns(true)
+    @scap_content = FactoryGirl.create(:scap_content)
+    @scap_profile = FactoryGirl.create(:scap_content_profile)
+  end
+
+  test "should assign hostgroups by their ids" do
+    ForemanOpenscap::Policy.any_instance.stubs(:find_scap_puppetclass).returns(FactoryGirl.create(:puppetclass, :name => 'foreman_scap_client'))
+    ForemanOpenscap::Policy.any_instance.stubs(:populate_overrides)
+    hg1 = FactoryGirl.create(:hostgroup)
+    hg2 = FactoryGirl.create(:hostgroup)
+    asset = FactoryGirl.create(:asset, :assetable_id => hg1.id, :assetable_type => 'Hostgroup')
+    policy = FactoryGirl.create(:policy, :assets => [asset])
+    policy.hostgroup_ids = [hg1, hg2].map(&:id)
+    policy.save!
+    assert_equal 2, policy.hostgroups.count
+    assert policy.hostgroups.include?(hg2)
+  end
+
+  test "should remove associated hostgroup" do
+    ForemanOpenscap::Policy.any_instance.stubs(:find_scap_puppetclass).returns(FactoryGirl.create(:puppetclass, :name => 'foreman_scap_client'))
+    ForemanOpenscap::Policy.any_instance.stubs(:populate_overrides)
+    hg = FactoryGirl.create(:hostgroup)
+    asset = FactoryGirl.create(:asset, :assetable_id => hg.id, :assetable_type => 'Hostgroup')
+    policy = FactoryGirl.create(:policy, :assets => [asset])
+    policy.save!
+    hg.hostgroup_classes.destroy_all
+    hg.destroy
+    assert_equal 0, policy.hostgroups.count
+  end
+
+  test "should create policy with custom period" do
+    p = ForemanOpenscap::Policy.new(:name => "custom_policy",
+                                    :scap_content_id => @scap_content.id,
+                                    :scap_content_profile_id => @scap_profile.id,
+                                    :period => 'custom',
+                                    :cron_line => '6 * 15 12 0')
+    assert p.save
+  end
+
+  test "should not create policy with custom period" do
+    p = ForemanOpenscap::Policy.new(:name => "custom_policy",
+                                    :scap_content_id => @scap_content.id,
+                                    :scap_content_profile_id => @scap_profile.id,
+                                    :period => 'custom',
+                                    :cron_line => 'aaa')
+    refute p.save
+    assert p.errors[:cron_line].include?("does not consist of 5 parts separated by space")
+  end
+
+  test "should create policy with weekly period" do
+    p = ForemanOpenscap::Policy.new(:name => "custom_policy",
+                                    :scap_content_id => @scap_content.id,
+                                    :scap_content_profile_id => @scap_profile.id,
+                                    :period => 'weekly',
+                                    :weekday => 'monday')
+    assert p.save
+  end
+
+  test "should not create policy with weekly period" do
+    p = ForemanOpenscap::Policy.new(:name => "custom_policy",
+                                    :scap_content_id => @scap_content.id,
+                                    :scap_content_profile_id => @scap_profile.id,
+                                    :period => 'weekly',
+                                    :weekday => 'someday')
+    refute p.save
+    assert p.errors[:weekday].include?("is not a valid value")
+  end
+
+  test "should create policy with monthly period" do
+    p = ForemanOpenscap::Policy.new(:name => "custom_policy",
+                                    :scap_content_id => @scap_content.id,
+                                    :scap_content_profile_id => @scap_profile.id,
+                                    :period => 'monthly',
+                                    :day_of_month => '1')
+    assert p.save
+  end
+
+  test "should not create policy with monthly period" do
+    p = ForemanOpenscap::Policy.new(:name => "custom_policy",
+                                    :scap_content_id => @scap_content.id,
+                                    :scap_content_profile_id => @scap_profile.id,
+                                    :period => 'monthly',
+                                    :day_of_month => '0')
+    refute p.save
+    assert p.errors[:day_of_month].include?("must be between 1 and 31")
+  end
+
+  test "should not create policy when attributes do not correspond to selected period in new record" do
+    p = ForemanOpenscap::Policy.new(:name => "custom_policy",
+                                    :scap_content_id => @scap_content.id,
+                                    :scap_content_profile_id => @scap_profile.id,
+                                    :period => 'monthly',
+                                    :weekday => 'tuesday',
+                                    :cron_line => "0 0 0 0 0")
+    policy = ForemanOpenscap::Policy.new(:name => "test policy",
+                                         :scap_content_id => @scap_content.id,
+                                         :scap_content_profile_id => @scap_profile.id,
+                                         :period => 'custom',
+                                         :weekday => 'tuesday',
+                                         :day_of_month => "15")
+    refute p.save
+    refute policy.save
+    assert p.weekday.empty?
+    assert p.cron_line.empty?
+    assert policy.weekday.empty?
+    assert policy.day_of_month.empty?
+  end
+
+  test "should update policy period" do
+    p = ForemanOpenscap::Policy.new(:name => "custom_policy",
+                                    :scap_content_id => @scap_content.id,
+                                    :scap_content_profile_id => @scap_profile.id,
+                                    :period => 'monthly',
+                                    :day_of_month => '5')
+    assert p.save
+    p.period = 'weekly'
+    p.weekday = 'monday'
+    p.day_of_month = nil
+    assert p.save
+  end
+end

data/test/unit/scap_content_test.rb

@@ -10,6 +10,11 @@ class ScapContentTest < ActiveSupport::TestCase
       assert(scap_content.valid?)
     end
 
+    test 'should not allow title.length > 255' do
+      scap_content = ForemanOpenscap::ScapContent.new(:title => ("a" * 256), :scap_file => @scap_file)
+      refute(scap_content.valid?)
+    end
+
     test 'scap content should fail if no openscap proxy' do
       SmartProxy.stubs(:with_features).returns([])
       ProxyAPI::AvailableProxy.any_instance.stubs(:available?).returns(false)