foreman_openbolt 1.0.0 → 1.1.1

data/webpack/src/Components/common/HostsPopover.js

@@ -1,6 +1,6 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import { translate as __ } from 'foremanReact/common/I18n';
+import { sprintf, translate as __ } from 'foremanReact/common/I18n';
 import { Popover, Button } from '@patternfly/react-core';
 import { Table, Tbody, Tr, Td } from '@patternfly/react-table';
 
@@ -17,7 +17,12 @@ const HostsPopover = ({ targets }) => {
         border: '1px solid var(--pf-v5-global--BorderColor--100)',
       }}
     >
-      <Table variant="compact" borders isStriped>
+      <Table
+        variant="compact"
+        borders
+        isStriped
+        aria-label={__('Target hosts')}
+      >
         <Tbody>
           {targets.map((host, index) => (
             <Tr key={index}>
@@ -31,7 +36,11 @@ const HostsPopover = ({ targets }) => {
 
   return (
     <Popover bodyContent={popoverContent} position="right" maxWidth="600px">
-      <Button variant="link" isInline>
+      <Button
+        variant="link"
+        isInline
+        aria-label={sprintf(__('%s target hosts'), targets.length)}
+      >
         {targets.length}
       </Button>
     </Popover>

data/webpack/src/Components/common/__tests__/HostsPopover.test.js

@@ -0,0 +1,20 @@
+import React from 'react';
+import { render, screen } from '@testing-library/react';
+import HostsPopover from '../HostsPopover';
+
+describe('HostsPopover', () => {
+  test('shows "No targets specified" when targets is empty', () => {
+    render(<HostsPopover targets={[]} />);
+    expect(screen.getByText('No targets specified')).toBeInTheDocument();
+  });
+
+  test('shows "No targets specified" when targets is not provided', () => {
+    render(<HostsPopover />);
+    expect(screen.getByText('No targets specified')).toBeInTheDocument();
+  });
+
+  test('shows target count as button when targets exist', () => {
+    render(<HostsPopover targets={['host1.com', 'host2.com', 'host3.com']} />);
+    expect(screen.getByText('3')).toBeInTheDocument();
+  });
+});

data/webpack/src/Components/common/__tests__/helpers.test.js

@@ -0,0 +1,135 @@
+import {
+  extractErrorMessage,
+  displayValue,
+  formatDuration,
+  formatDate,
+} from '../helpers';
+
+describe('extractErrorMessage', () => {
+  test('extracts error from response.data.error', () => {
+    const error = { response: { data: { error: 'Proxy unreachable' } } };
+    expect(extractErrorMessage(error)).toBe('Proxy unreachable');
+  });
+
+  test('extracts error from response.data.error when error is an object with message', () => {
+    const error = { response: { data: { error: { message: 'Bad request' } } } };
+    expect(extractErrorMessage(error)).toBe('Bad request');
+  });
+
+  test('stringifies object error without message key', () => {
+    const errorObj = { code: 500, detail: 'internal' };
+    const error = { response: { data: { error: errorObj } } };
+    expect(extractErrorMessage(error)).toBe(JSON.stringify(errorObj));
+  });
+
+  test('falls back to error.message', () => {
+    const error = { message: 'Network error' };
+    expect(extractErrorMessage(error)).toBe('Network error');
+  });
+
+  test('returns Unknown error when no useful fields exist', () => {
+    const error = {};
+    expect(extractErrorMessage(error)).toBe('Unknown error');
+  });
+
+  test('returns Unknown error for null input', () => {
+    expect(extractErrorMessage(null)).toBe('Unknown error');
+  });
+
+  test('returns Unknown error for undefined input', () => {
+    expect(extractErrorMessage(undefined)).toBe('Unknown error');
+  });
+});
+
+describe('displayValue', () => {
+  test('returns dash for null', () => {
+    expect(displayValue(null)).toBe('-');
+  });
+
+  test('returns dash for undefined', () => {
+    expect(displayValue(undefined)).toBe('-');
+  });
+
+  test('returns JSON string for objects', () => {
+    expect(displayValue({ key: 'val' })).toBe('{"key":"val"}');
+  });
+
+  test('returns string representation for numbers', () => {
+    expect(displayValue(42)).toBe('42');
+  });
+
+  test('returns string as-is', () => {
+    expect(displayValue('hello')).toBe('hello');
+  });
+
+  test('returns string for boolean', () => {
+    expect(displayValue(true)).toBe('true');
+  });
+
+  test('returns empty string as-is (not dash)', () => {
+    expect(displayValue('')).toBe('');
+  });
+});
+
+describe('formatDuration', () => {
+  test('returns dash for null', () => {
+    expect(formatDuration(null)).toBe('-');
+  });
+
+  test('returns dash for undefined', () => {
+    expect(formatDuration(undefined)).toBe('-');
+  });
+
+  test('returns 0s for zero', () => {
+    expect(formatDuration(0)).toBe('0s');
+  });
+
+  test('returns dash for negative', () => {
+    expect(formatDuration(-5)).toBe('-');
+  });
+
+  test('formats seconds only', () => {
+    expect(formatDuration(45)).toBe('45s');
+  });
+
+  test('formats minutes and seconds', () => {
+    expect(formatDuration(125)).toBe('2m 5s');
+  });
+
+  test('formats hours, minutes, and seconds', () => {
+    expect(formatDuration(3661)).toBe('1h 1m 1s');
+  });
+
+  test('formats exact minute boundary', () => {
+    expect(formatDuration(60)).toBe('1m 0s');
+  });
+
+  test('formats exact hour boundary', () => {
+    expect(formatDuration(3600)).toBe('1h 0m 0s');
+  });
+
+  test('rounds fractional seconds', () => {
+    expect(formatDuration(45.7)).toBe('46s');
+  });
+});
+
+describe('formatDate', () => {
+  test('returns dash for null', () => {
+    expect(formatDate(null)).toBe('-');
+  });
+
+  test('returns dash for empty string', () => {
+    expect(formatDate('')).toBe('-');
+  });
+
+  test('returns dash for invalid date string', () => {
+    expect(formatDate('not-a-date')).toBe('-');
+  });
+
+  test('formats a valid ISO date with recognizable date components', () => {
+    const result = formatDate('2026-01-15T10:30:00Z');
+    expect(result).not.toBe('-');
+    expect(result).toMatch(/2026/);
+    expect(result).toMatch(/15/);
+  });
+});

data/webpack/src/Components/common/helpers.js

@@ -1,12 +1,8 @@
 import { useCallback } from 'react';
 import { useDispatch } from 'react-redux';
 import { addToast } from 'foremanReact/components/ToastsList';
+import { translate as __ } from 'foremanReact/common/I18n';
 
-/**
- * Custom hook to show messages using the Foreman Toast system.
- *
- * @returns {Function} A function that takes a message and type, and shows a toast message.
- */
 export const useShowMessage = () => {
   const dispatch = useDispatch();
 
@@ -17,3 +13,36 @@ export const useShowMessage = () => {
     [dispatch]
   );
 };
+
+export const extractErrorMessage = error => {
+  if (!error) return __('Unknown error');
+  const rawError =
+    error.response?.data?.error || error.message || __('Unknown error');
+  if (typeof rawError === 'object')
+    return rawError.message || JSON.stringify(rawError);
+  return rawError;
+};
+
+export const displayValue = value => {
+  if (value === null || value === undefined) return '-';
+  if (typeof value === 'object') return JSON.stringify(value);
+  return String(value);
+};
+
+export const formatDuration = duration => {
+  if (duration === null || duration === undefined || duration < 0) return '-';
+  const totalSeconds = Math.round(duration);
+  const hours = Math.floor(totalSeconds / 3600);
+  const minutes = Math.floor((totalSeconds % 3600) / 60);
+  const seconds = totalSeconds % 60;
+  if (hours > 0) return `${hours}h ${minutes}m ${seconds}s`;
+  if (minutes > 0) return `${minutes}m ${seconds}s`;
+  return `${seconds}s`;
+};
+
+export const formatDate = dateString => {
+  if (!dateString) return '-';
+  const date = new Date(dateString);
+  if (Number.isNaN(date.getTime())) return '-';
+  return date.toLocaleString();
+};

data/webpack/test_setup.js

@@ -1,17 +1,40 @@
-import 'core-js/shim';
-import 'regenerator-runtime/runtime';
-import MutationObserver from '@sheerun/mutationobserver-shim';
-
-import { configure } from 'enzyme';
-import Adapter from 'enzyme-adapter-react-16';
-
-configure({ adapter: new Adapter() });
-
 // Mocking translation function
 global.__ = text => text; // eslint-disable-line
 
 // Mocking locales to prevent unnecessary fallback messages
 window.locales = { en: { domain: 'app', locale_data: { app: { '': {} } } } };
 
-// see https://github.com/testing-library/dom-testing-library/releases/tag/v7.0.0
-window.MutationObserver = MutationObserver;
+// Suppress React warnings about unrecognized DOM props from PatternFly 5.
+// PF5 passes custom attributes (ouia*, variant helpers) that React warns
+// about. Only suppress known PF5 prop names so real component bugs still
+// surface as test failures.
+const PF5_KNOWN_PROPS = [
+  'ouiaSafe',
+  'ouiaId',
+  'isExpanded',
+  'isDisabled',
+  'isActive',
+  'isPlain',
+  'isInline',
+  'isFilled',
+  'isCompact',
+  'isHovered',
+  'isStriped',
+  'isStickyHeader',
+  'hasRightBorder',
+  'hasGutter',
+];
+const originalConsoleError = console.error; // eslint-disable-line no-console
+// eslint-disable-next-line no-console
+console.error = (...args) => {
+  const message = typeof args[0] === 'string' ? args[0] : '';
+  if (message.includes('does not recognize the `%s` prop')) {
+    const propName = typeof args[1] === 'string' ? args[1] : '';
+    if (PF5_KNOWN_PROPS.includes(propName)) return;
+  }
+  originalConsoleError.apply(console, args);
+  const errorMsg = args
+    .map(arg => (typeof arg === 'string' ? arg : JSON.stringify(arg)))
+    .join(' ');
+  throw new Error(errorMsg || 'console.error was called');
+};

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman_openbolt
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Overlook InfraTech
@@ -29,82 +29,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '13'
-- !ruby/object:Gem::Dependency
-  name: erb_lint
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.9.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.9.0
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 13.0.6
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 13.0.6
-- !ruby/object:Gem::Dependency
-  name: rdoc
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '6.5'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '6.5'
-- !ruby/object:Gem::Dependency
-  name: theforeman-rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.1.2
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.1.2
-- !ruby/object:Gem::Dependency
-  name: rubocop-rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.6.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.6.0
 description: This plugin adds OpenBolt integration into Foreman, allowing users to
   run tasks and plans present in their environment.
 email:
@@ -136,11 +60,48 @@ files:
 - locale/foreman_openbolt.pot
 - locale/gemspec.rb
 - package.json
-- test/factories/foreman_openbolt_factories.rb
+- test/acceptance/acceptance_helper.rb
+- test/acceptance/docker/docker-compose.yml
+- test/acceptance/docker/foreman/Dockerfile
+- test/acceptance/docker/foreman/entrypoint.sh
+- test/acceptance/docker/target/Dockerfile
+- test/acceptance/docker/target/entrypoint.sh
+- test/acceptance/fixtures/modules/acceptance/tasks/complex_params.json
+- test/acceptance/fixtures/modules/acceptance/tasks/complex_params.sh
+- test/acceptance/fixtures/modules/acceptance/tasks/echo.json
+- test/acceptance/fixtures/modules/acceptance/tasks/echo.sh
+- test/acceptance/fixtures/modules/acceptance/tasks/failing_task.json
+- test/acceptance/fixtures/modules/acceptance/tasks/failing_task.sh
+- test/acceptance/fixtures/modules/acceptance/tasks/noop_task.json
+- test/acceptance/fixtures/modules/acceptance/tasks/noop_task.sh
+- test/acceptance/fixtures/modules/acceptance/tasks/slow_task.json
+- test/acceptance/fixtures/modules/acceptance/tasks/slow_task.sh
+- test/acceptance/fixtures/modules/acceptance/tasks/target_conditional.json
+- test/acceptance/fixtures/modules/acceptance/tasks/target_conditional.sh
+- test/acceptance/fixtures/openbolt.yml
+- test/acceptance/tests/error_handling_test.rb
+- test/acceptance/tests/host_selector_test.rb
+- test/acceptance/tests/launch_task_test.rb
+- test/acceptance/tests/parameter_table_test.rb
+- test/acceptance/tests/settings_test.rb
+- test/acceptance/tests/ssh_options_test.rb
+- test/acceptance/tests/task_execution_test.rb
+- test/acceptance/tests/task_history_test.rb
+- test/acceptance/tests/transport_options_test.rb
 - test/test_plugin_helper.rb
-- test/unit/foreman_openbolt_test.rb
+- test/unit/controllers/task_controller_test.rb
+- test/unit/docker/Dockerfile
+- test/unit/docker/docker-compose.yml
+- test/unit/docker/entrypoint.sh
+- test/unit/factories/foreman_openbolt_factories.rb
+- test/unit/lib/actions/cleanup_proxy_artifacts_test.rb
+- test/unit/lib/actions/poll_task_status_test.rb
+- test/unit/lib/proxy_api/openbolt_test.rb
+- test/unit/models/task_job_test.rb
+- webpack/__mocks__/foremanReact/common/I18n.js
+- webpack/__mocks__/foremanReact/components/ToastsList/index.js
+- webpack/__mocks__/foremanReact/redux/API/index.js
 - webpack/global_index.js
-- webpack/global_test_setup.js
 - webpack/index.js
 - webpack/src/Components/LaunchTask/EmptyContent.js
 - webpack/src/Components/LaunchTask/FieldTable.js
@@ -155,6 +116,15 @@ files:
 - webpack/src/Components/LaunchTask/ParametersSection.js
 - webpack/src/Components/LaunchTask/SmartProxySelect.js
 - webpack/src/Components/LaunchTask/TaskSelect.js
+- webpack/src/Components/LaunchTask/__tests__/EmptyContent.test.js
+- webpack/src/Components/LaunchTask/__tests__/LaunchTask.test.js
+- webpack/src/Components/LaunchTask/__tests__/ParameterField.test.js
+- webpack/src/Components/LaunchTask/__tests__/ParametersSection.test.js
+- webpack/src/Components/LaunchTask/__tests__/SmartProxySelect.test.js
+- webpack/src/Components/LaunchTask/__tests__/TaskSelect.test.js
+- webpack/src/Components/LaunchTask/hooks/__tests__/useOpenBoltOptions.test.js
+- webpack/src/Components/LaunchTask/hooks/__tests__/useSmartProxies.test.js
+- webpack/src/Components/LaunchTask/hooks/__tests__/useTasksData.test.js
 - webpack/src/Components/LaunchTask/hooks/useOpenBoltOptions.js
 - webpack/src/Components/LaunchTask/hooks/useSmartProxies.js
 - webpack/src/Components/LaunchTask/hooks/useTasksData.js
@@ -164,11 +134,22 @@ files:
 - webpack/src/Components/TaskExecution/LoadingIndicator.js
 - webpack/src/Components/TaskExecution/ResultDisplay.js
 - webpack/src/Components/TaskExecution/TaskDetails.js
+- webpack/src/Components/TaskExecution/__tests__/ExecutionDetails.test.js
+- webpack/src/Components/TaskExecution/__tests__/ExecutionDisplay.test.js
+- webpack/src/Components/TaskExecution/__tests__/LoadingIndicator.test.js
+- webpack/src/Components/TaskExecution/__tests__/ResultDisplay.test.js
+- webpack/src/Components/TaskExecution/__tests__/TaskDetails.test.js
+- webpack/src/Components/TaskExecution/__tests__/TaskExecution.test.js
+- webpack/src/Components/TaskExecution/hooks/__tests__/useJobPolling.test.js
 - webpack/src/Components/TaskExecution/hooks/useJobPolling.js
 - webpack/src/Components/TaskExecution/index.js
 - webpack/src/Components/TaskHistory/TaskPopover.js
+- webpack/src/Components/TaskHistory/__tests__/TaskHistory.test.js
+- webpack/src/Components/TaskHistory/__tests__/TaskPopover.test.js
 - webpack/src/Components/TaskHistory/index.js
 - webpack/src/Components/common/HostsPopover.js
+- webpack/src/Components/common/__tests__/HostsPopover.test.js
+- webpack/src/Components/common/__tests__/helpers.test.js
 - webpack/src/Components/common/constants.js
 - webpack/src/Components/common/helpers.js
 - webpack/src/Pages/LaunchTaskPage.js
@@ -176,12 +157,12 @@ files:
 - webpack/src/Pages/TaskHistoryPage.js
 - webpack/src/Router/routes.js
 - webpack/test_setup.js
-- webpack/webpack.config.js
 homepage: https://github.com/overlookinfra/foreman_openbolt
 licenses:
 - GPL-3.0-only
 metadata:
   is_foreman_plugin: 'true'
+  rubygems_mfa_required: 'true'
 rdoc_options: []
 require_paths:
 - lib
@@ -189,7 +170,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.0'
   - - "<"
     - !ruby/object:Gem::Version
       version: '5'
@@ -199,10 +180,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.3
+rubygems_version: 4.0.6
 specification_version: 4
 summary: Foreman OpenBolt integration
-test_files:
-- test/factories/foreman_openbolt_factories.rb
-- test/test_plugin_helper.rb
-- test/unit/foreman_openbolt_test.rb
+test_files: []

data/test/factories/foreman_openbolt_factories.rb

@@ -1,7 +0,0 @@
-# frozen_string_literal: true
-
-FactoryBot.define do
-  factory :host do
-    name 'foreman_openbolt'
-  end
-end

data/test/unit/foreman_openbolt_test.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_plugin_helper'
-
-class ForemanOpenboltTest < ActiveSupport::TestCase
-  setup do
-    User.current = User.find_by login: 'admin'
-  end
-
-  test 'the truth' do
-    assert true
-  end
-end

data/webpack/global_test_setup.js

@@ -1,11 +0,0 @@
-// runs before each test to make sure console.error output will
-// fail a test (i.e. default PropType missing). Check the error
-// output and traceback for actual error.
-global.console.error = (error, stack) => {
-  /* eslint-disable-next-line no-console */
-  if (stack) console.log(stack); // Prints out original stack trace
-  throw new Error(error);
-};
-
-// Increase jest timeout as some tests using multiple http mocks can time out on CI systems.
-jest.setTimeout(10000);

data/webpack/webpack.config.js

@@ -1,7 +0,0 @@
-// Set WEBPACK_MODE=development for development builds
-module.exports = (env, argv) => ({
-  mode: process.env.WEBPACK_MODE || 'production',
-  optimization: {
-    minimize: false,
-  },
-});