foreman_omaha 3.0.0 → 5.0.0

data/locale/gemspec.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 # Matches foreman_omaha.gemspec
 _('This plug-in adds support for the Omaha procotol to The Foreman. It allows you to better manage and update your CoreOS servers.')

data/test/factories/feature.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 FactoryBot.modify do
   factory :feature do
     trait :omaha do
-      name 'Omaha'
+      name { 'Omaha' }
     end
   end
 end

data/test/factories/foreman_omaha_factories.rb

@@ -1,18 +1,20 @@
+# frozen_string_literal: true
+
 FactoryBot.define do
   factory :omaha_report, :class => 'ForemanOmaha::OmahaReport' do
     host
     sequence(:reported_at) { |n| n.minutes.ago }
-    status 1
-    omaha_version '1068.9.0'
-    type 'ForemanOmaha::OmahaReport'
+    status { 1 }
+    omaha_version { '1068.9.0' }
+    type { 'ForemanOmaha::OmahaReport' }
   end
 
   factory :omaha_facet, :class => 'ForemanOmaha::OmahaFacet' do
     sequence(:last_report) { |n| n.minutes.ago }
-    version '1068.9.0'
-    oem 'rackspace'
+    version { '1068.9.0' }
+    oem { 'rackspace' }
     sequence(:machineid) { SecureRandom.hex }
-    status 1
+    status { 1 }
     host
     omaha_group
   end

data/test/factories/host.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 FactoryBot.modify do
   factory :host do
     trait :with_omaha_facet do
       association :omaha_facet, :factory => :omaha_facet, :strategy => :build
 
       transient do
-        omaha_status 1
-        omaha_version '1068.9.0'
-        omaha_oem 'rackspace'
-        omaha_group nil
+        omaha_status { 1 }
+        omaha_version { '1068.9.0' }
+        omaha_oem { 'rackspace' }
+        omaha_group { nil }
       end
 
       after(:build) do |host, evaluator|
@@ -17,5 +19,18 @@ FactoryBot.modify do
         host.omaha_facet.omaha_group = evaluator.omaha_group if evaluator.omaha_group.present?
       end
     end
+
+    trait :with_omaha_reports do
+      with_omaha_facet
+      transient do
+        omaha_report_count { 5 }
+      end
+      after(:create) do |host, evaluator|
+        evaluator.omaha_report_count.times do |i|
+          FactoryBot.create(:omaha_report, host: host, reported_at: (evaluator.omaha_report_count - i).minutes.ago)
+        end
+        host.omaha_facet.update_attribute(:last_report, host.omaha_reports.last.reported_at) # rubocop:disable Rails/SkipsModelValidations
+      end
+    end
   end
 end

data/test/factories/smart_proxy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 FactoryBot.modify do
   factory :smart_proxy do
     trait :omaha do

data/test/functional/api/v2/omaha_groups_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class Api::V2::OmahaGroupsControllerTest < ActionController::TestCase

data/test/functional/api/v2/omaha_reports_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class Api::V2::OmahaReportsControllerTest < ActionController::TestCase
@@ -53,7 +55,7 @@ class Api::V2::OmahaReportsControllerTest < ActionController::TestCase
     assert_response :success
     assert_not_nil assigns(:omaha_reports)
     reports = ActiveSupport::JSON.decode(@response.body)
-    assert reports['results'].empty?
+    assert_empty reports['results']
     assert_equal 0, reports['results'].count
   end
 
@@ -98,7 +100,7 @@ class Api::V2::OmahaReportsControllerTest < ActionController::TestCase
 
     test 'hosts with a registered smart proxy on should create a report successfully' do
       Setting[:restrict_registered_smart_proxies] = true
-      Setting[:require_ssl_smart_proxies] = false
+      Setting[:require_ssl_smart_proxies] = false if Gem::Version.new(SETTINGS[:version].notag) < Gem::Version.new('3.1')
 
       proxy = FactoryBot.create(:smart_proxy, :omaha)
       host = URI.parse(proxy.url).host

data/test/functional/omaha_groups_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class OmahaGroupsControllerTest < ActionController::TestCase

data/test/functional/omaha_hosts_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class OmahaHostsControllerTest < ActionController::TestCase

data/test/functional/omaha_reports_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class OmahaReportsControllerTest < ActionController::TestCase

data/test/graphql/queries/host_query_extensions_test.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+module Queries
+  class HostQueryExtensionsTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query (
+        $id: String!
+      ) {
+        host(id: $id) {
+          id
+          omahaReports {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:host) do
+      FactoryBot.create(:host, :managed, :with_omaha_reports)
+    end
+    let(:global_id) { Foreman::GlobalId.encode('Host', host.id) }
+    let(:variables) { { id: Foreman::GlobalId.encode('Host', host.id) } }
+    let(:data) { result['data']['host'] }
+
+    test 'fetching host attributes with omaha extensions' do
+      assert_empty result['errors']
+      assert_equal global_id, data['id']
+
+      assert_collection host.omaha_reports, data['omahaReports']
+    end
+  end
+end

data/test/graphql/queries/omaha_group_query_test.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+module Queries
+  class OmahaGroupQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query omahaGroupQuery (
+        $id: String!
+      ) {
+        omahaGroup(id: $id) {
+          id
+          name
+          uuid
+          createdAt
+          updatedAt
+          hosts {
+            totalCount
+            edges {
+              node {
+                id
+              }
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:omaha_group) { FactoryBot.create(:omaha_group) }
+    let(:global_id) { Foreman::GlobalId.for(omaha_group) }
+    let(:variables) { { id: global_id } }
+    let(:data) { result['data']['omahaGroup'] }
+
+    test 'fetching omaha group attributes' do
+      FactoryBot.create(:host, :managed, :with_omaha_facet, omaha_group: omaha_group)
+
+      assert_empty result['errors']
+      assert_not_nil data
+
+      assert_equal global_id, data['id']
+      assert_equal omaha_group.created_at.utc.iso8601, data['createdAt']
+      assert_equal omaha_group.updated_at.utc.iso8601, data['updatedAt']
+      assert_equal omaha_group.name, data['name']
+      assert_equal omaha_group.uuid, data['uuid']
+
+      assert_collection omaha_group.hosts, data['hosts'], type_name: 'Host'
+    end
+  end
+end

data/test/graphql/queries/omaha_groups_query_test.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+module Queries
+  class OmahaGroupsQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query omahaGroupsQuery {
+        omahaGroups {
+          totalCount
+          pageInfo {
+            startCursor
+            endCursor
+            hasNextPage
+            hasPreviousPage
+          }
+          edges {
+            cursor
+            node {
+              id
+              name
+              uuid
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:data) { result['data']['omahaGroups'] }
+
+    setup do
+      FactoryBot.create_list(:omaha_group, 2)
+    end
+
+    test 'fetching models attributes' do
+      assert_empty result['errors']
+
+      expected_count = ForemanOmaha::OmahaGroup.count
+
+      assert_not_equal 0, expected_count
+      assert_equal expected_count, data['totalCount']
+      assert_equal expected_count, data['edges'].count
+    end
+  end
+end

data/test/graphql/queries/omaha_report_query_test.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+module Queries
+  class OmahaReportQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query omahaReportQuery (
+        $id: String!
+      ) {
+        omahaReport(id: $id) {
+          id
+          status
+          omahaVersion
+          createdAt
+          updatedAt
+          host {
+            id
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:omaha_report) { FactoryBot.create(:omaha_report) }
+    let(:global_id) { Foreman::GlobalId.for(omaha_report) }
+    let(:variables) { { id: global_id } }
+    let(:data) { result['data']['omahaReport'] }
+
+    test 'fetching omaha report attributes' do
+      assert_empty result['errors']
+      assert_not_nil data
+
+      assert_equal global_id, data['id']
+      assert_equal omaha_report.created_at.utc.iso8601, data['createdAt']
+      assert_equal omaha_report.updated_at.utc.iso8601, data['updatedAt']
+      assert_equal omaha_report.status, data['status']
+      assert_equal omaha_report.omaha_version, data['omahaVersion']
+
+      assert_record omaha_report.host, data['host']
+    end
+  end
+end

data/test/graphql/queries/omaha_reports_query_test.rb

@@ -0,0 +1,47 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+module Queries
+  class OmahaReportsQueryTest < GraphQLQueryTestCase
+    let(:query) do
+      <<-GRAPHQL
+      query omahaReportsQuery {
+        omahaReports {
+          totalCount
+          pageInfo {
+            startCursor
+            endCursor
+            hasNextPage
+            hasPreviousPage
+          }
+          edges {
+            cursor
+            node {
+              id
+              status
+              omahaVersion
+            }
+          }
+        }
+      }
+      GRAPHQL
+    end
+
+    let(:data) { result['data']['omahaReports'] }
+
+    setup do
+      FactoryBot.create_list(:omaha_report, 2)
+    end
+
+    test 'fetching omaha reports attributes' do
+      assert_empty result['errors']
+
+      expected_count = ForemanOmaha::OmahaReport.count
+
+      assert_not_equal 0, expected_count
+      assert_equal expected_count, data['totalCount']
+      assert_equal expected_count, data['edges'].count
+    end
+  end
+end

data/test/test_plugin_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This calls the main test_helper in Foreman-core
 require 'test_helper'
 require 'database_cleaner'

data/test/unit/charts/oem_distribution_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanOmaha

data/test/unit/charts/status_distribution_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanOmaha

data/test/unit/charts/version_distribution_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanOmaha

data/test/unit/group_version_breakdown_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class CurrentVersionBreakdownTest < ActiveSupport::TestCase

data/test/unit/host_status/omaha_status_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class OmahaStatusTest < ActiveSupport::TestCase
@@ -10,10 +12,10 @@ class OmahaStatusTest < ActiveSupport::TestCase
   end
 
   test '#relevant? is only for hosts with an omaha facet' do
-    assert_equal true, status.relevant?
+    assert status.relevant?
 
     status.host = FactoryBot.build_stubbed(:host)
 
-    assert_equal false, status.relevant?
+    assert_not status.relevant?
   end
 end

data/test/unit/host_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class HostTest < ActiveSupport::TestCase

data/test/unit/omaha_fact_parser_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 class OmahaFactsParserTest < ActiveSupport::TestCase
@@ -19,7 +21,8 @@ class OmahaFactsParserTest < ActiveSupport::TestCase
       'osminor' => '9.0',
       'ipaddress' => '127.0.0.1',
       'ipaddress6' => '',
-      'hostname' => 'client.example.com'
+      'hostname' => 'client.example.com',
+      'distribution' => 'coreos'
     }
   end
   let(:importer) { ::ForemanOmaha::FactParser.new(facts) }
@@ -35,17 +38,53 @@ class OmahaFactsParserTest < ActiveSupport::TestCase
 
   context '#operatingsystem' do
     let(:os) { importer.operatingsystem }
+    let(:expected_os_default_templates) do
+      OsDefaultTemplate.joins(:provisioning_template)
+                       .where(operatingsystem: os)
+                       .where(templates: { name: Setting[:default_host_init_config_template] })
+    end
+
+    context 'without distribution fact' do
+      setup do
+        facts.delete('distribution')
+      end
+
+      test 'should return an OS with correct params' do
+        assert_equal 'CoreOS', os.name
+        assert_equal 'CoreOS 1068.9.0', os.description
+      end
+    end
 
-    test 'should return an OS with correct params' do
-      assert_kind_of Operatingsystem, os
-      assert_equal '1068', os.major
-      assert_equal '9.0', os.minor
-      assert_equal 'CoreOS', os.name
-      assert_equal 'CoreOS 1068.9.0', os.description
-      assert_equal 'stable', os.release_name
-      assert_empty os.ptables
-      assert_empty os.media
-      assert_empty os.os_default_templates
+    context 'CoreOS' do
+      test 'should return an OS with correct params' do
+        assert_kind_of Operatingsystem, os
+        assert_equal '1068', os.major
+        assert_equal '9.0', os.minor
+        assert_equal 'CoreOS', os.name
+        assert_equal 'CoreOS 1068.9.0', os.description
+        assert_equal 'stable', os.release_name
+        assert_empty os.ptables
+        assert_empty os.media
+        assert_same_elements os.os_default_templates, expected_os_default_templates
+      end
+    end
+
+    context 'Flatcar' do
+      setup do
+        facts['distribution'] = 'flatcar'
+      end
+
+      test 'should return an OS with correct params' do
+        assert_kind_of Operatingsystem, os
+        assert_equal '1068', os.major
+        assert_equal '9.0', os.minor
+        assert_equal 'Flatcar', os.name
+        assert_equal 'Flatcar 1068.9.0', os.description
+        assert_equal 'stable', os.release_name
+        assert_empty os.ptables
+        assert_empty os.media
+        assert_same_elements os.os_default_templates, expected_os_default_templates
+      end
     end
 
     context 'with old versions' do
@@ -54,23 +93,28 @@ class OmahaFactsParserTest < ActiveSupport::TestCase
                           :major => '899',
                           :minor => '17.0',
                           :title => 'CoreOS 899.17.0')
-        @previous = FactoryBot.create(:coreos,
-                                      :with_associations,
-                                      :with_provision,
-                                      :major => '1010',
-                                      :minor => '5.0',
-                                      :title => 'CoreOS 1010.5.0')
+
+        previous.reload
+      end
+
+      let(:previous) do
+        FactoryBot.create(:coreos,
+                          :with_associations,
+                          :with_provision,
+                          :major => '1010',
+                          :minor => '5.0',
+                          :title => 'CoreOS 1010.5.0')
       end
 
       test 'should copy attributes from previous os version' do
         assert_equal '1068', os.major
         assert_equal '9.0', os.minor
-        assert_equal @previous.ptables, os.ptables
-        assert_equal @previous.architectures, os.architectures
-        assert_equal @previous.media, os.media
-        assert_equal @previous.os_default_templates.map(&:provisioning_template), os.os_default_templates.map(&:provisioning_template)
-        assert_equal @previous.os_default_templates.map(&:template_kind), os.os_default_templates.map(&:template_kind)
-        assert_equal @previous.provisioning_templates, os.provisioning_templates
+        assert_equal previous.ptables, os.ptables
+        assert_equal previous.architectures, os.architectures
+        assert_equal previous.media, os.media
+        assert_same_elements previous.os_default_templates.map(&:template_kind), os.os_default_templates.map(&:template_kind)
+        assert_same_elements previous.os_default_templates.map(&:provisioning_template), os.os_default_templates.map(&:provisioning_template)
+        assert_same_elements previous.provisioning_templates, os.provisioning_templates
       end
     end
   end

data/test/unit/omaha_report_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 class OmahaReportTest < ActiveSupport::TestCase

data/test/unit/renderer_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_plugin_helper'
 
 module ForemanOmaha