foreman_netbox 1.1.1 → 2.0.0

data/test/services/foreman_netbox/netbox_attributes_test.rb

@@ -16,7 +16,7 @@ module ForemanNetbox
       let(:expected) do
         {
           name: 'Tenant Name',
-          slug: 'tenant-name'
+          slug: 'tenant-name',
         }
       end
 
@@ -33,7 +33,7 @@ module ForemanNetbox
       let(:expected) do
         {
           name: 'device_name',
-          serial: 'abc123'
+          serial: 'abc123',
         }
       end
 
@@ -62,7 +62,7 @@ module ForemanNetbox
       let(:expected) do
         {
           model: 'Product Name',
-          slug: 'product-name'
+          slug: 'product-name',
         }
       end
 
@@ -74,7 +74,7 @@ module ForemanNetbox
         let(:expected) do
           {
             model: 'Unknown',
-            slug: 'unknown'
+            slug: 'unknown',
           }
         end
 
@@ -120,7 +120,7 @@ module ForemanNetbox
       let(:expected) do
         {
           name: 'Site Name',
-          slug: 'site-name'
+          slug: 'site-name',
         }
       end
 
@@ -137,7 +137,7 @@ module ForemanNetbox
               :nic_base,
               identifier: expected.first[:name],
               mac: expected.first[:mac_address]
-            )
+            ),
           ]
         )
       end
@@ -147,8 +147,8 @@ module ForemanNetbox
           name: 'eth1',
           mac_address: 'FE:13:C6:44:29:24',
           type: {
-            value: 'virtual'
-          }
+            value: 'virtual',
+          },
         ]
       end
 
@@ -178,7 +178,7 @@ module ForemanNetbox
                 :subnet_ipv6,
                 cidr: expected.second[:address].split('/').second
               )
-            )
+            ),
           ]
         )
       end
@@ -188,15 +188,15 @@ module ForemanNetbox
           {
             address: '10.0.0.1/24',
             interface: {
-              name: 'eth1'
-            }
+              name: 'eth1',
+            },
           },
           {
             address: '1500:0:2d0:201::1/64',
             interface: {
-              name: 'eth2'
-            }
-          }
+              name: 'eth2',
+            },
+          },
         ]
       end
 
@@ -213,7 +213,7 @@ module ForemanNetbox
               memory_mb: expected[:memory],
               volumes: [
                 OpenStruct.new(size_gb: expected[:disk] / 2),
-                OpenStruct.new(size_gb: expected[:disk] / 2)
+                OpenStruct.new(size_gb: expected[:disk] / 2),
               ]
             )
           )
@@ -225,7 +225,7 @@ module ForemanNetbox
           name: 'virtual_machine_name',
           vcpus: 2,
           memory: 128,
-          disk: 20
+          disk: 20,
         }
       end
 

data/test/services/foreman_netbox/netbox_parameters_comparator_test.rb

@@ -10,8 +10,8 @@ module ForemanNetbox
       let(:my_hash) do
         {
           device: {
-            name: 'My device'
-          }
+            name: 'My device',
+          },
         }
       end
       let(:old_hash) { my_hash }
@@ -25,82 +25,82 @@ module ForemanNetbox
       let(:old_hash) do
         {
           device: {
-            name: 'Old name'
+            name: 'Old name',
           },
           device_role: {
-            name: 'SERVER'
+            name: 'SERVER',
           },
           manufacturer: {
-            name: 'Manufacturer'
+            name: 'Manufacturer',
           },
           interfaces: [
             {
               name: 'eth0',
               type: {
-                value: 'virtual'
-              }
+                value: 'virtual',
+              },
             },
             {
               name: 'eth1',
               type: {
-                value: 'virtual'
-              }
+                value: 'virtual',
+              },
             },
             {
               name: 'eth2',
               type: {
-                value: 'virtual'
-              }
+                value: 'virtual',
+              },
             },
             {
               name: 'eth4',
               mac_address: '00:50:56:84:6D:84',
               type: {
-                value: 'virtual'
-              }
-            }
-          ]
+                value: 'virtual',
+              },
+            },
+          ],
         }
       end
 
       let(:new_hash) do
         {
           device: {
-            name: 'New name'
+            name: 'New name',
           },
           device_type: {
-            model: 'Model name'
+            model: 'Model name',
           },
           manufacturer: {
-            name: 'Manufacturer'
+            name: 'Manufacturer',
           },
           interfaces: [
             {
               name: 'eth0',
               type: {
-                value: 'virtual'
-              }
+                value: 'virtual',
+              },
             },
             {
               name: 'eth1',
               type: {
-                value: 'new_type'
-              }
+                value: 'new_type',
+              },
             },
             {
               name: 'eth3',
               type: {
-                value: 'virtual'
-              }
+                value: 'virtual',
+              },
             },
             {
               name: 'eth4',
               mac_address: '00:50:56:84:6D:84',
               type: {
-                value: 'virtual'
-              }
-            }
-          ]
+                value: 'virtual',
+              },
+            },
+          ],
         }
       end
 
@@ -111,12 +111,12 @@ module ForemanNetbox
           device: {
             name: {
               old: old_hash.dig(:device, :name), new: new_hash.dig(:device, :name)
-            }
+            },
           },
           interfaces: {
             added: new_hash[:interfaces].select { |i| %w[eth1 eth3].include?(i[:name]) },
-            removed: old_hash[:interfaces].select { |i| %w[eth1 eth2].include?(i[:name]) }
-          }
+            removed: old_hash[:interfaces].select { |i| %w[eth1 eth2].include?(i[:name]) },
+          },
         }
       end
 

data/test/test_plugin_helper.rb

@@ -27,6 +27,6 @@ end
 
 def default_tags
   ForemanNetbox::SyncHost::SyncTags::Organizer::DEFAULT_TAGS.map.with_index(1) do |tag, id|
-    ForemanNetbox::API.client::Extras::Tag.new(id: id, name: tag[:name], slug: tag[:slug])
+    ForemanNetbox::Api.client::Extras::Tag.new(id: id, name: tag[:name], slug: tag[:slug])
   end
 end

data/test/unit/foreman_netbox/api_test.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+module ForemanNetbox
+  class ApiTest < ActiveSupport::TestCase
+    describe '.netbox_api_url' do
+      subject { described_class.netbox_api_url }
+
+      let(:netbox1_url) { 'https://netbox1.com' }
+      let(:netbox1_api_url) { "#{netbox1_url}/api" }
+      let(:netbox2_api_url) { 'https://netbox1.com/api' }
+
+      context 'when only the netbox_url setting is set' do
+        setup do
+          Setting[:netbox_url] = netbox1_url
+        end
+
+        it 'returns the URL to the Netbox API' do
+          assert_equal netbox1_api_url, subject
+        end
+      end
+
+      context 'when only the netbox_api_url setting is set' do
+        setup do
+          Setting[:netbox_api_url] = netbox2_api_url
+        end
+
+        it 'returns the URL to the Netbox API' do
+          assert_equal netbox2_api_url, subject
+        end
+      end
+
+      context 'when both netbox_url and netbox_api_url setting are set' do
+        setup do
+          Setting[:netbox_url] = netbox1_api_url
+          Setting[:netbox_api_url] = netbox2_api_url
+        end
+
+        it 'returns the URL to the Netbox API from netbox_api_url setting' do
+          assert_equal netbox2_api_url, subject
+        end
+      end
+
+      context 'when neither setting netbox_url nor netbox_api_url is set' do
+        it 'raises exception' do
+          assert_raises(Foreman::Exception) { subject }
+        end
+      end
+    end
+  end
+end