foreman_netbox 1.1.1 → 1.2.0

data/app/services/foreman_netbox/netbox_parameters_comparator.rb

@@ -32,22 +32,27 @@ module ForemanNetbox
     def keys_diff
       result = {}
 
-      result[:added] = added_keys.each_with_object({}) { |key, memo| memo[key] = new_hash[key] } if added_keys.any?
-      result[:removed] = removed_keys.each_with_object({}) { |key, memo| memo[key] = old_hash[key] } if removed_keys.any?
+      result[:added] = added_keys.index_with { |key| new_hash[key] } if added_keys.any?
+      if removed_keys.any?
+        result[:removed] = removed_keys.index_with do |key|
+          old_hash[key]
+        end
+      end
 
       result
     end
 
     def diff_old
       old_hash.except(*removed_keys).each_with_object({}) do |(key, old_value), memo|
-        if old_value.is_a?(Hash)
+        case old_value
+        when Hash
           new_value = new_hash.fetch(key, {})
           diff = ForemanNetbox::NetboxParametersComparator.call(old_value, new_value)
 
           next unless diff.keys.any?
 
           memo[key] = diff
-        elsif old_value.is_a?(Array)
+        when Array
           next if new_hash[key]
 
           memo[key] = { added: [], removed: old_value }
@@ -64,7 +69,8 @@ module ForemanNetbox
     # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
     def diff_new
       new_hash.except(*added_keys).each_with_object({}) do |(key, new_value), memo|
-        if new_value.is_a?(Hash)
+        case new_value
+        when Hash
           old_value = old_hash.fetch(key, {})
 
           next if old_value == new_value
@@ -74,7 +80,7 @@ module ForemanNetbox
           next unless diff.keys.any?
 
           memo[key] = diff
-        elsif new_value.is_a?(Array)
+        when Array
           old_value = old_hash.fetch(key, [])
           added = new_value.reject { |item| old_value.find { |x| x == item } }
           removed = old_value.reject { |item| new_value.find { |x| x == item } }

data/lib/foreman_netbox/engine.rb

@@ -17,7 +17,7 @@ module ForemanNetbox
       end
     end
 
-    initializer 'foreman_netbox.register_plugin', :before => :finisher_hook do |_app|
+    initializer 'foreman_netbox.register_plugin', before: :finisher_hook do |_app|
       Foreman::Plugin.register :foreman_netbox do
         requires_foreman '>= 3.1'
 
@@ -29,33 +29,33 @@ module ForemanNetbox
         # extend host show page
         extend_page('hosts/show') do |context|
           context.add_pagelet :main_tabs,
-                              name: N_('Netbox'),
-                              partial: 'hosts/netbox_tab',
-                              onlyif: proc { |host| host.netbox_facet.synchronized_at }
+            name: N_('Netbox'),
+            partial: 'hosts/netbox_tab',
+            onlyif: proc { |host| host.netbox_facet.synchronized_at }
         end
 
         settings do
           category(:netbox, N_('Netbox')) do
             setting 'netbox_url',
-                    type: :string,
-                    default: '-',
-                    full_name: N_('Netbox URL'),
-                    description: N_('URL where Netbox is reachable')
+              type: :string,
+              default: '-',
+              full_name: N_('Netbox URL'),
+              description: N_('URL where Netbox is reachable')
             setting 'netbox_api_token',
-                    type: :string,
-                    default: '-',
-                    full_name: N_('Netbox API token'),
-                    description: N_('API token to Netbox')
+              type: :string,
+              default: '-',
+              full_name: N_('Netbox API token'),
+              description: N_('API token to Netbox')
             setting 'netbox_orchestration_enabled',
-                    type: :boolean,
-                    default: false,
-                    full_name: N_('Netbox Orchestration'),
-                    description: N_('Enable Netbox Orchestration')
+              type: :boolean,
+              default: false,
+              full_name: N_('Netbox Orchestration'),
+              description: N_('Enable Netbox Orchestration')
             setting 'netbox_skip_site_update',
-                    type: :boolean,
-                    default: false,
-                    full_name: N_('Skip Site Update'),
-                    description: N_('Skip updating Site attribute for Devices')
+              type: :boolean,
+              default: false,
+              full_name: N_('Skip Site Update'),
+              description: N_('Skip updating Site attribute for Devices')
           end
         end
 

data/lib/foreman_netbox/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ForemanNetbox
-  VERSION = '1.1.1'
+  VERSION = '1.2.0'
 end

data/lib/tasks/foreman_netbox_tasks.rake

@@ -60,8 +60,6 @@ Rake::Task[:test].enhance ['test:foreman_netbox']
 
 load 'tasks/jenkins.rake'
 
-# rubocop:disable Style/IfUnlessModifier
 if Rake::Task.task_defined?(:'jenkins:unit')
   Rake::Task['jenkins:unit'].enhance ['test:foreman_netbox', 'foreman_netbox:rubocop']
 end
-# rubocop:enable Style/IfUnlessModifier

data/test/integration/foreman_netbox/sync_k8s_physical_host_test.rb

@@ -32,7 +32,7 @@ class SyncK8sPhysicalHostTest < ActiveSupport::TestCase
           mac: '45:E9:6A:83:02:20',
           ip6: '1600:0:2d0:202::17',
           subnet6: FactoryBot.build_stubbed(:subnet_ipv6, organizations: [], locations: [])
-        )
+        ),
       ]
     ).tap do |host|
       host.stubs(:ip).returns(host.interfaces.find(&:ip).ip)
@@ -71,15 +71,15 @@ class SyncK8sPhysicalHostTest < ActiveSupport::TestCase
     end
 
     expected_tag_ids = subject.tags.pluck('id')
-    assert (expected_tag_ids - subject.device.tags.pluck('id')).empty?
-    assert (expected_tag_ids - subject.device_type.tags.pluck('id')).empty?
-    assert (expected_tag_ids - subject.site.tags.pluck('id')).empty?
-    assert (expected_tag_ids - subject.tenant.tags.pluck('id')).empty?
+    assert_empty(expected_tag_ids - subject.device.tags.pluck('id'))
+    assert_empty(expected_tag_ids - subject.device_type.tags.pluck('id'))
+    assert_empty(expected_tag_ids - subject.site.tags.pluck('id'))
+    assert_empty(expected_tag_ids - subject.tenant.tags.pluck('id'))
     subject.interfaces.reload.each do |interface|
-      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
+      assert_empty(expected_tag_ids - interface.tags.pluck('id'))
     end
     subject.ip_addresses.reload.each do |interface|
-      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
+      assert_empty(expected_tag_ids - interface.tags.pluck('id'))
     end
   end
 end

data/test/integration/foreman_netbox/sync_rhel_physical_host_test.rb

@@ -32,7 +32,7 @@ class SyncRhelPhysicalHostTest < ActiveSupport::TestCase
           mac: '45:E9:6A:83:02:21',
           ip6: '1600:0:2d0:202::18',
           subnet6: FactoryBot.build_stubbed(:subnet_ipv6, organizations: [], locations: [])
-        )
+        ),
       ]
     ).tap do |host|
       host.stubs(:ip).returns(host.interfaces.find(&:ip).ip)
@@ -71,15 +71,15 @@ class SyncRhelPhysicalHostTest < ActiveSupport::TestCase
     end
 
     expected_tag_ids = subject.tags.pluck('id')
-    assert (expected_tag_ids - subject.device.tags.pluck('id')).empty?
-    assert (expected_tag_ids - subject.device_type.tags.pluck('id')).empty?
-    assert (expected_tag_ids - subject.site.tags.pluck('id')).empty?
-    assert (expected_tag_ids - subject.tenant.tags.pluck('id')).empty?
+    assert_empty(expected_tag_ids - subject.device.tags.pluck('id'))
+    assert_empty(expected_tag_ids - subject.device_type.tags.pluck('id'))
+    assert_empty(expected_tag_ids - subject.site.tags.pluck('id'))
+    assert_empty(expected_tag_ids - subject.tenant.tags.pluck('id'))
     subject.interfaces.reload.each do |interface|
-      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
+      assert_empty(expected_tag_ids - interface.tags.pluck('id'))
     end
     subject.ip_addresses.reload.each do |interface|
-      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
+      assert_empty(expected_tag_ids - interface.tags.pluck('id'))
     end
   end
 end

data/test/integration/foreman_netbox/sync_rhel_virtual_host_test.rb

@@ -31,7 +31,7 @@ class SyncRhelVirtualHostTest < ActiveSupport::TestCase
           mac: '45:E9:6A:83:02:22',
           ip6: '1600:0:2d0:202::19',
           subnet6: FactoryBot.build_stubbed(:subnet_ipv6, organizations: [], locations: [])
-        )
+        ),
       ]
     ).tap do |host|
       host.stubs(:ip).returns(host.interfaces.find(&:ip).ip)
@@ -46,7 +46,7 @@ class SyncRhelVirtualHostTest < ActiveSupport::TestCase
           cpus: 1,
           memory_mb: 1024,
           volumes: [
-            OpenStruct.new(size_gb: 120)
+            OpenStruct.new(size_gb: 120),
           ]
         )
       )
@@ -84,14 +84,14 @@ class SyncRhelVirtualHostTest < ActiveSupport::TestCase
     end
 
     expected_tag_ids = subject.tags.pluck('id')
-    assert (expected_tag_ids - subject.virtual_machine.tags.pluck('id')).empty?
-    assert (expected_tag_ids - subject.tenant.tags.pluck('id')).empty?
-    assert (expected_tag_ids - subject.cluster.tags.pluck('id')).empty?
+    assert_empty(expected_tag_ids - subject.virtual_machine.tags.pluck('id'))
+    assert_empty(expected_tag_ids - subject.tenant.tags.pluck('id'))
+    assert_empty(expected_tag_ids - subject.cluster.tags.pluck('id'))
     subject.interfaces.reload.each do |interface|
-      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
+      assert_empty(expected_tag_ids - interface.tags.pluck('id'))
     end
     subject.ip_addresses.reload.each do |interface|
-      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
+      assert_empty(expected_tag_ids - interface.tags.pluck('id'))
     end
   end
 end

data/test/interactors/foreman_netbox/sync_host/organizer_test.rb

@@ -20,7 +20,7 @@ class SyncHostOrganizerTest < ActiveSupport::TestCase
     # rubocop:disable Layout/FirstArrayElementIndentation
     default_tags.each do |tag|
       stub_get_netbox_request("extras/tags.json?limit=50&slug=#{tag.slug}", results: [
-        { id: tag.id, name: tag.name, slug: tag.slug }
+        { id: tag.id, name: tag.name, slug: tag.slug },
       ])
       stub_request(:get, "#{Setting[:netbox_url]}/api/extras/tags/#{tag.id}.json")
         .to_return(
@@ -28,27 +28,27 @@ class SyncHostOrganizerTest < ActiveSupport::TestCase
           body: {
             id: tag.id,
             name: tag.name,
-            slug: tag.slug
+            slug: tag.slug,
           }.to_json
         )
     end
     stub_get_netbox_request('tenancy/tenants.json?limit=50&slug=admin-user', results: [
-      { id: 1, name: host.owner.name, slug: host.owner.name.parameterize, tags: tags }
+      { id: 1, name: host.owner.name, slug: host.owner.name.parameterize, tags: tags },
     ])
     stub_get_netbox_request('dcim/sites.json?limit=50&slug=location-1', results: [
-      { id: 1, name: host.location.netbox_site_name, slug: host.location.netbox_site_slug, tags: tags }
+      { id: 1, name: host.location.netbox_site_name, slug: host.location.netbox_site_slug, tags: tags },
     ])
     stub_get_netbox_request('dcim/device-roles.json?limit=50&slug=server', results: [
-      { id: 1, name: 'Device Role', slug: 'server' }
+      { id: 1, name: 'Device Role', slug: 'server' },
     ])
     stub_get_netbox_request('dcim/manufacturers.json?limit=50&slug=unknown', results: [
-      { id: 1, name: 'Unknown', slug: 'unknown' }
+      { id: 1, name: 'Unknown', slug: 'unknown' },
     ])
     stub_get_netbox_request('dcim/device-types.json?limit=50&slug=unknown', results: [
-      { id: 1, name: 'Unknown', slug: 'unknown', tags: tags }
+      { id: 1, name: 'Unknown', slug: 'unknown', tags: tags },
     ])
     stub_get_netbox_request("dcim/devices.json?limit=50&serial=#{host.facts[:serialnumber]}", results: [
-      { id: 1, name: host.name, serial: host.facts[:serialnumber], tags: tags }
+      { id: 1, name: host.name, serial: host.facts[:serialnumber], tags: tags },
     ])
     stub_get_netbox_request('dcim/interfaces.json?device_id=1&limit=50', results: [])
     stub_get_netbox_request('ipam/ip-addresses.json?device_id=1&limit=50', results: [])
@@ -87,7 +87,7 @@ class SyncHostOrganizerTest < ActiveSupport::TestCase
       status: 200, headers: { 'Content-Type': 'application/json' },
       body: {
         count: 1,
-        results: results
+        results: results,
       }.to_json
     )
   end

data/test/interactors/foreman_netbox/sync_host/sync_device/create_test.rb

@@ -45,7 +45,7 @@ class CreateDeviceTest < ActiveSupport::TestCase
           device_role: device_role.id,
           site: site.id,
           tenant: tenant.id,
-          tags: tags.map(&:id)
+          tags: tags.map(&:id),
         }.to_json
       ).to_return(
         status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_device_role/create_test.rb

@@ -23,7 +23,7 @@ class CreateDeviceRoleTest < ActiveSupport::TestCase
         body: {
           name: device_role_params[:name],
           color: device_role_params[:color],
-          slug: device_role_params[:slug]
+          slug: device_role_params[:slug],
         }.to_json
       ).to_return(
         status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_device_role/find_test.rb

@@ -28,9 +28,9 @@ class FindDeviceRoleTest < ActiveSupport::TestCase
             {
               id: 1,
               name: device_role_params[:name],
-              slug: device_role_params[:slug]
-            }
-          ]
+              slug: device_role_params[:slug],
+            },
+          ],
         }.to_json
       )
 
@@ -47,7 +47,7 @@ class FindDeviceRoleTest < ActiveSupport::TestCase
         status: 200, headers: { 'Content-Type': 'application/json' },
         body: {
           count: 0,
-          results: []
+          results: [],
         }.to_json
       )
 

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/create_test.rb

@@ -34,7 +34,7 @@ class CreateDeviceTypeTest < ActiveSupport::TestCase
           model: host.netbox_facet.netbox_params.dig(:device_type, :model),
           slug: host.netbox_facet.netbox_params.dig(:device_type, :slug),
           manufacturer: manufacturer.id,
-          tags: default_tags.map(&:id)
+          tags: default_tags.map(&:id),
         }.to_json
       ).to_return(
         status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/find_test.rb

@@ -33,9 +33,9 @@ class FindDeviceTypeTest < ActiveSupport::TestCase
             {
               id: 1,
               name: host.facts.symbolize_keys.fetch(:'dmi::product::name'),
-              slug: slug
-            }
-          ]
+              slug: slug,
+            },
+          ],
         }.to_json
       )
 
@@ -52,7 +52,7 @@ class FindDeviceTypeTest < ActiveSupport::TestCase
         status: 200, headers: { 'Content-Type': 'application/json' },
         body: {
           count: 0,
-          results: []
+          results: [],
         }.to_json
       )
 

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/sync_manufacturer/create_test.rb

@@ -26,7 +26,7 @@ class CreateManufacturerTest < ActiveSupport::TestCase
       stub_post = stub_request(:post, "#{Setting[:netbox_url]}/api/dcim/manufacturers/").with(
         body: {
           name: host.netbox_facet.netbox_params.dig(:manufacturer, :name),
-          slug: host.netbox_facet.netbox_params.dig(:manufacturer, :slug)
+          slug: host.netbox_facet.netbox_params.dig(:manufacturer, :slug),
         }.to_json
       ).to_return(
         status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/sync_manufacturer/find_test.rb

@@ -14,7 +14,7 @@ class FindManufacturerTest < ActiveSupport::TestCase
       host.stubs(:facts).returns(
         {
           'dmi::manufacturer' => 'Manufacturer',
-          'dmi::product::name' => 'device type 2'
+          'dmi::product::name' => 'device type 2',
         }
       )
     end
@@ -34,7 +34,7 @@ class FindManufacturerTest < ActiveSupport::TestCase
           status: 200, headers: { 'Content-Type': 'application/json' },
           body: {
             count: 1,
-            results: [netbox_params.fetch(:manufacturer).merge(id: 1)]
+            results: [netbox_params.fetch(:manufacturer).merge(id: 1)],
           }.to_json
         )
         stub_get_with_name = stub_request(:get, "#{Setting[:netbox_url]}/api/dcim/manufacturers.json").with(
@@ -55,7 +55,7 @@ class FindManufacturerTest < ActiveSupport::TestCase
           status: 200, headers: { 'Content-Type': 'application/json' },
           body: {
             count: 0,
-            results: []
+            results: [],
           }.to_json
         )
         stub_get_with_name = stub_request(:get, "#{Setting[:netbox_url]}/api/dcim/manufacturers.json").with(
@@ -64,7 +64,7 @@ class FindManufacturerTest < ActiveSupport::TestCase
           status: 200, headers: { 'Content-Type': 'application/json' },
           body: {
             count: 1,
-            results: [netbox_params.fetch(:manufacturer).merge(id: 1)]
+            results: [netbox_params.fetch(:manufacturer).merge(id: 1)],
           }.to_json
         )
 
@@ -83,7 +83,7 @@ class FindManufacturerTest < ActiveSupport::TestCase
         status: 200, headers: { 'Content-Type': 'application/json' },
         body: {
           count: 0,
-          results: []
+          results: [],
         }.to_json
       )
 
@@ -93,7 +93,7 @@ class FindManufacturerTest < ActiveSupport::TestCase
         status: 200, headers: { 'Content-Type': 'application/json' },
         body: {
           count: 0,
-          results: []
+          results: [],
         }.to_json
       )
 

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/update_test.rb

@@ -32,7 +32,7 @@ class UpdateDeviceTypeTest < ActiveSupport::TestCase
     it 'updates device type' do
       stub_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/dcim/device-types/1.json").with(
         body: {
-          tags: default_tags.map(&:id)
+          tags: default_tags.map(&:id),
         }.to_json
       ).to_return(
         status: 200, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/create_test.rb

@@ -21,7 +21,7 @@ class CreateDeviceInterfacesTest < ActiveSupport::TestCase
       interfaces: [
         FactoryBot.build_stubbed(:nic_base, mac: 'FE:13:C6:44:29:24', ip: '10.0.0.1', ip6: '1500:0:2d0:201::1'),
         FactoryBot.build_stubbed(:nic_base, mac: 'FE:13:C6:44:29:22', ip: '10.0.0.2', ip6: '1500:0:2d0:201::2'),
-        FactoryBot.build_stubbed(:nic_base, identifier: nil, mac: nil)
+        FactoryBot.build_stubbed(:nic_base, identifier: nil, mac: nil),
       ]
     )
   end
@@ -39,13 +39,13 @@ class CreateDeviceInterfacesTest < ActiveSupport::TestCase
         mac_address: host.interfaces.first.mac.upcase,
         type: ForemanNetbox::NetboxParameters::DEFAULT_INTERFACE_TYPE,
         device: device.id,
-        tags: default_tags.map(&:id)
+        tags: default_tags.map(&:id),
       }.to_json
     ).to_return(
       status: 201, headers: { 'Content-Type': 'application/json' },
       body: {
         id: 1,
-        name: host.interfaces.first.netbox_name
+        name: host.interfaces.first.netbox_name,
       }.to_json
     )
 

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/delete_test.rb

@@ -25,7 +25,7 @@ class DeleteDeviceInterfacesTest < ActiveSupport::TestCase
       status: 200, headers: { 'Content-Type': 'application/json' },
       body: {
         count: 1,
-        results: [{ id: interface_id, name: 'eth0' }]
+        results: [{ id: interface_id, name: 'eth0' }],
       }.to_json
     )
   end

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/find_test.rb

@@ -24,8 +24,8 @@ class FindDeviceInterfacesTest < ActiveSupport::TestCase
         body: {
           count: 1,
           results: [
-            { id: 1 }
-          ]
+            { id: 1 },
+          ],
         }.to_json
       )
 
@@ -42,11 +42,11 @@ class FindDeviceInterfacesTest < ActiveSupport::TestCase
         status: 200, headers: { 'Content-Type': 'application/json' },
         body: {
           count: 0,
-          results: []
+          results: [],
         }.to_json
       )
 
-      assert_equal [], subject.interfaces.map(&:id)
+      assert_empty subject.interfaces.map(&:id)
       assert_requested(stub_get)
     end
   end

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/sync_ip_addresses/create_test.rb

@@ -26,7 +26,7 @@ class CreateDeviceIpAddressesTest < ActiveSupport::TestCase
           ip6: '1500:0:2d0:201::1',
           subnet: subnet,
           subnet6: subnet6
-        )
+        ),
       ]
     )
   end
@@ -39,7 +39,7 @@ class CreateDeviceIpAddressesTest < ActiveSupport::TestCase
       status: 200, headers: { 'Content-Type': 'application/json' },
       body: {
         count: 0,
-        results: []
+        results: [],
       }.to_json
     )
     stub_request(:get, "#{Setting[:netbox_url]}/api/ipam/ip-addresses.json").with(
@@ -48,7 +48,7 @@ class CreateDeviceIpAddressesTest < ActiveSupport::TestCase
       status: 200, headers: { 'Content-Type': 'application/json' },
       body: {
         count: 1,
-        results: [{ id: 2 }]
+        results: [{ id: 2 }],
       }.to_json
     )
   end
@@ -59,7 +59,7 @@ class CreateDeviceIpAddressesTest < ActiveSupport::TestCase
         address: host.interfaces.first.netbox_ip,
         assigned_object_type: 'dcim.interface',
         assigned_object_id: interfaces.first.id,
-        tags: default_tags.map(&:id)
+        tags: default_tags.map(&:id),
       }.to_json
     ).to_return(
       status: 201, headers: { 'Content-Type': 'application/json' },
@@ -71,7 +71,7 @@ class CreateDeviceIpAddressesTest < ActiveSupport::TestCase
         address: host.interfaces.first.netbox_ip6,
         assigned_object_type: 'dcim.interface',
         assigned_object_id: interfaces.first.id,
-        tags: default_tags.map(&:id)
+        tags: default_tags.map(&:id),
       }.to_json
     ).to_return(
       status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/sync_ip_addresses/delete_test.rb

@@ -19,7 +19,7 @@ class DeleteDeviceIpAddressesTest < ActiveSupport::TestCase
           :nic_base,
           ip: '10.0.0.1',
           subnet: FactoryBot.build_stubbed(:subnet_ipv4)
-        )
+        ),
       ]
     )
   end
@@ -39,8 +39,8 @@ class DeleteDeviceIpAddressesTest < ActiveSupport::TestCase
       body: {
         count: 1,
         results: [
-          { id: interface_id, name: host.interfaces.first.netbox_name }
-        ]
+          { id: interface_id, name: host.interfaces.first.netbox_name },
+        ],
       }.to_json
     )
     stub_request(:get, "#{Setting[:netbox_url]}/api/ipam/ip-addresses.json").with(
@@ -51,8 +51,8 @@ class DeleteDeviceIpAddressesTest < ActiveSupport::TestCase
         count: 2,
         results: [
           { id: ip_addresses_v4_id, address: ip_addresses_v4, assigned_object_type: 'dcim.interface', assigned_object_id: interface_id },
-          { id: ip_addresses_v6_id, address: ip_addresses_v6, assigned_object_type: 'dcim.interface', assigned_object_id: interface_id }
-        ]
+          { id: ip_addresses_v6_id, address: ip_addresses_v6, assigned_object_type: 'dcim.interface', assigned_object_id: interface_id },
+        ],
       }.to_json
     )
   end

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/sync_ip_addresses/find_test.rb

@@ -23,7 +23,7 @@ class FindDeviceIpAddressesTest < ActiveSupport::TestCase
         status: 200, headers: { 'Content-Type': 'application/json' },
         body: {
           count: 1,
-          results: [{ id: 1 }]
+          results: [{ id: 1 }],
         }.to_json
       )
 
@@ -40,11 +40,11 @@ class FindDeviceIpAddressesTest < ActiveSupport::TestCase
         status: 200, headers: { 'Content-Type': 'application/json' },
         body: {
           count: 0,
-          results: []
+          results: [],
         }.to_json
       )
 
-      assert_equal [], subject.ip_addresses.map(&:id)
+      assert_empty subject.ip_addresses.map(&:id)
       assert_requested(stub_get)
     end
   end

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/sync_ip_addresses/update_test.rb

@@ -16,7 +16,7 @@ class UpdateDeviceIpAddressesTest < ActiveSupport::TestCase
   let(:ip_addresses_data) do
     [
       { id: 1, address: host.netbox_facet.netbox_params[:ip_addresses].first[:address], tags: tags_data },
-      { id: 2, address: host.netbox_facet.netbox_params[:ip_addresses].second[:address], tags: [] }
+      { id: 2, address: host.netbox_facet.netbox_params[:ip_addresses].second[:address], tags: [] },
     ]
   end
   let(:host) do
@@ -30,7 +30,7 @@ class UpdateDeviceIpAddressesTest < ActiveSupport::TestCase
           ip6: '1600:0:2d0:202::17',
           subnet: FactoryBot.build_stubbed(:subnet_ipv4, organizations: [], locations: []),
           subnet6: FactoryBot.build_stubbed(:subnet_ipv6, organizations: [], locations: [])
-        )
+        ),
       ]
     )
   end
@@ -43,7 +43,7 @@ class UpdateDeviceIpAddressesTest < ActiveSupport::TestCase
       status: 200, headers: { 'Content-Type': 'application/json' },
       body: {
         count: ip_addresses_data.count,
-        results: ip_addresses_data
+        results: ip_addresses_data,
       }.to_json
     )
   end
@@ -52,7 +52,7 @@ class UpdateDeviceIpAddressesTest < ActiveSupport::TestCase
     stub_unexpected_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/ipam/ip-addresses/#{ip_addresses_data.first[:id]}.json")
     stub_expected_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/ipam/ip-addresses/#{ip_addresses_data.second[:id]}.json").with(
       body: {
-        tags: default_tags.map(&:id)
+        tags: default_tags.map(&:id),
       }.to_json
     ).to_return(
       status: 200, headers: { 'Content-Type': 'application/json' },