foreman_netbox 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9df549aa83fb9c91e18bba3c2690cb6f9c14977ca2364198b12b20cc01140069
-  data.tar.gz: 0adf0c06724a964efa56d7ca8b294ca73882c351a50c8063a1906f4ad3a429ac
+  metadata.gz: 4b8ad442bf38c2bf5ac0ed5b94580b108a16d267a2ae2a37f456a73ebb1f8cd6
+  data.tar.gz: e31f39d22ea73a0bda27093a4f8474740836899c4d0379cc8763a1b9ec766e24
 SHA512:
-  metadata.gz: dcd1893a719badc47fe8d083a46fa5ee403bc9f1c31a0963d05624c34f00dad74a8320cdaaf0917e6fc484c899f62fe56db277642e62ba240ef471d1214bd67c
-  data.tar.gz: 1e3e688b369849e00c54440e4de52507bdefd30109d4688fc478b22a1ceaa751593859be6fbc8480ce60a6ee0050f0ab783dbfc721df428d93aa3bfd44feb7de
+  metadata.gz: ab087e119d4a0fd10f4847a4e6aaa829e55e2b1036393058ccc90363a098ea12fa156fd7f62c1eba98d0e2a15e0f3fd0aeec77d65f4a78a515ff6b16b6739f13
+  data.tar.gz: 47561411ae532f4229a45ce71443f89fadc94aae271d25be9e201148500cfa7f013ff7e24c94c1134738e95f7a200ed204378a4dee65cd72e7694e64f81c5911

data/README.md

@@ -10,6 +10,7 @@ This is a plugin for Foreman that introduces integration with [NetBox](https://n
 | -------------- | -------------- |
 | 2.8            | 1.0            |
 | 2.11           | 1.1            |
+| 3.3            | 1.2            |
 
 ## Installation
 

data/app/contracts/foreman_netbox/device_contract.rb

@@ -4,9 +4,9 @@ module ForemanNetbox
   class DeviceContract < Dry::Validation::Contract
     # rubocop:disable Metrics/BlockLength
     params do
-      optional(:tenant).hash(ForemanNetbox::Params::TenantParams.new)
-      optional(:ip_addresses).array(ForemanNetbox::Params::IpAddressParams.new)
-      optional(:interfaces).array(ForemanNetbox::Params::InterfaceParams.new)
+      optional(:tenant).hash(ForemanNetbox::Params::TenantParams)
+      optional(:ip_addresses).array(ForemanNetbox::Params::IpAddressParams)
+      optional(:interfaces).array(ForemanNetbox::Params::InterfaceParams)
 
       required(:device).filled(:hash) do
         required(:name).filled(:string)

data/app/contracts/foreman_netbox/params/interface_params.rb

@@ -2,15 +2,13 @@
 
 module ForemanNetbox
   module Params
-    class InterfaceParams < Dry::Schema::Params
-      define do
-        required(:name).filled(:string)
-        required(:type).filled(:hash) do
-          required(:value).filled(:string)
-        end
-        optional(:mac_address).maybe(:string)
-        optional(:tags).array(:string)
+    InterfaceParams = Dry::Schema.Params do
+      required(:name).filled(:string)
+      required(:type).filled(:hash) do
+        required(:value).filled(:string)
       end
+      optional(:mac_address).maybe(:string)
+      optional(:tags).array(:string)
     end
   end
 end

data/app/contracts/foreman_netbox/params/ip_address_params.rb

@@ -2,14 +2,12 @@
 
 module ForemanNetbox
   module Params
-    class IpAddressParams < Dry::Schema::Params
-      define do
-        required(:address).filled(:string)
-        required(:interface).filled(:hash) do
-          required(:name).filled(:string)
-        end
-        optional(:tags).array(:string)
+    IpAddressParams = Dry::Schema.Params do
+      required(:address).filled(:string)
+      required(:interface).filled(:hash) do
+        required(:name).filled(:string)
       end
+      optional(:tags).array(:string)
     end
   end
 end

data/app/contracts/foreman_netbox/params/tenant_params.rb

@@ -2,12 +2,10 @@
 
 module ForemanNetbox
   module Params
-    class TenantParams < Dry::Schema::Params
-      define do
-        required(:name).filled(:string)
-        required(:slug).filled(:string)
-        optional(:tags).array(:string)
-      end
+    TenantParams = Dry::Schema.Params do
+      required(:name).filled(:string)
+      required(:slug).filled(:string)
+      optional(:tags).array(:string)
     end
   end
 end

data/app/contracts/foreman_netbox/virtual_machine_contract.rb

@@ -3,9 +3,9 @@
 module ForemanNetbox
   class VirtualMachineContract < Dry::Validation::Contract
     params do
-      optional(:tenant).hash(ForemanNetbox::Params::TenantParams.new)
-      optional(:ip_addresses).array(ForemanNetbox::Params::IpAddressParams.new)
-      optional(:interfaces).array(ForemanNetbox::Params::InterfaceParams.new)
+      optional(:tenant).hash(ForemanNetbox::Params::TenantParams)
+      optional(:ip_addresses).array(ForemanNetbox::Params::IpAddressParams)
+      optional(:interfaces).array(ForemanNetbox::Params::InterfaceParams)
 
       required(:virtual_machine).filled(:hash) do
         required(:name).filled(:string)

data/app/interactors/foreman_netbox/sync_host/sync_device/save_netbox_url.rb

@@ -21,7 +21,7 @@ module ForemanNetbox
         delegate :url, to: :netbox_facet, prefix: true, allow_nil: true
 
         def netbox_device_url
-          "#{Setting::Netbox[:netbox_url]}/dcim/devices/#{device&.id}" if device&.id
+          "#{Setting[:netbox_url]}/dcim/devices/#{device&.id}" if device&.id
         end
       end
     end

data/app/interactors/foreman_netbox/sync_host/sync_device/update.rb

@@ -62,6 +62,8 @@ module ForemanNetbox
         end
 
         def assign_site
+          return if device.site&.id && Setting[:netbox_skip_site_update]
+
           device.site = site&.id if device.site&.id != site&.id
         end
 

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/save_netbox_url.rb

@@ -23,7 +23,7 @@ module ForemanNetbox
         def netbox_virtual_machine_url
           return unless context.virtual_machine&.id
 
-          "#{Setting::Netbox[:netbox_url]}/virtualization/virtual-machines/#{context.virtual_machine&.id}"
+          "#{Setting[:netbox_url]}/virtualization/virtual-machines/#{context.virtual_machine&.id}"
         end
       end
     end

data/app/lib/foreman_netbox/api.rb

@@ -4,8 +4,8 @@ module ForemanNetbox
   class API
     def self.client
       NetboxClientRuby.configure do |config|
-        config.netbox.api_base_url = "#{Setting::Netbox['netbox_url']}/api"
-        config.netbox.auth.token = Setting::Netbox['netbox_api_token']
+        config.netbox.api_base_url = "#{Setting['netbox_url']}/api"
+        config.netbox.auth.token = Setting['netbox_api_token']
       end
     end
   end

data/app/models/orchestration/netbox.rb

@@ -14,7 +14,7 @@ module Orchestration
     protected
 
     def netbox_orchestration_allowed?
-      Setting::Netbox[:netbox_orchestration_enabled] && netbox_will_change?
+      Setting[:netbox_orchestration_enabled] && netbox_will_change?
     end
 
     def queue_netbox_push

data/db/migrate/20230303095650_fix_netbox_settings_category_to_dsl.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class FixNetboxSettingsCategoryToDsl < ActiveRecord::Migration[6.0]
+  def up
+    # rubocop:disable Rails/SkipsModelValidations
+    Setting.where(category: 'Setting::Netbox').update_all(category: 'Setting') if column_exists?(:settings, :category)
+    # rubocop:enable Rails/SkipsModelValidations
+  end
+end

data/lib/foreman_netbox/engine.rb

@@ -10,14 +10,6 @@ module ForemanNetbox
 
     config.autoload_paths += Dir["#{config.root}/app/interactors"]
 
-    initializer 'foreman_netbox.load_default_settings', before: :load_config_initializers do
-      require_dependency File.expand_path('../../app/models/setting/netbox.rb', __dir__) if begin
-        Setting.table_exists?
-      rescue StandardError
-        (false)
-      end
-    end
-
     # Add any db migrations
     initializer 'foreman_netbox.load_app_instance_data' do |app|
       ForemanNetbox::Engine.paths['db/migrate'].existent.each do |path|
@@ -27,7 +19,7 @@ module ForemanNetbox
 
     initializer 'foreman_netbox.register_plugin', :before => :finisher_hook do |_app|
       Foreman::Plugin.register :foreman_netbox do
-        requires_foreman '>= 1.24'
+        requires_foreman '>= 3.1'
 
         # Netbox Facet
         register_facet(ForemanNetbox::NetboxFacet, :netbox_facet) do
@@ -42,6 +34,31 @@ module ForemanNetbox
                               onlyif: proc { |host| host.netbox_facet.synchronized_at }
         end
 
+        settings do
+          category(:netbox, N_('Netbox')) do
+            setting 'netbox_url',
+                    type: :string,
+                    default: '-',
+                    full_name: N_('Netbox URL'),
+                    description: N_('URL where Netbox is reachable')
+            setting 'netbox_api_token',
+                    type: :string,
+                    default: '-',
+                    full_name: N_('Netbox API token'),
+                    description: N_('API token to Netbox')
+            setting 'netbox_orchestration_enabled',
+                    type: :boolean,
+                    default: false,
+                    full_name: N_('Netbox Orchestration'),
+                    description: N_('Enable Netbox Orchestration')
+            setting 'netbox_skip_site_update',
+                    type: :boolean,
+                    default: false,
+                    full_name: N_('Skip Site Update'),
+                    description: N_('Skip updating Site attribute for Devices')
+          end
+        end
+
         logger :import, enabled: true
       end
     end
@@ -54,8 +71,8 @@ module ForemanNetbox
       ::Usergroup.include(ForemanNetbox::UserUsergroupCommonExtensions)
 
       NetboxClientRuby.configure do |config|
-        config.netbox.api_base_url = Setting::Netbox['netbox_url']
-        config.netbox.auth.token = Setting::Netbox['netbox_api_token']
+        config.netbox.api_base_url = Setting['netbox_url']
+        config.netbox.auth.token = Setting['netbox_api_token']
       end
     rescue StandardError => e
       Rails.logger.warn "ForemanNetbox: skipping engine hook (#{e})\n#{e.backtrace.join("\n")}"

data/lib/foreman_netbox/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ForemanNetbox
-  VERSION = '1.1.0'
+  VERSION = '1.1.1'
 end

data/test/integration/foreman_netbox/sync_rhel_virtual_host_test.rb

@@ -61,7 +61,7 @@ class SyncRhelVirtualHostTest < ActiveSupport::TestCase
 
     assert_equal host.name,                                 subject.virtual_machine.name
     assert_equal host.owner.netbox_tenant_name,             subject.virtual_machine.tenant.name
-    assert_equal format('%.2f', host.compute_object.cpus),  subject.virtual_machine.vcpus
+    assert_equal host.compute_object.cpus.to_f,             subject.virtual_machine.vcpus
     assert_equal host.compute_object.memory_mb,             subject.virtual_machine.memory
     assert_equal host.compute_object.volumes.first.size_gb, subject.virtual_machine.disk
     assert_equal host.compute_object.cluster,               subject.virtual_machine.cluster.name

data/test/interactors/foreman_netbox/sync_host/organizer_test.rb

@@ -56,7 +56,7 @@ class SyncHostOrganizerTest < ActiveSupport::TestCase
   end
 
   test 'save synchronization status when it succeeds' do
-    stub_request(:patch, "#{Setting::Netbox[:netbox_url]}/api/dcim/devices/1.json").to_return(
+    stub_request(:patch, "#{Setting[:netbox_url]}/api/dcim/devices/1.json").to_return(
       status: 200, headers: { 'Content-Type': 'application/json' },
       body: { id: 1 }.to_json
     )
@@ -64,12 +64,12 @@ class SyncHostOrganizerTest < ActiveSupport::TestCase
     host.reload
 
     assert_not_nil host.netbox_facet.synchronized_at
-    assert_equal "#{Setting::Netbox[:netbox_url]}/dcim/devices/1", host.netbox_facet.url
+    assert_equal "#{Setting[:netbox_url]}/dcim/devices/1", host.netbox_facet.url
     assert_nil host.netbox_facet.synchronization_error
   end
 
   test 'save synchronization status when it fails' do
-    stub_request(:patch, "#{Setting::Netbox[:netbox_url]}/api/dcim/devices/1.json").to_return(
+    stub_request(:patch, "#{Setting[:netbox_url]}/api/dcim/devices/1.json").to_return(
       status: 500, headers: { 'Content-Type': 'application/json' }
     )
     subject
@@ -83,7 +83,7 @@ class SyncHostOrganizerTest < ActiveSupport::TestCase
   private
 
   def stub_get_netbox_request(path, results:)
-    stub_request(:get, "#{Setting::Netbox[:netbox_url]}/api/#{path}").to_return(
+    stub_request(:get, "#{Setting[:netbox_url]}/api/#{path}").to_return(
       status: 200, headers: { 'Content-Type': 'application/json' },
       body: {
         count: 1,

data/test/interactors/foreman_netbox/sync_host/sync_device/update_test.rb

@@ -199,4 +199,34 @@ class UpdateDeviceTest < ActiveSupport::TestCase
       end
     end
   end
+
+  context 'when netbox_skip_site_update setting is enabled' do
+    setup do
+      Setting[:netbox_skip_site_update] = true
+    end
+
+    let(:new_site_id) { device_data.dig(:site, :id) + 1 }
+    let(:site) { OpenStruct.new(id: new_site_id) }
+    let(:device_tags) do
+      default_tags.map { |t| { 'id' => t.id, 'name' => t.name, 'slug' => t.slug } }
+    end
+
+    it 'does not update site of device' do
+      device_tags.each do |t|
+        stub_request(:get, "#{Setting[:netbox_url]}/api/extras/tags/#{t['id']}.json")
+          .to_return(
+            status: 200, headers: { 'Content-Type': 'application/json' },
+            body: {
+              id: t['id'],
+              name: t['name'],
+              slug: t['slug']
+            }.to_json
+          )
+      end
+      stub_patch = stub_request(:patch, "#{Setting[:netbox_url]}/api/dcim/devices/#{device.id}.json")
+
+      assert_not_equal device.site.id, new_site_id
+      assert_not_requested(stub_patch)
+    end
+  end
 end

data/test/test_plugin_helper.rb

@@ -10,15 +10,10 @@ FactoryBot.definition_file_paths << File.join(File.dirname(__FILE__), 'factories
 FactoryBot.reload
 
 def setup_default_netbox_settings(netbox_url: 'https://netbox.example.com', netbox_api_token: 'api_key')
-  if Gem::Version.new(SETTINGS[:version].notag) < Gem::Version.new('2.6')
-    FactoryBot.create(:setting, name: 'netbox_url', value: netbox_url, category: 'Setting::Netbox')
-    FactoryBot.create(:setting, name: 'netbox_api_token', value: netbox_api_token, category: 'Setting::Netbox')
-    FactoryBot.create(:setting, name: 'netbox_orchestration_enabled', value: true, category: 'Setting::Netbox')
-  else
-    Setting[:netbox_url] = netbox_url
-    Setting[:netbox_api_token] = netbox_api_token
-    Setting[:netbox_orchestration_enabled] = true
-  end
+  Setting[:netbox_url] = netbox_url
+  Setting[:netbox_api_token] = netbox_api_token
+  Setting[:netbox_orchestration_enabled] = true
+  Setting[:netbox_skip_site_update] = false
 end
 
 def setup_netbox_integration_test

metadata

@@ -1,99 +1,129 @@
 --- !ruby/object:Gem::Specification
 name: foreman_netbox
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - dmTECH GmbH
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-11 00:00:00.000000000 Z
+date: 2023-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-configurable
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0.13'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.12.0
+        version: '0.17'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.12.0
+        version: '0.13'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '0.17'
 - !ruby/object:Gem::Dependency
   name: dry-container
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0.7'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: '0.12'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.0
+        version: '0.7'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '0.12'
 - !ruby/object:Gem::Dependency
   name: dry-core
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0.6'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: '0.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: '0.6'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '0.9'
 - !ruby/object:Gem::Dependency
   name: dry-inflector
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.2.0
+        version: 0.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.2.0
+        version: 0.3.0
 - !ruby/object:Gem::Dependency
   name: dry-schema
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.6'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: '1.12'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: '1.6'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1.12'
 - !ruby/object:Gem::Dependency
   name: dry-validation
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.2
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.5.2
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.9.0
 - !ruby/object:Gem::Dependency
   name: interactor
   requirement: !ruby/object:Gem::Requirement
@@ -112,16 +142,22 @@ dependencies:
   name: netbox-client-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.5.5
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 0.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.5.5
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 0.8.0
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
@@ -142,14 +178,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.0
+        version: 1.45.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.0
+        version: 1.45.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -254,7 +290,6 @@ files:
 - app/models/concerns/foreman_netbox/user_usergroup_common_extensions.rb
 - app/models/foreman_netbox/netbox_facet.rb
 - app/models/orchestration/netbox.rb
-- app/models/setting/netbox.rb
 - app/services/foreman_netbox/cached_netbox_parameters.rb
 - app/services/foreman_netbox/netbox_parameters.rb
 - app/services/foreman_netbox/netbox_parameters_comparator.rb
@@ -263,6 +298,7 @@ files:
 - db/migrate/20200527135812_create_netbox_facet.rb
 - db/migrate/20200604141933_add_sync_info_to_netbox_facet.rb
 - db/migrate/20200708093607_add_raw_data_to_netbox_facet.rb
+- db/migrate/20230303095650_fix_netbox_settings_category_to_dsl.rb
 - lib/foreman_netbox.rb
 - lib/foreman_netbox/engine.rb
 - lib/foreman_netbox/version.rb
@@ -348,70 +384,70 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Adds integration with NetBox
 test_files:
+- test/integration/foreman_netbox/sync_rhel_physical_host_test.rb
+- test/integration/foreman_netbox/sync_rhel_virtual_host_test.rb
+- test/integration/foreman_netbox/sync_k8s_physical_host_test.rb
+- test/models/host/managed_test.rb
+- test/models/foreman_netbox/location_test.rb
+- test/models/foreman_netbox/nics/base_test.rb
+- test/models/foreman_netbox/usergroup_test.rb
+- test/models/foreman_netbox/netbox_facet_test.rb
 - test/factories/host.rb
 - test/factories/netbox_facet.rb
-- test/fixtures/facts/k8s_physical_host.json
+- test/fixtures/netbox_virtual_machine_raw_data.json
+- test/fixtures/netbox_device_raw_data.json
 - test/fixtures/facts/rhel_physical_host.json
 - test/fixtures/facts/rhel_virtual_host.json
-- test/fixtures/netbox_device_raw_data.json
-- test/fixtures/netbox_virtual_machine_raw_data.json
-- test/integration/foreman_netbox/sync_k8s_physical_host_test.rb
-- test/integration/foreman_netbox/sync_rhel_physical_host_test.rb
-- test/integration/foreman_netbox/sync_rhel_virtual_host_test.rb
+- test/fixtures/facts/k8s_physical_host.json
+- test/test_plugin_helper.rb
+- test/jobs/foreman_netbox/sync_host_job_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/find_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/update_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/create_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/sync_cluster_type/find_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/sync_cluster_type/create_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/find_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/update_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/delete_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/find_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/update_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/create_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/delete_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/find_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/update_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/create_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/create_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/save_netbox_url_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_tenant/find_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_tenant/update_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_tenant/create_test.rb
 - test/interactors/foreman_netbox/sync_host/organizer_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/create_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/sync_site/find_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/sync_site/update_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/sync_site/create_test.rb
 - test/interactors/foreman_netbox/sync_host/sync_device/find_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/save_netbox_url_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/sync_device_role/create_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/sync_device_role/find_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/create_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/update_test.rb
 - test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/find_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/sync_manufacturer/create_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/sync_manufacturer/find_test.rb
 - test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/update_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/create_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/delete_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/find_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/sync_ip_addresses/create_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/sync_manufacturer/find_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/sync_manufacturer/create_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/create_test.rb
 - test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/sync_ip_addresses/delete_test.rb
 - test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/sync_ip_addresses/find_test.rb
 - test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/sync_ip_addresses/update_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/sync_ip_addresses/create_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/delete_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/find_test.rb
 - test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/update_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/sync_site/create_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/sync_site/find_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/sync_site/update_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_device/update_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_tenant/create_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_tenant/find_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_tenant/update_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/create_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/find_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/save_netbox_url_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/create_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/find_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/sync_cluster_type/create_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/sync_cluster_type/find_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_cluster/update_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/create_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/delete_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/find_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/create_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/delete_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/find_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/update_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/update_test.rb
-- test/interactors/foreman_netbox/sync_host/sync_virtual_machine/update_test.rb
-- test/jobs/foreman_netbox/sync_host_job_test.rb
-- test/models/foreman_netbox/location_test.rb
-- test/models/foreman_netbox/netbox_facet_test.rb
-- test/models/foreman_netbox/nics/base_test.rb
-- test/models/foreman_netbox/usergroup_test.rb
-- test/models/host/managed_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/sync_interfaces/create_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/create_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/sync_device_role/find_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/sync_device_role/create_test.rb
+- test/interactors/foreman_netbox/sync_host/sync_device/save_netbox_url_test.rb
 - test/services/foreman_netbox/netbox_attributes_test.rb
 - test/services/foreman_netbox/netbox_parameters_comparator_test.rb
-- test/test_plugin_helper.rb

data/app/models/setting/netbox.rb

@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-class Setting
-  class Netbox < ::Setting
-    BLANK_ATTRS << 'netbox_url'
-    BLANK_ATTRS << 'netbox_api_token'
-    URI_BLANK_ATTRS << 'netbox_url'
-
-    def self.default_settings
-      [
-        set('netbox_url', N_('URL where Netbox is reachable'), nil, N_('Netbox URL')),
-        set('netbox_api_token', N_('API token to Netbox'), nil, N_('Netbox API token'), nil, encrypted: true),
-        set('netbox_orchestration_enabled', N_('Enable Netbox Orchestration'), false, N_('Netbox Orchestration'))
-      ]
-    end
-
-    def self.load_defaults
-      # Check the table exists
-      return unless super
-
-      transaction do
-        default_settings.each { |s| create! s.update(category: 'Setting::Netbox') }
-      end
-
-      true
-    end
-
-    def self.humanized_category
-      N_('Netbox')
-    end
-  end
-end