foreman_netbox 1.0.2 → 1.1.1

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/create.rb

@@ -7,6 +7,7 @@ module ForemanNetbox
         module SyncIpAddresses
           class Create
             include ::Interactor
+            include ForemanNetbox::Concerns::AssignTags
 
             def call
               netbox_params.fetch(:ip_addresses, []).map do |ip_address|
@@ -16,12 +17,16 @@ module ForemanNetbox
                 next unless ForemanNetbox::API.client
                                               .ipam
                                               .ip_addresses
-                                              .filter(interface_id: interface_id, address: ip_address[:address])
+                                              .filter(vminterface_id: interface_id, address: ip_address[:address])
                                               .total
                                               .zero?
 
                 ForemanNetbox::API.client::IPAM::IpAddress.new(
-                  ip_address.slice(:address, :tags).merge(interface: interface_id)
+                  ip_address.slice(:address)
+                            .merge(
+                              assigned_object_type: 'virtualization.vminterface', assigned_object_id: interface_id,
+                              tags: default_tag_ids
+                            )
                 ).save
               end
             rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/delete.rb

@@ -25,7 +25,7 @@ module ForemanNetbox
                                                                .map { |ip| ip.fetch(:address) }
 
                 context.ip_addresses
-                       .select { |ip| ip['interface']['id'] == netbox_interface.id }
+                       .select { |ip| ip['assigned_object_type'] == 'virtualization.vminterface' && ip['assigned_object_id'] == netbox_interface.id }
                        .reject { |ip| host_interface_ips.include?(ip['address']) }
                        .each(&:delete)
               end

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/sync_ip_addresses/update.rb

@@ -7,12 +7,11 @@ module ForemanNetbox
         module SyncIpAddresses
           class Update
             include ::Interactor
+            include ForemanNetbox::Concerns::AssignTags
 
             def call
               context.ip_addresses.each do |ip_address|
-                new_tags = tags_map.fetch(ip_address[:address], []) - ip_address.tags
-
-                ip_address.tags = (ip_address.tags | new_tags) if new_tags.any?
+                assign_tags_to(ip_address)
 
                 ip_address.save
               end
@@ -20,17 +19,6 @@ module ForemanNetbox
               ::Foreman::Logging.logger('foreman_netbox/import').error("#{self.class} error #{e}: #{e.backtrace}")
               context.fail!(error: "#{self.class}: #{e}")
             end
-
-            private
-
-            delegate :netbox_params, to: :context
-
-            def tags_map
-              netbox_params.fetch(:ip_addresses, [])
-                           .each_with_object({}) do |item, memo|
-                             memo[item[:address]] = item.fetch(:tags, [])
-                           end
-            end
           end
         end
       end

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/sync_interfaces/update.rb

@@ -6,6 +6,7 @@ module ForemanNetbox
       module SyncInterfaces
         class Update
           include ::Interactor
+          include ForemanNetbox::Concerns::AssignTags
 
           def call
             context.interfaces.each { |netbox_interface| update(netbox_interface) }
@@ -22,9 +23,7 @@ module ForemanNetbox
             return unless new_params
 
             netbox_interface.mac_address = new_params[:mac_address] if netbox_interface.mac_address != new_params[:mac_address]
-
-            new_tags = new_params.fetch(:tags, []) - netbox_interface.tags
-            netbox_interface.tags = (netbox_interface.tags | new_tags) if new_tags.any?
+            assign_tags_to(netbox_interface)
 
             netbox_interface.save
           rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e

data/app/interactors/foreman_netbox/sync_host/sync_virtual_machine/update.rb

@@ -6,8 +6,9 @@ module ForemanNetbox
       class Update
         include ::Interactor
         include ForemanNetbox::Concerns::PrimaryIps
+        include ForemanNetbox::Concerns::AssignTags
 
-        ATTRIBUTES = %i[name cluster disk memory primary_ip4 primary_ip6 tenant vcpus tags].freeze
+        ATTRIBUTES = %i[name cluster disk memory primary_ip4 primary_ip6 tenant vcpus].freeze
 
         around do |interactor|
           interactor.call if context.virtual_machine
@@ -19,6 +20,7 @@ module ForemanNetbox
 
         def call
           assign_new_attributes
+          assign_tags_to(virtual_machine)
 
           virtual_machine.save
         rescue NetboxClientRuby::LocalError, NetboxClientRuby::ClientError, NetboxClientRuby::RemoteError => e
@@ -70,12 +72,6 @@ module ForemanNetbox
           vcpus = netbox_params.dig(:virtual_machine, :vcpus)
           virtual_machine.vcpus = vcpus if virtual_machine.vcpus != vcpus
         end
-
-        def assign_tags
-          new_tags = (netbox_params.dig(:virtual_machine, :tags) || []) - virtual_machine.tags
-
-          virtual_machine.tags = (virtual_machine.tags | new_tags) if new_tags.any?
-        end
       end
     end
   end

data/app/lib/foreman_netbox/api.rb

@@ -4,8 +4,8 @@ module ForemanNetbox
   class API
     def self.client
       NetboxClientRuby.configure do |config|
-        config.netbox.api_base_url = "#{Setting::Netbox['netbox_url']}/api"
-        config.netbox.auth.token = Setting::Netbox['netbox_api_token']
+        config.netbox.api_base_url = "#{Setting['netbox_url']}/api"
+        config.netbox.auth.token = Setting['netbox_api_token']
       end
     end
   end

data/app/models/concerns/foreman_netbox/user_usergroup_common_extensions.rb

@@ -2,7 +2,7 @@
 
 module ForemanNetbox
   module UserUsergroupCommonExtensions
-    NETBOX_TENANT_MAX_LENGTH = 30
+    NETBOX_TENANT_MAX_LENGTH = 100
 
     def netbox_tenant_name
       return name unless name.length > NETBOX_TENANT_MAX_LENGTH

data/app/models/orchestration/netbox.rb

@@ -14,7 +14,7 @@ module Orchestration
     protected
 
     def netbox_orchestration_allowed?
-      Setting::Netbox[:netbox_orchestration_enabled] && netbox_will_change?
+      Setting[:netbox_orchestration_enabled] && netbox_will_change?
     end
 
     def queue_netbox_push
@@ -30,6 +30,9 @@ module Orchestration
     def queue_netbox_destroy
       return unless errors.empty? && managed?
 
+      ::Foreman::Logging.logger('foreman_netbox/import')
+                        .info("Queued delete of #{name} from Netbox.")
+
       queue.create(name: _('Delete host %s from Netbox') % self, priority: 60,
                    action: [self, :del_netbox])
     end

data/app/services/foreman_netbox/cached_netbox_parameters.rb

@@ -28,7 +28,7 @@ module ForemanNetbox
       return unless data.keys.include?(:interfaces)
 
       result[:interfaces] = data.fetch(:interfaces, {}).fetch(:results, []).map do |interface|
-        interface.slice(:name, :mac_address, :tags)
+        interface.slice(:name, :mac_address)
                  .merge(type: interface.fetch(:type, {}).slice(:value))
                  .compact
       end
@@ -38,7 +38,7 @@ module ForemanNetbox
       return unless data.keys.include?(:ip_addresses)
 
       result[:ip_addresses] = data.fetch(:ip_addresses, {}).fetch(:results, []).map do |ip_address|
-        ip_address.slice(:address, :tags)
+        ip_address.slice(:address)
                   .merge(interface: ip_address.fetch(:interface, {}).slice(:name))
       end
     end
@@ -46,19 +46,19 @@ module ForemanNetbox
     def read_virtual_machine
       return unless data.keys.include?(:virtual_machine)
 
-      result[:virtual_machine] = data.fetch(:virtual_machine, {}).slice(:name, :vcpus, :memory, :disk, :tags)
+      result[:virtual_machine] = data.fetch(:virtual_machine, {}).slice(:name, :vcpus, :memory, :disk)
     end
 
     def read_tenant
       return unless data.keys.include?(:tenant)
 
-      result[:tenant] = data.fetch(:tenant, {}).slice(:name, :slug, :tags)
+      result[:tenant] = data.fetch(:tenant, {}).slice(:name, :slug)
     end
 
     def read_cluster
       return unless data.keys.include?(:cluster)
 
-      result[:cluster] = data.fetch(:cluster, {}).slice(:name, :tags)
+      result[:cluster] = data.fetch(:cluster, {}).slice(:name)
     end
 
     def read_cluster_type
@@ -71,7 +71,7 @@ module ForemanNetbox
       return unless data.keys.include?(:device)
 
       result[:device] = data.fetch(:device, {})
-                            .slice(:name, :serial, :tags)
+                            .slice(:name, :serial)
                             .compact
                             .reject { |k, v| k == :serial && v.blank? }
     end
@@ -85,7 +85,7 @@ module ForemanNetbox
     def read_device_type
       return unless data.keys.include?(:device_type)
 
-      result[:device_type] = data.fetch(:device_type, {}).slice(:model, :slug, :tags)
+      result[:device_type] = data.fetch(:device_type, {}).slice(:model, :slug)
     end
 
     def read_manufacturer
@@ -97,7 +97,7 @@ module ForemanNetbox
     def read_site
       return unless data.keys.include?(:site)
 
-      result[:site] = data.fetch(:site, {}).slice(:name, :slug, :tags)
+      result[:site] = data.fetch(:site, {}).slice(:name, :slug)
     end
   end
 end

data/app/services/foreman_netbox/netbox_parameters.rb

@@ -4,7 +4,6 @@ module ForemanNetbox
   # rubocop:disable Metrics/ClassLength
   class NetboxParameters
     UNKNOWN = 'Unknown'
-    DEFAULT_TAGS = ['foreman'].freeze
     DEFAULT_INTERFACE_TYPE = 'virtual'
     CLUSTER_TYPES = {
       :'Foreman::Model::Vmware' => {
@@ -56,8 +55,7 @@ module ForemanNetbox
       {
         tenant: {
           name: host.owner&.netbox_tenant_name,
-          slug: host.owner&.netbox_tenant_slug,
-          tags: DEFAULT_TAGS
+          slug: host.owner&.netbox_tenant_slug
         }
       }
     end
@@ -66,8 +64,7 @@ module ForemanNetbox
       {
         device: {
           name: host.name,
-          serial: host.facts.deep_symbolize_keys[:serialnumber],
-          tags: DEFAULT_TAGS
+          serial: host.facts.deep_symbolize_keys[:serialnumber]
         }
       }
     end
@@ -84,8 +81,7 @@ module ForemanNetbox
       {
         device_type: {
           model: model,
-          slug: model.parameterize,
-          tags: DEFAULT_TAGS
+          slug: model.parameterize
         }
       }
     end
@@ -105,8 +101,7 @@ module ForemanNetbox
       {
         site: {
           name: host.location&.netbox_site_name,
-          slug: host.location&.netbox_site_slug,
-          tags: DEFAULT_TAGS
+          slug: host.location&.netbox_site_slug
         }
       }
     end
@@ -122,8 +117,7 @@ module ForemanNetbox
             mac_address: mac_address,
             type: {
               value: DEFAULT_INTERFACE_TYPE
-            },
-            tags: DEFAULT_TAGS
+            }
           }
         end
       }
@@ -144,8 +138,7 @@ module ForemanNetbox
               address: ip_address,
               interface: {
                 name: identifier || (mac_address && "Interface #{mac_address}")
-              },
-              tags: DEFAULT_TAGS
+              }
             }
           end
         end.flatten
@@ -158,8 +151,7 @@ module ForemanNetbox
         virtual_machine: netbox_compute_attributes.slice(
           :vcpus, :memory, :disk
         ).merge(
-          name: host.name,
-          tags: DEFAULT_TAGS
+          name: host.name
         )
       }
     end
@@ -167,8 +159,7 @@ module ForemanNetbox
     def cluster
       {
         cluster: {
-          name: netbox_compute_attributes[:cluster],
-          tags: DEFAULT_TAGS
+          name: netbox_compute_attributes[:cluster]
         }.compact
       }
     end

data/app/services/foreman_netbox/netbox_parameters_comparator.rb

@@ -48,7 +48,7 @@ module ForemanNetbox
 
           memo[key] = diff
         elsif old_value.is_a?(Array)
-          next unless !new_hash[key] && key != :tags
+          next if new_hash[key]
 
           memo[key] = { added: [], removed: old_value }
         else
@@ -77,7 +77,7 @@ module ForemanNetbox
         elsif new_value.is_a?(Array)
           old_value = old_hash.fetch(key, [])
           added = new_value.reject { |item| old_value.find { |x| x == item } }
-          removed = key == :tags ? [] : old_value.reject { |item| new_value.find { |x| x == item } }
+          removed = old_value.reject { |item| new_value.find { |x| x == item } }
 
           next unless added.any? || removed.any?
 

data/db/migrate/20230303095650_fix_netbox_settings_category_to_dsl.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class FixNetboxSettingsCategoryToDsl < ActiveRecord::Migration[6.0]
+  def up
+    # rubocop:disable Rails/SkipsModelValidations
+    Setting.where(category: 'Setting::Netbox').update_all(category: 'Setting') if column_exists?(:settings, :category)
+    # rubocop:enable Rails/SkipsModelValidations
+  end
+end

data/lib/foreman_netbox/engine.rb

@@ -10,14 +10,6 @@ module ForemanNetbox
 
     config.autoload_paths += Dir["#{config.root}/app/interactors"]
 
-    initializer 'foreman_netbox.load_default_settings', before: :load_config_initializers do
-      require_dependency File.expand_path('../../app/models/setting/netbox.rb', __dir__) if begin
-        Setting.table_exists?
-      rescue StandardError
-        (false)
-      end
-    end
-
     # Add any db migrations
     initializer 'foreman_netbox.load_app_instance_data' do |app|
       ForemanNetbox::Engine.paths['db/migrate'].existent.each do |path|
@@ -27,7 +19,7 @@ module ForemanNetbox
 
     initializer 'foreman_netbox.register_plugin', :before => :finisher_hook do |_app|
       Foreman::Plugin.register :foreman_netbox do
-        requires_foreman '>= 1.24'
+        requires_foreman '>= 3.1'
 
         # Netbox Facet
         register_facet(ForemanNetbox::NetboxFacet, :netbox_facet) do
@@ -42,6 +34,31 @@ module ForemanNetbox
                               onlyif: proc { |host| host.netbox_facet.synchronized_at }
         end
 
+        settings do
+          category(:netbox, N_('Netbox')) do
+            setting 'netbox_url',
+                    type: :string,
+                    default: '-',
+                    full_name: N_('Netbox URL'),
+                    description: N_('URL where Netbox is reachable')
+            setting 'netbox_api_token',
+                    type: :string,
+                    default: '-',
+                    full_name: N_('Netbox API token'),
+                    description: N_('API token to Netbox')
+            setting 'netbox_orchestration_enabled',
+                    type: :boolean,
+                    default: false,
+                    full_name: N_('Netbox Orchestration'),
+                    description: N_('Enable Netbox Orchestration')
+            setting 'netbox_skip_site_update',
+                    type: :boolean,
+                    default: false,
+                    full_name: N_('Skip Site Update'),
+                    description: N_('Skip updating Site attribute for Devices')
+          end
+        end
+
         logger :import, enabled: true
       end
     end
@@ -54,8 +71,8 @@ module ForemanNetbox
       ::Usergroup.include(ForemanNetbox::UserUsergroupCommonExtensions)
 
       NetboxClientRuby.configure do |config|
-        config.netbox.api_base_url = Setting::Netbox['netbox_url']
-        config.netbox.auth.token = Setting::Netbox['netbox_api_token']
+        config.netbox.api_base_url = Setting['netbox_url']
+        config.netbox.auth.token = Setting['netbox_api_token']
       end
     rescue StandardError => e
       Rails.logger.warn "ForemanNetbox: skipping engine hook (#{e})\n#{e.backtrace.join("\n")}"

data/lib/foreman_netbox/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ForemanNetbox
-  VERSION = '1.0.2'
+  VERSION = '1.1.1'
 end

data/test/integration/foreman_netbox/sync_k8s_physical_host_test.rb

@@ -62,20 +62,24 @@ class SyncK8sPhysicalHostTest < ActiveSupport::TestCase
       assert nx_interface.present?
 
       h_interface.netbox_ips.each do |h_ip|
-        assert subject.ip_addresses.find { |nx_ip| nx_ip.interface.id == nx_interface.id && nx_ip.address == IPAddress.parse(h_ip) }.present?
+        assert subject.ip_addresses.find do |nx_ip|
+          nx_ip.interface.assigned_object_type == 'dcim.interface' &&
+            nx_ip.interface.assigned_object_id == nx_interface.id &&
+            nx_ip.address == IPAddress.parse(h_ip)
+        end.present?
       end
     end
 
-    expected_tags = ForemanNetbox::NetboxParameters::DEFAULT_TAGS
-    assert_equal expected_tags, subject.device.tags
-    assert_equal expected_tags, subject.device_type.tags
-    assert_equal expected_tags, subject.site.tags
-    assert_equal expected_tags, subject.tenant.tags
+    expected_tag_ids = subject.tags.pluck('id')
+    assert (expected_tag_ids - subject.device.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.device_type.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.site.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.tenant.tags.pluck('id')).empty?
     subject.interfaces.reload.each do |interface|
-      assert_equal expected_tags, interface.tags
+      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
     end
     subject.ip_addresses.reload.each do |interface|
-      assert_equal expected_tags, interface.tags
+      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
     end
   end
 end

data/test/integration/foreman_netbox/sync_rhel_physical_host_test.rb

@@ -62,20 +62,24 @@ class SyncRhelPhysicalHostTest < ActiveSupport::TestCase
       assert nx_interface.present?
 
       h_interface.netbox_ips.each do |h_ip|
-        assert subject.ip_addresses.find { |nx_ip| nx_ip.interface.id == nx_interface.id && nx_ip.address == IPAddress.parse(h_ip) }.present?
+        assert subject.ip_addresses.find do |nx_ip|
+          nx_ip.interface.assigned_object_type == 'dcim.interface' &&
+            nx_ip.interface.assigned_object_id == nx_interface.id &&
+            nx_ip.address == IPAddress.parse(h_ip)
+        end.present?
       end
     end
 
-    expected_tags = ForemanNetbox::NetboxParameters::DEFAULT_TAGS
-    assert_equal expected_tags, subject.device.tags
-    assert_equal expected_tags, subject.device_type.tags
-    assert_equal expected_tags, subject.site.tags
-    assert_equal expected_tags, subject.tenant.tags
+    expected_tag_ids = subject.tags.pluck('id')
+    assert (expected_tag_ids - subject.device.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.device_type.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.site.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.tenant.tags.pluck('id')).empty?
     subject.interfaces.reload.each do |interface|
-      assert_equal expected_tags, interface.tags
+      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
     end
     subject.ip_addresses.reload.each do |interface|
-      assert_equal expected_tags, interface.tags
+      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
     end
   end
 end

data/test/integration/foreman_netbox/sync_rhel_virtual_host_test.rb

@@ -61,7 +61,7 @@ class SyncRhelVirtualHostTest < ActiveSupport::TestCase
 
     assert_equal host.name,                                 subject.virtual_machine.name
     assert_equal host.owner.netbox_tenant_name,             subject.virtual_machine.tenant.name
-    assert_equal host.compute_object.cpus,                  subject.virtual_machine.vcpus
+    assert_equal host.compute_object.cpus.to_f,             subject.virtual_machine.vcpus
     assert_equal host.compute_object.memory_mb,             subject.virtual_machine.memory
     assert_equal host.compute_object.volumes.first.size_gb, subject.virtual_machine.disk
     assert_equal host.compute_object.cluster,               subject.virtual_machine.cluster.name
@@ -75,19 +75,23 @@ class SyncRhelVirtualHostTest < ActiveSupport::TestCase
       assert nx_interface.present?
 
       h_interface.netbox_ips.each do |h_ip|
-        assert subject.ip_addresses.find { |nx_ip| nx_ip.interface.id == nx_interface.id && nx_ip.address == IPAddress.parse(h_ip) }.present?
+        assert subject.ip_addresses.find do |nx_ip|
+          nx_ip.interface.assigned_object_type == 'virtualization.vminterface' &&
+            nx_ip.interface.assigned_object_id == nx_interface.id &&
+            nx_ip.address == IPAddress.parse(h_ip)
+        end.present?
       end
     end
 
-    expected_tags = ForemanNetbox::NetboxParameters::DEFAULT_TAGS
-    assert_equal expected_tags, subject.virtual_machine.tags
-    assert_equal expected_tags, subject.tenant.tags
-    assert_equal expected_tags, subject.cluster.tags
+    expected_tag_ids = subject.tags.pluck('id')
+    assert (expected_tag_ids - subject.virtual_machine.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.tenant.tags.pluck('id')).empty?
+    assert (expected_tag_ids - subject.cluster.tags.pluck('id')).empty?
     subject.interfaces.reload.each do |interface|
-      assert_equal expected_tags, interface.tags
+      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
     end
     subject.ip_addresses.reload.each do |interface|
-      assert_equal expected_tags, interface.tags
+      assert (expected_tag_ids - interface.tags.pluck('id')).empty?
     end
   end
 end

data/test/interactors/foreman_netbox/sync_host/organizer_test.rb

@@ -3,7 +3,7 @@
 require 'test_plugin_helper'
 
 class SyncHostOrganizerTest < ActiveSupport::TestCase
-  subject { ForemanNetbox::SyncHost::Organizer.call(host: host) }
+  subject { ForemanNetbox::SyncHost::Organizer.call(host: host, tags: default_tags) }
 
   let(:host) do
     FactoryBot.create(:host).tap do |host|
@@ -11,11 +11,27 @@ class SyncHostOrganizerTest < ActiveSupport::TestCase
       host.stubs(:facts).returns({ serialnumber: 'abc123' })
     end
   end
-  let(:tags) { ForemanNetbox::NetboxParameters::DEFAULT_TAGS }
+  let(:tags) do
+    default_tags.map { |t| { 'id' => t.id, 'name' => t.name, 'slug' => t.slug } }
+  end
 
   setup do
     setup_default_netbox_settings
     # rubocop:disable Layout/FirstArrayElementIndentation
+    default_tags.each do |tag|
+      stub_get_netbox_request("extras/tags.json?limit=50&slug=#{tag.slug}", results: [
+        { id: tag.id, name: tag.name, slug: tag.slug }
+      ])
+      stub_request(:get, "#{Setting[:netbox_url]}/api/extras/tags/#{tag.id}.json")
+        .to_return(
+          status: 200, headers: { 'Content-Type': 'application/json' },
+          body: {
+            id: tag.id,
+            name: tag.name,
+            slug: tag.slug
+          }.to_json
+        )
+    end
     stub_get_netbox_request('tenancy/tenants.json?limit=50&slug=admin-user', results: [
       { id: 1, name: host.owner.name, slug: host.owner.name.parameterize, tags: tags }
     ])
@@ -40,7 +56,7 @@ class SyncHostOrganizerTest < ActiveSupport::TestCase
   end
 
   test 'save synchronization status when it succeeds' do
-    stub_request(:patch, "#{Setting::Netbox[:netbox_url]}/api/dcim/devices/1.json").to_return(
+    stub_request(:patch, "#{Setting[:netbox_url]}/api/dcim/devices/1.json").to_return(
       status: 200, headers: { 'Content-Type': 'application/json' },
       body: { id: 1 }.to_json
     )
@@ -48,12 +64,12 @@ class SyncHostOrganizerTest < ActiveSupport::TestCase
     host.reload
 
     assert_not_nil host.netbox_facet.synchronized_at
-    assert_equal "#{Setting::Netbox[:netbox_url]}/dcim/devices/1", host.netbox_facet.url
+    assert_equal "#{Setting[:netbox_url]}/dcim/devices/1", host.netbox_facet.url
     assert_nil host.netbox_facet.synchronization_error
   end
 
   test 'save synchronization status when it fails' do
-    stub_request(:patch, "#{Setting::Netbox[:netbox_url]}/api/dcim/devices/1.json").to_return(
+    stub_request(:patch, "#{Setting[:netbox_url]}/api/dcim/devices/1.json").to_return(
       status: 500, headers: { 'Content-Type': 'application/json' }
     )
     subject
@@ -67,7 +83,7 @@ class SyncHostOrganizerTest < ActiveSupport::TestCase
   private
 
   def stub_get_netbox_request(path, results:)
-    stub_request(:get, "#{Setting::Netbox[:netbox_url]}/api/#{path}").to_return(
+    stub_request(:get, "#{Setting[:netbox_url]}/api/#{path}").to_return(
       status: 200, headers: { 'Content-Type': 'application/json' },
       body: {
         count: 1,

data/test/interactors/foreman_netbox/sync_host/sync_device/create_test.rb

@@ -11,7 +11,8 @@ class CreateDeviceTest < ActiveSupport::TestCase
       device_role: device_role,
       site: site,
       tenant: tenant,
-      device: device
+      device: device,
+      tags: tags
     )
   end
 
@@ -26,6 +27,7 @@ class CreateDeviceTest < ActiveSupport::TestCase
   let(:site) { OpenStruct.new(id: 1) }
   let(:tenant) { OpenStruct.new(id: 1) }
   let(:netbox_device_params) { host.netbox_facet.netbox_params.fetch(:device) }
+  let(:tags) { [ForemanNetbox::API.client::Extras::Tag.new(id: 1, name: 'foreman', slug: 'foreman')] }
 
   setup do
     setup_default_netbox_settings
@@ -39,11 +41,11 @@ class CreateDeviceTest < ActiveSupport::TestCase
         body: {
           name: netbox_device_params[:name],
           serial: netbox_device_params[:serial],
-          tags: netbox_device_params[:tags],
           device_type: device_type.id,
           device_role: device_role.id,
           site: site.id,
-          tenant: tenant.id
+          tenant: tenant.id,
+          tags: tags.map(&:id)
         }.to_json
       ).to_return(
         status: 201, headers: { 'Content-Type': 'application/json' },

data/test/interactors/foreman_netbox/sync_host/sync_device/sync_device_type/create_test.rb

@@ -8,7 +8,8 @@ class CreateDeviceTypeTest < ActiveSupport::TestCase
       netbox_params: host.netbox_facet.netbox_params,
       device_type: device_type,
       manufacturer: manufacturer,
-      host: host
+      host: host,
+      tags: default_tags
     )
   end
 
@@ -32,8 +33,8 @@ class CreateDeviceTypeTest < ActiveSupport::TestCase
         body: {
           model: host.netbox_facet.netbox_params.dig(:device_type, :model),
           slug: host.netbox_facet.netbox_params.dig(:device_type, :slug),
-          tags: host.netbox_facet.netbox_params.dig(:device_type, :tags),
-          manufacturer: manufacturer.id
+          manufacturer: manufacturer.id,
+          tags: default_tags.map(&:id)
         }.to_json
       ).to_return(
         status: 201, headers: { 'Content-Type': 'application/json' },