foreman_maintain 1.3.0 → 1.3.2

data/lib/foreman_maintain/cli/advanced/prebuild_bash_completion.rb

@@ -9,7 +9,7 @@ module ForemanMaintain
         answers = feature(:installer).configuration[:answer_file]
         comp_map[:expire] = {
           :file => answers,
-          :sha1sum => execute!("sha1sum #{answers}")
+          :sha1sum => execute!("sha1sum #{answers}"),
         }
         cache_dir = File.dirname(ForemanMaintain.config.completion_cache_file)
         FileUtils.mkdir_p(cache_dir) unless File.directory?(cache_dir)

data/lib/foreman_maintain/cli/advanced_command.rb

@@ -6,8 +6,8 @@ module ForemanMaintain
     class AdvancedCommand < Base
       subcommand 'procedure', 'Run maintain procedures manually', ProcedureCommand
       subcommand 'prebuild-bash-completion',
-                 'Prepare map of options and subcommands for Bash completion',
-                 PrebuildBashCompletionCommand
+        'Prepare map of options and subcommands for Bash completion',
+        PrebuildBashCompletionCommand
     end
   end
 end

data/lib/foreman_maintain/cli/backup_command.rb

@@ -33,20 +33,20 @@ module ForemanMaintain
         def common_backup_options
           # TODO: BACKUP_DIR in f-m config - should be default?
           parameter 'BACKUP_DIR', 'Path to backup dir',
-                    :completion => { :type => :directory },
-                    :attribute_name => :backup_root_dir do |dir|
+            :completion => { :type => :directory },
+            :attribute_name => :backup_root_dir do |dir|
             File.expand_path(dir)
           end
           option ['-s', '--skip-pulp-content'], :flag, 'Do not backup Pulp content'
           option ['-p', '--preserve-directory'], :flag, 'Do not create a time-stamped subdirectory'
           option ['-t', '--split-pulp-tar'], 'SPLIT_SIZE',
-                 'Split pulp data into files of a specified size, i.e. (100M, 50G). ' \
-                 "See '--tape-length' in 'info tar' for all sizes" do |size|
+            'Split pulp data into files of a specified size, i.e. (100M, 50G). ' \
+            "See '--tape-length' in 'info tar' for all sizes" do |size|
             self.class.valid_tape_size(size)
           end
           option ['-i', '--incremental'], 'PREVIOUS_BACKUP_DIR',
-                 'Backup changes since previous backup',
-                 :completion => { :type => :directory } do |dir|
+            'Backup changes since previous backup',
+            :completion => { :type => :directory } do |dir|
             unless File.directory?(dir)
               raise ArgumentError, "Previous backup directory does not exist: #{dir}"
             end
@@ -55,8 +55,8 @@ module ForemanMaintain
           end
           proxy_name = ForemanMaintain.detector.feature(:capsule) ? 'Capsule' : 'Foreman Proxy'
           option '--features', 'FEATURES',
-                 "#{proxy_name} features to include in the backup. " \
-                     'Valid features are tftp, dns, dhcp, openscap, and all.', :multivalued => true
+            "#{proxy_name} features to include in the backup. " \
+                'Valid features are tftp, dns, dhcp, openscap, and all.', :multivalued => true
         end
         # rubocop:enable  Metrics/MethodLength
 
@@ -76,7 +76,7 @@ module ForemanMaintain
         Scenarios::BackupRescueCleanup.new({
           :backup_dir => backup_dir,
           :strategy => strategy,
-          :preserve_dir => preserve_directory?
+          :preserve_dir => preserve_directory?,
         }.merge(options))
       end
 
@@ -88,7 +88,7 @@ module ForemanMaintain
           :proxy_features => features,
           :tar_volume_size => split_pulp_tar,
           :skip_pulp_content => skip_pulp_content?,
-          :incremental_dir => incremental
+          :incremental_dir => incremental,
         }.merge(options))
       end
 
@@ -123,7 +123,7 @@ module ForemanMaintain
 
       def execute
         perform_backup(:offline,
-                       :include_db_dumps => include_db_dumps?)
+          :include_db_dumps => include_db_dumps?)
       end
     end
 
@@ -133,21 +133,21 @@ module ForemanMaintain
       common_backup_options
       option '--include-db-dumps', :flag, 'Also dump full database schema before snapshot backup'
       option ['-d', '--snapshot-mount-dir'], 'SNAPSHOT_MOUNT_DIR',
-             "Override default directory ('/var/snap/') where the snapshots will be mounted",
-             :default => '/var/snap/' do |dir|
+        "Override default directory ('/var/snap/') where the snapshots will be mounted",
+        :default => '/var/snap/' do |dir|
         unless File.directory?(dir)
           raise ArgumentError, "Snapshot mount directory does not exist: #{dir}"
         end
         dir
       end
       option ['-b', '--snapshot-block-size'], 'SNAPSHOT_BLOCK_SIZE',
-             'Override default block size (2G)', :default => '2G'
+        'Override default block size (2G)', :default => '2G'
 
       def execute
         perform_backup(:snapshot,
-                       :snapshot_mount_dir => snapshot_mount_dir,
-                       :snapshot_block_size => snapshot_block_size,
-                       :include_db_dumps => include_db_dumps?)
+          :snapshot_mount_dir => snapshot_mount_dir,
+          :snapshot_block_size => snapshot_block_size,
+          :include_db_dumps => include_db_dumps?)
       end
     end
 

data/lib/foreman_maintain/cli/base.rb

@@ -57,10 +57,10 @@ module ForemanMaintain
       def run_scenario(scenarios, rescue_scenario = nil)
         @runner ||=
           ForemanMaintain::Runner.new(reporter, scenarios,
-                                      :assumeyes => option_wrapper('assumeyes?'),
-                                      :whitelist => option_wrapper('whitelist') || [],
-                                      :force => option_wrapper('force?'),
-                                      :rescue_scenario => rescue_scenario)
+            :assumeyes => option_wrapper('assumeyes?'),
+            :whitelist => option_wrapper('whitelist') || [],
+            :force => option_wrapper('force?'),
+            :rescue_scenario => rescue_scenario)
         runner.run
       end
 
@@ -135,8 +135,8 @@ module ForemanMaintain
 
       def self.label_option
         option '--label', 'label',
-               'Run only a specific check with a label. ' \
-                 '(Use "list" command to see available labels)' do |label|
+          'Run only a specific check with a label. ' \
+            '(Use "list" command to see available labels)' do |label|
           raise ArgumentError, 'value not specified' if label.nil? || label.empty?
           underscorize(label).to_sym
         end
@@ -144,9 +144,9 @@ module ForemanMaintain
 
       def self.tags_option
         option('--tags', 'tags',
-               'Run only those with all specific set of tags. ' \
-                 '(Use list-tags command to see available tags)',
-               :multivalued => true) do |tags|
+          'Run only those with all specific set of tags. ' \
+            '(Use list-tags command to see available tags)',
+          :multivalued => true) do |tags|
           raise ArgumentError, 'value not specified' if tags.nil? || tags.empty?
           tags.map { |tag| underscorize(tag).to_sym }
         end
@@ -158,14 +158,14 @@ module ForemanMaintain
 
         if opts.include?('assumeyes')
           option ['-y', '--assumeyes'], :flag,
-                 'Automatically answer yes for all questions' do |assume|
+            'Automatically answer yes for all questions' do |assume|
             ForemanMaintain.reporter.assumeyes = assume
           end
         end
 
         if opts.include?('whitelist')
           option(['-w', '--whitelist'], 'whitelist',
-                 'Comma-separated list of labels of steps to be skipped') do |whitelist|
+            'Comma-separated list of labels of steps to be skipped') do |whitelist|
             raise ArgumentError, 'value not specified' if whitelist.nil? || whitelist.empty?
             whitelist.split(',').map(&:strip)
           end
@@ -173,12 +173,12 @@ module ForemanMaintain
 
         if opts.include?('force')
           option ['-f', '--force'], :flag,
-                 'Force steps that would be skipped as they were already run'
+            'Force steps that would be skipped as they were already run'
         end
 
         if opts.include?('plaintext')
           option(['--plaintext'], :flag,
-                 'Print the output in plaintext and disable the spinner') do |plaintext|
+            'Print the output in plaintext and disable the spinner') do |plaintext|
             ForemanMaintain.reporter.plaintext = plaintext
           end
         end

data/lib/foreman_maintain/cli/maintenance_mode_command.rb

@@ -42,7 +42,7 @@ module ForemanMaintain
         end
 
         def fetch_procedure(scenario, procedure_class_name)
-          scenario.steps.find { |procedure| procedure.class.eql?(procedure_class_name) }
+          scenario.steps.find { |procedure| procedure.instance_of?(procedure_class_name) }
         end
       end
     end

data/lib/foreman_maintain/cli/plugin_command.rb

@@ -3,7 +3,7 @@ module ForemanMaintain
     class PluginCommand < Base
       subcommand 'purge-puppet', 'Remove the Puppet feature' do
         option ['-f', '--remove-all-data'], :flag, 'Purge all the Puppet data',
-               :attribute_name => :remove_data
+          :attribute_name => :remove_data
 
         def execute
           run_scenarios_and_exit(Scenarios::Puppet::RemovePuppet.new(:remove_data => remove_data?))

data/lib/foreman_maintain/cli/restore_command.rb

@@ -3,13 +3,13 @@ module ForemanMaintain
     class RestoreCommand < Base
       interactive_option
       parameter 'BACKUP_DIR', 'Path to backup directory to restore',
-                :attribute_name => :backup_dir, :completion => { :type => :directory }
+        :attribute_name => :backup_dir, :completion => { :type => :directory }
 
       option ['-i', '--incremental'], :flag, 'Restore an incremental backup',
-             :attribute_name => :incremental, :completion => { :type => :directory }
+        :attribute_name => :incremental, :completion => { :type => :directory }
       option ['-n', '--dry-run'], :flag,
-             'Check if backup could be restored, without performing the restore',
-             :attribute_name => :dry_run
+        'Check if backup could be restored, without performing the restore',
+        :attribute_name => :dry_run
 
       def execute
         scenario = Scenarios::Restore.new(

data/lib/foreman_maintain/cli/self_upgrade_command.rb

@@ -2,8 +2,8 @@ module ForemanMaintain
   module Cli
     class SelfUpgradeCommand < Base
       option ['--maintenance-repo-label'], 'REPOSITORY_LABEL',\
-             'Repository label from which packages should be updated.'\
-             'This can be used when standard CDN repositories are unavailable.'
+        'Repository label from which packages should be updated.'\
+        'This can be used when standard CDN repositories are unavailable.'
       def execute
         run_scenario(upgrade_scenario)
       end

data/lib/foreman_maintain/cli/service_command.rb

@@ -35,8 +35,8 @@ module ForemanMaintain
         service_options
         if feature(:katello)
           option ['-p', '--wait-for-server-response', '--wait-for-hammer-ping'], :flag,
-                 'Wait for hammer ping to return successfully before terminating',
-                 :attribute_name => :wait_for_server_response
+            'Wait for hammer ping to return successfully before terminating',
+            :attribute_name => :wait_for_server_response
         end
 
         def execute

data/lib/foreman_maintain/cli/transform_clamp_options.rb

@@ -26,7 +26,7 @@ module ForemanMaintain
         private
 
         def option_sym(option)
-          option = underscorize(option.switches.first[2..-1].to_s)
+          option = underscorize(option.switches.first[2..].to_s)
           option.to_sym unless option.empty?
         end
 

data/lib/foreman_maintain/cli/upgrade_command.rb

@@ -3,20 +3,20 @@ module ForemanMaintain
     class UpgradeCommand < Base
       def self.target_version_option
         option '--target-version', 'TARGET_VERSION', 'Target version of the upgrade',
-               :required => false
+          :required => false
       end
 
       def self.disable_self_upgrade_option
         option '--disable-self-upgrade', :flag, 'Disable automatic self upgrade',
-               :default => false
+          :default => false
       end
 
       def current_target_version
         current_target_version = ForemanMaintain::UpgradeRunner.current_target_version
         if current_target_version && target_version && target_version != current_target_version
           raise Error::UsageError,
-                "Can't set target version #{target_version}, "\
-                "#{current_target_version} already in progress"
+            "Can't set target version #{target_version}, "\
+            "#{current_target_version} already in progress"
         end
         @target_version = current_target_version if current_target_version
         return true if current_target_version
@@ -43,9 +43,9 @@ module ForemanMaintain
         return @upgrade_runner if defined? @upgrade_runner
         validate_target_version!
         @upgrade_runner = ForemanMaintain::UpgradeRunner.new(target_version, reporter,
-                                                             :assumeyes => assumeyes?,
-                                                             :whitelist => whitelist || [],
-                                                             :force => force?).tap(&:load)
+          :assumeyes => assumeyes?,
+          :whitelist => whitelist || [],
+          :force => force?).tap(&:load)
       end
 
       def print_versions(target_versions)

data/lib/foreman_maintain/cli.rb

@@ -10,7 +10,6 @@ require 'foreman_maintain/cli/service_command'
 require 'foreman_maintain/cli/restore_command'
 require 'foreman_maintain/cli/maintenance_mode_command'
 require 'foreman_maintain/cli/packages_command'
-require 'foreman_maintain/cli/content_command'
 require 'foreman_maintain/cli/plugin_command'
 require 'foreman_maintain/cli/self_upgrade_command'
 
@@ -26,19 +25,10 @@ module ForemanMaintain
       subcommand 'restore', 'Restore a backup', RestoreCommand
       subcommand 'packages', 'Lock/Unlock package protection, install, update', PackagesCommand
       subcommand 'advanced', 'Advanced tools for server maintenance', AdvancedCommand
-      subcommand 'content', 'Content related commands', ContentCommand
       subcommand 'plugin', 'Manage optional plugins on your server', PluginCommand
       subcommand 'self-upgrade', 'Perform major version self upgrade', SelfUpgradeCommand
       subcommand 'maintenance-mode', 'Control maintenance-mode for application',
-                 MaintenanceModeCommand
-      if ForemanMaintain.detector.feature(:satellite) &&
-         ForemanMaintain.detector.feature(:satellite).current_minor_version == '6.9'
-        subcommand 'prep-6.10-upgrade', 'Preparations for the Satellite 6.10 upgrade' do
-          def execute
-            run_scenarios_and_exit(Scenarios::Prep610Upgrade.new)
-          end
-        end
-      end
+        MaintenanceModeCommand
 
       def run(*arguments)
         logger.info("Running foreman-maintain command with arguments #{arguments.inspect}")

data/lib/foreman_maintain/concerns/base_database.rb

@@ -2,9 +2,7 @@ module ForemanMaintain
   module Concerns
     module BaseDatabase
       def data_dir
-        if el7? && package_manager.installed?('rh-postgresql12-postgresql-server-syspaths')
-          '/var/opt/rh/rh-postgresql12/lib/pgsql/data/'
-        elsif debian_or_ubuntu?
+        if debian_or_ubuntu?
           deb_postgresql_data_dir
         else
           '/var/lib/pgsql/data/'
@@ -39,20 +37,13 @@ module ForemanMaintain
         end
       end
 
-      def restore_transform
-        if el8?
-          # this allows to transform an EL7 backup to EL8 paths
-          's,^var/opt/rh/rh-postgresql12/,var/,S'
-        end
-      end
-
       def configuration
         raise NotImplementedError
       end
 
       def config_files
         [
-          '/etc/systemd/system/postgresql.service'
+          '/etc/systemd/system/postgresql.service',
         ]
       end
 
@@ -71,8 +62,8 @@ module ForemanMaintain
       def psql(query, config = configuration)
         if ping(config)
           execute(psql_command(config),
-                  :stdin => query,
-                  :hidden_patterns => [config['password']])
+            :stdin => query,
+            :hidden_patterns => [config['password']])
         else
           raise_service_error
         end
@@ -80,8 +71,8 @@ module ForemanMaintain
 
       def ping(config = configuration)
         execute?(psql_command(config),
-                 :stdin => 'SELECT 1 as ping',
-                 :hidden_patterns => [config['password']])
+          :stdin => 'SELECT 1 as ping',
+          :hidden_patterns => [config['password']])
       end
 
       def backup_file_path(config = configuration)
@@ -116,8 +107,8 @@ module ForemanMaintain
           tar_options = {
             :archive => backup_file,
             :command => command,
-            :transform => "s,^,#{dir[1..-1]},S",
-            :files => '*'
+            :transform => "s,^,#{dir[1..]},S",
+            :files => '*',
           }.merge(extra_tar_options)
           feature(:tar).run(tar_options)
         end

data/lib/foreman_maintain/concerns/downstream.rb

@@ -53,85 +53,27 @@ module ForemanMaintain
         rh_repos = main_rh_repos
         server_version_full = "#{server_version.major}.#{server_version.minor}"
         rh_repos.concat(product_specific_repos(server_version_full))
-        if server_version > version('6.3')
-          ansible_repo = ansible_repo(server_version)
-          rh_repos << ansible_repo if ansible_repo
-        end
-
         rh_repos
       end
 
-      def ansible_repo(server_version)
-        if server_version >= version('6.8')
-          ansible_version = '2.9'
-        elsif server_version >= version('6.6')
-          ansible_version = '2.8'
-        elsif server_version >= version('6.4')
-          ansible_version = '2.6'
-        end
-
-        if el7?
-          "rhel-#{el_major_version}-server-ansible-#{ansible_version}-rpms"
-        end
-      end
-
       def use_beta_repos?
         ENV['FOREMAN_MAINTAIN_USE_BETA'] == '1'
       end
 
       def product_specific_repos(full_version)
-        maj_version = full_version[0]
-        repos = if el7? && use_beta_repos?
-                  ["rhel-server-#{el_major_version}-#{package_name}-#{maj_version}-beta-rpms"]
-                elsif el7?
-                  ["rhel-#{el_major_version}-server-#{package_name}-#{full_version}-rpms"]
-                elsif use_beta_repos?
-                  ["#{package_name}-#{maj_version}-beta-for-rhel-#{el_major_version}-x86_64-rpms"]
-                else
-                  ["#{package_name}-#{full_version}-for-rhel-#{el_major_version}-x86_64-rpms"]
-                end
-
-        repos << puppet4_repo(full_version) unless puppet4_repo(full_version).nil?
+        repos = ["#{package_name}-#{full_version}-for-rhel-#{el_major_version}-x86_64-rpms"]
         repos.concat(common_repos(full_version))
       end
 
-      def puppet4_repo(full_version)
-        if current_minor_version == '6.3' && full_version.to_s != '6.4' && (
-          feature(:puppet_server) && feature(:puppet_server).puppet_version.major == 4)
-          "rhel-#{el_major_version}-server-#{package_name}-tools-6.3-puppet4-rpms"
-        end
-      end
-
       def common_repos(full_version)
-        sat_maint_version = if version(full_version) >= version('6.11') && !use_beta_repos?
-                              full_version
-                            else
-                              full_version[0]
-                            end
-
-        # rubocop:disable Metrics/LineLength
-        repos = if el7? && use_beta_repos?
-                  ["rhel-#{el_major_version}-server-satellite-maintenance-#{sat_maint_version}-beta-rpms"]
-                elsif el7?
-                  ["rhel-#{el_major_version}-server-satellite-maintenance-#{sat_maint_version}-rpms"]
-                elsif use_beta_repos?
-                  ["satellite-maintenance-#{sat_maint_version}-beta-for-rhel-#{el_major_version}-x86_64-rpms"]
-                else
-                  ["satellite-maintenance-#{sat_maint_version}-for-rhel-#{el_major_version}-x86_64-rpms"]
-                end
-        # rubocop:enable Metrics/LineLength
-
-        repos
+        ["satellite-maintenance-#{full_version}-for-rhel-#{el_major_version}-x86_64-rpms"]
       end
 
       def main_rh_repos
-        if el7?
-          ["rhel-#{el_major_version}-server-rpms",
-           "rhel-server-rhscl-#{el_major_version}-rpms"]
-        else
-          ["rhel-#{el_major_version}-for-x86_64-baseos-rpms",
-           "rhel-#{el_major_version}-for-x86_64-appstream-rpms"]
-        end
+        [
+          "rhel-#{el_major_version}-for-x86_64-baseos-rpms",
+          "rhel-#{el_major_version}-for-x86_64-appstream-rpms",
+        ]
       end
 
       def version_from_source

data/lib/foreman_maintain/concerns/firewall/iptables_maintenance_mode.rb

@@ -8,7 +8,7 @@ module ForemanMaintain
 
         def enable_maintenance_mode
           add_chain(custom_chain_name,
-                    ['-i lo -j ACCEPT', '-p tcp --dport 443 -j REJECT'])
+            ['-i lo -j ACCEPT', '-p tcp --dport 443 -j REJECT'])
         end
 
         def maintenance_mode_status?

data/lib/foreman_maintain/concerns/foreman_and_katello_version_map.rb

@@ -2,7 +2,7 @@ module ForemanMaintain
   module Concerns
     module ForemanAndKatelloVersionMap
       FOREMAN_AND_KATELLO_VERSION_MAP = {
-        'nightly' => 'nightly'
+        'nightly' => 'nightly',
       }.freeze
 
       def foreman_version_by_katello(version)

data/lib/foreman_maintain/concerns/os_facts.rb

@@ -62,14 +62,6 @@ module ForemanMaintain
         os_id == 'ubuntu'
       end
 
-      def el7?
-        el_major_version == 7
-      end
-
-      def el8?
-        el_major_version == 8
-      end
-
       def el_major_version
         os_version_id.to_i if el?
       end

data/lib/foreman_maintain/concerns/primary_checks.rb

@@ -2,19 +2,20 @@ module ForemanMaintain
   module Concerns
     module PrimaryChecks
       def validate_downstream_packages
-        return unless detector.feature(:installer) && detector.feature(:installer).with_scenarios?
+        return unless detector.feature(:installer)&.with_scenarios?
         if (package = package_name) && !package_manager.installed?(package)
           raise ForemanMaintain::Error::Fail,
-                "Error: Important rpm package #{package} is not installed!"\
-                "\nInstall #{package} rpm to ensure system consistency."
+            "Error: Important rpm package #{package} is not installed!"\
+            "\nInstall #{package} rpm to ensure system consistency."
         end
       end
 
       def package_name
         installed_scenario = detector.feature(:installer).last_scenario
-        if installed_scenario == 'satellite'
+        case installed_scenario
+        when 'satellite'
           'satellite'
-        elsif installed_scenario == 'capsule'
+        when 'capsule'
           'satellite-capsule'
         end
       end

data/lib/foreman_maintain/concerns/pulp_common.rb

@@ -6,16 +6,13 @@ module ForemanMaintain
       end
 
       def exclude_from_backup
-        # For pulp2:
-        # Exclude /var/lib/pulp/katello-export and /var/lib/pulp/cache
-        # since the tar is run from /var/lib/pulp, list subdir paths only
-        # For pulp3/pulpcore:
-        pulp2_dirs = %w[katello-export cache]
-        # For pulp3/pulpcore:
         # Only need to backup media directory of /var/lib/pulp
         # All below directories and their contents are regenerated on installer run
-        pulpcore_dirs = %w[assets exports imports sync_imports tmp]
-        pulp2_dirs + pulpcore_dirs
+        %w[assets exports imports sync_imports tmp]
+      end
+
+      def pulpcore_manager(command)
+        "PULP_SETTINGS=/etc/pulp/settings.py runuser -u pulp -- pulpcore-manager #{command}"
       end
     end
   end

data/lib/foreman_maintain/concerns/system_helpers.rb

@@ -127,7 +127,7 @@ module ForemanMaintain
       def parse_csv(data)
         parsed_data = CSV.parse(data)
         header = parsed_data.first
-        parsed_data[1..-1].map do |row|
+        parsed_data[1..].map do |row|
           Hash[*header.zip(row).flatten(1)]
         end
       end
@@ -191,11 +191,9 @@ module ForemanMaintain
         ForemanMaintain.repository_manager
       end
 
-      def ruby_prefix(scl = true)
+      def ruby_prefix
         if debian_or_ubuntu?
           'ruby-'
-        elsif el7? && scl
-          'tfm-rubygem-'
         else
           'rubygem-'
         end
@@ -213,8 +211,7 @@ module ForemanMaintain
         else
           proxy_plugin_prefix = 'smart_proxy_'
         end
-        scl = check_min_version('foreman-proxy', '2.0')
-        ruby_prefix(scl) + proxy_plugin_prefix + plugin
+        ruby_prefix + proxy_plugin_prefix + plugin
       end
 
       def hammer_plugin_name(plugin)

data/lib/foreman_maintain/concerns/upstream.rb

@@ -86,7 +86,7 @@ module ForemanMaintain
         repoids_and_urls = {}
         repository_manager.enabled_repos.each do |repo, url|
           repo_urls.each do |regex|
-            repoids_and_urls[repo] = url if url =~ regex
+            repoids_and_urls[repo] = url if url&.match?(regex)
           end
         end
         repoids_and_urls
@@ -95,8 +95,8 @@ module ForemanMaintain
       private
 
       def repo_urls
-        [%r{yum.theforeman.org\/*},
-         %r{yum.puppetlabs.com\/*}]
+        [%r{yum.theforeman.org/*},
+         %r{yum.puppetlabs.com/*}]
       end
     end
   end