foreman_maintain 0.7.9 → 0.7.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 87bde0596489f26881bb8ee92b9cec10df4aead0e72fb3411a6dc80916949efe
-  data.tar.gz: 0da057d0f9f7b6aaa0e5a2e0484a7adb66ed41eb09f0ef9f7fa32949640d7f92
+  metadata.gz: 4553337c4db35ead0b3f07871424c164b2df46bd1c8fc14937dc49768c428c29
+  data.tar.gz: 43aa2647efacc81fdb48b6c7aec36c791208c77cf637b1e187d8fda89b5c5053
 SHA512:
-  metadata.gz: 76b77f3b03a65565e8cc4264ce27b9e172bfc1f84c2f9819718e359551f7906c42783e1cd2f50f3a5ad4601445274c92e8fa734c90141da993f7a6777c39d4a6
-  data.tar.gz: 9b1dd4c293088f06b87584857123e74e17f2b7802408a0086d1889b159ef69a904af0b7eb16bc8f9f5a84bca7281d44fa30c4c9c4726853a854ea42f8f81365a
+  metadata.gz: 31c1e4710e552ce9fc04b66c497c86a3b1bc7cd27cf0feb025000026a5d5d148babe963f8c3090a2243c0f1f983b3bbbcd2113e3b391e84e3eb191eff5b75af2
+  data.tar.gz: 89158ea71347163b42ad198e978bec7990a581667049c5914c3c563216f233ae21a01d95dc52885699ed0777e449533a0657d45b045370abf5ddb07dae60bf52

data/definitions/checks/disk/available_space_postgresql12.rb

@@ -0,0 +1,45 @@
+module Checks
+  module Disk
+    class AvailableSpacePostgresql12 < ForemanMaintain::Check
+      metadata do
+        label :available_space_for_postgresql12
+        description 'Check to make sure PostgreSQL 12 work directory has enough space for upgrade'
+        confine do
+          (feature(:foreman_database) || feature(:candlepin_database)) && \
+            (file_exists?('/var/lib/pgsql') && \
+            file_exists?('/var/opt/rh/rh-postgresql12'))
+        end
+      end
+
+      def run
+        assert(psql_12_available_space >= psql_9_consumed_space, warning_message, :warn => true)
+      end
+
+      def pgsql_dir(version)
+        if version == 9
+          '/var/lib/pgsql/'
+        elsif version == 12
+          '/var/opt/rh/rh-postgresql12/'
+        end
+      end
+
+      def psql_9_consumed_space
+        io_obj = ForemanMaintain::Utils::Disk::IODevice.new(pgsql_dir(9))
+        io_obj.space_used
+      end
+
+      def psql_12_available_space
+        io_obj = ForemanMaintain::Utils::Disk::IODevice.new(pgsql_dir(12))
+        io_obj.available_space
+      end
+
+      def warning_message
+        sat_version = feature(:satellite).current_version.version[0..2]
+        "Satellite #{sat_version} uses PostgreSQL 12. \nThis changes PostgreSQL "\
+        "work directory to #{pgsql_dir(12)}\n"\
+        "The new work directory requires at least #{psql_9_consumed_space}"\
+        'MiB free space for upgrade!'
+      end
+    end
+  end
+end

data/definitions/features/dynflow_sidekiq.rb

@@ -37,6 +37,6 @@ class Features::DynflowSidekiq < ForemanMaintain::Feature
   end
 
   def configured_instances
-    Dir['/etc/foreman/dynflow/*'].map { |config| File.basename(config, '.yml') }
+    Dir['/etc/foreman/dynflow/*.yml'].map { |config| File.basename(config, '.yml') }
   end
 end

data/definitions/features/pulp2.rb

@@ -34,4 +34,10 @@ class Features::Pulp < ForemanMaintain::Feature
       '/etc/default/pulp_workers'
     ]
   end
+
+  def exclude_from_backup
+    # Exclude /var/lib/pulp/katello-export and /var/lib/pulp/cache
+    # since the tar is run from /var/lib/pulp, list subdir paths only
+    ['katello-export', 'cache']
+  end
 end

data/definitions/features/pulpcore.rb

@@ -11,13 +11,21 @@ class Features::Pulpcore < ForemanMaintain::Feature
   end
 
   def services
-    self.class.pulpcore_common_services + [
+    self.class.pulpcore_common_services + configured_workers + [
       system_service('rh-redis5-redis', 5),
-      system_service('pulpcore-worker@*', 20, :all => true, :skip_enablement => true),
       system_service('httpd', 30)
     ]
   end
 
+  def configured_workers
+    names = Dir['/etc/systemd/system/multi-user.target.wants/pulpcore-worker@*.service']
+    names = names.map { |f| File.basename(f) }
+    names.map do |name|
+      system_service(name, 20, :skip_enablement => true,
+                               :instance_parent_unit => 'pulpcore-worker@')
+    end
+  end
+
   def self.pulpcore_migration_services
     pulpcore_common_services + [
       ForemanMaintain::Utils.system_service('pulpcore-worker@1', 20),

data/definitions/features/service.rb

@@ -137,7 +137,7 @@ class Features::Service < ForemanMaintain::Feature
 
   def filter_disabled_services!(action, service_list)
     if %w[start stop restart status].include?(action)
-      service_list.select!(&:enabled?)
+      service_list.select! { |service| !service.respond_to?(:enabled?) || service.enabled? }
     end
     service_list
   end

data/definitions/procedures/backup/pulp.rb

@@ -30,7 +30,7 @@ module Procedures::Backup
       feature(:tar).run(
         :archive => File.join(@backup_dir, 'pulp_data.tar'),
         :command => 'create',
-        :exclude => ['var/lib/pulp/katello-export'],
+        :exclude => feature(:pulp2).exclude_from_backup,
         :listed_incremental => File.join(@backup_dir, '.pulp.snar'),
         :transform => 's,^,var/lib/pulp/,S',
         :volume_size => @tar_volume_size,

data/definitions/procedures/pulp/cleanup_old_metadata_files.rb

@@ -0,0 +1,75 @@
+require 'find'
+require 'rexml/document'
+
+module Procedures::Pulp
+  class CleanupOldMetadataFiles < ForemanMaintain::Procedure
+    metadata do
+      description 'Cleanup old and unneeded yum metadata files from /var/lib/pulp/'
+      confine do
+        check_max_version('katello-common', '4.0')
+      end
+      param :remove_files, 'If true, will actually delete files, otherwise will print them out.'
+    end
+
+    PULP_METADATA_DIR = '/var/lib/pulp/published/yum/master/yum_distributor/'.freeze
+    REPOMD_FILE = 'repomd.xml'.freeze
+
+    def run
+      return unless File.directory?(PULP_METADATA_DIR)
+      found = []
+
+      puts 'Warning: This command may cause reduced performance related to content operations.'
+      message = 'Locating repository metadata (this may take a while)'
+      with_spinner(message) do |spinner|
+        Find.find(PULP_METADATA_DIR) do |path|
+          next if File.basename(path) != REPOMD_FILE
+          found << path
+          spinner.update("#{message}: Found #{found.count} repos.")
+        end
+      end
+
+      found.each do |repo_md_path|
+        handle(repo_md_path, @remove_files)
+      end
+    end
+
+    def handle(repo_md_path, remove_files)
+      base_path = File.dirname(repo_md_path)
+      to_remove = list_existing_files(repo_md_path) - list_repomd_files(repo_md_path)
+
+      if to_remove.empty?
+        "Skipping #{base_path}, no files to remove."
+      elsif remove_files
+        puts '================================================================================'
+        puts "Removing #{to_remove.count} files from #{base_path}"
+        to_remove.each { |file| File.delete(File.join(base_path, file)) }
+      else
+        puts '================================================================================'
+        puts "For #{base_path} would remove, but --remove-files was not specified:"
+        to_remove.each { |file| puts "   #{file}" }
+      end
+    end
+
+    def list_repomd_files(repo_md_path)
+      doc = REXML::Document.new(File.new(repo_md_path))
+      filenames = []
+      doc.root.elements.each do |data|
+        locations = data.elements['location']
+        next unless locations
+
+        if locations.attributes
+          filenames << locations.attributes['href']
+        end
+      end
+      base_names(filenames.flatten)
+    end
+
+    def list_existing_files(repo_md_path)
+      base_names(Dir[File.dirname(repo_md_path) + '/*']) - [REPOMD_FILE]
+    end
+
+    def base_names(file_list)
+      file_list.map { |file| File.basename(file) }
+    end
+  end
+end

data/definitions/scenarios/content.rb

@@ -97,6 +97,24 @@ module ForemanMaintain::Scenarios
       end
     end
 
+    class CleanupRepositoryMetadata < ContentBase
+      metadata do
+        label :cleanup_repository_metadata
+        description 'Remove old leftover repository metadata'
+        param :remove_files, 'Actually remove the files? Otherwise a dryrun is performed.'
+
+        manual_detection
+      end
+
+      def compose
+        add_step_with_context(Procedures::Pulp::CleanupOldMetadataFiles)
+      end
+
+      def set_context_mapping
+        context.map(:remove_files, Procedures::Pulp::CleanupOldMetadataFiles => :remove_files)
+      end
+    end
+
     class RemovePulp2 < ContentBase
       metadata do
         label :content_remove_pulp2

data/definitions/scenarios/upgrade_to_satellite_6_8.rb

@@ -28,6 +28,7 @@ module Scenarios::Satellite_6_8
       add_steps(find_checks(:default))
       add_steps(find_checks(:pre_upgrade))
       add_step(Checks::Foreman::CheckpointSegments)
+      add_step(Checks::Disk::AvailableSpacePostgresql12)
       add_step(Checks::Repositories::Validate.new(:version => '6.8'))
     end
   end

data/definitions/scenarios/upgrade_to_satellite_6_9.rb

@@ -28,6 +28,7 @@ module Scenarios::Satellite_6_9
       add_steps(find_checks(:default))
       add_steps(find_checks(:pre_upgrade))
       add_step(Checks::Foreman::CheckpointSegments)
+      add_step(Checks::Disk::AvailableSpacePostgresql12)
       add_step(Checks::Repositories::Validate.new(:version => '6.9'))
     end
   end

data/lib/foreman_maintain/cli/content_command.rb

@@ -34,6 +34,17 @@ module ForemanMaintain
         end
       end
 
+      subcommand 'cleanup-repository-metadata', 'Cleanup old repository metadata under Pulp 2' do
+        option ['-r', '--remove-files'], :flag, 'Remove the files instead of just listing them.',
+               :attribute_name => :remove_files
+
+        def execute
+          run_scenarios_and_exit(
+            Scenarios::Content::CleanupRepositoryMetadata.new(:remove_files => @remove_files)
+          )
+        end
+      end
+
       subcommand 'remove-pulp2', 'Remove pulp2 and mongodb packages and data' do
         def execute
           run_scenarios_and_exit(Scenarios::Content::RemovePulp2.new)

data/lib/foreman_maintain/runner.rb

@@ -15,6 +15,7 @@ module ForemanMaintain
       @reporter = reporter
       @scenarios = Array(scenarios)
       @quit = false
+      @rescue = false
       @last_scenario = nil
       @last_scenario_continuation_confirmed = false
       @exit_code = 0
@@ -29,12 +30,17 @@ module ForemanMaintain
       @assumeyes
     end
 
+    def rescue?
+      @rescue
+    end
+
     def run
       @scenarios.each do |scenario|
         run_scenario(scenario)
         next unless @quit
 
         if @rescue_scenario
+          @rescue = true
           logger.debug('=== Rescue scenario found. Executing ===')
           execute_scenario_steps(@rescue_scenario, true)
         end
@@ -44,10 +50,10 @@ module ForemanMaintain
 
     def run_scenario(scenario)
       return if scenario.steps.empty?
-      raise 'The runner is already in quit state' if quit?
+      raise 'The runner is already in quit state' if quit? && !rescue?
 
       confirm_scenario(scenario)
-      return if quit?
+      return if quit? && !rescue?
 
       execute_scenario_steps(scenario)
     ensure

data/lib/foreman_maintain/utils/disk/io_device.rb

@@ -26,6 +26,10 @@ module ForemanMaintain
           execute!("df #{dir}|awk {'print $5'}|tail -1").to_i
         end
 
+        def space_used
+          convert_kb_to_mb(execute!("du -ks #{dir} | awk {'print $1'}").to_i)
+        end
+
         private
 
         # In fio command, --direct option bypass the cache page

data/lib/foreman_maintain/version.rb

@@ -1,3 +1,3 @@
 module ForemanMaintain
-  VERSION = '0.7.9'.freeze
+  VERSION = '0.7.13'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_maintain
 version: !ruby/object:Gem::Version
-  version: 0.7.9
+  version: 0.7.13
 platform: ruby
 authors:
 - Ivan Nečas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-25 00:00:00.000000000 Z
+date: 2021-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: clamp
@@ -126,6 +126,7 @@ files:
 - definitions/checks/check_tmout.rb
 - definitions/checks/disk/available_space.rb
 - definitions/checks/disk/available_space_candlepin.rb
+- definitions/checks/disk/available_space_postgresql12.rb
 - definitions/checks/disk/performance.rb
 - definitions/checks/env_proxy.rb
 - definitions/checks/foreman/check_checkpoint_segments.rb
@@ -259,6 +260,7 @@ files:
 - definitions/procedures/packages/update_all_confirmation.rb
 - definitions/procedures/passenger_recycler.rb
 - definitions/procedures/prep_6_10_upgrade.rb
+- definitions/procedures/pulp/cleanup_old_metadata_files.rb
 - definitions/procedures/pulp/migrate.rb
 - definitions/procedures/pulp/remove.rb
 - definitions/procedures/pulpcore/migrate.rb