foreman_maintain 0.6.0 → 0.6.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 9cf2de71b1fd3ab00b7305e517b1529428af64ef
-  data.tar.gz: 5fe408d0a49b4e196c27d81cf9e732fd994358a2
+SHA256:
+  metadata.gz: 78da2357707f4caa6c3a4aa295c75a07abfff9370800b51b0f03647b2f3abb7f
+  data.tar.gz: 592c818c90870337f4fdc866a29e09e9f9b483f712603d18b84cc5533563d615
 SHA512:
-  metadata.gz: 2588c117972fcc18c28fd503b945a9f00313906df3ac225af45ccb0a973e406d31bddd191d84937e3778718fae7e9a45cb7c2b57c812815a65f8922d29b0519b
-  data.tar.gz: 8973ea5b1105d668c3e493cb49e68c95e01bccb298f6fa7c2fa702dd629b781d460aca39a72a8a20d5e6e68e8c92adb6dd3e2678e960f1d976d9d23fcfd6708c
+  metadata.gz: 64cf4d1dee1a471a0082fb6daf6ec23812b50ecfb7a32620966c790c2bf976d75fb1b86ae14e73fbda169393abea261fba30c07c00fad589c19ea5ea9902584b
+  data.tar.gz: 94611d55110abfcb196b9bd758af79352930aa977d36a1deb2c08f412730f596fbfeea19585f03ed671797028e2f7a3e6e4484ecec6e77541c73645260fa1a4c

data/README.md

@@ -48,6 +48,10 @@ Subcommands:
       stop                          Stop maintenance-mode
       status                        Get maintenance-mode status
       is-enabled                    Get maintenance-mode status code
+
+    content                       Content related commands
+      prepare                       Prepare content for Pulp 3 
+      switchover                    Switch support for certain content from Pulp 2 to Pulp 3
 ```
 
 ### Upgrades

data/definitions/checks/check_hotfix_installed.rb

@@ -4,7 +4,8 @@ class Checks::CheckHotfixInstalled < ForemanMaintain::Check
     description 'Check to verify if any hotfix installed on system'
     tags :pre_upgrade
     preparation_steps do
-      Procedures::Packages::Install.new(:packages => %w[yum-utils])
+      [Checks::Repositories::CheckNonRhRepository.new,
+       Procedures::Packages::Install.new(:packages => %w[yum-utils])]
     end
 
     confine do

data/definitions/checks/disk/performance.rb

@@ -3,9 +3,14 @@ module Checks
     class Performance < ForemanMaintain::Check
       metadata do
         label :disk_performance
-        description 'Check for recommended disk speed of pulp, mongodb, pgsql dir.'
-        tags :pre_upgrade
-        preparation_steps { Procedures::Packages::Install.new(:packages => %w[fio]) }
+        preparation_steps do
+          if feature(:instance).downstream
+            [Checks::Repositories::CheckNonRhRepository.new,
+             Procedures::Packages::Install.new(:packages => %w[fio])]
+          else
+            [Procedures::Packages::Install.new(:packages => %w[fio])]
+          end
+        end
 
         confine do
           feature(:instance).pulp
@@ -14,9 +19,6 @@ module Checks
 
       EXPECTED_IO = 60
       DEFAULT_UNIT = 'MB/sec'.freeze
-      DEFAULT_DIRS = [
-        '/var/lib/pulp', '/var/lib/mongodb', '/var/lib/pgsql'
-      ].select { |file_path| File.directory?(file_path) }.freeze
 
       attr_reader :stats
 
@@ -37,16 +39,29 @@ module Checks
         end
       end
 
+      def default_dirs
+        @default_dirs ||= %i[pulp2 pulpcore_database mongo foreman_database].inject({}) do |dirs, f|
+          if feature(f) && File.directory?(feature(f).data_dir)
+            dirs[feature(f).label_dashed] = feature(f).data_dir
+          end
+          dirs
+        end
+      end
+
+      def description
+        "Check recommended disk speed for #{default_dirs.keys.join(', ')} directories."
+      end
+
       def check_only_single_device?
-        DEFAULT_DIRS.map do |dir|
+        default_dirs.values do |dir|
           ForemanMaintain::Utils::Disk::Device.new(dir).name
         end.uniq.length <= 1
       end
 
       def dirs_to_check
-        return DEFAULT_DIRS.first(1) if check_only_single_device?
+        return default_dirs.values.first(1) if check_only_single_device?
 
-        DEFAULT_DIRS
+        default_dirs.values
       end
 
       private

data/definitions/checks/foreman/check_corrupted_roles.rb

@@ -14,14 +14,22 @@ module Checks
       def run
         items = find_filter_permissions
         assert(items.empty?,
-               'There are user roles with inconsistent filters',
+               error_message(items),
                :next_steps => Procedures::Foreman::FixCorruptedRoles.new)
       end
 
+      def error_message(items)
+        roles = items.map { |item| item['role_name'] }.uniq
+        'There are filters having permissions with multiple resource types. ' \
+        'Roles with such filters are:' \
+        "\n#{roles.join("\n")}"
+      end
+
       def find_filter_permissions
         feature(:foreman_database).query(self.class.inconsistent_filter_perms)
       end
 
+      # rubocop:disable Metrics/MethodLength
       def self.inconsistent_filter_perms
         subquery = <<-SQL
           SELECT filters.id AS filter_id,
@@ -32,14 +40,17 @@ module Checks
                  filterings.id AS filtering_id,
                  permissions.id AS permission_id,
                  permissions.name AS permission_name,
-                 permissions.resource_type
+                 permissions.resource_type,
+                 roles.name AS role_name
           FROM filters INNER JOIN filterings ON filters.id = filterings.filter_id
                        INNER JOIN permissions ON permissions.id = filterings.permission_id
+                       INNER JOIN roles ON filters.role_id = roles.id
         SQL
 
         <<-SQL
           SELECT DISTINCT first.filter_id,
                           first.role_id,
+                          first.role_name,
                           first.filtering_id,
                           first.permission_id,
                           first.permission_name,
@@ -54,6 +65,7 @@ module Checks
                 OR (first.resource_type != second.resource_type))
         SQL
       end
+      # rubocop:enable Metrics/MethodLength
     end
   end
 end

data/definitions/checks/foreman/validate_external_db_version.rb

@@ -0,0 +1,28 @@
+module Checks
+  module Foreman
+    class ValidateExternalDbVersion < ForemanMaintain::Check
+      metadata do
+        description 'Make sure server is running on required database version'
+        tags :pre_upgrade
+        label :validate_external_db_version
+        confine do
+          feature(:foreman_database) && !feature(:foreman_database).local? &&
+            !check_min_version('foreman', '2.0')
+        end
+      end
+
+      def run
+        current_db_version = feature(:foreman_database).db_version
+        fail!(db_upgrade_message(current_db_version)) if current_db_version.major < 12
+      end
+
+      def db_upgrade_message(db_version)
+        product_name = feature(:instance).product_name
+
+        "\n\n*** ERROR: Server is running on PostgreSQL #{db_version} database.\n"\
+        "*** Newer version of #{product_name} supports only PostgreSQL version 12.\n"\
+        "*** Before proceeding further, you must upgrade database to PostgreSQL 12.\n"
+      end
+    end
+  end
+end

data/definitions/checks/original_assets.rb

@@ -2,6 +2,7 @@ class Checks::OriginalAssets < ForemanMaintain::Check
   metadata do
     description 'Check if only installed assets are present on the system'
     tags :post_upgrade
+    for_feature :foreman_server
   end
 
   ASSETS_DIR = '/var/lib/foreman/public/assets'.freeze

data/definitions/checks/pulpcore/db_up.rb

@@ -0,0 +1,29 @@
+module Checks
+  module Pulpcore
+    class DBUp < ForemanMaintain::Check
+      metadata do
+        description 'Make sure Pulpcore DB is up'
+        label :pulpcore_db_up
+        for_feature :pulpcore_database
+      end
+
+      def run
+        status = false
+        with_spinner('Checking connection to the Pulpcore DB') do
+          status = feature(:pulpcore_database).ping
+        end
+        assert(status, 'Pulpcore DB is not responding. ' \
+          'It needs to be up and running to perform the following steps',
+               :next_steps => next_steps)
+      end
+
+      def next_steps
+        if feature(:pulpcore_database).local?
+          [Procedures::Service::Start.new(:only => 'postgresql')]
+        else
+          [] # there is nothing we can do for remote db
+        end
+      end
+    end
+  end
+end

data/definitions/checks/repositories/check_non_rh_repository.rb

@@ -0,0 +1,23 @@
+module Checks::Repositories
+  class CheckNonRhRepository < ForemanMaintain::Check
+    metadata do
+      label :check_non_redhat_repository
+      description "Check whether system don't have any non Red Hat repositories(Eg: EPEL) enabled"
+      tags :pre_upgrade
+      confine do
+        feature(:instance).downstream
+      end
+    end
+
+    def run
+      with_spinner('Checking repositories enabled on the system') do
+        assert(!epel_enabled?, 'System is subscribed to non Red Hat repositories(Eg: EPEL)')
+      end
+    end
+
+    def epel_enabled?
+      system_repos = execute("yum repolist enabled -d 6 -e 0| grep -E 'Repo-baseurl|Repo-id'")
+      system_repos.to_s.match(/\bepel\b/i)
+    end
+  end
+end

data/definitions/checks/repositories/check_upstream_repository.rb

@@ -4,7 +4,8 @@ class Checks::CheckUpstreamRepository < ForemanMaintain::Check
     description 'Check if any upstream repositories are enabled on system'
     tags :pre_upgrade
     preparation_steps do
-      Procedures::Packages::Install.new(:packages => %w[yum-utils])
+      [Checks::Repositories::CheckNonRhRepository.new,
+       Procedures::Packages::Install.new(:packages => %w[yum-utils])]
     end
     confine do
       feature(:instance).downstream

data/definitions/checks/repositories/validate.rb

@@ -3,7 +3,8 @@ module Checks::Repositories
     metadata do
       description 'Validate availability of repositories'
       preparation_steps do
-        Procedures::Packages::Install.new(:packages => [ForemanMaintain::Utils::Facter.package])
+        [Checks::Repositories::CheckNonRhRepository.new,
+         Procedures::Packages::Install.new(:packages => [ForemanMaintain::Utils::Facter.package])]
       end
 
       confine do

data/definitions/features/apache.rb

@@ -0,0 +1,19 @@
+class Features::Apache < ForemanMaintain::Feature
+  metadata do
+    label :apache
+
+    confine do
+      find_package('httpd')
+    end
+  end
+
+  def services
+    [
+      system_service('httpd', 30)
+    ]
+  end
+
+  def config_files
+    ['/etc/httpd']
+  end
+end

data/definitions/features/dynflow_sidekiq.rb

@@ -13,7 +13,7 @@ class Features::DynflowSidekiq < ForemanMaintain::Feature
 
   def config_files
     # Workaround until foreman-installer can deploy scaled workers
-    service_symlinks = configured_services.map do |service|
+    service_symlinks = configured_instances.map do |service|
       "/etc/systemd/system/multi-user.target.wants/#{service}.service"
     end
     [

data/definitions/features/foreman_database.rb

@@ -16,9 +16,11 @@ class Features::ForemanDatabase < ForemanMaintain::Feature
   end
 
   def config_files
-    [
-      '/var/lib/pgsql/data/postgresql.conf'
-    ]
+    if check_min_version('foreman', '2.0')
+      ['/var/opt/rh/rh-postgresql12/lib/pgsql/data/postgresql.conf']
+    else
+      ['/var/lib/pgsql/data/postgresql.conf']
+    end
   end
 
   def services

data/definitions/features/foreman_server.rb

@@ -9,9 +9,11 @@ module ForemanMaintain
       end
 
       def services
-        [
-          system_service('httpd', 30)
-        ]
+        if execute?('systemctl is-enabled foreman')
+          [system_service('foreman', 30, :socket => 'foreman')]
+        else
+          [system_service('httpd', 30)]
+        end
       end
 
       def plugins
@@ -41,6 +43,10 @@ module ForemanMaintain
           '/var/lib/foreman/public'
         ]
       end
+
+      def services_running?
+        services.all?(&:running?)
+      end
     end
   end
 end

data/definitions/features/foreman_tasks.rb

@@ -162,8 +162,13 @@ class Features::ForemanTasks < ForemanMaintain::Feature
   def export_csv(sql, file_name, state)
     dir = prepare_for_backup(state)
     filepath = "#{dir}/#{file_name}"
-    execute("echo \"COPY (#{sql}) TO STDOUT WITH CSV;\" \
-      | su - postgres -c '/usr/bin/psql -d foreman' | bzip2 -9 > #{filepath}.bz2")
+    csv_output = feature(:foreman_database).query_csv(sql)
+    File.open(filepath, 'w') do |f|
+      f.write(csv_output)
+      f.close
+    end
+    execute("bzip2 #{filepath} -c -9 > #{filepath}.bz2")
+    FileUtils.rm_rf(filepath)
   end
 
   def old_tasks_condition(state = "'stopped', 'paused'")

data/definitions/features/installer.rb

@@ -92,8 +92,15 @@ class Features::Installer < ForemanMaintain::Feature
   end
 
   def upgrade(exec_options = {})
-    arguments = '--upgrade' if can_upgrade?
-    run(arguments, exec_options)
+    run(installer_arguments, exec_options)
+  end
+
+  def installer_arguments
+    installer_args = ' --disable-system-checks'
+    unless check_min_version('foreman', '2.1') || check_min_version('foreman-proxy', '2.1')
+      installer_args += ' --upgrade' if can_upgrade?
+    end
+    installer_args
   end
 
   def initial_admin_username

data/definitions/features/instance.rb

@@ -37,7 +37,9 @@ class Features::Instance < ForemanMaintain::Feature
   end
 
   def postgresql_local?
-    database_local?(:candlepin_database) || database_local?(:foreman_database)
+    database_local?(:candlepin_database) ||
+      database_local?(:foreman_database) ||
+      database_local?(:pulpcore_database)
   end
 
   def foreman_proxy_with_content?
@@ -65,7 +67,7 @@ class Features::Instance < ForemanMaintain::Feature
   end
 
   def pulp
-    feature(:pulp2) || feature(:pulp3)
+    feature(:pulp2) || feature(:pulpcore)
   end
 
   private
@@ -143,6 +145,7 @@ class Features::Instance < ForemanMaintain::Feature
       'candlepin' => %w[candlepin candlepin_database],
       'pulp_auth' => %w[pulp2 mongo],
       'pulp' => %w[pulp2 mongo],
+      'pulpcore' => %w[pulpcore pulpcore_database],
       'foreman_tasks' => %w[foreman_tasks]
     }
   end

data/definitions/features/katello.rb

@@ -52,6 +52,13 @@ class Features::Katello < ForemanMaintain::Feature
   end
   # rubocop:enable  Metrics/MethodLength
 
+  def config_files_exclude_for_online
+    [
+      '/var/lib/qpidd',
+      '/var/lib/candlepin/activemq-artemis'
+    ]
+  end
+
   private
 
   def installer_scenario_answers

data/definitions/features/{pulp3.rb → pulpcore.rb}

@@ -1,8 +1,8 @@
 require 'foreman_maintain/utils/service/systemd'
 
-class Features::Pulp3 < ForemanMaintain::Feature
+class Features::Pulpcore < ForemanMaintain::Feature
   metadata do
-    label :pulp3
+    label :pulpcore
 
     confine do
       ForemanMaintain::Utils::Service::Systemd.new('pulpcore-api', 0).exist?
@@ -11,12 +11,18 @@ class Features::Pulp3 < ForemanMaintain::Feature
 
   def services
     [
+      system_service('rh-redis5-redis', 5),
       system_service('pulpcore-api', 10),
       system_service('pulpcore-content', 10),
       system_service('pulpcore-resource-manager', 10),
       system_service('pulpcore-worker@*', 20, :all => true, :skip_enablement => true),
-      system_service('rh-redis5-redis', 30),
       system_service('httpd', 30)
     ]
   end
+
+  def config_files
+    [
+      '/etc/pulp/settings.py'
+    ]
+  end
 end

data/definitions/features/pulpcore_database.rb

@@ -0,0 +1,39 @@
+class Features::PulpcoreDatabase < ForemanMaintain::Feature
+  PULPCORE_DB_CONFIG = '/etc/pulp/settings.py'.freeze
+
+  include ForemanMaintain::Concerns::BaseDatabase
+
+  metadata do
+    label :pulpcore_database
+
+    confine do
+      file_nonzero?(PULPCORE_DB_CONFIG)
+    end
+  end
+
+  def configuration
+    @configuration || load_configuration
+  end
+
+  def services
+    [
+      system_service('postgresql', 10, :component => 'pulpcore',
+                                       :db_feature => feature(:pulpcore_database))
+    ]
+  end
+
+  private
+
+  def load_configuration
+    full_config = File.read(PULPCORE_DB_CONFIG).split(/[\s,'":]/).reject(&:empty?)
+
+    @configuration = {}
+    @configuration['adapter'] = 'postgresql'
+    @configuration['host'] = full_config[full_config.index('HOST') + 1]
+    @configuration['port'] = full_config[full_config.index('PORT') + 1]
+    @configuration['database'] = full_config[full_config.index('NAME') + 1]
+    @configuration['username'] = full_config[full_config.index('USER') + 1]
+    @configuration['password'] = full_config[full_config.index('PASSWORD') + 1]
+    @configuration
+  end
+end