foreman_maintain 0.5.0 → 0.5.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f7559f6d4d97f5b61279e22233855efd6ffcf4061013b107389f9bb0469832e5
-  data.tar.gz: 9a3c76b2006e87a0f2d5a6021f26a35624c70e08409dafffa76e1a518565e89a
+  metadata.gz: 88713e93aedca954a3162bfcb296a4e34702d3d5ffa4378b6f913081a5377e2c
+  data.tar.gz: 561a9cf651b6a8676efe9471eb2cde54e30cec37cf37f311f59ee7a886f44642
 SHA512:
-  metadata.gz: 7967c8ed3ec1830e917f25765626758ba4d8d1af636d7003e6522ddd038540fab1f33d62630cacd1dfd2855084bb2e2b4cbc50be84ed8582e3157a819f7bb4d5
-  data.tar.gz: 7c5fbf539f92af28e9e4326b276812c1f4bb4a13aaca8b0948f7c8d33fb26f7480864d6d269cb141c50e8870cc7a1dae9e668c25163d4b86fadf8033c4cf1cb6
+  metadata.gz: 0d0d4a7cbdad45bcfd35be8029fa7be9b458b72df62a9e83a72ffdd1e3b049fcff2ba72b2368531f2a40a40ac6578381fe57a91ef8abbcd7edd63908b9759071
+  data.tar.gz: 4635df0f060dd06372cb9ff77cbc6f0ac8756dbd4b7814f47e27444e4e1d480b648b5175391f4c337e1dd3934a5b077d5db4caa22b74b4c085ac66c9ba81dba9

data/definitions/checks/foreman/facts_names.rb

@@ -0,0 +1,32 @@
+module Checks
+  module Foreman
+    class FactsNames < ForemanMaintain::Check
+      metadata do
+        label :foreman_fact_names
+        tags :default
+        confine do
+          feature(:foreman_database)
+        end
+        description 'Check number of fact names in database'
+      end
+
+      def run
+        max = 10_000
+        sql = <<-SQL
+        select fact_values.host_id, count(fact_values.id) from fact_values
+        group by fact_values.host_id order by count desc limit 1
+        SQL
+        result = feature(:foreman_database).query(sql).first
+        if result
+          host_id = result['host_id']
+          count = result['count'].to_i
+          assert(count < max,
+                 "Host (ID #{host_id}) has #{count} fact values which is more than #{max}.\n" \
+                 'This can cause slow fact processing.',
+                 :warn => true,
+                 :next_steps => [Procedures::KnowledgeBaseArticle.new(:doc => 'many_fact_values')])
+        end
+      end
+    end
+  end
+end

data/definitions/checks/original_assets.rb

@@ -10,7 +10,7 @@ class Checks::OriginalAssets < ForemanMaintain::Check
     custom_assets = []
     product_name = feature(:instance).product_name
     with_spinner('Checking for presence of non-original assets...') do
-      custom_assets = feature(:package_manager).files_not_owned_by_package(ASSETS_DIR)
+      custom_assets = package_manager.files_not_owned_by_package(ASSETS_DIR)
       logger.info("Non-original assets detected:\n" + custom_assets.join("\n"))
     end
     remove_files = Procedures::Files::Remove.new(:files => custom_assets, :assumeyes => true)

data/definitions/checks/version_locking_enabled.rb

@@ -5,7 +5,7 @@ module Checks
     end
 
     def run
-      enabled = feature(:package_manager).version_locking_enabled?
+      enabled = package_manager.version_locking_enabled?
       enable_locking = Procedures::Packages::EnableVersionLocking.new(:assumeyes => assumeyes?)
       assert(enabled, 'Tools for package version locking are not available on this system',
              :next_steps => enable_locking)

data/definitions/features/capsule.rb

@@ -5,8 +5,8 @@ class Features::Capsule < ForemanMaintain::Feature
     label :capsule
 
     confine do
-      feature(:package_manager).installed?(['satellite-capsule']) ||
-        feature(:package_manager).installed?(['capsule-installer'])
+      package_manager.installed?(['satellite-capsule']) ||
+        package_manager.installed?(['capsule-installer'])
     end
   end
 

data/definitions/features/foreman_tasks.rb

@@ -55,7 +55,7 @@ class Features::ForemanTasks < ForemanMaintain::Feature
     sql = <<-SQL
       SELECT count(*) AS count
         FROM foreman_tasks_tasks
-        WHERE state IN ('paused')
+        WHERE state IN ('paused') AND result IN ('error')
     SQL
     unless ignored_tasks.empty?
       sql << "AND label NOT IN (#{quotize(ignored_tasks)})"
@@ -162,8 +162,13 @@ class Features::ForemanTasks < ForemanMaintain::Feature
   def export_csv(sql, file_name, state)
     dir = prepare_for_backup(state)
     filepath = "#{dir}/#{file_name}"
-    execute("echo \"COPY (#{sql}) TO STDOUT WITH CSV;\" \
-      | su - postgres -c '/usr/bin/psql -d foreman' | bzip2 -9 > #{filepath}.bz2")
+    csv_output = feature(:foreman_database).query_csv(sql)
+    File.open(filepath, 'w') do |f|
+      f.write(csv_output)
+      f.close
+    end
+    execute("bzip2 #{filepath} -c -9 > #{filepath}.bz2")
+    FileUtils.rm_rf(filepath)
   end
 
   def old_tasks_condition(state = "'stopped', 'paused'")

data/definitions/features/katello.rb

@@ -32,7 +32,11 @@ class Features::Katello < ForemanMaintain::Feature
       '/etc/sysconfig/tomcat*',
       '/etc/tomcat*',
       '/var/lib/candlepin',
-      '/usr/share/foreman/bundler.d/katello.rb'
+      '/usr/share/foreman/bundler.d/katello.rb',
+      '/etc/qpid',
+      '/etc/qpid-dispatch',
+      '/var/lib/qpidd',
+      '/etc/qpid-dispatch'
     ]
 
     if installer_scenario_answers['certs']
@@ -48,6 +52,13 @@ class Features::Katello < ForemanMaintain::Feature
   end
   # rubocop:enable  Metrics/MethodLength
 
+  def config_files_exclude_for_online
+    [
+      '/var/lib/qpidd',
+      '/var/lib/candlepin/activemq-artemis'
+    ]
+  end
+
   private
 
   def installer_scenario_answers

data/definitions/features/pulp.rb

@@ -30,12 +30,8 @@ class Features::Pulp < ForemanMaintain::Feature
     [
       '/etc/pki/pulp',
       '/etc/pulp',
-      '/etc/qpid',
-      '/etc/qpid-dispatch',
       '/etc/crane.conf',
-      '/etc/default/pulp_workers',
-      '/var/lib/qpidd',
-      '/etc/qpid-dispatch'
+      '/etc/default/pulp_workers'
     ]
   end
 end

data/definitions/features/puppet_server.rb

@@ -29,7 +29,7 @@ class Features::PuppetServer < ForemanMaintain::Feature
   end
 
   def puppet_version
-    version(execute!('puppet --version'))
+    version(execute!("#{puppet_path} --version"))
   end
 
   def find_empty_cacert_request_files
@@ -56,6 +56,10 @@ class Features::PuppetServer < ForemanMaintain::Feature
   end
 
   def puppet_ssldir_path
-    execute!('puppet master --configprint ssldir')
+    execute!("#{puppet_path} config print ssldir")
+  end
+
+  def puppet_path
+    '/opt/puppetlabs/bin/puppet'
   end
 end

data/definitions/features/satellite.rb

@@ -5,7 +5,7 @@ class Features::Satellite < ForemanMaintain::Feature
     label :satellite
 
     confine do
-      feature(:package_manager).installed?(['satellite'])
+      package_manager.installed?(['satellite'])
     end
   end
 

data/definitions/features/tar.rb

@@ -24,6 +24,7 @@ class Features::Tar < ForemanMaintain::Feature
   # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
   def run(options = {})
     volume_size = options.fetch(:volume_size, nil)
+    absolute_names = options.fetch(:absolute_names, nil)
     validate_volume_size(volume_size) unless volume_size.nil?
 
     tar_command = ['tar']
@@ -31,6 +32,10 @@ class Features::Tar < ForemanMaintain::Feature
     tar_command << "--#{options.fetch(:command, 'create')}"
     tar_command << "--file=#{options.fetch(:archive)}"
 
+    if absolute_names
+      tar_command << '--absolute-names'
+    end
+
     if volume_size
       split_tar_script = default_split_tar_script
       tar_command << "--tape-length=#{volume_size}"

data/definitions/procedures/backup/config_files.rb

@@ -13,6 +13,8 @@ module Procedures::Backup
             :array => true, :default => ['all']
       param :ignore_changed_files, 'Should packing tar ignore changed files',
             :flag => true, :default => false
+      param :online_backup, 'The config files are being prepared for an online backup',
+            :flag => true, :default => false
     end
 
     def run
@@ -39,6 +41,7 @@ module Procedures::Backup
 
         configs += feature.config_files
         exclude_configs += feature.config_files_to_exclude
+        exclude_configs += feature.config_files_exclude_for_online if @online_backup
       end
 
       if feature(:foreman_proxy)

data/definitions/procedures/backup/prepare_directory.rb

@@ -8,6 +8,7 @@ module Procedures::Backup
       param :incremental_dir, 'Changes since specified backup only'
     end
 
+    # rubocop:disable Metrics/MethodLength
     def run
       puts "Creating backup folder #{@backup_dir}"
 
@@ -22,8 +23,14 @@ module Procedures::Backup
 
       FileUtils.rm(Dir.glob(File.join(@backup_dir, '.*.snar'))) if @preserve_dir
       if @incremental_dir
-        FileUtils.cp(Dir.glob(File.join(@incremental_dir, '.*.snar')), @backup_dir)
+        if (snar_files = Dir.glob(File.join(@incremental_dir, '.*.snar'))).empty?
+          raise "#{@incremental_dir}/*.snar files unavailable. "\
+                'Provide a valid previous backup directory'
+        else
+          FileUtils.cp(snar_files, @backup_dir)
+        end
       end
     end
+    # rubocop:enable Metrics/MethodLength
   end
 end

data/definitions/procedures/foreman/fix_corrupted_roles.rb

@@ -2,7 +2,6 @@ module Procedures::Foreman
   class FixCorruptedRoles < ForemanMaintain::Procedure
     metadata do
       for_feature :foreman_database
-      tags :pre_migration
       desc = 'Create additional filters so that each filter has only permissions of one resource'
       description desc
       confine do

data/definitions/procedures/foreman_openscap/invalid_report_associations.rb

@@ -3,7 +3,7 @@ module Procedures::ForemanOpenscap
     metadata do
       param :ids_to_remove, 'Ids of reports to remove', :required => true
       for_feature :foreman_openscap
-      tags :pre_migration, :foreman_openscap, :openscap_report_associations
+      tags :foreman_openscap, :openscap_report_associations
       advanced_run false
       description 'Delete reports with association issues'
     end

data/definitions/procedures/knowledge_base_article.rb

@@ -25,7 +25,8 @@ class Procedures::KnowledgeBaseArticle < ForemanMaintain::Procedure
     {
       'fix_cpdb_validate_failure' => 'https://access.redhat.com/solutions/3362821',
       'fix_db_migrate_failure_on_duplicate_roles' => 'https://access.redhat.com/solutions/3998941',
-      'upgrade_puppet_guide_for_sat63' => 'https://access.redhat.com/documentation/en-us/red_hat_satellite/6.3/html/upgrading_and_updating_red_hat_satellite/upgrading_puppet-1'
+      'upgrade_puppet_guide_for_sat63' => 'https://access.redhat.com/documentation/en-us/red_hat_satellite/6.3/html/upgrading_and_updating_red_hat_satellite/upgrading_puppet-1',
+      'many_fact_values' => 'https://access.redhat.com/solutions/4163891'
     }
   end
 end

data/definitions/procedures/packages/enable_version_locking.rb

@@ -6,7 +6,7 @@ module Procedures::Packages
     end
 
     def run
-      feature(:package_manager).install_version_locking(:assumeyes => @assumeyes)
+      package_manager.install_version_locking(:assumeyes => @assumeyes)
     end
   end
 end

data/definitions/procedures/packages/installer_confirmation.rb

@@ -5,7 +5,7 @@ module Procedures::Packages
     end
 
     def run
-      question = "WARNING: This script runs #{feature(:installer).installer_command} " \
+      question = "\nWARNING: This script runs #{feature(:installer).installer_command} " \
         "after the yum execution \n" \
         "to ensure the #{feature(:instance).product_name} " \
         "is in a consistent state.\n" \

data/definitions/procedures/packages/lock_versions.rb

@@ -1,13 +1,12 @@
 module Procedures::Packages
   class LockVersions < ForemanMaintain::Procedure
     metadata do
-      for_feature :package_manager
       description 'Lock packages'
       preparation_steps { [Checks::VersionLockingEnabled.new] }
     end
 
     def run
-      feature(:package_manager).lock_versions
+      package_manager.lock_versions
     end
   end
 end

data/definitions/procedures/packages/locking_status.rb

@@ -1,7 +1,6 @@
 module Procedures::Packages
   class LockingStatus < ForemanMaintain::Procedure
     metadata do
-      for_feature :package_manager
       description 'Check status of version locking of packages'
       preparation_steps { [Checks::VersionLockingEnabled.new] }
     end
@@ -14,7 +13,7 @@ module Procedures::Packages
     private
 
     def check_version_locked
-      if feature(:package_manager).versions_locked?
+      if package_manager.versions_locked?
         puts '  Packages are locked.'
       else
         puts '  Packages are not locked.'

data/definitions/procedures/packages/unlock_versions.rb

@@ -1,13 +1,12 @@
 module Procedures::Packages
   class UnlockVersions < ForemanMaintain::Procedure
     metadata do
-      for_feature :package_manager
       description 'Unlock packages'
       preparation_steps { [Checks::VersionLockingEnabled.new] }
     end
 
     def run
-      feature(:package_manager).unlock_versions
+      package_manager.unlock_versions
     end
   end
 end

data/definitions/procedures/packages/update.rb

@@ -10,7 +10,7 @@ module Procedures::Packages
 
     def run
       assumeyes_val = @assumeyes.nil? ? assumeyes? : @assumeyes
-      feature(:package_manager).clean_cache
+      package_manager.clean_cache
       packages_action(:update, @packages, :assumeyes => assumeyes_val)
     rescue ForemanMaintain::Error::ExecutionError => e
       if @warn_on_errors

data/definitions/procedures/packages/update_all_confirmation.rb

@@ -0,0 +1,24 @@
+module Procedures::Packages
+  class UpdateAllConfirmation < ForemanMaintain::Procedure
+    metadata do
+      param :packages, 'List of packages to update', :array => true
+
+      description 'Confirm update all is intentional'
+    end
+
+    def run
+      if @packages.nil? || @packages.empty?
+        question = "\nWARNING: No specific packages to update were provided\n" \
+          "so we are going to update all available packages.\n" \
+          "It is recommended to update everything only as part of upgrade\n" \
+          "of the #{feature(:instance).product_name} to the next version. \n" \
+          "To Upgrade to next version use 'foreman-maintain upgrade'.\n\n" \
+          "NOTE: --assumeyes is not applicable for this check\n\n" \
+          "Do you want to proceed with update of everything regardless\n" \
+          'of the recommendations?'
+        answer = ask_decision(question, 'y(yes), q(quit)', ignore_assumeyes: true)
+        abort! unless answer == :yes
+      end
+    end
+  end
+end

data/definitions/procedures/restore/extract_files.rb

@@ -29,6 +29,7 @@ module Procedures::Restore
     def base_tar
       {
         :overwrite => true,
+        :absolute_names => true,
         :listed_incremental => '/dev/null',
         :command => 'extract',
         :directory => '/'

data/definitions/scenarios/backup.rb

@@ -186,7 +186,8 @@ module ForemanMaintain::Scenarios
     # rubocop:enable  Metrics/MethodLength
 
     def add_online_backup_steps
-      add_step_with_context(Procedures::Backup::ConfigFiles, :ignore_changed_files => true)
+      add_step_with_context(Procedures::Backup::ConfigFiles, :ignore_changed_files => true,
+                                                             :online_backup => true)
       add_step_with_context(Procedures::Backup::Pulp, :ensure_unchanged => true)
       add_steps_with_context(
         Procedures::Backup::Online::Mongo,

data/definitions/scenarios/packages.rb

@@ -71,8 +71,11 @@ module ForemanMaintain::Scenarios
       end
 
       def compose
-        add_step_with_context(Procedures::Packages::InstallerConfirmation)
-        add_step_with_context(Procedures::Packages::UnlockVersions)
+        add_steps_with_context(
+          Procedures::Packages::UpdateAllConfirmation,
+          Procedures::Packages::InstallerConfirmation,
+          Procedures::Packages::UnlockVersions
+        )
         add_step_with_context(Procedures::Packages::Update, :force => true, :warn_on_errors => true)
         add_step_with_context(Procedures::Installer::Run,
                               :arguments => '--upgrade --disable-system-checks')
@@ -81,7 +84,8 @@ module ForemanMaintain::Scenarios
 
       def set_context_mapping
         context.map(:packages,
-                    Procedures::Packages::Update => :packages)
+                    Procedures::Packages::Update => :packages,
+                    Procedures::Packages::UpdateAllConfirmation => :packages)
         context.map(:assumeyes,
                     Procedures::Packages::Update => :assumeyes)
       end

data/extras/foreman_protector/foreman-protector.py

@@ -77,7 +77,7 @@ def exclude_hook(conduit):
         else:
             suffix = ''
         conduit.info(1, '\n'
-                        'WARNING: Excluding %d update%s due to foreman-protector. \n'
+                        'WARNING: Excluding %d package%s due to foreman-protector. \n'
                         'Use foreman-maintain packages install/update <package> \n'
                         'to safely install packages without restrictions.\n'
                         'Use foreman-maintain upgrade run for full upgrade.\n'

data/extras/foreman_protector/foreman-protector.whitelist

@@ -15,5 +15,6 @@ librdmacm
 rdma-core
 boost-random
 boost-iostreams
+boost-thread
 # foreman-maintain
 rubygem-foreman_maintain

data/lib/foreman_maintain.rb

@@ -36,9 +36,9 @@ module ForemanMaintain
   require 'foreman_maintain/runner'
   require 'foreman_maintain/upgrade_runner'
   require 'foreman_maintain/reporter'
+  require 'foreman_maintain/package_manager'
   require 'foreman_maintain/utils'
   require 'foreman_maintain/error'
-  require 'foreman_maintain/package_manager'
 
   class << self
     attr_accessor :config, :logger

data/lib/foreman_maintain/cli/packages_command.rb

@@ -38,7 +38,7 @@ module ForemanMaintain
 
       subcommand 'update', 'Update packages in an unlocked session' do
         interactive_option
-        parameter 'PACKAGES ...', 'packages to update', :attribute_name => :packages
+        parameter '[PACKAGES ...]', 'packages to update', :attribute_name => :packages
 
         def execute
           run_scenarios_and_exit(
@@ -53,7 +53,7 @@ module ForemanMaintain
       subcommand 'is-locked', 'Check if update of packages is allowed' do
         interactive_option
         def execute
-          locked = feature(:package_manager).versions_locked?
+          locked = ForemanMaintain.package_manager.versions_locked?
           puts "Packages are#{locked ? '' : ' not'} locked"
           exit_code = locked ? 0 : 1
           exit exit_code

data/lib/foreman_maintain/concerns/downstream.rb

@@ -87,8 +87,7 @@ module ForemanMaintain
                  else
                    "rhel-#{rh_version_major}-server-#{package_name}-#{full_version}-rpms"
                  end
-
-        if current_minor_version == '6.3' && server_version.to_s != '6.4' && (
+        if current_minor_version == '6.3' && full_version.to_s != '6.4' && (
           feature(:puppet_server) && feature(:puppet_server).puppet_version.major == 4)
           # TODO: confirm repo for capsule. It might be same repo
           repos << "rhel-#{rh_version_major}-server-satellite-tools-6.3-puppet4-rpms"

data/lib/foreman_maintain/concerns/system_helpers.rb

@@ -85,7 +85,7 @@ module ForemanMaintain
       end
 
       def find_package(name)
-        feature(:package_manager).find_installed_package(name)
+        package_manager.find_installed_package(name)
       end
 
       def hostname
@@ -100,11 +100,11 @@ module ForemanMaintain
         options.validate_options!(:assumeyes)
         case action
         when :install
-          feature(:package_manager).install(packages, :assumeyes => options[:assumeyes])
+          package_manager.install(packages, :assumeyes => options[:assumeyes])
         when :update
-          feature(:package_manager).update(packages, :assumeyes => options[:assumeyes])
+          package_manager.update(packages, :assumeyes => options[:assumeyes])
         when :remove
-          feature(:package_manager).remove(packages, :assumeyes => options[:assumeyes])
+          package_manager.remove(packages, :assumeyes => options[:assumeyes])
         else
           raise ArgumentError, "Unexpected action #{action} expected #{expected_actions.inspect}"
         end
@@ -178,6 +178,10 @@ module ForemanMaintain
         result
       end
 
+      def package_manager
+        ForemanMaintain.package_manager
+      end
+
       private
 
       def check_version(name)

data/lib/foreman_maintain/feature.rb

@@ -41,5 +41,9 @@ module ForemanMaintain
     def config_files_to_exclude
       []
     end
+
+    def config_files_exclude_for_online
+      []
+    end
   end
 end

data/lib/foreman_maintain/package_manager.rb

@@ -1,3 +1,16 @@
 require 'foreman_maintain/package_manager/base'
 require 'foreman_maintain/package_manager/yum'
 require 'foreman_maintain/package_manager/dnf'
+
+module ForemanMaintain
+  def self.package_manager
+    @package_manager ||= case (%w[dnf yum apt].find { |manager| !`command -v #{manager}`.empty? })
+                         when 'dnf'
+                           ForemanMaintain::PackageManager::Dnf.new
+                         when 'yum'
+                           ForemanMaintain::PackageManager::Yum.new
+                         else
+                           raise 'No supported package manager was found'
+                         end
+  end
+end

data/lib/foreman_maintain/reporter/cli_reporter.rb

@@ -184,9 +184,9 @@ module ForemanMaintain
         ask_to_select('Select step to continue', steps, &:runtime_message)
       end
 
-      def ask_decision(message, options = 'y(yes), n(no), q(quit)')
-        if assumeyes?
-          print("#{message} (assuming yes)")
+      def ask_decision(message, options = 'y(yes), n(no), q(quit)', ignore_assumeyes: false)
+        if !ignore_assumeyes && assumeyes?
+          print("#{message} (assuming yes)\n")
           return :yes
         end
         until_valid_decision do

data/lib/foreman_maintain/utils/disk/io_device.rb

@@ -27,7 +27,7 @@ module ForemanMaintain
         # In fio command, --direct option bypass the cache page
         def fio
           cmd = "fio --name=job1 --rw=read --size=1g --output-format=json\
-                  --directory=#{dir} --direct=1"
+                  --directory=#{dir} --direct=1 --unlink=1"
           stdout = execute(cmd)
           output = JSON.parse(stdout)
           @fio ||= output['jobs'].first['read']['bw'].to_i

data/lib/foreman_maintain/utils/facter.rb

@@ -5,7 +5,7 @@ module ForemanMaintain::Utils
     FACTER_FILES = %w[/usr/bin/facter /opt/puppetlabs/bin/facter].freeze
 
     def self.package
-      puppet_version = version(execute!('puppet --version'))
+      puppet_version = version(execute!('/opt/puppetlabs/bin/puppet --version'))
 
       puppet_version.major >= 4 ? 'puppet-agent' : 'facter'
     end

data/lib/foreman_maintain/version.rb

@@ -1,3 +1,3 @@
 module ForemanMaintain
-  VERSION = '0.5.0'.freeze
+  VERSION = '0.5.5'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_maintain
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.5
 platform: ruby
 authors:
 - Ivan Nečas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-12 00:00:00.000000000 Z
+date: 2020-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: clamp
@@ -42,16 +42,16 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.17'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.17'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -130,6 +130,7 @@ files:
 - definitions/checks/foreman/check_corrupted_roles.rb
 - definitions/checks/foreman/check_duplicate_roles.rb
 - definitions/checks/foreman/db_up.rb
+- definitions/checks/foreman/facts_names.rb
 - definitions/checks/foreman/puppet_class_duplicates.rb
 - definitions/checks/foreman_openscap/invalid_report_associations.rb
 - definitions/checks/foreman_proxy/verify_dhcp_config_syntax.rb
@@ -173,7 +174,6 @@ files:
 - definitions/features/iptables.rb
 - definitions/features/katello.rb
 - definitions/features/mongo.rb
-- definitions/features/package_manager.rb
 - definitions/features/pulp.rb
 - definitions/features/puppet_server.rb
 - definitions/features/satellite.rb
@@ -233,6 +233,7 @@ files:
 - definitions/procedures/packages/locking_status.rb
 - definitions/procedures/packages/unlock_versions.rb
 - definitions/procedures/packages/update.rb
+- definitions/procedures/packages/update_all_confirmation.rb
 - definitions/procedures/passenger_recycler.rb
 - definitions/procedures/pulp/migrate.rb
 - definitions/procedures/puppet/delete_empty_ca_cert_request_files.rb
@@ -377,8 +378,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.10
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Foreman maintenance tool belt

data/definitions/features/package_manager.rb

@@ -1,33 +0,0 @@
-class Features::PackageManager < ForemanMaintain::Feature
-  metadata do
-    label :package_manager
-  end
-
-  extend Forwardable
-  def_delegators :manager, :lock_versions, :unlock_versions,
-                 :installed?, :find_installed_package, :install, :update,
-                 :version_locking_enabled?, :install_version_locking,
-                 :versions_locked?, :clean_cache, :remove, :files_not_owned_by_package
-
-  def self.type
-    @type ||= %w[dnf yum apt].find { |manager| command_present?(manager) }
-  end
-
-  def type
-    self.class.type
-  end
-
-  def manager
-    @manager ||= case type
-                 when 'dnf'
-                   ForemanMaintain::PackageManager::Dnf.new
-                 when 'yum'
-                   ForemanMaintain::PackageManager::Yum.new
-                 else
-                   raise 'No supported package manager was found'
-                 end
-  end
-
-  # TODO: DEB  grep ^Package: /var/lib/apt/lists/deb.theforeman.org_dists_*
-  # TODO DEB apt-mark hold/unhold <package>
-end