foreman_leapp 4.2.0 → 4.3.0

data/webpack/components/PreupgradeReports/PreupgradeReportsActions.js

@@ -1,31 +0,0 @@
-import api from 'foremanReact/API';
-import { deepPropsToCamelCase } from 'foremanReact/common/helpers';
-import { translate as __ } from 'foremanReact/common/I18n';
-
-import {
-  PREUPGRADE_REPORTS_REQUEST,
-  PREUPGRADE_REPORTS_SUCCESS,
-  PREUPGRADE_REPORTS_FAILURE,
-} from '../../consts';
-
-export const getPreupgradeReportsAction = url => async dispatch => {
-  dispatch({ type: PREUPGRADE_REPORTS_REQUEST });
-
-  try {
-    const { data } = await api.get(url);
-    return dispatch({
-      type: PREUPGRADE_REPORTS_SUCCESS,
-      payload: deepPropsToCamelCase(data),
-    });
-  } catch (error) {
-    return dispatch(errorHandler(PREUPGRADE_REPORTS_FAILURE, error));
-  }
-};
-
-const errorHandler = (msg, err) => {
-  const error = {
-    errorMsg: __('Failed to fetch preupgrade reports from server.'),
-    statusText: err.response.statusText,
-  };
-  return { type: msg, payload: { error } };
-};

data/webpack/components/PreupgradeReports/PreupgradeReportsHelpers.js

@@ -1,152 +0,0 @@
-import Immutable from 'seamless-immutable';
-
-export const flattenEntries = reports =>
-  reports.reduce((memo, report) => [...memo, ...report.entries], []);
-
-const entryWithFixKind = kind => entry =>
-  entry.detail &&
-  entry.detail.remediations &&
-  entry.detail.remediations.some(remediation => remediation.type === kind);
-
-export const entryFixable = entryWithFixKind('command');
-
-export const isInhibitor = entry =>
-  entry.flags && entry.flags.some(flag => flag === 'inhibitor');
-
-export const filterByInhibitor = value => entry => {
-  const inhibitsUpgrade = isInhibitor(entry);
-
-  if (value === 'yes') {
-    return inhibitsUpgrade;
-  }
-
-  if (value === 'no') {
-    return !inhibitsUpgrade;
-  }
-
-  return true;
-};
-
-export const isEmpty = obj => Object.keys(obj).length === 0;
-
-export const anyEntriesFixable = reports =>
-  reportsToEntries(reports, Array.prototype.some, entryFixable);
-
-export const fixableEntries = reports =>
-  reportsToEntries(reports, Array.prototype.filter, entryFixable);
-
-const reportsToEntries = (reports, iterator, predicate) =>
-  iterator.call(flattenEntries(reports), predicate);
-
-export const idsForInvocationFromEntries = entries =>
-  entries.reduce(
-    (memo, entry) => {
-      if (entryFixable(entry)) {
-        memo.entryIds = [...memo.entryIds, entry.id];
-
-        if (!memo.hostIds.includes(entry.hostId)) {
-          memo.hostIds = [...memo.hostIds, entry.hostId];
-        }
-      }
-      return memo;
-    },
-    { hostIds: [], entryIds: [] }
-  );
-
-export const idsForInvocationFromReports = reports =>
-  idsForInvocationFromEntries(flattenEntries(reports));
-
-export const entriesPage = (entries, pagination) => {
-  const offset = (pagination.page - 1) * pagination.perPage;
-
-  return entries.slice(offset, offset + pagination.perPage);
-};
-
-export const filterEntries = (attribute, value, entries) => {
-  if (!value) {
-    return entries;
-  }
-
-  if (attribute === 'fix') {
-    return entries.filter(entryWithFixKind(value));
-  }
-
-  if (attribute === 'inhibitor') {
-    return entries.filter(filterByInhibitor(value));
-  }
-
-  return entries.filter(entry =>
-    entry[attribute].toLowerCase().includes(value.toLowerCase())
-  );
-};
-
-export const byText = attribute => (first, second) => {
-  const firstAttr = first[attribute].toLowerCase();
-  const secondAttr = second[attribute].toLowerCase();
-
-  if (firstAttr < secondAttr) {
-    return -1;
-  }
-
-  if (firstAttr > secondAttr) {
-    return 1;
-  }
-  return 0;
-};
-
-export const bySeverity = attribute => (first, second) => {
-  const sevList = ['info', 'low', 'medium', 'high'];
-
-  const firstAttr = first[attribute].toLowerCase();
-  const secondAttr = second[attribute].toLowerCase();
-
-  return sevList.indexOf(firstAttr) - sevList.indexOf(secondAttr);
-};
-
-export const byFix = (first, second) => {
-  const firstAttr = !!(first.detail && first.detail.remediations);
-  const secondAttr = !!(second.detail && second.detail.remediations);
-  return byBoolComparison(firstAttr, secondAttr);
-};
-
-export const byInhibitor = (first, second) =>
-  byBoolComparison(isInhibitor(first), isInhibitor(second));
-
-const byBoolComparison = (first, second) => {
-  if (first === second) {
-    return 0;
-  }
-
-  if (first) {
-    return -1;
-  }
-  return 1;
-};
-
-export const sortEntries = (entries, sort) => {
-  const entriesCopy = Immutable.asMutable(entries);
-
-  if (!sort.attribute) {
-    return entriesCopy;
-  }
-
-  let sorted;
-
-  if (['title', 'hostname'].includes(sort.attribute)) {
-    sorted = entriesCopy.sort(byText(sort.attribute));
-  }
-
-  if (sort.attribute === 'severity') {
-    sorted = entriesCopy.sort(bySeverity(sort.attribute));
-  }
-
-  if (sort.attribute === 'fix') {
-    sorted = entriesCopy.sort(byFix);
-  }
-
-  if (sort.attribute === 'inhibitor') {
-    sorted = entriesCopy.sort(byInhibitor);
-  }
-
-  return sort.order === 'asc' ? sorted : sorted.reverse();
-};

data/webpack/components/PreupgradeReports/PreupgradeReportsReducer.js

@@ -1,37 +0,0 @@
-import Immutable from 'seamless-immutable';
-
-import {
-  PREUPGRADE_REPORTS_REQUEST,
-  PREUPGRADE_REPORTS_SUCCESS,
-  PREUPGRADE_REPORTS_FAILURE,
-} from '../../consts';
-
-export const initialState = Immutable({
-  loadingPreupgradeReports: false,
-  reportsExpected: false,
-  preupgradeReports: [],
-  error: {},
-});
-
-const reducer = (state = initialState, action) => {
-  const { payload } = action;
-  switch (action.type) {
-    case PREUPGRADE_REPORTS_REQUEST:
-      return state.set('loadingPreupgradeReports', true);
-    case PREUPGRADE_REPORTS_SUCCESS:
-      return state.merge({
-        loadingPreupgradeReports: false,
-        preupgradeReports: payload.results,
-        reportsExpected: true,
-      });
-    case PREUPGRADE_REPORTS_FAILURE:
-      return state.merge({
-        error: payload.error,
-        loadingPreupgradeReports: false,
-      });
-    default:
-      return state;
-  }
-};
-
-export default reducer;

data/webpack/components/PreupgradeReports/PreupgradeReportsSelectors.js

@@ -1,18 +0,0 @@
-export const selectPreupgrade = state => state.foremanLeapp.preupgrade;
-
-export const selectPreupgradeReports = state =>
-  selectPreupgrade(state).preupgradeReports;
-
-export const selectLoadingPreupgradeReports = state =>
-  selectPreupgrade(state).loadingPreupgradeReports;
-export const selectError = state => selectPreupgrade(state).error;
-
-export const selectReportsExpected = state =>
-  selectPreupgrade(state).reportsExpected;
-
-export const selectRexState = state => state.foremanRemoteExecutionReducers;
-
-export const selectJobInvocations = state =>
-  selectRexState(state).jobInvocations;
-export const selectJobInvocationsPolling = state =>
-  selectJobInvocations(state).isPolling;

data/webpack/components/PreupgradeReports/__tests__/PreupgradeReports.fixtures.js

@@ -1,129 +0,0 @@
-export const preupgradeReports = [
-  {
-    hostId: 5,
-    entries: [
-      {
-        title: 'Fix me!',
-        severity: 'info',
-        id: 42,
-        hostname: 'host.example.com',
-        flags: [],
-      },
-      {
-        title: 'I am broken too',
-        severity: 'medium',
-        id: 43,
-        hostname: 'host.example.com',
-        flags: [],
-      },
-    ],
-  },
-  {
-    hostId: 6,
-    entries: [
-      {
-        title: 'Octocat is not happy',
-        severity: 'high',
-        id: 44,
-        hostname: 'foo.example.com',
-        flags: ['inhibitor'],
-      },
-      {
-        title: 'Not enough credits',
-        severity: 'low',
-        id: 45,
-        hostname: 'foo.example.com',
-        flags: [],
-      },
-      {
-        title: 'SELinux is turned off',
-        severity: 'medium',
-        id: 46,
-        hostname: 'foo.example.com',
-        flags: [],
-      },
-      {
-        title: 'Root password is too short',
-        severity: 'medium',
-        id: 47,
-        hostname: 'foo.example.com',
-        flags: [],
-      },
-      {
-        title: 'No chocolate chip cookies in cookie jar',
-        severity: 'high',
-        id: 49,
-        hostname: 'foo.example.com',
-        flags: [],
-      },
-    ],
-  },
-];
-
-export const preupgradeReportsWithFixableEntries = [
-  {
-    hostId: 5,
-    entries: [
-      {
-        title: 'Fixable entry',
-        severity: 'high',
-        id: 100,
-        hostId: 5,
-        hostname: 'host.example.com',
-        flags: [],
-        detail: {
-          remediations: [{ type: 'command', context: ['echo', 'fix'] }],
-        },
-      },
-      {
-        title: 'Not fixable entry',
-        severity: 'low',
-        id: 101,
-        hostId: 5,
-        hostname: 'host.example.com',
-        flags: [],
-      },
-    ],
-  },
-  {
-    hostId: 6,
-    entries: [
-      {
-        title: 'Another fixable entry',
-        severity: 'medium',
-        id: 102,
-        hostId: 6,
-        hostname: 'foo.example.com',
-        flags: [],
-        detail: {
-          remediations: [{ type: 'command', context: ['echo', 'fix2'] }],
-        },
-      },
-    ],
-  },
-];
-
-export const reportsWithRemediations = [
-  {
-    hostId: 5,
-    entries: [
-      {
-        title: 'Fix me!',
-        severity: 'info',
-        detail: { remediations: [{ type: 'hint' }] },
-      },
-      { title: 'I am broken too', severity: 'medium' },
-    ],
-  },
-  {
-    hostId: 6,
-    entries: [
-      {
-        title: 'Octocat is not happy',
-        severity: 'high',
-        detail: { remediations: [{ type: 'command' }] },
-      },
-      { title: 'Not enough credits', severity: 'low' },
-    ],
-  },
-];

data/webpack/components/PreupgradeReports/__tests__/PreupgradeReports.test.js

@@ -1,159 +0,0 @@
-import React from 'react';
-import { Provider } from 'react-redux';
-import configureMockStore from 'redux-mock-store';
-import { fireEvent, render, screen } from '@testing-library/react';
-import '@testing-library/jest-dom';
-
-import PreupgradeReports from '../PreupgradeReports';
-import {
-  preupgradeReports,
-  preupgradeReportsWithFixableEntries,
-} from './PreupgradeReports.fixtures';
-
-jest.mock('foremanReact/components/Pagination', () => {
-  const MockPagination = () => <div data-testid="pagination">Pagination</div>;
-  return MockPagination;
-});
-
-jest.mock('../../PreupgradeReportsList/components/images/i_severity-high.svg', () => 'severity-high.svg');
-jest.mock('../../PreupgradeReportsList/components/images/i_severity-med.svg', () => 'severity-med.svg');
-jest.mock('../../PreupgradeReportsList/components/images/i_severity-low.svg', () => 'severity-low.svg');
-
-const mockStore = configureMockStore([]);
-
-const csrfToken = 'xyz';
-const newJobInvocationUrl = '/job_invocations/new';
-
-const defaultProps = {
-  loading: false,
-  error: {},
-  preupgradeReports,
-  csrfToken,
-  newJobInvocationUrl,
-  reportsExpected: true,
-};
-
-const renderComponent = (props = {}) =>
-  render(
-    <Provider store={mockStore({})}>
-      <PreupgradeReports {...defaultProps} {...props} />
-    </Provider>
-  );
-
-const getFixSelectedForm = () =>
-  screen.getByRole('button', { name: 'Fix Selected' }).closest('form');
-
-describe('PreupgradeReports', () => {
-  // withLoadingState wraps content in patternfly-react LoadingState, which
-  // delays showing the spinner by 300ms and always schedules that timeout on
-  // mount — even when loading=false. Without fake timers the timeout fires
-  // after the test unmounts and React logs a setState-on-unmounted warning.
-  beforeEach(() => {
-    jest.useFakeTimers();
-  });
-
-  afterEach(() => {
-    jest.runOnlyPendingTimers();
-    jest.useRealTimers();
-  });
-
-  it('renders report entries when loaded with reports', () => {
-    renderComponent();
-
-    expect(screen.getByText('Fix me!')).toBeInTheDocument();
-    expect(screen.getByText('I am broken too')).toBeInTheDocument();
-    expect(screen.getByText('Octocat is not happy')).toBeInTheDocument();
-  });
-
-  it('renders empty state when loaded without reports', () => {
-    renderComponent({ preupgradeReports: [] });
-
-    expect(
-      screen.getByRole('heading', {
-        name: 'No Preupgrade Report Available',
-        level: 5,
-      })
-    ).toBeInTheDocument();
-    expect(
-      screen.getByText(
-        'The preupgrade report could not be generated, check the job details for the reason'
-      )
-    ).toBeInTheDocument();
-  });
-
-  it('renders loading state while data is being fetched', () => {
-    renderComponent({
-      loading: true,
-      preupgradeReports: [],
-      reportsExpected: false,
-    });
-
-    // LoadingState renders nothing until its 300ms timeout elapses.
-    jest.advanceTimersByTime(300);
-
-    expect(screen.getByText('Loading')).toBeInTheDocument();
-    expect(
-      screen.queryByRole('heading', {
-        name: 'No Preupgrade Report Available',
-      })
-    ).not.toBeInTheDocument();
-  });
-
-  it('renders error empty state when data retrieval fails', () => {
-    renderComponent({
-      error: {
-        statusText: 'Internal server error',
-        errorMsg: 'Unexpected error',
-      },
-      preupgradeReports: [],
-      reportsExpected: false,
-    });
-
-    expect(
-      screen.getByRole('heading', {
-        name: 'Could not retrieve data: Internal server error - Unexpected error',
-        level: 5,
-      })
-    ).toBeInTheDocument();
-  });
-
-  it('disables Fix Selected when no fixable entries are selected', () => {
-    renderComponent({ preupgradeReports: preupgradeReportsWithFixableEntries });
-
-    expect(screen.getByRole('button', { name: 'Fix Selected' })).toBeDisabled();
-  });
-
-  it('enables Fix Selected and passes selected entry ids when a fixable entry is selected', () => {
-    renderComponent({ preupgradeReports: preupgradeReportsWithFixableEntries });
-
-    const [, fixableEntryCheckbox] = screen.getAllByRole('checkbox');
-
-    fireEvent.click(fixableEntryCheckbox);
-
-    expect(screen.getByRole('button', { name: 'Fix Selected' })).toBeEnabled();
-    expect(
-      getFixSelectedForm().querySelector('input[name="inputs[remediation_ids]"]')
-    ).toHaveValue('100');
-  });
-
-  it('selects all fixable entries when header checkbox is clicked', () => {
-    renderComponent({ preupgradeReports: preupgradeReportsWithFixableEntries });
-
-    const [selectAllCheckbox] = screen.getAllByRole('checkbox');
-
-    fireEvent.click(selectAllCheckbox);
-
-    expect(screen.getByRole('button', { name: 'Fix Selected' })).toBeEnabled();
-
-    const form = getFixSelectedForm();
-
-    expect(
-      form.querySelector('input[name="inputs[remediation_ids]"]')
-    ).toHaveValue('100,102');
-    expect(
-      [...form.querySelectorAll('input[name="host_ids[]"]')].map(
-        input => input.value
-      )
-    ).toEqual(['5', '6']);
-  });
-});

data/webpack/components/PreupgradeReports/__tests__/PreupgradeReportsHelpers.test.js

@@ -1,78 +0,0 @@
-import { testSelectorsSnapshotWithFixtures } from '@theforeman/test';
-
-import {
-  preupgradeReports,
-  reportsWithRemediations,
-} from './PreupgradeReports.fixtures';
-
-import {
-  flattenEntries,
-  isEmpty,
-  entryFixable,
-  anyEntriesFixable,
-  idsForInvocationFromReports,
-  entriesPage,
-  filterEntries,
-  fixableEntries,
-  sortEntries,
-} from '../PreupgradeReportsHelpers';
-
-const fixtures = {
-  'should return flattened entrues': () => flattenEntries(preupgradeReports),
-  'should detect empty object': () => isEmpty({}),
-  'should detect non-empty object': () => isEmpty({ foo: 'bar' }),
-  'should detect entry is fixable': () =>
-    entryFixable({ detail: { remediations: [{ type: 'command' }] } }),
-  'should detect entry is not fixable when not having a command': () =>
-    entryFixable({ detail: { remediations: [{ type: 'hint' }] } }),
-  'should detect entry is not fixable when not having remediations': () =>
-    !!entryFixable({ detail: {} }),
-  'should detect no entry is fixable': () =>
-    anyEntriesFixable(preupgradeReports),
-  'should detect a fixable entry in reports': () =>
-    anyEntriesFixable(reportsWithRemediations),
-  'should collect ids for job invocation from reports': () =>
-    idsForInvocationFromReports(preupgradeReports),
-  'should return entries page': () =>
-    entriesPage(flattenEntries(preupgradeReports), { page: 2, perPage: 3 }),
-  'should filter entries by title': () =>
-    filterEntries('title', 'broken', flattenEntries(preupgradeReports)),
-  'should filter entries by severity': () =>
-    filterEntries('severity', 'medium', flattenEntries(preupgradeReports)),
-  'should filter entries by host': () =>
-    filterEntries('hostname', 'foo', flattenEntries(preupgradeReports)),
-  'should filter entries by remediations': () =>
-    filterEntries('fix', 'command', flattenEntries(reportsWithRemediations)),
-  'should filter entries by inhibitor': () =>
-    filterEntries('inhibitor', 'yes', flattenEntries(preupgradeReports)),
-  'should return fixable entries': () =>
-    fixableEntries(reportsWithRemediations),
-  'should sort entries by title in ascending order': () =>
-    sortEntries(flattenEntries(preupgradeReports), {
-      attribute: 'title',
-      order: 'asc',
-    }),
-  'should sort entries by title in descending order': () =>
-    sortEntries(flattenEntries(preupgradeReports), {
-      attribute: 'title',
-      order: 'desc',
-    }),
-  'should sort entries by hostname': () =>
-    sortEntries(flattenEntries(preupgradeReports), {
-      attribute: 'hostname',
-      order: 'asc',
-    }),
-  'should sort entries by severity': () =>
-    sortEntries(flattenEntries(preupgradeReports), {
-      attribute: 'severity',
-      order: 'asc',
-    }),
-  'should sort entries by remediations': () =>
-    sortEntries(flattenEntries(reportsWithRemediations), {
-      attribute: 'fix',
-      order: 'asc',
-    }),
-};
-
-describe('PreupgradeReportsHelpers', () =>
-  testSelectorsSnapshotWithFixtures(fixtures));

data/webpack/components/PreupgradeReports/__tests__/PreupgradeReportsReducer.test.js

@@ -1,44 +0,0 @@
-import { testReducerSnapshotWithFixtures } from '@theforeman/test';
-
-import reducer, { initialState } from '../PreupgradeReportsReducer';
-
-import {
-  PREUPGRADE_REPORTS_REQUEST,
-  PREUPGRADE_REPORTS_SUCCESS,
-  PREUPGRADE_REPORTS_FAILURE,
-} from '../../../consts';
-
-import { preupgradeReports } from './PreupgradeReports.fixtures';
-
-const fixtures = {
-  'should return initial state': {
-    state: initialState,
-    action: {
-      type: undefined,
-      payload: [],
-    },
-  },
-  'should start loading reports on request': {
-    state: initialState,
-    action: {
-      type: PREUPGRADE_REPORTS_REQUEST,
-    },
-  },
-  'should stop loading on reports success': {
-    state: initialState.set('loadingPreupgradeReports', true),
-    action: {
-      type: PREUPGRADE_REPORTS_SUCCESS,
-      payload: { results: preupgradeReports },
-    },
-  },
-  'should show error on request failure': {
-    state: initialState.set('loadingPreupgradeReports', true),
-    action: {
-      type: PREUPGRADE_REPORTS_FAILURE,
-      payload: { error: { errorMsg: 'This is error', statusText: 'Not good' } },
-    },
-  },
-};
-
-describe('PreupgradeReportsReducer', () =>
-  testReducerSnapshotWithFixtures(reducer, fixtures));

data/webpack/components/PreupgradeReports/__tests__/PreupgradeReportsSelectors.test.js

@@ -1,28 +0,0 @@
-import { testSelectorsSnapshotWithFixtures } from '@theforeman/test';
-
-import { preupgradeReports } from './PreupgradeReports.fixtures';
-
-import {
-  selectPreupgradeReports,
-  selectLoadingPreupgradeReports,
-  selectError,
-} from '../PreupgradeReportsSelectors';
-
-const state = {
-  foremanLeapp: {
-    preupgrade: {
-      preupgradeReports,
-      loadingPreupgradeReports: false,
-      error: { errorMsg: 'Error', statusText: 'Status text' },
-    },
-  },
-};
-
-const fixtures = {
-  'should return preupgrade reports': () => selectPreupgradeReports(state),
-  'should return loading state': () => selectLoadingPreupgradeReports(state),
-  'should return error': () => selectError(state),
-};
-
-describe('PreupgradeReportsSelectors', () =>
-  testSelectorsSnapshotWithFixtures(fixtures));