foreman_leapp 0.1.4 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 59cdca70be055403d924f568f8ccdd333123fbbdd6d6665bdaa7ca59706b7410
-  data.tar.gz: f1e4859e8b1c84faf8807d58656205ee60d2a8139ad304ec220810c64976f8c7
+  metadata.gz: 0dfdafe8cfd66270ad9e3fa8b26b14318eeb3c335c63aaad854c5fb3514c7fdf
+  data.tar.gz: 8c2066dbfeeb373aa8989ba401fb2b39c25e0896373c2d6b4ddcba17ddf6fe7e
 SHA512:
-  metadata.gz: 89d6b5ebb3171d2a286f91995fd719652bcd486d3038b3e349ea8a147925464d41d1cc47e52d0b4e719a57c1aa88ca458eb36745870d7e1b3796a8c33779c42a
-  data.tar.gz: ffe034b5513860e72b8c4672b5a444c886334f21a7f7d232b4eb82e9b92d8defd8fca5150fc257d69ce7263c38f12941d2558ac04809aa023cdba7109a240834
+  metadata.gz: 77551a97d10c13a751b4f3d03954e6f359e53e980f933c402c5045bd173c35514b8dbd0555425fb3cef85dd6c6c542879167d4e4be789c6c342dfc92fba1bf25
+  data.tar.gz: 944be997316144646e4c1f993679467779a65fda006f07606acae2650e87dadc2cbf9c9fa1c68aa625a5f0451dbe26b72b949ec3cdae04436f000690b445f2cb

data/config/routes.rb

@@ -4,7 +4,8 @@ Rails.application.routes.draw do
   resources :preupgrade_reports, :only => %i[index]
 
   namespace :api, defaults: { format: 'json' } do
-    scope '(:apiv)', module: :v2, defaults: { apiv: 'v2' }, apiv: /v2/, constraints: ApiConstraints.new( version: 2, default: true) do
+    scope '(:apiv)', module: :v2, defaults: { apiv: 'v2' }, apiv: /v2/,
+          constraints: ApiConstraints.new( version: 2, default: true) do
       resources :preupgrade_reports, only: %i[index show]
       get 'job_invocations/:id/preupgrade_reports', to: 'preupgrade_reports#job_invocation'
     end

data/db/seeds.d/10_leapp_preupgrade.rb

@@ -4,6 +4,14 @@ organizations = Organization.unscoped.all
 locations = Location.unscoped.all
 User.as_anonymous_admin do
   RemoteExecutionFeature.without_auditing do
+    if Rails.env.test? || Foreman.in_rake?
+      # If this file tries to import a template with a REX feature in a SeedsTest,
+      # it will fail - the REX feature isn't registered on SeedsTest because
+      # DatabaseCleaner truncates the db before every test.
+      # During db:seed, we also want to know the feature is registered before
+      # seeding the template
+      ForemanLeapp::Engine.register_rex_features
+    end
     JobTemplate.without_auditing do
       Dir[File.join("#{ForemanLeapp::Engine.root}/app/views/foreman_leapp/"\
                     'job_templates/**/*.erb')].each do |template|

data/lib/foreman_leapp/engine.rb

@@ -36,6 +36,11 @@ module ForemanLeapp
                              ::Helpers::JobHelper.correct_feature?(subject, 'leapp_remediation_plan')
                          }
         end
+
+        security_block :foreman_leapp do
+          permission :view_job_invocations, { :preupgrade_reports => %i[index show job_invocation],
+                                              'api/v2/preupgrade_reports' => %i[index show job_invocation] }
+        end
       end
     end
 
@@ -48,26 +53,7 @@ module ForemanLeapp
         Rails.logger.warn "ForemanLeapp: skipping engine hook (#{e})"
       end
 
-      RemoteExecutionFeature.register(
-        :leapp_preupgrade,
-        N_('Preupgrade check with Leapp'),
-        description: N_('Upgradeability check for RHEL 7 host'),
-        host_action_button: false
-      )
-
-      RemoteExecutionFeature.register(
-        :leapp_upgrade,
-        N_('Upgrade with Leapp'),
-        description: N_('Run Leapp upgrade job for RHEL 7 host'),
-        host_action_button: false
-      )
-
-      RemoteExecutionFeature.register(
-        :leapp_remediation_plan,
-        N_('Remediation plan'),
-        description: N_('Run Remediation plan with Leapp'),
-        host_action_button: false
-      )
+      ForemanLeapp::Engine.register_rex_features
     end
 
     rake_tasks do
@@ -97,5 +83,28 @@ module ForemanLeapp
     initializer 'foreman_leapp.apipie' do
       Apipie.configuration.checksum_path += ['/api/']
     end
+
+    def self.register_rex_features
+      RemoteExecutionFeature.register(
+        :leapp_preupgrade,
+        N_('Preupgrade check with Leapp'),
+        description: N_('Upgradeability check for RHEL 7 host'),
+        host_action_button: false
+      )
+
+      RemoteExecutionFeature.register(
+        :leapp_upgrade,
+        N_('Upgrade with Leapp'),
+        description: N_('Run Leapp upgrade job for RHEL 7 host'),
+        host_action_button: false
+      )
+
+      RemoteExecutionFeature.register(
+        :leapp_remediation_plan,
+        N_('Remediation plan'),
+        description: N_('Run Remediation plan with Leapp'),
+        host_action_button: false
+      )
+    end
   end
 end

data/lib/foreman_leapp/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module ForemanLeapp
-  VERSION = '0.1.4'
+  VERSION = '0.1.8'
 end

data/package.json

@@ -25,15 +25,15 @@
   },
   "homepage": "https://github.com/oamg/foreman_leapp",
   "peerDependencies": {
-    "@theforeman/vendor": ">= 4.2.1"
+    "@theforeman/vendor": ">= 8.3.3"
   },
   "devDependencies": {
     "@babel/core": "^7.7.0",
-    "@theforeman/builder": "^4.2.1",
-    "@theforeman/eslint-plugin-foreman": "4.2.1",
-    "@theforeman/stories": "^4.2.1",
-    "@theforeman/test": "^4.2.1",
-    "@theforeman/vendor-dev": "^4.2.1",
+    "@theforeman/builder": "^8.3.3",
+    "@theforeman/eslint-plugin-foreman": "8.3.3",
+    "@theforeman/stories": "^8.3.3",
+    "@theforeman/test": "^8.3.3",
+    "@theforeman/vendor-dev": "^8.3.3",
     "babel-eslint": "^10.0.0",
     "eslint": "^6.8.0",
     "jest-svg-transformer": "^1.0.0",

data/webpack/components/PreupgradeReports/PreupgradeReports.js

@@ -110,8 +110,8 @@ const PreupgradeReports = ({
   );
 };
 
-const withLoadingState = Component => props => {
-  const { error, loading, preupgradeReports, reportsExpected } = props;
+const withLoadingState = Component => componentProps => {
+  const { error, loading, preupgradeReports, reportsExpected } = componentProps;
 
   if (!isEmpty(error)) {
     return (
@@ -126,7 +126,7 @@ const withLoadingState = Component => props => {
   return (
     <LoadingState loading={loading}>
       {preupgradeReports.length > 0 ? (
-        <Component {...props} />
+        <Component {...componentProps} />
       ) : (
         <NoReports reportsExpected={reportsExpected} />
       )}

data/webpack/components/PreupgradeReports/components/UpgradeAllButton.js

@@ -3,22 +3,21 @@ import PropTypes from 'prop-types';
 import { Button } from 'patternfly-react';
 import { translate as __ } from 'foremanReact/common/I18n';
 
-import { idsForInvocationFromReports } from '../PreupgradeReportsHelpers';
-
-const UpgradeAllButton = ({ preupgradeReports, postUrl, csrfToken }) => {
-  const { hostIds } = idsForInvocationFromReports(preupgradeReports);
-
-  return (
-    <form action={postUrl} method="post">
-      <Button type="submit">{__('Run Upgrade')}</Button>
-      <input type="hidden" name="authenticity_token" value={csrfToken} />
-      <input type="hidden" name="feature" value="leapp_upgrade" />
-      {hostIds.map(hostId => (
-        <input type="hidden" name="host_ids[]" key={hostId} value={hostId} />
-      ))}
-    </form>
-  );
-};
+const UpgradeAllButton = ({ preupgradeReports, postUrl, csrfToken }) => (
+  <form action={postUrl} method="post">
+    <Button type="submit">{__('Run Upgrade')}</Button>
+    <input type="hidden" name="authenticity_token" value={csrfToken} />
+    <input type="hidden" name="feature" value="leapp_upgrade" />
+    {preupgradeReports.map(report => (
+      <input
+        type="hidden"
+        name="host_ids[]"
+        key={report.hostId}
+        value={report.hostId}
+      />
+    ))}
+  </form>
+);
 
 UpgradeAllButton.propTypes = {
   preupgradeReports: PropTypes.array.isRequired,

data/webpack/components/PreupgradeReports/components/__snapshots__/UpgradeAllButton.test.js.snap

@@ -25,5 +25,17 @@ exports[`UpgradeAllButton should render 1`] = `
     type="hidden"
     value="leapp_upgrade"
   />
+  <input
+    key="5"
+    name="host_ids[]"
+    type="hidden"
+    value={5}
+  />
+  <input
+    key="6"
+    name="host_ids[]"
+    type="hidden"
+    value={6}
+  />
 </form>
 `;

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_leapp
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.8
 platform: ruby
 authors:
 - Foreman Leapp team
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-08-24 00:00:00.000000000 Z
+date: 2021-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foreman_remote_execution
@@ -17,9 +17,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -27,21 +24,18 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.2'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: foreman_ansible
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '5.0'
 - !ruby/object:Gem::Dependency
@@ -58,20 +52,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '6.2'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.80'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.80'
 description: A Foreman plugin to support inplace RHEL 7 -> RHEL 8 upgrades with Leapp
   utility.
 email:
@@ -203,7 +183,7 @@ homepage: https://github.com/oamg/foreman_leapp
 licenses:
 - GPL-3.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -218,17 +198,17 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: A Foreman plugin for Leapp utility.
 test_files:
-- test/factories/foreman_leapp_factories.rb
-- test/test_plugin_helper.rb
-- test/unit/helpers/job_helper_test.rb
-- test/unit/actions/preupgrade_job_test.rb
-- test/models/preupgrade_report_entry_test.rb
-- test/models/preupgrade_report_test.rb
 - test/functional/api/v2/preupgrade_reports_controller_test.rb
 - test/functional/preupgrade_reports_controller_test.rb
+- test/models/preupgrade_report_test.rb
+- test/models/preupgrade_report_entry_test.rb
+- test/unit/helpers/job_helper_test.rb
+- test/unit/actions/preupgrade_job_test.rb
+- test/test_plugin_helper.rb
 - test/helpers/template_helper_test.rb
+- test/factories/foreman_leapp_factories.rb