foreman_kubevirt 0.4.0 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dcdce0e160ee8cbe528af3cd3206f1674c0852a136b9f92c37c6d08a15484085
-  data.tar.gz: 72195120514dac9bc18a56f605fce51b182a997937852dd9a5a9287e783baa9e
+  metadata.gz: 39fc9c907b2357c24a43be724a2e00b2105452abd42911c836b1cd5dc0f6b085
+  data.tar.gz: 00b5f9b3bcf1c36c540e6a1261c1c68fb2f9f337fc0ef6b669ef5da182f22d7d
 SHA512:
-  metadata.gz: 9235eb8d62cf2c6a48fcc577697750239ceabf5a69c9d5653ab6cb10fa896c6e5e42e483d901007107896cd8b4586e6241854c693bc7e7677dabdd053489e6fd
-  data.tar.gz: 922a37a5fa0bc31b4e6b88ac896f4f12ca4b5adceefed54edd83a63af5e777610abfc4509d6457acb32ce24dae282a66a9d6c6394af70bc3b857d9869f1a4f9a
+  metadata.gz: aedfe24b1155d7140ca79bb056292fa28abfdc33c64bb401fa76c482ba61950b81461832d21a0fda69b94e805d508079b1959661c01e5fc96770a503db67d62a
+  data.tar.gz: f3879d38d591219040d0bf4bd4f1b645548ef0b7c471ae3da62705a1a5a5d4b44619f5e2d7b6c3c24f5d9e9c0fb6c1f20b77a0e65b8649205cf95b8469c96126

data/app/assets/javascripts/foreman_kubevirt/locale/ca/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "Robert Antoni Buj i Gelonch <rbuj@fedoraproject.org>, 2020",

data/app/assets/javascripts/foreman_kubevirt/locale/cs_CZ/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "mhulan <mhulan@redhat.com>, 2020",

data/app/assets/javascripts/foreman_kubevirt/locale/de/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "pdolinic, 2021",

data/app/assets/javascripts/foreman_kubevirt/locale/en/foreman_kubevirt.js

@@ -5,7 +5,7 @@
       "": {
         "Project-Id-Version": "foreman_kubevirt 1.0.0",
         "Report-Msgid-Bugs-To": "",
-        "PO-Revision-Date": "2025-02-10 20:07+0100",
+        "PO-Revision-Date": "2025-10-07 14:20+0200",
         "Last-Translator": "FULL NAME <EMAIL@ADDRESS>",
         "Language-Team": "LANGUAGE <LL@li.org>",
         "Language": "",

data/app/assets/javascripts/foreman_kubevirt/locale/en_GB/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "Andi Chandler <andi@gowling.com>, 2023",

data/app/assets/javascripts/foreman_kubevirt/locale/es/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "Amit Upadhye <aupadhye@redhat.com>, 2022",

data/app/assets/javascripts/foreman_kubevirt/locale/fr/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarden.nl>, 2024",

data/app/assets/javascripts/foreman_kubevirt/locale/gl/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "Carmela Rubiños <carmela.rubinos@gmail.com>, 2020",

data/app/assets/javascripts/foreman_kubevirt/locale/it/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "Giuseppe Pignataro (Fastbyte01) <rogepix@gmail.com>, 2020",

data/app/assets/javascripts/foreman_kubevirt/locale/ja/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarden.nl>, 2023",

data/app/assets/javascripts/foreman_kubevirt/locale/ka/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "Temuri Doghonadze <temuri.doghonadze@gmail.com>, 2023",

data/app/assets/javascripts/foreman_kubevirt/locale/ko/foreman_kubevirt.js

@@ -3,10 +3,10 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
-        "Last-Translator": "Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarden.nl>, 2024",
+        "Last-Translator": "Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarden.nl>, 2025",
         "Language-Team": "Korean (https://app.transifex.com/foreman/teams/114/ko/)",
         "MIME-Version": "1.0",
         "Content-Type": "text/plain; charset=UTF-8",
@@ -150,7 +150,7 @@
         "볼륨 크기%s이/가 잘못되었습니다"
       ],
       "X509 Certification Authorities": [
-        "X509 인증 기관 "
+        "X509 인증 기관"
       ],
       "cni_provider or network are missing": [
         "cni_provider 또는 네트워크가 없습니다"

data/app/assets/javascripts/foreman_kubevirt/locale/nl_NL/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarden.nl>, 2023",

data/app/assets/javascripts/foreman_kubevirt/locale/pl/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "Michał Foryt <michal.foryt@gmail.com>, 2020",

data/app/assets/javascripts/foreman_kubevirt/locale/pt_BR/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "Amit Upadhye <aupadhye@redhat.com>, 2022",

data/app/assets/javascripts/foreman_kubevirt/locale/ru/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "Vladimir Pavlov <v.pavlov@i-teco.ru>, 2020",

data/app/assets/javascripts/foreman_kubevirt/locale/sv_SE/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "johnny.westerlund <johnny.westerlund@gmail.com>, 2020",

data/app/assets/javascripts/foreman_kubevirt/locale/zh_CN/foreman_kubevirt.js

@@ -3,10 +3,10 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
-        "Last-Translator": "Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarden.nl>, 2023",
+        "Last-Translator": "Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarden.nl>, 2025",
         "Language-Team": "Chinese (China) (https://app.transifex.com/foreman/teams/114/zh_CN/)",
         "MIME-Version": "1.0",
         "Content-Type": "text/plain; charset=UTF-8",
@@ -150,7 +150,7 @@
         "卷大小 %s 无效"
       ],
       "X509 Certification Authorities": [
-        "X509 证书授权"
+        "X509 认证颁发机构"
       ],
       "cni_provider or network are missing": [
         "cni_provider 或网络丢失"

data/app/assets/javascripts/foreman_kubevirt/locale/zh_TW/foreman_kubevirt.js

@@ -3,7 +3,7 @@
   "locale_data": {
     "foreman_kubevirt": {
       "": {
-        "Project-Id-Version": "foreman_kubevirt 0.3.0",
+        "Project-Id-Version": "foreman_kubevirt 0.4.1",
         "Report-Msgid-Bugs-To": "",
         "PO-Revision-Date": "2020-05-26 07:39+0000",
         "Last-Translator": "Bryan Kearney <bryan.kearney@gmail.com>, 2020",

data/app/models/foreman_kubevirt/kubevirt.rb

@@ -73,18 +73,32 @@ module ForemanKubevirt
       end
     end
 
+    def connection_valid?
+      return false if hostname.blank? || token.blank? || namespace.blank? || api_port.blank?
+      client&.valid? && client&.virt_supported?
+    rescue StandardError
+      false
+    end
+
     def connection_properties_valid?
       errors[:hostname].empty? && errors[:token].empty? && errors[:namespace].empty? && errors[:api_port].empty?
     end
 
     def networks
-      client.networkattachmentdefs.all
-    rescue StandardError => e
-      logger.warn("Failed to retrieve network attachments definition from KubeVirt,
-        make sure KubeVirt has CNI provider and NetworkAttachmentDefinition CRD deployed: #{e.message}")
+      client.networkattachmentdefs.all.map do |network|
+        namespaced_name = "#{network.namespace}/#{network.name}"
+        OpenStruct.new(id: namespaced_name, name: namespaced_name)
+      end
+    rescue Fog::Kubevirt::Errors::ClientError => e
+      Foreman::Logging.exception("Failed to retrieve network attachments definition from KubeVirt,
+        make sure KubeVirt has CNI provider and NetworkAttachmentDefinition CRD deployed", e)
       []
     end
 
+    def editable_network_interfaces?
+      true
+    end
+
     def find_vm_by_uuid(uuid)
       super
     rescue Fog::Kubevirt::Errors::ClientError => e
@@ -94,10 +108,16 @@ module ForemanKubevirt
 
     def volumes
       client.volumes.all
+    rescue Fog::Kubevirt::Errors::ClientError => e
+      Foreman::Logging.exception("Failed retrieving KubeVirt volumes", e)
+      []
     end
 
     def storage_classes
       client.storageclasses.all
+    rescue Fog::Kubevirt::Errors::ClientError => e
+      Foreman::Logging.exception("Failed retrieving KubeVirt storage classes", e)
+      []
     end
 
     def storage_classes_for_select
@@ -458,9 +478,12 @@ module ForemanKubevirt
     end
 
     def create_network_element(iface)
-      nic = { bridge: {}, name: iface[:network] }
+      # K8s objects have string naming.
+      # Use ActiveSupport::Inflector#parameterize to create a sanitized NIC name
+      nic_name = iface[:network].parameterize
+      nic = { bridge: {}, name: nic_name }
       cni = iface[:cni_provider].to_sym
-      net = { :name => iface[:network], cni => { :networkName => iface[:network] } }
+      net = { :name => nic_name, cni => { :networkName => iface[:network] } }
       [nic, net]
     end
 

data/app/views/compute_resources/form/_kubevirt.html.erb

@@ -4,14 +4,13 @@
 <%= password_f f, :token, :label => _("Token"), :required => true,
               :keep_value => true, :unset => unset_password?,
               :help_block => _("e.g. eyJhbGciOiJSUzI1NiIsImtpZCI6IiJ9..."),
-              :help_inline => documentation_button('/foreman_kubevirt/0.x/index.html#4.1SettingComputeResourceTokenandX509CAvalues',
-              :root_url => 'https://theforeman.org/plugins'),
+              :help_inline => documentation_button('#4.1SettingComputeResourceTokenandX509CAvalues', type: 'plugin_manual', name: 'foreman_kubevirt', version: '0.x'),
               :id => "compute_resource_password"
 %>
 
 <%= textarea_f f, :ca_cert, :label => _("X509 Certification Authorities"),
   :placeholder => _("Optionally provide a CA, or a correctly ordered CA chain or a path to a file. If left blank - insecure.") %>
 
- <div class="col-md-offset-2">
-   <%= test_connection_button_f(f, true) %>
- </div>
+<div class="col-md-offset-2">
+  <%= test_connection_button_f(f, f.object.connection_valid?) %>
+</div>

data/app/views/compute_resources_vms/form/kubevirt/_network.html.erb

@@ -9,10 +9,11 @@
 
 <div id='networks' class='<%= 'hide' if pod %>'>
 <%= select_f f, :network,
-                compute_resource.networks,
+                (compute_resource.networks + [OpenStruct.new(name: f.object.network, id: f.object.network)]).compact.uniq,
                 :id,
                 :name,
                 {},
+                :data => { tags: true },
                 :disabled => !new_vm || pod,
                 :class => "col-md-3 kubevirt-network",
                 :label => _('Network'),

data/lib/foreman_kubevirt/version.rb

@@ -1,3 +1,3 @@
 module ForemanKubevirt
-  VERSION = '0.4.0'.freeze
+  VERSION = '0.4.2'.freeze
 end

data/locale/ca/foreman_kubevirt.po

@@ -8,7 +8,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Robert Antoni Buj i Gelonch <rbuj@fedoraproject.org>, 2020\n"

data/locale/cs_CZ/foreman_kubevirt.po

@@ -10,7 +10,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: mhulan <mhulan@redhat.com>, 2020\n"

data/locale/de/foreman_kubevirt.po

@@ -18,7 +18,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: pdolinic, 2021\n"

data/locale/en/foreman_kubevirt.po

@@ -8,7 +8,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: foreman_kubevirt 1.0.0\n"
 "Report-Msgid-Bugs-To: \n"
-"PO-Revision-Date: 2025-02-10 20:07+0100\n"
+"PO-Revision-Date: 2025-10-07 14:20+0200\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
 "Language: \n"

data/locale/en_GB/foreman_kubevirt.po

@@ -9,7 +9,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Andi Chandler <andi@gowling.com>, 2023\n"

data/locale/es/foreman_kubevirt.po

@@ -15,7 +15,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Amit Upadhye <aupadhye@redhat.com>, 2022\n"

data/locale/foreman_kubevirt.pot

@@ -8,8 +8,8 @@ msgid ""
 msgstr ""
 "Project-Id-Version: foreman_kubevirt 1.0.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2025-02-10 20:07+0100\n"
-"PO-Revision-Date: 2025-02-10 20:07+0100\n"
+"POT-Creation-Date: 2025-10-07 14:20+0200\n"
+"PO-Revision-Date: 2025-10-07 14:20+0200\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <LL@li.org>\n"
 "Language: \n"

data/locale/fr/foreman_kubevirt.po

@@ -13,7 +13,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarde"

data/locale/gl/foreman_kubevirt.po

@@ -8,7 +8,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Carmela Rubiños <carmela.rubinos@gmail.com>, 2020\n"

data/locale/it/foreman_kubevirt.po

@@ -10,7 +10,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Giuseppe Pignataro (Fastbyte01) <rogepix@gmail.com>, 2020\n"

data/locale/ja/foreman_kubevirt.po

@@ -12,7 +12,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarde"

data/locale/ka/foreman_kubevirt.po

@@ -8,7 +8,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Temuri Doghonadze <temuri.doghonadze@gmail.com>, 2023\n"

data/locale/ko/foreman_kubevirt.po

@@ -6,15 +6,15 @@
 # Translators:
 # 0868a4d1af5275b3f70b0a6dac4c99a4, 2020
 # Bryan Kearney <bryan.kearney@gmail.com>, 2020
-# Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarden.nl>, 2024
+# Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarden.nl>, 2025
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarde"
-"n.nl>, 2024\n"
+"n.nl>, 2025\n"
 "Language-Team: Korean (https://app.transifex.com/foreman/teams/114/ko/)\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
@@ -157,7 +157,7 @@ msgid "Volume size %s is not valid"
 msgstr "볼륨 크기%s이/가 잘못되었습니다"
 
 msgid "X509 Certification Authorities"
-msgstr "X509 인증 기관 "
+msgstr "X509 인증 기관"
 
 msgid "cni_provider or network are missing"
 msgstr "cni_provider 또는 네트워크가 없습니다"

data/locale/nl_NL/foreman_kubevirt.po

@@ -12,7 +12,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarde"

data/locale/pl/foreman_kubevirt.po

@@ -9,7 +9,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Michał Foryt <michal.foryt@gmail.com>, 2020\n"

data/locale/pt_BR/foreman_kubevirt.po

@@ -12,7 +12,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Amit Upadhye <aupadhye@redhat.com>, 2022\n"

data/locale/ru/foreman_kubevirt.po

@@ -13,7 +13,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Vladimir Pavlov <v.pavlov@i-teco.ru>, 2020\n"

data/locale/sv_SE/foreman_kubevirt.po

@@ -10,7 +10,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: johnny.westerlund <johnny.westerlund@gmail.com>, 2020\n"

data/locale/zh_CN/foreman_kubevirt.po

@@ -8,15 +8,15 @@
 # Bryan Kearney <bryan.kearney@gmail.com>, 2020
 # tim123, 2020
 # Amit Upadhye <aupadhye@redhat.com>, 2022
-# Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarden.nl>, 2023
+# Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarden.nl>, 2025
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarde"
-"n.nl>, 2023\n"
+"n.nl>, 2025\n"
 "Language-Team: Chinese (China) (https://app.transifex.com/foreman/teams/114/zh"
 "_CN/)\n"
 "MIME-Version: 1.0\n"
@@ -162,7 +162,7 @@ msgid "Volume size %s is not valid"
 msgstr "卷大小 %s 无效"
 
 msgid "X509 Certification Authorities"
-msgstr "X509 证书授权"
+msgstr "X509 认证颁发机构"
 
 msgid "cni_provider or network are missing"
 msgstr "cni_provider 或网络丢失"

data/locale/zh_TW/foreman_kubevirt.po

@@ -9,7 +9,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_kubevirt 0.3.0\n"
+"Project-Id-Version: foreman_kubevirt 0.4.1\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2020-05-26 07:39+0000\n"
 "Last-Translator: Bryan Kearney <bryan.kearney@gmail.com>, 2020\n"

data/test/models/compute_resources/kubevirt_test.rb

@@ -21,25 +21,82 @@ class ForemanKubevirtTest < ActiveSupport::TestCase
     assert_equal expected_res, result
   end
 
+  describe "create_vm" do
+    test "uses sanitized NIC names" do
+      vms = stub
+      pvcs = stub
+      pvcs.stubs(:create)
+      pvcs.stubs(:delete)
+      servers = stub
+      servers.stubs(:get)
+      client = stub
+      client.stubs(:vms).returns(vms)
+      client.stubs(:pvcs).returns(pvcs)
+      client.stubs(:servers).returns(servers)
+      record = new_kubevirt_vcr
+      record.stubs(:client).returns(client)
+
+      expected_networks = [{ :name => "default-network", :multus => { :networkName => "default/network" } }]
+      expected_interfaces = [{ :bridge => {}, :name => "default-network" }]
+
+      vms.expects(:create).with(vm_name: anything, cpus: anything, memory_size: anything, memory_unit: anything, volumes: anything, cloudinit: anything, networks: expected_networks, interfaces: expected_interfaces)
+
+      record.create_vm({ :name => "test", :volumes_attributes => { 0 => { :capacity => "5" } }, :interfaces_attributes => { "0" => { "cni_provider" => "multus", "network" => "default/network" } } })
+    end
+  end
+
+  describe "create_network_element" do
+    test "sanitizes NIC names" do
+      record = new_kubevirt_vcr
+      iface = { network: "default/network", cni_provider: "multus" }
+      nic, net = record.send(:create_network_element, iface)
+      assert_equal "default-network", nic[:name]
+      assert_equal "default-network", net[:name]
+    end
+  end
+
   describe "networks" do
     test "returns list of networksattachmentdefs" do
       Fog.mock!
       compute_resource = FactoryBot.build(:compute_resource_kubevirt)
       res = compute_resource.networks
       assert_equal 1, res.count
-      assert_equal '0e35b868-2464-11e9-93b4-525400c5a686', res.first.uid
+      assert_equal 'default/ovs-foreman', res.first.id
+      assert_equal 'default/ovs-foreman', res.first.name
     end
 
     test "in case of exception, returns an empty array" do
       compute_resource = FactoryBot.build(:compute_resource_kubevirt)
       client = stub
       compute_resource.stubs(:client).returns(client)
-      client.stubs(:networkattachmentdefs).raises("exception")
+      client.stubs(:networkattachmentdefs).raises(Fog::Kubevirt::Errors::ClientError.new)
       res = compute_resource.networks
       assert_equal 0, res.count
     end
   end
 
+  describe "volumes" do
+    test "returns empty array when error is raised" do
+      Fog.mock!
+      compute_resource = new_kubevirt_vcr
+      client = stub
+      compute_resource.stubs(:client).returns(client)
+      client.stubs(:volumes).raises(Fog::Kubevirt::Errors::ClientError.new)
+      assert_empty compute_resource.volumes
+    end
+  end
+
+  describe "storage_classes" do
+    test "returns empty array when error is raised" do
+      Fog.mock!
+      compute_resource = new_kubevirt_vcr
+      client = stub
+      compute_resource.stubs(:client).returns(client)
+      client.stubs(:storageclasses).raises(Fog::Kubevirt::Errors::ClientError.new)
+      assert_empty compute_resource.storage_classes
+    end
+  end
+
   describe "find_vm_by_uuid" do
     test "it finds the vm" do
       Fog.mock!

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foreman_kubevirt
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.2
 platform: ruby
 authors:
 - Moti Asayag
 bindir: bin
 cert_chain: []
-date: 2025-02-11 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fog-kubevirt
@@ -150,7 +150,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Provision and manage Kubevirt Virtual Machines from Foreman
 test_files: