foreman_google 3.0.8 → 3.0.9

data/locale/it/foreman_google.po

@@ -10,7 +10,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_google 3.0.6\n"
+"Project-Id-Version: foreman_google 3.1.0\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2022-08-01 12:51+0000\n"
 "Last-Translator: 0868a4d1af5275b3f70b0a6dac4c99a4, 2022\n"
@@ -99,3 +99,9 @@ msgstr ""
 
 msgid "console is not available at this time because the instance is powered off"
 msgstr ""
+
+msgid "unable to start machine that is not persisted"
+msgstr ""
+
+msgid "unable to stop machine that is not persisted"
+msgstr ""

data/locale/ja/foreman_google.po

@@ -8,14 +8,14 @@
 # Bryan Kearney <bryan.kearney@gmail.com>, 2022
 # Amit Upadhye <aupadhye@redhat.com>, 2022
 # Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarden.nl>, 2024
+# Ondřej Gajdušek, 2026
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_google 3.0.6\n"
+"Project-Id-Version: foreman_google 3.1.0\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2022-08-01 12:51+0000\n"
-"Last-Translator: Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarde"
-"n.nl>, 2024\n"
+"Last-Translator: Ondřej Gajdušek, 2026\n"
 "Language-Team: Japanese (https://app.transifex.com/foreman/teams/114/ja/)\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
@@ -100,3 +100,9 @@ msgstr "ゾーン、GCE 専用"
 
 msgid "console is not available at this time because the instance is powered off"
 msgstr "インスタンスの電源がオフであるため、現時点ではコンソールは使用できません"
+
+msgid "unable to start machine that is not persisted"
+msgstr "永続化されていないマシンを起動できません"
+
+msgid "unable to stop machine that is not persisted"
+msgstr "永続化されていないマシンを停止できません"

data/locale/ka/foreman_google.po

@@ -8,7 +8,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_google 3.0.6\n"
+"Project-Id-Version: foreman_google 3.1.0\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2022-08-01 12:51+0000\n"
 "Last-Translator: Temuri Doghonadze <temuri.doghonadze@gmail.com>, 2023\n"
@@ -96,3 +96,9 @@ msgstr "ზონა, მხოლოდ GCE-სთვის"
 
 msgid "console is not available at this time because the instance is powered off"
 msgstr "კონსოლი ამჟამად მიუწვდომელია. გაშვებული ასლი გამორთულია"
+
+msgid "unable to start machine that is not persisted"
+msgstr ""
+
+msgid "unable to stop machine that is not persisted"
+msgstr ""

data/locale/ko/foreman_google.po

@@ -7,14 +7,14 @@
 # Bryan Kearney <bryan.kearney@gmail.com>, 2022
 # 0868a4d1af5275b3f70b0a6dac4c99a4, 2022
 # Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarden.nl>, 2024
+# Ondřej Gajdušek, 2026
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_google 3.0.6\n"
+"Project-Id-Version: foreman_google 3.1.0\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2022-08-01 12:51+0000\n"
-"Last-Translator: Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarde"
-"n.nl>, 2024\n"
+"Last-Translator: Ondřej Gajdušek, 2026\n"
 "Language-Team: Korean (https://app.transifex.com/foreman/teams/114/ko/)\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
@@ -99,3 +99,9 @@ msgstr "Zone, GCE 전용"
 
 msgid "console is not available at this time because the instance is powered off"
 msgstr "인스턴스 전원이 꺼져 있으므로 현재 콘솔을 사용할 수 없습니다."
+
+msgid "unable to start machine that is not persisted"
+msgstr "영구 저장되지 않은 머신은 시작할 수 없습니다."
+
+msgid "unable to stop machine that is not persisted"
+msgstr "영구 저장되지 않은 머신은 중지할 수 없습니다."

data/locale/pl/foreman_google.po

@@ -9,7 +9,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_google 3.0.6\n"
+"Project-Id-Version: foreman_google 3.1.0\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2022-08-01 12:51+0000\n"
 "Last-Translator: Michał Foryt <michal.foryt@gmail.com>, 2022\n"
@@ -99,3 +99,9 @@ msgstr ""
 
 msgid "console is not available at this time because the instance is powered off"
 msgstr ""
+
+msgid "unable to start machine that is not persisted"
+msgstr ""
+
+msgid "unable to stop machine that is not persisted"
+msgstr ""

data/locale/pt_BR/foreman_google.po

@@ -12,7 +12,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_google 3.0.6\n"
+"Project-Id-Version: foreman_google 3.1.0\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2022-08-01 12:51+0000\n"
 "Last-Translator: Luiz Henrique Vasconcelos <luizvasconceloss@yahoo.com.br>, 20"
@@ -103,3 +103,9 @@ msgstr ""
 
 msgid "console is not available at this time because the instance is powered off"
 msgstr "console não está disponível neste momento porque a instância está desligada"
+
+msgid "unable to start machine that is not persisted"
+msgstr ""
+
+msgid "unable to stop machine that is not persisted"
+msgstr ""

data/locale/ru/foreman_google.po

@@ -12,7 +12,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_google 3.0.6\n"
+"Project-Id-Version: foreman_google 3.1.0\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2022-08-01 12:51+0000\n"
 "Last-Translator: 0868a4d1af5275b3f70b0a6dac4c99a4, 2022\n"
@@ -102,3 +102,9 @@ msgstr ""
 
 msgid "console is not available at this time because the instance is powered off"
 msgstr ""
+
+msgid "unable to start machine that is not persisted"
+msgstr ""
+
+msgid "unable to stop machine that is not persisted"
+msgstr ""

data/locale/sv_SE/foreman_google.po

@@ -10,7 +10,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_google 3.0.6\n"
+"Project-Id-Version: foreman_google 3.1.0\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2022-08-01 12:51+0000\n"
 "Last-Translator: johnny.westerlund <johnny.westerlund@gmail.com>, 2022\n"
@@ -99,3 +99,9 @@ msgstr ""
 
 msgid "console is not available at this time because the instance is powered off"
 msgstr ""
+
+msgid "unable to start machine that is not persisted"
+msgstr ""
+
+msgid "unable to stop machine that is not persisted"
+msgstr ""

data/locale/zh_CN/foreman_google.po

@@ -9,14 +9,14 @@
 # tim123, 2022
 # Amit Upadhye <aupadhye@redhat.com>, 2022
 # Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarden.nl>, 2024
+# Ondřej Gajdušek, 2026
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_google 3.0.6\n"
+"Project-Id-Version: foreman_google 3.1.0\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2022-08-01 12:51+0000\n"
-"Last-Translator: Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarde"
-"n.nl>, 2024\n"
+"Last-Translator: Ondřej Gajdušek, 2026\n"
 "Language-Team: Chinese (China) (https://app.transifex.com/foreman/teams/114/zh"
 "_CN/)\n"
 "MIME-Version: 1.0\n"
@@ -102,3 +102,9 @@ msgstr "Zone，仅限 GCE"
 
 msgid "console is not available at this time because the instance is powered off"
 msgstr "控制台目前不可用，因为实例已关闭"
+
+msgid "unable to start machine that is not persisted"
+msgstr "无法启动没有持久化的机器"
+
+msgid "unable to stop machine that is not persisted"
+msgstr "无法停止没有持久化的机器"

data/locale/zh_TW/foreman_google.po

@@ -10,7 +10,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_google 3.0.6\n"
+"Project-Id-Version: foreman_google 3.1.0\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2022-08-01 12:51+0000\n"
 "Last-Translator: 0868a4d1af5275b3f70b0a6dac4c99a4, 2022\n"
@@ -99,3 +99,9 @@ msgstr ""
 
 msgid "console is not available at this time because the instance is powered off"
 msgstr ""
+
+msgid "unable to start machine that is not persisted"
+msgstr ""
+
+msgid "unable to stop machine that is not persisted"
+msgstr ""

data/test/controllers/foreman_google/api/v2/compute_resources_extensions_test.rb

@@ -0,0 +1,51 @@
+require 'test_google_helper'
+
+module ForemanGoogle
+  module Api
+    module V2
+      class ComputeResourcesExtensionsTest < GoogleTestCase
+        let(:controller_class) do
+          Class.new do
+            def self.before_action(*)
+            end
+
+            include ForemanGoogle::Api::V2::ComputeResourcesExtensions
+
+            attr_accessor :params
+
+            def compute_resource_params
+              params[:compute_resource]
+            end
+          end
+        end
+
+        describe '#read_key' do
+          it 'reads key file content into password for GCE provider' do
+            key_content = '{"type": "service_account", "project_id": "test"}'
+
+            Tempfile.open('gce_key') do |f|
+              f.write(key_content)
+              f.flush
+
+              ctrl = controller_class.new
+              ctrl.params = { 'compute_resource' => { 'provider' => 'GCE', 'key_path' => f.path } }.with_indifferent_access
+              ctrl.send(:read_key)
+
+              assert_equal key_content, ctrl.params[:compute_resource][:password]
+              assert_not ctrl.params[:compute_resource].key?('key_path')
+            end
+          end
+
+          it 'skips when provider is not GCE' do
+            ctrl = controller_class.new
+            ctrl.params = { 'compute_resource' => { 'provider' => 'EC2', 'key_path' => '/nonexistent' } }.with_indifferent_access
+            ctrl.send(:read_key)
+
+            assert_nil ctrl.params[:compute_resource][:password]
+            assert_equal '/nonexistent', ctrl.params[:compute_resource]['key_path']
+          end
+        end
+      end
+    end
+  end
+end

data/test/models/concerns/foreman_google/host_managed_extensions_test.rb

@@ -0,0 +1,46 @@
+require 'test_google_helper'
+
+module ForemanGoogle
+  class HostManagedExtensionsTest < GoogleTestCase
+    let(:host_class) do
+      Class.new do
+        include ForemanGoogle::HostManagedExtensions
+        attr_accessor :vm
+      end
+    end
+
+    describe '#ip_addresses' do
+      it 'returns vm ip_addresses when vm exists' do
+        vm = mock('GoogleCompute')
+        vm.expects(:ip_addresses).returns(['1.2.3.4', '10.0.0.1'])
+
+        host = host_class.new
+        host.vm = vm
+        assert_equal ['1.2.3.4', '10.0.0.1'], host.ip_addresses
+      end
+
+      it 'returns empty array when vm is nil' do
+        host = host_class.new
+        host.vm = nil
+        assert_empty host.ip_addresses
+      end
+    end
+
+    describe '#vm_ip_address' do
+      it 'returns vm public IP when vm exists' do
+        vm = mock('GoogleCompute')
+        vm.expects(:vm_ip_address).returns('1.2.3.4')
+
+        host = host_class.new
+        host.vm = vm
+        assert_equal '1.2.3.4', host.vm_ip_address
+      end
+
+      it 'returns nil when vm is nil' do
+        host = host_class.new
+        host.vm = nil
+        assert_nil host.vm_ip_address
+      end
+    end
+  end
+end

data/test/models/foreman_google/gce_test.rb

@@ -2,7 +2,7 @@ require 'test_google_helper'
 
 module ForemanGoogle
   class GCETest < GoogleTestCase
-    subject { ForemanGoogle::GCE.new(zone: 'zone', password: gauth_json) }
+    subject { ForemanGoogle::GCE.new(zone: 'us-east1-b', password: gauth_json) }
     let(:service) { mock('GoogleAdapter') }
 
     let(:instance_args) do
@@ -18,6 +18,142 @@ module ForemanGoogle
       service.stubs(:project_id).returns('project_id')
     end
 
+    describe '#to_label' do
+      it 'includes name, zone, and provider' do
+        subject.name = 'my-gce'
+        expected = 'my-gce (us-east1-b-Google)'
+        assert_equal expected, subject.to_label
+      end
+    end
+
+    describe '#capabilities' do
+      it 'returns image and new_volume' do
+        assert_equal %i[image new_volume], subject.capabilities
+      end
+    end
+
+    describe '#provided_attributes' do
+      it 'includes ip mapped to vm_ip_address' do
+        attrs = subject.provided_attributes
+        assert_equal :vm_ip_address, attrs[:ip]
+      end
+    end
+
+    describe '#user_data_supported?' do
+      it 'returns true' do
+        assert subject.user_data_supported?
+      end
+    end
+
+    describe '#zone' do
+      it 'reads from url attribute' do
+        subject.url = 'us-central1-a'
+        assert_equal 'us-central1-a', subject.zone
+      end
+    end
+
+    describe '#zone=' do
+      it 'writes to url attribute' do
+        subject.zone = 'europe-west1-b'
+        assert_equal 'europe-west1-b', subject.url
+      end
+    end
+
+    describe 'validations' do
+      it 'is valid with name, zone, and password' do
+        subject.name = 'test-gce'
+        assert subject.valid?, "Expected subject to be valid, got errors: #{subject.errors.full_messages}"
+      end
+
+      it 'requires password' do
+        cr = ForemanGoogle::GCE.new(zone: 'us-east1-b', password: nil)
+        assert_not cr.valid?
+        assert_includes cr.errors.attribute_names, :password
+      end
+
+      it 'requires zone' do
+        cr = ForemanGoogle::GCE.new(zone: nil, password: gauth_json)
+        assert_not cr.valid?
+        assert_includes cr.errors.attribute_names, :zone
+      end
+
+      it 'requires name' do
+        cr = ForemanGoogle::GCE.new(name: nil, zone: 'us-east1-b', password: gauth_json)
+        assert_not cr.valid?
+        assert_includes cr.errors.attribute_names, :name
+      end
+    end
+
+    describe '#zones' do
+      it 'returns zone names from client' do
+        zones = [OpenStruct.new(name: 'us-east1-b'), OpenStruct.new(name: 'us-west1-a')]
+        service.expects(:zones).returns(zones)
+        assert_equal %w[us-east1-b us-west1-a], subject.zones
+      end
+
+      it 'is aliased as available_zones' do
+        zones = [OpenStruct.new(name: 'us-east1-b')]
+        service.expects(:zones).returns(zones)
+        assert_equal %w[us-east1-b], subject.available_zones
+      end
+    end
+
+    describe '#networks' do
+      it 'returns network names from client' do
+        networks = [OpenStruct.new(name: 'default'), OpenStruct.new(name: 'custom')]
+        service.expects(:networks).returns(networks)
+        assert_equal %w[default custom], subject.networks
+      end
+    end
+
+    describe '#available_networks' do
+      it 'returns full network objects from client' do
+        network_objects = [OpenStruct.new(name: 'default')]
+        service.expects(:networks).returns(network_objects)
+        assert_equal network_objects, subject.available_networks
+      end
+    end
+
+    describe '#machine_types' do
+      it 'returns machine types for the zone from client' do
+        types = [OpenStruct.new(name: 'e2-micro')]
+        service.expects(:machine_types).with('us-east1-b').returns(types)
+        assert_equal types, subject.machine_types
+      end
+
+      it 'is aliased as available_flavors' do
+        types = [OpenStruct.new(name: 'n1-standard-1')]
+        service.expects(:machine_types).with('us-east1-b').returns(types)
+        assert_equal types, subject.available_flavors
+      end
+    end
+
+    describe '#available_images' do
+      it 'delegates to client.images with filter' do
+        images = [OpenStruct.new(name: 'centos-7')]
+        service.expects(:images).with(filter: nil).returns(images)
+        assert_equal images, subject.available_images
+      end
+
+      it 'passes custom filter to client' do
+        images = [OpenStruct.new(name: 'centos-7')]
+        service.expects(:images).with(filter: 'name = "centos"').returns(images)
+        assert_equal images, subject.available_images(filter: 'name = "centos"')
+      end
+    end
+
+    describe '#filter_for_images' do
+      it 'defaults to nil' do
+        assert_nil subject.filter_for_images
+      end
+    end
+
+    describe '#google_project_id' do
+      it 'delegates to client' do
+        assert_equal 'project_id', subject.google_project_id
+      end
+    end
+
     describe '#find_vm_by_uuid' do
       it 'does query gce' do
         instance = OpenStruct.new(**instance_args)
@@ -48,11 +184,29 @@ module ForemanGoogle
       end
 
       it 'iteration over the vms array' do
-        subject.vms.each_with_index { |instance, i| assert instance.name, instances[i].name }
+        subject.vms.each_with_index { |instance, i| assert_equal instances[i].name, instance.name }
       end
 
       it 'all method' do
-        subject.vms.all.each_with_index { |instance, i| assert instance.name, instances[i].name }
+        subject.vms.all.each_with_index { |instance, i| assert_equal instances[i].name, instance.name }
+      end
+    end
+
+    describe '#new_vm' do
+      it 'assigns provided attributes' do
+        vm = subject.new_vm(name: 'test-vm', machine_type: 'e2-micro')
+        assert_equal 'test-vm', vm.name
+        assert_equal 'e2-micro', vm.machine_type
+      end
+
+      it 'converts volumes_attributes nested hash' do
+        attrs = {
+          'name' => 'test-vm',
+          'volumes_attributes' => { '0' => { 'size_gb' => '20' } },
+        }
+        vm = subject.new_vm(attrs)
+        assert_equal 1, vm.volumes.size
+        assert_equal 20, vm.volumes.first.size_gb
       end
     end
 
@@ -65,5 +219,123 @@ module ForemanGoogle
         value { subject.create_vm({ image_id: 0 }) }.must_raise(::Foreman::Exception)
       end
     end
+
+    describe '#create_vm success path' do
+      let(:os_image) { OpenStruct.new(username: 'gce_user', name: 'centos-7') }
+      let(:gce_image) { OpenStruct.new(id: 42, self_link: 'image-link') }
+      let(:key_pair_obj) { OpenStruct.new(public: 'ssh-rsa AAAA') }
+      let(:vm) { mock('GoogleCompute') }
+
+      setup do
+        service.stubs(:image).returns(gce_image)
+        service.stubs(:instance)
+        subject.stubs(:images).returns(stub(find_by: os_image))
+        subject.stubs(:key_pair).returns(key_pair_obj)
+        subject.stubs(:new_vm).returns(vm)
+        vm.stubs(:hostname).returns('test-vm')
+
+        vm.expects(:create_volumes)
+        vm.expects(:create_instance)
+        vm.expects(:set_disk_auto_delete)
+      end
+
+      it 'creates volumes, instance, and sets auto-delete' do
+        result = subject.create_vm({ image_id: 42 })
+        assert_kind_of ForemanGoogle::GoogleCompute, result
+      end
+    end
+
+    describe '#create_vm rollback on error' do
+      let(:os_image) { OpenStruct.new(username: 'gce_user', name: 'centos-7') }
+      let(:gce_image) { OpenStruct.new(id: 42, self_link: 'image-link') }
+      let(:key_pair_obj) { OpenStruct.new(public: 'ssh-rsa AAAA') }
+      let(:vm) { mock('GoogleCompute') }
+
+      setup do
+        subject.stubs(:images).returns(stub(find_by: os_image))
+        service.stubs(:image).returns(gce_image)
+        subject.stubs(:key_pair).returns(key_pair_obj)
+        subject.stubs(:new_vm).returns(vm)
+        vm.stubs(:create_volumes).raises(::Google::Cloud::Error.new('quota exceeded'))
+
+        vm.expects(:destroy_volumes)
+      end
+
+      it 'destroys volumes and raises WrappedException' do
+        assert_raises(Foreman::WrappedException) { subject.create_vm({ image_id: 42 }) }
+      end
+    end
+
+    describe '#destroy_vm' do
+      it 'calls set_disk_auto_delete and delete_instance' do
+        service.expects(:set_disk_auto_delete).with('us-east1-b', 'vm-uuid')
+        service.expects(:delete_instance).with('us-east1-b', 'vm-uuid')
+        subject.destroy_vm('vm-uuid')
+      end
+
+      it 'returns true when VM not found' do
+        service.expects(:set_disk_auto_delete).raises(ActiveRecord::RecordNotFound)
+        assert subject.destroy_vm('missing-vm')
+      end
+    end
+
+    describe '#new_volume' do
+      it 'returns an AttachedDisk with 20 GB default' do
+        vol = subject.new_volume
+        assert_kind_of Google::Cloud::Compute::V1::AttachedDisk, vol
+        assert_equal 20, vol.disk_size_gb
+      end
+
+      it 'merges provided attributes' do
+        vol = subject.new_volume(device_name: 'boot-disk')
+        assert_equal 'boot-disk', vol.device_name
+        assert_equal 20, vol.disk_size_gb
+      end
+    end
+
+    describe '#console' do
+      let(:vm) { mock('GoogleCompute') }
+
+      setup do
+        subject.stubs(:find_vm_by_uuid).returns(vm)
+      end
+
+      it 'returns serial output when VM is ready' do
+        vm.stubs(:ready?).returns(true)
+        vm.stubs(:serial_port_output).returns('boot log...')
+        vm.stubs(:name).returns('test-vm')
+
+        result = subject.console('test-vm')
+        assert_equal 'boot log...', result['output']
+        assert_equal 'log', result[:type]
+        assert_equal 'test-vm', result[:name]
+        assert result['timestamp'].is_a?(Time)
+      end
+
+      it 'raises when VM is not ready' do
+        vm.stubs(:ready?).returns(false)
+        assert_raises(::Foreman::Exception) { subject.console('test-vm') }
+      end
+    end
+
+    describe '#associated_host' do
+      it 'calls associate_by with ip addresses' do
+        vm = OpenStruct.new(public_ip_address: '1.2.3.4', private_ip_address: '10.0.0.1')
+        subject.expects(:associate_by).with('ip', ['1.2.3.4', '10.0.0.1'])
+        subject.associated_host(vm)
+      end
+    end
+
+    describe '#vm_ready' do
+      it 'polls until vm is ready' do
+        vm = mock('GoogleCompute')
+        vm.stubs(:reload).returns(vm)
+        vm.stubs(:ready?).returns(false, true)
+        vm.stubs(:wait_for).yields.returns({ duration: 2 })
+
+        result = subject.vm_ready(vm)
+        assert_equal({ duration: 2 }, result)
+      end
+    end
   end
 end