foreman_google 0.0.1 → 1.0.0

data/locale/foreman_google.pot

@@ -1,19 +1,123 @@
-# foreman_google
-#
-# This file is distributed under the same license as foreman_google.
+# SOME DESCRIPTIVE TITLE.
+# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
+# This file is distributed under the same license as the foreman_google package.
+# FIRST AUTHOR <EMAIL@ADDRESS>, YEAR.
 #
 #, fuzzy
 msgid ""
 msgstr ""
-"Project-Id-Version: version 0.0.1\n"
+"Project-Id-Version: foreman_google 1.0.0\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2014-08-20 08:46+0100\n"
-"PO-Revision-Date: 2014-08-20 08:46+0100\n"
-"Last-Translator: Foreman Team <foreman-dev@googlegroups.com>\n"
-"Language-Team: Foreman Team <foreman-dev@googlegroups.com>\n"
+"POT-Creation-Date: 2022-07-29 13:33+0200\n"
+"PO-Revision-Date: 2022-07-29 13:33+0200\n"
+"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
+"Language-Team: LANGUAGE <LL@li.org>\n"
 "Language: \n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 "Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n"
 
+#: ../app/models/foreman_google/gce.rb:126
+msgid "console is not available at this time because the instance is powered off"
+msgstr ""
+
+#: ../app/models/foreman_google/gce.rb:170
+msgid "Missing an image for operating system!"
+msgstr ""
+
+#: ../app/views/compute_resources/form/_gce.html.erb:3
+msgid "JSON key"
+msgstr ""
+
+#: ../app/views/compute_resources/form/_gce.html.erb:9
+#: ../app/views/compute_resources_vms/show/_gce.html.erb:11
+msgid "Zone"
+msgstr ""
+
+#: ../app/views/compute_resources/form/_gce.html.erb:10
+msgid "Load Zones"
+msgstr ""
+
+#: ../app/views/compute_resources_vms/form/gce/_base.html.erb:3
+msgid "Machine type"
+msgstr ""
+
+#: ../app/views/compute_resources_vms/form/gce/_base.html.erb:12
+msgid "Please select an image"
+msgstr ""
+
+#: ../app/views/compute_resources_vms/form/gce/_base.html.erb:13
+#: ../app/views/compute_resources_vms/show/_gce.html.erb:18
+msgid "Image"
+msgstr ""
+
+#: ../app/views/compute_resources_vms/form/gce/_base.html.erb:17
+msgid "Network"
+msgstr ""
+
+#: ../app/views/compute_resources_vms/form/gce/_base.html.erb:18
+msgid "Associate Ephemeral External IP"
+msgstr ""
+
+#: ../app/views/compute_resources_vms/form/gce/_volume.html.erb:5
+msgid "Size (GB)"
+msgstr ""
+
+#: ../app/views/compute_resources_vms/index/_gce.html.erb:3
+msgid "Name"
+msgstr ""
+
+#: ../app/views/compute_resources_vms/index/_gce.html.erb:4
+msgid "Type"
+msgstr ""
+
+#: ../app/views/compute_resources_vms/index/_gce.html.erb:5
+msgid "State"
+msgstr ""
+
+#: ../app/views/compute_resources_vms/index/_gce.html.erb:6
+msgid "Actions"
+msgstr ""
+
+#: ../app/views/compute_resources_vms/show/_gce.html.erb:6
+msgid "Properties"
+msgstr ""
+
+#: ../app/views/compute_resources_vms/show/_gce.html.erb:10
+msgid "Machine Type"
+msgstr ""
+
+#: ../app/views/images/form/_gce.html.erb:1
+msgid ""
+"The user that is used to ssh into the instance, normally cloud-user, ec2-user,"
+" ubuntu, etc. Note: Google engine doesn't support SSH for the root user."
+msgstr ""
+
+#: ../app/views/images/form/_gce.html.erb:3
+msgid "Does this image support user data input (e.g. via cloud-init)?"
+msgstr ""
+
+#: action_names.rb:2
+msgid "Preupgrade job"
+msgstr ""
+
+#: action_names.rb:3
+msgid "Action with sub plans"
+msgstr ""
+
+#: action_names.rb:4
+msgid "Import facts"
+msgstr ""
+
+#: action_names.rb:5
+msgid "Import Puppet classes"
+msgstr ""
+
+#: action_names.rb:6
+msgid "Remote action:"
+msgstr ""
+
+#: gemspec.rb:2
+msgid "Google Compute Engine plugin for the Foreman."
+msgstr ""

data/locale/gemspec.rb

@@ -1,2 +1,2 @@
 # Matches foreman_google.gemspec
-_('TODO: Description of ForemanGoogle.')
+_('Google Compute Engine plugin for the Foreman.')

data/package.json

@@ -21,7 +21,7 @@
     "url": "http://projects.theforeman.org/projects/foreman_google/issues"
   },
   "peerDependencies": {
-    "@theforeman/vendor": ">= 6.0.0"
+    "@theforeman/vendor": ">= 8.16.0"
   },
   "dependencies": {
     "react-intl": "^2.8.0"
@@ -29,12 +29,12 @@
   "devDependencies": {
     "@babel/core": "^7.7.0",
     "@sheerun/mutationobserver-shim": "^0.3.3",
-    "@theforeman/builder": "^6.0.0",
-    "@theforeman/eslint-plugin-foreman": "6.0.0",
-    "@theforeman/find-foreman": "^4.8.0",
-    "@theforeman/stories": "^7.0.0",
-    "@theforeman/test": "^8.0.0",
-    "@theforeman/vendor-dev": "^6.0.0",
+    "@theforeman/builder": "^10.0",
+    "@theforeman/eslint-plugin-foreman": "^10.0",
+    "@theforeman/find-foreman": "^10.0",
+    "@theforeman/stories": "^10.0",
+    "@theforeman/test": "^10.0",
+    "@theforeman/vendor-dev": "^10.0",
     "babel-eslint": "^10.0.3",
     "eslint": "^6.7.2",
     "prettier": "^1.19.1",

data/test/fixtures/disks_delete.json

@@ -0,0 +1,14 @@
+{
+  "kind": "compute#operation",
+  "id": "7996175101872145267",
+  "name": "operation-1648639388515-5db6dc51d7cb9-84b381ef-f190800c",
+  "zone": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b",
+  "operationType": "delete",
+  "targetLink": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b/disks/foreman-disk1",
+  "targetId": "8772167819860748300",
+  "status": "RUNNING",
+  "progress": 0,
+  "insertTime": "2022-03-30T04:23:08.704-07:00",
+  "startTime": "2022-03-30T04:23:08.711-07:00",
+  "selfLink": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b/operations/operation-1648639388515-5db6dc51d7cb9-84b381ef-f190800c"
+}

data/test/fixtures/disks_get.json

@@ -0,0 +1,13 @@
+{
+  "kind": "compute#disk",
+  "id": "8772167819860748300",
+  "creationTimestamp": "2022-03-30T01:37:55.394-07:00",
+  "name": "foreman-disk1",
+  "sizeGb": "500",
+  "zone": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b",
+  "status": "READY",
+  "selfLink": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b/disks/foreman-disk1",
+  "type": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b/diskTypes/pd-standard",
+  "labelFingerprint": "42WmSpB8rSM=",
+  "physicalBlockSizeBytes": "4096"
+}

data/test/fixtures/disks_insert.json

@@ -0,0 +1,12 @@
+{
+  "kind": "compute#operation",
+  "id": "1043042221276375052",
+  "name": "operation-1648629475145-5db6b763b7595-82e7ebef-451ed31a",
+  "zone": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b",
+  "operationType": "insert",
+  "targetLink": "https://www.googleapis.com/compute/v1/projects/modular-ethos-98809/zones/us-east1-b/disks/foreman-disk1",
+  "targetId": "8772167819860748300",
+  "status": "RUNNING",
+  "progress": 0,
+  "selfLink": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b/operations/operation-1648629475145-5db6b763b7595-82e7ebef-451ed31a"
+}

data/test/fixtures/instance.json

@@ -7,7 +7,7 @@
           "tags": {
             "fingerprint": "42WmSpB8rSM="
           },
-          "machineType": "https://www.googleapis.com/compute/v1/projectscoastal-haven-123456zones/us-east1-b/machineTypes/e2-micro",
+          "machineType": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b/machineTypes/e2-micro",
           "status": "RUNNING",
           "zone": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b",
           "canIpForward": false,

data/test/fixtures/instance_insert.json

@@ -0,0 +1,15 @@
+{
+  "kind": "compute#operation",
+  "id": "6200725776819157246",
+  "name": "operation-1648641552671-5db6e461be422-a2599aa0-27cd29fc",
+  "zone": "https://www.googleapis.com/compute/v1/projects/modular-ethos-98809/zones/europe-west3-c",
+  "operationType": "insert",
+  "targetLink": "https://www.googleapis.com/compute/v1/projects/modular-ethos-98809/zones/europe-west3-c/instances/foreman-test-google1648641548",
+  "targetId": "6079655721101293822",
+  "status": "RUNNING",
+  "user": "modular-ethos-98809@appspot.gserviceaccount.com",
+  "progress": 0,
+  "insertTime": "2022-03-30T04:59:13.515-07:00",
+  "startTime": "2022-03-30T04:59:13.516-07:00",
+  "selfLink": "https://www.googleapis.com/compute/v1/projects/modular-ethos-98809/zones/europe-west3-c/operations/operation-1648641552671-5db6e461be422-a2599aa0-27cd29fc"
+}

data/test/fixtures/instance_list.json

@@ -0,0 +1,86 @@
+{
+  "kind": "compute#instanceList",
+  "id": "projects/coastal-haven-123456/zones/us-east1-b/instances",
+  "items": [
+    {
+      "kind": "compute#instance",
+      "id": "123",
+      "creationTimestamp": "2022-03-30T04:59:13.453-07:00",
+      "name": "foreman-test-google1648641548",
+      "tags": {
+        "fingerprint": "42WmSpB8rSM="
+      },
+      "machineType": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b/machineTypes/e2-micro",
+      "status": "TERMINATED",
+      "zone": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b",
+      "networkInterfaces": [
+        {
+          "kind": "compute#networkInterface",
+          "network": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/global/networks/default",
+          "subnetwork": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/regions/europe-west3/subnetworks/default",
+          "networkIP": "10.156.0.15",
+          "name": "nic0",
+          "fingerprint": "TJa5cxJEqkU=",
+          "stackType": "IPV4_ONLY"
+        }
+      ],
+      "disks": [
+        {
+          "kind": "compute#attachedDisk",
+          "type": "PERSISTENT",
+          "mode": "READ_WRITE",
+          "source": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b/disks/foreman-test-google1648641548-disk1",
+          "deviceName": "persistent-disk-0",
+          "index": 0,
+          "boot": true,
+          "autoDelete": true,
+          "licenses": [
+            "https://www.googleapis.com/compute/v1/projects/centos-cloud/global/licenses/centos-stream"
+          ],
+          "interface": "SCSI",
+          "guestOsFeatures": [
+            {
+              "type": "UEFI_COMPATIBLE"
+            },
+            {
+              "type": "VIRTIO_SCSI_MULTIQUEUE"
+            },
+            {
+              "type": "SEV_CAPABLE"
+            },
+            {
+              "type": "GVNIC"
+            }
+          ],
+          "diskSizeGb": "23"
+        }
+      ],
+      "metadata": {
+        "kind": "compute#metadata",
+        "fingerprint": "YazRB9ehpGM="
+      },
+      "selfLink": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b/instances/foreman-test-google1648641548",
+      "scheduling": {
+        "onHostMaintenance": "MIGRATE",
+        "automaticRestart": true,
+        "preemptible": false
+      },
+      "cpuPlatform": "Unknown CPU Platform",
+      "labelFingerprint": "42WmSpB8rSM=",
+      "startRestricted": false,
+      "deletionProtection": false,
+      "shieldedInstanceConfig": {
+        "enableSecureBoot": false,
+        "enableVtpm": true,
+        "enableIntegrityMonitoring": true
+      },
+      "shieldedInstanceIntegrityPolicy": {
+        "updateAutoLearnPolicy": true
+      },
+      "fingerprint": "kDkIG75oL1k=",
+      "lastStartTimestamp": "2022-04-07T06:09:42.109-07:00",
+      "lastStopTimestamp": "2022-04-07T06:52:58.005-07:00"
+    }
+  ],
+  "selfLink": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b/instances"
+}

data/test/fixtures/instance_set_disk_auto_delete.json

@@ -0,0 +1,14 @@
+{
+  "kind": "compute#operation",
+  "id": "4987965516534051502",
+  "name": "operation-1648708672817-5db7de6c808c0-7970bcc7-68670f06",
+  "zone": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b",
+  "operationType": "setDiskAutoDelete",
+  "targetLink": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b/instances/foreman-test-google1648641548",
+  "targetId": "6079655721101293822",
+  "status": "RUNNING",
+  "progress": 0,
+  "insertTime": "2022-03-30T23:37:53.201-07:00",
+  "startTime": "2022-03-30T23:37:53.212-07:00",
+  "selfLink": "https://www.googleapis.com/compute/v1/projects/coastal-haven-123456/zones/us-east1-b/operations/operation-1648708672817-5db7de6c808c0-7970bcc7-68670f06"
+}

data/test/fixtures/operation_error.json

@@ -0,0 +1,26 @@
+{
+  "kind": "compute#operation",
+  "id": "150820958032316172",
+  "name": "operation-1654585826373-5e0d6486e6dac-12d06773-e45211ed",
+  "zone": "https://www.googleapis.com/compute/v1/projects/modular-ethos-98809/zones/europe-central2-a",
+  "operationType": "insert",
+  "targetLink": "https://www.googleapis.com/compute/v1/projects/modular-ethos-98809/zones/europe-central2-a/instances/louie-stahly-example-com",
+  "targetId": "7654338946829338380",
+  "status": "DONE",
+  "user": "coconut-service-account@modular-ethos-98809.iam.gserviceaccount.com",
+  "progress": 100,
+  "insertTime": "2022-06-07T00:10:27.995-07:00",
+  "startTime": "2022-06-07T00:10:27.996-07:00",
+  "endTime": "2022-06-07T00:10:34.467-07:00",
+  "error": {
+    "errors": [
+      {
+        "code": "QUOTA_EXCEEDED",
+        "message": "Quota 'CPUS' exceeded.  Limit: 8.0 in region europe-central2."
+      }
+    ]
+  },
+  "httpErrorStatusCode": 403,
+  "httpErrorMessage": "FORBIDDEN",
+  "selfLink": "https://www.googleapis.com/compute/v1/projects/modular-ethos-98809/zones/europe-central2-a/operations/operation-1654585826373-5e0d6486e6dac-12d06773-e45211ed"
+}

data/test/fixtures/operation_get.json

@@ -0,0 +1,13 @@
+{
+  "kind": "compute#operation",
+  "id": "6200725776819157246",
+  "name": "operation-1653565614407-5dfe8bf0f40b4-855dec88-23e914e4",
+  "zone": "https://www.googleapis.com/compute/v1/projects/modular-ethos-98809/zones/europe-west3-c",
+  "operationType": "insert",
+  "targetLink": "https://www.googleapis.com/compute/v1/projects/modular-ethos-98809/zones/europe-west3-c/instances/mega-chad-1",
+  "targetId": "3160050662526604865",
+  "status": "DONE",
+  "insertTime": "2022-05-26T04:46:55.770-07:00",
+  "startTime": "2022-05-26T04:46:55.770-07:00",
+  "endTime": "2022-05-26T04:47:02.023-07:00"
+}

data/test/models/foreman_google/gce_test.rb

@@ -5,6 +5,14 @@ module ForemanGoogle
     subject { ForemanGoogle::GCE.new(zone: 'zone', password: gauth_json) }
     let(:service) { mock('GoogleAdapter') }
 
+    let(:instance_args) do
+      nics = [OpenStruct.new(access_configs: [OpenStruct.new(nat_i_p: '1.2.3.4')], network: 'test/default', network_i_p: '10.10.10.23')]
+
+      { name: "instance-#{Time.now.to_i}", network_interfaces: nics,
+        creation_timestamp: Time.zone.now, zone: '/test/us-east1-b',
+        machine_type: 'machineTypes/e2-micro' }
+    end
+
     setup do
       subject.stubs(client: service)
       service.stubs(:project_id).returns('project_id')
@@ -12,9 +20,11 @@ module ForemanGoogle
 
     describe '#find_vm_by_uuid' do
       it 'does query gce' do
-        instance = stub(status: 'RUNNING')
-        service.expects(:instance).with(subject.zone, 'instance_name').returns(instance)
-        compute = subject.find_vm_by_uuid('instance_name')
+        instance = OpenStruct.new(**instance_args)
+
+        service.expects(:instance).with(subject.zone, instance.name).returns(instance)
+
+        compute = subject.find_vm_by_uuid(instance.name)
         value(compute).must_be_kind_of(ForemanGoogle::GoogleCompute)
       end
 
@@ -22,9 +32,37 @@ module ForemanGoogle
         service
           .expects(:instance)
           .with(subject.zone, 'non-existing-name-or-id')
-          .raises(Foreman::WrappedException.new(Google::Cloud::NotFoundError.new, 'not found'))
+          .raises(ActiveRecord::RecordNotFound)
+
+        value { subject.find_vm_by_uuid('non-existing-name-or-id') }.must_raise(ActiveRecord::RecordNotFound)
+      end
+    end
+
+    describe '#vms' do
+      let(:instances) do
+        Array.new(2) { |_i| OpenStruct.new(**instance_args) }
+      end
+
+      setup do
+        service.expects(:instances).returns(instances)
+      end
+
+      it 'iteration over the vms array' do
+        subject.vms.each_with_index { |instance, i| assert instance.name, instances[i].name }
+      end
+
+      it 'all method' do
+        subject.vms.all.each_with_index { |instance, i| assert instance.name, instances[i].name }
+      end
+    end
+
+    describe '#create_vm' do
+      setup do
+        service.expects(:image).returns(nil)
+      end
 
-        value { subject.find_vm_by_uuid('non-existing-name-or-id') }.must_raise(Foreman::WrappedException)
+      it 'without OS image' do
+        value { subject.create_vm({ image_id: 0 }) }.must_raise(::Foreman::Exception)
       end
     end
   end

data/test/models/foreman_google/google_compute_test.rb

@@ -6,6 +6,14 @@ module ForemanGoogle
     let(:zone) { 'zone-1' }
     let(:identity) { 'instance-id-or-name' }
 
+    let(:instance) do
+      nics = [OpenStruct.new(access_configs: [OpenStruct.new(nat_i_p: '1.2.3.4')], network: 'test/default', network_i_p: '10.10.10.23')]
+
+      OpenStruct.new name: 'instance', network_interfaces: nics,
+        creation_timestamp: Time.zone.now, zone: zone,
+        machine_type: 'machineTypes/e2-micro'
+    end
+
     subject { ForemanGoogle::GoogleCompute.new(client: client, zone: zone, identity: identity) }
 
     setup do
@@ -40,19 +48,15 @@ module ForemanGoogle
     end
 
     describe '#ready?' do
-      let(:instance) { mock('Google::Compute::Instance') }
-
-      setup do
-        client.expects(:instance).with(zone, identity).returns(instance)
-      end
-
       it 'is ready with running instance' do
-        instance.expects(:status).returns('RUNNING')
+        instance.status = 'RUNNING'
+        client.expects(:instance).with(zone, identity).returns(instance)
         value(subject).must_be(:ready?)
       end
 
       it 'is not ready for not running instance' do
-        instance.expects(:status).returns('PROVISIONING')
+        instance.status = 'PROVISIONING'
+        client.expects(:instance).with(zone, identity).returns(instance)
         value(subject).wont_be(:ready?)
       end
     end
@@ -62,8 +66,8 @@ module ForemanGoogle
         args = { network: '' }
         cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, args: args)
 
-        assert_includes cr.name, 'foreman_'
-        assert_includes cr.hostname, 'foreman_'
+        assert_includes cr.name, 'foreman-'
+        assert_includes cr.hostname, 'foreman-'
       end
 
       it 'is parameterized' do
@@ -95,8 +99,7 @@ module ForemanGoogle
       end
 
       it 'with nics' do
-        nics = [{ network: 'global/networks/custom' }]
-        args = { associate_external_ip: '1', network_interfaces: nics }
+        args = { associate_external_ip: '1', network_interfaces: [{ network: 'global/networks/custom' }] }
         cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, args: args)
         expected_nics = [{ network: 'global/networks/custom', access_configs: [{ name: 'External NAT', type: 'ONE_TO_ONE_NAT' }] }]
 
@@ -104,52 +107,107 @@ module ForemanGoogle
       end
     end
 
-    describe '#disks' do
+    describe '#volumes' do
       setup do
-        client.stubs(:images).returns([OpenStruct.new(id: 1, name: 'coastal-image')])
+        client.stubs(:images).returns([OpenStruct.new(id: 1, name: 'coastal-image', self_link: 'test-self-link')])
+        client.stubs(:image).returns(OpenStruct.new(id: 1, name: 'coastal-image', self_link: 'test-self-link'))
       end
 
       it 'no volumes' do
-        args = { volumes: [] }
-        cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, args: args)
+        cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone)
+        volumes = [Google::Cloud::Compute::V1::AttachedDisk.new(disk_size_gb: 20)]
 
-        assert_equal cr.disks, []
+        assert_equal cr.volumes, volumes
       end
 
       it 'without image_id' do
         args = { volumes: [{ size_gb: '23' }] }
         cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, args: args)
-        disk = cr.disks.first
+        volume = cr.volumes.first
 
-        assert_equal disk.name, "#{cr.name}-disk1"
-        assert_nil disk.source_image
-      end
-
-      it 'image not found' do
-        args = { volumes: [{ size_gb: '23' }], image_id: '0' }
-        value { ForemanGoogle::GoogleCompute.new(client: client, zone: zone, args: args) }.must_raise(::Foreman::Exception)
+        assert_equal volume.device_name, "#{cr.name}-disk1"
+        assert_empty volume.source
       end
 
       it 'with source_image' do
-        args = { volumes: [{ size_gb: '23', source_image: 'centos-stream-8-v20220317' }], image_id: '1' }
+        args = { volumes: Array.new(2, { size_gb: '23', source_image: 'centos-stream-8-v20220317' }), image_id: '1' }
         cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, args: args)
 
-        disk = cr.disks.first
-        assert_equal disk.source_image, 'coastal-image'
+        assert_equal cr.volumes[0].source, 'test-self-link'
+        assert_equal cr.volumes[1].source, ''
       end
     end
 
     describe '#metadata' do
+      let(:ssh_attrs) { { username: 'gce_user', public_key: 'public_key' } }
+
       it 'with user_data' do
-        args = { user_data: 'test' }
+        args = ssh_attrs.merge({ user_data: 'test' })
         cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, args: args)
-        assert_equal cr.metadata, { items: [{ key: 'user-data', value: 'test' }] }
+
+        assert_includes cr.metadata[:items], { key: 'user-data', value: 'test' }
+        assert_includes cr.metadata[:items], { key: 'ssh-keys', value: 'gce_user:public_key' }
       end
 
       it 'no user_data' do
-        cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone)
-        assert_nil cr.metadata
+        cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, args: ssh_attrs)
+        assert_equal cr.metadata, { items: [{ key: 'ssh-keys', value: 'gce_user:public_key' }] }
       end
     end
+
+    it '#pretty_machine_type - with instance' do
+      cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, instance: instance)
+      assert_equal cr.pretty_machine_type, 'e2-micro'
+    end
+
+    it '#pretty_machine_type - without instance' do
+      args = { machine_type: 'high-cpu-16' }
+      cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, args: args)
+      assert_equal cr.pretty_machine_type, args[:machine_type]
+    end
+
+    it '#vm_ip_address' do
+      cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, instance: instance)
+      assert_equal cr.vm_ip_address, '1.2.3.4'
+    end
+
+    it '#private_ip_address' do
+      cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, instance: instance)
+      assert_equal cr.private_ip_address, '10.10.10.23'
+    end
+
+    it '#pretty_image_name' do
+      client.stubs(:disk).returns(OpenStruct.new(source_image: '/path/to/centos-source-image'))
+      instance.disks = [OpenStruct.new(source: 'path/to/foreman-disk1')]
+
+      cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, instance: instance)
+      assert_equal cr.pretty_image_name, 'centos-source-image'
+    end
+
+    it '@associate_external_ip' do
+      cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone)
+      assert_not cr.associate_external_ip
+
+      cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, args: { associate_external_ip: '1' })
+      assert cr.associate_external_ip
+    end
+
+    it '@network' do
+      cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone)
+      assert cr.network, 'default'
+
+      cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, args: { network: 'my-network' })
+      assert cr.network, 'my-network'
+    end
+
+    it '@zone' do
+      cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone)
+      assert zone, cr.zone
+    end
+
+    it '@zone_name' do
+      cr = ForemanGoogle::GoogleCompute.new(client: client, zone: zone, instance: instance)
+      assert zone, cr.zone_name
+    end
   end
 end