foreman_fog_proxmox 0.9.4 → 0.10.0

data/locale/fr/foreman_fog_proxmox.po

@@ -17,8 +17,8 @@ msgstr ""
 "Plural-Forms: nplurals=2; plural=n>1;\n"
 "\n"
 
-msgid "%s console is not supported at this time"
-msgstr "%s console pas encore supportée"
+msgid "%<s>s console is not supported at this time"
+msgstr ""
 
 msgid "Add Volume"
 msgstr "Ajouter un volume"
@@ -47,6 +47,12 @@ msgstr ""
 msgid "CDROM"
 msgstr ""
 
+msgid "CIDR IPv4 prefix"
+msgstr ""
+
+msgid "CIDR IPv6 prefix"
+msgstr ""
+
 msgid "CPU"
 msgstr ""
 
@@ -62,15 +68,15 @@ msgstr ""
 msgid "Cache"
 msgstr ""
 
-msgid "Caps lock ON"
-msgstr "Touches verrouillées"
-
 msgid "Card"
 msgstr "Carte"
 
 msgid "Change the password"
 msgstr "Changer le mot de passe"
 
+msgid "Cluster nodes"
+msgstr "Noeuds de la ferme"
+
 msgid "Controller"
 msgstr "Contrôleur"
 
@@ -80,6 +86,12 @@ msgstr "Coeurs"
 msgid "Create image?"
 msgstr "Créer image?"
 
+msgid "DHCP IPv4"
+msgstr ""
+
+msgid "DHCP IPv6"
+msgstr ""
+
 msgid "DNS"
 msgstr ""
 
@@ -110,6 +122,15 @@ msgstr "Activer/désactiver la virtualisation matérielle de KVM"
 msgid "Extended"
 msgstr "Etendu"
 
+msgid "Failed retrieving proxmox compute client caused by %<e>s"
+msgstr ""
+
+msgid "Failed retrieving proxmox identity client caused by %<e>s"
+msgstr ""
+
+msgid "Failed retrieving proxmox network client caused by %<e>s"
+msgstr ""
+
 msgid "Failed retrieving proxmox server vm by vmid=%<vmid>s"
 msgstr ""
 
@@ -131,6 +152,12 @@ msgstr ""
 msgid "ForemanFogProxmox plugin adds Proxmox VE compute resource to Foreman using fog-proxmox gem."
 msgstr "Le plugin ForemanFogProxmox ajoute la ressource de calcul Proxmox VE à foreman en utilisant le gem fog-proxmox"
 
+msgid "Gateway IPv4"
+msgstr ""
+
+msgid "Gateway IPv6"
+msgstr ""
+
 msgid "General"
 msgstr "Général"
 
@@ -206,7 +233,7 @@ msgid "Password to authenticate with - used for SSH finish step."
 msgstr "Mot de passe d'authentification - utilisé dans la dernière phase avec SSH."
 
 msgid "Path"
-msgstr ""
+msgstr "Chemin"
 
 msgid "Physical"
 msgstr "Physique"
@@ -230,7 +257,7 @@ msgid "Rate limit"
 msgstr "Taux limite"
 
 msgid "Renew expired token ?"
-msgstr ""
+msgstr "Renouveler jeton expiré?"
 
 msgid "Root password"
 msgstr "Mot de passe root"
@@ -256,6 +283,9 @@ msgstr ""
 msgid "Spectre-CTRL"
 msgstr ""
 
+msgid "Start after creation?"
+msgstr "Démarrer après création?"
+
 msgid "Start at boot"
 msgstr "Démarrer au boot"
 
@@ -278,13 +308,10 @@ msgid "Time"
 msgstr "Temps"
 
 msgid "Token expires on"
-msgstr ""
-
-msgid "Token expires on #{token_deadline}"
-msgstr ""
+msgstr "Jeton expire le "
 
 msgid "Token has expired?"
-msgstr ""
+msgstr "Jeton expiré?"
 
 msgid "Type"
 msgstr ""

data/test/factories/foreman_fog_proxmox/proxmox_node_mock_factory.rb

@@ -21,26 +21,41 @@ module ForemanFogProxmox
   module ProxmoxNodeMockFactory
     def mock_node_servers(cr, servers)
       node = mock('node')
+      nodes = mock('nodes')
+      node.stubs(:node).returns('pve')
       node.stubs(:servers).returns(servers)
-      cr.stubs(:nodes).returns([node])
-      cr.stubs(:node).returns(node)
+      nodes.stubs(:get).returns(node)
+      nodes.stubs(:all).returns([node])
+      client = mock('client')
+      client.stubs(:nodes).returns(nodes)
+      cr.stubs(:client).returns(client)
       cr
     end
 
     def mock_node_containers(cr, containers)
       node = mock('node')
+      nodes = mock('nodes')
+      node.stubs(:node).returns('pve')
       node.stubs(:containers).returns(containers)
-      cr.stubs(:node).returns(node)
-      cr.stubs(:nodes).returns([node])
+      nodes.stubs(:get).returns(node)
+      nodes.stubs(:all).returns([node])
+      client = mock('client')
+      client.stubs(:nodes).returns(nodes)
+      cr.stubs(:client).returns(client)
       cr
     end
 
     def mock_node_servers_containers(cr, servers, containers)
       node = mock('node')
+      node.stubs(:node).returns('pve')
       node.stubs(:containers).returns(containers)
       node.stubs(:servers).returns(servers)
-      cr.stubs(:node).returns(node)
-      cr.stubs(:nodes).returns([node])
+      nodes = mock('nodes')
+      nodes.stubs(:get).returns(node)
+      nodes.stubs(:all).returns([node])
+      client = mock('client')
+      client.stubs(:nodes).returns(nodes)
+      cr.stubs(:client).returns(client)
       cr
     end
 
@@ -53,8 +68,13 @@ module ForemanFogProxmox
       node2.stubs(:node).returns('node2')
       node2.stubs(:servers).returns(n2s)
       node2.stubs(:containers).returns(n2c)
-      cr.stubs(:node).returns(node1)
-      cr.stubs(:nodes).returns([node1, node2])
+      nodes = mock('nodes')
+      nodes.stubs(:get).with('pve').returns(node1)
+      nodes.stubs(:get).with('pve2').returns(node2)
+      nodes.stubs(:all).returns([node1, node2])
+      client = mock('client')
+      client.stubs(:nodes).returns(nodes)
+      cr.stubs(:client).returns(client)
       cr
     end
   end

data/test/factories/proxmox_factory.rb

@@ -30,7 +30,6 @@ FactoryBot.define do
       user { 'root@pam' }
       password { 'proxmox01' }
       url { 'https://192.168.56.101:8006/api2/json' }
-      node_id { 'pve' }
     end
 
     factory :proxmox_cr, :class => ForemanFogProxmox::Proxmox, :traits => [:proxmox]

data/test/functional/compute_resources_controller_test.rb

@@ -20,14 +20,26 @@ require 'test_plugin_helper'
 
 module ForemanFogProxmox
   class ComputeResourcesControllerTest < ActionController::TestCase
-    test 'should get isos' do
-      get :isos, params: { :storage => 'local' }
+    test 'should get isos by node and storage' do
+      get :isos_by_node_and_storage, params: { :node_id => 'pve', :storage => 'local' }
       assert_response :found
       show_response = @response.body
       assert_not show_response.empty?
     end
-    test 'should get ostemplates' do
-      get :ostemplates, params: { :storage => 'local' }
+    test 'should get ostemplates by node and storage' do
+      get :ostemplates_by_node_and_storage, params: { :node_id => 'pve', :storage => 'local' }
+      assert_response :found
+      show_response = @response.body
+      assert_not show_response.empty?
+    end
+    test 'should get isos by node' do
+      get :isos_by_node, params: { :node_id => 'pve' }
+      assert_response :found
+      show_response = @response.body
+      assert_not show_response.empty?
+    end
+    test 'should get ostemplates by node' do
+      get :ostemplates_by_node, params: { :node_id => 'pve' }
       assert_response :found
       show_response = @response.body
       assert_not show_response.empty?

data/test/unit/foreman_fog_proxmox/helpers/proxmox_server_helper_test.rb

@@ -56,6 +56,7 @@ module ForemanFogProxmox
 
       let(:host_delete) do
         { 'vmid' => '100',
+          'node_id' => 'pve',
           'name' => 'test',
           'type' => 'qemu',
           'cdrom' => 'image',

data/test/unit/foreman_fog_proxmox/proxmox_test.rb

@@ -35,7 +35,6 @@ module ForemanFogProxmox
     should validate_presence_of(:url)
     should validate_presence_of(:user)
     should validate_presence_of(:password)
-    should validate_presence_of(:node_id)
     should allow_value('root@pam').for(:user)
     should_not allow_value('root').for(:user)
     should_not allow_value('a').for(:url)

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_container_test.rb

@@ -35,6 +35,23 @@ module ForemanFogProxmox
         @cr = FactoryBot.build_stubbed(:proxmox_cr)
       end
 
+      it 'migrates container from one node to another in the cluster' do
+        uuid = '100'
+        config = mock('config')
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(true)
+        vm.stubs(:type).returns('lxc')
+        vm.stubs(:node_id).returns('pve')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        attr = { 'templated' => '0', 'node_id' => 'pve', 'config_attributes' => { 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' } }.with_indifferent_access
+        @cr.stubs(:parse_container_vm).returns('vmid' => '100', 'node_id' => 'pve2', 'type' => 'lxc', 'cores' => '1', 'cpulimit' => '1')
+        expected_attr = { :cores => '1', :cpulimit => '1' }
+        vm.expects(:update, expected_attr)
+        @cr.save_vm(uuid, attr)
+      end
+
       it 'saves modified container config' do
         uuid = '100'
         config = mock('config')
@@ -43,9 +60,10 @@ module ForemanFogProxmox
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(true)
         vm.stubs(:type).returns('lxc')
+        vm.stubs(:node_id).returns('pve')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
-        attr = { 'templated' => '0', 'config_attributes' => { 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' } }.with_indifferent_access
-        @cr.stubs(:parse_container_vm).returns('vmid' => '100', 'type' => 'lxc', 'cores' => '1', 'cpulimit' => '1')
+        attr = { 'templated' => '0', 'node_id' => 'pve', 'config_attributes' => { 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' } }.with_indifferent_access
+        @cr.stubs(:parse_container_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'lxc', 'cores' => '1', 'cpulimit' => '1')
         expected_attr = { :cores => '1', :cpulimit => '1' }
         vm.expects(:update, expected_attr)
         @cr.save_vm(uuid, attr)
@@ -66,9 +84,11 @@ module ForemanFogProxmox
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(true)
         vm.stubs(:type).returns('lxc')
+        vm.stubs(:node_id).returns('pve')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
+          'node_id' => 'pve',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -85,7 +105,7 @@ module ForemanFogProxmox
             }
           }
         }.with_indifferent_access
-        @cr.stubs(:parse_container_vm).returns('vmid' => '100', 'type' => 'lxc', 'cores' => '1', 'cpulimit' => '1')
+        @cr.stubs(:parse_container_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'lxc', 'cores' => '1', 'cpulimit' => '1')
         expected_config_attr = { :cores => '1', :cpulimit => '1' }
         expected_volume_attr =
           [
@@ -118,10 +138,12 @@ module ForemanFogProxmox
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(true)
         vm.stubs(:type).returns('lxc')
+        vm.stubs(:node_id).returns('pve')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes =
           {
             'templated' => '0',
+            'node_id' => 'pve',
             'config_attributes' => {
               'cores' => '1',
               'cpulimit' => '1',
@@ -141,6 +163,7 @@ module ForemanFogProxmox
           }.with_indifferent_access
         @cr.stubs(:parse_container_vm).returns(
           'vmid' => '100',
+          'node_id' => 'pve',
           'type' => 'lxc',
           'cores' => '1',
           'cpulimit' => '1'
@@ -169,9 +192,11 @@ module ForemanFogProxmox
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(true)
         vm.stubs(:type).returns('lxc')
+        vm.stubs(:node_id).returns('pve')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
+          'node_id' => 'pve',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -189,7 +214,7 @@ module ForemanFogProxmox
             }
           }
         }.with_indifferent_access
-        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
         expected_config_attr = { :cores => '1', :cpulimit => '1' }
         expected_volume_attr = { :id => 'mp0', :volid => 'local-lvm:vm-100-disk-0', :size => 1_073_741_824 }, { :mp => '/opt/toto' }
         vm.expects(:attach, expected_volume_attr)
@@ -200,11 +225,11 @@ module ForemanFogProxmox
 
     describe 'create_vm' do
       it 'creates container without bootstart' do
-        args = { vmid: '100', type: 'lxc', config_attributes: { onboot: '0' } }
+        args = { vmid: '100', type: 'lxc', node_id: 'pve', start_after_create: '0' }
         servers = mock('servers')
         servers.stubs(:id_valid?).returns(true)
         containers = mock('containers')
-        containers.stubs(:create).with(vmid: 100, type: 'lxc', config_attributes: { onboot: '0' })
+        containers.stubs(:create).with(vmid: 100, type: 'lxc', node_id: 'pve', start_after_create: '0')
         cr = mock_node_servers_containers(ForemanFogProxmox::Proxmox.new, servers, containers)
         cr.stubs(:convert_sizes).with(args)
         cr.stubs(:parse_container_vm).with(args).returns(args)
@@ -214,12 +239,12 @@ module ForemanFogProxmox
       end
 
       it 'creates container with bootstart' do
-        args = { vmid: '100', type: 'lxc', config_attributes: { onboot: '0' } }
+        args = { vmid: '100', type: 'lxc', node_id: 'pve', start_after_create: '1' }
         servers = mock('servers')
         servers.stubs(:id_valid?).returns(true)
         containers = mock('containers')
         vm = mock('vm')
-        containers.stubs(:create).with(vmid: 100, type: 'lxc', config_attributes: { onboot: '0' }).returns(vm)
+        containers.stubs(:create).with(vmid: 100, type: 'lxc', node_id: 'pve', start_after_create: '1').returns(vm)
         cr = mock_node_servers_containers(ForemanFogProxmox::Proxmox.new, servers, containers)
         cr.stubs(:convert_sizes).with(args)
         cr.stubs(:parse_container_vm).with(args).returns(args)

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_create_test.rb

@@ -43,7 +43,7 @@ module ForemanFogProxmox
       end
 
       it 'creates server without bootstart' do
-        args = { vmid: '100', type: 'qemu', config_attributes: { onboot: '0' } }
+        args = { vmid: '100', type: 'qemu', node_id: 'pve', start_after_create: '0' }
         servers = mock('servers')
         servers.stubs(:id_valid?).returns(true)
         cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
@@ -56,7 +56,7 @@ module ForemanFogProxmox
       end
 
       it 'creates server with bootstart' do
-        args = { vmid: '100', type: 'qemu', config_attributes: { onboot: '1' } }
+        args = { vmid: '100', type: 'qemu', node_id: 'pve', start_after_create: '1' }
         servers = mock('servers')
         servers.stubs(:id_valid?).returns(true)
         cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_test.rb

@@ -35,6 +35,22 @@ module ForemanFogProxmox
         @cr = FactoryBot.build_stubbed(:proxmox_cr)
       end
 
+      it 'migrates server from node to another one in the cluster' do
+        uuid = '100'
+        config = mock('config')
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:templated?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        attr = { 'templated' => '0', 'node_id' => 'pve2' }
+        vm.expects(:migrate)
+        @cr.save_vm(uuid, attr)
+      end
+
       it 'saves modified server config with same volumes' do
         uuid = '100'
         config = mock('config')
@@ -44,9 +60,10 @@ module ForemanFogProxmox
         vm.stubs(:container?).returns(false)
         vm.stubs(:templated?).returns(false)
         vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
-        attr = { 'templated' => '0', 'config_attributes' => { 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' } }.with_indifferent_access
-        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0')
+        attr = { 'templated' => '0', 'node_id' => 'pve', 'config_attributes' => { 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' } }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0')
         expected_attr = { :cores => '1', :cpulimit => '1' }.with_indifferent_access
         vm.expects(:update, expected_attr)
         @cr.save_vm(uuid, attr)
@@ -80,9 +97,11 @@ module ForemanFogProxmox
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(false)
         vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
+          'node_id' => 'pve',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -96,6 +115,7 @@ module ForemanFogProxmox
         }.with_indifferent_access
         @cr.stubs(:parse_server_vm).returns(
           'vmid' => '100',
+          'node_id' => 'pve',
           'type' => 'qemu',
           'cores' => '1',
           'cpulimit' => '1',

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_volumes_test.rb

@@ -50,9 +50,11 @@ module ForemanFogProxmox
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(false)
         vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
+          'node_id' => 'pve',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -69,7 +71,7 @@ module ForemanFogProxmox
             }
           }
         }.with_indifferent_access
-        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0')
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0')
         expected_config_attr = { :cores => '1', :cpulimit => '1' }
         expected_volume_attr = { id: 'scsi0', storage: 'local:lvm', size: (2_147_483_648 / GIGA).to_s }
         vm.expects(:attach, expected_volume_attr)
@@ -93,9 +95,11 @@ module ForemanFogProxmox
         vm.stubs(:container?).returns(false)
         vm.stubs(:templated?).returns(false)
         vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
+          'node_id' => 'pve',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -113,7 +117,7 @@ module ForemanFogProxmox
             }
           }
         }.with_indifferent_access
-        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'config_attributes' => { 'onboot' => '0' })
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'config_attributes' => { 'onboot' => '0' })
         expected_config_attr = { :cores => '1', :cpulimit => '1' }
         expected_volume_attr = 'scsi0'
         vm.expects(:detach, expected_volume_attr)
@@ -137,9 +141,11 @@ module ForemanFogProxmox
         vm.stubs(:container?).returns(false)
         vm.stubs(:templated?).returns(false)
         vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
+          'node_id' => 'pve',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -157,7 +163,7 @@ module ForemanFogProxmox
             }
           }
         }.with_indifferent_access
-        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
         expected_config_attr = { :cores => '1', :cpulimit => '1' }
         expected_volume_attr = ['scsi0', '+1G']
         vm.expects(:extend, expected_volume_attr)
@@ -179,9 +185,11 @@ module ForemanFogProxmox
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(false)
         vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
+          'node_id' => 'pve',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -199,7 +207,7 @@ module ForemanFogProxmox
             }
           }
         }.with_indifferent_access
-        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
         err = assert_raises Foreman::Exception do
           @cr.save_vm(uuid, new_attributes)
         end
@@ -220,9 +228,11 @@ module ForemanFogProxmox
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(false)
         vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
+          'node_id' => 'pve',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -240,7 +250,7 @@ module ForemanFogProxmox
             }
           }
         }.with_indifferent_access
-        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
         expected_config_attr = { :cores => '1', :cpulimit => '1' }
         expected_volume_attr = ['scsi0', 'local-lvm2']
         vm.expects(:move, expected_volume_attr)
@@ -264,9 +274,11 @@ module ForemanFogProxmox
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(false)
         vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
+          'node_id' => 'pve',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -284,7 +296,7 @@ module ForemanFogProxmox
             }
           }
         }.with_indifferent_access
-        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
         expected_config_attr = { :cores => '1', :cpulimit => '1' }
         expected_volume_attr = { :id => 'scsi0', :volid => 'local-lvm:vm-100-disk-0', :size => 1_073_741_824 }, { :cache => 'directsync' }
         vm.expects(:attach, expected_volume_attr)