foreman_fog_proxmox 0.17.1 → 0.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b4d4330c4fcf2a9c34654f0eb6fd815ff594e92c89cf3087668593c34eb5163
-  data.tar.gz: 299d35d38bc7acc751bcc6029ae81668c77885e008c2f05c44d821b3fc9b41b0
+  metadata.gz: 706caedbf4e2d8ec401c6c5257594cf35633bba111437ed7c6d00b2470f17fdb
+  data.tar.gz: a5849ac10f319cd6c0b3d35188f8cba52d0e35f55765db2b8301e6d9f2141725
 SHA512:
-  metadata.gz: a73e32847f12af16d70796f3d197126b4a0ade07d79ba8b5ced0d0c9663131af88d3ddaf21b1feef5dfe9209f066eae59cf0aab54c52ea7053a077bd85dbba13
-  data.tar.gz: bb05744d447e8dddcc864aaa44439cae3d6793f6d7d24b637ba627443cd1d0964c39c63e7adb72fc157284c36b0be9630a82e722765782b17d716a95040a8cc7
+  metadata.gz: 821257efc8242ee2b7322fb438f9a4bed9c1520e7e01f8a8e21314c2b0d5b47df14f1d3bbaca87f41f29ca95c61d1e5bf417d32c1c0b9956b8d3e4914429d6ef
+  data.tar.gz: 2211366e977d013664d358760e10a61888cda03dd6f16a077486443d759b276e55c29f49038a1aa6f284702a5053d13864c99c2b964a380dfe0e5618cee515ab

data/README.md

@@ -34,7 +34,7 @@ You can support the plugin development via the following methods:
 |>=0.12 |>=6.1|>=0.11|>=2.0|>=2.5|
 |>=0.14 |>=6.2|=0.13.0|>=2.4|>=2.7|
 |>=0.14 |>=6.2|>=0.13.1|>=2.3|>=2.5|
-|>=0.14 |>=6.2|>=0.14.0|>=2.5|>=2.5|
+|>=0.14 |>=6.2,<8.0|>=0.14.0|>=2.5|>=2.5|
 
 ## Installation
 

data/app/helpers/proxmox_vm_attrs_helper.rb

@@ -62,7 +62,7 @@ module ProxmoxVMAttrsHelper
         keys = ['id', 'volid', 'storage', 'size', 'storage_type']
         type = 'rootfs'
       elsif vol.hard_disk?
-        keys = ['id', 'volid', 'storage_type', 'storage', 'controller', 'device', 'cache', 'size']
+        keys = ['id', 'volid', 'storage_type', 'storage', 'controller', 'device', 'cache', 'size', '_delete']
         type = 'hard_disk'
       elsif  vol.cdrom?
         keys = ['id', 'storage_type', 'cdrom', 'storage', 'volid']
@@ -82,7 +82,7 @@ module ProxmoxVMAttrsHelper
   def vol_keys(param_scope, keys, vol, id)
     attrs = ActiveSupport::HashWithIndifferentAccess.new
     keys.each do |key|
-      camel_key = key.to_s.include?('_') ? snake_to_camel(key.to_s).to_sym : key
+      camel_key = key.to_s.include?('_') && key.to_s != '_delete' ? snake_to_camel(key.to_s).to_sym : key
       attrs[camel_key] = { :name => "#{param_scope}[volumes_attributes][#{id}][#{key}]", :value => vol.public_send(key) }
     end
     attrs

data/app/models/foreman_fog_proxmox/proxmox.rb

@@ -151,7 +151,7 @@ module ForemanFogProxmox
     def client
       @client ||= ::Fog::Proxmox::Compute.new(fog_credentials)
     rescue Excon::Errors::Unauthorized => e
-      raise ::Foreman::Exception, 'User token expired' if token_expired?(e)
+      raise ::Foreman::Exception, token_expired?(e) ? 'User token expired' : "Authentication Failure: #{error_message(e)}"
     rescue StandardError => e
       logger.warn("failed to create compute client: #{e}")
       raise ::Foreman::Exception, error_message(e)
@@ -160,7 +160,7 @@ module ForemanFogProxmox
     def identity_client
       @identity_client ||= ::Fog::Proxmox::Identity.new(fog_credentials)
     rescue Excon::Errors::Unauthorized => e
-      raise ::Foreman::Exception, 'User token expired' if token_expired?(e)
+      raise ::Foreman::Exception, token_expired?(e) ? 'User token expired' : "Authentication Failure: #{error_message(e)}"
     rescue StandardError => e
       logger.warn("failed to create identity client: #{e}")
       raise ::Foreman::Exception, error_message(e)
@@ -169,14 +169,14 @@ module ForemanFogProxmox
     def network_client
       @network_client ||= ::Fog::Proxmox::Network.new(fog_credentials)
     rescue Excon::Errors::Unauthorized => e
-      raise ::Foreman::Exception, 'User token expired' if token_expired?(e)
+      raise ::Foreman::Exception, token_expired?(e) ? 'User token expired' : "Authentication Failure: #{error_message(e)}"
     rescue StandardError => e
       logger.warn("failed to create network client: #{e}")
       raise ::Foreman::Exception, error_message(e)
     end
 
     def error_message(e)
-      "Failed to create Proxmox compute resource: #{e.message}.
+      "Failed to create Proxmox compute resource: #{e.response.reason_phrase}.
        Either provided credentials or FQDN is wrong or
        your server cannot connect to Proxmox due to network issues."
     end

data/app/models/foreman_fog_proxmox/proxmox_connection.rb

@@ -56,11 +56,11 @@ module ForemanFogProxmox
       identity_client
       version_suitable?
     rescue StandardError => e
-      errors[:base] << e.message
+      errors.add(:base, e.message)
       if e.message.include?('SSL')
-        errors[:ssl_certs] << e.message
+        errors.add(:ssl_certs, e.message)
       else
-        errors[:url] << e.message
+        errors.add(:url, e.message)
       end
     end
 

data/app/models/foreman_fog_proxmox/proxmox_interfaces.rb

@@ -18,7 +18,6 @@
 # along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
 
 require 'fog/proxmox/helpers/ip_helper'
-require 'net/validations'
 
 module ForemanFogProxmox
   module ProxmoxInterfaces

data/app/models/foreman_fog_proxmox/proxmox_version.rb

@@ -36,6 +36,7 @@ module ForemanFogProxmox
       v = identity_client.read_version if identity_client
       v ? v['version'] : 'Unknown'
     rescue ::Foreman::Exception => e
+      logger.warn("Foreman::Exception => failed to fetch identity client version: #{e}")
       'Unkown' if e.message == 'User token expired'
     rescue StandardError => e
       logger.warn("failed to get identity client version: #{e}")

data/app/views/compute_resources_vms/form/proxmox/_base.html.erb

@@ -24,7 +24,7 @@ along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>. %>
     <%= select_f f, :image_id, images, :uuid, :name, { :include_blank => true },
       :disabled => true,
       :help_inline => :indicator,
-      :class => ('hide' if from_profile),
+      :class => ("without_select2 #{'hide' if from_profile}"),
       :label => _('Image'),
       :no_label => from_profile,
       :label_size => "col-md-2" %>

data/app/views/templates/provisioning/user_data/proxmox_user_data.erb

@@ -110,7 +110,7 @@ ethernets:
     addresses:
       - <%= @host.ip %>/<%= @host.subnet.cidr %>
     routes:
-      - to: 0.0.0.0
+      - to: 0.0.0.0/0
         via: <%= @host.subnet.gateway %>
     nameservers:
       addresses:

data/lib/foreman_fog_proxmox/engine.rb

@@ -33,7 +33,7 @@ module ForemanFogProxmox
     initializer 'foreman_fog_proxmox.register_plugin', :before => :finisher_hook do |app|
       app.reloader.to_prepare do
         Foreman::Plugin.register :foreman_fog_proxmox do
-          requires_foreman '>= 1.22.0'
+          requires_foreman '>= 3.15'
           # Add Global files for extending foreman-core components and routes
           register_global_js_file 'global'
           # Register Proxmox VE compute resource in foreman

data/lib/foreman_fog_proxmox/version.rb

@@ -18,5 +18,5 @@
 # along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
 
 module ForemanFogProxmox
-  VERSION = '0.17.1'
+  VERSION = '0.19.0'
 end

data/package.json

@@ -5,7 +5,7 @@
   "main": "index.js",
   "scripts": {
     "lint": "tfm-lint --plugin -d webpack",
-    "test": "tfm-test --config jest.config.js",
+    "test": "tfm-test --plugin --passWithNoTests",
     "test:watch": "tfm-test --plugin --watchAll",
     "test:current": "tfm-test --plugin --watch",
     "publish-coverage": "tfm-publish-coverage",
@@ -21,18 +21,18 @@
     "url": "http://projects.theforeman.org/projects/foreman_fog_proxmox/issues"
   },
   "peerDependencies": {
-    "@theforeman/vendor": "^12.0.1"
+    "@theforeman/vendor": "^15.0.1"
   },
   "dependencies": {
     "react-intl": "^2.8.0"
   },
   "devDependencies": {
     "@babel/core": "^7.7.0",
-    "@theforeman/builder": ">= 12.0.1",
-    "@theforeman/eslint-plugin-foreman": ">= 12.0.1",
-    "@theforeman/find-foreman": ">= 12.0.1",
-    "@theforeman/test": ">= 12.0.1",
-    "@theforeman/vendor-dev": ">= 12.0.1",
+    "@theforeman/builder": ">= 15.0.1",
+    "@theforeman/eslint-plugin-foreman": ">= 15.0.1",
+    "@theforeman/find-foreman": ">= 15.0.1",
+    "@theforeman/test": ">= 15.0.1",
+    "@theforeman/vendor-dev": ">= 15.0.1",
     "babel-eslint": "^10.0.3",
     "eslint": "^6.7.2",
     "prettier": "^1.19.1",

data/webpack/components/ProxmoxContainer/MountPoint.js

@@ -53,7 +53,7 @@ const MountPoint = ({ id, data, storagesMap }) => {
       <InputField
         label={__('Device')}
         name={mp?.device?.name}
-        disabled
+        readOnly
         value={mp?.device?.value}
         onChange={handleChange}
         tooltip={__('Device value is set automatically.')}

data/webpack/components/ProxmoxContainer/ProxmoxContainerHardware.js

@@ -20,7 +20,9 @@ const ProxmoxContainerHardware = ({ hardware }) => {
   return (
     <div>
       <PageSection padding={{ default: 'noPadding' }}>
-        <Title headingLevel="h3">{__('CPU')}</Title>
+        <Title ouiaId="proxmox-container-hardware-cpu" headingLevel="h3">
+          {__('CPU')}
+        </Title>
         <Divider component="li" style={{ marginBottom: '2rem' }} />
         <InputField
           name={hw?.arch?.name}
@@ -53,7 +55,9 @@ const ProxmoxContainerHardware = ({ hardware }) => {
         />
       </PageSection>
       <PageSection padding={{ default: 'noPadding' }}>
-        <Title headingLevel="h3">{__('Memory')}</Title>
+        <Title ouiaId="proxmox-container-hardware-memory" headingLevel="h3">
+          {__('Memory')}
+        </Title>
         <Divider component="li" style={{ marginBottom: '2rem' }} />
         <InputField
           name={hw?.memory?.name}

data/webpack/components/ProxmoxContainer/ProxmoxContainerNetwork.js

@@ -129,7 +129,11 @@ const ProxmoxContainerNetwork = ({ network, bridges, paramScope }) => {
   return (
     <div>
       <PageSection padding={{ default: 'noPadding' }}>
-        <Button onClick={addInterface} variant="secondary">
+        <Button
+          ouiaId="proxmox-container-network-interface"
+          onClick={addInterface}
+          variant="secondary"
+        >
           {__('Add Interface')}
         </Button>
         {interfaces.map(nic => (
@@ -142,7 +146,7 @@ const ProxmoxContainerNetwork = ({ network, bridges, paramScope }) => {
                 alignItems: 'center',
               }}
             >
-              <Title headingLevel="h4">
+              <Title ouiaId="proxmox-container-network-nic" headingLevel="h4">
                 {sprintf(__('Nic %(nicId)s'), { nicId: nic.id })}
               </Title>
               <button onClick={() => removeInterface(nic.id)} type="button">

data/webpack/components/ProxmoxContainer/ProxmoxContainerStorage.js

@@ -112,7 +112,9 @@ const ProxmoxContainerStorage = ({ storage, storages, nodeId, paramScope }) => {
   return (
     <div>
       <PageSection padding={{ default: 'noPadding' }}>
-        <Title headingLevel="h3">{__('Rootfs')}</Title>
+        <Title ouiaId="proxmox-container-storage-rootfs" headingLevel="h3">
+          {__('Rootfs')}
+        </Title>
         <Divider component="li" style={{ marginBottom: '2rem' }} />
         <InputField
           name={rootfs?.storage?.name}
@@ -142,9 +144,15 @@ const ProxmoxContainerStorage = ({ storage, storages, nodeId, paramScope }) => {
         />
       </PageSection>
       <PageSection padding={{ default: 'noPadding' }}>
-        <Title headingLevel="h3">Storage</Title>
+        <Title ouiaId="proxmox-container-storage-title" headingLevel="h3">
+          Storage
+        </Title>
         <Divider component="li" style={{ marginBottom: '2rem' }} />
-        <Button onClick={addMountPoint} variant="secondary">
+        <Button
+          ouiaId="proxmox-container-storage-mountpoint-button"
+          onClick={addMountPoint}
+          variant="secondary"
+        >
           {__('Add MountPoint')}
         </Button>
         {mountPoints.map(mountPoint => (
@@ -157,7 +165,10 @@ const ProxmoxContainerStorage = ({ storage, storages, nodeId, paramScope }) => {
                 alignItems: 'center',
               }}
             >
-              <Title headingLevel="h4">
+              <Title
+                ouiaId="proxmox-container-storage-mountpoint-title"
+                headingLevel="h4"
+              >
                 {sprintf(__('Mount Point %(mp)s'), { mp: mountPoint.id })}
               </Title>
               <button onClick={() => removeMountPoint(mountPoint.id)}>

data/webpack/components/ProxmoxServer/ProxmoxServerHardware.js

@@ -91,7 +91,9 @@ const ProxmoxServerHardware = ({ hardware }) => {
   return (
     <div>
       <PageSection padding={{ default: 'noPadding' }}>
-        <Title headingLevel="h3">{__('CPU')}</Title>
+        <Title ouiaId="proxmox-server-hardware-cpu" headingLevel="h3">
+          {__('CPU')}
+        </Title>
         <Divider component="li" style={{ marginBottom: '2rem' }} />
         <InputField
           name={hw?.cpuType?.name}
@@ -145,7 +147,11 @@ const ProxmoxServerHardware = ({ hardware }) => {
           onChange={handleChange}
         />
         <div style={{ marginLeft: '5%', display: 'inline-block' }}>
-          <Button variant="link" onClick={handleModalToggle}>
+          <Button
+            ouiaId="proxmox-server-hardware-cpu-flags"
+            variant="link"
+            onClick={handleModalToggle}
+          >
             {__('Extra CPU Flags')}
           </Button>
         </div>
@@ -165,7 +171,9 @@ const ProxmoxServerHardware = ({ hardware }) => {
         ))}
       </PageSection>
       <PageSection padding={{ default: 'noPadding' }}>
-        <Title headingLevel="h3">{__('Memory')}</Title>
+        <Title ouiaId="proxmox-server-hardware-memory" headingLevel="h3">
+          {__('Memory')}
+        </Title>
         <Divider component="li" style={{ marginBottom: '2rem' }} />
         <InputField
           name={hw?.memory?.name}

data/webpack/components/ProxmoxServer/ProxmoxServerNetwork.js

@@ -111,7 +111,11 @@ const ProxmoxServerNetwork = ({ network, bridges, paramScope }) => {
   return (
     <div>
       <PageSection padding={{ default: 'noPadding' }}>
-        <Button onClick={addInterface} variant="secondary">
+        <Button
+          ouiaId="proxmox-server-network-interface"
+          onClick={addInterface}
+          variant="secondary"
+        >
           {__('Add Interface')}
         </Button>
         {interfaces.map(nic => (
@@ -124,7 +128,7 @@ const ProxmoxServerNetwork = ({ network, bridges, paramScope }) => {
                 alignItems: 'center',
               }}
             >
-              <Title headingLevel="h4">
+              <Title ouiaId="proxmox-server-network-nic" headingLevel="h4">
                 {sprintf(__('Nic %(nicId)s'), { nicId: nic.id })}
               </Title>
               <button onClick={() => removeInterface(nic.id)} type="button">

data/webpack/components/ProxmoxServer/ProxmoxServerStorage.js

@@ -140,6 +140,7 @@ const ProxmoxServerStorage = ({ storage, storages, paramScope, nodeId }) => {
           storages,
           data: initHdd,
           disks: storage,
+          isNew: !isPreExisting,
         };
         setHardDisks(prevHardDisks => [...prevHardDisks, newHardDisk]);
         return newNextId;
@@ -149,9 +150,11 @@ const ProxmoxServerStorage = ({ storage, storages, paramScope, nodeId }) => {
   );
 
   const removeHardDisk = idToRemove => {
-    const newHardDisks = hardDisks.filter(
-      hardDisk => hardDisk.id !== idToRemove
-    );
+    const newHardDisks = hardDisks
+      .filter(hardDisk => !(hardDisk.id === idToRemove && hardDisk.isNew))
+      .map(hardDisk =>
+        hardDisk.id === idToRemove ? { ...hardDisk, hidden: true } : hardDisk
+      );
     setHardDisks(newHardDisks);
   };
 
@@ -207,12 +210,21 @@ const ProxmoxServerStorage = ({ storage, storages, paramScope, nodeId }) => {
   return (
     <div>
       <PageSection padding={{ default: 'noPadding' }}>
-        <Button onClick={addCDRom} variant="secondary" isDisabled={cdRom}>
+        <Button
+          ouiaId="proxmox-server-storage-cdrom"
+          onClick={addCDRom}
+          variant="secondary"
+          isDisabled={cdRom}
+        >
           {' '}
           {__('Add CD-ROM')}
         </Button>
         {'  '}
-        <Button onClick={addHardDisk} variant="secondary">
+        <Button
+          ouiaId="proxmox-server-storage-harddisk"
+          onClick={addHardDisk}
+          variant="secondary"
+        >
           {__('Add HardDisk')}
         </Button>
         {cdRom && cdRomData && (
@@ -224,7 +236,13 @@ const ProxmoxServerStorage = ({ storage, storages, paramScope, nodeId }) => {
           />
         )}
         {hardDisks.map(hardDisk => (
-          <div style={{ position: 'relative' }}>
+          <div
+            key={hardDisk.id}
+            style={{
+              position: 'relative',
+              display: hardDisk.hidden ? 'none' : 'block',
+            }}
+          >
             <div
               style={{
                 marginTop: '10px',
@@ -233,7 +251,7 @@ const ProxmoxServerStorage = ({ storage, storages, paramScope, nodeId }) => {
                 alignItems: 'center',
               }}
             >
-              <Title headingLevel="h4">
+              <Title ouiaId="proxmox-server-storage-harddisk" headingLevel="h4">
                 {sprintf(__('Hard Disk %(hddId)s'), { hddId: hardDisk.id })}
               </Title>
               <button onClick={() => removeHardDisk(hardDisk.id)} type="button">
@@ -247,6 +265,7 @@ const ProxmoxServerStorage = ({ storage, storages, paramScope, nodeId }) => {
               disks={hardDisk.disks}
               updateHardDiskData={updateHardDiskData}
               createUniqueDevice={createUniqueDevice}
+              hidden={hardDisk.hidden ? true : ''}
             />
           </div>
         ))}

data/webpack/components/ProxmoxServer/components/CDRom.js

@@ -51,7 +51,9 @@ const CDRom = ({ onRemove, data, storages, nodeId }) => {
           alignItems: 'center',
         }}
       >
-        <Title headingLevel="h4">{__('CD-ROM')}</Title>
+        <Title ouiaId="proxmox-server-cdrom-title" headingLevel="h4">
+          {__('CD-ROM')}
+        </Title>
         <button onClick={onRemove}>
           <TimesIcon />
         </button>
@@ -64,38 +66,45 @@ const CDRom = ({ onRemove, data, storages, nodeId }) => {
           alignItems: 'center',
         }}
       >
-        <Title headingLevel="h5">{__('Media')}</Title>
+        <Title ouiaId="proxmox-server-cdrom-media-title" headingLevel="h5">
+          {__('Media')}
+        </Title>
       </div>
       <Divider component="li" style={{ marginBottom: '1rem' }} />
       <div style={{ display: 'flex', gap: '1rem' }}>
         <Radio
+          ouiaId="proxmox-server-cdrom-media-none"
           id="radio-none"
           name={cdrom?.cdrom?.name}
           label={__('None')}
           value="none"
           isChecked={cdrom?.cdrom?.value === 'none'}
-          onChange={handleMediaChange}
+          onChange={(e, _) => handleMediaChange(_, e)}
         />
         <Radio
+          ouiaId="proxmox-server-cdrom-media-physical"
           id="radio-physical"
           name={cdrom?.cdrom?.name}
           label={__('Physical')}
           value="physical"
           isChecked={cdrom?.cdrom?.value === 'physical'}
-          onChange={handleMediaChange}
+          onChange={(e, _) => handleMediaChange(_, e)}
         />
         <Radio
+          ouiaId="proxmox-server-cdrom-media-image"
           id="radio-image"
           name={cdrom?.cdrom?.name}
           label={__('Image')}
           value="image"
           isChecked={cdrom?.cdrom?.value === 'image'}
-          onChange={handleMediaChange}
+          onChange={(e, _) => handleMediaChange(_, e)}
         />
       </div>
       {cdrom?.cdrom?.value === 'image' && (
         <PageSection padding={{ default: 'noPadding' }}>
-          <Title headingLevel="h5">{__('Image')}</Title>
+          <Title ouiaId="proxmox-server-cdrom-image-title" headingLevel="h5">
+            {__('Image')}
+          </Title>
           <Divider component="li" style={{ marginBottom: '2rem' }} />
           <InputField
             label={__('Storage')}

data/webpack/components/ProxmoxServer/components/CPUFlagsModal.js

@@ -1,7 +1,7 @@
 import React from 'react';
 import { Modal, Button } from '@patternfly/react-core';
 import { translate as __ } from 'foremanReact/common/I18n';
-import { Table, Thead, Tr, Th, Tbody, Td } from '@patternfly/react-table';
+import { Thead, Tr, Th, Tbody, Td, Table } from '@patternfly/react-table';
 import PropTypes from 'prop-types';
 import ProxmoxComputeSelectors from '../../ProxmoxComputeSelectors';
 
@@ -20,6 +20,7 @@ const CPUFlagsModal = ({ isOpen, onClose, flags, handleChange }) => {
   return (
     <div>
       <Modal
+        ouiaId="proxmox-server-cpu-flags"
         bodyAriaLabel="Scrollable modal content"
         width="60%"
         tabIndex={0}
@@ -27,17 +28,31 @@ const CPUFlagsModal = ({ isOpen, onClose, flags, handleChange }) => {
         isOpen={isOpen}
         onClose={onClose}
         actions={[
-          <Button key="confirm" variant="primary" onClick={onClose}>
+          <Button
+            ouiaId="proxmox-server-cpu-flags-confirm"
+            key="confirm"
+            variant="primary"
+            onClick={onClose}
+          >
             {__('Confirm')}
           </Button>,
-          <Button key="reset" variant="secondary" onClick={resetFlags}>
+          <Button
+            ouiaId="proxmox-server-cpu-flags-reset"
+            key="reset"
+            variant="secondary"
+            onClick={resetFlags}
+          >
             {__('Reset')}
           </Button>,
         ]}
       >
-        <Table aria-label="Simple table" variant="compact">
+        <Table
+          ouiaId="proxmox-server-cpu-flags-table"
+          aria-label="Simple table"
+          variant="compact"
+        >
           <Thead>
-            <Tr>
+            <Tr ouiaId="proxmox-server-cpu-flags-tr1">
               <Th>Name</Th>
               <Th />
               <Th>Description</Th>
@@ -47,7 +62,7 @@ const CPUFlagsModal = ({ isOpen, onClose, flags, handleChange }) => {
             {Object.keys(flags).map(key => {
               const item = flags[key];
               return (
-                <Tr key={item.label}>
+                <Tr ouiaId="proxmox-server-cpu-flags-tr2" key={item.label}>
                   <Td>{item.label}</Td>
                   <Td>
                     <select

data/webpack/components/ProxmoxServer/components/HardDisk.js

@@ -13,6 +13,7 @@ const HardDisk = ({
   disks,
   updateHardDiskData,
   createUniqueDevice,
+  hidden,
   nodeId,
 }) => {
   const [hdd, setHdd] = useState(data);
@@ -107,7 +108,7 @@ const HardDisk = ({
         name={hdd?.device?.name}
         value={hdd?.device?.value}
         onChange={handleChange}
-        disabled
+        readOnly
         tooltip={__('Device value is set automatically.')}
       />
       <InputField
@@ -125,6 +126,7 @@ const HardDisk = ({
         value={hdd?.size?.value}
         onChange={handleChange}
       />
+      <input name={hdd?._delete?.name} type="hidden" value={hidden} />
     </div>
   );
 };
@@ -134,6 +136,7 @@ HardDisk.propTypes = {
   data: PropTypes.object,
   storages: PropTypes.array,
   disks: PropTypes.array,
+  hidden: PropTypes.bool,
   updateHardDiskData: PropTypes.func,
   createUniqueDevice: PropTypes.func,
   nodeId: PropTypes.string,
@@ -144,6 +147,7 @@ HardDisk.defaultProps = {
   storages: [],
   disks: [],
   nodeId: '',
+  hidden: 'false',
   updateHardDiskData: Function.prototype,
   createUniqueDevice: Function.prototype,
 };

data/webpack/components/ProxmoxVmType.js

@@ -162,12 +162,14 @@ const ProxmoxVmType = ({
         type="select"
       />
       <Tabs
+        ouiaId="proxmox-vm-type-tabs-options"
         activeKey={activeTabKey}
         onSelect={handleTabClick}
         aria-label="Options tabs"
         role="region"
       >
         <Tab
+          ouiaId="proxmox-vm-type-tab-general"
           eventKey={0}
           title={<TabTitleText>{__('General')}</TabTitleText>}
           aria-label="Default content - general"
@@ -184,6 +186,7 @@ const ProxmoxVmType = ({
           />
         </Tab>
         <Tab
+          ouiaId="proxmox-vm-type-tab-advanced"
           eventKey={1}
           title={<TabTitleText>{__('Advanced Options')}</TabTitleText>}
           aria-label="advanced options"
@@ -194,6 +197,7 @@ const ProxmoxVmType = ({
           </PageSection>
         </Tab>
         <Tab
+          ouiaId="proxmox-vm-type-tab-hardware"
           eventKey={2}
           title={<TabTitleText>{__('Hardware')}</TabTitleText>}
           aria-label="hardware"
@@ -205,6 +209,7 @@ const ProxmoxVmType = ({
         </Tab>
         {fromProfile && (
           <Tab
+            ouiaId="proxmox-vm-type-tab-network"
             eventKey={3}
             title={<TabTitleText>{__('Network Interfaces')}</TabTitleText>}
             aria-label="Network interface"
@@ -216,6 +221,7 @@ const ProxmoxVmType = ({
           </Tab>
         )}
         <Tab
+          ouiaId="proxmox-vm-type-tab-storage"
           eventKey={4}
           title={<TabTitleText>{__('Storage')}</TabTitleText>}
           aria-label="storage"

data/webpack/components/common/FormInputs.js

@@ -13,6 +13,7 @@ const InputField = ({
   required,
   type,
   disabled,
+  readOnly,
   options,
   checked,
   error,
@@ -40,6 +41,7 @@ const InputField = ({
       renderComponent = (
         <select
           disabled={disabled}
+          readOnly={readOnly}
           name={name}
           className="without_select2 form-control"
           value={value}
@@ -59,6 +61,7 @@ const InputField = ({
           checked={checked}
           onChange={onChange}
           disabled={disabled}
+          readOnly={readOnly}
         />
       );
       break;
@@ -71,6 +74,7 @@ const InputField = ({
           value={value}
           onChange={onChange}
           disabled={disabled}
+          readOnly={readOnly}
         />
       );
       break;
@@ -122,6 +126,7 @@ InputField.propTypes = {
     'checkbox',
   ]),
   disabled: PropTypes.bool,
+  readOnly: PropTypes.bool,
   checked: PropTypes.bool,
   options: PropTypes.arrayOf(
     PropTypes.shape({
@@ -142,6 +147,7 @@ InputField.defaultProps = {
   required: false,
   type: 'text',
   disabled: false,
+  readOnly: false,
   checked: false,
   options: [],
   error: '',

metadata

@@ -1,15 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_fog_proxmox
 version: !ruby/object:Gem::Version
-  version: 0.17.1
+  version: 0.19.0
 platform: ruby
 authors:
 - Tristan Robert
 - The Foreman Team
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-11-07 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface
@@ -31,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.15'
+        version: 0.15.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.15'
+        version: 0.15.1
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
@@ -273,7 +272,6 @@ homepage: https://github.com/theforeman/foreman_fog_proxmox
 licenses:
 - GPL-3.0
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -288,34 +286,33 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
-signing_key: 
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Foreman plugin that adds Proxmox VE compute resource using fog-proxmox
 test_files:
+- test/factories/foreman_fog_proxmox/proxmox_container_mock_factory.rb
+- test/factories/foreman_fog_proxmox/proxmox_node_mock_factory.rb
+- test/factories/foreman_fog_proxmox/proxmox_server_mock_factory.rb
+- test/factories/proxmox_factory.rb
+- test/functional/compute_resources_controller_test.rb
 - test/test_plugin_helper.rb
-- test/unit/foreman_fog_proxmox/proxmox_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_vm_queries_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_cloudinit_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_vm_new_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_vm_commands_test.rb
+- test/unit/foreman_fog_proxmox/helpers/proxmox_container_helper_test.rb
+- test/unit/foreman_fog_proxmox/helpers/proxmox_server_helper_test.rb
+- test/unit/foreman_fog_proxmox/helpers/proxmox_vm_helper_test.rb
+- test/unit/foreman_fog_proxmox/helpers/proxmox_vm_uuid_helper_test.rb
+- test/unit/foreman_fog_proxmox/helpers/proxmox_vm_volumes_helper_test.rb
 - test/unit/foreman_fog_proxmox/proxmox_compute_attributes_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_images_test.rb
 - test/unit/foreman_fog_proxmox/proxmox_interfaces_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_version_test.rb
 - test/unit/foreman_fog_proxmox/proxmox_vm_commands_container_test.rb
-- test/unit/foreman_fog_proxmox/semver_test.rb
 - test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_create_test.rb
 - test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_cdrom_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_version_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_cloudinit_test.rb
 - test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_hard_disk_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_images_test.rb
 - test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_test.rb
-- test/unit/foreman_fog_proxmox/helpers/proxmox_server_helper_test.rb
-- test/unit/foreman_fog_proxmox/helpers/proxmox_container_helper_test.rb
-- test/unit/foreman_fog_proxmox/helpers/proxmox_vm_uuid_helper_test.rb
-- test/unit/foreman_fog_proxmox/helpers/proxmox_vm_helper_test.rb
-- test/unit/foreman_fog_proxmox/helpers/proxmox_vm_volumes_helper_test.rb
-- test/functional/compute_resources_controller_test.rb
-- test/factories/foreman_fog_proxmox/proxmox_server_mock_factory.rb
-- test/factories/foreman_fog_proxmox/proxmox_container_mock_factory.rb
-- test/factories/foreman_fog_proxmox/proxmox_node_mock_factory.rb
-- test/factories/proxmox_factory.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_commands_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_new_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_queries_test.rb
+- test/unit/foreman_fog_proxmox/semver_test.rb