foreman_fog_proxmox 0.15.0 → 0.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b41c2a927bcce7383e1fd55c588247e935e0c6e11ba967fe6628db72a80730df
-  data.tar.gz: ce7634ce750c8317bc28906e4394888d50b66931b9c77586f3af90c339ca07c2
+  metadata.gz: 66a00f7786605946bb2388d497b7a2f512fb29fcf00a12f35bc7059e8b0825f4
+  data.tar.gz: 3e2bf00ae5430cad3c5927ba4636582cd78d83cefa7065088fa4458da638b173
 SHA512:
-  metadata.gz: 65a3b9ac47bb382cc0c2b30430151a9db92bf64dcc9c64ed6c9fffb1fbb5dc525316d3475a7c5d88c21d30e3ffb8ad8eaf6ef5d6676cff53cfbd43dd5a086378
-  data.tar.gz: e210dad89239964322d0dc1b5f3a326a11f449ada2ad61d23f87f2047d421454020aa4b14ffed1efc173f31fd7cb0c68d92a76a9df0757133c810993a49a5a85
+  metadata.gz: 9534979808ea0e6ad262d696497189b3129e6594478601649d74d475ef1cee060898988e662d50db447f04257b6e6cdcfa6d2d144fea0ef498e66c3a899bd140
+  data.tar.gz: 981cfaa3815ce58182a465490541051b4a79612f0153e3419142bbf5e3c7e58c68b7758b2cac8eaa4bae31a428717d239315695b6847f2d1d207b04f26ff8a41

data/app/assets/javascripts/foreman_fog_proxmox/proxmox_vm.js

@@ -15,8 +15,6 @@
 // You should have received a copy of the GNU General Public License
 // along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
 
-//= require jquery-ui/widgets/accordion
-
 $(document).ready(vmTypeSelected);
 
 function vmTypeSelected() {
@@ -25,13 +23,21 @@ function vmTypeSelected() {
   var host_uuid = $("input[id='host_uuid']").val();
   var new_vm =  host_uuid == undefined;
   var fieldsets = [];
+  var fieldconfig = [];
   fieldsets.push({id: 'config_advanced_options', toggle: true, new_vm: new_vm, selected: selected});
   fieldsets.push({id: 'config_ext', toggle: true, new_vm: new_vm, selected: selected});
   fieldsets.push({id: 'volume', toggle: true, new_vm: new_vm, selected: selected});
   fieldsets.push({id: 'network', toggle: true, new_vm: true, selected: selected});
+  fieldconfig.push({id: 'config_options', new_vm: new_vm, selected: selected});
+  fieldconfig.push({id: 'config_cpu', new_vm: new_vm, selected: selected});
+  fieldconfig.push({id: 'config_memory', new_vm: new_vm, selected: selected});
+  fieldconfig.push({id: 'config_cdrom', new_vm: new_vm, selected: selected});
+  fieldconfig.push({id: 'config_os', new_vm: new_vm, selected: selected});
+  fieldconfig.push({id: 'config_dns', new_vm: new_vm, selected: selected});
   fieldsets.forEach(toggleFieldsets);
-  toggleAccordion(selected);
   toggleVolumes(selected);
+  fieldconfig.forEach(toggleConfigs);
+  toggleAccordions();
   return false;
 }
 
@@ -131,7 +137,7 @@ function enableFieldset(fieldsetId, fieldset) {
   input_hidden_id(fieldsetId).removeAttr('disabled');
 }
 
-function disableFieldset(fieldsetId, fieldset) {  
+function disableFieldset(fieldsetId, fieldset) {
   if (fieldset.toggle && fieldset.new_vm){
     fieldset_id(fieldsetId, fieldset).hide();
   }
@@ -139,57 +145,72 @@ function disableFieldset(fieldsetId, fieldset) {
   input_hidden_id(fieldsetId).attr('disabled','disabled');
 }
 
-function enableConfigOptions(fieldsetId) {
-  var field = $("#" + fieldsetId + "_advanced_options");
-  field.accordion({collapsible : true, heightStyle: "content"});
-  field.removeClass('disabled').find("*").prop("disabled", false);
-  field.removeClass('hide');
+function toggleFieldset(fieldsetId, fieldset, type1, type2) {
+  type1 === type2 ? enableFieldset(fieldsetId, fieldset) : disableFieldset(fieldsetId, fieldset);
 }
 
-function disableConfigOptions(fieldsetId) {
-  var field = $("#" + fieldsetId + "_advanced_options");
-  field.addClass('disabled').find("*").prop("disabled", true);
-  field.addClass('hide');
+function input_hidden_id(volume_id){
+  return $("div[id^='"+ volume_id +"_volumes']" + " + input:hidden");
 }
 
-function toggleConfigOptions(fieldsetId, type1, type2) {
-  if (type1 === type2) {
-    enableConfigOptions(fieldsetId);
-  } else {
-    disableConfigOptions(fieldsetId);
-  }
+function fieldset_id(fieldsetId, fieldset){
+  return $("fieldset[id^='" + fieldsetId + "_"+fieldset.id+"']");
 }
 
-function toggleAccordion(selected){
+function fieldsets(type){
+  return type === 'qemu' ? ['server'] : ['container'];
+}
+
+function toggleFieldsets(fieldset){
+  var removable_input_hidden = $("div.removable-item[style='display: none;']" + " + input:hidden");
+  removable_input_hidden.attr('disabled','disabled');
   ['qemu', 'lxc'].forEach(function(type){
     fieldsets(type).forEach(function(fieldsetId){
-      toggleConfigOptions(fieldsetId, selected, type);
+      toggleFieldset(fieldsetId, fieldset, fieldset.selected, type);
     });
   });
 }
 
-function toggleFieldset(fieldsetId, fieldset, type1, type2) {  
-  type1 === type2 ? enableFieldset(fieldsetId, fieldset) : disableFieldset(fieldsetId, fieldset);
+function toggleAccordions() {
+  $('.accordion-content').hide();
+  $('.accordion-section').off('click').on('click', function(event) {
+    var $content = $(this).find('.accordion-content');
+    $content.slideToggle();
+    $(this).toggleClass('active');
+    $('.accordion-content').not($content).slideUp();
+    $('.accordion-section').not($(this)).removeClass('active');
+    event.stopPropagation();
+  });
+  $('.accordion-content').on('click', function(event) {
+    event.stopPropagation();
+  });
 }
 
-function input_hidden_id(volume_id){
-  return $("div[id^='"+ volume_id +"_volumes']" + " + input:hidden");
+function enableConfig(fieldsetId, fieldset) {
+  fieldset_id(fieldsetId, fieldset).removeClass('hide');
+  fieldset_id(fieldsetId, fieldset).removeAttr('disabled');
+  input_hidden_id(fieldsetId).removeAttr('disabled');
+
 }
 
-function fieldset_id(fieldsetId, fieldset){
-  return $("fieldset[id^='" + fieldsetId + "_"+fieldset.id+"']");
+function disableConfig(fieldsetId, fieldset) {
+  fieldset_id(fieldsetId, fieldset).addClass('hide');
+  fieldset_id(fieldsetId, fieldset).attr('disabled','disabled');
+  input_hidden_id(fieldsetId).attr('disabled','disabled');
 }
 
-function fieldsets(type){
-  return type === 'qemu' ? ['server'] : ['container'];
+function toggleConfig(fieldsetId, fieldset, type1, type2) {
+  if (type1 === type2) {
+    enableConfig(fieldsetId, fieldset);
+  } else {
+    disableConfig(fieldsetId, fieldset);
+  }
 }
 
-function toggleFieldsets(fieldset){
-  var removable_input_hidden = $("div.removable-item[style='display: none;']" + " + input:hidden");
-  removable_input_hidden.attr('disabled','disabled');  
+function toggleConfigs(fieldset){
   ['qemu', 'lxc'].forEach(function(type){
     fieldsets(type).forEach(function(fieldsetId){
-      toggleFieldset(fieldsetId, fieldset, fieldset.selected, type);
+      toggleConfig(fieldsetId, fieldset, fieldset.selected, type);
     });
   });
 }

data/app/assets/javascripts/foreman_fog_proxmox/proxmox_vm_server.js

@@ -32,7 +32,7 @@ function getIndex(item) {
 }
 
 function isProfile() {
-  return $(volumesAttributesSelector(true,0,'id')) !== undefined;
+  return $(volumesAttributesSelector(true,0,'id')).val() !== undefined;
 }
 
 function controllerSelected(item) {
@@ -42,23 +42,43 @@ function controllerSelected(item) {
   var profile = isProfile();
   var device_selector = volumesAttributesSelector(profile,index,'device');
   var id_selector = volumesAttributesSelector(profile,index,'id');
-  $(device_selector).attr('data-soft-max', max);
-  var device = $(device_selector).limitedSpinner('value');
+  var device = $(device_selector).val();
   var id = controller + device;
+  validateDeviceLimit(device_selector, max);
   $(id_selector).val(id);
 }
 
 function deviceSelected(item) {
-  var device = $(item).limitedSpinner('value');
+  var device = $(item).val();
   var index = getIndex(item);
   var profile = isProfile();
   var controller_selector = volumesAttributesSelector(profile,index,'controller');
   var id_selector = volumesAttributesSelector(profile,index,'id');
   var controller = $(controller_selector).val();
   var id = controller + device;
+  var max = computeControllerMaxDevice(controller);
+  validateDeviceLimit(item, max);
   $(id_selector).val(id);
 }
 
+function validateDeviceLimit(item, maxLimit) {
+  var warningContainer = $(item).closest('form').find('.warning-container');
+  var deviceNumber = $(item).val();
+  var submitButton = $(item).closest('form').find('[data-disable-with]');
+  if (!isNaN(maxLimit) && !isNaN(deviceNumber) && deviceNumber > maxLimit) {
+    if (warningContainer.length === 0) {
+      warningContainer = $('<div class="warning-container" style="color: red;"><span style="color: red;">&#9888;</span> Warning: Value exceeds the maximum limit of ' + maxLimit + '.</div>');
+      $(item).closest('.col-md-4').append(warningContainer);
+    }
+    warningContainer.show();
+    submitButton.prop('disabled', true);
+  } else {
+    warningContainer.hide();
+    warningContainer.remove();
+    submitButton.prop('disabled', false);
+  }
+}
+
 function computeControllerMaxDevice(controller) {
   switch (controller) {
     case 'ide':
@@ -72,4 +92,4 @@ function computeControllerMaxDevice(controller) {
     default:
       return 1;
   }
-}
+}

data/app/assets/stylesheets/foreman_fog_proxmox/accordion.css

@@ -0,0 +1,21 @@
+.accordion-section {
+   cursor: pointer;
+}
+
+.accordion-section > legend::before {
+    content: "\f054";
+    font-family: "Font Awesome 5 Free";
+    position: relative;
+    left: -1em;
+    top: 50%;
+    transform: translateY(-50%);
+}
+
+.accordion-section.active > legend::before {
+    content: "\f078";
+    font-family: "Font Awesome 5 Free";
+    position: relative;
+    left: -1em;
+    top: 50%;
+    transform: translateY(-50%);
+}

data/app/helpers/proxmox_compute_resources_helper.rb

@@ -34,7 +34,7 @@ module ProxmoxComputeResourcesHelper
   def cluster_nodes(compute_resource)
     nodes = compute_resource.nodes ? compute_resource.nodes.collect(&:node) : []
   rescue ::Foreman::Exception => e
-    return [] if e.message == 'User token expired'
+    [] if e.message == 'User token expired'
   rescue StandardError => e
     logger.warn("failed to get cluster nodes: #{e}")
     raise e

data/app/helpers/proxmox_form_helper.rb

@@ -30,7 +30,7 @@ module ProxmoxFormHelper
         addClass options, 'form-control'
         pass = f.password_field(attr, options) +
                tag(:span, '', class: 'glyphicon glyphicon-warning-sign input-addon', title: 'Caps lock ON',
-style: 'display:none')
+                 style: 'display:none')
         if unset_button
           button = link_to_function(icon_text('edit', '', :kind => 'pficon'), 'toggle_input_group(this)',
             :id => 'disable-pass-btn', :class => 'btn btn-default', :title => _('Change the password'))
@@ -56,7 +56,7 @@ style: 'display:none')
     options[:form_builder_attrs] ||= {}
 
     content_tag(:div, :class => "#{options[:type]}_#{association}_fields_template form_template",
-:style => 'display: none;') do
+      :style => 'display: none;') do
       form_builder.fields_for(association, options[:object],
         :child_index => "new_#{options[:type]}_#{association}") do |f|
         render(:partial => options[:partial], :layout => options[:layout],

data/app/helpers/proxmox_vm_attrs_helper.rb

@@ -0,0 +1,131 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'fog/proxmox/helpers/disk_helper'
+require 'fog/proxmox/helpers/nic_helper'
+require 'fog/proxmox/helpers/cpu_helper'
+require 'foreman_fog_proxmox/value'
+require 'foreman_fog_proxmox/hash_collection'
+
+# Convert a foreman form server hash into a fog-proxmox server attributes hash
+module ProxmoxVmAttrsHelper
+  def object_to_attributes_hash(vms, from_profile, start_checked)
+    param_scope = from_profile ? "compute_attribute[vm_attrs]" : "host[compute_attributes]"
+    vm_h = ActiveSupport::HashWithIndifferentAccess.new
+    keys = [:vmid, :node_id, :type, :pool]
+    main = vms.attributes.select { |key, _value| keys.include? key }
+    vms.config.all_attributes.each do |key, value|
+      camel_key = key.to_s.include?('_') ? snake_to_camel(key.to_s).to_sym : key
+      vm_h[camel_key] = { :name => "#{param_scope}[config_attributes][#{key}]", :value => value } unless keys.include? key
+    end
+    main.each do |key, value|
+      camel_key = key.to_s.include?('_') ? snake_to_camel(key.to_s).to_sym : key
+      vm_h[camel_key] = { :name => "#{param_scope}[#{key}]", :value => value } if keys.include? key
+    end
+
+    vm_h.merge!(additional_attrs(vms, param_scope, start_checked))
+    vm_h[:interfaces] = network_attrs(param_scope, vms.interfaces)
+    vm_h[:disks] = volumes_attrs(param_scope, vms.volumes)
+    vm_h.merge(cpu_flags_attrs(param_scope, vms.config))
+  end
+
+  def cpu_flags_attrs(param_scope, config)
+    flag_attrs = ActiveSupport::HashWithIndifferentAccess.new
+    Fog::Proxmox::CpuHelper.flags.each do |key, _val|
+      flag_attrs.merge!({ key => { :name => "#{param_scope}[config_attributes][#{key}]", :value => config.public_send(key) } })
+    end
+    flag_attrs
+  end
+
+  def volumes_attrs(param_scope, volumes)
+    vol_attrs = []
+    volumes.each_with_index do |vol, id|
+      keys = []
+      type = ""
+      if vol.rootfs?
+        keys = ['id', 'volid', 'storage', 'size', 'storage_type']
+        type = 'rootfs'
+      elsif vol.hard_disk?
+        keys = ['id', 'volid', 'storage_type', 'storage', 'controller', 'device', 'cache', 'size']
+        type = 'hard_disk'
+      elsif  vol.cdrom?
+        keys = ['id', 'storage_type', 'cdrom', 'storage', 'volid']
+        type = 'cdrom'
+      elsif vol.cloud_init?
+        keys = ['id', 'volid', 'storage_type', 'storage', 'controller', 'device']
+        type = 'cloud_init'
+      elsif vol.mount_point?
+        keys = ['id', 'volid', 'storage_type', 'storage', 'device', 'mp', 'size']
+        type = 'mount_point'
+      end
+      vol_attrs << { :name => type, :value => vol_keys(param_scope, keys, vol, id) }
+    end
+    vol_attrs
+  end
+
+  def vol_keys(param_scope, keys, vol, id)
+    attrs = ActiveSupport::HashWithIndifferentAccess.new
+    keys.each do |key|
+      camel_key = key.to_s.include?('_') ? snake_to_camel(key.to_s).to_sym : key
+      attrs[camel_key] = { :name => "#{param_scope}[volumes_attributes][#{id}][#{key}]", :value => vol.public_send(key) }
+    end
+    attrs
+  end
+
+  def network_attrs(param_scope, interfaces)
+    networks_attrs = []
+    interfaces.each_with_index do |interface, id|
+      attrs = ActiveSupport::HashWithIndifferentAccess.new
+      interface.all_attributes.each do |key, value|
+        camel_key = key.to_s.include?('_') ? snake_to_camel(key.to_s).to_sym : key
+        attrs[camel_key] = { :name => "#{param_scope}[interfaces_attributes][#{id}][#{key}]", :value => value }
+      end
+      networks_attrs << { :name => 'interface', :value => attrs }
+    end
+    networks_attrs
+  end
+
+  def additional_attrs(vms, param_scope, start_checked)
+    attributes = {
+      pool: vms.pool,
+      image_id: vms.image_id,
+      cpu_type: vms.config.cpu_type,
+      nameserver: vms.config.nameserver,
+      searchdomain: vms.config.searchdomain,
+      hostname: vms.config.hostname,
+      ostemplate_storage: vms.ostemplate_storage,
+      ostemplate_file: vms.ostemplate_file,
+      start_after_create: vms.start_after_create,
+      templated: vms.templated,
+    }
+    vms_keys = [:pool, :start_after_create]
+    extra_attrs = ActiveSupport::HashWithIndifferentAccess.new
+    attributes.each do |key, value|
+      camel_key = key.to_s.include?('_') ? snake_to_camel(key.to_s).to_sym : key
+      nested_key = vms_keys.include?(key) ? key : "config_attributes[#{key}]"
+      value = start_checked if key == :start_after_create
+      extra_attrs[camel_key] = { name: "#{param_scope}[#{nested_key}]", value: value }
+    end
+    extra_attrs
+  end
+
+  def snake_to_camel(str)
+    str.split('_').inject([]) { |buffer, e| buffer.push(buffer.empty? ? e : e.capitalize) }.join
+  end
+end

data/app/helpers/proxmox_vm_cloudinit_helper.rb

@@ -48,7 +48,7 @@ module ProxmoxVmCloudinitHelper
     wd = create_temp_directory(ssh)
 
     configs.each do |config|
-      config_file = ssh.run(%(echo "#{config[1]}" >> "#{wd}/#{config[0]}"))
+      config_file = ssh.run(%(echo '#{config[1]}' >> "#{wd}/#{config[0]}"))
       unless config_file.first.status.zero?
         delete_temp_dir(ssh, wd)
         raise ::Foreman::Exception, "Failed to create file #{config[0]}: #{config_file.first.stdout}"

data/app/helpers/proxmox_vm_interfaces_helper.rb

@@ -56,13 +56,13 @@ module ProxmoxVmInterfacesHelper
   end
 
   def interface_common_typed_keys(type)
-    ['id', type == 'qemu' ? 'macaddr' : 'hwaddr']
+    ['id', (type == 'qemu') ? 'macaddr' : 'hwaddr']
   end
 
   def compute_dhcps(interface_attributes_h)
-    interface_attributes_h[:dhcp] = interface_attributes_h[:ip] == 'dhcp' ? '1' : '0'
+    interface_attributes_h[:dhcp] = (interface_attributes_h[:ip] == 'dhcp') ? '1' : '0'
     interface_attributes_h[:ip] = '' if interface_attributes_h[:dhcp] == '1'
-    interface_attributes_h[:dhcp6] = interface_attributes_h[:ip6] == 'dhcp' ? '1' : '0'
+    interface_attributes_h[:dhcp6] = (interface_attributes_h[:ip6] == 'dhcp') ? '1' : '0'
     interface_attributes_h[:ip6] = '' if interface_attributes_h[:dhcp6] == '1'
   end
 

data/app/helpers/proxmox_vm_volumes_helper.rb

@@ -52,9 +52,9 @@ module ProxmoxVmVolumesHelper
     logger.debug(format(_('parse_hard_disk_volume(): args=%<args>s'), args: args))
     disk = {}
     disk[:id] = args['id'] if args.key?('id')
-    disk[:volid] = args['volid'] if args.key?('volid')
-    disk[:storage] = args['storage'].to_s if args.key?('storage')
-    disk[:size] = args['size'].to_i if args.key?('size')
+    disk[:volid] = args['volid'] if args.key?('volid') && !args['volid'].empty?
+    disk[:storage] = args['storage'].to_s if args.key?('storage') && !args['storage'].empty?
+    disk[:size] = args['size'].to_i if args.key?('size') && !args['size'].empty?
     add_disk_options(disk, args) unless args.key?('options')
     disk[:options] = args['options'] if args.key?('options')
     disk.key?(:storage) ? disk : {}

data/app/models/concerns/fog_extensions/proxmox/node.rb

@@ -31,7 +31,7 @@ module FogExtensions
             # We need to explicitly use the base 'each' method here on the page,
             #  otherwise we get infinite recursion
             base_each = Fog::Collection.instance_method(:each)
-            base_each.bind(page).call(&block)
+            base_each.bind_call(page, &block)
           end
         end
         self

data/app/models/foreman_fog_proxmox/proxmox.rb

@@ -181,7 +181,7 @@ module ForemanFogProxmox
        your server cannot connect to Proxmox due to network issues."
     end
 
-    def host
+    def proxmox_host
       URI.parse(url).host
     end
   end

data/app/models/foreman_fog_proxmox/proxmox_compute_attributes.rb

@@ -30,7 +30,7 @@ module ForemanFogProxmox
         unless compute_os_types(host).include?(ostype)
           raise ::Foreman::Exception,
             format(_('Operating system family %<type>s is not consistent with %<ostype>s'), type: host.operatingsystem.type,
-ostype: ostype)
+              ostype: ostype)
         end
       end
       super
@@ -42,8 +42,8 @@ ostype: ostype)
 
     def interface_compute_attributes(interface_attributes)
       vm_attrs = ForemanFogProxmox::HashCollection.new_hash_reject_keys(interface_attributes, [:identifier, :macaddr, :hwaddr])
-      vm_attrs[:dhcp] = interface_attributes[:ip] == 'dhcp' ? '1' : '0'
-      vm_attrs[:dhcp6] = interface_attributes[:ip6] == 'dhcp' ? '1' : '0'
+      vm_attrs[:dhcp] = (interface_attributes[:ip] == 'dhcp') ? '1' : '0'
+      vm_attrs[:dhcp6] = (interface_attributes[:ip6] == 'dhcp') ? '1' : '0'
       vm_attrs
     end
 

data/app/models/foreman_fog_proxmox/proxmox_console.rb

@@ -33,7 +33,7 @@ module ForemanFogProxmox
         vnc_console = vm.start_console(options)
         vmid = extract_vmid(uuid).to_i
         vnc_host_port = vnc_console['port'].to_i + vmid
-        WsProxy.start(:host => host, :host_port => vnc_host_port, :password => vnc_console['ticket']).merge(
+        WsProxy.start(:host => proxmox_host, :host_port => vnc_host_port, :password => vnc_console['ticket']).merge(
           :name => vm.name, :type => type_console
         )
       rescue StandardError => e

data/app/models/foreman_fog_proxmox/proxmox_images.rb

@@ -48,9 +48,14 @@ module ForemanFogProxmox
       volumes = []
       nodes.each do |node|
         storages(node.node).each do |storage|
+          # fetches volumes of QEMU servers for images
           volumes += storage.volumes.list_by_content_type('images')
+
+          # fetches volumes of KVM containers for images
+          volumes += storage.volumes.list_by_content_type('rootdir')
         end
       end
+      # for creating image, only list volumes which are templated
       volumes.select(&:template?)
     end
 

data/app/models/foreman_fog_proxmox/proxmox_version.rb

@@ -36,7 +36,7 @@ module ForemanFogProxmox
       v = identity_client.read_version if identity_client
       v ? v['version'] : 'Unknown'
     rescue ::Foreman::Exception => e
-      return 'Unkown' if e.message == 'User token expired'
+      'Unkown' if e.message == 'User token expired'
     rescue StandardError => e
       logger.warn("failed to get identity client version: #{e}")
       raise e

data/app/models/foreman_fog_proxmox/proxmox_vm_commands.rb

@@ -32,10 +32,9 @@ module ForemanFogProxmox
     end
 
     def create_vm(args = {})
-      vmid = args[:vmid].to_i
       type = args[:type]
       node = client.nodes.get(args[:node_id])
-      vmid = node.servers.next_id.to_i if vmid < 1
+      vmid = args[:vmid] = assign_vmid(args[:vmid].to_i, node)
       raise ::Foreman::Exception, format(N_('invalid vmid=%<vmid>s'), vmid: vmid) unless node.servers.id_valid?(vmid)
 
       image_id = args[:image_id]
@@ -55,6 +54,10 @@ module ForemanFogProxmox
       raise e
     end
 
+    def assign_vmid(vmid, node)
+      (vmid < 1) ? node.servers.next_id : vmid
+    end
+
     def compute_clone_attributes(args, container, type)
       args = parse_cloudinit_config(args) if args[:user_data]
       parsed_args = parse_typed_vm(args, type)

data/app/models/foreman_fog_proxmox/proxmox_vm_new.rb

@@ -191,7 +191,7 @@ module ForemanFogProxmox
       new_attr_type ||= type
       logger.debug("new_typed_vm(#{type}): new_attr_type=#{new_attr_type}")
       logger.debug("new_typed_vm(#{type}): new_attr=#{new_attr}'")
-      options = !new_attr.key?('vmid') || ForemanFogProxmox::Value.empty?(new_attr['vmid']) ? vm_typed_instance_defaults(type).merge(new_attr).merge(type: type) : new_attr
+      options = (!new_attr.key?('vmid') || ForemanFogProxmox::Value.empty?(new_attr['vmid'])) ? vm_typed_instance_defaults(type).merge(new_attr).merge(type: type) : new_attr
       logger.debug("new_typed_vm(#{type}): options=#{options}")
       vm_h = parse_typed_vm(options, type).deep_symbolize_keys
       logger.debug("new_typed_vm(#{type}): vm_h=#{vm_h}")

data/app/overrides/compute_resources_vms/form/add_from_profile_to_compute_attributes_form.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Copyright 2018 Tristan Robert
 
 # This file is part of ForemanFogProxmox.
@@ -15,6 +17,12 @@
 # You should have received a copy of the GNU General Public License
 # along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
 
+Deface::Override.new(
+  virtual_path: 'compute_attributes/_compute_form',
+  name: 'remove_networks_and_volumes_partial',
+  remove: "erb[loud]:contains('compute_resources_vms/form/networks'), erb[loud]:contains('compute_resources_vms/form/volumes')"
+)
+
 Deface::Override.new(
   :virtual_path => 'compute_attributes/_form',
   :name => 'add_from_profile_to_compute_attributes_form',

data/app/overrides/compute_resources_vms/form/add_react_component_to_host.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+Deface::Override.new(
+  virtual_path: 'hosts/_form',
+  name: 'add_react_component_to_virtual_machine_tab',
+  insert_after: "li.active",
+  partial: 'compute_resources_vms/form/proxmox/add_react_component_to_host_form'
+)

data/app/overrides/compute_resources_vms/form/update_react_component_to_host_form.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+Deface::Override.new(
+  :virtual_path => 'hosts/_compute',
+  :name => 'update_react_component_to_virtual_machine_tab',
+  :replace => "erb[loud]:contains('hosts/compute_detail')",
+  :partial => 'compute_resources_vms/form/proxmox/update_react_component_to_host_form'
+)

data/app/views/compute_resources_vms/form/proxmox/_add_react_component_to_host_form.html.erb

@@ -0,0 +1,5 @@
+<% content_for(:javascripts) do %>
+  <%= webpacked_plugins_js_for :foreman_fog_proxmox %>
+  <%= javascript_include_tag 'foreman_fog_proxmox/proxmox_vm', "data-turbolinks-track" => true %>
+<% end %>
+<%= react_component('ProxmoxVmType', { registerComp: true }) unless @host.managed %>