foreman_fog_proxmox 0.14.0 → 0.14.1

data/app/helpers/proxmox_vm_volumes_helper.rb

@@ -26,33 +26,37 @@ require 'foreman_fog_proxmox/hash_collection'
 module ProxmoxVmVolumesHelper
   include ProxmoxVmCdromHelper
   include ProxmoxVmCloudinitHelper
-  KILO = 1024
-  MEGA = KILO * KILO
-  GIGA = KILO * MEGA
 
   def add_disk_options(disk, args)
-    options = ForemanFogProxmox::HashCollection.new_hash_reject_keys(args, ['id', 'volid', 'controller', 'device', 'storage', 'size', '_delete', 'storage_type'])
+    options = ForemanFogProxmox::HashCollection.new_hash_reject_keys(args,
+      ['id', 'volid', 'controller', 'device', 'storage', 'size', '_delete', 'storage_type'])
     ForemanFogProxmox::HashCollection.remove_empty_values(options)
     disk[:options] = options
   end
 
   def parsed_typed_volumes(args, type, parsed_vm)
-    logger.debug(format(_('parsed_typed_volumes(%<type>s): args=%<args>s'), args: args, type: type))
+    logger.debug("parsed_typed_volumes(#{type}): args=#{args}")
     volumes_attributes = args['volumes_attributes']
-    volumes_attributes ||= args['config_attributes']['volumes_attributes'] unless ForemanFogProxmox::Value.empty?(args['config_attributes'])
-    volumes_attributes ||= args['vm_attrs']['volumes_attributes'] unless ForemanFogProxmox::Value.empty?(args['vm_attrs'])
+    unless ForemanFogProxmox::Value.empty?(args['config_attributes'])
+      volumes_attributes ||= args['config_attributes']['volumes_attributes']
+    end
+    unless ForemanFogProxmox::Value.empty?(args['vm_attrs'])
+      volumes_attributes ||= args['vm_attrs']['volumes_attributes']
+    end
     volumes = parse_typed_volumes(volumes_attributes, type)
     volumes.each { |volume| parsed_vm = parsed_vm.merge(volume) }
     parsed_vm
   end
 
   def parse_hard_disk_volume(args)
+    logger.debug(format(_('parse_hard_disk_volume(): args=%<args>s'), args: args))
     disk = {}
     disk[:id] = args['id'] if args.key?('id')
     disk[:volid] = args['volid'] if args.key?('volid')
     disk[:storage] = args['storage'].to_s if args.key?('storage')
     disk[:size] = args['size'].to_i if args.key?('size')
-    add_disk_options(disk, args)
+    add_disk_options(disk, args) unless args.key?('options')
+    disk[:options] = args['options'] if args.key?('options')
     disk.key?(:storage) ? disk : {}
   end
 
@@ -67,11 +71,12 @@ module ProxmoxVmVolumesHelper
   end
 
   def parse_typed_volume(args, type)
-    logger.debug(format(_('parse_typed_volume(%<type>s): args=%<args>s'), args: args, type: type))
-    disk = parse_hard_disk_volume(args) if volume_type?(args, 'hard_disk') || volume_type?(args, 'mp') || volume_type?(args, 'rootfs')
+    logger.debug("parse_typed_volume(#{type}): args=#{args}")
+    disk = parse_hard_disk_volume(args) if volume_type?(args,
+      'hard_disk') || volume_type?(args, 'mp') || volume_type?(args, 'rootfs')
     disk = parse_server_cloudinit(args) if volume_type?(args, 'cloud_init')
     disk = parse_server_cdrom(args) if volume_type?(args, 'cdrom')
-    logger.debug(format(_('parse_typed_volume(%<type>s): disk=%<disk>s'), disk: disk, type: type))
+    logger.debug("parse_typed_volume(#{type}): disk=#{disk}")
     Fog::Proxmox::DiskHelper.flatten(disk) unless disk.empty?
   end
 
@@ -81,25 +86,17 @@ module ProxmoxVmVolumesHelper
   end
 
   def parse_typed_volumes(args, type)
-    logger.debug(format(_('parse_typed_volumes(%<type>s): args=%<args>s'), args: args, type: type))
+    logger.debug("parse_typed_volumes(#{type}): args=#{args}")
     volumes = []
     args&.each_value { |value| add_typed_volume(volumes, value, type) }
     volumes
   end
 
-  def convert_volumes_size(args)
-    args['volumes_attributes'].each_value { |value| value['size'] = (value['size'].to_i / GIGA).to_s unless ForemanFogProxmox::Value.empty?(value['size']) }
-  end
-
-  def convert_sizes(args)
-    convert_memory_size(args['config_attributes'], 'memory')
-    convert_memory_size(args['config_attributes'], 'balloon')
-    convert_memory_size(args['config_attributes'], 'shares')
-    convert_memory_size(args['config_attributes'], 'swap')
-    args['volumes_attributes'].each_value { |value| value['size'] = (value['size'].to_i / GIGA).to_s unless ForemanFogProxmox::Value.empty?(value['size']) }
-  end
-
   def remove_volume_keys(args)
-    args['volumes_attributes'].each_value { |volume_attributes| ForemanFogProxmox::HashCollection.remove_keys(volume_attributes, ['_delete']) } if args.key?('volumes_attributes')
+    if args.key?('volumes_attributes')
+      args['volumes_attributes'].each_value do |volume_attributes|
+        ForemanFogProxmox::HashCollection.remove_keys(volume_attributes, ['_delete'])
+      end
+    end
   end
 end

data/app/models/concerns/fog_extensions/proxmox/node.rb

@@ -22,7 +22,7 @@ module FogExtensions
     module Node
       extend ActiveSupport::Concern
 
-      def each(collection_filters = {})
+      def each(collection_filters = {}, &block)
         if block_given?
           Kernel.loop do
             break unless collection_filters[:marker]
@@ -31,7 +31,7 @@ module FogExtensions
             # We need to explicitly use the base 'each' method here on the page,
             #  otherwise we get infinite recursion
             base_each = Fog::Collection.instance_method(:each)
-            base_each.bind(page).call { |item| yield item }
+            base_each.bind(page).call(&block)
           end
         end
         self

data/app/models/concerns/fog_extensions/proxmox/server.rb

@@ -24,7 +24,7 @@ module FogExtensions
       attr_accessor :image_id, :templated, :ostemplate_storage, :ostemplate_file, :password, :start_after_create
 
       def unique_cluster_identity(compute_resource)
-        compute_resource.id.to_s + '_' + identity
+        compute_resource.id.to_s + '_' + identity.to_s
       end
 
       def start
@@ -59,7 +59,8 @@ module FogExtensions
       delegate :description, to: :config
 
       def vm_description
-        format(_('Type %<type>s, node %<node>s, %<cpus>s CPUs and %<memory>s MB memory'), type: type, node: node_id, cpus: config.cores || '0', memory: config.memory / (1024 * 1024) || '0')
+        format(_('Type %<type>s, node %<node>s, %<cpus>s CPUs and %<memory>s MB memory'),
+          type: type, node: node_id, cpus: config.cores || '0', memory: config.memory)
       end
 
       def select_nic(fog_nics, nic)
@@ -84,11 +85,14 @@ module FogExtensions
       delegate :pool, to: :config
       delegate :cloud_init?, to: :config
 
-      def interfaces_attributes=(attrs); end
+      def interfaces_attributes=(attrs)
+      end
 
-      def volumes_attributes=(attrs); end
+      def volumes_attributes=(attrs)
+      end
 
-      def config_attributes=(attrs); end
+      def config_attributes=(attrs)
+      end
 
       def templated?
         volumes.any?(&:template?)

data/app/models/concerns/host_ext/proxmox/associator.rb

@@ -33,13 +33,14 @@ module HostExt
 
         def proxmox_vm_id(compute_resource, vm)
           id = vm.identity
-          id = vm.unique_cluster_identity(compute_resource) if compute_resource.class == ForemanFogProxmox::Proxmox
+          id = vm.unique_cluster_identity(compute_resource) if compute_resource.instance_of?(ForemanFogProxmox::Proxmox)
           id
         end
       end
 
       def for_vm_uuid(cr, vm)
-        where(:compute_resource_id => cr.id, :uuid => Array.wrap(vm).compact.map(cr.id.to_s + '_' + vm&.identity).map(&:to_s))
+        where(:compute_resource_id => cr.id,
+          :uuid => Array.wrap(vm).compact.map(cr.id.to_s + '_' + vm&.identity).map(&:to_s))
       end
     end
   end

data/app/models/concerns/host_ext/proxmox/for_vm.rb

@@ -24,7 +24,7 @@ module HostExt
       module ClassMethods
         def for_vm_uuid(cr, vm)
           uuid = vm&.identity
-          uuid = cr.id.to_s + '_' + vm&.identity if cr.class == ForemanFogProxmox::Proxmox
+          uuid = cr.id.to_s + '_' + vm&.identity.to_s if cr.instance_of?(ForemanFogProxmox::Proxmox)
           where(:compute_resource_id => cr.id, :uuid => uuid)
         end
       end

data/app/models/concerns/host_ext/proxmox/interfaces.rb

@@ -24,14 +24,17 @@ module HostExt
     module Interfaces
       extend ActiveSupport::Concern
       def update(attributes = {})
-        add_interfaces_to_compute_attributes(attributes) if provider == 'Proxmox' && !attributes.nil? && attributes.key?('compute_attributes')
+        if provider == 'Proxmox' && !attributes.nil? && attributes.key?('compute_attributes')
+          add_interfaces_to_compute_attributes(attributes)
+        end
         super(attributes)
       end
 
       def add_interfaces_to_compute_attributes(attributes)
         attributes['compute_attributes'].store('interfaces_attributes', {})
         attributes['interfaces_attributes'].each do |index, interface_attributes|
-          add_interface_to_compute_attributes(index, interface_attributes, attributes['compute_attributes']['interfaces_attributes'])
+          add_interface_to_compute_attributes(index, interface_attributes,
+            attributes['compute_attributes']['interfaces_attributes'])
         end
       end
 
@@ -40,7 +43,8 @@ module HostExt
         key_ip += '6' if v == 6
         key_cidr = 'cidr'
         key_cidr += '6' if v == 6
-        Fog::Proxmox::IpHelper.to_cidr(interface_attributes[key_ip], interface_attributes['compute_attributes'][key_cidr])
+        Fog::Proxmox::IpHelper.to_cidr(interface_attributes[key_ip],
+          interface_attributes['compute_attributes'][key_cidr])
       end
 
       def add_interface_to_compute_attributes(index, interface_attributes, compute_attributes)

data/app/models/concerns/orchestration/proxmox/compute.rb

@@ -32,7 +32,8 @@ module Orchestration
           compute_resource.save_vm uuid, final_compute_attributes
         end
       rescue StandardError => e
-        failure format(_('Failed to update a compute %<compute_resource>s instance %<name>s: %<e>s'), :compute_resource => compute_resource, :name => name, :e => e), e
+        failure format(_('Failed to update a compute %<compute_resource>s instance %<name>s: %<e>s'), :compute_resource => compute_resource, :name => name, :e => e),
+          e
       end
 
       def delComputeUpdate
@@ -44,7 +45,8 @@ module Orchestration
           compute_resource.save_vm uuid, final_compute_attributes
         end
       rescue StandardError => e
-        failure format(_('Failed to undo update compute %<compute_resource>s instance %<name>s: %<e>s'), :compute_resource => compute_resource, :name => name, :e => e), e
+        failure format(_('Failed to undo update compute %<compute_resource>s instance %<name>s: %<e>s'), :compute_resource => compute_resource, :name => name, :e => e),
+          e
       end
 
       def empty_provided_ips?(ip, ip6)
@@ -62,7 +64,7 @@ module Orchestration
       def computeValue(foreman_attr, fog_attr)
         value = ''
         value += compute_resource.id.to_s + '_' if foreman_attr == :uuid
-        value += vm.send(fog_attr)
+        value += vm.send(fog_attr).to_s
         value
       end
 
@@ -82,7 +84,12 @@ module Orchestration
             result = false unless validate_required_foreman_attr(value, Host, foreman_attr)
           end
         end
-        return failure(format(_('Failed to acquire IP addresses from compute resource for %<name>s'), name: name)) if empty_provided_ips?(ip, ip6)
+        if empty_provided_ips?(
+          ip, ip6
+        )
+          return failure(format(_('Failed to acquire IP addresses from compute resource for %<name>s'),
+            name: name))
+        end
 
         result
       end

data/app/models/foreman_fog_proxmox/options_select.rb

@@ -19,9 +19,7 @@
 
 module ForemanFogProxmox
   class OptionsSelect
-    attr_accessor :id
-    attr_accessor :name
-    attr_accessor :range
+    attr_accessor :id, :name, :range
 
     def to_s
       id

data/app/models/foreman_fog_proxmox/proxmox.rb

@@ -36,11 +36,12 @@ module ForemanFogProxmox
     include ProxmoxVersion
     include ProxmoxConsole
     validates :url, :format => { :with => URI::DEFAULT_PARSER.make_regexp }, :presence => true
-    validates :auth_method, :presence => true, inclusion: { in: ['access_ticket', 'user_token'], message: ->(value) do format('%<value>s is not a valid authentication method', { value: value }) end }
-    validates :user, :format => { :with => /(\w+)[@]{1}(\w+)/ }, :presence => true
-    validates :password, :presence => true, if: :access_ticket?
-    validates :token_id, :presence => true, if: :user_token?
-    validates :token, :presence => true, if: :user_token?
+    validates :auth_method, :presence => true, :inclusion => { in: ['access_ticket', 'user_token'],
+      message: ->(value) do format('%<value>s is not a valid authentication method', { value: value }) end }
+    validates :user, :format => { :with => /(\w+)@{1}(\w+)/ }, :presence => true
+    validates :password, :presence => true, :if => :access_ticket?
+    validates :token_id, :presence => true, :if => :user_token?
+    validates :token, :presence => true, :if => :user_token?
 
     def provided_attributes
       super.merge(
@@ -65,7 +66,8 @@ module ForemanFogProxmox
     end
 
     def associate_by(name, attributes)
-      Host.authorized(:view_hosts, Host).joins(:primary_interface).where(:nics => { :primary => true }).where("nics.#{name}" => attributes).readonly(false).first
+      Host.authorized(:view_hosts,
+        Host).joins(:primary_interface).where(:nics => { :primary => true }).where("nics.#{name}".downcase => attributes.downcase).readonly(false).first
     end
 
     def ssl_certs
@@ -128,7 +130,7 @@ module ForemanFogProxmox
       hash = {
         proxmox_url: url,
         proxmox_auth_method: auth_method || 'access_ticket',
-        connection_options: connection_options
+        connection_options: connection_options,
       }
       if access_ticket?
         hash[:proxmox_username] = user
@@ -151,7 +153,7 @@ module ForemanFogProxmox
     rescue Excon::Errors::Unauthorized => e
       raise ::Foreman::Exception, 'User token expired' if token_expired?(e)
     rescue StandardError => e
-      logger.warn(format(_('failed to create compute client: %<e>s'), e: e))
+      logger.warn("failed to create compute client: #{e}")
       raise e
     end
 
@@ -160,7 +162,7 @@ module ForemanFogProxmox
     rescue Excon::Errors::Unauthorized => e
       raise ::Foreman::Exception, 'User token expired' if token_expired?(e)
     rescue StandardError => e
-      logger.warn(format(_('failed to create identity client: %<e>s'), e: e))
+      logger.warn("failed to create identity client: #{e}")
       raise e
     end
 
@@ -169,7 +171,7 @@ module ForemanFogProxmox
     rescue Excon::Errors::Unauthorized => e
       raise ::Foreman::Exception, 'User token expired' if token_expired?(e)
     rescue StandardError => e
-      logger.warn(format(_('failed to create network client: %<e>s'), e: e))
+      logger.warn("failed to create network client: #{e}")
       raise e
     end
 

data/app/models/foreman_fog_proxmox/proxmox_compute_attributes.rb

@@ -27,7 +27,11 @@ module ForemanFogProxmox
         host.compute_attributes['config_attributes'].store('hostname', host.name)
       when 'qemu'
         host.compute_attributes['config_attributes'].store('name', host.name)
-        raise ::Foreman::Exception, format(_('Operating system family %<type>s is not consistent with %<ostype>s'), type: host.operatingsystem.type, ostype: ostype) unless compute_os_types(host).include?(ostype)
+        unless compute_os_types(host).include?(ostype)
+          raise ::Foreman::Exception,
+            format(_('Operating system family %<type>s is not consistent with %<ostype>s'), type: host.operatingsystem.type,
+ostype: ostype)
+        end
       end
       super
     end
@@ -47,8 +51,16 @@ module ForemanFogProxmox
       vm_attrs = {}
       vm_attrs = vm_attrs.merge(vmid: vm.identity, node_id: vm.node_id, type: vm.type)
       if vm.respond_to?(:config)
-        vm_attrs[:volumes_attributes] = Hash[vm.config.disks.each_with_index.map { |disk, idx| [idx.to_s, disk.attributes] }] if vm.config.respond_to?(:disks)
-        vm_attrs[:interfaces_attributes] = Hash[vm.config.interfaces.each_with_index.map { |interface, idx| [idx.to_s, interface_compute_attributes(interface.attributes)] }] if vm.config.respond_to?(:interfaces)
+        if vm.config.respond_to?(:disks)
+          vm_attrs[:volumes_attributes] = Hash[vm.config.disks.each_with_index.map do |disk, idx|
+                                                 [idx.to_s, disk.attributes]
+                                               end ]
+        end
+        if vm.config.respond_to?(:interfaces)
+          vm_attrs[:interfaces_attributes] = Hash[vm.config.interfaces.each_with_index.map do |interface, idx|
+                                                    [idx.to_s, interface_compute_attributes(interface.attributes)]
+                                                  end ]
+        end
         vm_attrs[:config_attributes] = vm.config.attributes.reject do |key, value|
           not_config_key?(vm, key) || ForemanFogProxmox::Value.empty?(value.to_s) || Fog::Proxmox::DiskHelper.disk?(key.to_s) || Fog::Proxmox::NicHelper.nic?(key.to_s)
         end

data/app/models/foreman_fog_proxmox/proxmox_connection.rb

@@ -38,8 +38,12 @@ module ForemanFogProxmox
 
     def credentials_valid?
       errors[:url].empty? && errors[:auth_method].empty?
-      errors[:user].empty? && errors[:user].include?('@') && errors[:password].empty? && errors[:node_id].empty? if access_ticket?
-      errors[:user].empty? && errors[:user].include?('@') && errors[:token_id].empty? && errors[:token].empty? && errors[:node_id].empty? if user_token?
+      if access_ticket?
+        errors[:user].empty? && errors[:user].include?('@') && errors[:password].empty? && errors[:node_id].empty?
+      end
+      if user_token?
+        errors[:user].empty? && errors[:user].include?('@') && errors[:token_id].empty? && errors[:token].empty? && errors[:node_id].empty?
+      end
     end
 
     def current_user_token_expire

data/app/models/foreman_fog_proxmox/proxmox_console.rb

@@ -31,7 +31,9 @@ module ForemanFogProxmox
       options.store(:websocket, 1) if type_console == 'vnc'
       begin
         vnc_console = vm.start_console(options)
-        WsProxy.start(:host => host, :host_port => vnc_console['port'], :password => vnc_console['ticket']).merge(:name => vm.name, :type => type_console)
+        WsProxy.start(:host => host, :host_port => vnc_console['port'], :password => vnc_console['ticket']).merge(
+          :name => vm.name, :type => type_console
+        )
       rescue StandardError => e
         logger.error(e)
         raise ::Foreman::Exception, _('%<s>s console is not supported at this time') % type_console

data/app/models/foreman_fog_proxmox/proxmox_images.rb

@@ -27,7 +27,7 @@ module ForemanFogProxmox
       node = client.nodes.get node_id
       node ||= default_node
       storage = node.storages.get storage_id if storage_id
-      logger.debug(format(_('images_by_storage(): node_id %<node_id>s storage_id %<storage_id>s type %<type>s'), node_id: node_id, storage_id: storage_id, type: type))
+      logger.debug("images_by_storage(): node_id #{node_id} storage_id #{storage_id} type #{type}")
       storage.volumes.list_by_content_type(type).sort_by(&:volid) if storage
     end
 
@@ -58,7 +58,7 @@ module ForemanFogProxmox
     end
 
     def clone_from_image(image_id, args, vmid)
-      logger.debug(format(_('create_vm(): clone %<image_id>s in %<vmid>s'), image_id: image_id, vmid: vmid))
+      logger.debug("create_vm(): clone #{image_id} in #{vmid}")
       image = find_vm_by_uuid(image_id)
       image.clone(vmid)
       clone = find_vm_by_uuid(id.to_s + '_' + vmid.to_s)

data/app/models/foreman_fog_proxmox/proxmox_interfaces.rb

@@ -28,7 +28,11 @@ module ForemanFogProxmox
 
     def set_nic_identifier(nic, index)
       nic.compute_attributes[:id] = format('net%<index>s', index: index) if nic.compute_attributes[:id].empty?
-      raise ::Foreman::Exception, _(format('Invalid proxmox NIC id on interface[%<index>s]. Must be net[n] with n integer >= 0', index: index)) unless Fog::Proxmox::NicHelper.nic?(nic.compute_attributes[:id])
+      unless Fog::Proxmox::NicHelper.nic?(nic.compute_attributes[:id])
+        raise ::Foreman::Exception,
+          _(format('Invalid proxmox NIC id on interface[%<index>s]. Must be net[n] with n integer >= 0',
+            index: index))
+      end
 
       nic.identifier = nic.compute_attributes['id'] if nic.identifier.empty?
     end
@@ -49,7 +53,11 @@ module ForemanFogProxmox
 
     def set_container_interface_name(_host, nic, index)
       nic.compute_attributes['name'] = format('eth%<index>s', index: index) if nic.compute_attributes['name'].empty?
-      raise ::Foreman::Exception, _(format('Invalid name interface[%<index>s]. Must be eth[n] with n integer >= 0', index: index)) unless container_nic_name_valid?(nic)
+      unless container_nic_name_valid?(nic)
+        raise ::Foreman::Exception,
+          _(format('Invalid name interface[%<index>s]. Must be eth[n] with n integer >= 0',
+            index: index))
+      end
     end
 
     def cidr_prefix(nic_compute_attributes, v6 = false)
@@ -66,7 +74,9 @@ module ForemanFogProxmox
       ipv = "IPv#{v6 ? '6' : '4'}"
       max = v6 ? 128 : 32
       checked = valid || ForemanFogProxmox::Value.empty?(ip)
-      message = format('Invalid Interface Proxmox CIDR %<ip>s. If %<ip>s is not empty, Proxmox CIDR prefix must be an integer between 0 and %<max>i.', ip: ipv, max: max)
+      message = format(
+        'Invalid Interface Proxmox CIDR %<ip>s. If %<ip>s is not empty, Proxmox CIDR prefix must be an integer between 0 and %<max>i.', ip: ipv, max: max
+      )
       raise ::Foreman::Exception, _(message) unless checked
     end
 
@@ -89,7 +99,10 @@ module ForemanFogProxmox
           ip = 'dhcp'
         elsif !ForemanFogProxmox::Value.empty?(cidr_prefix(nic_compute_attributes, v6))
           check_cidr(nic_compute_attributes, v6, ip)
-          ip = Fog::Proxmox::IpHelper.send(to_cidr_method(v6), nic.send(ip_s(v6).to_sym), cidr_prefix(nic_compute_attributes, v6)) if ip
+          if ip
+            ip = Fog::Proxmox::IpHelper.send(to_cidr_method(v6), nic.send(ip_s(v6).to_sym),
+              cidr_prefix(nic_compute_attributes, v6))
+          end
         end
       end
       nic_compute_attributes[ip_s(v6).to_sym] = ip
@@ -118,8 +131,17 @@ module ForemanFogProxmox
         mac = nic.mac
         mac ||= nic.attributes['mac']
         set_mac(nic.compute_attributes, mac, vm_type(host)) if mac.present?
-        interface_compute_attributes = host.compute_attributes['interfaces_attributes'] ? host.compute_attributes['interfaces_attributes'].select { |_k, v| v['id'] == nic.compute_attributes[:id] } : {}
-        nic.compute_attributes.store(:_delete, interface_compute_attributes[interface_compute_attributes.keys[0]]['_delete']) unless interface_compute_attributes.empty?
+        interface_compute_attributes = if host.compute_attributes['interfaces_attributes']
+                                         host.compute_attributes['interfaces_attributes'].select do |_k, v|
+                                           v['id'] == nic.compute_attributes[:id]
+                                         end
+                                       else
+                                         {}
+                                       end
+        unless interface_compute_attributes.empty?
+          nic.compute_attributes.store(:_delete,
+            interface_compute_attributes[interface_compute_attributes.keys[0]]['_delete'])
+        end
         set_ip(host, nic, nic.compute_attributes)
         set_ip(host, nic, nic.compute_attributes, true)
         ForemanFogProxmox::HashCollection.remove_keys(nic.compute_attributes, ['dhcp', 'dhcp6', 'cidr', 'cidr6'])

data/app/models/foreman_fog_proxmox/proxmox_operating_systems.rb

@@ -39,7 +39,12 @@ module ForemanFogProxmox
     end
 
     def os_linux_types_mapping(host)
-      ['Debian', 'Redhat', 'Suse', 'Altlinux', 'Archlinux', 'Coreos', 'Rancheros', 'Gentoo'].include?(host.operatingsystem.type) ? available_linux_operating_systems : []
+      if ['Debian', 'Redhat', 'Suse', 'Altlinux', 'Archlinux', 'Coreos', 'Rancheros',
+          'Gentoo'].include?(host.operatingsystem.type)
+        available_linux_operating_systems
+      else
+        []
+      end
     end
 
     def os_windows_types_mapping(host)

data/app/models/foreman_fog_proxmox/proxmox_pools.rb

@@ -25,21 +25,21 @@ module ForemanFogProxmox
     end
 
     def pool_owner(vm)
-      logger.debug(format(_('pool_owner(%<vmid>s)'), vmid: vm&.vmid))
+      logger.debug("pool_owner(#{vm&.vmid})")
       pools_owners = pools.select { |pool| pool.has_server?(vm&.vmid) }
       pool = pools_owners.first
-      logger.debug(format(_('found vm: %<vmid>s member of pool: %<poolid>s'), vmid: vm&.vmid, poolid: pool&.poolid))
+      logger.debug("found vm: #{vm&.vmid} member of pool: #{pool&.poolid}")
       vm&.config&.pool = pool&.poolid
     end
 
     def add_vm_to_pool(poolid, vmid)
-      logger.debug(format(_('add_vm_to_pool(%<poolid>s, %<vmid>s)'), poolid: poolid, vmid: vmid))
+      logger.debug("add_vm_to_pool(#{poolid}, #{vmid})")
       pool = identity_client.pools.get poolid
       pool&.add_server vmid
     end
 
     def remove_vm_from_pool(poolid, vmid)
-      logger.debug(format(_('remove_vm_from_pool(%<poolid>s, %<vmid>s)'), poolid: poolid, vmid: vmid))
+      logger.debug("remove_vm_from_pool(#{poolid}, #{vmid})")
       pool = identity_client.pools.get poolid
       pool&.remove_server vmid
     end

data/app/models/foreman_fog_proxmox/proxmox_version.rb

@@ -22,8 +22,12 @@ require 'foreman_fog_proxmox/semver'
 module ForemanFogProxmox
   module ProxmoxVersion
     def version_suitable?
-      logger.debug(format(_('Proxmox compute resource version is %<version>s'), version: version))
-      raise ::Foreman::Exception, format(_('Proxmox version %<version>s is not semver suitable'), version: version) unless ForemanFogProxmox::Semver.semver?(version)
+      logger.debug("Proxmox compute resource version is #{version}")
+      unless ForemanFogProxmox::Semver.semver?(version)
+        raise ::Foreman::Exception,
+          format(_('Proxmox version %<version>s is not semver suitable'),
+            version: version)
+      end
 
       ForemanFogProxmox::Semver.to_semver(version) >= ForemanFogProxmox::Semver.to_semver('5.3.0')
     end
@@ -34,7 +38,7 @@ module ForemanFogProxmox
     rescue ::Foreman::Exception => e
       return 'Unkown' if e.message == 'User token expired'
     rescue StandardError => e
-      logger.warn(format(_('failed to get identity client version: %<e>s'), e: e))
+      logger.warn("failed to get identity client version: #{e}")
       raise e
     end
   end

data/app/models/foreman_fog_proxmox/proxmox_vm_commands.rb

@@ -42,14 +42,13 @@ module ForemanFogProxmox
       if image_id
         clone_from_image(image_id, args, vmid)
       else
-        convert_sizes(args)
         remove_volume_keys(args)
-        logger.warn(format(_('create vm: args=%<args>s'), args: args))
+        logger.warn("create vm: args=#{args}")
         vm = node.send(vm_collection(type)).create(parse_typed_vm(args, type))
         start_on_boot(vm, args)
       end
     rescue StandardError => e
-      logger.warn(format(_('failed to create vm: %<e>s'), e: e))
+      logger.warn("failed to create vm: #{e}")
       destroy_vm client.identity + '_' + vm.id if vm
       raise e
     end
@@ -74,7 +73,8 @@ module ForemanFogProxmox
     end
 
     def compute_config_attributes(parsed_attr)
-      excluded_keys = [:vmid, :templated, :ostemplate, :ostemplate_file, :ostemplate_storage, :volumes_attributes, :pool]
+      excluded_keys = [:vmid, :templated, :ostemplate, :ostemplate_file, :ostemplate_storage, :volumes_attributes,
+                       :pool]
       config_attributes = parsed_attr.reject { |key, _value| excluded_keys.include? key.to_sym }
       ForemanFogProxmox::HashCollection.remove_empty_values(config_attributes)
       config_attributes = config_attributes.reject { |key, _value| Fog::Proxmox::DiskHelper.disk?(key) }
@@ -90,11 +90,13 @@ module ForemanFogProxmox
       elsif vm.node_id != node_id
         vm.migrate(node_id)
       else
-        convert_memory_sizes(new_attributes)
-        parsed_attr = parse_typed_vm(ForemanFogProxmox::HashCollection.new_hash_reject_keys(new_attributes, ['volumes_attributes']).merge(type: vm.type), vm.type)
+        parsed_attr = parse_typed_vm(
+          ForemanFogProxmox::HashCollection.new_hash_reject_keys(new_attributes,
+            ['volumes_attributes']).merge(type: vm.type), vm.type
+        )
         config_attributes = compute_config_attributes(parsed_attr)
         volumes_attributes = new_attributes['volumes_attributes']
-        logger.debug(format(_('save_vm(%<vmid>s) volumes_attributes=%<volumes_attributes>s'), vmid: uuid, volumes_attributes: volumes_attributes))
+        logger.debug("save_vm(#{uuid}) volumes_attributes=#{volumes_attributes}")
         volumes_attributes&.each_value { |volume_attributes| save_volume(vm, volume_attributes) }
         vm.update(config_attributes[:config_attributes])
         poolid = new_attributes['pool'] if new_attributes.key?('pool')