foreman_fog_proxmox 0.12.1 → 0.13.2

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_create_test.rb

@@ -43,13 +43,13 @@ module ForemanFogProxmox
       end
 
       it 'computes next vmid when vmid == 0 and creates server' do
-        args = { vmid: '0', type: 'qemu', node_id: 'pve', start_after_create: '0' }
+        args = { vmid: '0', type: 'qemu', node_id: 'proxmox', start_after_create: '0' }
         servers = mock('servers')
         servers.stubs(:id_valid?).returns(true)
         servers.stubs(:next_id).returns('101')
         cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
         cr.stubs(:convert_sizes).with(args)
-        cr.stubs(:parse_server_vm).with(args).returns(args)
+        cr.stubs(:parse_typed_vm).with(args, 'qemu').returns(args)
         servers.stubs(:create).with(args)
         vm = mock('vm')
         cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
@@ -57,12 +57,12 @@ module ForemanFogProxmox
       end
 
       it 'creates server without bootstart' do
-        args = { vmid: '100', type: 'qemu', node_id: 'pve', start_after_create: '0' }
+        args = { vmid: '100', type: 'qemu', node_id: 'proxmox', start_after_create: '0' }
         servers = mock('servers')
         servers.stubs(:id_valid?).returns(true)
         cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
         cr.stubs(:convert_sizes).with(args)
-        cr.stubs(:parse_server_vm).with(args).returns(args)
+        cr.stubs(:parse_typed_vm).with(args, 'qemu').returns(args)
         servers.stubs(:create).with(args)
         vm = mock('vm')
         cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
@@ -70,12 +70,12 @@ module ForemanFogProxmox
       end
 
       it 'creates server with bootstart' do
-        args = { vmid: '100', type: 'qemu', node_id: 'pve', start_after_create: '1' }
+        args = { vmid: '100', type: 'qemu', node_id: 'proxmox', start_after_create: '1' }
         servers = mock('servers')
         servers.stubs(:id_valid?).returns(true)
         cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
         cr.stubs(:convert_sizes).with(args)
-        cr.stubs(:parse_server_vm).with(args).returns(args)
+        cr.stubs(:parse_typed_vm).with(args, 'qemu').returns(args)
         vm = mock('vm')
         servers.stubs(:create).with(args).returns(vm)
         cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
@@ -84,12 +84,12 @@ module ForemanFogProxmox
       end
 
       it 'creates server within pool' do
-        args = { vmid: '100', type: 'qemu', node_id: 'pve', start_after_create: '0', pool: 'pool1' }
+        args = { vmid: '100', type: 'qemu', node_id: 'proxmox', start_after_create: '0', pool: 'pool1' }
         servers = mock('servers')
         servers.stubs(:id_valid?).returns(true)
         cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
         cr.stubs(:convert_sizes).with(args)
-        cr.stubs(:parse_server_vm).with(args).returns(args)
+        cr.stubs(:parse_typed_vm).with(args, 'qemu').returns(args)
         vm = mock('vm')
         servers.stubs(:create).with(args).returns(vm)
         cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_cdrom_test.rb

@@ -0,0 +1,181 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'test_plugin_helper'
+require 'models/compute_resources/compute_resource_test_helpers'
+require 'factories/foreman_fog_proxmox/proxmox_node_mock_factory'
+require 'factories/foreman_fog_proxmox/proxmox_server_mock_factory'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module ForemanFogProxmox
+  class ProxmoxVmCommandsServerUpdateTest < ActiveSupport::TestCase
+    include ComputeResourceTestHelpers
+    include ProxmoxNodeMockFactory
+    include ProxmoxServerMockFactory
+    include ProxmoxVmHelper
+
+    describe 'save_vm' do
+      before do
+        @cr = FactoryBot.build_stubbed(:proxmox_cr)
+      end
+
+      it 'saves modified server config with added cdrom' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:id).returns('ide2')
+        disks.stubs(:get).returns
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:identity).returns(uuid)
+        vm.stubs(:attributes).returns('' => '')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('proxmox')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'node_id' => 'proxmox',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'ide2',
+              '_delete' => '',
+              'device' => '2',
+              'controller' => 'ide',
+              'storage_type' => 'cdrom',
+              'storage' => 'local-lvm',
+              'cdrom' => 'image',
+              'volid' => 'local-lvm:iso/ubuntu-20_4.iso'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'proxmox', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0')
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = { id: 'ide2', storage: 'local:lvm', volid: 'local-lvm:iso/ubuntu-20_4.iso', media: 'cdrom' }
+        vm.expects(:attach, expected_volume_attr)
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+
+      it 'saves modified server config with removed cdrom' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:volid).returns('local-lvm:iso/ubuntu-20_4.iso')
+        disk.stubs(:media).returns('cdrom')
+        disk.stubs(:id).returns('ide2')
+        disks.stubs(:get).returns(disk)
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:identity).returns(uuid)
+        vm.stubs(:attributes).returns('ide2' => '')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:templated?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('proxmox')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'node_id' => 'proxmox',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'ide2',
+              '_delete' => '1',
+              'device' => '2',
+              'controller' => 'ide',
+              'storage_type' => 'cdrom',
+              'cdrom' => 'none'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'proxmox', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'config_attributes' => { 'onboot' => '0' })
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = 'ide2'
+        vm.expects(:detach, expected_volume_attr)
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+
+      it 'saves modified server config with modified cdrom from image into physical' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:volid).returns('local-lvm:iso/ubuntu-20_4.iso')
+        disk.stubs(:media).returns('cdrom')
+        disk.stubs(:id).returns('ide2')
+        disk.stubs(:attributes).returns(id: 'ide2', storage: 'local-lvm', volid: 'local-lvm:vm-100-disk-0', size: 1_073_741_824)
+        disks.stubs(:get).returns(disk)
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:identity).returns(uuid)
+        vm.stubs(:attributes).returns('ide2' => '')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('proxmox')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'node_id' => 'proxmox',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'ide2',
+              '_delete' => '',
+              'device' => '2',
+              'controller' => 'ide',
+              'storage_type' => 'cdrom',
+              'cdrom' => 'cdrom'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'proxmox', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = { :id => 'ide2', :cdrom => 'cdrom' }
+        vm.expects(:attach, expected_volume_attr)
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+    end
+  end
+end

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_cloudinit_test.rb

@@ -0,0 +1,131 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'test_plugin_helper'
+require 'models/compute_resources/compute_resource_test_helpers'
+require 'factories/foreman_fog_proxmox/proxmox_node_mock_factory'
+require 'factories/foreman_fog_proxmox/proxmox_server_mock_factory'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module ForemanFogProxmox
+  class ProxmoxVmCommandsServerUpdateTest < ActiveSupport::TestCase
+    include ComputeResourceTestHelpers
+    include ProxmoxNodeMockFactory
+    include ProxmoxServerMockFactory
+    include ProxmoxVmHelper
+
+    describe 'save_vm' do
+      before do
+        @cr = FactoryBot.build_stubbed(:proxmox_cr)
+      end
+
+      it 'saves modified server config with added cloudinit' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:id).returns('ide0')
+        disks.stubs(:get).returns
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:identity).returns(uuid)
+        vm.stubs(:attributes).returns('' => '')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('proxmox')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'node_id' => 'proxmox',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'ide2',
+              '_delete' => '',
+              'device' => '0',
+              'controller' => 'ide',
+              'storage_type' => 'cloud_init',
+              'storage' => 'local-lvm',
+              'volid' => 'local-lvm:cloudinit'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'proxmox', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0')
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = { id: 'ide0', storage: 'local:lvm', volid: 'local-lvm:cloudinit', media: 'cdrom' }
+        vm.expects(:attach, expected_volume_attr)
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+
+      it 'saves modified server config with removed cdrom' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:volid).returns('local-lvm:vm-100-cloudinit')
+        disk.stubs(:media).returns('cdrom')
+        disk.stubs(:id).returns('ide0')
+        disks.stubs(:get).returns(disk)
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:identity).returns(uuid)
+        vm.stubs(:attributes).returns('ide0' => '')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:templated?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('proxmox')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'node_id' => 'proxmox',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'ide0',
+              '_delete' => '1',
+              'device' => '0',
+              'controller' => 'ide',
+              'storage_type' => 'cloud_init'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'proxmox', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'config_attributes' => { 'onboot' => '0' })
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = 'ide0'
+        vm.expects(:detach, expected_volume_attr)
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+    end
+  end
+end

data/test/unit/foreman_fog_proxmox/{proxmox_vm_commands_server_update_volumes_test.rb → proxmox_vm_commands_server_update_hard_disk_test.rb}

@@ -43,18 +43,21 @@ module ForemanFogProxmox
         disk.stubs(:size).returns(1_073_741_824)
         disk.stubs(:storage).returns('local-lvm')
         disk.stubs(:id).returns('scsi0')
+        disk.stubs(:attributes).returns(id: 'scsi0', storage: 'local-lvm', size: 1_073_741_824)
         disks.stubs(:get).returns
         config.stubs(:disks).returns(disks)
         config.stubs(:attributes).returns(:cores => '')
         vm = mock('vm')
+        vm.stubs(:identity).returns(uuid)
+        vm.stubs(:attributes).returns('' => '')
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(false)
         vm.stubs(:type).returns('qemu')
-        vm.stubs(:node_id).returns('pve')
+        vm.stubs(:node_id).returns('proxmox')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
-          'node_id' => 'pve',
+          'node_id' => 'proxmox',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -65,13 +68,14 @@ module ForemanFogProxmox
               '_delete' => '',
               'device' => '0',
               'controller' => 'scsi',
+              'storage_type' => 'hard_disk',
               'storage' => 'local-lvm',
               'size' => '2147483648',
               'cache' => 'none'
             }
           }
         }.with_indifferent_access
-        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0')
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'proxmox', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0')
         expected_config_attr = { :cores => '1', :cpulimit => '1' }
         expected_volume_attr = { id: 'scsi0', storage: 'local:lvm', size: (2_147_483_648 / GIGA).to_s }
         vm.expects(:attach, expected_volume_attr)
@@ -91,15 +95,17 @@ module ForemanFogProxmox
         config.stubs(:disks).returns(disks)
         config.stubs(:attributes).returns(:cores => '')
         vm = mock('vm')
+        vm.stubs(:identity).returns(uuid)
+        vm.stubs(:attributes).returns('scsi0' => '')
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(false)
         vm.stubs(:templated?).returns(false)
         vm.stubs(:type).returns('qemu')
-        vm.stubs(:node_id).returns('pve')
+        vm.stubs(:node_id).returns('proxmox')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
-          'node_id' => 'pve',
+          'node_id' => 'proxmox',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -108,6 +114,7 @@ module ForemanFogProxmox
             '0' => {
               '_delete' => '1',
               'id' => 'scsi0',
+              'storage_type' => 'hard_disk',
               'volid' => 'local-lvm:vm-100-disk-0',
               'device' => '0',
               'controller' => 'scsi',
@@ -117,7 +124,7 @@ module ForemanFogProxmox
             }
           }
         }.with_indifferent_access
-        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'config_attributes' => { 'onboot' => '0' })
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'proxmox', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'config_attributes' => { 'onboot' => '0' })
         expected_config_attr = { :cores => '1', :cpulimit => '1' }
         expected_volume_attr = 'scsi0'
         vm.expects(:detach, expected_volume_attr)
@@ -132,20 +139,24 @@ module ForemanFogProxmox
         disks = mock('disks')
         disk = mock('disk')
         disk.stubs(:size).returns(1_073_741_824)
-        disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:storage).returns('scsi0')
+        disk.stubs(:id).returns('local-lvm')
+        disk.stubs(:attributes).returns(id: 'scsi0', storage: 'local-lvm', size: 1_073_741_824)
         disks.stubs(:get).returns(disk)
         config.stubs(:disks).returns(disks)
         config.stubs(:attributes).returns(:cores => '')
         vm = mock('vm')
+        vm.stubs(:identity).returns(uuid)
+        vm.stubs(:attributes).returns('scsi0' => '')
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(false)
         vm.stubs(:templated?).returns(false)
         vm.stubs(:type).returns('qemu')
-        vm.stubs(:node_id).returns('pve')
+        vm.stubs(:node_id).returns('proxmox')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
-          'node_id' => 'pve',
+          'node_id' => 'proxmox',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -154,6 +165,7 @@ module ForemanFogProxmox
             '0' => {
               'id' => 'scsi0',
               '_delete' => '',
+              'storage_type' => 'hard_disk',
               'volid' => 'local-lvm:vm-100-disk-0',
               'device' => '0',
               'controller' => 'scsi',
@@ -163,7 +175,7 @@ module ForemanFogProxmox
             }
           }
         }.with_indifferent_access
-        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'proxmox', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
         expected_config_attr = { :cores => '1', :cpulimit => '1' }
         expected_volume_attr = ['scsi0', '+1G']
         vm.expects(:extend, expected_volume_attr)
@@ -176,20 +188,24 @@ module ForemanFogProxmox
         config = mock('config')
         disks = mock('disks')
         disk = mock('disk')
+        disk.stubs(:id).returns('scsi0')
         disk.stubs(:size).returns(1_073_741_824)
         disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:attributes).returns(id: 'scsi0', storage: 'local-lvm', size: 1_073_741_824)
         disks.stubs(:get).returns(disk)
         config.stubs(:disks).returns(disks)
         config.stubs(:attributes).returns(:cores => '')
         vm = mock('vm')
+        vm.stubs(:identity).returns(uuid)
+        vm.stubs(:attributes).returns('scsi0' => '')
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(false)
         vm.stubs(:type).returns('qemu')
-        vm.stubs(:node_id).returns('pve')
+        vm.stubs(:node_id).returns('proxmox')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
-          'node_id' => 'pve',
+          'node_id' => 'proxmox',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -198,6 +214,7 @@ module ForemanFogProxmox
             '0' => {
               'id' => 'scsi0',
               '_delete' => '',
+              'storage_type' => 'hard_disk',
               'volid' => 'local-lvm:vm-100-disk-0',
               'device' => '0',
               'controller' => 'scsi',
@@ -207,7 +224,7 @@ module ForemanFogProxmox
             }
           }
         }.with_indifferent_access
-        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'proxmox', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
         err = assert_raises Foreman::Exception do
           @cr.save_vm(uuid, new_attributes)
         end
@@ -219,20 +236,24 @@ module ForemanFogProxmox
         config = mock('config')
         disks = mock('disks')
         disk = mock('disk')
+        disk.stubs(:id).returns('scsi0')
         disk.stubs(:size).returns(1_073_741_824)
         disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:attributes).returns(id: 'scsi0', storage: 'local-lvm', size: 1_073_741_824)
         disks.stubs(:get).returns(disk)
         config.stubs(:disks).returns(disks)
         config.stubs(:attributes).returns(:cores => '')
         vm = mock('vm')
+        vm.stubs(:identity).returns(uuid)
+        vm.stubs(:attributes).returns('scsi0' => '')
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(false)
         vm.stubs(:type).returns('qemu')
-        vm.stubs(:node_id).returns('pve')
+        vm.stubs(:node_id).returns('proxmox')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
-          'node_id' => 'pve',
+          'node_id' => 'proxmox',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -241,6 +262,7 @@ module ForemanFogProxmox
             '0' => {
               'id' => 'scsi0',
               '_delete' => '',
+              'storage_type' => 'hard_disk',
               'volid' => 'local-lvm:vm-100-disk-0',
               'device' => '0',
               'controller' => 'scsi',
@@ -250,7 +272,7 @@ module ForemanFogProxmox
             }
           }
         }.with_indifferent_access
-        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'proxmox', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
         expected_config_attr = { :cores => '1', :cpulimit => '1' }
         expected_volume_attr = ['scsi0', 'local-lvm2']
         vm.expects(:move, expected_volume_attr)
@@ -267,18 +289,21 @@ module ForemanFogProxmox
         disk.stubs(:storage).returns('local-lvm')
         disk.stubs(:volid).returns('local-lvm:vm-100-disk-0')
         disk.stubs(:id).returns('scsi0')
+        disk.stubs(:attributes).returns(id: 'scsi0', storage: 'local-lvm', volid: 'local-lvm:vm-100-disk-0', size: 1_073_741_824)
         disks.stubs(:get).returns(disk)
         config.stubs(:disks).returns(disks)
         config.stubs(:attributes).returns(:cores => '')
         vm = mock('vm')
+        vm.stubs(:identity).returns(uuid)
+        vm.stubs(:attributes).returns('scsi0' => '')
         vm.stubs(:config).returns(config)
         vm.stubs(:container?).returns(false)
         vm.stubs(:type).returns('qemu')
-        vm.stubs(:node_id).returns('pve')
+        vm.stubs(:node_id).returns('proxmox')
         @cr.stubs(:find_vm_by_uuid).returns(vm)
         new_attributes = {
           'templated' => '0',
-          'node_id' => 'pve',
+          'node_id' => 'proxmox',
           'config_attributes' => {
             'cores' => '1',
             'cpulimit' => '1'
@@ -287,6 +312,7 @@ module ForemanFogProxmox
             '0' => {
               'id' => 'scsi0',
               '_delete' => '',
+              'storage_type' => 'hard_disk',
               'volid' => 'local-lvm:vm-100-disk-0',
               'device' => '0',
               'controller' => 'scsi',
@@ -296,7 +322,7 @@ module ForemanFogProxmox
             }
           }
         }.with_indifferent_access
-        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'proxmox', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
         expected_config_attr = { :cores => '1', :cpulimit => '1' }
         expected_volume_attr = { :id => 'scsi0', :volid => 'local-lvm:vm-100-disk-0', :size => 1_073_741_824 }, { :cache => 'directsync' }
         vm.expects(:attach, expected_volume_attr)