foreman_fog_proxmox 0.10.2 → 0.11.0

data/locale/fr/foreman_fog_proxmox.po

@@ -32,9 +32,6 @@ msgstr ""
 msgid "Average load (x100)"
 msgstr "Charge moyenne du serveur (x100)"
 
-msgid "Ballooning Device"
-msgstr "Périphérique à gonflement"
-
 msgid "Boot device order"
 msgstr ""
 
@@ -238,6 +235,9 @@ msgstr "Chemin"
 msgid "Physical"
 msgstr "Physique"
 
+msgid "Pool"
+msgstr ""
+
 msgid "Power"
 msgstr "Alimentation"
 
@@ -265,6 +265,9 @@ msgstr "Mot de passe root"
 msgid "Rootfs"
 msgstr ""
 
+msgid "SCSI Controller"
+msgstr ""
+
 msgid "SSL verify peer"
 msgstr ""
 
@@ -349,6 +352,9 @@ msgstr "Autorités de certification X509"
 msgid "add new storage volume"
 msgstr "ajouter un nouveau volume de stockage"
 
+msgid "add_vm_to_pool(%<poolid>s, %<vmid>s)"
+msgstr ""
+
 msgid "create_vm(): clone %<image_id>s in %<vmid>s"
 msgstr ""
 
@@ -364,6 +370,9 @@ msgstr "par exemple root@pam"
 msgid "failed to create vm: %<e>s"
 msgstr "échec à la création de la VM: %<e>s"
 
+msgid "found vm: %<vmid>s member of pool: %<poolid>s"
+msgstr ""
+
 msgid "invalid vmid=%<vmid>s"
 msgstr "vmid=%<vmid>s incorrect"
 
@@ -376,11 +385,17 @@ msgstr ""
 msgid "new_vm() vm.config=%<config>s"
 msgstr ""
 
+msgid "pool_owner(%<vmid>s)"
+msgstr ""
+
 msgid "remove network interface"
 msgstr "retirer l'interface réseau"
 
 msgid "remove storage volume"
 msgstr "retirer le stockage de volume"
 
+msgid "remove_vm_from_pool(%<poolid>s, %<vmid>s)"
+msgstr ""
+
 msgid "vmid of template vm."
 msgstr "vmid de la VM modèle."

data/test/factories/foreman_fog_proxmox/proxmox_node_mock_factory.rb

@@ -75,6 +75,12 @@ module ForemanFogProxmox
       client = mock('client')
       client.stubs(:nodes).returns(nodes)
       cr.stubs(:client).returns(client)
+      identity_client = mock('identity_client')
+      pools = mock('pools')
+      pools.stubs(:select).returns([])
+      pools.stubs(:all).returns([])
+      identity_client.stubs(:pools).returns(pools)
+      cr.stubs(:identity_client).returns(identity_client)
       cr
     end
   end

data/test/unit/foreman_fog_proxmox/helpers/proxmox_container_helper_test.rb

@@ -187,17 +187,17 @@ module ForemanFogProxmox
         deletes = []
         nics = []
         add_container_interface(host_delete['interfaces_attributes']['0'], deletes, nics)
-        assert nics.empty?
+        assert_empty nics
         assert_equal 1, deletes.length
         assert_equal 'net0', deletes[0]
       end
 
       test '#interfaces' do
         interfaces_to_add, interfaces_to_delete = parse_container_interfaces(host['interfaces_attributes'])
-        assert interfaces_to_delete.empty?
+        assert_empty interfaces_to_delete
         assert_equal 2, interfaces_to_add.length
-        assert interfaces_to_add.include?(net0: 'name=eth0,bridge=vmbr0,ip=dhcp,ip6=dhcp,gw=192.168.56.100,gw6=2001:0:1234::c1c0:abcd:876')
-        assert interfaces_to_add.include?(net1: 'name=eth1,bridge=vmbr0,ip=dhcp,ip6=dhcp,gw=192.168.56.100,gw6=2001:0:1234::c1c0:abcd:876')
+        assert_includes interfaces_to_add, { net0: 'name=eth0,bridge=vmbr0,ip=dhcp,ip6=dhcp,gw=192.168.56.100,gw6=2001:0:1234::c1c0:abcd:876' }
+        assert_includes interfaces_to_add, { net1: 'name=eth1,bridge=vmbr0,ip=dhcp,ip6=dhcp,gw=192.168.56.100,gw6=2001:0:1234::c1c0:abcd:876' }
       end
     end
   end

data/test/unit/foreman_fog_proxmox/helpers/proxmox_server_helper_test.rb

@@ -35,9 +35,8 @@ module ForemanFogProxmox
           'type' => 'qemu',
           'config_attributes' => {
             'memory' => '536870912',
-            'min_memory' => '',
-            'ballon' => '',
-            'shares' => '',
+            'balloon' => '268435456',
+            'shares' => '5',
             'cpu_type' => 'kvm64',
             'spectre' => '1',
             'pcid' => '0',
@@ -83,6 +82,8 @@ module ForemanFogProxmox
         assert_equal '1', vm['sockets']
         assert_equal 'cputype=kvm64,flags=+spec-ctrl', vm[:cpu]
         assert_equal 536_870_912, vm[:memory]
+        assert_equal 268_435_456, vm[:balloon]
+        assert_equal 5, vm[:shares]
         assert_equal 'local-lvm:1073741824,cache=none', vm[:scsi0]
         assert_equal 'model=virtio,bridge=vmbr0,firewall=0,link_down=0', vm[:net0]
         assert_not vm.key?(:config)
@@ -111,7 +112,7 @@ module ForemanFogProxmox
         interfaces_to_delete = []
         interfaces_to_add = []
         add_server_interface(host['interfaces_attributes']['0'], interfaces_to_delete, interfaces_to_add)
-        assert interfaces_to_delete.empty?
+        assert_empty interfaces_to_delete
         assert_equal 1, interfaces_to_add.length
         assert interfaces_to_add[0].key?(:net0)
         assert_equal 'model=virtio,bridge=vmbr0,firewall=0,link_down=0', interfaces_to_add[0][:net0]
@@ -121,7 +122,7 @@ module ForemanFogProxmox
         interfaces_to_delete = []
         interfaces_to_add = []
         add_server_interface(host['interfaces_attributes']['1'], interfaces_to_delete, interfaces_to_add)
-        assert interfaces_to_delete.empty?
+        assert_empty interfaces_to_delete
         assert_equal 1, interfaces_to_add.length
         assert interfaces_to_add[0].key?(:net1)
         assert_equal 'model=e1000,bridge=vmbr0,firewall=0,link_down=0', interfaces_to_add[0][:net1]
@@ -131,17 +132,17 @@ module ForemanFogProxmox
         interfaces_to_delete = []
         interfaces_to_add = []
         add_server_interface(host_delete['interfaces_attributes']['0'], interfaces_to_delete, interfaces_to_add)
-        assert interfaces_to_add.empty?
+        assert_empty interfaces_to_add
         assert_equal 1, interfaces_to_delete.length
         assert_equal 'net0', interfaces_to_delete[0]
       end
 
       test '#interfaces' do
         interfaces_to_add, interfaces_to_delete = parse_server_interfaces(host['interfaces_attributes'])
-        assert interfaces_to_delete.empty?
+        assert_empty interfaces_to_delete
         assert_equal 2, interfaces_to_add.length
-        assert interfaces_to_add.include?(net0: 'model=virtio,bridge=vmbr0,firewall=0,link_down=0')
-        assert interfaces_to_add.include?(net1: 'model=e1000,bridge=vmbr0,firewall=0,link_down=0')
+        assert_includes interfaces_to_add, { net0: 'model=virtio,bridge=vmbr0,firewall=0,link_down=0' }
+        assert_includes interfaces_to_add, { net1: 'model=e1000,bridge=vmbr0,firewall=0,link_down=0' }
       end
     end
   end

data/test/unit/foreman_fog_proxmox/helpers/proxmox_vm_helper_test.rb

@@ -209,7 +209,7 @@ module ForemanFogProxmox
 
       it '#container swap empty' do
         convert_memory_size(host_container['config_attributes'], 'swap')
-        assert host_container['config_attributes']['swap'].empty?
+        assert_empty host_container['config_attributes']['swap']
       end
     end
   end

data/test/unit/foreman_fog_proxmox/proxmox_version_test.rb

@@ -72,22 +72,22 @@ module ForemanFogProxmox
 
       it 'is true with 5.4-3' do
         @identity_client.stubs(:read_version).returns(supported_version)
-        assert_equal true, @cr.version_suitable?
+        assert @cr.version_suitable?
       end
 
       it 'is true with 6.0-1' do
         @identity_client.stubs(:read_version).returns(supported_6_version)
-        assert_equal true, @cr.version_suitable?
+        assert @cr.version_suitable?
       end
 
       it 'is true with 6.1-3' do
         @identity_client.stubs(:read_version).returns(supported_6_1_version)
-        assert_equal true, @cr.version_suitable?
+        assert @cr.version_suitable?
       end
 
       it 'is false with 5.2-2' do
         @identity_client.stubs(:read_version).returns(unsupported_version)
-        assert_equal false, @cr.version_suitable?
+        assert_not @cr.version_suitable?
       end
     end
   end

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_container_test.rb

@@ -253,6 +253,20 @@ module ForemanFogProxmox
         cr.create_vm(args)
       end
 
+      it 'creates container within pool' do
+        args = { vmid: '100', type: 'lxc', node_id: 'pve', start_after_create: '0', pool: 'pool1' }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(true)
+        containers = mock('containers')
+        vm = mock('vm')
+        containers.stubs(:create).with(vmid: 100, type: 'lxc', node_id: 'pve', start_after_create: '0', pool: 'pool1').returns(vm)
+        cr = mock_node_servers_containers(ForemanFogProxmox::Proxmox.new, servers, containers)
+        cr.stubs(:convert_sizes).with(args)
+        cr.stubs(:parse_container_vm).with(args).returns(args)
+        cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
+        cr.create_vm(args)
+      end
+
       it 'clones container' do
         args = { vmid: '100', type: 'lxc', image_id: '999', name: 'name' }
         servers = mock('servers')

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_create_test.rb

@@ -69,6 +69,20 @@ module ForemanFogProxmox
         cr.create_vm(args)
       end
 
+      it 'creates server within pool' do
+        args = { vmid: '100', type: 'qemu', node_id: 'pve', start_after_create: '0', pool: 'pool1' }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(true)
+        cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
+        cr.stubs(:convert_sizes).with(args)
+        cr.stubs(:parse_server_vm).with(args).returns(args)
+        vm = mock('vm')
+        servers.stubs(:create).with(args).returns(vm)
+        cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
+        cr.stubs(:start_on_boot).with(vm, args).returns(vm)
+        cr.create_vm(args)
+      end
+
       it 'clones server' do
         args = { vmid: '100', type: 'qemu', image_id: '999', name: 'name' }
         servers = mock('servers')

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_test.rb

@@ -126,6 +126,97 @@ module ForemanFogProxmox
         vm.expects(:update, expected_config_attr)
         @cr.save_vm(uuid, new_attributes)
       end
+
+      it 'saves server config with modified pool' do
+        uuid = '100'
+        config = mock('config')
+        config.stubs(:pool).returns('pool1')
+        config.expects(:pool=).with('pool1')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        vm.stubs(:vmid).returns(uuid)
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        identity_client = mock('identity_client')
+        pools = mock('pools')
+        pool1 = mock('pool1')
+        pool1.stubs(:poolid).returns('pool1')
+        pool1.stubs(:has_server?).with('100').returns(true)
+        pool1.expects(:remove_server).with(uuid)
+        pool2 = mock('pool2')
+        pool2.stubs(:poolid).returns('pool2')
+        pool2.stubs(:has_server?).with('100').returns(false)
+        pool2.expects(:add_server).with(uuid)
+        pools.stubs(:all).returns([pool1, pool2])
+        pools.expects(:get).with('pool1').returns(pool1)
+        pools.expects(:get).with('pool2').returns(pool2)
+        identity_client.stubs(:pools).returns(pools)
+        @cr.stubs(:identity_client).returns(identity_client)
+        attr = { 'templated' => '0', 'node_id' => 'pve', 'pool' => 'pool2', 'config_attributes' => { 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' } }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0', 'pool' => 'pool2')
+        vm.expects(:update).with({ 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' }.with_indifferent_access)
+        @cr.save_vm(uuid, attr)
+      end
+
+      it 'saves server config with removed pool' do
+        uuid = '100'
+        config = mock('config')
+        config.expects(:pool=).with('pool1')
+        config.stubs(:pool).returns('pool1')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        vm.stubs(:vmid).returns(uuid)
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        identity_client = mock('identity_client')
+        pools = mock('pools')
+        pool1 = mock('pool1')
+        pool1.stubs(:has_server?).with('100').returns(true)
+        pool1.stubs(:poolid).returns('pool1')
+        pool1.expects(:remove_server).with(uuid)
+        pools.stubs(:all).returns([pool1])
+        pools.expects(:get).with('pool1').returns(pool1)
+        pools.expects(:get).with('').returns(nil)
+        identity_client.stubs(:pools).returns(pools)
+        @cr.stubs(:identity_client).returns(identity_client)
+        attr = { 'templated' => '0', 'node_id' => 'pve', 'pool' => '', 'config_attributes' => { 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' } }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0', 'pool' => '')
+        vm.expects(:update).with({ 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' }.with_indifferent_access)
+        @cr.save_vm(uuid, attr)
+      end
+
+      it 'saves server config with added pool' do
+        uuid = '100'
+        config = mock('config')
+        config.expects(:pool=).with(nil)
+        config.stubs(:pool).returns(nil)
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        vm.stubs(:vmid).returns(uuid)
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        identity_client = mock('identity_client')
+        pools = mock('pools')
+        pool2 = mock('pool2')
+        pool2.stubs(:has_server?).with('100').returns(false)
+        pool2.stubs(:poolid).returns('pool2')
+        pool2.expects(:add_server).with(uuid)
+        pools.stubs(:all).returns([pool2])
+        pools.expects(:get).with('pool2').returns(pool2)
+        pools.expects(:get).with('').returns(nil)
+        identity_client.stubs(:pools).returns(pools)
+        @cr.stubs(:identity_client).returns(identity_client)
+        attr = { 'templated' => '0', 'node_id' => 'pve', 'pool' => 'pool2', 'config_attributes' => { 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' } }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0', 'pool' => 'pool2')
+        vm.expects(:update).with({ 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' }.with_indifferent_access)
+        @cr.save_vm(uuid, attr)
+      end
     end
   end
 end

data/test/unit/foreman_fog_proxmox/proxmox_vm_queries_test.rb

@@ -49,14 +49,19 @@ module ForemanFogProxmox
       it 'finds vm on other node in cluster' do
         args = { vmid: '100', type: 'qemu' }
         servers = mock('servers')
+        vm = mock('vm')
+        vm.stubs(:vmid).returns(args[:vmid])
+        config = mock('config')
+        config.expects(:pool=, nil)
+        vm.stubs(:config).returns(config)
         servers.stubs(:id_valid?).returns(true)
-        servers.stubs(:get).with(args[:vmid]).returns(args)
+        servers.stubs(:get).with(args[:vmid]).returns(vm)
         cr = mock_cluster_nodes_servers_containers(
           ForemanFogProxmox::Proxmox.new,
           empty_servers, empty_servers, # node1
           servers, empty_servers        # node2
         )
-        assert_equal args, cr.find_vm_by_uuid(args[:vmid])
+        assert_equal vm, cr.find_vm_by_uuid(args[:vmid])
       end
     end
   end

data/test/unit/foreman_fog_proxmox/semver_test.rb

@@ -57,7 +57,6 @@ module ForemanFogProxmox
         end
       end
     end
-    # rubocop:disable Lint/UselessComparison
     describe 'semverclass comparators' do
       it '#5.3.0 <= 5.4.3 returns true' do
         assert ForemanFogProxmox::Semver.to_semver('5.3.0') <= ForemanFogProxmox::Semver.to_semver('5.4.3')
@@ -78,7 +77,7 @@ module ForemanFogProxmox
         assert ForemanFogProxmox::Semver.to_semver('1.0.10') <= ForemanFogProxmox::Semver.to_semver('1.0.20')
       end
       it '#1.2.3-beta == 1.2.3-beta returns true' do
-        assert ForemanFogProxmox::Semver.to_semver('1.2.3-beta') == ForemanFogProxmox::Semver.to_semver('1.2.3-beta')
+        assert_equal ForemanFogProxmox::Semver.to_semver('1.2.3-beta'), ForemanFogProxmox::Semver.to_semver('1.2.3-beta')
       end
       it '#1.2.3-beta >= 1.-beta raises ArgumentError' do
         assert_raises ArgumentError do
@@ -101,13 +100,12 @@ module ForemanFogProxmox
         assert_equal 20, ForemanFogProxmox::Semver.to_semver('1.20.0').minor
         assert_equal 0, ForemanFogProxmox::Semver.to_semver('1.20.0').patch
         assert ForemanFogProxmox::Semver.to_semver('0.10.2').major < ForemanFogProxmox::Semver.to_semver('1.20.0').major
-        assert_equal false, ForemanFogProxmox::Semver.to_semver('0.10.2').major == ForemanFogProxmox::Semver.to_semver('1.20.0').major
-        assert_equal false, ForemanFogProxmox::Semver.to_semver('0.10.2').minor == ForemanFogProxmox::Semver.to_semver('1.20.0').minor
+        assert_not ForemanFogProxmox::Semver.to_semver('0.10.2').major == ForemanFogProxmox::Semver.to_semver('1.20.0').major
+        assert_not ForemanFogProxmox::Semver.to_semver('0.10.2').minor == ForemanFogProxmox::Semver.to_semver('1.20.0').minor
         assert ForemanFogProxmox::Semver.to_semver('0.10.2').minor < ForemanFogProxmox::Semver.to_semver('1.20.0').minor
         assert ForemanFogProxmox::Semver.to_semver('0.10.2').patch > ForemanFogProxmox::Semver.to_semver('1.20.0').patch
         assert ForemanFogProxmox::Semver.to_semver('0.10.2') < ForemanFogProxmox::Semver.to_semver('1.20.0')
       end
     end
-    # rubocop:enable Lint/UselessComparison
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman_fog_proxmox
 version: !ruby/object:Gem::Version
-  version: 0.10.2
+  version: 0.11.0
 platform: ruby
 authors:
 - Tristan Robert
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-12 00:00:00.000000000 Z
+date: 2020-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface
@@ -31,14 +31,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: '0.12'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: '0.12'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
@@ -121,6 +121,7 @@ files:
 - app/models/foreman_fog_proxmox/proxmox_images.rb
 - app/models/foreman_fog_proxmox/proxmox_interfaces.rb
 - app/models/foreman_fog_proxmox/proxmox_operating_systems.rb
+- app/models/foreman_fog_proxmox/proxmox_pools.rb
 - app/models/foreman_fog_proxmox/proxmox_token_expiration.rb
 - app/models/foreman_fog_proxmox/proxmox_version.rb
 - app/models/foreman_fog_proxmox/proxmox_vm_commands.rb
@@ -228,25 +229,25 @@ signing_key:
 specification_version: 4
 summary: Foreman plugin that adds Proxmox VE compute resource using fog-proxmox
 test_files:
-- test/test_plugin_helper.rb
+- test/factories/proxmox_factory.rb
+- test/factories/foreman_fog_proxmox/proxmox_container_mock_factory.rb
+- test/factories/foreman_fog_proxmox/proxmox_server_mock_factory.rb
+- test/factories/foreman_fog_proxmox/proxmox_node_mock_factory.rb
 - test/functional/compute_resources_controller_test.rb
+- test/test_plugin_helper.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_new_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_images_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_test.rb
 - test/unit/foreman_fog_proxmox/proxmox_vm_commands_container_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_vm_commands_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_volumes_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_version_test.rb
 - test/unit/foreman_fog_proxmox/proxmox_vm_queries_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_compute_attributes_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_version_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_volumes_test.rb
 - test/unit/foreman_fog_proxmox/semver_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_images_test.rb
 - test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_create_test.rb
-- test/unit/foreman_fog_proxmox/proxmox_vm_new_test.rb
-- test/unit/foreman_fog_proxmox/helpers/proxmox_vm_helper_test.rb
-- test/unit/foreman_fog_proxmox/helpers/proxmox_container_helper_test.rb
-- test/unit/foreman_fog_proxmox/helpers/proxmox_server_helper_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_compute_attributes_test.rb
 - test/unit/foreman_fog_proxmox/proxmox_test.rb
+- test/unit/foreman_fog_proxmox/proxmox_vm_commands_test.rb
 - test/unit/foreman_fog_proxmox/proxmox_interfaces_test.rb
-- test/factories/foreman_fog_proxmox/proxmox_container_mock_factory.rb
-- test/factories/foreman_fog_proxmox/proxmox_node_mock_factory.rb
-- test/factories/foreman_fog_proxmox/proxmox_server_mock_factory.rb
-- test/factories/proxmox_factory.rb
+- test/unit/foreman_fog_proxmox/helpers/proxmox_container_helper_test.rb
+- test/unit/foreman_fog_proxmox/helpers/proxmox_server_helper_test.rb
+- test/unit/foreman_fog_proxmox/helpers/proxmox_vm_helper_test.rb