foreman_fog_proxmox 0.12.0

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_create_test.rb

@@ -0,0 +1,110 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'test_plugin_helper'
+require 'models/compute_resources/compute_resource_test_helpers'
+require 'factories/foreman_fog_proxmox/proxmox_node_mock_factory'
+require 'factories/foreman_fog_proxmox/proxmox_server_mock_factory'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module ForemanFogProxmox
+  class ProxmoxVmCommandsServerCreateTest < ActiveSupport::TestCase
+    include ComputeResourceTestHelpers
+    include ProxmoxNodeMockFactory
+    include ProxmoxServerMockFactory
+    include ProxmoxVmHelper
+
+    describe 'create_vm' do
+      it 'raises Foreman::Exception when vmid <= 100 and vmid > 0' do
+        args = { vmid: '100' }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(false)
+        cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
+        err = assert_raises Foreman::Exception do
+          cr.create_vm(args)
+        end
+        assert err.message.end_with?('invalid vmid=100')
+      end
+
+      it 'computes next vmid when vmid == 0 and creates server' do
+        args = { vmid: '0', type: 'qemu', node_id: 'pve', start_after_create: '0' }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(true)
+        servers.stubs(:next_id).returns('101')
+        cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
+        cr.stubs(:convert_sizes).with(args)
+        cr.stubs(:parse_server_vm).with(args).returns(args)
+        servers.stubs(:create).with(args)
+        vm = mock('vm')
+        cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
+        cr.create_vm(args)
+      end
+
+      it 'creates server without bootstart' do
+        args = { vmid: '100', type: 'qemu', node_id: 'pve', start_after_create: '0' }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(true)
+        cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
+        cr.stubs(:convert_sizes).with(args)
+        cr.stubs(:parse_server_vm).with(args).returns(args)
+        servers.stubs(:create).with(args)
+        vm = mock('vm')
+        cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
+        cr.create_vm(args)
+      end
+
+      it 'creates server with bootstart' do
+        args = { vmid: '100', type: 'qemu', node_id: 'pve', start_after_create: '1' }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(true)
+        cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
+        cr.stubs(:convert_sizes).with(args)
+        cr.stubs(:parse_server_vm).with(args).returns(args)
+        vm = mock('vm')
+        servers.stubs(:create).with(args).returns(vm)
+        cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
+        cr.stubs(:start_on_boot).with(vm, args).returns(vm)
+        cr.create_vm(args)
+      end
+
+      it 'creates server within pool' do
+        args = { vmid: '100', type: 'qemu', node_id: 'pve', start_after_create: '0', pool: 'pool1' }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(true)
+        cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
+        cr.stubs(:convert_sizes).with(args)
+        cr.stubs(:parse_server_vm).with(args).returns(args)
+        vm = mock('vm')
+        servers.stubs(:create).with(args).returns(vm)
+        cr.stubs(:find_vm_by_uuid).with((args[:vmid]).to_s).returns(vm)
+        cr.stubs(:start_on_boot).with(vm, args).returns(vm)
+        cr.create_vm(args)
+      end
+
+      it 'clones server' do
+        args = { vmid: '100', type: 'qemu', image_id: '999', name: 'name' }
+        servers = mock('servers')
+        servers.stubs(:id_valid?).returns(true)
+        cr = mock_node_servers(ForemanFogProxmox::Proxmox.new, servers)
+        cr.expects(:clone_from_image).with('999', args, 100)
+        cr.create_vm(args)
+      end
+    end
+  end
+end

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_test.rb

@@ -0,0 +1,222 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'test_plugin_helper'
+require 'models/compute_resources/compute_resource_test_helpers'
+require 'factories/foreman_fog_proxmox/proxmox_node_mock_factory'
+require 'factories/foreman_fog_proxmox/proxmox_server_mock_factory'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module ForemanFogProxmox
+  class ProxmoxVmCommandsServerUpdateTest < ActiveSupport::TestCase
+    include ComputeResourceTestHelpers
+    include ProxmoxNodeMockFactory
+    include ProxmoxServerMockFactory
+    include ProxmoxVmHelper
+
+    describe 'save_vm' do
+      before do
+        @cr = FactoryBot.build_stubbed(:proxmox_cr)
+      end
+
+      it 'migrates server from node to another one in the cluster' do
+        uuid = '100'
+        config = mock('config')
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:templated?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        attr = { 'templated' => '0', 'node_id' => 'pve2' }
+        vm.expects(:migrate)
+        @cr.save_vm(uuid, attr)
+      end
+
+      it 'saves modified server config with same volumes' do
+        uuid = '100'
+        config = mock('config')
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:templated?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        attr = { 'templated' => '0', 'node_id' => 'pve', 'config_attributes' => { 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' } }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0')
+        expected_attr = { :cores => '1', :cpulimit => '1' }.with_indifferent_access
+        vm.expects(:update, expected_attr)
+        @cr.save_vm(uuid, attr)
+      end
+
+      it 'saves server as template' do
+        uuid = '100'
+        config = mock('config')
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:templated?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        attr = { 'templated' => '1' }
+        vm.expects(:create_template)
+        @cr.save_vm(uuid, attr)
+      end
+
+      it 'saves modified server config with removed interfaces' do
+        uuid = '100'
+        config = mock('config')
+        interfaces = mock('interfaces')
+        interface = mock('interface')
+        interface.stubs(:id).returns('net0')
+        interfaces.stubs(:get).returns(interface)
+        config.stubs(:interfaces).returns(interfaces)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'node_id' => 'pve',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'interfaces_attributes' => {
+            '0' => {
+              '_delete' => '1',
+              'id' => 'net0'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns(
+          'vmid' => '100',
+          'node_id' => 'pve',
+          'type' => 'qemu',
+          'cores' => '1',
+          'cpulimit' => '1',
+          'delete' => 'net0',
+          'onboot' => '0'
+        )
+        expected_config_attr = { :cores => '1', :cpulimit => '1', :delete => 'net0' }
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+
+      it 'saves server config with modified pool' do
+        uuid = '100'
+        config = mock('config')
+        config.stubs(:pool).returns('pool1')
+        config.expects(:pool=).with('pool1')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        vm.stubs(:vmid).returns(uuid)
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        identity_client = mock('identity_client')
+        pools = mock('pools')
+        pool1 = mock('pool1')
+        pool1.stubs(:poolid).returns('pool1')
+        pool1.stubs(:has_server?).with('100').returns(true)
+        pool1.expects(:remove_server).with(uuid)
+        pool2 = mock('pool2')
+        pool2.stubs(:poolid).returns('pool2')
+        pool2.stubs(:has_server?).with('100').returns(false)
+        pool2.expects(:add_server).with(uuid)
+        pools.stubs(:all).returns([pool1, pool2])
+        pools.expects(:get).with('pool1').returns(pool1)
+        pools.expects(:get).with('pool2').returns(pool2)
+        identity_client.stubs(:pools).returns(pools)
+        @cr.stubs(:identity_client).returns(identity_client)
+        attr = { 'templated' => '0', 'node_id' => 'pve', 'pool' => 'pool2', 'config_attributes' => { 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' } }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0', 'pool' => 'pool2')
+        vm.expects(:update).with({ 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' }.with_indifferent_access)
+        @cr.save_vm(uuid, attr)
+      end
+
+      it 'saves server config with removed pool' do
+        uuid = '100'
+        config = mock('config')
+        config.expects(:pool=).with('pool1')
+        config.stubs(:pool).returns('pool1')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        vm.stubs(:vmid).returns(uuid)
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        identity_client = mock('identity_client')
+        pools = mock('pools')
+        pool1 = mock('pool1')
+        pool1.stubs(:has_server?).with('100').returns(true)
+        pool1.stubs(:poolid).returns('pool1')
+        pool1.expects(:remove_server).with(uuid)
+        pools.stubs(:all).returns([pool1])
+        pools.expects(:get).with('pool1').returns(pool1)
+        pools.expects(:get).with('').returns(nil)
+        identity_client.stubs(:pools).returns(pools)
+        @cr.stubs(:identity_client).returns(identity_client)
+        attr = { 'templated' => '0', 'node_id' => 'pve', 'pool' => '', 'config_attributes' => { 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' } }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0', 'pool' => '')
+        vm.expects(:update).with({ 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' }.with_indifferent_access)
+        @cr.save_vm(uuid, attr)
+      end
+
+      it 'saves server config with added pool' do
+        uuid = '100'
+        config = mock('config')
+        config.expects(:pool=).with(nil)
+        config.stubs(:pool).returns(nil)
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        vm.stubs(:vmid).returns(uuid)
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        identity_client = mock('identity_client')
+        pools = mock('pools')
+        pool2 = mock('pool2')
+        pool2.stubs(:has_server?).with('100').returns(false)
+        pool2.stubs(:poolid).returns('pool2')
+        pool2.expects(:add_server).with(uuid)
+        pools.stubs(:all).returns([pool2])
+        pools.expects(:get).with('pool2').returns(pool2)
+        pools.expects(:get).with('').returns(nil)
+        identity_client.stubs(:pools).returns(pools)
+        @cr.stubs(:identity_client).returns(identity_client)
+        attr = { 'templated' => '0', 'node_id' => 'pve', 'pool' => 'pool2', 'config_attributes' => { 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' } }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0', 'pool' => 'pool2')
+        vm.expects(:update).with({ 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0' }.with_indifferent_access)
+        @cr.save_vm(uuid, attr)
+      end
+    end
+  end
+end

data/test/unit/foreman_fog_proxmox/proxmox_vm_commands_server_update_volumes_test.rb

@@ -0,0 +1,308 @@
+# frozen_string_literal: true
+
+# Copyright 2018 Tristan Robert
+
+# This file is part of ForemanFogProxmox.
+
+# ForemanFogProxmox is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# ForemanFogProxmox is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with ForemanFogProxmox. If not, see <http://www.gnu.org/licenses/>.
+
+require 'test_plugin_helper'
+require 'models/compute_resources/compute_resource_test_helpers'
+require 'factories/foreman_fog_proxmox/proxmox_node_mock_factory'
+require 'factories/foreman_fog_proxmox/proxmox_server_mock_factory'
+require 'active_support/core_ext/hash/indifferent_access'
+
+module ForemanFogProxmox
+  class ProxmoxVmCommandsServerUpdateTest < ActiveSupport::TestCase
+    include ComputeResourceTestHelpers
+    include ProxmoxNodeMockFactory
+    include ProxmoxServerMockFactory
+    include ProxmoxVmHelper
+
+    describe 'save_vm' do
+      before do
+        @cr = FactoryBot.build_stubbed(:proxmox_cr)
+      end
+
+      it 'saves modified server config with added volumes' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:id).returns('scsi0')
+        disks.stubs(:get).returns
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'node_id' => 'pve',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'scsi0',
+              '_delete' => '',
+              'device' => '0',
+              'controller' => 'scsi',
+              'storage' => 'local-lvm',
+              'size' => '2147483648',
+              'cache' => 'none'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'onboot' => '0')
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = { id: 'scsi0', storage: 'local:lvm', size: (2_147_483_648 / GIGA).to_s }
+        vm.expects(:attach, expected_volume_attr)
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+
+      it 'saves modified server config with removed volumes' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:id).returns('virtio0')
+        disks.stubs(:get).returns(disk)
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:templated?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'node_id' => 'pve',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              '_delete' => '1',
+              'id' => 'scsi0',
+              'volid' => 'local-lvm:vm-100-disk-0',
+              'device' => '0',
+              'controller' => 'scsi',
+              'storage' => 'local-lvm',
+              'size' => '2147483648',
+              'cache' => 'none'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1', 'config_attributes' => { 'onboot' => '0' })
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = 'scsi0'
+        vm.expects(:detach, expected_volume_attr)
+        vm.expects(:detach, 'unused0')
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+
+      it 'saves modified server config with resized volumes' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disks.stubs(:get).returns(disk)
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:templated?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'node_id' => 'pve',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'scsi0',
+              '_delete' => '',
+              'volid' => 'local-lvm:vm-100-disk-0',
+              'device' => '0',
+              'controller' => 'scsi',
+              'storage' => 'local-lvm',
+              'size' => '2147483648',
+              'cache' => 'none'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = ['scsi0', '+1G']
+        vm.expects(:extend, expected_volume_attr)
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+
+      it 'raises error unable to shrink volumes' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disks.stubs(:get).returns(disk)
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'node_id' => 'pve',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'scsi0',
+              '_delete' => '',
+              'volid' => 'local-lvm:vm-100-disk-0',
+              'device' => '0',
+              'controller' => 'scsi',
+              'storage' => 'local-lvm',
+              'size' => '2',
+              'cache' => 'none'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        err = assert_raises Foreman::Exception do
+          @cr.save_vm(uuid, new_attributes)
+        end
+        assert err.message.end_with?('Unable to shrink scsi0 size. Proxmox allows only increasing size.')
+      end
+
+      it 'saves modified server config with moved volumes' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disks.stubs(:get).returns(disk)
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'node_id' => 'pve',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'scsi0',
+              '_delete' => '',
+              'volid' => 'local-lvm:vm-100-disk-0',
+              'device' => '0',
+              'controller' => 'scsi',
+              'storage' => 'local-lvm2',
+              'size' => '1073741824',
+              'cache' => 'none'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = ['scsi0', 'local-lvm2']
+        vm.expects(:move, expected_volume_attr)
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+
+      it 'saves modified server config with modified volumes options' do
+        uuid = '100'
+        config = mock('config')
+        disks = mock('disks')
+        disk = mock('disk')
+        disk.stubs(:size).returns(1_073_741_824)
+        disk.stubs(:storage).returns('local-lvm')
+        disk.stubs(:volid).returns('local-lvm:vm-100-disk-0')
+        disk.stubs(:id).returns('scsi0')
+        disks.stubs(:get).returns(disk)
+        config.stubs(:disks).returns(disks)
+        config.stubs(:attributes).returns(:cores => '')
+        vm = mock('vm')
+        vm.stubs(:config).returns(config)
+        vm.stubs(:container?).returns(false)
+        vm.stubs(:type).returns('qemu')
+        vm.stubs(:node_id).returns('pve')
+        @cr.stubs(:find_vm_by_uuid).returns(vm)
+        new_attributes = {
+          'templated' => '0',
+          'node_id' => 'pve',
+          'config_attributes' => {
+            'cores' => '1',
+            'cpulimit' => '1'
+          },
+          'volumes_attributes' => {
+            '0' => {
+              'id' => 'scsi0',
+              '_delete' => '',
+              'volid' => 'local-lvm:vm-100-disk-0',
+              'device' => '0',
+              'controller' => 'scsi',
+              'storage' => 'local-lvm',
+              'size' => '1073741824',
+              'cache' => 'directsync'
+            }
+          }
+        }.with_indifferent_access
+        @cr.stubs(:parse_server_vm).returns('vmid' => '100', 'node_id' => 'pve', 'type' => 'qemu', 'cores' => '1', 'cpulimit' => '1')
+        expected_config_attr = { :cores => '1', :cpulimit => '1' }
+        expected_volume_attr = { :id => 'scsi0', :volid => 'local-lvm:vm-100-disk-0', :size => 1_073_741_824 }, { :cache => 'directsync' }
+        vm.expects(:attach, expected_volume_attr)
+        vm.expects(:update, expected_config_attr)
+        @cr.save_vm(uuid, new_attributes)
+      end
+    end
+  end
+end