foreman_docker 3.0.0 → 3.1.0

data/test/functionals/containers_controller_test.rb

@@ -1,6 +1,11 @@
 require 'test_plugin_helper'
 
 class ContainersControllerTest < ActionController::TestCase
+  setup do
+    stub_image_existance
+    stub_registry_api
+  end
+
   test 'redirect if Docker provider is not available' do
     get :index, {}, set_session_user
     assert_redirected_to new_compute_resource_path

data/test/functionals/containers_steps_controller_test.rb

@@ -3,14 +3,16 @@ require 'test_plugin_helper'
 module Containers
   class StepsControllerTest < ActionController::TestCase
     setup do
+      stub_image_existance
+      stub_registry_api
       @container = FactoryGirl.create(:container)
+      @state = DockerContainerWizardState.create!
     end
 
     test 'wizard finishes with a redirect to the managed container' do
-      state = DockerContainerWizardState.create!
-      Service::Containers.any_instance.expects(:start_container!).with(equals(state))
+      Service::Containers.any_instance.expects(:start_container!).with(equals(@state))
         .returns(@container)
-      put :update, { :wizard_state_id => state.id,
+      put :update, { :wizard_state_id => @state.id,
                      :id => :environment,
                      :start_on_create => true,
                      :docker_container_wizard_states_environment => { :tty => false } },
@@ -19,41 +21,68 @@ module Containers
       assert_redirected_to container_path(:id => @container.id)
     end
 
-    test 'image show doesnot load katello' do
-      compute_resource = FactoryGirl.create(:docker_cr)
-      state = DockerContainerWizardState.create!
-      create_options = { :wizard_state => state,
-                         :compute_resource_id => compute_resource.id
+    describe 'on image step' do
+      setup do
+        @compute_resource = FactoryGirl.create(:docker_cr)
+        @create_options = { :wizard_state => @state,
+                           :compute_resource_id => @compute_resource.id }
+        @state.preliminary = DockerContainerWizardStates::Preliminary.create!(@create_options)
+        DockerContainerWizardState.expects(:find).at_least_once.returns(@state)
+      end
+
+      test 'image show doesnot load katello' do
+        get :show, { :wizard_state_id => @state.id, :id => :image }, set_session_user
+        refute @state.image.katello?
+        refute response.body.include?("katello") # this is code generated by katello partial
+        docker_image = @controller.instance_eval do
+          @docker_container_wizard_states_image
+        end
+        assert_equal @state.image, docker_image
+      end
+
+      describe 'submitting' do
+        setup do
+          @image_params = {
+            docker_container_wizard_states_image: {
+              repository_name: 'test',
+              tag: 'test'
+          }}
+          @params = @image_params.merge({
+            wizard_state_id: @state.id,
+            id: :image,
+          })
+        end
+
+        test 'has no errors if the image exists' do
+          put :update, @params, set_session_user
+          assert_valid @state.image
+          assert css_select('#hub_image_search.has-error').size == 0
+        end
 
-                       }
-      state.preliminary = DockerContainerWizardStates::Preliminary.create!(create_options)
-      DockerContainerWizardState.expects(:find).at_least_once.returns(state)
-      get :show, { :wizard_state_id => state.id, :id => :image }, set_session_user
-      refute state.image.katello?
-      refute response.body.include?("katello") # this is code generated by katello partial
-      docker_image = @controller.instance_eval do
-        @docker_container_wizard_states_image
+        test 'shows an error when the image does not exist' do
+          stub_image_existance(false)
+          put :update, @params, set_session_user
+          refute_valid @state.image
+          assert_select '#hub_image_search.has-error'
+        end
       end
-      assert_equal state.image, docker_image
     end
 
     test 'new container respects exposed_ports configuration' do
-      state = DockerContainerWizardState.create!
       environment_options = {
-        :docker_container_wizard_state_id => state.id
+        :docker_container_wizard_state_id => @state.id
       }
-      state.environment = DockerContainerWizardStates::Environment.create!(environment_options)
-      state.environment.exposed_ports.create!(:name => '1654', :value => 'tcp')
-      state.environment.exposed_ports.create!(:name => '1655', :value => 'udp')
-      get :show, { :wizard_state_id => state.id, :id => :environment }, set_session_user
+      @state.environment = DockerContainerWizardStates::Environment.create!(environment_options)
+      @state.environment.exposed_ports.create!(:key => '1654', :value => 'tcp')
+      @state.environment.exposed_ports.create!(:key => '1655', :value => 'udp')
+      get :show, { :wizard_state_id => @state.id, :id => :environment }, set_session_user
       assert response.body.include?("1654")
       assert response.body.include?("1655")
 
       # Load ExposedPort variables into container
-      state.environment.exposed_ports.each do |e|
-        @container.exposed_ports.build :name => e.name,
-                                       :value => e.value,
-                                       :priority => e.priority
+      @state.environment.exposed_ports.each do |e|
+        @container.exposed_ports.build :key => e.key,
+                                       :value => e.value
       end
       # Check if parametrized value of container matches Docker API's expectations
       assert @container.parametrize.key? "ExposedPorts"
@@ -62,26 +91,35 @@ module Containers
     end
 
     test 'new container respects dns configuration' do
-      state = DockerContainerWizardState.create!
       environment_options = {
-        :docker_container_wizard_state_id => state.id
+        :docker_container_wizard_state_id => @state.id
       }
-      state.environment = DockerContainerWizardStates::Environment.create!(environment_options)
-      state.environment.dns.create!(:name => '18.18.18.18')
-      state.environment.dns.create!(:name => '19.19.19.19')
-      get :show, { :wizard_state_id => state.id, :id => :environment }, set_session_user
+      @state.environment = DockerContainerWizardStates::Environment.create!(environment_options)
+      @state.environment.dns.create!(:key => '18.18.18.18')
+      @state.environment.dns.create!(:key => '19.19.19.19')
+      get :show, { :wizard_state_id => @state.id, :id => :environment }, set_session_user
       assert response.body.include?("18.18.18.18")
       assert response.body.include?("19.19.19.19")
 
       # Load Dns variables into container
-      state.environment.dns.each do |e|
-        @container.dns.build :name => e.name,
-                             :priority => e.priority
+      @state.environment.dns.each do |e|
+        @container.dns.build :key => e.key
       end
       # Check if parametrized value of container matches Docker API's expectations
       assert @container.parametrize.key? "HostConfig"
       assert @container.parametrize["HostConfig"].key? "Dns"
       assert @container.parametrize["HostConfig"].value? ["18.18.18.18", "19.19.19.19"]
     end
+
+    test "does not create a container with 2 exposed ports with the same key" do
+      environment_options = {
+          :docker_container_wizard_state_id => @state.id
+      }
+      @state.environment = DockerContainerWizardStates::Environment.new(environment_options)
+      @state.environment.exposed_ports.new(:key => '1654', :value => 'tcp')
+      @state.environment.exposed_ports.new(:key => '1654', :value => 'udp')
+      refute_valid @state
+      assert_equal "Please ensure the following parameters are unique", @state.errors[:'environment.exposed_ports'].first
+    end
   end
 end

data/test/functionals/image_search_controller_test.rb

@@ -1,27 +1,179 @@
 require 'test_plugin_helper'
 
 class ImageSearchControllerTest < ActionController::TestCase
+  let(:docker_image) { 'centos' }
+  let(:tags) { ['latest', '5', '4.3'].map { |tag| "#{term}:#{tag}" } }
+  let(:term) { docker_image }
+
+  let(:docker_hub) { Service::RegistryApi.new(url: 'https://nothub.com') }
+  let(:compute_resource) { FactoryGirl.create(:docker_cr) }
+  let(:registry) { FactoryGirl.create(:docker_registry) }
+  let(:image_search_service) { ForemanDocker::ImageSearch.new }
+
   setup do
-    @container = FactoryGirl.create(:docker_cr)
+    Service::RegistryApi.stubs(:docker_hub).returns(docker_hub)
+    ComputeResource::ActiveRecord_Relation.any_instance
+      .stubs(:find).returns(compute_resource)
+    DockerRegistry::ActiveRecord_Relation.any_instance
+      .stubs(:find).returns(registry)
+  end
+
+  describe '#auto_complete_repository_name' do
+    test 'returns if an image is available' do
+      exists = ['true', 'false'].sample
+      search_type = ['hub', 'registry'].sample
+      subject.instance_variable_set(:@image_search_service, image_search_service)
+      image_search_service.expects(:available?).returns(exists)
+
+      xhr :get, :auto_complete_repository_name,
+        { registry: search_type, search: term,
+          id: compute_resource }, set_session_user
+      assert_equal exists, response.body
+    end
+
+    context 'it is a Docker Hub tab request' do
+      let(:search_type) { 'hub' }
+
+      test 'it queries the compute_resource and Docker Hub' do
+        compute_resource.expects(:image).with(term)
+          .returns(term)
+        compute_resource.expects(:tags_for_local_image)
+          .returns(tags)
+        docker_hub.expects(:tags).returns([])
+
+        xhr :get, :auto_complete_repository_name,
+          { registry: search_type, search: term,
+            id: compute_resource }, set_session_user
+      end
+    end
+
+    context 'it is a External Registry tab request' do
+      let(:search_type) { 'registry' }
+
+      test 'it only queries the registry api' do
+        compute_resource.expects(:image).with(term).never
+        docker_hub.expects(:tags).never
+        registry.api.expects(:tags).with(term, nil)
+          .returns(['latest'])
+
+        xhr :get, :auto_complete_repository_name,
+          { registry: search_type, registry_id: registry,
+            search: term, id: compute_resource }, set_session_user
+      end
+    end
+  end
+
+  describe '#auto_complete_image_tag' do
+    let(:tag_fragment) { 'lat' }
+    let(:term) { "#{docker_image}:#{tag_fragment}"}
+
+    test 'returns an array of { label:, value: } hashes' do
+      search_type = ['hub', 'registry'].sample
+      subject.instance_variable_set(:@image_search_service, image_search_service)
+      image_search_service.expects(:search)
+        .with({ term: term, tags: 'true' })
+        .returns(tags)
+      xhr :get, :auto_complete_image_tag,
+        { registry: search_type, search: term,
+          id: compute_resource }, set_session_user
+      assert_equal tags.first, JSON.parse(response.body).first['value']
+    end
+
+    context 'a Docker Hub tab request' do
+      let(:search_type) { 'hub' }
+
+      test 'it searches Docker Hub and the ComputeResource' do
+        compute_resource.expects(:image).with(docker_image)
+          .returns(term)
+        compute_resource.expects(:tags_for_local_image)
+          .returns(tags)
+        docker_hub.expects(:tags).returns([])
+
+        xhr :get, :auto_complete_image_tag,
+          { registry: search_type, search: term,
+            id: compute_resource }, set_session_user
+      end
+    end
+
+    context 'it is a External Registry tab request' do
+      let(:search_type) { 'registry' }
+
+      test 'it only queries the registry api' do
+        compute_resource.expects(:image).with(docker_image).never
+        docker_hub.expects(:tags).never
+        registry.api.expects(:tags).with(docker_image, tag_fragment)
+          .returns([])
+
+        xhr :get, :auto_complete_image_tag,
+          { registry: search_type, registry_id: registry,
+            search: term, id: compute_resource }, set_session_user
+      end
+    end
+  end
+
+  describe '#search_repository' do
+    test 'returns html with the found images' do
+      search_type = ['hub', 'registry'].sample
+      subject.instance_variable_set(:@image_search_service, image_search_service)
+      image_search_service.expects(:search)
+        .with({ term: term, tags: 'false' })
+        .returns([{ 'name' => term}])
+      xhr :get, :search_repository,
+        { registry: search_type, search: term,
+          id: compute_resource }, set_session_user
+      assert response.body.include?(term)
+    end
+
+    context 'a Docker Hub tab request' do
+      let(:search_type) { 'hub' }
+
+      test 'it searches Docker Hub and the ComputeResource' do
+        compute_resource.expects(:local_images)
+          .returns([OpenStruct.new(info: { 'RepoTags' => [term] })])
+        docker_hub.expects(:search).returns({})
+
+        xhr :get, :search_repository,
+          { registry: search_type, search: term,
+            id: compute_resource }, set_session_user
+      end
+    end
+
+    context 'it is a External Registry tab request' do
+      let(:search_type) { 'registry' }
+
+      test 'it only queries the registry api' do
+        compute_resource.expects(:local_images).with(docker_image).never
+        docker_hub.expects(:search).never
+        registry.api.expects(:search).with(docker_image)
+          .returns({})
+
+        xhr :get, :search_repository,
+          { registry: search_type, registry_id: registry,
+            search: term, id: compute_resource }, set_session_user
+      end
+    end
   end
 
   [Docker::Error::DockerError, Excon::Errors::Error, Errno::ECONNREFUSED].each do |error|
     test 'auto_complete_repository_name catches exceptions on network errors' do
-      ForemanDocker::Docker.any_instance.expects(:exist?).raises(error)
-      get :auto_complete_repository_name, { :search => "test", :id => @container.id },
-          set_session_user
+      ForemanDocker::ImageSearch.any_instance.expects(:available?)
+        .raises(error)
+      xhr :get, :auto_complete_repository_name,
+        { registry: 'hub', search: term, id: compute_resource }, set_session_user
       assert_response_is_expected
     end
 
     test 'auto_complete_image_tag catch exceptions on network errors' do
-      ForemanDocker::Docker.any_instance.expects(:tags).raises(error)
-      get :auto_complete_image_tag, { :search => "test", :id => @container.id }, set_session_user
+      ForemanDocker::ImageSearch.any_instance.expects(:search).raises(error)
+      xhr :get, :auto_complete_image_tag,
+        { registry: 'hub', search:  term, id: compute_resource }, set_session_user
       assert_response_is_expected
     end
 
     test 'search_repository catch exceptions on network errors' do
-      ForemanDocker::Docker.any_instance.expects(:search).raises(error)
-      get :search_repository, { :search => "test", :id => @container.id }, set_session_user
+      ForemanDocker::ImageSearch.any_instance.expects(:search).raises(error)
+      xhr :get, :search_repository,
+        { registry: 'hub', search: term, id: compute_resource }, set_session_user
       assert_response_is_expected
     end
   end
@@ -36,8 +188,9 @@ class ImageSearchControllerTest < ActionController::TestCase
                    "name" =>  repo_full_name,
                    "star_count" => 0
                 }]
-    ForemanDocker::Docker.any_instance.expects(:search).returns(expected).at_least_once
-    get :search_repository, { :search => "centos", :id => @container.id }, set_session_user
+    ForemanDocker::ImageSearch.any_instance.expects(:search).returns(expected).at_least_once
+    xhr :get, :search_repository,
+      { registry: 'hub', search: 'centos', id: compute_resource }, set_session_user
     assert_response :success
     refute response.body.include?(repo_full_name)
     assert response.body.include?(repository)
@@ -53,8 +206,9 @@ class ImageSearchControllerTest < ActionController::TestCase
                   "name" =>  repo_full_name,
                   "star_count" => 0
                 }]
-    ForemanDocker::Docker.any_instance.expects(:search).returns(expected).at_least_once
-    get :search_repository, { :search => "centos", :id => @container.id }, set_session_user
+    ForemanDocker::ImageSearch.any_instance.expects(:search).returns(expected).at_least_once
+    xhr :get, :search_repository,
+      { registry: 'hub', search: 'centos', id: compute_resource  }, set_session_user
     assert_response :success
     assert response.body.include?(repo_full_name)
     assert response.body.include?(repository)

data/test/integration/container_test.rb

@@ -12,7 +12,7 @@ class ContainerIntegrationTest < ActionDispatch::IntegrationTest
       ComputeResource.any_instance.stubs(:vms).returns([])
       FactoryGirl.create(:docker_cr)
       visit containers_path
-      assert page.has_link? 'New container'
+      assert page.has_link? 'Create container'
       refute_equal current_path, new_compute_resource_path
     end
   end

data/test/test_plugin_helper.rb

@@ -12,3 +12,13 @@ end
 # Add plugin to FactoryGirl's paths
 FactoryGirl.definition_file_paths << File.join(File.dirname(__FILE__), 'factories')
 FactoryGirl.reload
+
+def stub_image_existance(exists = true)
+  Docker::Image.any_instance.stubs(:exist?).returns(exists)
+  ForemanDocker::ImageSearch.any_instance.stubs(:available?).returns(exists)
+end
+
+def stub_registry_api
+  Service::RegistryApi.any_instance.stubs(:get).returns({'results' => []})
+  Docker::Image.stubs(:all).returns([])
+end

data/test/units/container_test.rb

@@ -6,5 +6,5 @@ class ContainerTest < ActiveSupport::TestCase
   should have_many(:environment_variables)
   should have_many(:dns)
   should have_many(:exposed_ports)
-  should validate_uniqueness_of(:name)
+  should validate_uniqueness_of(:name).scoped_to(:compute_resource_id)
 end

data/test/units/containers_service_test.rb

@@ -1,12 +1,16 @@
 require 'test_plugin_helper'
+require 'ostruct'
 
 class ContainersServiceTest < ActiveSupport::TestCase
   setup do
+    stub_image_existance
+    stub_registry_api
+
     @state = DockerContainerWizardState.create! do |s|
       s.build_preliminary(:compute_resource_id => FactoryGirl.create(:docker_cr).id,
                           :locations           => [taxonomies(:location1)],
                           :organizations       => [taxonomies(:organization1)])
-      s.build_image(:repository_name => 'test', :tag => 'test')
+      s.build_image(:repository_name => 'test', :tag => 'test', :wizard_state => s)
       s.build_configuration(:name => 'test', :command => '/bin/bash')
       s.build_environment(:tty => false)
     end
@@ -25,14 +29,32 @@ class ContainersServiceTest < ActiveSupport::TestCase
     assert_equal DockerContainerWizardState.where(:id => @state.id).count, 0
   end
 
-  test 'passes errors from compute resource' do
-    # Since the compute resource will be unreachable, this test will always
-    # fail at the 'pull_image' step
-    containers_service = Service::Containers.new
-    assert_raises(ActiveRecord::Rollback) do
-      containers_service.create_container_object(@state)
+  context 'errors' do
+    setup do
+      @containers_service = Service::Containers.new
+    end
+
+    test 'from compute resource' do
+      # Since the compute resource will be unreachable, this test will always
+      # fail at the 'pull_image' step
+      assert_raises(ActiveRecord::Rollback) do
+        @containers_service.create_container_object(@state)
+      end
+      assert @containers_service.errors.present?
+      assert_match(/No such file or directory.*ENOENT/,
+                   @containers_service.full_messages.join(' '))
     end
-    assert containers_service.errors.present?
-  end
 
+    test 'from multiple sources' do
+      Container.any_instance.expects(:valid?).returns(false)
+      Container.any_instance.stubs(:errors).returns(
+        OpenStruct.new(:full_messages => ['foo']))
+      assert_raises(ActiveRecord::Rollback) do
+        @containers_service.create_container_object(@state)
+      end
+      assert @containers_service.errors.present?
+      assert_match(/foo/,
+                   @containers_service.full_messages.join(' '))
+    end
+  end
 end