foreman_discovery 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 876b21259147ee28a7fb842a77509e67a86bfe9e
-  data.tar.gz: 727967204c0d3e9832a5f9e2255b39c480ff5d6a
+  metadata.gz: 66b0655f5a5cb3205a263ba723b51a9e41fb0b8d
+  data.tar.gz: 6f16041f72c20dd65b33756326d41176a0e570e8
 SHA512:
-  metadata.gz: 5ea541c20e74fa17810b9ecd2a849bb90dcc3029ca3808ac01b4b89bbf756ad76000fc78d7e5842ea0510a20757d364ac5d78aee81c15adfa306a4fd9e665e02
-  data.tar.gz: 913c4b70355675861a44da328f573202a49211d8e2acb476ef9c9070160bca2545174a21d62f6fc27ad032e43f349fbf0faa530e3d5d62e9fc7e9f0ae57094f8
+  metadata.gz: fdb6a81be087dce7ec317f8379506ed5af697fa727cd24551b649c95647638c2e8135749b33093174b7582611e17bcd2e73d2e2fdfef6a2257d94e16e54daf31
+  data.tar.gz: 2159e5c80640c6a7badc42511f054235e93b2b2c858961a4fbac5592bfe91b35d062b6eb03da3ecfc52f848f4376dfaa809540dbb6bced266293df086ffa781a

data/app/controllers/api/v2/discovered_hosts_controller.rb

@@ -76,18 +76,12 @@ module Api
       end
 
       def update
-        @host         = @discovered_host.becomes(::Host::Managed)
-        @host.type    = 'Host::Managed'
-        @host.managed = true
-        @host.build   = true
-        forward_request_url
-        update_response = @host.update_attributes(params[:discovered_host])
         Host.transaction do
-          if update_response
-            delete_discovery_attribute_set(@host.id)
-          end
+          @host = ::ForemanDiscovery::HostConverter.to_managed(@discovered_host)
+          forward_request_url
+          update_response = @host.update_attributes(params[:discovered_host])
+          process_response update_response
         end
-        process_response update_response
       end
 
       api :DELETE, "/discovered_hosts/:id/", N_("Delete a discovered host")

data/app/controllers/api/v2/discovery_rules_controller.rb

@@ -28,13 +28,13 @@ module Api
 
       def_param_group :discovery_rule do
         param :discovery_rule, Hash, :action_aware => true do
-          param :name, String, :required => true
-          param :search, String, :required => true
-          param :hostgroup_id, Integer, :required => true
-          param :hostname, String, :required => true
-          param :max_count, Integer
-          param :priority, Integer
-          param :enabled, :bool
+          param :name, String, :required => true, :desc => N_("represents rule name shown to the users")
+          param :search, String, :required => true, :desc => N_("query to match discovered hosts for the particular rule")
+          param :hostgroup_id, Integer, :required => true, :desc => N_("the hostgroup that is used to auto provision a host")
+          param :hostname, String, :desc => N_("defines a pattern to assign human-readable hostnames to the matching hosts")
+          param :max_count, Integer, :desc => N_("enables to limit maximum amount of provisioned hosts per rule")
+          param :priority, Integer, :desc => N_("puts the rules in order, low numbers go first. Must be greater then zero")
+          param :enabled, :bool, :desc => N_("flag is used for temporary shutdown of rules")
         end
       end
 
@@ -48,15 +48,7 @@ module Api
 
       api :PUT, "/discovery_rules/:id/", N_("Update a rule")
       param :id, :identifier, :required => true
-      param :discovery_rule, Hash, :action_aware => true do
-          param :name, String, :required => true
-          param :search, String, :required => true
-          param :hostgroup_id, Integer, :required => true
-          param :hostname, String, :required => true
-          param :max_count, Integer
-          param :priority, Integer
-          param :enabled, :bool
-      end
+      param_group :discovery_rule, :as => :update
 
       def update
         process_response @discovery_rule.update_attributes(params[:discovery_rule])

data/app/controllers/concerns/foreman/controller/discovered_extensions.rb

@@ -28,32 +28,21 @@ module Foreman::Controller::DiscoveredExtensions
   end
 
   # trigger the provisioning
-  def perform_auto_provision host, rule
-    host = host.becomes(::Host::Managed)
-    host.type = 'Host::Managed'
-    host.managed = true
-    host.build = true
-    host.hostgroup_id = rule.hostgroup_id
-    host.comment = "Auto-discovered and provisioned via rule '#{rule.name}'"
-    host.discovery_rule = rule
-    # render hostname only when all other fields are set
-    original_name = host.name
-    host.name = host.render_template(rule.hostname) unless rule.hostname.empty?
-    # fallback to the original if template did not expand
-    host.name = original_name if host.name.empty?
+  def perform_auto_provision original_host, rule
     Host.transaction do
-      if host.save #save! does not work here
-        delete_discovery_attribute_set(host.id)
-      end
+      host = ::ForemanDiscovery::HostConverter.to_managed(original_host)
+      host.hostgroup_id = rule.hostgroup_id
+      host.comment = "Auto-discovered and provisioned via rule '#{rule.name}'"
+      host.discovery_rule = rule
+      # render hostname only when all other fields are set
+      original_name = host.name
+      host.name = host.render_template(rule.hostname) unless rule.hostname.empty?
+      # fallback to the original if template did not expand
+      host.name = original_name if host.name.empty?
+      # save! does not work here
+      host.save
     end
   end
 
-  # discovery_attribute_set should be deleted only after a host has been successfully provisioned
-  # (after discovered host becomes managed host)
-  # after this happens the host is a manged host so non of the callbacks in discovered hosts are relevant anymore
-  # for this reason the orphaned discovery_attribute_set needs to be searched for and deleted
-  def delete_discovery_attribute_set(host_id)
-    DiscoveryAttributeSet.delete_all(:host_id => host_id)
-  end
 
 end

data/app/controllers/discovered_hosts_controller.rb

@@ -59,24 +59,18 @@ class DiscoveredHostsController < ::ApplicationController
   end
 
   def edit
-    unless @host.nil?
-      @host         = @host.becomes(::Host::Managed)
-      @host.type    = 'Host::Managed'
-      @host.managed = true
-      @host.build   = true
+    Host.transaction do
+      @host = ::ForemanDiscovery::HostConverter.to_managed(@host) unless @host.nil?
+      render :template => 'hosts/edit'
     end
-
-    render :template => 'hosts/edit'
   end
 
   def update
-    @host         = @host.becomes(::Host::Managed)
-    @host.type    = 'Host::Managed'
-    forward_url_options
-    Taxonomy.no_taxonomy_scope do
-      Host.transaction do
+    Host.transaction do
+      @host = ::ForemanDiscovery::HostConverter.to_managed(@host, false, false)
+      forward_url_options
+      Taxonomy.no_taxonomy_scope do
         if @host.update_attributes(params[:host])
-          delete_discovery_attribute_set(@host.id)
           process_success :success_redirect => host_path(@host), :redirect_xhr => request.xhr?
         else
           taxonomy_scope
@@ -146,7 +140,7 @@ class DiscoveredHostsController < ::ApplicationController
     @host.transaction do
       if rule = find_discovery_rule(@host)
         if perform_auto_provision(@host, rule)
-          process_success :success_msg => _("Host %s was provisioned with rule %s") % [@host.name, rule.name], :success_redirect => :back
+          process_success :success_msg => _("Host %{host} was provisioned with rule %{rule}") % {:host => @host.name, :rule => rule.name}, :success_redirect => discovered_hosts_path
         else
           errors = @host.errors.full_messages.join(' ')
           logger.warn "Failed to auto provision host %s: %s" % [@host.name, errors]

data/app/models/discovery_rule.rb

@@ -15,6 +15,7 @@ class DiscoveryRule < ActiveRecord::Base
   validates :max_count, :numericality => { :only_integer => true, :greater_than_or_equal_to => 0 }
   validates :priority, :presence => true, :numericality => { :only_integer => true, :greater_than_or_equal_to => 0 }
   validates_lengths_from_database
+  before_validation :default_int_attributes
 
   belongs_to :hostgroup
   has_many :hosts
@@ -23,4 +24,10 @@ class DiscoveryRule < ActiveRecord::Base
   scoped_search :on => :priority
   scoped_search :on => :search
   scoped_search :on => :enabled
+  scoped_search :in => :hostgroup, :on => :name, :complete_value => true, :rename => :hostgroup
+
+  def default_int_attributes
+   self.max_count ||= 0
+   self.priority  ||= 0
+  end
 end

data/app/services/host_converter.rb

@@ -0,0 +1,30 @@
+class ForemanDiscovery::HostConverter
+
+  # must be called from SQL transaction 
+  def self.to_managed(original_host, set_managed = true, set_build = true)
+    if ActiveRecord::Base.connection.open_transactions <= 0
+      raise "This method must be executed with explicit transaction"
+    end
+    host = original_host.becomes(::Host::Managed)
+    host.type = 'Host::Managed'
+    # the following flags can be skipped when parameters are set to false
+    if set_managed
+      host.managed = set_managed
+      host.managed = set_managed
+    end
+    host.build = set_build if set_build
+    # this gets rolled back when anything in the transaction fails
+    delete_discovery_attribute_set(host.id)
+    host
+  end
+
+  private
+
+  # discovery_attribute_set should be deleted only after a host has been successfully provisioned
+  # (after discovered host becomes managed host)
+  # after this happens the host is a manged host so non of the callbacks in discovered hosts are relevant anymore
+  # for this reason the orphaned discovery_attribute_set needs to be searched for and deleted
+  def self.delete_discovery_attribute_set(host_id)
+    DiscoveryAttributeSet.destroy_all(:host_id => host_id)
+  end
+end

data/app/views/api/v2/discovery_rules/main.json.rabl

@@ -2,4 +2,9 @@ object @discovery_rule
 
 extends "api/v2/discovery_rules/base"
 
-attributes :name, :enabled, :hostgroup_id, :hostname, :max_count, :priority, :search
+attributes :name, :enabled, :hostgroup_id, :hostgroup_name, :hostname, :priority, :search
+attribute :max_count => :hosts_limit
+
+child :hosts do
+  extends "api/v2/discovered_hosts/base"
+end

data/db/migrate/20150302112545_remove_duplicate_tokens_from_hosts.rb

@@ -0,0 +1,8 @@
+class RemoveDuplicateTokensFromHosts < ActiveRecord::Migration
+  def up
+    Token.where('id not in (?)', Host::Managed.all.map(&:token).compact).delete_all
+  end
+
+  def down
+  end
+end

data/db/migrate/20150310153859_remove_discovery_attribute_sets_from_managed_hosts.rb

@@ -0,0 +1,8 @@
+class RemoveDiscoveryAttributeSetsFromManagedHosts < ActiveRecord::Migration
+  def up
+    DiscoveryAttributeSet.where(:id => DiscoveryAttributeSet.joins(:host).where(:'hosts.managed' => true).pluck(:id)).delete_all
+  end
+
+  def down
+  end
+end

data/lib/foreman_discovery/engine.rb

@@ -7,10 +7,11 @@ module ForemanDiscovery
   #Thus, inherits from ::Rails::Engine and not from Rails::Engine
   class Engine < ::Rails::Engine
 
-    # support for concerns for pre-4 Rails versions
+    # support pre-4 Rails versions
     config.autoload_paths += Dir["#{config.root}/app/controllers/concerns"]
     config.autoload_paths += Dir["#{config.root}/app/helpers/concerns"]
     config.autoload_paths += Dir["#{config.root}/app/models/concerns"]
+    config.autoload_paths += Dir["#{config.root}/app/services"]
 
     # Load this before the Foreman config initializers, so that the Setting.descendants
     # list includes the plugin STI setting class

data/lib/foreman_discovery/version.rb

@@ -1,3 +1,3 @@
 module ForemanDiscovery
-  VERSION = "2.0.0"
+  VERSION = "2.0.1"
 end

data/test/functional/api/v2/discovered_hosts_controller_test.rb

@@ -2,6 +2,13 @@ require 'test_helper'
 
 class Api::V2::DiscoveredHostsControllerTest < ActionController::TestCase
 
+  def switch_controller(klass)
+    old_controller = @controller
+    @controller = klass.new
+    yield
+    @controller = old_controller
+  end
+
   setup do
     User.current = User.find_by_login "admin"
     @request.env['HTTP_REFERER'] = '/discovery_rules'
@@ -34,6 +41,12 @@ class Api::V2::DiscoveredHostsControllerTest < ActionController::TestCase
     assert_equal "Empty Organization", show_response["organization_name"]
   end
 
+  def test_delete_discovered_host
+    host = Host::Discovered.import_host_and_facts(@facts).first
+    delete :destroy, { :id => host.id }
+    assert_response :success
+  end
+
   def test_auto_provision_success_via_upload
     disable_orchestration
     facts = @facts.merge({"somefact" => "abc"})
@@ -52,6 +65,20 @@ class Api::V2::DiscoveredHostsControllerTest < ActionController::TestCase
     assert_response :success
   end
 
+  def test_auto_provision_success_and_delete
+    disable_orchestration
+    facts = @facts.merge({"somefact" => "abc"})
+    host = Host::Discovered.import_host_and_facts(facts).first
+    FactoryGirl.create(:discovery_rule, :priority => 1, :search => "facts.somefact = abc", :hostgroup => hostgroups(:common))
+    post :auto_provision, { :id => host.id }
+    assert_response :success
+    # test deletion of a managed host
+    switch_controller(::Api::V2::HostsController) do
+      delete :destroy, { :id => host.id }
+      assert_response :success
+    end
+  end
+
   def test_auto_provision_no_rule_success
     disable_orchestration
     facts = @facts.merge({"somefact" => "abc"})

data/test/functional/discovered_hosts_controller_test.rb

@@ -29,6 +29,18 @@ class DiscoveredHostsControllerTest < ActionController::TestCase
     assert_response :success
   end
 
+  def test_edit_form
+    skip "until foreman 1.8"
+    host = Host::Discovered.import_host_and_facts(@facts).first
+    get :edit, {:id => host.id}, set_session_user
+    assert_select "select" do |elements|
+      elements.each do |element|
+        assert_match(/^host_/, element.attributes['id'])
+        assert_match(/^host\[/, element.attributes['name'])
+      end
+    end
+  end
+
   def test_index_json
     get :index, {:format => "json"}, set_session_user
     assert_response :success

data/test/unit/discovery_rule_test.rb

@@ -0,0 +1,20 @@
+require 'test_helper'
+
+class DiscoveryRuleTest < ActiveSupport::TestCase
+
+  test "should be able to create a rule without entering hosts limit" do
+    rule = DiscoveryRule.new :name => "myrule", :search => "cpu_count > 1", :priority => "1", :hostgroup_id => "1"
+    assert_valid rule
+  end
+
+  test "should be able to create a rule without entering priority" do
+    rule = DiscoveryRule.new :name => "myrule", :search => "cpu_count > 1", :max_count => "1", :hostgroup_id => "1"
+    assert_valid rule
+  end
+
+  test "should not be able to create a rule without a hostgroup" do
+    rule = DiscoveryRule.new :name => "myrule", :search => "cpu_count > 1"
+    refute_valid rule
+  end
+
+end

metadata

@@ -1,27 +1,27 @@
 --- !ruby/object:Gem::Specification
 name: foreman_discovery
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Greg Sutcliffe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-09 00:00:00.000000000 Z
+date: 2015-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: deface
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '1.0'
 description: 'MaaS Discovery Plugin engine for Foreman '
@@ -32,112 +32,116 @@ extra_rdoc_files:
 - LICENSE
 - README.md
 files:
-- app/controllers/discovery_rules_controller.rb
-- app/controllers/discovered_hosts_controller.rb
-- app/controllers/concerns/foreman/controller/discovered_extensions.rb
-- app/controllers/api/v2/discovery_rules_controller.rb
+- LICENSE
+- README.md
 - app/controllers/api/v2/discovered_hosts_controller.rb
-- app/lib/puppet_fact_parser_extensions.rb
-- app/helpers/discovery_rules_helper.rb
+- app/controllers/api/v2/discovery_rules_controller.rb
+- app/controllers/concerns/foreman/controller/discovered_extensions.rb
+- app/controllers/discovered_hosts_controller.rb
+- app/controllers/discovery_rules_controller.rb
 - app/helpers/discovered_hosts_helper.rb
-- app/overrides/subnet_form_with_discovery_proxy.rb
-- app/models/setting/discovered.rb
-- app/models/hostgroup_extensions.rb
-- app/models/host/discovered.rb
-- app/models/host/managed_extensions.rb
-- app/models/discovery_rule.rb
+- app/helpers/discovery_rules_helper.rb
+- app/lib/puppet_fact_parser_extensions.rb
 - app/models/concerns/discovery_subnet.rb
 - app/models/discovery_attribute_set.rb
-- app/views/dashboard/_discovery_widget_host_list.html.erb
+- app/models/discovery_rule.rb
+- app/models/host/discovered.rb
+- app/models/host/managed_extensions.rb
+- app/models/hostgroup_extensions.rb
+- app/models/setting/discovered.rb
+- app/overrides/subnet_form_with_discovery_proxy.rb
+- app/services/host_converter.rb
+- app/views/api/v2/discovered_hosts/auto_provision.json.rabl
+- app/views/api/v2/discovered_hosts/auto_provision_all.json.rabl
+- app/views/api/v2/discovered_hosts/base.json.rabl
+- app/views/api/v2/discovered_hosts/index.json.rabl
+- app/views/api/v2/discovered_hosts/main.json.rabl
+- app/views/api/v2/discovered_hosts/show.json.rabl
+- app/views/api/v2/discovered_hosts/update.json.rabl
+- app/views/api/v2/discovery_rules/base.json.rabl
+- app/views/api/v2/discovery_rules/index.json.rabl
+- app/views/api/v2/discovery_rules/main.json.rabl
+- app/views/api/v2/discovery_rules/show.json.rabl
 - app/views/dashboard/_discovery_widget.html.erb
-- app/views/discovery_rules/new.html.erb
-- app/views/discovery_rules/edit.html.erb
-- app/views/discovery_rules/index.html.erb
-- app/views/discovery_rules/_form.html.erb
+- app/views/dashboard/_discovery_widget_host_list.html.erb
 - app/views/discovered_hosts/_discovered_host.html.erb
+- app/views/discovered_hosts/_discovered_hosts_list.html.erb
 - app/views/discovered_hosts/_selected_hosts.html.erb
-- app/views/discovered_hosts/multiple_destroy.html.erb
 - app/views/discovered_hosts/index.html.erb
+- app/views/discovered_hosts/multiple_destroy.html.erb
+- app/views/discovered_hosts/select_multiple_location.html.erb
 - app/views/discovered_hosts/select_multiple_organization.html.erb
-- app/views/discovered_hosts/_discovered_hosts_list.html.erb
 - app/views/discovered_hosts/show.html.erb
-- app/views/discovered_hosts/select_multiple_location.html.erb
-- app/views/api/v2/discovery_rules/index.json.rabl
-- app/views/api/v2/discovery_rules/base.json.rabl
-- app/views/api/v2/discovery_rules/main.json.rabl
-- app/views/api/v2/discovery_rules/show.json.rabl
-- app/views/api/v2/discovered_hosts/index.json.rabl
-- app/views/api/v2/discovered_hosts/update.json.rabl
-- app/views/api/v2/discovered_hosts/auto_provision_all.json.rabl
-- app/views/api/v2/discovered_hosts/base.json.rabl
-- app/views/api/v2/discovered_hosts/main.json.rabl
-- app/views/api/v2/discovered_hosts/auto_provision.json.rabl
-- app/views/api/v2/discovered_hosts/show.json.rabl
-- extra/build_iso.sh
-- extra/wait_for_network.sh
-- extra/disk_facts.rb
-- extra/discover_host
-- extra/foreman_startup.rb
-- extra/discovery_init.sh.example
-- extra/ovirt-node-build/build_image.sh
-- extra/ovirt-node-build/Vagrantfile
-- config/routes.rb
+- app/views/discovery_rules/_form.html.erb
+- app/views/discovery_rules/edit.html.erb
+- app/views/discovery_rules/index.html.erb
+- app/views/discovery_rules/new.html.erb
 - config/initializers/discovery_setup.rb
+- config/routes.rb
 - db/migrate/20141107091416_create_discovery_rules.rb
 - db/migrate/20141107091417_add_discovery_rule_to_host.rb
 - db/migrate/20141126165451_add_discovery_id_to_subnet.rb
 - db/migrate/20141223101707_create_discovery_attribute_sets.rb
 - db/migrate/20141223142759_fill_discovery_attribute_sets_for_existing_hosts.rb
+- db/migrate/20150302112545_remove_duplicate_tokens_from_hosts.rb
+- db/migrate/20150310153859_remove_discovery_attribute_sets_from_managed_hosts.rb
 - db/seeds.d/60_discovery_proxy_feature.rb
+- extra/build_iso.sh
+- extra/discover_host
+- extra/discovery_init.sh.example
+- extra/disk_facts.rb
+- extra/foreman_startup.rb
+- extra/ovirt-node-build/Vagrantfile
+- extra/ovirt-node-build/build_image.sh
+- extra/wait_for_network.sh
 - lib/discovery.rake
 - lib/foreman_discovery.rb
+- lib/foreman_discovery/engine.rb
 - lib/foreman_discovery/proxy_operations.rb
 - lib/foreman_discovery/version.rb
-- lib/foreman_discovery/engine.rb
-- locale/foreman_discovery.pot
 - locale/Makefile
-- locale/ru/foreman_discovery.po
-- locale/ru/LC_MESSAGES/foreman_discovery.mo
-- locale/de/foreman_discovery.po
 - locale/de/LC_MESSAGES/foreman_discovery.mo
-- locale/pt_BR/foreman_discovery.po
-- locale/pt_BR/LC_MESSAGES/foreman_discovery.mo
-- locale/en_GB/foreman_discovery.po
+- locale/de/foreman_discovery.po
 - locale/en_GB/LC_MESSAGES/foreman_discovery.mo
-- locale/zh_TW/foreman_discovery.po
-- locale/zh_TW/LC_MESSAGES/foreman_discovery.mo
-- locale/es/foreman_discovery.po
+- locale/en_GB/foreman_discovery.po
 - locale/es/LC_MESSAGES/foreman_discovery.mo
-- locale/fr/foreman_discovery.po
+- locale/es/foreman_discovery.po
+- locale/foreman_discovery.pot
 - locale/fr/LC_MESSAGES/foreman_discovery.mo
-- locale/it/foreman_discovery.po
+- locale/fr/foreman_discovery.po
+- locale/gl/LC_MESSAGES/foreman_discovery.mo
+- locale/gl/foreman_discovery.po
 - locale/it/LC_MESSAGES/foreman_discovery.mo
-- locale/ja/foreman_discovery.po
+- locale/it/foreman_discovery.po
 - locale/ja/LC_MESSAGES/foreman_discovery.mo
-- locale/ko/foreman_discovery.po
+- locale/ja/foreman_discovery.po
 - locale/ko/LC_MESSAGES/foreman_discovery.mo
-- locale/zh_CN/foreman_discovery.po
-- locale/zh_CN/LC_MESSAGES/foreman_discovery.mo
-- locale/zanata.xml
-- locale/gl/foreman_discovery.po
-- locale/gl/LC_MESSAGES/foreman_discovery.mo
-- locale/sv_SE/foreman_discovery.po
+- locale/ko/foreman_discovery.po
+- locale/pt_BR/LC_MESSAGES/foreman_discovery.mo
+- locale/pt_BR/foreman_discovery.po
+- locale/ru/LC_MESSAGES/foreman_discovery.mo
+- locale/ru/foreman_discovery.po
 - locale/sv_SE/LC_MESSAGES/foreman_discovery.mo
-- LICENSE
-- README.md
-- test/functional/discovery_rules_controller_test.rb
-- test/functional/api/v2/discovery_rules_controller_test.rb
+- locale/sv_SE/foreman_discovery.po
+- locale/zanata.xml
+- locale/zh_CN/LC_MESSAGES/foreman_discovery.mo
+- locale/zh_CN/foreman_discovery.po
+- locale/zh_TW/LC_MESSAGES/foreman_discovery.mo
+- locale/zh_TW/foreman_discovery.po
+- test/factories/discovery_rule_related.rb
 - test/functional/api/v2/discovered_hosts_controller_test.rb
+- test/functional/api/v2/discovery_rules_controller_test.rb
 - test/functional/discovered_hosts_controller_test.rb
-- test/factories/discovery_rule_related.rb
+- test/functional/discovery_rules_controller_test.rb
+- test/test_helper.rb
+- test/test_plugin_helper.rb
 - test/unit/discovered_extensions_test.rb
 - test/unit/discovery_attribute_set_test.rb
-- test/unit/setting_discovered_test.rb
+- test/unit/discovery_rule_test.rb
 - test/unit/facts.json
-- test/unit/puppet_fact_parser_extensions_test.rb
 - test/unit/host_discovered_test.rb
-- test/test_plugin_helper.rb
-- test/test_helper.rb
+- test/unit/puppet_fact_parser_extensions_test.rb
+- test/unit/setting_discovered_test.rb
 homepage: http://github.com/theforeman/foreman_discovery
 licenses:
 - GPL-3
@@ -148,17 +152,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 2.2.0
 signing_key: 
 specification_version: 4
 summary: MaaS Discovery Plugin for Foreman
@@ -173,6 +177,7 @@ test_files:
 - test/unit/setting_discovered_test.rb
 - test/unit/facts.json
 - test/unit/puppet_fact_parser_extensions_test.rb
+- test/unit/discovery_rule_test.rb
 - test/unit/host_discovered_test.rb
 - test/test_plugin_helper.rb
 - test/test_helper.rb