foreman_datacenter 1.22.1 → 1.24.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e96deecee872fb9556eaadaf8810780ff51756b52bd40899045ea80ffaeffbe8
-  data.tar.gz: 868d381b9b0ee40a40104dbb68140ec6ad8ada53eb1affa10bd3d2b8f71079a1
+  metadata.gz: aa372e8673608cecc9343f4a2efa60d2d38dc77cb9ef37cfd55f8ec261907ccc
+  data.tar.gz: b806528ffcea447652114e76043f216d28eb50c2386f253ca93bd8808ab0ee35
 SHA512:
-  metadata.gz: cd3c206a2840fd9c13b35c916e0d6575e29e907d57b76b9d5fb57931845be2293cc018fb2cb450ff8cbb487bd8dc8277d9157fadbf9dcd076608249dbf773886
-  data.tar.gz: 18a82c60a9a04cfd7d51eda80bfcc2e065ad41cc3238294b95f90192e537a94e691365036517d9e5ced4b88d28872a56780d8e1961c0dda1adc2dbcbad67fb5f
+  metadata.gz: 8fa308e3840207c9a77aecfaa18491b578a73f5a1307bcea72fabafa1e97d4b3dfcf6bd9386803c847bbc410e75de3515d629c1e12227d4606d5e8385096c721
+  data.tar.gz: 3a00433a5afb85a305c687e66f153dd4279efe62f2ec842d6c67d321085062530dc261529436076b3ea0df0e74136bed184b79b388b98cf34f39eb6ecd0066b9

data/app/controllers/foreman_datacenter/application_controller.rb

@@ -92,6 +92,8 @@ module ForemanDatacenter
           'move'
         when 'racks'
           'racks'
+        when 'export_to_csv'
+          'export_to_csv'
         else
           super
       end

data/app/controllers/foreman_datacenter/racks_controller.rb

@@ -3,7 +3,7 @@ module ForemanDatacenter
     include Foreman::Controller::AutoCompleteSearch
     include ForemanDatacenter::Controller::Parameters::Rack
 
-    before_action :find_resource, only: [:show, :edit, :update, :destroy, :devices, :move]
+    before_action :find_resource, only: [:show, :edit, :update, :destroy, :devices, :move, :export_to_csv]
 
     def index
       @racks = resource_base_search_and_page.includes(:site, :rack_group)
@@ -64,6 +64,13 @@ module ForemanDatacenter
       process_error object: @rack, error_msg: 'Current Rack haven\'t any Devices.' if @devices.empty?
     end
 
+    def export_to_csv
+      data = @rack.format_for_csv
+      file = File.open("#{@rack.name}.csv", "r")
+      send_file(file)
+      file.close
+    end
+
     def update_associated_objects
       begin
         @rack = ForemanDatacenter::Rack.find(request.env['HTTP_REFERER'].split('/')[-2])

data/app/models/foreman_datacenter/rack.rb

@@ -52,8 +52,42 @@ module ForemanDatacenter
           count
     end
 
+    def format_for_csv
+      positioned_devices = self.positioned_devices
+      unpositioned_devices = self.unpositioned_devices
+      csv_string = CSV.generate do |csv|
+        csv << ["positions", "left", "full", "right", "no side"]
+        positioned_devices.each do |i|
+          pos = i[0].map{|p| "#{p}"+"U"}.join(",")
+          if i[1].size > 0
+            sort = sort_for_csv(i[1])
+            csv << [pos, sort[0], sort[1], sort[2], sort[3]]
+          else
+            csv << [pos]
+          end
+        end
+        unless unpositioned_devices.empty?
+          csv << []
+          csv << ["Unpositioned", unpositioned_devices.map(&:name).join(",")]
+        end
+
+      end
+      File.open("#{self.name}.csv", "w") {|f| f << csv_string}
+    end
+
     private
 
+    def sort_for_csv(device_array)
+      left, full, right, no_side = "", "", "", []
+      device_array.each do |d|
+        left = d.name if d.side == "left"
+        right = d.name if d.side == "right"
+        full = d.name if d.side == "full"
+        no_side << d.name if d.side == nil
+      end
+      [left, full, right, no_side.join(",")]
+    end
+
     def device_sorting(devices)
       devices.reverse.map { |d| [d[0].reverse, d[1]] }
     end
@@ -63,5 +97,7 @@ module ForemanDatacenter
       devices.each{|d| devs[1] << d[1][0]}
       return devs
     end
+
+
   end
 end

data/app/views/foreman_datacenter/device_roles/show.html.erb

@@ -20,8 +20,7 @@
                              objectid: @device_role.id,
                              objectname: @device_role.to_label,
                              associatedobjects: associated_objects('device_role') }
-                 )
-                 help_path %>
+                 ) %>
 
 <div class="row">
   <div class="col-md-6">

data/app/views/foreman_datacenter/device_types/show.html.erb

@@ -20,8 +20,7 @@
                              objectid: @device_type.id,
                              objectname: @device_type.to_label,
                              associatedobjects: associated_objects('device_type') }
-                 )
-                 help_path %>
+                 ) %>
 
 <div class="row">
   <div class="col-md-6">

data/app/views/foreman_datacenter/manufacturers/show.html.erb

@@ -20,8 +20,7 @@
                            objectid: @manufacturer.id,
                            objectname: @manufacturer.to_label,
                            associatedobjects: associated_objects('manufacturer') }
-                 )
-                 help_path %>
+                 ) %>
 
 <div class="row">
   <div class="col-md-6">

data/app/views/foreman_datacenter/platforms/show.html.erb

@@ -20,8 +20,7 @@
                            objectid: @platform.id,
                            objectname: @platform.to_label,
                            associatedobjects: associated_objects('platform') }
-                 )
-                 help_path %>
+                 ) %>
 
 <div class="row">
   <div class="col-md-6">

data/app/views/foreman_datacenter/rack_groups/show.html.erb

@@ -25,8 +25,7 @@
                              objectid: @rack_group.id,
                              objectname: @rack_group.to_label,
                              associatedobjects: associated_objects('rack_group') }
-                 )
-                 help_path %>
+                 ) %>
 
 <div class="row">
 

data/app/views/foreman_datacenter/racks/_device_position.html.erb

@@ -1,5 +1,14 @@
 <div class="panel panel-default">
-  <div class="panel-heading text-center"><h4 class="nonmargintop nonmarginbottom"><strong><%= link_to _("#{rack.name}"), rack_path(rack) %></strong></h4></div>
+  <div class="panel-heading text-center">
+    <h4 class="nonmargintop nonmarginbottom">
+      <strong>
+        <%= link_to _("#{rack.name}"), rack_path(rack) %>
+      </strong>
+      <strong>
+           <%= link_to 'Export to CSV', export_to_csv_rack_path(rack.id), class: "btn btn-primary btn-xs pull-right" %>
+      </strong>
+      </h4>
+    </div>
   <table class="<%= table_css_classes 'table-hover panel-body nonmarginbottom' %>">
     <tbody>
       <% rack.positioned_devices.each do |positions, devices| %>

data/app/views/foreman_datacenter/racks/show.html.erb

@@ -26,8 +26,7 @@
                              objectid: @rack.id,
                              objectname: @rack.to_label,
                              associatedobjects: associated_objects('rack') }
-                 )
-                 help_path %>
+                 ) %>
 
 <div class="row">
   <div class="col-md-6">

data/app/views/foreman_datacenter/sites/show.html.erb

@@ -25,8 +25,7 @@
                              objectid: @site.id,
                              objectname: @site.to_label,
                              associatedobjects: associated_objects('site') }
-                 )
-                 help_path %>
+                 ) %>
 
 <div class="row">
   <!-- Site -->

data/config/routes.rb

@@ -74,11 +74,30 @@ Foreman::Application.routes.draw do
   get 'datacenter/import_to_device', to: 'hosts#import_to_device',
       as: 'import_to_device'
 
-  get '/api/:controller/(:action(/*welcome))'
+  # get '/api/:controller/(:action(/*welcome))'
   # get '/datacenter/(:controller)/help', :action => 'welcome', :as => "help"
 
   scope 'datacenter', module: :foreman_datacenter do
 
+    welcoming_controllers = [
+      'console_ports',
+      'device_interface_connections',
+      'device_interface_connections',
+      'device_roles',
+      'device_types',
+      'devices',
+      'manufacturers',
+      'platforms',
+      'power_ports',
+      'rack_groups',
+      'racks',
+      'sites',
+    ]
+
+    welcoming_controllers.each do |welcoming_controller|
+      get "#{welcoming_controller}/help", :action => :welcome, :controller => welcoming_controller
+    end
+
     post :site_update_associated_objects, to: "sites#update_associated_objects"
     post :rack_group_update_associated_objects, to: "rack_groups#update_associated_objects"
     post :rack_update_associated_objects, to: "racks#update_associated_objects"
@@ -94,6 +113,7 @@ Foreman::Application.routes.draw do
     end
     resources :racks do
       member do
+        get :export_to_csv
         get :move
       end
       collection do

data/lib/foreman_datacenter/version.rb

@@ -1,3 +1,3 @@
 module ForemanDatacenter
-  VERSION = '1.22.1'.freeze
+  VERSION = '1.24.2'.freeze
 end

data/test/controllers/foreman_datacenter/device_roles_controller_test.rb

@@ -0,0 +1,133 @@
+require_relative '../../test_plugin_helper'
+
+module ForemanDatacenter
+  class DeviceRolesControllerTest < ActionController::TestCase
+    describe ForemanDatacenter::DeviceRolesController do
+      setup do
+        @model = ForemanDatacenter::DeviceRole.first
+      end
+
+      basic_index_test 'device_roles'
+      basic_new_test
+      basic_edit_test 'device_role'
+      basic_pagination_per_page_test
+      basic_pagination_rendered_test
+
+      def test_create_invalid
+        ForemanDatacenter::DeviceRole.any_instance.stubs(:valid?).returns(false)
+        post :create, params: { :device_role => {:name => nil} }, session: set_session_user
+        assert_template 'new'
+      end
+
+      def test_create_valid(name = "test device_role")
+        ForemanDatacenter::DeviceRole.any_instance.stubs(:valid?).returns(true)
+        post :create, params: { :device_role => {:name => name, :color => 'Teal'} }, session: set_session_user
+        assert_redirected_to device_roles_url
+      end
+
+      def test_update_invalid
+        ForemanDatacenter::DeviceRole.any_instance.stubs(:valid?).returns(false)
+        put :update, params: { :id => @model.to_param, :device_role => {:name => "3243", :color => "Red"} }, session: set_session_user
+        assert_template 'edit'
+      end
+
+      def test_update_valid
+        ForemanDatacenter::DeviceRole.any_instance.stubs(:valid?).returns(true)
+        put :update, params: { :id => @model.to_param, :device_role => {:name => @model.name, :color => "Green"} }, session: set_session_user
+        assert_redirected_to device_roles_url
+      end
+
+      def test_destroy
+        test_create_valid "tobedeleted_test"
+        @new_dr = ForemanDatacenter::DeviceRole.find_by_name("tobedeleted_test")
+        delete :destroy, params: { :id => @new_dr.id }, session: set_session_user
+        assert_redirected_to device_roles_url
+        assert !ForemanDatacenter::DeviceRole.exists?(@new_dr.id)
+      end
+
+      test "should not get index when not permitted" do
+        setup_user
+        get :index, session: { :user => users(:one).id, :expires_at => 5.minutes.from_now }
+        assert_response :forbidden
+        assert_includes @response.body, 'view_device_roles'
+      end
+
+      test 'should not get show when not permitted' do
+        setup_user
+        get :show, params: { :id => @model.id }, session: {:user => users(:one).id, :expires_at => 5.minutes.from_now}
+        assert_response :forbidden
+        assert_includes @response.body, 'view_device_roles'
+      end
+
+      test 'should not get edit when not permitted' do
+        setup_user
+        get :edit, params: { :id => @model.id }, session: {:user => users(:one).id, :expires_at => 5.minutes.from_now}
+        assert_response :forbidden
+        assert_includes @response.body, 'edit_device_roles'
+      end
+
+      test "should get index" do
+        setup_user("Viewer")
+        get :index, session: set_session_user
+        assert_response :success
+        assert_template 'index'
+      end
+
+      test 'should get show' do
+        setup_user("Viewer")
+        get :show, params: { :id => @model.id }, session: set_session_user
+        assert_response :success
+        assert_template 'show'
+      end
+
+      test 'should not get edit with viewer permissions' do
+        setup_user("Viewer")
+        get :edit, params: { :id => @model.id }, session: {:user => users(:one).id, :expires_at => 5.minutes.from_now}
+        assert_response :forbidden
+        assert_includes @response.body, 'edit_device_roles'
+      end
+
+     test 'should get edit' do
+        get :edit, params: { :id => @model.id }, session: set_session_user
+        assert_response :success
+        assert_template 'edit'
+      end
+
+      def setup_user(role = "")
+        @request.session[:user] = users(:one).id
+        users(:one).roles       = [Role.default]
+        users(:one).roles << Role.find_by_name(role) if role != ""
+        # users(:one).roles       = [Role.default, Role.find_by_name("Viewer")]
+      end
+
+      test "should_render_404_when_device_role_is_not_found" do
+        get :show, params: { id: 'no.such.device.role' }, session: set_session_user
+        assert_response :not_found
+        assert_template 'common/404'
+      end
+
+      test "should_not_destroy_device_role_when_not_permitted" do
+        setup_user
+        assert_difference('ForemanDatacenter::DeviceRole.count', 0) do
+          delete :destroy, params: { :id => @model.id }, session: {:user => users(:one).id, :expires_at => 5.minutes.from_now}
+        end
+        assert_response :forbidden
+      end
+
+      test "should search by name" do
+        get :index, params: {:search => "name=\"device_role_1\""}, session: set_session_user
+        assert_response :success
+        refute_empty assigns(:device_roles)
+        assert assigns(:device_roles).include?(device_roles(:one)) 
+      end
+
+     test "should search by color" do
+        get :index, params: {:search => "color=\"Teal\""}, session: set_session_user
+        assert_response :success
+        refute_empty assigns(:device_roles)
+        assert assigns(:device_roles).include?(device_roles(:one)) 
+      end
+   
+    end
+  end
+end

data/test/controllers/foreman_datacenter/device_types_contoller_test.rb

@@ -13,78 +13,139 @@ module ForemanDatacenter
       basic_pagination_per_page_test
       basic_pagination_rendered_test
 
-      def test_new_submit_button_id
-        get :new, session: set_session_user
-        assert_select "[data-id='aid_datacenter_device_types']"
-      end
+      def test_create_invalid
+        ForemanDatacenter::DeviceType.any_instance.stubs(:valid?).returns(false)
+        post :create, params: { device_type: { model: nil } }, session: set_session_user
+        assert_template 'new'
+         end
 
-      def test_new_cancel_button_id
-        get :new, session: set_session_user
-        assert_select "[data-id='aid_datacenter_device_types']"
-      end
-      
-      def test_show_edit_button_id
-        get :show, params: { :id => ForemanDatacenter::DeviceType.first.to_param }, session: set_session_user
-        assert_select "[data-id='aid_device_types_#{ForemanDatacenter::DeviceType.first.id}_edit']"
+      def test_create_valid(model = "test device_type")
+        ForemanDatacenter::DeviceType.any_instance.stubs(:valid?).returns(true)
+        post :create, params: { device_type: { model: model, manufacturer_id: 1 } }, session: set_session_user
+        assert_redirected_to device_types_url
       end
 
-      def test_show_delete_button_id
-        get :show, params: { :id => ForemanDatacenter::DeviceType.first.to_param }, session: set_session_user
-        assert_select "[data-id='aid_datacenter_device_types_#{ForemanDatacenter::DeviceType.first.id}']"
+      def test_update_invalid
+        ForemanDatacenter::DeviceType.any_instance.stubs(:valid?).returns(false)
+        put :update, params: { id: @model.to_param, device_type: { model: '3243', color: 'Red' } }, session: set_session_user
+        assert_template 'edit'
       end
 
-      test "should_show_device_type" do
-        setup_user
-        get :show, params: { :id => ForemanDatacenter::DeviceType.first.to_param }, session: set_session_user
-        assert_response :success
+      def test_update_valid
+        ForemanDatacenter::DeviceType.any_instance.stubs(:valid?).returns(true)
+        put :update, params: { id: @model.to_param, device_type: { model: @model.model, color: 'Green' } }, session: set_session_user
+        assert_redirected_to device_types_url
       end
 
       def test_create_invalid
         ForemanDatacenter::DeviceType.any_instance.stubs(:valid?).returns(false)
-        post :create, params: { :device_type => {:model => nil} }, session: set_session_user
+        post :create, params: { device_type: { model: nil } }, session: set_session_user
         assert_template 'new'
       end
 
-      def test_create_valid
-        ForemanDatacenter::DeviceType.any_instance.stubs(:valid?).returns(true)
-        post :create, params: { :device_type => {:model => 'test model'} }, session: set_session_user
-        # assert_redirected_to device_types_url
-        # assert_redirected_to device_type_url(ForemanDatacenter::DeviceType.first)
+      def test_destroy
+        test_create_valid "tobedeleted_test"
+        @new_dt = ForemanDatacenter::DeviceType.find_by_model("tobedeleted_test")
+        delete :destroy, params: { id: @new_dt.id }, session: set_session_user
+        assert_redirected_to device_types_url
+        assert !ForemanDatacenter::DeviceType.exists?(@new_dt.id)
       end
 
-      def test_edit_submit_button_id
-        get :edit, params: { :id => ForemanDatacenter::DeviceType.first }, session: set_session_user
-        assert_select "[data-id='aid_update_foreman_datacenter_device_type']"
+      test "should not get index when not permitted" do
+        setup_user
+        get :index, session: { :user => users(:one).id, :expires_at => 5.minutes.from_now }
+        assert_response :forbidden
+        assert_includes @response.body, 'view_device_types'
       end
 
-      def test_update_invalid
-        ForemanDatacenter::DeviceType.any_instance.stubs(:valid?).returns(false)
-        put :update, params: { :id => ForemanDatacenter::DeviceType.first.to_param, :device_type => {:model => "3243"} }, session: set_session_user
-        assert_template 'edit'
+      test 'should not get show when not permitted' do
+        setup_user
+        get :show, params: { :id => @model.id }, session: {:user => users(:one).id, :expires_at => 5.minutes.from_now}
+        assert_response :forbidden
+        assert_includes @response.body, 'view_device_types'
       end
 
-      def test_update_valid
-        ForemanDatacenter::DeviceType.any_instance.stubs(:valid?).returns(true)
-        put :update, params: { :id => ForemanDatacenter::DeviceType.first.to_param, :device_type => {:model => ForemanDatacenter::DeviceType.first.model} }, session: set_session_user
-        # assert_redirected_to device_type_url(ForemanDatacenter::DeviceType.first)
+      test 'should not get edit when not permitted' do
+        setup_user
+        get :edit, params: { :id => @model.id }, session: {:user => users(:one).id, :expires_at => 5.minutes.from_now}
+        assert_response :forbidden
+        assert_includes @response.body, 'edit_device_types'
       end
 
-      def test_destroy
-        device_type = ForemanDatacenter::DeviceType.first
-        # architecture.hosts.delete_all
-        # architecture.hostgroups.delete_all
-        delete :destroy, params: { :id => device_type.id }, session: set_session_user
-        assert_redirected_to device_types_url
-        assert !ForemanDatacenter::DeviceType.exists?(device_type.id)
+      test "should get index" do
+        setup_user("Viewer")
+        get :index, session: set_session_user
+        assert_response :success
+        assert_template 'index'
+      end
+
+      test 'should get show' do
+        setup_user("Viewer")
+        get :show, params: { :id => @model.id }, session: set_session_user
+        assert_response :success
+        assert_template 'show'
+      end
+
+      test 'should not get edit with viewer permissions' do
+        setup_user("Viewer")
+        get :edit, params: { :id => @model.id }, session: {:user => users(:one).id, :expires_at => 5.minutes.from_now}
+        assert_response :forbidden
+        assert_includes @response.body, 'edit_device_types'
       end
 
-      def setup_user
+     test 'should get edit' do
+        get :edit, params: { :id => @model.id }, session: set_session_user
+        assert_response :success
+        assert_template 'edit'
+      end
+
+      def setup_user(role = "")
         @request.session[:user] = users(:one).id
-        users(:one).roles       = [Role.default, Role.find_by_name('Viewer')]
+        users(:one).roles       = [Role.default]
+        users(:one).roles << Role.find_by_name(role) if role != ""
+        # users(:one).roles       = [Role.default, Role.find_by_name("Viewer")]
+      end
+
+      test "should_render_404_when_device_type_is_not_found" do
+        get :show, params: { id: 'no.such.device.type' }, session: set_session_user
+        assert_response :not_found
+        assert_template 'common/404'
       end
 
-      def get_factory_name
-        :device_type
+      test "should_not_destroy_device_type_when_not_permitted" do
+        setup_user
+        assert_difference('ForemanDatacenter::DeviceType.count', 0) do
+          delete :destroy, params: { :id => @model.id }, session: {:user => users(:one).id, :expires_at => 5.minutes.from_now}
+        end
+        assert_response :forbidden
+      end
+
+      test "should search by model" do
+        get :index, params: {:search => "model=\"DeviceType_1NONE\""}, session: set_session_user
+        assert_response :success
+        refute_empty assigns(:device_types)
+        assert assigns(:device_types).include?(device_types(:one))
+      end
+
+      test "should search by manufacturer" do
+        get :index, params: {:search => "manufacturer=\"manufacturer_1\""}, session: set_session_user
+        assert_response :success
+        refute_empty assigns(:device_types)
+        assert assigns(:device_types).include?(device_types(:one))
+      end
+
+      test "should search by subdevice role" do
+        get :index, params: {:search => "subdevice_role=\"None\""}, session: set_session_user
+        assert_response :success
+        refute_empty assigns(:device_types)
+        assert assigns(:device_types).include?(device_types(:one))
+      end
+
+      test "should search by U height" do
+        get :index, params: {:search => "u_height=\"1\""}, session: set_session_user
+        assert_response :success
+        refute_empty assigns(:device_types)
+        assert assigns(:device_types).include?(device_types(:one))
       end
     end
   end