foreman_datacenter 1.20.4 → 1.20.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 31dbb1be5a3d3b9952130a981dd0504936e95b351c1123ca6e8b51722e7fcfd7
-  data.tar.gz: bd5ec041069a976115bac55df645b02334a37e0b250ffcf41fc994ec0458d59d
+  metadata.gz: 20a7f019dba7bbd3c87601170d1b877cb427ebce27908572f7b69460c16ee943
+  data.tar.gz: 6850811eb83a4aef513f74e48fa46d3ab68daa6e632ac410b4141515ae901850
 SHA512:
-  metadata.gz: 71b2ec635d67fc988d2dcfdaae9d4b9639060d91397847d477328341ff21fc6c12f2b3d28a010eaf26ce557351cf524c6a040972fe393f5aa62f50b5e7157b7c
-  data.tar.gz: 9509cc3926f5fe17020ae65dffa2995b671a9dbb8c1ba6c7aa0de76323f52a5b820a8316845217cea3967db51f424c6c439e60966db26969f96be8c6a7d5d851
+  metadata.gz: a019cd9673e4896a04c590ca481982cb959c5f50ac44363bbf3fb0813c796fee9f9c5b7912c1a6e9033534d064f27765d13d0fcf40974e627611d95f0506db1e
+  data.tar.gz: 9f2764dda03e07a2653b420d43f247d0db2847870353d522deb3b06b7f4f89c6dfd4ba24d09386ccd52d5d3c71bac4b6129a2fd26338420e3e38f03c4dcdafb3

data/app/assets/javascripts/foreman_datacenter/modal.js

@@ -10,7 +10,8 @@ $(window).click(function(event) {
     var patt = new RegExp(str);
     var token = $('meta[name="csrf-token"]').attr('content');
     if (object_type == 'device') {
-      var checkbox_label = 'Delete associated host ONLY and keep current device as UNASSIGNED!'
+      // var checkbox_label = 'Delete associated host ONLY and keep current device as UNASSIGNED!'
+      var checkbox_label = ''
     } else {
       var checkbox_label = 'Delete ' +  object_type + ' ONLY'
     }
@@ -18,11 +19,18 @@ $(window).click(function(event) {
     if (!(patt.test(pathname))) {
       pathname = pathname + str
     }
-
     var move = "<p></p>"
-    if (object_type == "device" || object_type == "site" || object_type == "rack" || object_type == "rack_group") {
+    var checkbox = ""
+    var text = "You will permanently delete the"
+    text_ao = ""
+    if (object_type == "site" || object_type == "rack" || object_type == "rack_group") {
       move = '<p>You also can move associated object to another <strong>' + object_type + '</strong> before you destroy it.</p> \
           <a class="btn btn-block btn-primary modal-btn modal-btn-primary marginbottomsixteen" href="/datacenter/' + object_type + 's/' + object_id + '/move">Move associated objects</a>'
+      checkbox = '<input type="checkbox" name="object_only" id="object_only" value="true" checked="checked">'
+      text = "By unselecting checkbox you will permanently delete the"
+      text_ao = 'with \
+            <strong>ALL</strong> \
+            associated objects' + ao
     }
 
     var form = '<div id="myModal" class="modal"> \
@@ -37,16 +45,15 @@ $(window).click(function(event) {
         <div class="modal-body"> \
           <p>This action \
             <strong>cannot</strong> \
-            be undone. By unselecting checkbox you will permanently delete the \
+            be undone. \
+            ' + text + ' \
             <strong>' + object_name + '</strong> \
-            with \
-            <strong>ALL</strong> \
-            associated objects' + ao + ' \
+            ' + text_ao + ' \
           </p> \
           <form class="modal-form nonpaddingbottom" action=' + pathname + ' accept-charset="UTF-8" method="post"> \
             <input type="hidden" name="_method" value="delete"> \
             <input type="hidden" name="authenticity_token" value=' + token + '> \
-            <input type="checkbox" name="object_only" id="object_only" value="true" checked="checked"> \
+            ' + checkbox + ' \
             <label>' + checkbox_label + '</label> \
             <input type="submit" name="commit" value="I understand the consequences, delete this ' + object_type + '" class="btn btn-block btn-danger modal-btn modal-btn-danger"> \
 	  </form> \

data/app/assets/stylesheets/foreman_datacenter/horizontal-scroll.css

@@ -0,0 +1,9 @@
+.horizontal-scroll {
+  overflow: auto;
+  white-space: nowrap;
+}
+
+.horizontal-scroll > div.col-md-4 {
+  display: inline-block;
+  float: none;
+}

data/app/controllers/api/v2/foreman_datacenter/device_interface_connections_controller.rb

@@ -34,7 +34,7 @@ module Api
         def create
           @device_interface_connection = ::ForemanDatacenter::DeviceInterfaceConnection.new(device_interface_connection_params.merge(interface_a: params[:device_interface_id]))
           @device_interface_connection.first_interface = get_device_interface
-          @device_interface_connection.save
+          process_response @device_interface_connection.save
         end
 
         api :DELETE, "/foreman_datacenter/device_interface_connections/:id/", N_("Delete a DeviceInterfaceConnection")

data/app/controllers/api/v2/foreman_datacenter/management_devices_controller.rb

@@ -34,7 +34,7 @@ module Api
 
 	def create
 	  @management_device = ::ForemanDatacenter::ManagementDevice.new(management_device_params)#.merge(device_id: params[]))
-	  @management_device.save
+          process_response @management_device.save
 	end
 
 	api :PUT, "/foreman_datacenter/management_devices/:id/", N_("Update a management_device")

data/app/controllers/api/v2/foreman_datacenter/power_outlets_controller.rb

@@ -2,14 +2,14 @@ module Api
   module V2
     module ForemanDatacenter
       class PowerOutletsController < ForemanDatacenter::BaseController
-	include ::ForemanDatacenter::Controller::Parameters::PowerOutlet
+        include ::ForemanDatacenter::Controller::Parameters::PowerOutlet
 
         before_action :find_resource, :only => %w{show update destroy connect disconnect}
         add_scoped_search_description_for(::ForemanDatacenter::PowerOutletTemplate)
         param_group :search_and_pagination, ::Api::V2::BaseController
 
         api :GET, "/foreman_datacenter/power_outlets/", N_("List all PowerOutlets")
-        
+
         def index
           @power_outlets = resource_scope_for_index
         end
@@ -20,57 +20,57 @@ module Api
         def show
         end
 
-	def_param_group :power_outlet do
-	  param :power_outlet, Hash, :required => true, :action_aware => true do
-	    param :name, String, :required => true
-	    param :device_id, :number, :desc => N_("Device ID")
-	  end
-	end
+        def_param_group :power_outlet do
+          param :power_outlet, Hash, :required => true, :action_aware => true do
+            param :name, String, :required => true
+            param :device_id, :number, :desc => N_("Device ID")
+          end
+        end
 
-	api :POST, "/foreman_datacenter/power_outlets", N_("Create a PowerOutlet")
-	param_group :power_outlet, :as => :create
+        api :POST, "/foreman_datacenter/power_outlets", N_("Create a PowerOutlet")
+        param_group :power_outlet, :as => :create
 
-	def create
-	  @power_outlet = ::ForemanDatacenter::PowerOutlet.new(power_outlet_params)
-	  @power_outlet.save
-	end
+        def create
+          @power_outlet = ::ForemanDatacenter::PowerOutlet.new(power_outlet_params)
+          process_response @power_outlet.save
+        end
 
-	api :PUT, "/foreman_datacenter/power_outlets/:id/", N_("Update a PowerOutlet")
-	param :id, :identifier, :required => true
-	param_group :power_outlet
+        api :PUT, "/foreman_datacenter/power_outlets/:id/", N_("Update a PowerOutlet")
+        param :id, :identifier, :required => true
+        param_group :power_outlet
 
-	def update
-	  process_response @power_outlet.update(power_outlet_params)
-	end
+        def update
+          process_response @power_outlet.update(power_outlet_params)
+        end
 
-	api :DELETE, "/foreman_datacenter/power_outlets/:id/", N_("Delete a PowerOutlet")
-	param :id, :identifier, :required => true
+        api :DELETE, "/foreman_datacenter/power_outlets/:id/", N_("Delete a PowerOutlet")
+        param :id, :identifier, :required => true
 
-	def destroy
-	  process_response @power_outlet.destroy
-	end
+        def destroy
+          process_response @power_outlet.destroy
+        end
 
-	api :PATCH, "/foreman_datacenter/power_outlets/:id/connect", N_("Connect")
-	param :id, :identifier, :required => true
-	param_group :power_outlet
+        api :PATCH, "/foreman_datacenter/power_outlets/:id/connect", N_("Connect")
+        param :id, :identifier, :required => true
+        param_group :power_outlet
         param :console_server_port_id, :number, :desc => N_("ConsoleServerPort ID"), :required => true
         param :connection_status, :number, :desc => N_("Connections status"), :required => true
 
-	def connect
+        def connect
           power_port = ::ForemanDatacenter::PowerPort.find(params[:power_port_id])
           power_port.connect(
             @power_outlet,
             params[:connection_status]
           )
-	end
+        end
 
-	api :PATCH, "/foreman_datacenter/power_outlets/:id/disconnect", N_("Disconnect")
-	param :id, :identifier, :required => true
-	param_group :power_outlet
+        api :PATCH, "/foreman_datacenter/power_outlets/:id/disconnect", N_("Disconnect")
+        param :id, :identifier, :required => true
+        param_group :power_outlet
 
-	def disconnect
+        def disconnect
           process_response @power_outlet.power_port.disconnect
-	end
+        end
       end
     end
   end

data/app/controllers/foreman_datacenter/console_ports_controller.rb

@@ -72,14 +72,12 @@ module ForemanDatacenter
         console_server_port,
         params[:console_port][:connection_status]
       )
-      redirect_to device_url(id: @console_port.device_id),
-                  notice: 'Console port was successfully connected.'
+      process_success(success_msg: "Console port was successfully connected.", success_redirect: device_url(id: @console_port.device_id))
     end
 
     def disconnect
       @console_port.disconnect
-      redirect_to device_url(id: @console_port.device_id),
-                  notice: 'Console port was successfully disconnected.'
+      process_success(success_msg: "Console port was successfully disconnected.", success_redirect: device_url(id: @console_port.device_id))
     end
   end
 end

data/app/controllers/foreman_datacenter/console_server_ports_controller.rb

@@ -18,8 +18,7 @@ module ForemanDatacenter
       @console_server_port = ForemanDatacenter::ConsoleServerPort.new(console_server_port_params.merge(device_id: params[:device_id]))
 
       if @console_server_port.save
-        redirect_to device_url(id: @console_server_port.device_id),
-                    notice: 'Console server port was successfully created.'
+        process_success(success_msg: "Console server port was successfully created.", success_redirect: device_url(id: @console_server_port.device_id))
       else
         process_error object: @console_server_port
       end
@@ -27,8 +26,7 @@ module ForemanDatacenter
 
     def update
       if @console_server_port.update(console_server_port_params)
-        redirect_to device_url(id: @console_server_port.device_id),
-                    notice: 'Console server port was successfully updated.'
+        process_success(success_msg: "Console server port was successfully updated.", success_redirect: device_url(id: @console_server_port.device_id))
       else
         process_error object: @console_server_port
       end
@@ -36,8 +34,7 @@ module ForemanDatacenter
 
     def destroy
       if @console_server_port.destroy
-        redirect_to device_url(id: @console_server_port.device_id),
-                    notice: 'Console server port was successfully destroyed.'
+        process_success(success_msg: "Console server port was successfully destroyed.", success_redirect: device_url(id: @console_server_port.device_id))
       else
         process_error object: @console_server_port
       end
@@ -52,14 +49,12 @@ module ForemanDatacenter
         @console_server_port,
         params[:console_port][:connection_status]
       )
-      redirect_to device_url(id: @console_server_port.device_id),
-                  notice: 'Console server port was successfully connected.'
+      process_success(success_msg: "Console server port was successfully connected.", success_redirect: device_url(id: @console_server_port.device_id))
     end
 
     def disconnect
       @console_server_port.console_port.disconnect
-      redirect_to device_url(id: @console_server_port.device_id),
-                  notice: 'Console server port was successfully disconnected.'
+      process_success(success_msg: "Console server port was successfully disconnected.", success_redirect: device_url(id: @console_server_port.device_id))
     end
 
     def for_device

data/app/controllers/foreman_datacenter/device_bays_controller.rb

@@ -17,8 +17,7 @@ module ForemanDatacenter
       @device_bay = ForemanDatacenter::DeviceBay.new(device_bay_params.merge(device_id: params[:device_id]))
 
       if @device_bay.save
-        redirect_to device_url(@device_bay.device),
-                    notice: 'New device bay was successfully created'
+        process_success(success_msg: "New device bay was successfully created.", success_redirect: device_url(id: @device_bay.device))
       else
         process_error object: @device_bay
       end
@@ -26,8 +25,7 @@ module ForemanDatacenter
 
     def update
       if @device_bay.update(device_bay_params)
-        redirect_to device_url(@device_bay.device),
-                    notice: 'Device bay was successfully updated'
+        process_success(success_msg: "Device bay was successfully updated.", success_redirect: device_url(id: @device_bay.device))
       else
         process_error object: @device_bay
       end
@@ -35,8 +33,7 @@ module ForemanDatacenter
 
     def destroy
       if @device_bay.destroy
-        redirect_to device_url(@device_bay.device),
-                    notice: 'Device bay was successfully destroyed'
+        process_success(success_msg: "Device bay was successfully destroyed.", success_redirect: device_url(id: @device_bay.device))
       else
         process_error object: @device_bay
       end
@@ -48,8 +45,7 @@ module ForemanDatacenter
     def populate
       device_id = params[:device_bay][:installed_device_id]
       if @device_bay.update(installed_device_id: device_id)
-        redirect_to device_url(@device_bay.device),
-                    notice: 'Device bay was successfully populated'
+        process_success(success_msg: "Device bay was successfully populated.", success_redirect: device_url(id: @device_bay.device))
       else
         process_error object: @device_bay
       end
@@ -57,8 +53,7 @@ module ForemanDatacenter
 
     def depopulate
       if @device_bay.update(installed_device_id: nil)
-        redirect_to device_url(@device_bay.device),
-                    notice: 'Device bay was successfully depopulated'
+        process_success(success_msg: "Device bay was successfully depopulated.", success_redirect: device_url(id: @device_bay.device))
       else
         process_error object: @device_bay
       end

data/app/controllers/foreman_datacenter/device_interface_connections_controller.rb

@@ -3,10 +3,10 @@ module ForemanDatacenter
     include Foreman::Controller::AutoCompleteSearch
     include ForemanDatacenter::Controller::Parameters::DeviceInterfaceConnection
 
-    before_action :find_resource, only: [:destroy, :planned, :connected]
+    before_action :find_resource, only: [:destroy, :planned, :connected, :edit]
 
     def index
-      @device_interface_connections = resource_base_search_and_page.includes(:second_interface, first_interface: [:device])
+      @device_interface_connections = resource_base_search_and_page.includes(second_interface: [:device], first_interface: [:device])
     end
 
     def new
@@ -15,13 +15,16 @@ module ForemanDatacenter
       )
     end
 
+    def edit
+      @device = @device_interface_connection.first_device
+    end
+
     def create
       @device_interface_connection = ForemanDatacenter::DeviceInterfaceConnection.new(device_interface_connection_params.merge(interface_a: params[:device_interface_id]))
       @device_interface_connection.first_interface = get_device_interface
 
       if @device_interface_connection.save
-        redirect_to device_url(@device_interface_connection.first_interface.device),
-                    notice: 'Connection was successfully created.'
+        process_success(success_msg: "Connection was successfully created.", success_redirect: device_url(id: @device_interface_connection.first_interface.device))
       else
         process_error object: @device_interface_connection
       end

data/app/controllers/foreman_datacenter/device_interfaces_controller.rb

@@ -28,8 +28,7 @@ module ForemanDatacenter
       @device_interface = ForemanDatacenter::DeviceInterface.new(device_interface_params.merge(device_id: params[:device_id]))
 
       if @device_interface.save
-        redirect_to device_url(id: @device_interface.device_id),
-                    notice: 'Device interface was successfully created.'
+        process_success(success_msg: "Device interface was successfully created.", success_redirect: device_url(id: @device_interface.device.id))
       else
         process_error object: @device_interface
       end
@@ -37,8 +36,7 @@ module ForemanDatacenter
 
     def update
       if @device_interface.update(device_interface_params)
-        redirect_to device_url(id: @device_interface.device_id),
-                    notice: 'Device interface was successfully updated.'
+        process_success(success_msg: "Device interface was successfully updated.", success_redirect: device_url(id: @device_interface.device.id))
       else
         process_error object: @device_interface
       end
@@ -46,8 +44,7 @@ module ForemanDatacenter
 
     def destroy
       if @device_interface.destroy
-        redirect_to device_url(id: @device_interface.device_id),
-                    notice: 'Device interface was successfully destroyed.'
+        process_success(success_msg: "Device interface was successfully destroyed.", success_redirect: device_url(id: @device_interface.device.id))
       else
         process_error object: @device_interface
       end

data/app/controllers/foreman_datacenter/device_modules_controller.rb

@@ -15,10 +15,8 @@ module ForemanDatacenter
 
     def create
       @device_module = ForemanDatacenter::DeviceModule.new(device_module_params.merge(device_id: params[:device_id]))
-
       if @device_module.save
-        redirect_to inventory_device_url(id: @device_module.device_id),
-                    notice: 'Device module was successfully created.'
+        process_success(success_msg: "Device module was successfully created.", success_redirect: inventory_device_url(id: @device_module.device_id))
       else
         process_error object: @device_module
       end
@@ -26,8 +24,7 @@ module ForemanDatacenter
 
     def update
       if @device_module.update(device_module_params)
-        redirect_to inventory_device_url(id: @device_module.device_id),
-                    notice: 'Device module was successfully updated.'
+        process_success(success_msg: "Device module was successfully updated.", success_redirect: inventory_device_url(id: @device_module.device_id))
       else
         process_error object: @device_module
       end
@@ -35,8 +32,7 @@ module ForemanDatacenter
 
     def destroy
       if @device_module.destroy
-        redirect_to inventory_device_url(id: @device_module.device_id),
-                    notice: 'Device module was successfully destroyed.'
+        process_success(success_msg: "Device module was successfully destroyed.", success_redirect: inventory_device_url(id: @device_module.device_id))
       else
         process_error object: @device_module
       end

data/app/controllers/foreman_datacenter/device_types_controller.rb

@@ -33,8 +33,7 @@ module ForemanDatacenter
 
     def update
       if @device_type.update(device_type_params)
-        redirect_to device_type_url(@device_type),
-                    notice: 'Device type was successfully updated'
+        process_success object: @device_type
       else
         process_error object: @device_type
       end

data/app/controllers/foreman_datacenter/devices_controller.rb

@@ -17,11 +17,8 @@ module ForemanDatacenter
 
     def show
       @device = ForemanDatacenter::Device.includes(
-        power_ports: [:power_outlet, :device],
-        power_outlets: [:device, :power_port],
-        console_ports: [:console_server_port, :device],
-        console_server_ports: [:console_port, :device],
-        device_bays: [:installed_device],
+        power_ports: [:power_outlet],
+        console_ports: [:console_server_port],
         comments: [:user]
       ).find(params[:id])
       @comments = @device.comments
@@ -63,21 +60,10 @@ module ForemanDatacenter
     end
 
     def destroy
-      unless params['object_only']
-        if @device.destroy
-          process_success success_redirect: "/datacenter/devices"
-        else
-          process_error object: @device
-        end
+      if @device.destroy
+        process_success success_redirect: "/datacenter/devices"
       else
-        if @device.host
-          @device.host.destroy
-          new_device_name = "Unassigned device (former: #{@device.name})"
-          @device.update(name: new_device_name)
-          process_success success_redirect: '/datacenter/devices', success_msg: 'Associated host deleted'
-        else
-          process_error success_redirect: '/datacenter/devices', error_msg: 'Associated host not found'
-        end
+        process_error object: @device
       end
     end
 
@@ -110,7 +96,7 @@ module ForemanDatacenter
       @device.non_management_interfaces.
         where(id: params[:interfaces]).
         destroy_all
-      redirect_to device_url(@device)
+      process_success(success_msg: "Selected interfaces were successfully destroyed.", success_redirect: device_url(id: @device))
     end
 
     def qr_code
@@ -121,11 +107,9 @@ module ForemanDatacenter
 
     def sync_interfaces_with_host
       if @device.sync_interfaces_with_host
-        notice("Device successfully synchronized.")
-        redirect_to device_url(@device)
+        process_success(success_msg: "Device successfully synchronized.", success_redirect: device_url(id: @device))
       else
-        error("Unsuccessful synchronization.")
-        redirect_to device_url(@device)
+        process_error(error_msg: "Unsuccessfully synchronization.", redirect: device_url(@device))
       end
     end
 
@@ -154,4 +138,3 @@ module ForemanDatacenter
     end
   end
 end
-

data/app/controllers/foreman_datacenter/management_devices_controller.rb

@@ -16,8 +16,7 @@ module ForemanDatacenter
       @management_device = ManagementDevice.new(management_device_params.merge(device_id: params[:device_id]))
 
       if @management_device.save
-        redirect_to device_url(@management_device.device),
-                    notice: 'New management device was successfully created'
+        process_success(success_redirect: device_url(id: @management_device.device))
       else
         process_error object: @management_device
       end
@@ -25,8 +24,7 @@ module ForemanDatacenter
 
     def update
       if @management_device.update(management_device_params)
-        redirect_to device_url(@management_device.device),
-                    notice: 'Management device was successfully updated'
+        process_success(success_redirect: device_url(id: @management_device.device))
       else
         process_error object: @management_device
       end
@@ -34,8 +32,7 @@ module ForemanDatacenter
 
     def destroy
       if @management_device.destroy
-        redirect_to device_url(@management_device.device),
-                    notice: 'Management device was successfully destroyed'
+        process_success(success_redirect: device_url(id: @management_device.device))
       else
         process_error object: @management_device
       end

data/app/controllers/foreman_datacenter/power_outlets_controller.rb

@@ -18,8 +18,7 @@ module ForemanDatacenter
       @power_outlet = PowerOutlet.new(power_outlet_params.merge(device_id: params[:device_id]))
 
       if @power_outlet.save
-        redirect_to device_url(id: @power_outlet.device_id),
-                    notice: 'Power outlet was successfully created.'
+        process_success(success_redirect: device_url(id: @power_outlet.device_id))
       else
         process_error object: @power_outlet
       end
@@ -27,8 +26,7 @@ module ForemanDatacenter
 
     def update
       if @power_outlet.update(power_outlet_params)
-        redirect_to device_url(id: @power_outlet.device_id),
-                    notice: 'Power outlet was successfully updated.'
+        process_success(success_redirect: device_url(id: @power_outlet.device_id))
       else
         process_error object: @power_outlet
       end
@@ -36,8 +34,7 @@ module ForemanDatacenter
 
     def destroy
       if @power_outlet.destroy
-        redirect_to device_url(id: @power_outlet.device_id),
-                    notice: 'Power outlet was successfully destroyed.'
+        process_success(success_redirect: device_url(id: @power_outlet.device_id))
       else
         process_error object: @power_outlet
       end
@@ -52,14 +49,12 @@ module ForemanDatacenter
         @power_outlet,
         params[:power_port][:connection_status]
       )
-      redirect_to device_url(id: @power_outlet.device_id),
-                  notice: 'Power outlet was successfully connected.'
+      process_success(success_msg: "Power outlet was successfully connected.", success_redirect: device_url(id: @power_outlet.device_id))
     end
 
     def disconnect
       @power_outlet.power_port.disconnect
-      redirect_to device_url(id: @power_outlet.device_id),
-                  notice: 'Power outlet was successfully disconnected.'
+      process_success(success_msg: "Power outlet was successfully disconnected.", success_redirect: device_url(id: @power_outlet.device_id))
     end
 
     def for_device

data/app/controllers/foreman_datacenter/power_ports_controller.rb

@@ -24,8 +24,7 @@ module ForemanDatacenter
       @power_port = ForemanDatacenter::PowerPort.new(power_port_params.merge(device_id: params[:device_id]))
 
       if @power_port.save
-        redirect_to device_url(id: @power_port.device_id),
-                    notice: 'Power port was successfully created.'
+        process_success(success_redirect: device_url(id: @power_port.device_id))
       else
         process_error object: @power_port
       end
@@ -33,8 +32,7 @@ module ForemanDatacenter
 
     def update
       if @power_port.update(power_port_params)
-        redirect_to device_url(id: @power_port.device_id),
-                    notice: 'Power port was successfully updated.'
+        process_success(success_redirect: device_url(id: @power_port.device_id))
       else
         process_error object: @power_port
       end
@@ -42,8 +40,7 @@ module ForemanDatacenter
 
     def destroy
       if @power_port.destroy
-        redirect_to device_url(id: @power_port.device_id),
-                    notice: 'Power port was successfully destroyed.'
+        process_success(success_redirect: device_url(id: @power_port.device_id))
       else
         process_error object: @power_port
       end
@@ -73,14 +70,12 @@ module ForemanDatacenter
         power_outlet,
         params[:power_port][:connection_status]
       )
-      redirect_to device_url(id: @power_port.device_id),
-                  notice: 'Power port was successfully connected.'
+      process_success(success_msg: "Power port was successfully connected.", success_redirect: device_url(id: @power_port.device_id))
     end
 
     def disconnect
       @power_port.disconnect
-      redirect_to device_url(id: @power_port.device_id),
-                  notice: 'Power port was successfully disconnected.'
+      process_success(success_msg: "Power port was successfully disconnected.", success_redirect: device_url(id: @power_port.device_id))
     end
   end
 end

data/app/controllers/foreman_datacenter/rack_groups_controller.rb

@@ -59,7 +59,7 @@ module ForemanDatacenter
     end
 
     def racks
-      @racks = @rack_group.racks.includes(:devices)
+      @racks = @rack_group.racks.includes(devices: [:device_role])
       process_error redirect: rack_groups_path(@rack_group), error_msg: 'Current Rack Group haven\'t any Racks.' if @racks.empty?
     end
 

data/app/controllers/foreman_datacenter/sites_controller.rb

@@ -51,8 +51,9 @@ module ForemanDatacenter
     end
 
     def racks
-      @racks = @site.racks.includes(:devices)
-      process_error redirect: site_path(@site), error_msg: 'Current site haven\'t any Racks.' if @racks.empty?
+      @rack_groups = @site.rack_groups.includes(racks: [devices: [:device_role]])
+      @ungrouped_racks = @site.racks.where(rack_group_id: nil)#.includes(:device_role)
+      process_error redirect: site_path(@site), error_msg: 'Current site haven\'t any Racks.' if (@rack_groups.empty? && @ungrouped_racks.empty?)
     end
 
     def move

data/app/models/foreman_datacenter/device_interface_connection.rb

@@ -23,7 +23,7 @@ module ForemanDatacenter
     scoped_search in: :second_interface, on: :name, complete_value: true, rename: :interface_b
 
     def first_device
-      first_interface.device
+      self.try(:first_interface).try(:device)
     end
 
     def first_rack
@@ -35,7 +35,7 @@ module ForemanDatacenter
     end
 
     def second_device
-      first_interface.device
+      self.try(:second_interface).try(:device)
     end
 
     def second_rack

data/app/views/foreman_datacenter/console_ports/index.html.erb

@@ -14,12 +14,34 @@
     <% for port in @console_ports %>
       <tr>
         <td>
-          <%= link_to port.console_server_port.device.name,
-                      device_path(port.console_server_port.device) %>
+          <% if port.console_server_port %>
+            <%= link_to port.console_server_port.device.name,
+                        device_path(port.console_server_port.device) %>
+          <% else %>
+            <%= muted_text("Device not found", "span") %>
+          <% end %>
+        </td>
+        <td>
+          <% if port.console_server_port %>
+            <%= h port.console_server_port.name %>
+          <% else %>
+            <%= muted_text("Port not found", "span") %>
+          <% end %>
+        </td>
+        <td>
+          <% if port.device %>
+            <%= link_to port.device.name, device_path(port.device) %>
+          <% else %>
+            <%= muted_text("Device not found", "span") %>
+          <% end %>
+        </td>
+        <td>
+          <% if port %>
+            <%= h port.name %>
+          <% else %>
+            <%= muted_text("Port not found", "span") %>
+          <% end %>
         </td>
-        <td><%= h port.console_server_port.name %></td>
-        <td><%= link_to port.device.name, device_path(port.device) %></td>
-        <td><%= h port.name %></td>
       </tr>
     <% end %>
   </tbody>

data/app/views/foreman_datacenter/device_interface_connections/index.html.erb

@@ -15,15 +15,35 @@
     <% for connection in @device_interface_connections %>
       <tr>
         <td>
-          <%= link_to connection.first_device.name,
+          <% if connection.first_device %>
+            <%= link_to connection.first_device.name,
                         device_path(connection.first_device) %>
+          <% else %>
+            <%= muted_text("Device not found", "span") %>
+          <% end %>
         </td>
-        <td><%= h connection.first_interface.name %></td>
         <td>
+          <% if connection.first_device %>
+            <%= h connection.first_interface.name %>
+          <% else %>
+            <%= muted_text("Interface not found", "span") %>
+          <% end %>
+        </td>
+        <td>
+          <% if connection.second_device %>
           <%= link_to connection.second_device.name,
                       device_path(connection.second_device) %>
+          <% else %>
+            <%= muted_text("Device not found", "span") %>
+          <% end %>
+        </td>
+        <td>
+          <% if connection.second_device %>
+            <%= h connection.second_interface.name %>
+          <% else %>
+            <%= muted_text("Interface not found", "span") %>
+          <% end %>
         </td>
-        <td><%= h connection.second_interface.name %></td>
       </tr>
   <% end %>
   </tbody>

data/app/views/foreman_datacenter/devices/_interface.html.erb

@@ -8,11 +8,24 @@
       <td><%= h interface.mac_address %></td>
       <td><%= h interface.ip_address %></td>
       <td>
-        <%= link_to interface.connected_interface.device.name,
-                    device_path(interface.connected_interface.device) %>
+        <% if interface.connected_interface %>
+          <%= link_to interface.connected_interface.device.name,
+                      device_path(interface.connected_interface.device) %>
+        <% else %>
+            <%= muted_text("Device not found", "span") %>
+        <% end %>
       </td>
       <td>
-        <%= h interface.connected_interface.name %>
+        <% if interface.connected_interface %>
+          <%= h interface.connected_interface.name %>
+        <% else %>
+            <%= muted_text("Interface not found", "span") %>
+        <% end %>
+      </td>
+      <td>
+        <%= h interface.connection.id %>
+        -
+        <%= h interface.form_factor %>
       </td>
       <td></td>
       <td class="text-right">
@@ -56,6 +69,7 @@
       <td></td>
       <td class="text-muted">Not connected</td>
       <td></td>
+      <td></td>
       <td class="text-right">
         <%= link_to new_device_interface_device_interface_connection_path(interface),
                     class: 'btn btn-success btn-xs', title: 'Connect' do %>

data/app/views/foreman_datacenter/devices/show.html.erb

@@ -257,7 +257,7 @@
             <tr>
               <td><%= _("Console URL") %></td>
               <td>
-                <%= link_to @device.console_url, "http://#{@device.console_url}", target: "_blank" %>
+                <%= link_to @device.console_url, "#{@device.console_url}", target: "_blank" %>
               </td>
 
             </tr>

data/app/views/foreman_datacenter/platforms/show.html.erb

@@ -12,14 +12,14 @@
                    :class => 'btn btn-warning'
                  ),
                  display_fake_delete_if_authorized(
-                    hash_for_platform_path(id: @platform),
-                    class: 'btn btn-danger',
-                    id: 'init-modal',
-                    href: '#',
-                    data: { objecttype: 'platform',
-                            objectid: @platform.id,
-                            objectname: @platform.to_label,
-                            associatedobjects: associated_objects('platform') }
+                   hash_for_platform_path(:id => @platform).merge(:auth_object => @platform, :authorizer => authorizer),
+                   class: 'btn btn-danger',
+                   id: 'init-modal',
+                   href: '#',
+                   data: { objecttype: 'platform',
+                           objectid: @platform.id,
+                           objectname: @platform.to_label,
+                           associatedobjects: associated_objects('platform') }
                  )
                  help_path %>
 

data/app/views/foreman_datacenter/rack_groups/racks.html.erb

@@ -1,19 +1,18 @@
 <% stylesheet 'foreman_datacenter/datacenter' %>
 <% stylesheet 'foreman_datacenter/device_roles' %>
+<% stylesheet 'foreman_datacenter/horizontal-scroll' %>
 
 <% title h(@rack_group.name) %>
 
 <%= breadcrumbs(items: [{caption: _('Rack Group %s')   % @rack_group.name, url: rack_group_path(@rack_group)}, {caption: _('Racks Overview')}]) %>
 
-<% @racks.in_groups_of(3).each do |g| %>
-  <div class="row">
-    <% g.compact.each do |rack| %>
-      <div class="col-md-4">
-        <!-- Devices -->
-        <%= render "foreman_datacenter/racks/device_position", rack: rack %>
-      </div>
-    <% end %>
-  </div>
-<% end %>
+<div class="row horizontal-scroll">
+  <% @racks.each do |rack| %>
+    <div class="col-md-4">
+      <%= render "foreman_datacenter/racks/device_position", rack: rack %>
+    </div>
+  <% end %>
+</div>
+
 <div><h6 class="text-right"><%= _("* side is not defined") %></h6></div>
 <div><h6 class="text-right"><%= _("** size is not defined") %></h6></div>

data/app/views/foreman_datacenter/racks/_device_position.html.erb

@@ -25,7 +25,7 @@
       <% end %>
       <% unless rack.unpositioned_devices.empty? %>
         <tr>
-          <td class="col-md-1">Unpositioned Devices</td>
+          <td class="col-md-1">Unpositioned</br>Devices</td>
           <td class="col-md-4" style="text-align:center">
             <% rack.unpositioned_devices.each do |d| %>
               <div class="<%= "label " + d.device_role.color.downcase.gsub(" ","") %>" style="border-radius:40px;border:0px;">&nbsp;&nbsp;</div>

data/app/views/foreman_datacenter/sites/racks.html.erb

@@ -1,17 +1,36 @@
 <% stylesheet 'foreman_datacenter/datacenter' %>
 <% stylesheet 'foreman_datacenter/device_roles' %>
+<% stylesheet 'foreman_datacenter/horizontal-scroll' %>
 
 <% title h(@site.name) %>
 
-<% @racks.in_groups_of(3).each do |g| %>
-  <div class="row">
-    <% g.compact.each do |rack| %>
+<%= breadcrumbs(items: [{caption: _('Site %s') % @site.name, url: site_path(@site)}, {caption: _('Racks Overview')}]) %>
+
+<% unless @rack_groups.empty? %>
+  <% @rack_groups.each do |rg| %>
+    <h2>
+      <%= rg.name %>
+    </h2>
+    <div class="row horizontal-scroll">
+      <% rg.racks.each do |rack| %>
+        <div class="col-md-4">
+          <%= render "foreman_datacenter/racks/device_position", rack: rack %>
+        </div>
+      <% end %>
+    </div>
+  <% end %>
+<% end %>
+
+<% unless @ungrouped_racks.empty? %>
+  <h2>Ungrouped Racks</h2>
+  <div class="row horizontal-scroll">
+    <% @ungrouped_racks.each do |rack| %>
       <div class="col-md-4">
-        <!-- Devices -->
         <%= render "foreman_datacenter/racks/device_position", rack: rack %>
       </div>
     <% end %>
   </div>
 <% end %>
+
 <div><h6 class="text-right"><%= _("* side is not defined") %></h6></div>
 <div><h6 class="text-right"><%= _("** size is not defined") %></h6></div>

data/db/migrate/20180725201545_add_location_id_and_organization_id_columns_to_devices.rb

@@ -1,4 +1,4 @@
-class AddLocationIdAndOrganizationIdColumnsToDevices < ActiveRecord::Migration
+class AddLocationIdAndOrganizationIdColumnsToDevices < ActiveRecord::Migration[4.2]
   def change
     add_column :devices, :organization_id, :integer
     add_column :devices, :location_id, :integer

data/lib/foreman_datacenter/version.rb

@@ -1,3 +1,3 @@
 module ForemanDatacenter
-  VERSION = '1.20.4'.freeze
+  VERSION = '1.20.6'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foreman_datacenter
 version: !ruby/object:Gem::Version
-  version: 1.20.4
+  version: 1.20.6
 platform: ruby
 authors:
 - Pavel Ivanov
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-25 00:00:00.000000000 Z
+date: 2019-08-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: prawn
@@ -90,6 +90,7 @@ files:
 - app/assets/stylesheets/foreman_datacenter/device_interface_connections.css
 - app/assets/stylesheets/foreman_datacenter/device_roles.css
 - app/assets/stylesheets/foreman_datacenter/devices.css
+- app/assets/stylesheets/foreman_datacenter/horizontal-scroll.css
 - app/assets/stylesheets/foreman_datacenter/modal.css
 - app/assets/stylesheets/foreman_datacenter/title_filter.css
 - app/controllers/api/v2/foreman_datacenter/base_controller.rb
@@ -593,7 +594,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: A plugin that lets you document your servers in a datacenter