foreman_datacenter 0.1.54 → 0.1.55

data/app/views/foreman_datacenter/sites/move.html.erb

@@ -0,0 +1,27 @@
+<% title _("Move associated objects") %>
+
+<%= breadcrumbs(items: [{caption: _('Sites'), url: sites_path}, {caption: _("Move associated objects")}]) %>
+
+<%= form_tag ('/datacenter/site_update_associated_objects'), class: 'form-horizontal well' do %>
+  <div class='clearfix'>
+    <%= label_tag 'Site *', nil, class: 'col-md-2 control-label' %>
+    <div class='col-md-4'>
+      <%= select_tag 'site_id', options_from_collection_for_select(@sites, 'id', 'name', @site.id), class: 'form-control' %>
+      <span class="help-block">
+        You are going to update <b>site_id</b> for all associated objects:
+        <% unless @rack_groups.empty? %>
+          </br><b>Rack Groups:</b> <%= @rack_groups.map(&:name).join(', ') %>
+        <% end %>
+        <% unless @racks.empty? %>
+          </br><b>Racks:</b> <%= @racks.map(&:name).join(', ') %>
+        <% end %>
+      </span>
+    </div>
+  </div>
+  <div class='clearfix'>
+    <div class='form-actions'>
+      <%= submit_tag 'Submit', class: 'btn btn-primary remove_form_templates' %>
+      <%= link_to(_("Cancel"), site_path(params[:id]), :class => "btn btn-default")%>
+    </div>
+  </div>
+<% end %>

data/app/views/foreman_datacenter/sites/new.html.erb

@@ -1,3 +1,5 @@
-<% title 'New site' %>
+<% title _("Create Site") %>
+
+<%= breadcrumbs(items: [{caption: _('Sites'), url: sites_path}, {caption: _("Create Site")}]) %>
 
 <%= render 'form' %>

data/app/views/foreman_datacenter/sites/show.html.erb

@@ -1,17 +1,30 @@
 <% stylesheet 'foreman_datacenter/datacenter' %>
+<% stylesheet 'foreman_datacenter/modal' %>
+<% javascript 'foreman_datacenter/modal' %>
 
 <% title h(@site.name) %>
 
+<%= breadcrumbs(items: [{caption: _('Sites'), url: '/datacenter/sites'}, {caption: _(@site.to_label)}]) %>
+
 <% title_actions display_link_if_authorized(
+                     _('Move associated objects'),
+                     hash_for_move_site_path(id: @site),
+                     class: 'btn btn-primary'
+                 ),
+                 display_link_if_authorized(
                      _('Edit'),
-                     hash_for_edit_site_path(:id => @site),
-                     :class => 'btn btn-warning'
+                     hash_for_edit_site_path(id: @site),
+                     class: 'btn btn-warning'
                  ),
-                 display_delete_if_authorized(
-                     hash_for_site_path(:id => @site),
-                     :data => { :confirm => 'Are you sure?'},
-                     :action => :destroy,
-                     :class => 'btn btn-danger'
+                 display_fake_delete_if_authorized(
+                     hash_for_site_path(id: @site),
+                     class: 'btn btn-danger',
+                     id: 'init-modal',
+                     href: '#',
+                     data: { objecttype: 'site',
+                             objectid: @site.id,
+                             objectname: @site.to_label,
+                             associatedobjects: associated_objects('site') }
                  )
                  help_path %>
 
@@ -20,53 +33,74 @@
   <div class="col-md-6">
     <div class="panel panel-default">
       <div class="panel-heading">
-        <strong>Site</strong>
+        <strong><%= _("Site") %></strong>
       </div>
-      <table class="<%= table_css_classes 'table-hover panel-body nonmarginbottom' %>">
+      <table class="<%= table_css_classes 'table-fixed nonmarginbottom' %>">
         <tbody>
-        <tr>
-          <td>Facility</td>
-          <td><%= h @site.facility %></td>
-        </tr>
-        <tr>
-          <td>AS Number</td>
-          <td><%= @site.asn %></td>
-        </tr>
-        <tr>
-          <td>Physical Address</td>
-          <td><%= h @site.physical_address %></td>
-        </tr>
-        <tr>
-          <td>Shipping Address</td>
-          <td><%= h @site.shipping_address %></td>
-        </tr>
-        <tr>
-          <td>Created</td>
-          <td><%= @site.created_at.to_s(:long) %></td>
-        </tr>
-        <tr>
-          <td>Last Updated</td>
-          <td><%= @site.updated_at.to_s(:long) %></td>
-        </tr>
+          <tr>
+            <td><%= _("Facility") %></td>
+            <td><%= h @site.facility %></td>
+          </tr>
+          <tr>
+            <td><%= _("AS Number") %></td>
+            <td><%= @site.asn %></td>
+          </tr>
+          <tr>
+            <td><%= _("Physical Address") %></td>
+            <td><%= h @site.physical_address %></td>
+          </tr>
+          <tr>
+            <td><%= _("Shipping Address") %></td>
+            <td><%= h @site.shipping_address %></td>
+          </tr>
+          <tr>
+            <td><%= _("Created") %></td>
+            <td><%= @site.created_at.to_s(:long) %></td>
+          </tr>
+          <tr>
+            <td><%= _("Last Updated") %></td>
+            <td><%= @site.updated_at.to_s(:long) %></td>
+          </tr>
+        </tbody>
+    </table>
+    </div>
+
+    <!-- Comments -->
+    <div class="panel panel-default">
+      <div class="panel-heading"><strong><%= _("Comments") %></strong></div>
+      <table class="<%= table_css_classes 'table-fixed nonmarginbottom' %>">
+        <tbody>
+          <% if @site.comments == "" || @site.comments.nil? %>
+            <%= muted_text("None", "tr", "td") %>
+          <% else %>
+              <tr>
+                <td><%= @site.comments %></td>
+              </tr>
+          <% end %>
         </tbody>
       </table>
     </div>
   </div>
+
   <!-- Stats -->
   <div class="col-md-6">
     <div class="panel panel-default">
       <div class="panel-heading">
-        <strong>Stats</strong>
+        <strong><%= _("Stats") %></strong>
       </div>
-      <table class="<%= table_css_classes 'table-hover panel-body nonmarginbottom' %>">
+      <table class="<%= table_css_classes 'table-fixed nonmarginbottom' %>">
         <tbody>
         <tr>
-          <td>Racks</td>
-          <td><%= @site.racks_count %></td>
+          <td><%= _("Rack Groups") %></td>
+          <td><%= link_to @site.rack_groups_count, rack_groups_path(search: "site=#{@site.name}") %></td>
+        </tr>
+        <tr>
+          <td><%= _("Racks") %></td>
+          <td><%= link_to @site.racks_count, racks_path(search: "site=#{@site.name}") %></td>
         </tr>
         <tr>
-          <td>Devices</td>
-          <td><%= @site.devices_count %></td>
+          <td><%= _("Devices") %></td>
+          <td><%= link_to @site.devices_count, devices_path(search: "site=#{@site.name}") %></td>
         </tr>
         </tbody>
       </table>
@@ -75,27 +109,23 @@
     <!-- Rack groups -->
     <div class="panel panel-default">
       <div class="panel-heading">
-        <strong>Rack Groups</strong>
+        <strong><%= _("Rack Groups") %></strong>
       </div>
-      <table class="<%= table_css_classes 'table-hover panel-body nonmarginbottom' %>">
+      <table class="<%= table_css_classes 'table-fixed nonmarginbottom' %>">
         <tbody>
-        <% @site.rack_groups.each do |rack_group| %>
-            <tr>
-              <td>
-                <%= link_to rack_group.name, rack_group_path(rack_group) %>
-              </td>
-            </tr>
-        <% end %>
+          <% unless @site.rack_groups.empty? %>
+            <% @site.rack_groups.each do |rack_group| %>
+                <tr>
+                  <td>
+                    <%= link_to rack_group.name, rack_group_path(rack_group) %>
+                  </td>
+                </tr>
+            <% end %>
+          <% else %>
+	    <%= muted_text("None", "tr", "td") %>
+          <% end %>
         </tbody>
       </table>
     </div>
   </div>
 </div>
-
-<!-- Comments -->
-<div class="panel panel-default">
-  <div class="panel-heading">
-    <strong>Comments</strong>
-  </div>
-  <div class="panel-body"><%= simple_format @site.comments %></div>
-</div>

data/config/routes.rb

@@ -1,13 +1,24 @@
 Foreman::Application.routes.draw do
 
+  # API
+  namespace :api, :defaults => {:format => 'json'} do
+    # new v2 routes that point to v2
+    scope "(:apiv)", :module => :v2, :defaults => {:apiv => 'v2'}, :apiv => /v2/, :constraints => ApiConstraints.new(:version => 2, :default => true) do
+      scope 'foreman_datacenter', module: :foreman_datacenter do
+        resources :sites
+      end
+    end
+  end
+
   # TODO: find a better way to do this
   get 'datacenter/import_to_device', to: 'hosts#import_to_device',
       as: 'import_to_device'
 
+  get '/api/:controller/(:action(/*welcome))'
+  # get '/datacenter/(:controller)/help', :action => 'welcome', :as => "help"
 
   scope 'datacenter', module: :foreman_datacenter do
     resources :comments, only: [:new, :edit, :create, :update]
-
     resources :sites
     resources :racks do
       get :rack_groups, on: :collection

data/lib/foreman_datacenter/engine.rb

@@ -14,6 +14,15 @@ module ForemanDatacenter
       end
     end
 
+    initializer 'foreman_datacenter.apipie' do
+      # this condition is here for compatibility reason to work with Foreman 1.4.x
+      if Apipie.configuration.api_controllers_matcher.is_a?(Array) &&
+        Apipie.configuration.respond_to?(:checksum_path)
+        Apipie.configuration.api_controllers_matcher << "#{ForemanDatacenter::Engine.root}/app/controllers/api/v2/foreman_datacenter/**/*.rb"
+        Apipie.configuration.checksum_path += ['/foreman_datacenter/api/']
+      end
+    end
+
     initializer 'foreman_datacenter.register_plugin', :before => :finisher_hook do |_app|
       Foreman::Plugin.register :foreman_datacenter do
         requires_foreman '>= 1.12'
@@ -269,8 +278,11 @@ module ForemanDatacenter
           permission :destroy_power_ports, {
                      :'foreman_datacenter/power_ports' => [:destroy]},
                      :resource_type => "ForemanDatacenter::PowerPort"
+          # permission :power_ports, {
+          #            :'foreman_datacenter/power_ports' => [:planned, :connected, :for_device, :new_connection, :connect, :disconnect]},
+          #            :resource_type => "ForemanDatacenter::PowerPort"
           permission :power_ports_connections_management, {
-                     :'foreman_datacenter/device_interface_connections' => [:planned, :connected, :for_device, :new_connection, :connect, :disconnect]},
+                     :'foreman_datacenter/power_ports' => [:planned, :connected, :for_device, :new_connection, :connect, :disconnect]},
                      :resource_type => "ForemanDatacenter::PowerPort"
           # RackGroups
           permission :view_rack_groups, {

data/lib/foreman_datacenter/version.rb

@@ -1,3 +1,3 @@
 module ForemanDatacenter
-  VERSION = '0.1.54'.freeze
+  VERSION = '0.1.55'.freeze
 end

data/test/controllers/foreman_datacenter/device_types_contoller_test.rb

@@ -0,0 +1,91 @@
+require_relative '../../test_plugin_helper'
+
+module ForemanDatacenter
+  class DeviceTypesControllerTest < ActionController::TestCase
+    describe ForemanDatacenter::DeviceTypesController do
+      setup do
+        @model = ForemanDatacenter::DeviceType.first
+      end
+
+      basic_index_test 'device_types'
+      basic_new_test
+      basic_edit_test 'device_type'
+      basic_pagination_per_page_test
+      basic_pagination_rendered_test
+
+      def test_new_submit_button_id
+        get :new, session: set_session_user
+        assert_select "[data-id='aid_datacenter_device_types']"
+      end
+
+      def test_new_cancel_button_id
+        get :new, session: set_session_user
+        assert_select "[data-id='aid_datacenter_device_types']"
+      end
+      
+      def test_show_edit_button_id
+        get :show, params: { :id => ForemanDatacenter::DeviceType.first.to_param }, session: set_session_user
+        assert_select "[data-id='aid_device_types_#{ForemanDatacenter::DeviceType.first.id}_edit']"
+      end
+
+      def test_show_delete_button_id
+        get :show, params: { :id => ForemanDatacenter::DeviceType.first.to_param }, session: set_session_user
+        assert_select "[data-id='aid_datacenter_device_types_#{ForemanDatacenter::DeviceType.first.id}']"
+      end
+
+      test "should_show_device_type" do
+        setup_user
+        get :show, params: { :id => ForemanDatacenter::DeviceType.first.to_param }, session: set_session_user
+        assert_response :success
+      end
+
+      def test_create_invalid
+        ForemanDatacenter::DeviceType.any_instance.stubs(:valid?).returns(false)
+        post :create, params: { :device_type => {:model => nil} }, session: set_session_user
+        assert_template 'new'
+      end
+
+      def test_create_valid
+        ForemanDatacenter::DeviceType.any_instance.stubs(:valid?).returns(true)
+        post :create, params: { :device_type => {:model => 'test model'} }, session: set_session_user
+        # assert_redirected_to device_types_url
+        # assert_redirected_to device_type_url(ForemanDatacenter::DeviceType.first)
+      end
+
+      def test_edit_submit_button_id
+        get :edit, params: { :id => ForemanDatacenter::DeviceType.first }, session: set_session_user
+        assert_select "[data-id='aid_update_foreman_datacenter_device_type']"
+      end
+
+      def test_update_invalid
+        ForemanDatacenter::DeviceType.any_instance.stubs(:valid?).returns(false)
+        put :update, params: { :id => ForemanDatacenter::DeviceType.first.to_param, :device_type => {:model => "3243"} }, session: set_session_user
+        assert_template 'edit'
+      end
+
+      def test_update_valid
+        ForemanDatacenter::DeviceType.any_instance.stubs(:valid?).returns(true)
+        put :update, params: { :id => ForemanDatacenter::DeviceType.first.to_param, :device_type => {:model => ForemanDatacenter::DeviceType.first.model} }, session: set_session_user
+        # assert_redirected_to device_type_url(ForemanDatacenter::DeviceType.first)
+      end
+
+      def test_destroy
+        device_type = ForemanDatacenter::DeviceType.first
+        # architecture.hosts.delete_all
+        # architecture.hostgroups.delete_all
+        delete :destroy, params: { :id => device_type.id }, session: set_session_user
+        assert_redirected_to device_types_url
+        assert !ForemanDatacenter::DeviceType.exists?(device_type.id)
+      end
+
+      def setup_user
+        @request.session[:user] = users(:one).id
+        users(:one).roles       = [Role.default, Role.find_by_name('Viewer')]
+      end
+
+      def get_factory_name
+        :device_type
+      end
+    end
+  end
+end

data/test/controllers/foreman_datacenter/manufacturers_contoller_test.rb

@@ -0,0 +1,97 @@
+require_relative '../../test_plugin_helper'
+
+module ForemanDatacenter
+  class ManufacturersControllerTest < ActionController::TestCase
+    describe ForemanDatacenter::ManufacturersController do
+      setup do
+        @model = ForemanDatacenter::Manufacturer.first
+      end
+
+      basic_index_test 'manufacturers'
+      basic_new_test
+      basic_edit_test 'manufacturer'
+      basic_pagination_per_page_test
+      basic_pagination_rendered_test
+
+      def test_new_submit_button_id
+        get :new, session: set_session_user
+        assert_select "[data-id='aid_datacenter_manufacturers']"
+      end
+
+      def test_new_cancel_button_id
+        get :new, session: set_session_user
+        assert_select "[data-id='aid_datacenter_manufacturers']"
+      end
+      
+      def test_show_edit_button_id
+        get :show, params: { :id => ForemanDatacenter::Manufacturer.first.to_param }, session: set_session_user
+        assert_select "[data-id='aid_manufacturers_#{ForemanDatacenter::Manufacturer.first.id}_edit']"
+      end
+
+      def test_show_delete_button_id
+        get :show, params: { :id => ForemanDatacenter::Manufacturer.first.to_param }, session: set_session_user
+        assert_select "[data-id='aid_datacenter_manufacturers_#{ForemanDatacenter::Manufacturer.first.id}']"
+      end
+
+      test "should_show_manufacturer" do
+        setup_user
+        get :show, params: { :id => ForemanDatacenter::Manufacturer.first.to_param }, session: set_session_user
+        assert_response :success
+      end
+
+      def test_create_invalid
+        ForemanDatacenter::Manufacturer.any_instance.stubs(:valid?).returns(false)
+        post :create, params: { :manufacturer => {:name => nil} }, session: set_session_user
+        assert_template 'new'
+      end
+
+      def test_create_valid
+        ForemanDatacenter::Manufacturer.any_instance.stubs(:valid?).returns(true)
+        post :create, params: { :manufacturer => {:name => 'test manufacturer'} }, session: set_session_user
+        assert_redirected_to manufacturers_url
+      end
+
+      def test_edit_submit_button_id
+        get :edit, params: { :id => ForemanDatacenter::Manufacturer.first }, session: set_session_user
+        assert_select "[data-id='aid_update_foreman_datacenter_manufacturer']"
+      end
+
+      def test_update_invalid
+        ForemanDatacenter::Manufacturer.any_instance.stubs(:valid?).returns(false)
+        put :update, params: { :id => ForemanDatacenter::Manufacturer.first.to_param, :manufacturer => {:name => "3243", :asn => "string"} }, session: set_session_user
+        assert_template 'edit'
+      end
+
+      def test_update_valid
+        ForemanDatacenter::Manufacturer.any_instance.stubs(:valid?).returns(true)
+        put :update, params: { :id => ForemanDatacenter::Manufacturer.first.to_param, :manufacturer => {:name => ForemanDatacenter::Site.first.name} }, session: set_session_user
+        assert_redirected_to manufacturers_url
+      end
+
+      # def test_destroy
+      #   manufacturer = ForemanDatacenter::Manufacturer.first
+      #   # architecture.hosts.delete_all
+      #   # architecture.hostgroups.delete_all
+      #   delete :destroy, params: { :id => manufacturer }, session: set_session_user
+      #   assert_redirected_to manufacturers_url
+      #   assert !ForemanDatacenter::Manufacturer.exists?(manufacturer.id)
+      # end
+
+      test '403 response contains missing permissions' do
+        setup_user
+        get :edit, params: { :id => ForemanDatacenter::Manufacturer.first.id }, session: {:user => users(:one).id, :expires_at => 5.minutes.from_now}
+        assert_response :forbidden
+        assert_includes @response.body, 'edit_manufacturers'
+      end
+
+      def setup_user
+        @request.session[:user] = users(:one).id
+        users(:one).roles       = [Role.default, Role.find_by_name('Viewer')]
+      end
+
+      def get_factory_name
+        :manufacturer
+      end
+    end
+  end
+end