foreman_datacenter 0.1.45 → 0.1.46

data/db/migrate/20160824212010_add_host_ref_to_devices.rb

@@ -1,4 +1,4 @@
-class AddHostRefToDevices < ActiveRecord::Migration
+class AddHostRefToDevices < ActiveRecord::Migration[4.2]
   def change
     add_reference :devices, :host, index: true
   end

data/db/migrate/20160828200938_add_ip_address_to_device_interfaces.rb

@@ -1,4 +1,4 @@
-class AddIpAddressToDeviceInterfaces < ActiveRecord::Migration
+class AddIpAddressToDeviceInterfaces < ActiveRecord::Migration[4.2]
   def change
     add_column :device_interfaces, :ip_address, :string, limit: 128, default: ''
   end

data/db/migrate/20160905211522_create_management_devices.rb

@@ -1,4 +1,4 @@
-class CreateManagementDevices < ActiveRecord::Migration
+class CreateManagementDevices < ActiveRecord::Migration[4.2]
   def change
     create_table :management_devices do |t|
       t.references :device

data/db/migrate/20160906205605_rename_field_in_management_devices.rb

@@ -1,4 +1,4 @@
-class RenameFieldInManagementDevices < ActiveRecord::Migration
+class RenameFieldInManagementDevices < ActiveRecord::Migration[4.2]
   def change
     rename_column :management_devices, :name, :console_url
   end

data/db/migrate/20160909205537_add_name_index_to_racks.rb

@@ -1,4 +1,4 @@
-class AddNameIndexToRacks < ActiveRecord::Migration
+class AddNameIndexToRacks < ActiveRecord::Migration[4.2]
   def change
     add_index :racks, :name
   end

data/db/migrate/20160920221011_remove_index_from_devices.rb

@@ -1,4 +1,4 @@
-class RemoveIndexFromDevices < ActiveRecord::Migration
+class RemoveIndexFromDevices < ActiveRecord::Migration[4.2]
   def change
     remove_index :devices, :name
   end

data/db/migrate/20170824122025_add_side_to_device.rb

@@ -1,4 +1,4 @@
-class AddSideToDevice < ActiveRecord::Migration
+class AddSideToDevice < ActiveRecord::Migration[4.2]
   def change
     add_column :devices, :side, :integer, null: true
   end

data/db/migrate/20170918202630_add_racksize_to_device.rb

@@ -1,4 +1,4 @@
-class AddRacksizeToDevice < ActiveRecord::Migration
+class AddRacksizeToDevice < ActiveRecord::Migration[4.2]
   def change
     add_column :devices, :size, :integer, default: 1
   end

data/db/migrate/20170922110137_create_comments.rb

@@ -1,4 +1,4 @@
-class CreateComments < ActiveRecord::Migration
+class CreateComments < ActiveRecord::Migration[4.2]
   def change
     create_table :comments do |t|
       t.text :content
@@ -6,6 +6,6 @@ class CreateComments < ActiveRecord::Migration
 
       t.timestamps null: false
     end
-    add_index :comments, [:commentable_id, :commentable_type]
+    add_index :comments, [:commentable_id, :commentable_type], name: 'comments_index'
   end
 end

data/db/migrate/20170922174725_renaming_comments.rb

@@ -1,4 +1,4 @@
-class RenamingComments < ActiveRecord::Migration
+class RenamingComments < ActiveRecord::Migration[4.2]
   def change
     rename_table :comments, :datacenter_comments
   end

data/db/migrate/20170924194247_rename_device_comments_column.rb

@@ -1,4 +1,4 @@
-class RenameDeviceCommentsColumn < ActiveRecord::Migration
+class RenameDeviceCommentsColumn < ActiveRecord::Migration[4.2]
   def change
     rename_column :devices, :comments, :old_comments
   end

data/db/migrate/20170929101032_add_parent_id_to_comments.rb

@@ -1,4 +1,4 @@
-class AddParentIdToComments < ActiveRecord::Migration
+class AddParentIdToComments < ActiveRecord::Migration[4.2]
   def change
     add_reference :datacenter_comments, :parent, index: true
   end

data/db/migrate/20171001130802_fix_parent_id_column_in_comments.rb

@@ -1,4 +1,4 @@
-class FixParentIdColumnInComments < ActiveRecord::Migration
+class FixParentIdColumnInComments < ActiveRecord::Migration[4.2]
   def change
     change_column :datacenter_comments, :parent_id, :string
     rename_column :datacenter_comments, :parent_id, :ancestry

data/db/migrate/20171004221349_add_user_id_to_comments.rb

@@ -1,4 +1,4 @@
-class AddUserIdToComments < ActiveRecord::Migration
+class AddUserIdToComments < ActiveRecord::Migration[4.2]
   def change
     add_column :datacenter_comments, :user_id, :integer
   end

data/lib/foreman_datacenter/engine.rb

@@ -413,7 +413,7 @@ module ForemanDatacenter
         role "Datacenter Manager", MANAGER
         add_all_permissions_to_default_roles
 
-        sub_menu :top_menu, :datacenter, :after=> :infrastructure_menu do
+        sub_menu :top_menu, :datacenter, :after=> :infrastructure_menu, :icon => 'pficon pficon-enterprise' do
           menu :top_menu, :sites, :url_hash => { controller: :'foreman_datacenter/sites', action: :index }
           divider :top_menu, :parent => :datacenter, :after => :sites, :caption => 'Racks'
           menu :top_menu, :racks, :url_hash => { controller: :'foreman_datacenter/racks', action: :index }

data/lib/foreman_datacenter/version.rb

@@ -1,3 +1,3 @@
 module ForemanDatacenter
-  VERSION = '0.1.45'.freeze
+  VERSION = '0.1.46'.freeze
 end

data/lib/tasks/test_tasks.rake

@@ -0,0 +1,13 @@
+# Tasks
+namespace :foreman_datacenter do
+  namespace :example do
+    desc 'Example Task'
+    task task: :environment do
+      Comment.create({content: "TEST ++++++++++++++++++++"})
+      ForemanDatacenter::Comment.create({content: "TEST ______________________"})
+      Comment.create(content: "TEST ################")
+      ForemanDatacenter::Comment.create(content: "TEST @@@@@@@@@@@@@@@@@@@@")
+    end
+  end
+end
+

data/test/controllers/foreman_datacenter/rack_groups_contoller_test.rb

@@ -0,0 +1,91 @@
+require 'test_helper'
+
+module ForemanDatacenter
+  class RackGroupsControllerTest < ActionController::TestCase
+    setup do
+      @model = RackGroup.first
+    end
+
+    basic_index_test
+    basic_new_test
+    basic_edit_test
+    basic_pagination_per_page_test
+    basic_pagination_rendered_test
+
+    test 'test_new_submit_button_id' do
+      get :new, {}, set_session_user
+      assert_select "[data-id='aid_create_foreman_datacenter_rack_group']"
+    end
+
+    test 'test_new_cancel_button_id' do
+      get :new, {}, set_session_user
+      assert_select "[data-id='aid_datacenter_rack_groups']"
+    end
+
+    test 'test_create_invalid' do
+      RackGroup.any_instance.stubs(:valid?).returns(false)
+      post :create, {:rack_group => {:name => nil, :site_id => nil}}, set_session_user
+      assert_template 'new'
+    end
+
+    test 'test_create_valid' do
+      RackGroup.any_instance.stubs(:valid?).returns(true)
+      post :create, {:rack_group => {:name => 'test rack_group', :site_id => Site.first.id}}, set_session_user
+      assert_redirected_to rack_groups_url
+    end
+
+    test 'test_edit_submit_button_id' do
+      get :edit, {:id => RackGroup.first}, set_session_user
+      assert_select "[data-id='aid_update_foreman_datacenter_rack_group']"
+    end
+
+    test 'test_update_invalid' do
+      RackGroup.any_instance.stubs(:valid?).returns(false)
+      put :update, {:id => RackGroup.first.to_param, :rack_group => {:name => "3243"}}, set_session_user
+      assert_template 'edit'
+    end
+
+    test 'test_update_valid' do
+      Site.any_instance.stubs(:valid?).returns(true)
+      put :update, {:id => RackGroup.first.to_param, :rack_group => {:name => RackGroup.first.name}}, set_session_user
+      assert_redirected_to rack_groups_url
+    end
+
+    test 'test_destroy' do
+      rack_group = RackGroup.first
+      delete :destroy, {:id => rack_group}, set_session_user
+      assert_redirected_to rack_groups_url
+      assert !RackGroup.exists?(rack_group.id)
+    end
+
+    test '403 response contains missing permissions' do
+      setup_user
+      get :edit, { :id => RackGroup.first.id }, {:user => users(:one).id, :expires_at => 5.minutes.from_now}
+      assert_response :forbidden
+      assert_includes @response.body, 'edit_rack_groups'
+    end
+
+    def setup_user
+      @request.session[:user] = users(:one).id
+      users(:one).roles       = [Role.default, Role.find_by_name('Viewer')]
+    end
+
+    test 'user_with_viewer_rights_should_fail_to_edit_a_rack_group' do
+      setup_user
+      get :edit, {:id => RackGroup.first.id}
+      assert_response :forbidden
+    end
+
+    test 'user_with_viewer_rights_should_succeed_in_viewing_rack_groups' do
+      setup_user
+      get :index
+      assert_response :success
+    end
+
+    test 'user_with_viewer_rights_should_succeed_in_viewing_rack_group' do
+      setup_user
+      get :show
+      assert_response :success
+    end
+  end
+end

data/test/controllers/foreman_datacenter/racks_contoller_test.rb

@@ -0,0 +1,91 @@
+require 'test_helper'
+
+module ForemanDatacenter
+  class RacksControllerTest < ActionController::TestCase
+    setup do
+      @model = ForemanDatacenter::Rack.first
+    end
+
+    basic_index_test
+    basic_new_test
+    basic_edit_test
+    basic_pagination_per_page_test
+    basic_pagination_rendered_test
+
+    test 'test_new_submit_button_id' do
+      get :new, {}, set_session_user
+      assert_select "[data-id='aid_create_foreman_datacenter_racks']"
+    end
+
+    test 'test_new_cancel_button_id' do
+      get :new, {}, set_session_user
+      assert_select "[data-id='aid_datacenter_racks']"
+    end
+
+    test 'test_create_invalid' do
+      ForemanDatacenter::Rack.any_instance.stubs(:valid?).returns(false)
+      post :create, {:rack => {:name => nil, :site => nil, :height => nil}}, set_session_user
+      assert_template 'new'
+    end
+
+    test 'test_create_valid' do
+      ForemanDatacenter::Rack.any_instance.stubs(:valid?).returns(true)
+      post :create, {:rack => {:name => 'test rack', :height => '42', :site => Site.first.id }}, set_session_user
+      assert_redirected_to racks_url
+    end
+
+    test 'test_edit_submit_button_id' do
+      get :edit, {:id => ForemanDatacenter::Rack.first}, set_session_user
+      assert_select "[data-id='aid_update_foreman_datacenter_rack']"
+    end
+
+    test 'test_update_invalid' do
+      ForemanDatacenter::Rack.any_instance.stubs(:valid?).returns(false)
+      put :update, {:id => ForemanDatacenter::Rack.first.to_param, :rack => {:name => "3243"}}, set_session_user
+      assert_template 'edit'
+    end
+
+    test 'test_update_valid' do
+      ForemanDatacenter::Rack.any_instance.stubs(:valid?).returns(true)
+      put :update, {:id => ForemanDatacenter::Rack.first.to_param, :rack => {:name => ForemanDatacenter::Rack.first.name}}, set_session_user
+      assert_redirected_to racks_url
+    end
+
+    test 'test_destroy' do
+      rack = ForemanDatacenter::Rack.first
+      delete :destroy, {:id => rack}, set_session_user
+      assert_redirected_to racks_url
+      assert !ForemanDatacenter::Rack.exists?(rack.id)
+    end
+
+    test '403 response contains missing permissions' do
+      setup_user
+      get :edit, { :id => ForemanDatacenter::Rack.first.id }, {:user => users(:one).id, :expires_at => 5.minutes.from_now}
+      assert_response :forbidden
+      assert_includes @response.body, 'edit_racks'
+    end
+
+    def setup_user
+      @request.session[:user] = users(:one).id
+      users(:one).roles       = [Role.default, Role.find_by_name('Viewer')]
+    end
+
+    test 'user_with_viewer_rights_should_fail_to_edit_a_rack' do
+      setup_user
+      get :edit, {:id => ForemanDatacenter::Rack.first.id}
+      assert_response :forbidden
+    end
+
+    test 'user_with_viewer_rights_should_succeed_in_viewing_racks' do
+      setup_user
+      get :index
+      assert_response :success
+    end
+
+    test 'user_with_viewer_rights_should_succeed_in_viewing_rack' do
+      setup_user
+      get :show
+      assert_response :success
+    end
+  end
+end

data/test/controllers/foreman_datacenter/sites_contoller_test.rb

@@ -0,0 +1,91 @@
+require 'test_helper'
+
+module ForemanDatacenter
+  class SitesControllerTest < ActionController::TestCase
+    setup do
+      @model = ForemanDatacenter::Site.first
+    end
+
+    basic_index_test
+    basic_new_test
+    basic_edit_test
+    basic_pagination_per_page_test
+    basic_pagination_rendered_test
+
+    test 'test_new_submit_button_id' do
+      get :new, {}, set_session_user
+      assert_select "[data-id='aid_create_foreman_datacenter_sites']"
+    end
+
+    test 'test_new_cancel_button_id' do
+      get :new, {}, set_session_user
+      assert_select "[data-id='aid_datacenter_sites']"
+    end
+
+    test 'test_create_invalid' do
+      ForemanDatacenter::Site.any_instance.stubs(:valid?).returns(false)
+      post :create, {:site => {:name => nil}}, set_session_user
+      assert_template 'new'
+    end
+
+    test 'test_create_valid' do
+      ForemanDatacenter::Site.any_instance.stubs(:valid?).returns(true)
+      post :create, {:site => {:name => 'test site'}}, set_session_user
+      assert_redirected_to sites_url
+    end
+
+    test 'test_edit_submit_button_id' do
+      get :edit, {:id => ForemanDatacenter::Site.first}, set_session_user
+      assert_select "[data-id='aid_update_foreman_datacenter_site']"
+    end
+
+    test 'test_update_invalid' do
+      ForemanDatacenter::Site.any_instance.stubs(:valid?).returns(false)
+      put :update, {:id => ForemanDatacenter::Site.first.to_param, :site => {:name => "3243", :asn => "string"}}, set_session_user
+      assert_template 'edit'
+    end
+
+    test 'test_update_valid' do
+      ForemanDatacenter::Site.any_instance.stubs(:valid?).returns(true)
+      put :update, {:id => ForemanDatacenter::Site.first.to_param, :site => {:name => ForemanDatacenter::Site.first.name}}, set_session_user
+      assert_redirected_to sites_url
+    end
+
+    test 'test_destroy' do
+      site = ForemanDatacenter::Site.first
+      delete :destroy, {:id => site}, set_session_user
+      assert_redirected_to sites_url
+      assert !ForemanDatacenter::Site.exists?(site.id)
+    end
+
+    test '403 response contains missing permissions' do
+      setup_user
+      get :edit, { :id => ForemanDatacenter::Site.first.id }, {:user => users(:one).id, :expires_at => 5.minutes.from_now}
+      assert_response :forbidden
+      assert_includes @response.body, 'edit_sites'
+    end
+
+    def setup_user
+      @request.session[:user] = users(:one).id
+      users(:one).roles       = [Role.default, Role.find_by_name('Viewer')]
+    end
+
+    test 'user_with_viewer_rights_should_fail_to_edit_a_site' do
+      setup_user
+      get :edit, {:id => ForemanDatacenter::Site.first.id}
+      assert_response :forbidden
+    end
+
+    test 'user_with_viewer_rights_should_succeed_in_viewing_sites' do
+      setup_user
+      get :index
+      assert_response :success
+    end
+
+    test 'user_with_viewer_rights_should_succeed_in_viewing_site' do
+      setup_user
+      get :show
+      assert_response :success
+    end
+  end
+end

data/test/fixtures/foreman_datacenter/rack_groups.yml

@@ -0,0 +1,11 @@
+# Read about fixtures at http://ar.rubyonrails.org/classes/Fixtures.html
+
+one:
+  id: 1
+  name: Room 1
+  site_id: 1
+
+one:
+  id: 1
+  name: Room 2
+  site_id: 2

data/test/fixtures/foreman_datacenter/racks.yml

@@ -0,0 +1,19 @@
+# Read about fixtures at http://ar.rubyonrails.org/classes/Fixtures.html
+
+one:
+  id: 1
+  site_id: 1
+  rack_group_id: 1
+  name: Rack 1
+  facility: test facility
+  height: 42
+  comments: test comment
+
+two:
+  id: 2
+  site_id: 2
+  rack_group_id: 2
+  name: Rack 2
+  facility: test facility
+  height: 42
+  comments: test comment