foreman_ansible 7.0.3 → 7.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7a8c4f263992d803c31386bc301ce1e032c680ada845db8bf07e71162c003384
-  data.tar.gz: 628c7b6952499ef5dfe912370bec8d3e936926a004acf5b7693d7706fe461ea9
+  metadata.gz: dc6d250a74d7e811600edfd0f78551286d8800644512d4346fd6d5794fe451f3
+  data.tar.gz: f7057a56a7e5fda90510ab9aa13b70b59efa90f07a8e7fb3460140102e36d390
 SHA512:
-  metadata.gz: '09f3fd7b961edcb7abee1f6dd6de4fbf0bb80130668c39724d6c8658c2ca1570109ab6b7d172d2f9b963c6e4e5aebaa3280ebf199f9fe5ff86580ab1d8f06c7e'
-  data.tar.gz: 924b85ee81562a848c07417fd0788520c000292901f63ef45f8adbfc99ec32dae21858589c83688f461d19e49a4c6491801d53f611032a1c291ba941e9068133
+  metadata.gz: 99dbfada521e9075ae164312cdf3eecb85e663beca47e558b5d3fd61cde68bb2a632e29f80ca9dcbf5519be3122a15b6c2777f4400b6bd685c84f2488a02baf4
+  data.tar.gz: b8a5fde3a9bb62aaf578b5d08ef24afe6bd9ddc2ac7af33b732a6c8eadfeb077dc92f0db86496975f44d3b9ad0c59acdb176f1722e964de5a4afb7a7c826182c

data/app/controllers/api/v2/ansible_playbooks_controller.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+module Api
+  module V2
+    # API controller for Ansible Roles
+    class AnsiblePlaybooksController < ::Api::V2::BaseController
+      include ::Api::Version2
+      include ::ForemanAnsible::ProxyAPI
+
+      before_action :find_proxy, only: [:fetch, :sync]
+
+      resource_description do
+        api_version 'v2'
+        api_base_url '/ansible/api'
+      end
+
+      api :PUT, '/ansible_playbooks/sync', N_('Sync Ansible playbooks')
+      param :proxy_id, :identifier, :required => true, :desc => N_('Smart Proxy to sync from')
+      param :playbooks_names, Array, N_('Ansible  playbooks names to be synced')
+      def sync
+        @task = plan_ansible_sync(@proxy.id, playbooks_names)
+      end
+
+      api :GET, '/ansible_playbooks/fetch', N_('Fetch Ansible playbooks available to be synced')
+      param :proxy_id, :identifier, N_('Smart Proxy to fetch from'),
+            :required => true
+      def fetch
+        fetched = fetch_playbooks_names
+        render :json => { :results => { :playbooks_names => fetched } }
+      end
+
+      def action_permission
+        case params[:action]
+        when 'sync', 'fetch'
+          :import
+        else
+          super
+        end
+      end
+
+      def plan_ansible_sync(proxy_id, playbooks_names)
+        ForemanTasks.async_task(ImportPlaybooksJob::Async::SyncPlaybooks, proxy_id, playbooks_names)
+      end
+
+      private
+
+      def find_proxy
+        unless params[:proxy_id]
+          msg = _('Smart proxy id is required')
+          render_error('custom_error', :status => :unprocessable_entity, :locals => { :message => msg })
+          return false
+        end
+        @proxy = SmartProxy.find(params[:proxy_id])
+      end
+
+      def fetch_playbooks_names
+        proxy_api = find_proxy_api(@proxy)
+        proxy_api.playbooks_names if @proxy
+      end
+
+      def playbooks_names
+        params.fetch(:playbooks_names, [])
+      end
+    end
+  end
+end

data/app/jobs/sync_playbooks.rb

@@ -0,0 +1,25 @@
+module ImportPlaybooksJob
+  module Async
+    class SyncPlaybooks < ::Actions::EntryAction
+      def plan(proxy_id, playbooks_names)
+        plan_self(proxy_id: proxy_id, playbooks_names: playbooks_names)
+      end
+
+      def run
+        playbooks_importer = ForemanAnsible::PlaybooksImporter.new(proxy)
+        output[:result] = playbooks_importer.import_playbooks(playbooks_names)
+        ForemanAnsible::ImportPlaybooksSuccessNotification.deliver!(task)
+      rescue StandardError => e
+        ForemanAnsible::ImportPlaybooksErrorNotification.new(e, task).deliver!
+      end
+
+      def proxy
+        SmartProxy.find(input[:proxy_id])
+      end
+
+      def playbooks_names
+        input[:playbooks_names]
+      end
+    end
+  end
+end

data/app/lib/proxy_api/ansible.rb

@@ -40,5 +40,18 @@ module ProxyAPI
       raise ProxyException.new(url, e,
                                N_('Unable to get roles/variables from Ansible'))
     end
+
+    def playbooks_names
+      parse(get('playbooks_names'))
+    rescue *PROXY_ERRORS => e
+      raise ProxyException.new(url, e, N_('Unable to get playbook\'s names from Ansible'))
+    end
+
+    def playbooks(playbooks_names = [])
+      playbooks_names = playbooks_names.join(',')
+      parse(get("playbooks/#{playbooks_names}"))
+    rescue *PROXY_ERRORS => e
+      raise ProxyException.new(url, e, N_('Unable to get playbooks from Ansible'))
+    end
   end
 end

data/app/services/foreman_ansible/import_playbooks_error_notification.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module ForemanAnsible
+  class ImportPlaybooksErrorNotification < ::UINotifications::Base
+    private
+
+    def initialize(error, task)
+      @job_error = error
+      @subject = task
+    end
+
+    def create
+      ::Notification.create!(
+        :audience => Notification::AUDIENCE_USER,
+        :notification_blueprint => blueprint,
+        :initiator => initiator,
+        :message => message,
+        :subject => subject,
+        :actions => {
+          :links => links
+        }
+      )
+    end
+
+    def blueprint
+      name = 'Sync_playbooks_failed'
+      @blueprint ||= NotificationBlueprint.unscoped.find_by(:name => name)
+    end
+
+    def message
+      _("Failed to import playbooks Due to: #{@job_error}")
+    end
+
+    def links
+      [{ :href => Rails.application.routes.url_helpers.foreman_tasks_task_path(:id => subject.id), :title => N_('Task Details') }]
+    end
+  end
+end

data/app/services/foreman_ansible/import_playbooks_success_notification.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module ForemanAnsible
+  class ImportPlaybooksSuccessNotification < ::UINotifications::Base
+    private
+
+    def create
+      ::Notification.create!(
+        :audience => Notification::AUDIENCE_USER,
+        :notification_blueprint => blueprint,
+        :initiator => initiator,
+        :message => message,
+        :subject => subject,
+        :actions => {
+          :links => links
+        }
+      )
+    end
+
+    def blueprint
+      name = 'Sync_playbooks_successfully'
+      @blueprint ||= NotificationBlueprint.unscoped.find_by(:name => name)
+    end
+
+    def message
+      blueprint.message
+    end
+
+    def links
+      [{ :href => Rails.application.routes.url_helpers.foreman_tasks_task_path(:id => subject.id), :title => N_('Task Details') }]
+    end
+  end
+end

data/app/services/foreman_ansible/playbooks_importer.rb

@@ -0,0 +1,73 @@
+# frozen_string_literal: true
+
+module ForemanAnsible
+  # Imports playbooks from smart proxy
+  class PlaybooksImporter
+    include ::ForemanAnsible::ProxyAPI
+    delegate :playbooks, :playbooks_names, :to => :proxy_api
+
+    def initialize(proxy = nil)
+      @ansible_proxy = proxy
+    end
+
+    def import_playbooks(playbooks_names)
+      playbooks = playbooks(playbooks_names)
+      result = { created: {}, updated: {} }
+      playbooks.each do |playbook|
+        parsed_playbook = parse_playbook playbook
+        job_template_id = JobTemplate.where(name: parsed_playbook[:name]).pick(:id)
+        if job_template_id.present?
+          updated = update_job_template(job_template_id, parsed_playbook)
+          result[:updated].merge!(updated) unless updated.nil?
+        else
+          result[:created].merge!(create_job_template(parsed_playbook))
+        end
+      end
+      result
+    end
+
+    def parse_playbook(playbook)
+      content = playbook['playbooks_content']
+      {
+        name: playbook['name'],
+        playbook_content: metadata(playbook['name']) + content,
+        vars: get_vars(content)
+      }
+    end
+
+    def metadata(playbook_name)
+      <<~END_HEREDOC
+        <%#
+          name: #{playbook_name}
+          snippet: false
+          job_category: Ansible Playbook - Imported
+          provider_type: Ansible
+          kind: job_template
+          model: JobTemplate
+        %>
+      END_HEREDOC
+    end
+
+    def get_vars(playbook_content)
+      YAML.safe_load(playbook_content).map { |play| play['vars'] }
+    end
+
+    def create_job_template(playbook)
+      job_template = JobTemplate.create(name: playbook[:name], template: playbook[:playbook_content], job_category: 'Ansible Playbook - Imported', provider_type: 'Ansible')
+      # TODO: Add support for creating template inputs
+      job_template.organizations = Organization.unscoped.all
+      job_template.locations = Location.unscoped.all
+      job_template.save
+      { job_template.id => job_template.name }
+    end
+
+    def update_job_template(job_template_id, playbook)
+      # TODO: Add support for updating template inputs
+      inputs = []
+      job_template = JobTemplate.find(job_template_id)
+      should_update = !playbook[:playbook_content].eql?(job_template.template)
+      job_template.template = playbook[:playbook_content] if should_update
+      { job_template.id => job_template.name } unless inputs.empty? && !should_update
+    end
+  end
+end

data/app/services/foreman_ansible/proxy_api.rb

@@ -8,16 +8,15 @@ module ForemanAnsible
     included do
       attr_reader :ansible_proxy
 
-      def find_proxy_api
+      def find_proxy_api(ansible_proxy)
         if ansible_proxy.blank?
           raise ::Foreman::Exception.new(N_('Proxy not found'))
         end
-        @proxy_api = ::ProxyAPI::Ansible.new(:url => ansible_proxy.url)
+        ::ProxyAPI::Ansible.new(:url => ansible_proxy.url)
       end
 
       def proxy_api
-        return @proxy_api if @proxy_api
-        find_proxy_api
+        @proxy_api ||= find_proxy_api(ansible_proxy)
       end
     end
   end

data/app/views/ansible_roles/index.html.erb

@@ -9,6 +9,7 @@
       <th class="col-md-6"><%= sort :name, :as => s_("Role|Name") %></th>
       <th class="col-md-2"><%= _("Hostgroups") %></th>
       <th class="col-md-2"><%= _("Hosts") %></th>
+      <th class="col-md-2"><%= _("Variables") %></th>
       <th class="col-md-2"><%= sort :updated_at, :as => _("Imported at") %></th>
       <th class="col-md-2"><%= _("Actions") %></th>
     </tr>
@@ -19,6 +20,7 @@
         <td class="ellipsis"><%= role.name %></td>
         <td class="ellipsis"><%= role.hostgroups.count %></td>
         <td class="ellipsis"><%= link_to role.hosts.count, hosts_path(:search => "ansible_role = #{role.name}")%></td>
+        <td class="ellipsis"><%= link_to(role.ansible_variables.count, ansible_variables_path(:search => "ansible_role = #{role}")) %></td>
         <td class="ellipsis"><%= import_time role %></td>
         <td>
           <%

data/app/views/api/v2/ansible_playbooks/sync.json.rabl

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+object @task
+
+attributes :id, :action, :state, :result, :start_at

data/app/views/foreman_ansible/job_templates/ansible_windows_updates.erb

@@ -0,0 +1,160 @@
+<%#
+name: Manage Windows Updates - Ansible Default
+snippet: false
+template_inputs:
+- name: reject_list
+  required: false
+  input_type: user
+  description: "A list of update titles or KB numbers that can be used to specify
+    which updates are to be excluded from installation.\r\nIf an available update
+    does match one of the entries, then it is skipped and not installed.\r\nEach entry
+    can either be the KB article or Update title as a regex according to the PowerShell
+    regex rules."
+  advanced: false
+- name: category_names
+  required: false
+  input_type: user
+  description: "A scalar or list of categories to install updates from. To get the
+    list of categories, run the module with state=searched. The category must be the
+    full category string, but is case insensitive.\r\nSome possible categories are
+    Application, Connectors, Critical Updates, Definition Updates, Developer Kits,
+    Feature Packs, Guidance, Security Updates, Service Packs, Tools, Update Rollups
+    and Updates.\r\n\r\nDefault is '[\"CriticalUpdates\", \"SecurityUpdates\", \"UpdateRollups\"]'"
+  advanced: false
+- name: log_path
+  required: false
+  input_type: user
+  description: If set, win_updates will append update progress to the specified file.
+    The directory must already exist.
+  advanced: false
+- name: reboot
+  required: false
+  input_type: user
+  description: "Ansible will automatically reboot the remote host if it is required
+    and continue to install updates after the reboot.\r\nThis can be used instead
+    of using a win_reboot task after this one and ensures all updates for that category
+    is installed in one go.\r\nAsync does not work when reboot=true.\r\n\r\nDefault
+    is 'false'"
+  options: "false\r\ntrue"
+  advanced: false
+- name: reboot_timeout
+  required: false
+  input_type: user
+  description: "The time in seconds to wait until the host is back online from a reboot.\r\nThis
+    is only used if reboot=true and a reboot is required.\r\n\r\nDefault is '1200'"
+  advanced: false
+- name: server_selection
+  required: false
+  input_type: user
+  description: "Defines the Windows Update source catalog.\r\ndefault Use the default
+    search source. For many systems default is set to the Microsoft Windows Update
+    catalog. Systems participating in Windows Server Update Services (WSUS), Systems
+    Center Configuration Manager (SCCM), or similar corporate update server environments
+    may default to those managed update sources instead of the Windows Update catalog.\r\nmanaged_server
+    Use a managed server catalog. For environments utilizing Windows Server Update
+    Services (WSUS), Systems Center Configuration Manager (SCCM), or similar corporate
+    update servers, this option selects the defined corporate update source.\r\nwindows_update
+    Use the Microsoft Windows Update catalog.\r\n\r\nDefault is 'default'"
+  options: "default\r\nmanaged_server\r\nwindows_update"
+  advanced: false
+- name: state
+  required: false
+  input_type: user
+  description: "Controls whether found updates are downloaded or installed or listed\r\nThis
+    module also supports Ansible check mode, which has the same effect as setting
+    state=searched\r\n\r\nDefault is 'searched'"
+  options: "installed\r\nsearched\r\ndownloaded"
+  advanced: false
+- name: use_scheduled_task
+  required: false
+  input_type: user
+  description: "Will not auto elevate the remote process with become and use a scheduled
+    task instead.\r\nSet this to true when using this module with async on Server
+    2008, 2008 R2, or Windows 7, or on Server 2008 that is not authenticated with
+    basic or credssp.\r\nCan also be set to true on newer hosts where become does
+    not work due to further privilege restrictions from the OS defaults."
+  options: "false\r\ntrue"
+  advanced: false
+- name: whitelist
+  required: false
+  input_type: user
+  description: "A list of update titles or KB numbers that can be used to specify
+    which updates are to be searched or installed.\r\nIf an available update does
+    not match one of the entries, then it is skipped and not installed.\r\nEach entry
+    can either be the KB article or Update title as a regex according to the PowerShell
+    regex rules.\r\nThe whitelist is only validated on updates that were found based
+    on category_names. It will not force the module to install an update if it was
+    not in the category specified."
+  advanced: false
+model: JobTemplate
+job_category: Ansible Playbook
+provider_type: Ansible
+kind: job_template
+organizations:
+- My_Organization
+locations:
+- My_Location
+%>
+
+- hosts: all
+  vars:
+    updates: []
+    <% if input('state').blank? %>
+    state: searched
+    <% else %>
+    state: <%= input('state') %>
+    <% end %>
+
+  tasks:
+    - name: "{{ state | replace('ed','') | capitalize }} Windows Updates"
+      win_updates:
+        <% unless input('reject_list').blank? %>
+        blacklist: <%= input('reject_list') %>
+        <% end -%>
+        <% if input('category_names').blank? %>
+        category_names: ["CriticalUpdates", "SecurityUpdates", "UpdateRollups"]
+        <% else %>
+        category_names: <%= input('category_names') %>
+        <% end %>
+        <% unless input('log_path').blank? %>
+        log_path: <%= input('log_path') %>
+        <% end -%>
+        <% if input('reboot').blank? %>
+        reboot: false
+        <% else %>
+        reboot: <%= input('reboot') %>
+        <% end %>
+        <% if input('reboot_timeout').blank? %>
+        reboot_timeout: 1200
+        <% else %>
+        reboot_timeout: <%= input('reboot_timeout') %>
+        <% end -%>
+        <% if input('server_selection').blank? %>
+        server_selection: default
+        <% else %>
+        server_selection: <%= input('server_selection') %>
+        <% end %>
+        state: "{{ state }}"
+        <% if input('use_scheduled_task').blank? %>
+        use_scheduled_task: false
+        <% else %>
+        use_scheduled_task: <%= input('use_scheduled_task') %>
+        <% end %>
+        <% if !input('whitelist').blank? %>
+        whitelist: <%= input('whitelist') %>
+        <% end -%>
+
+      register: found_updates
+      
+    - name: "Get all {{ state }} updates"
+      set_fact:
+        updates: "{{ updates + [ current_update ] }}"
+      vars:
+        current_update: "{{ item.value.title  }}"
+      loop: "{{ found_updates.updates | dict2items }}"
+      no_log: true
+
+    - name: "List {{ state }} Windows Updates"
+      debug: 
+        msg: "{{ item }}"
+      loop: "{{ updates }}"

data/config/routes.rb

@@ -85,6 +85,13 @@ Rails.application.routes.draw do
           end
         end
 
+        resources :ansible_playbooks, :only => [] do
+          collection do
+            get :fetch
+            put :sync
+          end
+        end
+
         resources :ansible_variables, :only => [:show, :index, :destroy, :update, :create] do
           collection do
             put :import

data/db/seeds.d/90_notification_blueprints.rb

@@ -31,7 +31,21 @@ blueprints = [
     :name => 'Sync_roles_and_variables_failed',
     :message => 'DYNAMIC',
     :level => 'error'
+  },
+  {
+    :group => N_('Playbooks'),
+    :name => 'Sync_playbooks_successfully',
+    :message => N_('Import playbooks has finished successfully'),
+    :level => 'success'
+
+  },
+  {
+    :group => N_('Playbooks'),
+    :name => 'Sync_playbooks_failed',
+    :message => 'DYNAMIC',
+    :level => 'error'
   }
 
 ]
+
 blueprints.each { |blueprint| UINotifications::Seed.new(blueprint).configure }

data/lib/foreman_ansible/register.rb

@@ -158,6 +158,8 @@ Foreman::Plugin.register :foreman_ansible do
                :resource_type => 'Hostgroup'
     permission :generate_ansible_inventory,
                { :'api/v2/ansible_inventories' => [:schedule] }
+    permission :import_ansible_playbooks,
+               { :'api/v2/ansible_playbooks' => [:sync, :fetch] }
   end
 
   role 'Ansible Roles Manager',
@@ -167,7 +169,7 @@ Foreman::Plugin.register :foreman_ansible do
         :view_ansible_roles, :destroy_ansible_roles,
         :import_ansible_roles, :view_ansible_variables,
         :create_ansible_variables, :import_ansible_variables,
-        :edit_ansible_variables, :destroy_ansible_variables]
+        :edit_ansible_variables, :destroy_ansible_variables, :import_ansible_playbooks]
 
   role 'Ansible Tower Inventory Reader',
        [:view_hosts, :view_hostgroups, :view_facts, :generate_report_templates, :generate_ansible_inventory,

data/lib/foreman_ansible/version.rb

@@ -4,5 +4,5 @@
 # This way other parts of Foreman can just call ForemanAnsible::VERSION
 # and detect what version the plugin is running.
 module ForemanAnsible
-  VERSION = '7.0.3'
+  VERSION = '7.1.0'
 end

data/test/fixtures/playbooks_example_output.json

@@ -0,0 +1 @@
+{ "template": "<%#\n  name: xprazak2.forklift_collection.foreman_provisioning.yml\n  snippet: false\n  job_category: Ansible Playbook - Imported\n  provider_type: Ansible\n  kind: job_template\n  model: JobTemplate\n%>\n- hosts: all\n  become: true\n  vars:\n    libvirt_tftp: true\n  roles:\n    - foreman\n    - libvirt\n    - foreman_provisioning\n"}

data/test/fixtures/sample_playbooks.json

@@ -0,0 +1,10 @@
+[
+  {
+    "name": "xprazak2.forklift_collection.foreman_provisioning.yml",
+    "playbooks_content": "- hosts: all\n  become: true\n  vars:\n    libvirt_tftp: true\n  roles:\n    - foreman\n    - libvirt\n    - foreman_provisioning\n"
+  },
+  {
+    "name": "xprazak2.forklift_collection.collect_debug_draft.yml",
+    "playbooks_content": "---\n- hosts: all\n  become: true\n  vars:\n    bats_output_dir: '/root/bats_results'\n    remote_dir: \"/tmp/debug-{{ pipeline_type | default('foreman') }}-{{ pipeline_version | default('nightly') }}-{{ pipeline_os | default('el7') }}\"\n  roles:\n    - sos_report\n  tasks:\n    - name: \"Find bats files\"\n      find:\n        paths: \"{{ bats_output_dir }}\"\n        patterns: \"*.tap\"\n      register: bats_results\n\n    - name: \"Copy bats results\"\n      fetch:\n        src: \"{{ item.path }}\"\n        dest: \"{{ remote_dir }}\"\n      with_items: \"{{ bats_results.files }}\"\n\n    - name: \"Find smoker files\"\n      find:\n        paths: \"{{ smoker_output_dir }}\"\n        patterns: \"*.xml\"\n      register: smoker_results\n\n    - name: \"Copy smoker results\"\n      fetch:\n        src: \"{{ item.path }}\"\n        dest: \"{{ remote_dir }}\"\n      with_items: \"{{ smoker_results.files }}\"\n"
+  }
+]

data/test/functional/api/v2/ansible_playbooks_controller_test.rb

@@ -0,0 +1,65 @@
+# frozen_string_literal: true
+
+require 'test_plugin_helper'
+
+module Api
+  module V2
+    # Tests for the ansible playbooks controller
+    class AnsiblePlaybooksControllerTest < ActionController::TestCase
+      let(:ansible_proxy) { FactoryBot.create(:smart_proxy, :with_ansible) }
+      let(:proxy_api) { ::ProxyAPI::Ansible.new(url: ansible_proxy.url) }
+      let(:playbooks_names) { %w[xprazak2.forklift_collection.foreman_provisioning.yml xprazak2.forklift_collection.collect_debug_draft.yml] }
+      let(:importer_test) { mock('PlaybooksImporter') }
+
+      test 'should fetch with nil' do
+        AnsiblePlaybooksController.any_instance.stubs(:fetch_playbooks_names).returns(nil)
+
+        get :fetch, :params => {
+          :proxy_id => ansible_proxy.id
+        }, :session => set_session_user
+        response = JSON.parse(@response.body)
+        assert_empty response['results']['playbooks_names']
+        assert_response :success
+      end
+
+      test 'should fetch playbooks names' do
+        AnsiblePlaybooksController.any_instance.stubs(:fetch_playbooks_names).returns(playbooks_names)
+
+        get :fetch, :params => {
+          :proxy_id => ansible_proxy.id
+        }, :session => set_session_user
+        response = JSON.parse(@response.body)
+        assert_not_empty response['results']
+        assert_equal response['results']['playbooks_names'], playbooks_names
+      end
+
+      test 'should use correct proxy' do
+        AnsiblePlaybooksController.any_instance.expects(:find_proxy_api).with(ansible_proxy).returns(proxy_api)
+        proxy_api.expects(:playbooks_names).returns(playbooks_names)
+
+        get :fetch, :params => {
+          :proxy_id => ansible_proxy.id
+        }, :session => set_session_user
+        response = JSON.parse(@response.body)
+        assert_not_empty response['results']
+        assert_not_empty playbooks_names = response['results']['playbooks_names']
+        assert_equal 2, playbooks_names.count
+      end
+
+      test 'check plan and sync' do
+        task = mock('Foreman Task')
+        AnsiblePlaybooksController.any_instance.expects(:plan_ansible_sync).with(ansible_proxy.id, playbooks_names).returns(task)
+        task.stubs(:id).returns('123')
+        task.stubs(:action).returns('Import Playbooks')
+
+        put :sync, :params => {
+          :proxy_id => ansible_proxy.id,
+          :playbooks_names => playbooks_names
+        }, :session => set_session_user
+        response = JSON.parse(@response.body)
+        assert_equal '123', response['id']
+        assert_equal 'Import Playbooks', response['action']
+      end
+    end
+  end
+end

data/test/functional/hosts_controller_test.rb

@@ -20,7 +20,7 @@ class HostsControllerExtensionsTest < ActionController::TestCase
                  0 => { :ansible_role_id => @role.id, :position => 0 }
                } }
       post :create, :params => { :host => host }, :session => set_session_user
-      assert_redirected_to host_url(assigns('host'))
+      assert_redirected_to host_details_page_url(assigns('host'))
       assert assigns('host').ansible_roles, [@role]
     end
 
@@ -34,7 +34,7 @@ class HostsControllerExtensionsTest < ActionController::TestCase
              } }
            },
            :session => set_session_user
-      assert_redirected_to host_url(assigns('host'))
+      assert_redirected_to host_details_page_url(assigns('host'))
       assert_equal assigns('host').ansible_roles, [@role]
     end