foreman_ansible 6.0.2 → 6.4.0

data/webpack/components/AnsibleRolesSwitcher/components/__snapshots__/AvailableRolesList.test.js.snap

@@ -8,9 +8,14 @@ exports[`AvailableRolesList should render 1`] = `
     className="sticky-pagination"
   >
     <PaginationWrapper
+      className=""
+      disableNext={false}
+      disablePrev={false}
       dropdownButtonId="available-ansible-roles-pagination-row-dropdown"
       itemCount={2}
       onChange={[Function]}
+      onPageSet={[Function]}
+      onPerPageSelect={[Function]}
       pagination={
         Object {
           "page": 1,

data/webpack/components/AnsibleRolesSwitcher/index.js

@@ -7,15 +7,13 @@ import AnsiblePermissionDenied from './components/AnsiblePermissionDenied';
 import withProtectedView from './components/withProtectedView';
 import {
   selectUnassignedRoles,
-  selectAssignedRolesPage,
   selectAssignedRoles,
-  selectAssignedRolesCount,
   selectResults,
   selectPaginationMemoized,
   selectItemCount,
   selectLoading,
-  selectAssignedPagination,
   selectError,
+  selectToDestroyRoles,
 } from './AnsibleRolesSwitcherSelectors';
 
 const mapStateToProps = state => ({
@@ -24,11 +22,9 @@ const mapStateToProps = state => ({
   itemCount: selectItemCount(state),
   loading: selectLoading(state),
   error: selectError(state),
-  assignedPagination: selectAssignedPagination(state),
-  assignedRolesCount: selectAssignedRolesCount(state),
-  assignedRoles: selectAssignedRolesPage(state),
-  allAssignedRoles: selectAssignedRoles(state),
+  assignedRoles: selectAssignedRoles(state),
   unassignedRoles: selectUnassignedRoles(state),
+  toDestroyRoles: selectToDestroyRoles(state),
 });
 
 const mapDispatchToProps = dispatch =>
@@ -37,5 +33,5 @@ const mapDispatchToProps = dispatch =>
 export default withProtectedView(
   connect(mapStateToProps, mapDispatchToProps)(AnsibleRolesSwitcher),
   AnsiblePermissionDenied,
-  props => props.data && props.data.canView
+  props => props.canView
 );

data/webpack/global_index.js

@@ -0,0 +1,12 @@
+import React from 'react';
+
+import { addGlobalFill } from 'foremanReact/components/common/Fill/GlobalFill';
+
+import AnsibleHostDetail from './components/AnsibleHostDetail';
+
+addGlobalFill(
+  'host-details-page-tabs',
+  'Ansible',
+  <AnsibleHostDetail key="ansible-host-detail" />,
+  500
+);

data/webpack/index.js

@@ -1,12 +1,10 @@
-import $ from 'jquery';
 import componentRegistry from 'foremanReact/components/componentRegistry';
 import injectReducer from 'foremanReact/redux/reducers/registerReducer';
 import ReportJsonViewer from './components/ReportJsonViewer';
 import AnsibleRolesSwitcher from './components/AnsibleRolesSwitcher';
+import WrappedImportRolesAndVariables from './components/AnsibleRolesAndVariables';
 import reducer from './reducer';
 
-const { tfm } = window;
-
 componentRegistry.register({
   name: 'ReportJsonViewer',
   type: ReportJsonViewer,
@@ -16,14 +14,9 @@ componentRegistry.register({
   type: AnsibleRolesSwitcher,
 });
 
-injectReducer('foremanAnsible', reducer);
+componentRegistry.register({
+  name: 'WrappedImportRolesAndVariables',
+  type: WrappedImportRolesAndVariables,
+});
 
-tfm.initAnsibleRoleSwitcher = () => {
-  $(document).on('ContentLoad', evt => {
-    tfm.reactMounter.mount(
-      'AnsibleRolesSwitcher',
-      '#ansible_roles_switcher',
-      $('#ansible_roles_switcher').data('roles')
-    );
-  });
-};
+injectReducer('foremanAnsible', reducer);

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: foreman_ansible
 version: !ruby/object:Gem::Version
-  version: 6.0.2
+  version: 6.4.0
 platform: ruby
 authors:
 - Daniel Lobato Garcia
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-22 00:00:00.000000000 Z
+date: 2021-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: foreman_ansible_core
+  name: acts_as_list
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :development
+        version: 1.0.3
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: 1.0.3
 - !ruby/object:Gem::Dependency
   name: deface
   requirement: !ruby/object:Gem::Requirement
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 4.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 4.4.0
 - !ruby/object:Gem::Dependency
   name: ipaddress
   requirement: !ruby/object:Gem::Requirement
@@ -104,8 +104,10 @@ files:
 - app/controllers/ui_ansible_roles_controller.rb
 - app/helpers/foreman_ansible/ansible_plugin_helper.rb
 - app/helpers/foreman_ansible/ansible_reports_helper.rb
+- app/helpers/foreman_ansible/ansible_roles_data_preparations.rb
 - app/helpers/foreman_ansible/ansible_roles_helper.rb
 - app/helpers/foreman_ansible/hosts_helper_extensions.rb
+- app/jobs/sync_roles_and_variables.rb
 - app/lib/actions/foreman_ansible/helpers/play_roles_description.rb
 - app/lib/proxy_api/ansible.rb
 - app/models/ansible_role.rb
@@ -128,6 +130,8 @@ files:
 - app/services/foreman_ansible/fact_importer.rb
 - app/services/foreman_ansible/fact_parser.rb
 - app/services/foreman_ansible/fact_sparser.rb
+- app/services/foreman_ansible/import_roles_and_variables_error_notification.rb
+- app/services/foreman_ansible/import_roles_and_variables_success_notification.rb
 - app/services/foreman_ansible/insights_notification_builder.rb
 - app/services/foreman_ansible/insights_plan_runner.rb
 - app/services/foreman_ansible/inventory_creator.rb
@@ -144,7 +148,6 @@ files:
 - app/views/ansible_roles/welcome.html.erb
 - app/views/ansible_variables/_fields.erb
 - app/views/ansible_variables/edit.html.erb
-- app/views/ansible_variables/import.html.erb
 - app/views/ansible_variables/index.html.erb
 - app/views/ansible_variables/new.html.erb
 - app/views/api/v2/ansible_override_values/show.json.rabl
@@ -152,6 +155,7 @@ files:
 - app/views/api/v2/ansible_roles/index.json.rabl
 - app/views/api/v2/ansible_roles/obsolete.json.rabl
 - app/views/api/v2/ansible_roles/show.json.rabl
+- app/views/api/v2/ansible_roles/sync.json.rabl
 - app/views/api/v2/ansible_variables/create.json.rabl
 - app/views/api/v2/ansible_variables/destroy.json.rabl
 - app/views/api/v2/ansible_variables/import.json.rabl
@@ -169,11 +173,13 @@ files:
 - app/views/foreman_ansible/api/v2/ansible_roles/show.json.rabl
 - app/views/foreman_ansible/config_reports/_ansible.html.erb
 - app/views/foreman_ansible/config_reports/_output.html.erb
+- app/views/foreman_ansible/job_templates/ansible_collections_-_install_from_galaxy.erb
 - app/views/foreman_ansible/job_templates/ansible_roles_-_ansible_default.erb
 - app/views/foreman_ansible/job_templates/ansible_roles_-_install_from_galaxy.erb
 - app/views/foreman_ansible/job_templates/ansible_roles_-_install_from_git.erb
 - app/views/foreman_ansible/job_templates/capsule_upgrade_-_ansible_default.erb
 - app/views/foreman_ansible/job_templates/configure_cloud_connector_-_ansible_default.erb
+- app/views/foreman_ansible/job_templates/convert_to_rhel.erb
 - app/views/foreman_ansible/job_templates/maintenance_plan.erb
 - app/views/foreman_ansible/job_templates/module_action_-_ansible_default.erb
 - app/views/foreman_ansible/job_templates/package_action_-_ansible_default.erb
@@ -200,6 +206,8 @@ files:
 - db/migrate/20190328114657_remove_top_level_ansible_variables_setting.rb
 - db/migrate/20191010074208_remove_ansible_implementation_setting.rb
 - db/migrate/20200421201839_update_ansible_inv_template_name.rb
+- db/migrate/20210120150019_add_position_to_ansible_role.rb
+- db/seeds.d/100_common_parameters.rb
 - db/seeds.d/62_ansible_proxy_feature.rb
 - db/seeds.d/75_job_templates.rb
 - db/seeds.d/90_notification_blueprints.rb
@@ -252,9 +260,11 @@ files:
 - test/factories/ansible_proxy.rb
 - test/factories/ansible_roles.rb
 - test/factories/ansible_variables.rb
+- test/factories/host_ansible_enhancements.rb
 - test/fixtures/insights_playbook.yaml
 - test/fixtures/report.json
 - test/fixtures/sample_facts.json
+- test/foreman_ansible/helpers/ansible_roles_helper_test.rb
 - test/functional/ansible_roles_controller_test.rb
 - test/functional/ansible_variables_controller_test.rb
 - test/functional/api/v2/ansible_inventories_controller_test.rb
@@ -276,9 +286,8 @@ files:
 - test/unit/helpers/ansible_reports_helper_test.rb
 - test/unit/host_ansible_role_test.rb
 - test/unit/hostgroup_ansible_role_test.rb
-- test/unit/lib/foreman_ansible_core/ansible_runner_test.rb
-- test/unit/lib/foreman_ansible_core/command_creator_test.rb
-- test/unit/lib/foreman_ansible_core/playbook_runner_test.rb
+- test/unit/ignore_roles_test.rb
+- test/unit/import_roles_and_variables.rb
 - test/unit/lib/proxy_api/ansible_test.rb
 - test/unit/services/ansible_report_importer_test.rb
 - test/unit/services/ansible_variables_importer_test.rb
@@ -291,9 +300,19 @@ files:
 - test/unit/services/roles_importer_test.rb
 - test/unit/services/structured_fact_importer_test.rb
 - test/unit/services/ui_roles_importer_test.rb
-- webpack/__mocks__/foremanReact/common/I18n.js
-- webpack/__mocks__/foremanReact/components/Pagination/PaginationWrapper.js
-- webpack/__mocks__/foremanReact/components/common/EmptyState.js
+- webpack/components/AnsibleHostDetail/AnsibleHostDetail.js
+- webpack/components/AnsibleHostDetail/AnsibleHostDetail.scss
+- webpack/components/AnsibleHostDetail/AnsibleHostDetail.test.js
+- webpack/components/AnsibleHostDetail/index.js
+- webpack/components/AnsibleRolesAndVariables/AnsibleRolesAndVariables.js
+- webpack/components/AnsibleRolesAndVariables/AnsibleRolesAndVariables.scss
+- webpack/components/AnsibleRolesAndVariables/AnsibleRolesAndVariablesActions.js
+- webpack/components/AnsibleRolesAndVariables/AnsibleRolesAndVariablesConstants.js
+- webpack/components/AnsibleRolesAndVariables/AnsibleRolesAndVariablesHelpers.js
+- webpack/components/AnsibleRolesAndVariables/__test__/AnsibleRolesAndVariablesHelpers.test.js
+- webpack/components/AnsibleRolesAndVariables/__test__/AnsibleRolesAndVariablesImport.test.js
+- webpack/components/AnsibleRolesAndVariables/__test__/__snapshots__/AnsibleRolesAndVariablesImport.test.js.snap
+- webpack/components/AnsibleRolesAndVariables/index.js
 - webpack/components/AnsibleRolesSwitcher/AnsibleRolesSwitcher.js
 - webpack/components/AnsibleRolesSwitcher/AnsibleRolesSwitcher.scss
 - webpack/components/AnsibleRolesSwitcher/AnsibleRolesSwitcherActions.js
@@ -314,21 +333,25 @@ files:
 - webpack/components/AnsibleRolesSwitcher/components/AnsibleRole.js
 - webpack/components/AnsibleRolesSwitcher/components/AnsibleRole.test.js
 - webpack/components/AnsibleRolesSwitcher/components/AnsibleRoleActionButton.js
+- webpack/components/AnsibleRolesSwitcher/components/AnsibleRoleInputs.js
+- webpack/components/AnsibleRolesSwitcher/components/AnsibleRoleInputs.test.js
 - webpack/components/AnsibleRolesSwitcher/components/AnsibleRolesSwitcherError.js
 - webpack/components/AnsibleRolesSwitcher/components/AssignedRolesList.js
 - webpack/components/AnsibleRolesSwitcher/components/AssignedRolesList.test.js
 - webpack/components/AnsibleRolesSwitcher/components/AvailableRolesList.js
 - webpack/components/AnsibleRolesSwitcher/components/AvailableRolesList.test.js
+- webpack/components/AnsibleRolesSwitcher/components/OrderedRolesTooltip.js
 - webpack/components/AnsibleRolesSwitcher/components/__snapshots__/AnsiblePermissionDenied.test.js.snap
 - webpack/components/AnsibleRolesSwitcher/components/__snapshots__/AnsibleRole.test.js.snap
+- webpack/components/AnsibleRolesSwitcher/components/__snapshots__/AnsibleRoleInputs.test.js.snap
 - webpack/components/AnsibleRolesSwitcher/components/__snapshots__/AssignedRolesList.test.js.snap
 - webpack/components/AnsibleRolesSwitcher/components/__snapshots__/AvailableRolesList.test.js.snap
 - webpack/components/AnsibleRolesSwitcher/components/withProtectedView.js
 - webpack/components/AnsibleRolesSwitcher/index.js
 - webpack/components/ReportJsonViewer.js
+- webpack/global_index.js
 - webpack/index.js
 - webpack/reducer.js
-- webpack/test_setup.js
 homepage: https://github.com/theforeman/foreman_ansible
 licenses:
 - GPL-3.0
@@ -354,20 +377,21 @@ specification_version: 4
 summary: Ansible integration with Foreman (theforeman.org)
 test_files:
 - test/factories/ansible_proxy.rb
-- test/factories/ansible_roles.rb
 - test/factories/ansible_variables.rb
+- test/factories/ansible_roles.rb
+- test/factories/host_ansible_enhancements.rb
 - test/fixtures/insights_playbook.yaml
-- test/fixtures/report.json
 - test/fixtures/sample_facts.json
+- test/fixtures/report.json
 - test/functional/ansible_roles_controller_test.rb
-- test/functional/ansible_variables_controller_test.rb
 - test/functional/api/v2/ansible_inventories_controller_test.rb
-- test/functional/api/v2/ansible_roles_controller_test.rb
 - test/functional/api/v2/ansible_variables_controller_test.rb
 - test/functional/api/v2/hostgroups_controller_test.rb
 - test/functional/api/v2/hosts_controller_test.rb
-- test/functional/hosts_controller_test.rb
+- test/functional/api/v2/ansible_roles_controller_test.rb
 - test/functional/ui_ansible_roles_controller_test.rb
+- test/functional/ansible_variables_controller_test.rb
+- test/functional/hosts_controller_test.rb
 - test/test_plugin_helper.rb
 - test/unit/actions/run_ansible_job_test.rb
 - test/unit/actions/run_proxy_ansible_command_test.rb
@@ -377,21 +401,21 @@ test_files:
 - test/unit/concerns/host_managed_extensions_test.rb
 - test/unit/concerns/hostgroup_extensions_test.rb
 - test/unit/helpers/ansible_reports_helper_test.rb
-- test/unit/host_ansible_role_test.rb
-- test/unit/hostgroup_ansible_role_test.rb
-- test/unit/lib/foreman_ansible_core/command_creator_test.rb
-- test/unit/lib/foreman_ansible_core/ansible_runner_test.rb
-- test/unit/lib/foreman_ansible_core/playbook_runner_test.rb
 - test/unit/lib/proxy_api/ansible_test.rb
 - test/unit/services/ansible_report_importer_test.rb
-- test/unit/services/ansible_variables_importer_test.rb
-- test/unit/services/api_roles_importer_test.rb
-- test/unit/services/fact_importer_test.rb
-- test/unit/services/fact_parser_test.rb
 - test/unit/services/fact_sparser_test.rb
 - test/unit/services/insights_plan_runner_test.rb
 - test/unit/services/roles_importer_test.rb
 - test/unit/services/structured_fact_importer_test.rb
+- test/unit/services/fact_importer_test.rb
+- test/unit/services/ansible_variables_importer_test.rb
 - test/unit/services/ui_roles_importer_test.rb
+- test/unit/services/api_roles_importer_test.rb
+- test/unit/services/fact_parser_test.rb
 - test/unit/services/inventory_creator_test.rb
 - test/unit/ansible_provider_test.rb
+- test/unit/host_ansible_role_test.rb
+- test/unit/hostgroup_ansible_role_test.rb
+- test/unit/import_roles_and_variables.rb
+- test/unit/ignore_roles_test.rb
+- test/foreman_ansible/helpers/ansible_roles_helper_test.rb

data/app/views/ansible_variables/import.html.erb

@@ -1,56 +0,0 @@
-<% title _("Changed Ansible variables") %>
-<%= form_tag confirm_import_ansible_variables_path do %>
-  <h4><%= _("Select the changes you want to realize in Foreman") %></h4>
-  <h6>
-  <%= _("Toggle") %>:
-  <%= link_to_function(icon_text("check", _("New")),
-                       "toggleCheckboxesBySelector('.variable_select_boxes_new')",
-                       :title => _("Check/Uncheck new")) %> |
-  <%= link_to_function(icon_text("check", _("Obsolete")),
-                       "toggleCheckboxesBySelector('.variable_select_boxes_obsolete')",
-                       :title => _("Check/Uncheck obsolete")) %>
-  <%= link_to_function(icon_text("check", _("Update")),
-                       "toggleCheckboxesBySelector('.variable_select_boxes_update')",
-                       :title => _("Check/Uncheck update")) %>
-  </h6>
-  <table class="<%= table_css_classes %>">
-    <thead>
-      <tr>
-        <th class="ca">
-          <%= link_to_function(icon_text("check"),
-                               "toggleCheckboxesBySelector('.variable_select_boxes')",
-                               :title => _("Check/Uncheck all")) %>
-        </th>
-        <th><%= _("Name") %></th>
-        <th><%= _("Ansible role") %></th>
-        <th class="col-md-2"><%= _("Hosts count") %></th>
-        <th class="col-md-2"><%= _("Hostgroups count") %></th>
-        <th><%= _("Operation") %></th>
-      </tr>
-    </thead>
-    <tbody>
-      <% changed.each do |kind, variables| %>
-        <% variables.each do |variable| %>
-          <tr>
-            <td>
-              <%= check_box_tag "changed[#{kind}][#{variable.ansible_role}][#{variable}]", variable.to_json, false, :class => "variable_select_boxes variable_select_boxes_#{kind} variable_select_boxes_variable_#{variable}" %>
-            </td>
-            <td>
-              <%= link_to_function("#{variable}", "toggleCheckboxesBySelector('.variable_select_boxes_variable_#{variable}')", :title => _("Check/Uncheck all %s changes") % variable) %>
-            </td>
-            <td><%= variable.ansible_role %></td>
-            <td><%= variable.ansible_role.hosts.count %></td>
-            <td><%= variable.ansible_role.hostgroups.count %></td>
-            <td>
-              <%= { "new" => _("Add"), "obsolete" => _("Remove"), "update" => _("Update") }[kind] %>
-            </td>
-          </tr>
-        <% end %>
-      <% end %>
-    </tbody>
-  </table>
-  <div>
-    <%= link_to _("Cancel"), ansible_variables_path, :class => "btn btn-default" %>
-    <%= submit_tag _("Update"), :class => "btn btn-primary" %>
-  </div>
-<% end %>

data/test/unit/lib/foreman_ansible_core/ansible_runner_test.rb

@@ -1,51 +0,0 @@
-# frozen_string_literal: true
-
-require 'test_helper'
-
-module ForemanAnsibleCore
-  module Runner
-    class AnsibleRunnerTest < ActiveSupport::TestCase
-      describe AnsibleRunner do
-        it 'parses files without event data' do
-          content = <<~JSON
-            {"uuid": "a29d8592-f805-4d0e-b73d-7a53cc35a92e", "stdout": " [WARNING]: Consider using the yum module rather than running 'yum'.  If you", "counter": 8, "end_line": 8, "runner_ident": "e2d9ae11-026a-4f9f-9679-401e4b852ab0", "start_line": 7, "event": "verbose"}
-          JSON
-
-          File.expects(:read).with('fake.json').returns(content)
-          runner = AnsibleRunner.allocate
-          runner.expects(:handle_broadcast_data)
-          assert runner.send(:handle_event_file, 'fake.json')
-        end
-      end
-
-      describe '#rebuild_secrets' do
-        let(:inventory) do
-          { 'all' => { 'hosts' => ['foreman.example.com'] },
-            '_meta' => { 'hostvars' => { 'foreman.example.com' => {} } } }
-        end
-        let(:input) do
-          host_secrets = { 'ansible_password' => 'letmein', 'ansible_become_password' => 'iamroot' }
-          secrets = { 'per-host' => { 'foreman.example.com' => host_secrets } }
-          host_input = { 'input' => { 'action_input' => { 'secrets' => secrets } } }
-          { 'foreman.example.com' => host_input }
-        end
-        let(:runner) { ForemanAnsibleCore::Runner::AnsibleRunner.allocate }
-
-        test 'uses secrets from inventory' do
-          test_inventory = inventory.merge('ssh_password' => 'sshpass', 'effective_user_password' => 'mypass')
-          rebuilt = runner.send(:rebuild_secrets, test_inventory, input)
-          host_vars = rebuilt.dig('_meta', 'hostvars', 'foreman.example.com')
-          assert_equal 'sshpass', host_vars['ansible_password']
-          assert_equal 'mypass', host_vars['ansible_become_password']
-        end
-
-        test 'host secrets are used when not overriden by inventory secrest' do
-          rebuilt = runner.send(:rebuild_secrets, inventory, input)
-          host_vars = rebuilt.dig('_meta', 'hostvars', 'foreman.example.com')
-          assert_equal 'letmein', host_vars['ansible_password']
-          assert_equal 'iamroot', host_vars['ansible_become_password']
-        end
-      end
-    end
-  end
-end