foreman_ansible 2.1.0 → 2.1.1

data/test/fixtures/insights_playbook.yaml

@@ -0,0 +1,79 @@
+# Red Hat Insights has recommended one or more actions for you, a system administrator, to review and if you
+# deem appropriate, deploy on your systems running Red Hat software. Based on the analysis, we have automatically
+# generated an Ansible Playbook for you. Please review and test the recommended actions and the Playbook as
+# they may contain configuration changes, updates, reboots and/or other changes to your systems. Red Hat is not
+# responsible for any adverse outcomes related to these recommendations or Playbooks.
+#
+# Addresses maintenance plan 38439429 (demo)
+# https://access.redhat.com/insights/planner/438294928
+# Generated by Red Hat Insights on Wed, 18 Apr 2018 07:54:18 GMT
+# Warning: Some of the rules in the plan do not have Ansible support and this playbook does not address them!
+
+# Kernel vulnerable to denial of service via Bluetooth stack (CVE-2017-1000251/Blueborne)
+# Identifier: (CVE_2017_1000251_kernel_blueborne|KERNEL_CVE_2017_1000251_POSSIBLE_DOS,105,fix)
+# Version: 43787ds87s78d87s87438787s87ds87ds87
+- name: Update system to the latest kernel and reboot
+  hosts: "juana-sensel.lobatolan.home"
+  become: true
+  vars:
+    # determine if we need to update the 'kernel' package or 'kernel-rt' package
+    kernel_pkg: "{{'kernel-rt' if 'rt' in ansible_kernel else 'kernel'}}"
+
+  tasks:
+    - name: Update kernel
+      yum:
+        name: "{{kernel_pkg}}"
+        state: latest
+      register: yum
+
+    - when: yum|changed
+      name: set reboot fact
+      set_fact:
+        insights_needs_reboot: True
+
+    - when: not yum|changed
+      # The latest kernel is already installed so boot from it.  Sort the installed kernels
+      # by buildtime and select the one with the most recent build time
+      block:
+      - name: get latest installed {{kernel_pkg}} package version
+        shell: rpm -q {{kernel_pkg}} --queryformat="%{buildtime}\t%{version}-%{release}.%{arch}\n" | sort -nr | head -1 | cut -f2
+        register: latest_kernel
+        check_mode: no
+
+      - name: get configured default kernel
+        command: /sbin/grubby --default-kernel
+        register: default_kernel
+        check_mode: no
+
+      - when: default_kernel.stdout.split('-', 1)[1] != latest_kernel.stdout
+        name: set the default kernel to the latest installed
+        command: /sbin/grubby --set-default /boot/vmlinuz-{{latest_kernel.stdout}}
+        register: grub_change
+        check_mode: no
+
+      - when: grub_change|changed
+        name: set reboot fact
+        set_fact:
+          insights_needs_reboot: True
+
+
+# Automatic system reboot was suppressed for this playbook.
+# This play lists the systems that need to be rebooted manually for the changes to take effect.
+- name: Reboot reminder
+  hosts: juana-sensel.lobatolan.home
+  gather_facts: False
+  tasks:
+    - debug:
+        msg: "Automatic system reboot was suppressed for this playbook. Reboot {{inventory_hostname}} manually for the changes to take effect."
+      when:
+        - insights_needs_reboot is defined
+        - insights_needs_reboot
+
+- name: run insights
+  hosts: juana-sensel.lobatolan.home
+  become: True
+  gather_facts: False
+  tasks:
+    - name: run insights
+      command: redhat-access-insights
+      changed_when: false

data/test/unit/services/insights_plan_runner_test.rb

@@ -0,0 +1,36 @@
+require 'test_plugin_helper'
+
+if defined? RedhatAccess
+  module ForemanAnsible
+    # Tests for the RH Insights plan runner. Mostly about checking whether
+    # the playbook can be parsed properly
+    class InsightsPlanRunnerTest < ActiveSupport::TestCase
+      test 'disclaimer is saved as raw_playbook' do
+        disclaimer = <<-DISCLAIMER.strip_heredoc.strip
+  # Red Hat Insights has recommended one or more actions for you, a system administrator, to review and if you
+  # deem appropriate, deploy on your systems running Red Hat software. Based on the analysis, we have automatically
+  # generated an Ansible Playbook for you. Please review and test the recommended actions and the Playbook as
+  # they may contain configuration changes, updates, reboots and/or other changes to your systems. Red Hat is not
+  # responsible for any adverse outcomes related to these recommendations or Playbooks.
+  #
+  # Addresses maintenance plan 38439429 (demo)
+  # https://access.redhat.com/insights/planner/438294928
+  # Generated by Red Hat Insights on Wed, 18 Apr 2018 07:54:18 GMT
+        DISCLAIMER
+
+        playbook = File.read(ansible_fixture_file('insights_playbook.yaml'))
+        planner = ::ForemanAnsible::InsightsPlanRunner.new(
+          FactoryBot.build(:organization), rand
+        )
+        assert_empty planner.parse_disclaimer
+        planner.expects(:insights_api_host).returns('')
+        planner.expects(:get_ssl_options_for_org).returns(nil)
+        RestClient::Resource.any_instance.expects(:get).returns(
+          OpenStruct.new(:body => playbook)
+        )
+        planner.playbook
+        assert_equal disclaimer, planner.parse_disclaimer
+      end
+    end
+  end
+end

data/test/unit/services/inventory_creator_test.rb

@@ -62,6 +62,8 @@ module ForemanAnsible
                    connection_params['ansible_user']
       refute_equal Setting['remote_execution_ssh_port'],
                    connection_params['ansible_port']
+      assert_equal ForemanRemoteExecutionCore.settings[:ssh_identity_key_file],
+                   connection_params['ansible_ssh_private_key_file']
       assert_equal extra_options['ansible_port'],
                    connection_params['ansible_port']
       assert_equal Setting['remote_execution_ssh_password'],
@@ -77,6 +79,22 @@ module ForemanAnsible
                    inventory.rex_ssh_password(@host))
     end
 
+    test 'ssh private key is passed when available' do
+      host = FactoryBot.build(:host)
+      path_to_key = '/path/to/private/key'
+      inventory = ForemanAnsible::InventoryCreator.new(host,
+                                                       @template_invocation)
+      host.params.expects(:[]).with('ansible_ssh_private_key_file').
+        returns(path_to_key)
+      host.params.expects(:[]).with('remote_execution_ssh_user').
+        returns('root')
+      host.params.expects(:[]).with('remote_execution_ssh_port').
+        returns('2222')
+      connection_params = inventory.connection_params(host)
+      assert_equal path_to_key,
+                   connection_params['ansible_ssh_private_key_file']
+    end
+
     test 'template invocation inputs are sent as Ansible variables' do
       job_template = FactoryBot.build(
         :job_template,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_ansible
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.1.1
 platform: ruby
 authors:
 - Daniel Lobato Garcia
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-08 00:00:00.000000000 Z
+date: 2018-05-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -38,20 +38,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
-- !ruby/object:Gem::Dependency
-  name: dynflow
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.8.14
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.8.14
 - !ruby/object:Gem::Dependency
   name: foreman-tasks
   requirement: !ruby/object:Gem::Requirement
@@ -59,9 +45,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '0.12'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -69,9 +52,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '0.12'
 - !ruby/object:Gem::Dependency
   name: foreman_ansible_core
   requirement: !ruby/object:Gem::Requirement
@@ -150,6 +130,7 @@ files:
 - app/services/foreman_ansible/fact_importer.rb
 - app/services/foreman_ansible/fact_parser.rb
 - app/services/foreman_ansible/fact_sparser.rb
+- app/services/foreman_ansible/insights_notification_builder.rb
 - app/services/foreman_ansible/insights_plan_runner.rb
 - app/services/foreman_ansible/inventory_creator.rb
 - app/services/foreman_ansible/playbook_creator.rb
@@ -191,8 +172,10 @@ files:
 - db/migrate/20160802153302_create_join_table_hostgroup_ansible_roles.rb
 - db/migrate/20160805094233_add_primary_key_hostgroup_ansible_roles.rb
 - db/migrate/20161122154057_automatically_set_role_timestamps.rb
+- db/migrate/20180410125416_rename_ansible_job_categories.rb
 - db/seeds.d/62_ansible_proxy_feature.rb
 - db/seeds.d/75_job_templates.rb
+- db/seeds.d/90_notification_blueprints.rb
 - lib/foreman_ansible.rb
 - lib/foreman_ansible/engine.rb
 - lib/foreman_ansible/register.rb
@@ -205,6 +188,7 @@ files:
 - package.json
 - test/factories/ansible_proxy.rb
 - test/factories/ansible_roles.rb
+- test/fixtures/insights_playbook.yaml
 - test/fixtures/report.json
 - test/fixtures/sample_facts.json
 - test/functional/ansible_roles_controller_test.rb
@@ -229,13 +213,12 @@ files:
 - test/unit/services/fact_importer_test.rb
 - test/unit/services/fact_parser_test.rb
 - test/unit/services/fact_sparser_test.rb
+- test/unit/services/insights_plan_runner_test.rb
 - test/unit/services/inventory_creator_test.rb
 - test/unit/services/proxy_selector_test.rb
 - test/unit/services/roles_importer_test.rb
 - test/unit/services/structured_fact_importer_test.rb
 - test/unit/services/ui_roles_importer_test.rb
-- webpack/components/ReportJsonViewer.js
-- webpack/index.js
 homepage: https://github.com/theforeman/foreman_ansible
 licenses:
 - GPL-3.0
@@ -256,39 +239,41 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Ansible integration with Foreman (theforeman.org)
 test_files:
-- test/factories/ansible_proxy.rb
-- test/factories/ansible_roles.rb
-- test/functional/api/v2/ansible_roles_controller_test.rb
-- test/functional/api/v2/hostgroups_controller_test.rb
-- test/functional/api/v2/hosts_controller_test.rb
-- test/functional/ansible_roles_controller_test.rb
-- test/functional/hosts_controller_test.rb
 - test/unit/ansible_role_test.rb
-- test/unit/concerns/config_reports_extensions_test.rb
-- test/unit/concerns/host_managed_extensions_test.rb
-- test/unit/concerns/hostgroup_extensions_test.rb
-- test/unit/lib/foreman_ansible_core/playbook_runner_test.rb
-- test/unit/lib/foreman_ansible_core/roles_reader_test.rb
-- test/unit/lib/proxy_api/ansible_test.rb
+- test/unit/hostgroup_ansible_role_test.rb
 - test/unit/services/api_roles_importer_test.rb
-- test/unit/services/fact_importer_test.rb
-- test/unit/services/fact_parser_test.rb
 - test/unit/services/fact_sparser_test.rb
-- test/unit/services/inventory_creator_test.rb
 - test/unit/services/proxy_selector_test.rb
-- test/unit/services/roles_importer_test.rb
+- test/unit/services/insights_plan_runner_test.rb
 - test/unit/services/structured_fact_importer_test.rb
 - test/unit/services/ui_roles_importer_test.rb
-- test/unit/actions/run_ansible_job_test.rb
-- test/unit/actions/run_proxy_ansible_command_test.rb
+- test/unit/services/inventory_creator_test.rb
+- test/unit/services/fact_parser_test.rb
+- test/unit/services/roles_importer_test.rb
+- test/unit/services/fact_importer_test.rb
 - test/unit/helpers/ansible_reports_helper_test.rb
+- test/unit/actions/run_proxy_ansible_command_test.rb
+- test/unit/actions/run_ansible_job_test.rb
+- test/unit/lib/foreman_ansible_core/playbook_runner_test.rb
+- test/unit/lib/foreman_ansible_core/roles_reader_test.rb
+- test/unit/lib/proxy_api/ansible_test.rb
 - test/unit/host_ansible_role_test.rb
-- test/unit/hostgroup_ansible_role_test.rb
-- test/fixtures/sample_facts.json
-- test/fixtures/report.json
+- test/unit/concerns/host_managed_extensions_test.rb
+- test/unit/concerns/config_reports_extensions_test.rb
+- test/unit/concerns/hostgroup_extensions_test.rb
+- test/factories/ansible_proxy.rb
+- test/factories/ansible_roles.rb
 - test/test_plugin_helper.rb
+- test/fixtures/insights_playbook.yaml
+- test/fixtures/report.json
+- test/fixtures/sample_facts.json
+- test/functional/ansible_roles_controller_test.rb
+- test/functional/api/v2/ansible_roles_controller_test.rb
+- test/functional/api/v2/hostgroups_controller_test.rb
+- test/functional/api/v2/hosts_controller_test.rb
+- test/functional/hosts_controller_test.rb

data/webpack/components/ReportJsonViewer.js

@@ -1,17 +0,0 @@
-import React from 'react';
-import JSONTree from 'react-json-tree';
-
-const theme = {
-  scheme: 'foreman',
-  backgroundColor: 'rgba(0, 0, 0, 255)',
-  base00: 'rgba(0, 0, 0, 0)',
-};
-
-class ReportJsonViewer extends React.Component {
-  render() {
-    return <div className="report-json-viewer">
-      <JSONTree data={this.props.data} hideRoot theme={theme} />
-    </div>;
-  }
-}
-export default ReportJsonViewer;

data/webpack/index.js

@@ -1,4 +0,0 @@
-import componentRegistry from 'foremanReact/components/componentRegistry';
-import ReportJsonViewer from './components/ReportJsonViewer';
-
-componentRegistry.register({ name: 'ReportJsonViewer', type: ReportJsonViewer });