foreman_ansible 15.0.7 → 16.0.0

data/webpack/components/AnsibleHostDetail/components/AnsibleVariableOverrides/EditableValueHelper.js

@@ -5,17 +5,23 @@ import {
   FormGroup,
   FormSelect,
   FormSelectOption,
+  FormHelperText,
+  HelperText,
+  HelperTextItem,
 } from '@patternfly/react-core';
 
 const withFormGroup = Component => componentProps => {
   const { validation, ...rest } = componentProps;
   return (
-    <FormGroup
-      label=""
-      helperTextInvalid={validation.msg}
-      validated={validation.key}
-    >
+    <FormGroup label="">
       <Component {...rest} validated={validation.key} />
+      {validation.key === 'error' && (
+        <FormHelperText>
+          <HelperText>
+            <HelperTextItem>{validation.msg}</HelperTextItem>
+          </HelperText>
+        </FormHelperText>
+      )}
     </FormGroup>
   );
 };

data/webpack/components/AnsibleHostDetail/components/AnsibleVariableOverrides/__test__/AnsibleVariableOverrides.test.js

@@ -67,7 +67,7 @@ describe('AnsibleVariableOverrides', () => {
       name: 'Edit override button',
     });
     expect(editBtns).toHaveLength(0);
-    const actions = screen.queryAllByRole('button', { name: 'Actions' });
+    const actions = screen.queryAllByRole('button', { name: 'Kebab toggle' });
     expect(actions).toHaveLength(0);
   });
 });

data/webpack/components/AnsibleHostDetail/components/AnsibleVariableOverrides/__test__/AnsibleVariableOverridesDelete.test.js

@@ -33,7 +33,7 @@ describe('AnsibleVariableOverrides', () => {
       />
     );
     await waitFor(tick);
-    userEvent.click(screen.getAllByRole('button', { name: 'Actions' })[0]);
+    userEvent.click(screen.getAllByRole('button', { name: 'Kebab toggle' })[0]);
     userEvent.click(screen.getByText('Delete'));
     await waitFor(tick);
     expect(
@@ -58,7 +58,7 @@ describe('AnsibleVariableOverrides', () => {
     );
     await waitFor(tick);
     expect(screen.queryByText('21')).toBeInTheDocument();
-    userEvent.click(screen.getAllByRole('button', { name: 'Actions' })[0]);
+    userEvent.click(screen.getAllByRole('button', { name: 'Kebab toggle' })[0]);
     userEvent.click(screen.getByText('Delete'));
     await waitFor(tick);
     userEvent.click(screen.getByText('Confirm'));

data/webpack/components/AnsibleHostDetail/components/JobsTab/NewRecurringJobModal.scss

@@ -1,4 +1,4 @@
-.pf-c-backdrop {
+.pf-v5-c-backdrop {
   z-index: 1040;
 }
 
@@ -8,7 +8,7 @@
     height: 70vh;
   }
 
-  .pf-c-form-control, .pf-c-date-picker, .pf-c-date-picker__input {
+  .pf-v5-c-form-control, .pf-v5-c-date-picker, .pf-v5-c-date-picker__input {
     width: 250px
   }
 }

data/webpack/components/AnsibleHostDetail/components/JobsTab/PreviousJobsTable.js

@@ -3,14 +3,7 @@ import PropTypes from 'prop-types';
 import { translate as __ } from 'foremanReact/common/I18n';
 import RelativeDateTime from 'foremanReact/components/common/dates/RelativeDateTime';
 
-import {
-  TableComposable,
-  Thead,
-  Tbody,
-  Tr,
-  Th,
-  Td,
-} from '@patternfly/react-table';
+import { Table, Thead, Tbody, Tr, Th, Td } from '@patternfly/react-table';
 import { Flex, FlexItem } from '@patternfly/react-core';
 import Pagination from 'foremanReact/components/Pagination';
 
@@ -40,7 +33,7 @@ const PreviousJobsTable = ({ history, totalCount, jobs, pagination }) => {
           />
         </FlexItem>
         <FlexItem>
-          <TableComposable ouiaId="table-composable-compact" variant="compact">
+          <Table ouiaId="table-composable-compact" variant="compact">
             <Thead>
               <Tr ouiaId="row-header">
                 {columns.map(col => (
@@ -73,7 +66,7 @@ const PreviousJobsTable = ({ history, totalCount, jobs, pagination }) => {
                 </Tr>
               ))}
             </Tbody>
-          </TableComposable>
+          </Table>
         </FlexItem>
         <FlexItem align={{ default: 'alignRight' }}>
           <Pagination

data/webpack/components/AnsibleHostDetail/components/JobsTab/RecurringJobsTable.js

@@ -5,14 +5,7 @@ import { translate as __ } from 'foremanReact/common/I18n';
 import RelativeDateTime from 'foremanReact/components/common/dates/RelativeDateTime';
 import { openConfirmModal } from 'foremanReact/components/ConfirmModal';
 
-import {
-  TableComposable,
-  Thead,
-  Tbody,
-  Tr,
-  Th,
-  Td,
-} from '@patternfly/react-table';
+import { Table, Thead, Tbody, Tr, Th, Td } from '@patternfly/react-table';
 
 import {
   useCancelMutation,
@@ -60,7 +53,7 @@ const RecurringJobsTable = ({
   return (
     <React.Fragment>
       <h3>{__('Scheduled recurring jobs')}</h3>
-      <TableComposable ouiaId="table-composable-compact" variant="compact">
+      <Table ouiaId="table-composable-compact" variant="compact">
         <Thead>
           <Tr ouiaId="row-header">
             {columns.map(col => (
@@ -93,7 +86,7 @@ const RecurringJobsTable = ({
             </Tr>
           ))}
         </Tbody>
-      </TableComposable>
+      </Table>
     </React.Fragment>
   );
 };

data/webpack/components/AnsibleHostDetail/components/JobsTab/__test__/JobsTab.test.js

@@ -102,6 +102,7 @@ describe('JobsTab', () => {
       />
     );
     await waitFor(tick);
+    await waitFor(tick);
     userEvent.click(
       screen.getByRole('button', { name: 'schedule recurring job' })
     );
@@ -156,7 +157,7 @@ describe('JobsTab', () => {
     expect(
       screen.queryByText('No config job for Ansible roles scheduled')
     ).not.toBeInTheDocument();
-    userEvent.click(screen.getAllByRole('button', { name: 'Actions' })[0]);
+    userEvent.click(screen.getAllByRole('button', { name: 'Kebab toggle' })[0]);
     userEvent.click(screen.getByText('Cancel'));
     await waitFor(tick);
     expect(

data/webpack/components/AnsibleHostDetail/components/RolesTab/AllRolesModal/AllRolesTable.js

@@ -2,14 +2,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import { translate as __ } from 'foremanReact/common/I18n';
 
-import {
-  TableComposable,
-  Thead,
-  Tbody,
-  Tr,
-  Th,
-  Td,
-} from '@patternfly/react-table';
+import { Table, Thead, Tbody, Tr, Th, Td } from '@patternfly/react-table';
 import { Flex, FlexItem } from '@patternfly/react-core';
 import Pagination from 'foremanReact/components/Pagination';
 import withLoading from '../../../../withLoading';
@@ -28,7 +21,7 @@ const AllRolesTable = ({ allAnsibleRoles, totalCount }) => {
             variant="top"
           />
         </FlexItem>
-        <TableComposable ouiaId="table-composable-compact" variant="compact">
+        <Table ouiaId="table-composable-compact" variant="compact">
           <Thead>
             <Tr ouiaId="row-header">
               <Th />
@@ -60,7 +53,7 @@ const AllRolesTable = ({ allAnsibleRoles, totalCount }) => {
               </Tr>
             ))}
           </Tbody>
-        </TableComposable>
+        </Table>
         <FlexItem align={{ default: 'alignRight' }}>
           <Pagination
             ouiaId="pagination-bottom"

data/webpack/components/AnsibleHostDetail/components/RolesTab/EditRolesModal/EditRolesModal.scss

@@ -1,3 +1,3 @@
-.pf-c-backdrop {
+.pf-v5-c-backdrop {
   z-index: 1040;
 }

data/webpack/components/AnsibleHostDetail/components/RolesTab/RolesTable.js

@@ -4,14 +4,7 @@ import { translate as __ } from 'foremanReact/common/I18n';
 import { Route, Link } from 'react-router-dom';
 import Pagination from 'foremanReact/components/Pagination';
 
-import {
-  TableComposable,
-  Thead,
-  Tbody,
-  Tr,
-  Th,
-  Td,
-} from '@patternfly/react-table';
+import { Table, Thead, Tbody, Tr, Th, Td } from '@patternfly/react-table';
 import { Flex, FlexItem, Button } from '@patternfly/react-core';
 
 import EditRolesModal from './EditRolesModal';
@@ -66,7 +59,7 @@ const RolesTable = ({
       </Flex>
       <Flex direction={{ default: 'column' }}>
         <FlexItem>
-          <TableComposable variant="compact" ouiaId="table-composable-compact">
+          <Table variant="compact" ouiaId="table-composable-compact">
             <Thead>
               <Tr ouiaId="row-header">
                 {columns.map(col => (
@@ -92,7 +85,7 @@ const RolesTable = ({
                 </Tr>
               ))}
             </Tbody>
-          </TableComposable>
+          </Table>
         </FlexItem>
         <FlexItem align={{ default: 'alignRight' }}>
           <Pagination

data/webpack/components/AnsibleRolesAndVariables/AnsibleRolesAndVariables.js

@@ -1,10 +1,10 @@
 import React, { useState } from 'react';
+import { cellWidth } from '@patternfly/react-table';
 import {
   Table,
   TableHeader,
   TableBody,
-  cellWidth,
-} from '@patternfly/react-table';
+} from '@patternfly/react-table/deprecated';
 import {
   Button,
   Toolbar,
@@ -99,7 +99,7 @@ const ImportRolesAndVariablesTable = ({
             <Checkbox
               ouiaId="ansible-roles-and-variables-table-select-all-checkbox"
               isChecked={isChecked}
-              onChange={SelectAll}
+              onChange={(_event, checked) => SelectAll(checked)}
               aria-label="select all checkbox"
               id="select-all"
               name="select-all"

data/webpack/components/DualList/ListControls.js

@@ -3,10 +3,10 @@ import PropTypes from 'prop-types';
 import { translate as __ } from 'foremanReact/common/I18n';
 
 const ListControls = props => (
-  <div className="pf-c-dual-list-selector__controls">
-    <div className="pf-c-dual-list-selector__controls-item">
+  <div className="pf-v5-c-dual-list-selector__controls">
+    <div className="pf-v5-c-dual-list-selector__controls-item">
       <button
-        className="pf-c-button pf-m-plain"
+        className="pf-v5-c-button pf-m-plain"
         type="button"
         disabled={props.addSelectedDisabled}
         onClick={props.onAddSelected}
@@ -15,9 +15,9 @@ const ListControls = props => (
         <i className="fas fa-fw fa-angle-right" />
       </button>
     </div>
-    <div className="pf-c-dual-list-selector__controls-item">
+    <div className="pf-v5-c-dual-list-selector__controls-item">
       <button
-        className="pf-c-button pf-m-plain"
+        className="pf-v5-c-button pf-m-plain"
         type="button"
         disabled={props.addAllDisabled}
         onClick={props.onAddAll}
@@ -26,9 +26,9 @@ const ListControls = props => (
         <i className="fas fa-fw fa-angle-double-right" />
       </button>
     </div>
-    <div className="pf-c-dual-list-selector__controls-item">
+    <div className="pf-v5-c-dual-list-selector__controls-item">
       <button
-        className="pf-c-button pf-m-plain"
+        className="pf-v5-c-button pf-m-plain"
         type="button"
         disabled={props.removeAllDisabled}
         onClick={props.onRemoveAll}
@@ -37,9 +37,9 @@ const ListControls = props => (
         <i className="fas fa-fw fa-angle-double-left" />
       </button>
     </div>
-    <div className="pf-c-dual-list-selector__controls-item">
+    <div className="pf-v5-c-dual-list-selector__controls-item">
       <button
-        className="pf-c-button pf-m-plain"
+        className="pf-v5-c-button pf-m-plain"
         type="button"
         disabled={props.removeSelectedDisabled}
         onClick={props.onRemoveSelected}

data/webpack/components/DualList/ListHeader.js

@@ -2,9 +2,11 @@ import React from 'react';
 import PropTypes from 'prop-types';
 
 const ListHeader = props => (
-  <div className="pf-c-dual-list-selector__header">
-    <div className="pf-c-dual-list-selector__title">
-      <div className="pf-c-dual-list-selector__title-text">{props.title}</div>
+  <div className="pf-v5-c-dual-list-selector__header">
+    <div className="pf-v5-c-dual-list-selector__title">
+      <div className="pf-v5-c-dual-list-selector__title-text">
+        {props.title}
+      </div>
     </div>
   </div>
 );

data/webpack/components/DualList/ListItem.js

@@ -4,9 +4,9 @@ import PropTypes from 'prop-types';
 
 const ListItem = props => {
   const draggableBtn = (
-    <div className="pf-c-dual-list-selector__draggable">
+    <div className="pf-v5-c-dual-list-selector__draggable">
       <button
-        className="pf-c-button pf-m-plain"
+        className="pf-v5-c-button pf-m-plain"
         type="button"
         aria-pressed="false"
         aria-label="Reorder"
@@ -24,27 +24,27 @@ const ListItem = props => {
   );
 
   return (
-    <li className="pf-c-dual-list-selector__list-item">
+    <li className="pf-v5-c-dual-list-selector__list-item">
       <div
-        className={classNames('pf-c-dual-list-selector__list-item-row ', {
+        className={classNames('pf-v5-c-dual-list-selector__list-item-row ', {
           'pf-m-selected': props.selected,
           'pf-m-ghost-row': props.dragging,
         })}
       >
         {props.draggable && draggableBtn}
         <button
-          className="pf-c-dual-list-selector__item"
+          className="pf-v5-c-dual-list-selector__item"
           type="button"
           onClick={props.onClick}
         >
-          <span className="pf-c-dual-list-selector__item-main">
-            <span className="pf-c-dual-list-selector__item-text">
+          <span className="pf-v5-c-dual-list-selector__item-main">
+            <span className="pf-v5-c-dual-list-selector__item-text">
               {props.draggable && orderBtn}
               <span>{props.name}</span>
             </span>
           </span>
-          <span className="pf-c-dual-list-selector__item-count">
-            <span className="pf-c-badge pf-m-read" />
+          <span className="pf-v5-c-dual-list-selector__item-count">
+            <span className="pf-v5-c-badge pf-m-read" />
           </span>
         </button>
       </div>

data/webpack/components/DualList/ListPane.js

@@ -58,16 +58,16 @@ const ListPane = ({
 
   return (
     <div
-      className={`pf-c-dual-list-selector__pane pf-m-available ${paneClass}`}
+      className={`pf-v5-c-dual-list-selector__pane pf-m-available ${paneClass}`}
     >
       <ListHeader title={title} />
       <SelectedStatus
         selectedCount={selected.length}
         totalCount={items.length}
       />
-      <div className="pf-c-dual-list-selector__menu">
+      <div className="pf-v5-c-dual-list-selector__menu">
         <DndProvider backend={HTML5Backend}>
-          <ul className="pf-c-dual-list-selector__list">
+          <ul className="pf-v5-c-dual-list-selector__list">
             {items.map(renderItem)}
           </ul>
         </DndProvider>

data/webpack/components/DualList/SelectedStatus.js

@@ -3,8 +3,8 @@ import PropTypes from 'prop-types';
 import { translate as __, sprintf } from 'foremanReact/common/I18n';
 
 const SelectedStatus = ({ selectedCount, totalCount }) => (
-  <div className="pf-c-dual-list-selector__status">
-    <span className="pf-c-dual-list-selector__status-text">
+  <div className="pf-v5-c-dual-list-selector__status">
+    <span className="pf-v5-c-dual-list-selector__status-text">
       {sprintf(__('%(selectedCount)s of %(totalCount)s items selected'), {
         selectedCount,
         totalCount,

data/webpack/components/DualList/index.js

@@ -61,7 +61,7 @@ const DualList = props => {
     props.onListChange(props.availableOptions, items);
 
   return (
-    <div className="pf-c-dual-list-selector">
+    <div className="pf-v5-c-dual-list-selector">
       <ListPane
         title={__('Available Ansible roles')}
         items={props.availableOptions}

data/webpack/formHelper.js

@@ -6,19 +6,12 @@ import {
   FormSelectOption,
   DatePicker,
   TimePicker,
+  FormHelperText,
+  HelperText,
+  HelperTextItem,
 } from '@patternfly/react-core';
 import { ExclamationCircleIcon } from '@patternfly/react-icons';
 
-const wrapFieldProps = fieldProps => {
-  const { onChange } = fieldProps;
-  // modify onChange args to correctly wire formik with pf4 input handlers
-  const wrappedOnChange = (value, event) => {
-    onChange(event);
-  };
-
-  return { ...fieldProps, onChange: wrappedOnChange };
-};
-
 const wrapPickerProps = fieldProps => {
   const { onChange } = fieldProps;
   // because pf4 does not provide consistent handlers for its inputs
@@ -45,18 +38,12 @@ export const SelectField = ({
   isRequired,
   blankLabel,
 }) => {
-  const fieldProps = wrapFieldProps(field);
+  const fieldProps = field;
 
   const valid = shouldValidate(form, field.name);
 
   return (
-    <FormGroup
-      label={label}
-      isRequired={isRequired}
-      helperTextInvalid={form.errors[field.name]}
-      helperTextInvalidIcon={<ExclamationCircleIcon />}
-      validated={valid}
-    >
+    <FormGroup label={label} isRequired={isRequired}>
       <FormSelect
         ouiaId={`select-${fieldProps.name}`}
         {...fieldProps}
@@ -70,6 +57,15 @@ export const SelectField = ({
           <FormSelectOption key={idx + 1} value={item.id} label={item.name} />
         ))}
       </FormSelect>
+      {valid === 'error' && (
+        <FormHelperText>
+          <HelperText>
+            <HelperTextItem variant="icon" icon={<ExclamationCircleIcon />}>
+              {form.errors[field.name]}
+            </HelperTextItem>
+          </HelperText>
+        </FormHelperText>
+      )}
     </FormGroup>
   );
 };
@@ -96,25 +92,26 @@ const pickerWithHandlers = ComponentType => {
 
     const Component = ComponentType === 'date' ? DatePicker : TimePicker;
     return (
-      <FormGroup
-        label={label}
-        isRequired={isRequired}
-        helperTextInvalid={form.errors[field.name]}
-        helperTextInvalidIcon={<ExclamationCircleIcon />}
-        validated={valid}
-      >
+      <FormGroup label={label} isRequired={isRequired}>
         <Component
           aria-label={field.name}
-          onChange={(a, b) => {
-            // datepicker: onChange	(event: React.FormEvent<HTMLInputElement>, value: string, date?: Date) => void
-            // timepicker: onChange	(time: string, hour?: number, minute?: number, seconds?: number, isValid?: boolean ) => void
-            ComponentType === 'date' ? onChange(b, a) : onChange(a);
+          onChange={(e, value) => {
+            onChange(value);
           }}
           onBlur={onBlur}
           {...rest}
           validated={valid}
           isDisabled={form.isSubmitting}
         />
+        {valid === 'error' && (
+          <FormHelperText>
+            <HelperText>
+              <HelperTextItem variant="icon" icon={<ExclamationCircleIcon />}>
+                {form.errors[field.name]}
+              </HelperTextItem>
+            </HelperText>
+          </FormHelperText>
+        )}
       </FormGroup>
     );
   };

data/webpack/routes/HostgroupJobs/__test__/HostgroupJobs.test.js

@@ -75,6 +75,7 @@ describe('HostgroupJobs', () => {
       />
     );
     await waitFor(tick);
+    await waitFor(tick);
     userEvent.click(
       screen.getByRole('button', { name: 'schedule recurring job' })
     );

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foreman_ansible
 version: !ruby/object:Gem::Version
-  version: 15.0.7
+  version: 16.0.0
 platform: ruby
 authors:
 - Daniel Lobato Garcia
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-03-31 00:00:00.000000000 Z
+date: 2025-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: acts_as_list
@@ -16,14 +15,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.3
+        version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.3
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: deface
   requirement: !ruby/object:Gem::Requirement
@@ -47,7 +46,7 @@ dependencies:
         version: '14.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '16'
+        version: '17'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -57,7 +56,7 @@ dependencies:
         version: '14.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '16'
+        version: '17'
 - !ruby/object:Gem::Dependency
   name: foreman-tasks
   requirement: !ruby/object:Gem::Requirement
@@ -67,7 +66,7 @@ dependencies:
         version: '10.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '11'
+        version: '12'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -77,7 +76,7 @@ dependencies:
         version: '10.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '11'
+        version: '12'
 - !ruby/object:Gem::Dependency
   name: theforeman-rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -105,8 +104,6 @@ files:
 - app/assets/javascripts/foreman_ansible/locale/ca/foreman_ansible.js
 - app/assets/javascripts/foreman_ansible/locale/cs_CZ/foreman_ansible.js
 - app/assets/javascripts/foreman_ansible/locale/de/foreman_ansible.js
-- app/assets/javascripts/foreman_ansible/locale/en/foreman_ansible.js
-- app/assets/javascripts/foreman_ansible/locale/en_GB/foreman_ansible.js
 - app/assets/javascripts/foreman_ansible/locale/es/foreman_ansible.js
 - app/assets/javascripts/foreman_ansible/locale/fr/foreman_ansible.js
 - app/assets/javascripts/foreman_ansible/locale/gl/foreman_ansible.js
@@ -269,6 +266,7 @@ files:
 - db/migrate/20221003153000_add_ansible_callback_enabled_to_templates.rb
 - db/migrate/20221031114720_rename_capsule_upgrade_playbook.rb
 - db/migrate/20230416170000_enable_ansible_callback_for_rex_feature.rb
+- db/migrate/20241022000000_add_ansible_check_mode_to_templates.rb
 - db/seeds.d/100_common_parameters.rb
 - db/seeds.d/62_ansible_proxy_feature.rb
 - db/seeds.d/75_job_templates.rb
@@ -285,8 +283,8 @@ files:
 - locale/cs_CZ/foreman_ansible.po
 - locale/de/LC_MESSAGES/foreman_ansible.mo
 - locale/de/foreman_ansible.po
-- locale/en/foreman_ansible.po
-- locale/en_GB/foreman_ansible.po
+- locale/en/LC_MESSAGES/foreman_ansible.mo
+- locale/en_GB/LC_MESSAGES/foreman_ansible.mo
 - locale/es/LC_MESSAGES/foreman_ansible.mo
 - locale/es/foreman_ansible.po
 - locale/foreman_ansible.pot
@@ -493,7 +491,6 @@ homepage: https://github.com/theforeman/foreman_ansible
 licenses:
 - GPL-3.0
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -508,8 +505,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.23
-signing_key:
+rubygems_version: 3.6.2
 specification_version: 4
 summary: Ansible integration with Foreman (theforeman.org)
 test_files: