foreman_ansible 15.0.5 → 16.0.0

data/locale/nl_NL/foreman_ansible.po

@@ -14,7 +14,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_ansible 15.0.0\n"
+"Project-Id-Version: foreman_ansible 15.0.5\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2018-11-14 21:36+0000\n"
 "Last-Translator: Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarde"
@@ -294,6 +294,12 @@ msgstr ""
 msgid "Enable Ansible Callback"
 msgstr ""
 
+msgid "Enable Ansible Check Mode"
+msgstr ""
+
+msgid "Enable Ansible Check Mode for this template"
+msgstr ""
+
 msgid "Enable the callback plugin for this template"
 msgstr ""
 
@@ -827,6 +833,9 @@ msgstr ""
 msgid "Update Smart Proxy"
 msgstr ""
 
+msgid "Update an override value"
+msgstr ""
+
 msgid "Updates Ansible variable"
 msgstr ""
 

data/locale/pl/foreman_ansible.po

@@ -9,7 +9,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_ansible 15.0.0\n"
+"Project-Id-Version: foreman_ansible 15.0.5\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2018-11-14 21:36+0000\n"
 "Last-Translator: Michał Foryt <michal.foryt@gmail.com>, 2023\n"
@@ -289,6 +289,12 @@ msgstr ""
 msgid "Enable Ansible Callback"
 msgstr ""
 
+msgid "Enable Ansible Check Mode"
+msgstr ""
+
+msgid "Enable Ansible Check Mode for this template"
+msgstr ""
+
 msgid "Enable the callback plugin for this template"
 msgstr ""
 
@@ -822,6 +828,9 @@ msgstr ""
 msgid "Update Smart Proxy"
 msgstr ""
 
+msgid "Update an override value"
+msgstr ""
+
 msgid "Updates Ansible variable"
 msgstr ""
 

data/locale/pt_BR/foreman_ansible.po

@@ -14,7 +14,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_ansible 15.0.0\n"
+"Project-Id-Version: foreman_ansible 15.0.5\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2018-11-14 21:36+0000\n"
 "Last-Translator: Luiz Henrique Vasconcelos <luizvasconceloss@yahoo.com.br>, 20"
@@ -295,6 +295,12 @@ msgstr "Editar Funções possíveis"
 msgid "Enable Ansible Callback"
 msgstr ""
 
+msgid "Enable Ansible Check Mode"
+msgstr ""
+
+msgid "Enable Ansible Check Mode for this template"
+msgstr ""
+
 msgid "Enable the callback plugin for this template"
 msgstr ""
 
@@ -830,6 +836,9 @@ msgstr "Atualização de variáveis de função"
 msgid "Update Smart Proxy"
 msgstr ""
 
+msgid "Update an override value"
+msgstr ""
+
 msgid "Updates Ansible variable"
 msgstr "Atualiza a variável do Ansible"
 

data/locale/ru/foreman_ansible.po

@@ -15,7 +15,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_ansible 15.0.0\n"
+"Project-Id-Version: foreman_ansible 15.0.5\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2018-11-14 21:36+0000\n"
 "Last-Translator: 0868a4d1af5275b3f70b0a6dac4c99a4, 2023\n"
@@ -295,6 +295,12 @@ msgstr ""
 msgid "Enable Ansible Callback"
 msgstr ""
 
+msgid "Enable Ansible Check Mode"
+msgstr ""
+
+msgid "Enable Ansible Check Mode for this template"
+msgstr ""
+
 msgid "Enable the callback plugin for this template"
 msgstr ""
 
@@ -828,6 +834,9 @@ msgstr ""
 msgid "Update Smart Proxy"
 msgstr ""
 
+msgid "Update an override value"
+msgstr ""
+
 msgid "Updates Ansible variable"
 msgstr ""
 

data/locale/sv_SE/foreman_ansible.po

@@ -10,7 +10,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_ansible 15.0.0\n"
+"Project-Id-Version: foreman_ansible 15.0.5\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2018-11-14 21:36+0000\n"
 "Last-Translator: johnny.westerlund <johnny.westerlund@gmail.com>, 2023\n"
@@ -289,6 +289,12 @@ msgstr ""
 msgid "Enable Ansible Callback"
 msgstr ""
 
+msgid "Enable Ansible Check Mode"
+msgstr ""
+
+msgid "Enable Ansible Check Mode for this template"
+msgstr ""
+
 msgid "Enable the callback plugin for this template"
 msgstr ""
 
@@ -822,6 +828,9 @@ msgstr ""
 msgid "Update Smart Proxy"
 msgstr ""
 
+msgid "Update an override value"
+msgstr ""
+
 msgid "Updates Ansible variable"
 msgstr ""
 

data/locale/zh_CN/foreman_ansible.po

@@ -12,7 +12,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_ansible 15.0.0\n"
+"Project-Id-Version: foreman_ansible 15.0.5\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2018-11-14 21:36+0000\n"
 "Last-Translator: Ewoud Kohl van Wijngaarden <ewoud+transifex@kohlvanwijngaarde"
@@ -292,6 +292,12 @@ msgstr "编辑 Ansible 角色"
 msgid "Enable Ansible Callback"
 msgstr "启用 Ansible 回调"
 
+msgid "Enable Ansible Check Mode"
+msgstr ""
+
+msgid "Enable Ansible Check Mode for this template"
+msgstr ""
+
 msgid "Enable the callback plugin for this template"
 msgstr "为此模板启用回调插件"
 
@@ -827,6 +833,9 @@ msgstr "更新角色变量"
 msgid "Update Smart Proxy"
 msgstr "更新智能代理"
 
+msgid "Update an override value"
+msgstr ""
+
 msgid "Updates Ansible variable"
 msgstr "更新 Ansible 变量"
 

data/locale/zh_TW/foreman_ansible.po

@@ -9,7 +9,7 @@
 #
 msgid ""
 msgstr ""
-"Project-Id-Version: foreman_ansible 15.0.0\n"
+"Project-Id-Version: foreman_ansible 15.0.5\n"
 "Report-Msgid-Bugs-To: \n"
 "PO-Revision-Date: 2018-11-14 21:36+0000\n"
 "Last-Translator: 0868a4d1af5275b3f70b0a6dac4c99a4, 2023\n"
@@ -288,6 +288,12 @@ msgstr ""
 msgid "Enable Ansible Callback"
 msgstr ""
 
+msgid "Enable Ansible Check Mode"
+msgstr ""
+
+msgid "Enable Ansible Check Mode for this template"
+msgstr ""
+
 msgid "Enable the callback plugin for this template"
 msgstr ""
 
@@ -821,6 +827,9 @@ msgstr ""
 msgid "Update Smart Proxy"
 msgstr ""
 
+msgid "Update an override value"
+msgstr ""
+
 msgid "Updates Ansible variable"
 msgstr ""
 

data/webpack/components/AnsibleHostDetail/AnsibleHostDetail.scss

@@ -1,4 +1,4 @@
-@import '~@theforeman/vendor/scss/variables';
+@import 'foremanReact/common/colors';
 
 .ansible-host-detail {
   background-color: $pf-color-white;

data/webpack/components/AnsibleHostDetail/components/AnsibleVariableOverrides/AnsibleVariableOverridesTable.js

@@ -5,14 +5,7 @@ import { useMutation } from '@apollo/client';
 
 import { sprintf, translate as __ } from 'foremanReact/common/I18n';
 import { openConfirmModal } from 'foremanReact/components/ConfirmModal';
-import {
-  TableComposable,
-  Thead,
-  Tbody,
-  Tr,
-  Th,
-  Td,
-} from '@patternfly/react-table';
+import { Table, Thead, Tbody, Tr, Th, Td } from '@patternfly/react-table';
 import { Flex, FlexItem } from '@patternfly/react-core';
 
 import Pagination from 'foremanReact/components/Pagination';
@@ -77,7 +70,7 @@ const AnsibleVariableOverridesTable = ({
     innerDispatch({ idx, payload: { open: flag } });
   };
 
-  const onValueChange = (idx, variable) => value => {
+  const onValueChange = (idx, variable) => (e, value) => {
     const payload = {
       value,
       validation: validateValue(variable, value),
@@ -156,7 +149,7 @@ const AnsibleVariableOverridesTable = ({
           />
         </FlexItem>
         <FlexItem>
-          <TableComposable ouiaId="table-composable-compact" variant="compact">
+          <Table ouiaId="table-composable-compact" variant="compact">
             <Thead>
               <Tr ouiaId="row-header">
                 {columns.map(col => (
@@ -203,7 +196,7 @@ const AnsibleVariableOverridesTable = ({
                 </Tr>
               ))}
             </Tbody>
-          </TableComposable>
+          </Table>
         </FlexItem>
         <FlexItem align={{ default: 'alignRight' }}>
           <Pagination

data/webpack/components/AnsibleHostDetail/components/AnsibleVariableOverrides/EditableValue.js

@@ -4,11 +4,7 @@ import { translate as __ } from 'foremanReact/common/I18n';
 
 import { formatValue } from './AnsibleVariableOverridesTableHelper';
 
-import {
-  TextAreaField,
-  TextInputField,
-  SelectField,
-} from './EditableValueHelper';
+import { TextAreaField, SelectField } from './EditableValueHelper';
 
 const EditableValue = props => {
   if (!props.editing) {
@@ -50,7 +46,7 @@ const EditableValue = props => {
   }
 
   return (
-    <TextInputField
+    <TextAreaField
       onChange={props.onChange}
       value={props.value}
       validation={props.validation}

data/webpack/components/AnsibleHostDetail/components/AnsibleVariableOverrides/EditableValueHelper.js

@@ -5,17 +5,23 @@ import {
   FormGroup,
   FormSelect,
   FormSelectOption,
+  FormHelperText,
+  HelperText,
+  HelperTextItem,
 } from '@patternfly/react-core';
 
 const withFormGroup = Component => componentProps => {
   const { validation, ...rest } = componentProps;
   return (
-    <FormGroup
-      label=""
-      helperTextInvalid={validation.msg}
-      validated={validation.key}
-    >
+    <FormGroup label="">
       <Component {...rest} validated={validation.key} />
+      {validation.key === 'error' && (
+        <FormHelperText>
+          <HelperText>
+            <HelperTextItem>{validation.msg}</HelperTextItem>
+          </HelperText>
+        </FormHelperText>
+      )}
     </FormGroup>
   );
 };

data/webpack/components/AnsibleHostDetail/components/AnsibleVariableOverrides/__test__/AnsibleVariableOverrides.test.js

@@ -67,7 +67,7 @@ describe('AnsibleVariableOverrides', () => {
       name: 'Edit override button',
     });
     expect(editBtns).toHaveLength(0);
-    const actions = screen.queryAllByRole('button', { name: 'Actions' });
+    const actions = screen.queryAllByRole('button', { name: 'Kebab toggle' });
     expect(actions).toHaveLength(0);
   });
 });

data/webpack/components/AnsibleHostDetail/components/AnsibleVariableOverrides/__test__/AnsibleVariableOverridesDelete.test.js

@@ -33,7 +33,7 @@ describe('AnsibleVariableOverrides', () => {
       />
     );
     await waitFor(tick);
-    userEvent.click(screen.getAllByRole('button', { name: 'Actions' })[0]);
+    userEvent.click(screen.getAllByRole('button', { name: 'Kebab toggle' })[0]);
     userEvent.click(screen.getByText('Delete'));
     await waitFor(tick);
     expect(
@@ -58,7 +58,7 @@ describe('AnsibleVariableOverrides', () => {
     );
     await waitFor(tick);
     expect(screen.queryByText('21')).toBeInTheDocument();
-    userEvent.click(screen.getAllByRole('button', { name: 'Actions' })[0]);
+    userEvent.click(screen.getAllByRole('button', { name: 'Kebab toggle' })[0]);
     userEvent.click(screen.getByText('Delete'));
     await waitFor(tick);
     userEvent.click(screen.getByText('Confirm'));

data/webpack/components/AnsibleHostDetail/components/JobsTab/NewRecurringJobModal.scss

@@ -1,4 +1,4 @@
-.pf-c-backdrop {
+.pf-v5-c-backdrop {
   z-index: 1040;
 }
 
@@ -8,7 +8,7 @@
     height: 70vh;
   }
 
-  .pf-c-form-control, .pf-c-date-picker, .pf-c-date-picker__input {
+  .pf-v5-c-form-control, .pf-v5-c-date-picker, .pf-v5-c-date-picker__input {
     width: 250px
   }
 }

data/webpack/components/AnsibleHostDetail/components/JobsTab/PreviousJobsTable.js

@@ -3,14 +3,7 @@ import PropTypes from 'prop-types';
 import { translate as __ } from 'foremanReact/common/I18n';
 import RelativeDateTime from 'foremanReact/components/common/dates/RelativeDateTime';
 
-import {
-  TableComposable,
-  Thead,
-  Tbody,
-  Tr,
-  Th,
-  Td,
-} from '@patternfly/react-table';
+import { Table, Thead, Tbody, Tr, Th, Td } from '@patternfly/react-table';
 import { Flex, FlexItem } from '@patternfly/react-core';
 import Pagination from 'foremanReact/components/Pagination';
 
@@ -40,7 +33,7 @@ const PreviousJobsTable = ({ history, totalCount, jobs, pagination }) => {
           />
         </FlexItem>
         <FlexItem>
-          <TableComposable ouiaId="table-composable-compact" variant="compact">
+          <Table ouiaId="table-composable-compact" variant="compact">
             <Thead>
               <Tr ouiaId="row-header">
                 {columns.map(col => (
@@ -73,7 +66,7 @@ const PreviousJobsTable = ({ history, totalCount, jobs, pagination }) => {
                 </Tr>
               ))}
             </Tbody>
-          </TableComposable>
+          </Table>
         </FlexItem>
         <FlexItem align={{ default: 'alignRight' }}>
           <Pagination

data/webpack/components/AnsibleHostDetail/components/JobsTab/RecurringJobsTable.js

@@ -5,14 +5,7 @@ import { translate as __ } from 'foremanReact/common/I18n';
 import RelativeDateTime from 'foremanReact/components/common/dates/RelativeDateTime';
 import { openConfirmModal } from 'foremanReact/components/ConfirmModal';
 
-import {
-  TableComposable,
-  Thead,
-  Tbody,
-  Tr,
-  Th,
-  Td,
-} from '@patternfly/react-table';
+import { Table, Thead, Tbody, Tr, Th, Td } from '@patternfly/react-table';
 
 import {
   useCancelMutation,
@@ -60,7 +53,7 @@ const RecurringJobsTable = ({
   return (
     <React.Fragment>
       <h3>{__('Scheduled recurring jobs')}</h3>
-      <TableComposable ouiaId="table-composable-compact" variant="compact">
+      <Table ouiaId="table-composable-compact" variant="compact">
         <Thead>
           <Tr ouiaId="row-header">
             {columns.map(col => (
@@ -93,7 +86,7 @@ const RecurringJobsTable = ({
             </Tr>
           ))}
         </Tbody>
-      </TableComposable>
+      </Table>
     </React.Fragment>
   );
 };

data/webpack/components/AnsibleHostDetail/components/JobsTab/__test__/JobsTab.test.js

@@ -102,6 +102,7 @@ describe('JobsTab', () => {
       />
     );
     await waitFor(tick);
+    await waitFor(tick);
     userEvent.click(
       screen.getByRole('button', { name: 'schedule recurring job' })
     );
@@ -156,7 +157,7 @@ describe('JobsTab', () => {
     expect(
       screen.queryByText('No config job for Ansible roles scheduled')
     ).not.toBeInTheDocument();
-    userEvent.click(screen.getAllByRole('button', { name: 'Actions' })[0]);
+    userEvent.click(screen.getAllByRole('button', { name: 'Kebab toggle' })[0]);
     userEvent.click(screen.getByText('Cancel'));
     await waitFor(tick);
     expect(

data/webpack/components/AnsibleHostDetail/components/RolesTab/AllRolesModal/AllRolesTable.js

@@ -2,14 +2,7 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import { translate as __ } from 'foremanReact/common/I18n';
 
-import {
-  TableComposable,
-  Thead,
-  Tbody,
-  Tr,
-  Th,
-  Td,
-} from '@patternfly/react-table';
+import { Table, Thead, Tbody, Tr, Th, Td } from '@patternfly/react-table';
 import { Flex, FlexItem } from '@patternfly/react-core';
 import Pagination from 'foremanReact/components/Pagination';
 import withLoading from '../../../../withLoading';
@@ -28,7 +21,7 @@ const AllRolesTable = ({ allAnsibleRoles, totalCount }) => {
             variant="top"
           />
         </FlexItem>
-        <TableComposable ouiaId="table-composable-compact" variant="compact">
+        <Table ouiaId="table-composable-compact" variant="compact">
           <Thead>
             <Tr ouiaId="row-header">
               <Th />
@@ -60,7 +53,7 @@ const AllRolesTable = ({ allAnsibleRoles, totalCount }) => {
               </Tr>
             ))}
           </Tbody>
-        </TableComposable>
+        </Table>
         <FlexItem align={{ default: 'alignRight' }}>
           <Pagination
             ouiaId="pagination-bottom"

data/webpack/components/AnsibleHostDetail/components/RolesTab/EditRolesModal/EditRolesModal.scss

@@ -1,3 +1,3 @@
-.pf-c-backdrop {
+.pf-v5-c-backdrop {
   z-index: 1040;
 }

data/webpack/components/AnsibleHostDetail/components/RolesTab/RolesTable.js

@@ -4,14 +4,7 @@ import { translate as __ } from 'foremanReact/common/I18n';
 import { Route, Link } from 'react-router-dom';
 import Pagination from 'foremanReact/components/Pagination';
 
-import {
-  TableComposable,
-  Thead,
-  Tbody,
-  Tr,
-  Th,
-  Td,
-} from '@patternfly/react-table';
+import { Table, Thead, Tbody, Tr, Th, Td } from '@patternfly/react-table';
 import { Flex, FlexItem, Button } from '@patternfly/react-core';
 
 import EditRolesModal from './EditRolesModal';
@@ -66,7 +59,7 @@ const RolesTable = ({
       </Flex>
       <Flex direction={{ default: 'column' }}>
         <FlexItem>
-          <TableComposable variant="compact" ouiaId="table-composable-compact">
+          <Table variant="compact" ouiaId="table-composable-compact">
             <Thead>
               <Tr ouiaId="row-header">
                 {columns.map(col => (
@@ -92,7 +85,7 @@ const RolesTable = ({
                 </Tr>
               ))}
             </Tbody>
-          </TableComposable>
+          </Table>
         </FlexItem>
         <FlexItem align={{ default: 'alignRight' }}>
           <Pagination

data/webpack/components/AnsibleRolesAndVariables/AnsibleRolesAndVariables.js

@@ -1,10 +1,10 @@
 import React, { useState } from 'react';
+import { cellWidth } from '@patternfly/react-table';
 import {
   Table,
   TableHeader,
   TableBody,
-  cellWidth,
-} from '@patternfly/react-table';
+} from '@patternfly/react-table/deprecated';
 import {
   Button,
   Toolbar,
@@ -99,7 +99,7 @@ const ImportRolesAndVariablesTable = ({
             <Checkbox
               ouiaId="ansible-roles-and-variables-table-select-all-checkbox"
               isChecked={isChecked}
-              onChange={SelectAll}
+              onChange={(_event, checked) => SelectAll(checked)}
               aria-label="select all checkbox"
               id="select-all"
               name="select-all"

data/webpack/components/DualList/ListControls.js

@@ -3,10 +3,10 @@ import PropTypes from 'prop-types';
 import { translate as __ } from 'foremanReact/common/I18n';
 
 const ListControls = props => (
-  <div className="pf-c-dual-list-selector__controls">
-    <div className="pf-c-dual-list-selector__controls-item">
+  <div className="pf-v5-c-dual-list-selector__controls">
+    <div className="pf-v5-c-dual-list-selector__controls-item">
       <button
-        className="pf-c-button pf-m-plain"
+        className="pf-v5-c-button pf-m-plain"
         type="button"
         disabled={props.addSelectedDisabled}
         onClick={props.onAddSelected}
@@ -15,9 +15,9 @@ const ListControls = props => (
         <i className="fas fa-fw fa-angle-right" />
       </button>
     </div>
-    <div className="pf-c-dual-list-selector__controls-item">
+    <div className="pf-v5-c-dual-list-selector__controls-item">
       <button
-        className="pf-c-button pf-m-plain"
+        className="pf-v5-c-button pf-m-plain"
         type="button"
         disabled={props.addAllDisabled}
         onClick={props.onAddAll}
@@ -26,9 +26,9 @@ const ListControls = props => (
         <i className="fas fa-fw fa-angle-double-right" />
       </button>
     </div>
-    <div className="pf-c-dual-list-selector__controls-item">
+    <div className="pf-v5-c-dual-list-selector__controls-item">
       <button
-        className="pf-c-button pf-m-plain"
+        className="pf-v5-c-button pf-m-plain"
         type="button"
         disabled={props.removeAllDisabled}
         onClick={props.onRemoveAll}
@@ -37,9 +37,9 @@ const ListControls = props => (
         <i className="fas fa-fw fa-angle-double-left" />
       </button>
     </div>
-    <div className="pf-c-dual-list-selector__controls-item">
+    <div className="pf-v5-c-dual-list-selector__controls-item">
       <button
-        className="pf-c-button pf-m-plain"
+        className="pf-v5-c-button pf-m-plain"
         type="button"
         disabled={props.removeSelectedDisabled}
         onClick={props.onRemoveSelected}

data/webpack/components/DualList/ListHeader.js

@@ -2,9 +2,11 @@ import React from 'react';
 import PropTypes from 'prop-types';
 
 const ListHeader = props => (
-  <div className="pf-c-dual-list-selector__header">
-    <div className="pf-c-dual-list-selector__title">
-      <div className="pf-c-dual-list-selector__title-text">{props.title}</div>
+  <div className="pf-v5-c-dual-list-selector__header">
+    <div className="pf-v5-c-dual-list-selector__title">
+      <div className="pf-v5-c-dual-list-selector__title-text">
+        {props.title}
+      </div>
     </div>
   </div>
 );