foreman_ansible 1.0 → 1.1

data/test/factories/ansible_proxy.rb

@@ -0,0 +1,7 @@
+FactoryGirl.modify do
+  factory :smart_proxy do
+    trait :with_ansible do
+      features { [::Feature.find_or_create_by(:name => 'Ansible')] }
+    end
+  end
+end

data/test/factories/ansible_roles.rb

@@ -1,5 +1,5 @@
 FactoryGirl.define do
-  factory :ansible_role, :class => ForemanAnsible::AnsibleRole do
-    sequence(:name) { |n| "ansible_role_#{n}"}
+  factory :ansible_role do
+    sequence(:name) { |n| "ansible_role_#{n}" }
   end
 end

data/test/fixtures/ansible_permissions.yml

@@ -0,0 +1,11 @@
+---
+  view_ansible_roles:
+    name: view_ansible_roles
+    resource_type: AnsibleRole
+    created_at: "2013-12-04 08:41:04.321867"
+    updated_at: "2013-12-04 08:41:04.321867"
+  destroy_ansible_roles:
+    name: destroy_ansible_roles
+    resource_type: AnsibleRole
+    created_at: "2013-12-04 08:41:04.321867"
+    updated_at: "2013-12-04 08:41:04.321867"

data/test/functional/ansible_roles_controller_test.rb

@@ -0,0 +1,16 @@
+require 'test_plugin_helper'
+# functional tests for AnsibleRolesController
+class AnsibleRolesControllerTest < ActionController::TestCase
+  setup do
+    @role = FactoryGirl.create(:ansible_role)
+  end
+
+  basic_index_test
+
+  test 'should destroy role' do
+    assert_difference('AnsibleRole.count', -1) do
+      delete :destroy, { :id => @role.id }, set_session_user
+    end
+    assert_redirected_to ansible_roles_url
+  end
+end

data/test/functional/api/v2/ansible_roles_controller_test.rb

@@ -0,0 +1,24 @@
+require 'test_plugin_helper'
+
+module Api
+  module V2
+    class AnsibleRolesControllerTest < ActionController::TestCase
+      setup do
+        @role = FactoryGirl.create(:ansible_role)
+      end
+
+      test 'should get index' do
+        get :index, {}, set_session_user
+        response = JSON.parse(@response.body)
+        refute_empty response['results']
+        assert_response :success
+      end
+
+      test 'should destroy' do
+        delete :destroy, { :id => @role.id }, set_session_user
+        assert_response :ok
+        refute AnsibleRole.exists?(@role.id)
+      end
+    end
+  end
+end

data/test/functional/hosts_controller_test.rb

@@ -1,36 +1,77 @@
 require 'test_plugin_helper'
+require 'dynflow/testing'
+Mocha::Mock.send :include, Dynflow::Testing::Mimic
+require 'support/foreman_tasks/task'
 
+# Ensure Hosts controller can CRUD ansible roles
 class HostsControllerExtensionsTest < ActionController::TestCase
+  include Support::ForemanTasks::Task
+
   tests ::HostsController
 
-  setup do
-    @role = FactoryGirl.create(:ansible_role)
-  end
+  context 'role assignment' do
+    setup do
+      @role = FactoryGirl.create(:ansible_role)
+    end
+
+    test 'create a host with ansible roles' do
+      host = { :name => 'foo',
+               :managed => false,
+               :ansible_role_ids => [@role.id] }
+      post :create, { :host => host }, set_session_user
+      assert_redirected_to host_url(assigns('host'))
+      assert assigns('host').ansible_roles, [@role]
+    end
+
+    test 'update a host with ansible roles' do
+      host = FactoryGirl.create(:host, :managed => false)
+      post :update, { :id => host.id,
+                      :host => { :ansible_role_ids => [@role.id] } },
+           set_session_user
+      assert_redirected_to host_url(assigns('host'))
+      assert assigns('host').ansible_roles, [@role]
+    end
 
-  test 'create a host with ansible roles' do
-    host = { :name => 'foo',
-             :managed => false,
-             :ansible_role_ids => [@role.id] }
-    post :create, { :host => host },
-      set_session_user
-    assert_redirected_to host_url(assigns('host'))
-    assert assigns('host').ansible_roles, [@role]
+    test 'delete a host with ansible roles' do
+      host = FactoryGirl.create(:host,
+                                :managed => false,
+                                :ansible_roles => [@role])
+      assert_include @role.hosts, host
+      delete :destroy, { :id => host.id }, set_session_user
+      assert_redirected_to hosts_url
+      assert @role.hosts.empty?
+    end
   end
 
-  test 'update a host with ansible roles' do
-    host = FactoryGirl.create(:host, :managed => false)
-    post :update, { :id => host.id, :ansible_role_ids => [@role.id] },
-      set_session_user
-    assert_redirected_to host_url(assigns('host'))
-    assert assigns('host').ansible_roles, [@role]
+  context 'playing roles' do
+    setup do
+      @host = FactoryGirl.create(:host, :managed => false)
+    end
+
+    test 'redirect to task if successful' do
+      task_stub = new_task_stub(@host)
+      task_to_redirect = ForemanTasks::Task.new
+      task_stub.stubs(:to_model).returns(task_to_redirect)
+      task_to_redirect.stubs(:persisted?).returns(true)
+      task_to_redirect.stubs(:id).returns(1)
+      get :play_roles, { :id => @host.id }, set_session_user
+    end
+
+    test 'shows errors when not successful' do
+      HostsController.any_instance.expects(:async_task).
+        raises(::Foreman::Exception.new('Oh foo'))
+      get :play_roles, { :id => @host.id }, set_session_user
+      assert flash[:error].present?
+      assert_redirected_to host_path(@host)
+    end
   end
 
-  test 'delete a host with ansible roles' do
-    host = FactoryGirl.create(:host, :managed => false,
-                              :ansible_roles => [@role])
-    assert_include @role.hosts, host
-    delete :destroy, { :id => host.id }, set_session_user
-    assert_redirected_to hosts_url
-    assert @role.hosts.empty?
+  private
+
+  def new_task_stub(host)
+    assert_async_task(::Actions::ForemanAnsible::PlayHostRoles,
+                      host) do |action_host|
+      assert_equal host, action_host
+    end
   end
 end

data/test/support/fixture_support.rb

@@ -0,0 +1,25 @@
+module ForemanAnsible
+  module PluginFixtures
+    FIXTURE_MAPPING = {
+      :ansible_permissions => :permissions
+    }.freeze
+
+    def self.add_fixtures(new_fixture_path)
+      FileUtils.cp(Dir.glob("#{Rails.root}/test/fixtures/*"), new_fixture_path)
+      copy_plugin_fixtures new_fixture_path
+    end
+
+    def self.copy_plugin_fixtures(new_fixture_path)
+      FIXTURE_MAPPING.each do |key, value|
+        fixture_path = "#{ForemanAnsible::Engine.root}/test/fixtures/#{key}.yml"
+        break unless File.exist?(fixture_path)
+        File.open("#{new_fixture_path}/#{value}.yml", 'a') do |file|
+          File.open(fixture_path, 'r').each do |line|
+            next if line =~ /---/
+            file.write line
+          end
+        end
+      end
+    end
+  end
+end

data/test/support/foreman_tasks/task.rb

@@ -0,0 +1,47 @@
+module Support
+  module ForemanTasks
+    module Task
+      def stub_tasks!
+        @controller.stubs(:sync_task).returns(build_task_stub)
+        @controller.stubs(:async_task).returns(build_task_stub)
+      end
+
+      def build_task_stub
+        task_attrs = [:id, :label, :pending, :username, :started_at, :ended_at,
+                      :state, :result, :progress, :input, :humanized,
+                      :cli_example].inject({}) { |a, e| a.update e => nil }
+        task_attrs[:output] = {}
+
+        stub('task', task_attrs).mimic!(::ForemanTasks::Task)
+      end
+
+      def assert_async_task(expected_action_class, *args_expected)
+        assert_foreman_task(true, expected_action_class, *args_expected)
+      end
+
+      def assert_sync_task(expected_action_class, *args_expected)
+        assert_foreman_task(false, expected_action_class, *args_expected)
+      end
+
+      def assert_foreman_task(async, expected_action_class, *args_expected)
+        block ||= block_from_args(args_expected)
+        method = async ? :async_task : :sync_task
+        task_stub = build_task_stub
+        @controller.
+          expects(method).
+          with do |action_class, *args|
+            expected_action_class == action_class && block.call(*args)
+          end.
+          returns(task_stub)
+        task_stub
+      end
+
+      private
+
+      def block_from_args(args_expected)
+        ->(*_) { true } if args_expected.empty?
+        ->(*args) { args == args_expected }
+      end
+    end
+  end
+end

data/test/support/foreman_test_helper_additions.rb

@@ -0,0 +1,22 @@
+require "#{ForemanAnsible::Engine.root}/test/support/fixture_support"
+# loads the permissions for foreman_ansible and makes them available in tests
+module AnsiblePermissionTestCase
+  extend ActiveSupport::Concern
+
+  included do
+    extend ActiveRecord::TestFixtures
+
+    new_fixture_path = Dir.mktmpdir('ansible_fixtures')
+    self.fixture_path = new_fixture_path
+    ForemanAnsible::PluginFixtures.add_fixtures(new_fixture_path)
+    fixtures(:all)
+    load_fixtures(ActiveRecord::Base)
+  end
+end
+
+module ActiveSupport
+  #:nodoc
+  class TestCase
+    include AnsiblePermissionTestCase
+  end
+end

data/test/test_plugin_helper.rb

@@ -1,8 +1,11 @@
 require 'test_helper'
 
 def sample_facts_file
-  File.read(File.join(
-    ForemanAnsible::Engine.root, 'test', 'fixtures', 'sample_facts.json'))
+  File.read(
+    File.join(
+      ForemanAnsible::Engine.root, 'test', 'fixtures', 'sample_facts.json'
+    )
+  )
 end
 
 def facts_json

data/test/unit/ansible_role_test.rb

@@ -1,8 +1,12 @@
- require 'test_plugin_helper'
+require 'test_plugin_helper'
 
+# Tests for the behavior of Ansible Role, currently only validations
 class AnsibleRoleTest < ActiveSupport::TestCase
   should have_many(:host_ansible_roles)
   should have_many(:hosts).through(:host_ansible_roles).dependent(:destroy)
   should validate_presence_of(:name)
-  should validate_uniqueness_of(:name)
+  context 'with new role' do
+    subject { AnsibleRole.new(:name => 'foo') }
+    should validate_uniqueness_of(:name)
+  end
 end

data/test/unit/concerns/host_managed_extensions_test.rb

@@ -0,0 +1,37 @@
+require 'test_plugin_helper'
+
+# Tests for the behavior of Host with roles, checks inheritance, etc
+class HostManagedExtensionsTest < ActiveSupport::TestCase
+  before do
+    @role1 = FactoryGirl.create(:ansible_role)
+    @role2 = FactoryGirl.create(:ansible_role)
+    @role3 = FactoryGirl.create(:ansible_role)
+
+    @hostgroup_parent = FactoryGirl.create(:hostgroup,
+                                           :ansible_roles => [@role2])
+    @hostgroup = FactoryGirl.create(:hostgroup, :parent => @hostgroup_parent)
+    @host = FactoryGirl.build_stubbed(:host, :ansible_roles => [@role1])
+  end
+
+  describe '#all_ansible_roles' do
+    test 'returns assigned roles for host without a hostgroup' do
+      @host.all_ansible_roles.must_equal [@role1]
+    end
+
+    test 'returns assigned and inherited roles for host with a hostgroup' do
+      @host.hostgroup = @hostgroup
+      @host.all_ansible_roles.must_equal [@role1, @role2]
+    end
+  end
+
+  describe '#inherited_ansible_roles' do
+    test 'returns empty array for host without hostgroup' do
+      @host.inherited_ansible_roles.must_equal []
+    end
+
+    test 'returns roles inherited from a hostgroup' do
+      @host.hostgroup = @hostgroup
+      @host.inherited_ansible_roles.must_equal [@role2]
+    end
+  end
+end

data/test/unit/concerns/hostgroup_extensions_test.rb

@@ -0,0 +1,36 @@
+require 'test_plugin_helper'
+
+# Tests for the behavior of Hostgroup with roles, checks inheritance, etc
+class HostgroupExtensionsTest < ActiveSupport::TestCase
+  before do
+    @role1 = FactoryGirl.create(:ansible_role)
+    @role2 = FactoryGirl.create(:ansible_role)
+    @role3 = FactoryGirl.create(:ansible_role)
+
+    @hostgroup_parent = FactoryGirl.create(:hostgroup,
+                                           :ansible_roles => [@role2])
+    @hostgroup = FactoryGirl.create(:hostgroup, :ansible_roles => [@role1])
+  end
+
+  describe '#all_ansible_roles' do
+    test 'returns assigned roles without any parent hostgroup' do
+      @hostgroup.all_ansible_roles.must_equal [@role1]
+    end
+
+    test 'returns assigned and inherited roles with a parent hostgroup' do
+      @hostgroup.parent = @hostgroup_parent
+      @hostgroup.all_ansible_roles.must_equal [@role1, @role2]
+    end
+  end
+
+  describe '#inherited_ansible_roles' do
+    test 'returns empty array for hostgroup without any parent' do
+      @hostgroup.inherited_ansible_roles.must_equal []
+    end
+
+    test 'returns roles inherited from a chain of parents' do
+      @hostgroup.parent = @hostgroup_parent
+      @hostgroup.inherited_ansible_roles.must_equal [@role2]
+    end
+  end
+end

data/test/unit/fact_importer_test.rb

@@ -1,22 +1,25 @@
 require 'test_plugin_helper'
 
 module ForemanAnsible
+  # Test for the facts importer - only verify that given
+  # a set of facts it's able to import them
   class FactImporterTest < ActiveSupport::TestCase
     setup do
-      @host = FactoryGirl.build_stubbed(:host)
+      @host = FactoryGirl.build(:host)
     end
 
     test 'add new facts adds all fact names in the fixture' do
       @fact_importer = FactImporter.new(@host, facts_json)
       facts_to_be_added = FactSparser.sparse(facts_json[:ansible_facts]).keys +
-        FactSparser.unsparse(facts_json[:ansible_facts]).keys
+                          FactSparser.unsparse(facts_json[:ansible_facts]).keys
       @fact_importer.send(:add_new_facts)
-      assert (facts_to_be_added - FactName.all.map(&:name)).empty?
+      assert((facts_to_be_added - FactName.all.map(&:name)).empty?)
     end
 
     test 'missing_facts returns facts we do not have in the database' do
       @fact_importer = FactImporter.new(@host, facts_json)
-      @fact_importer.expects(:db_facts).returns('ansible_cmdline' => 'fakevalue')
+      @fact_importer.expects(:db_facts).
+        returns('ansible_cmdline' => 'fakevalue')
       refute @fact_importer.send(:missing_facts).include?('ansible_cmdline')
     end
 
@@ -36,12 +39,12 @@ module ForemanAnsible
         @fact_importer.counters[:added] = 0
         assert_difference('@host.fact_values.count', 1) do
           @fact_importer.send(:add_fact_value, 'missing_value', missing_fact)
+          @host.save
+          # We have to save the host in order to ensure @host.fact_values.count
+          # resolves properly (otherwise) :add_fact_value just won't save the
+          # relation
         end
       end
     end
-
-    test 'add_fact_value works for hosts that have not been created yet' do
-    end
   end
 end
-

data/test/unit/fact_parser_test.rb

@@ -1,6 +1,8 @@
 require 'test_plugin_helper'
 
 module ForemanAnsible
+  # Checks sample Ansible facts to see if it can assign them to
+  # Host properties
   class FactParserTest < ActiveSupport::TestCase
     setup do
       @facts_parser = ForemanAnsible::FactParser.new(facts_json)

data/test/unit/fact_sparser_test.rb

@@ -1,6 +1,7 @@
 require 'test_plugin_helper'
 
 module ForemanAnsible
+  # Tests for checking if FactSparser can sparse a hash and unsparse it
   class FactSparserTest < ActiveSupport::TestCase
     setup do
       @original_os_facts = { 'operatingsystem' => { 'major' => 20, 'minor' => 1,