foreman_ansible 0.3 → 1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f98cfedfee37e7a9829abe818b80cfc7d553b001
-  data.tar.gz: 008f22e68ec44bf9aa46e75d9006608df8c2821a
+  metadata.gz: fc4ac60019a9a765f9d6952ef2353dd4c67ddac3
+  data.tar.gz: 1cdc990b070ea857835c74822b021340640bac56
 SHA512:
-  metadata.gz: 1b1a8c519e2f29aaf1cfdb5b8c604e06db5d8dcbf3a7646a25b1e9a2a935e9dab4b0977ae21d56e4623fd022fd6b68db4358efddcb9f1a32ab83755f4b2921cf
-  data.tar.gz: 54eace7707e28bcb0870cb8e24a270fb473c208c4845bb85c3fbdcf925a1690f0c31577072a5a076502564dde7a1b4ec9c2202336c21bf4b4bc4ea828ffbd2fb
+  metadata.gz: 6658351477f153ae2b6b42356ba9cb75515fbfeae8a8a40040e2c80d458b127adb2a2a37171b42dc54ca73b135cfd207aa804d190ad6a63df5b8ae8f211805b7
+  data.tar.gz: 20f1305a896c46529bc488044f3a3284feb09290845ecbdd333be2ad616473051aa2160cacca849656164bd8c91b654e063a35b4ad9a9edeaa2e257db37cee4c

data/README.md

@@ -1,35 +1,29 @@
+[![Code Climate](https://codeclimate.com/github/theforeman/foreman_ansible/badges/gpa.svg)](https://codeclimate.com/github/theforeman/foreman_ansible)
+[![Gem Version](https://badge.fury.io/rb/foreman_ansible.svg)](https://badge.fury.io/rb/foreman_ansible)
+[![GPL License](https://img.shields.io/github/license/theforeman/foreman_ansible.svg)](https://github.com/theforeman/foreman_ansible/blob/master/LICENSE)
+
 # Foreman Ansible :arrow_forward:
 
+Reporting and facts import from Ansible to Foreman.
+
+* Main website: [theforeman.org](http://theforeman.org)
+* Plugin manual: [foreman_ansible manual](http://theforeman.org/plugins/foreman_ansible/1.x/index.html)
+* ServerFault tag: [Foreman](http://serverfault.com/questions/tagged/foreman)
+* Issues: [foreman ansible on Redmine](http://projects.theforeman.org/projects/ansible/issues)
+* Community and support: [#theforeman](https://kiwiirc.com/client/irc.freenode.net/?#theforeman) for general support, [#theforeman-dev](https://kiwiirc.com/client/irc.freenode.net/?#theforeman-dev) for development chat in [Freenode](irc.freenode.net)
+* Mailing lists:
+    * [foreman-users](https://groups.google.com/forum/?fromgroups#!forum/foreman-users)
+    * [foreman-dev](https://groups.google.com/forum/?fromgroups#!forum/foreman-dev)
+
 ## Features
 * Import facts
-* Monitor playbook and ansible runs runtime
+* Monitor playbook and Ansible runs runtime
 * Sends Ansible reports to Foreman that contain what changed on your system after an ansible run.
+* Stores a list of roles applicable to your hosts and 'plays' them
+* Looking for an Ansible dynamic inventory for Foreman? Use [foreman_ansible_inventory](https://github.com/theforeman/foreman_ansible_inventory/)
 
-## Basic usage
-
-Install `foreman_ansible` on your Foreman host. See the [Foreman manual: installing plugin from gems](http://www.theforeman.org/plugins/#2.3AdvancedInstallationfromGems)
-
-Deploy `extras/foreman_callback.py` as a callback on your Ansible installation. For instance, put in your `ansible.cfg`:
-
-```
-callback_plugins = ~/.ansible/plugins/callback_plugins/
-bin_ansible_callbacks = True
-```
-And copy `extras/foreman_callback.py` from this repo to `~/.ansible/plugins/callback_plugins/`.
-
-You can configure it via the following environment variables:
-
-* FOREMAN_URL: the URL of your Foreman installation (default "http://localhost:3000")
-* FOREMAN_SSL_CERT: The public key when using SSL client certificates (default "/etc/foreman/client_cert.pem")
-* FOREMAN_SSL_KEY: The private key when using SSL client certificates (default  "/etc/foreman/client_key.pem")
-* FOREMAN_SSL_VERIFY: wether to verify SSL certificates. Use *False*
-  to disable certificate checks. You can also set it to CA bundle (default is "True").
-
-See the [python-requests documentation](http://docs.python-requests.org/en/master/user/advanced/#ssl-cert-verification) on the details of certificate setup.
-
-That's it!
-
-Now, every time you run a playbook or  `ansible -m setup $HOSTNAME`, Ansible will automatically submit facts and a small report for $HOSTNAME to Foreman. See 'Extra information' below if you find any error.
+## Documentation (installation and configuration)
+Check out the official manual at [theforeman.org](http://theforeman.org/plugins/foreman_ansible/1.x/index.html)
 
 ##### Registering a new host in Foreman
 ![sign up gif](http://i.imgur.com/mlnVFJj.gif)
@@ -37,13 +31,18 @@ Now, every time you run a playbook or  `ansible -m setup $HOSTNAME`, Ansible wil
 ##### Host with failed and successful reports
 ![reports](http://i.imgur.com/1ySO4sh.png)
 
-### Extra information
+##### Assigning roles to a host and 'playing' them
+![role list](http://i.imgur.com/UyeZIq8.png)
+![role play](http://i.imgur.com/eU4RENK.png)
+![multiple role play](http://i.imgur.com/uoIiKJ5.png)
 
-In Foreman, you should add whatever Ansible hosts you want to submit facts from to the setting `trusted_puppetmaster_hosts`. Change it at Administer > Settings, Puppet tab.
 
-If the Foreman setting 'create_new_host_when_facts_are_uploaded' is true, and $HOSTNAME doesn't exist in Foreman, it will autocreate that host in Foreman. If it already exists, it will update the facts.
+## Compatibility
 
-Similarly, the Foreman setting 'ignore_puppet_facts_for_provisioning' is set to false, facts related to interfaces will update the interfaces of $HOSTNAME in Foreman.
+| Foreman | Plugin |
+| ---------------:| --------------:|
+| >= 1.9         | 0 - 0.3         |
+| >= 1.12        | 1.0 - TBD       |
 
 ### Devs
 
@@ -53,10 +52,6 @@ Facts must contain the output of `ansible -m setup $HOSTNAME`, plus a '_type' an
 
 After that request, you should have a host registered in Foreman with the Ansible facts. It takes into account some facter and ohai facts if these are available on the system as well.
 
-## Contributing
-
-Fork and send a Pull Request. Thanks!
-
 ## Copyright
 
 Copyright (c) Daniel Lobato Garcia
@@ -73,6 +68,3 @@ GNU General Public License for more details.
 
 You should have received a copy of the GNU General Public License
 along with this program.  If not, see <http://www.gnu.org/licenses/>.
-
-
-

data/app/controllers/foreman_ansible/concerns/hosts_controller_extensions.rb

@@ -0,0 +1,37 @@
+module ForemanAnsible
+  module Concerns
+    # Extra methods to enforce Ansible roles on a host or multiple hosts
+    module HostsControllerExtensions
+      extend ActiveSupport::Concern
+
+      def play_roles
+        find_resource
+        RolePlayer.new(@host).play
+        notice(_('Ansible roles running on background: ') +
+               @host.ansible_roles.map(&:name).join(', '))
+        redirect_to :back
+      end
+
+      def multiple_play_roles
+        find_multiple
+        @hosts.each do |host|
+          RolePlayer.new(host).play
+        end
+        notice(_('Ansible roles running on background for hosts: ') +
+               @hosts.map(&:name).join(', '))
+        redirect_to :hosts
+      end
+
+      private
+
+      def action_permission
+        case params[:action]
+        when 'multiple_play_roles', 'play_roles'
+          :view
+        else
+          super
+        end
+      end
+    end
+  end
+end

data/app/helpers/foreman_ansible/ansible_roles_helper.rb

@@ -0,0 +1,9 @@
+module ForemanAnsible
+  # Small convenience to list all roles in the UI
+  module AnsibleRolesHelper
+    def ansible_roles
+      ForemanAnsible::RolesImporter.import!
+      AnsibleRole.all
+    end
+  end
+end

data/app/helpers/foreman_ansible/hosts_helper_extensions.rb

@@ -0,0 +1,28 @@
+module ForemanAnsible
+  # Chained methods to extend the hosts menu with Ansible actions
+  module HostsHelperExtensions
+    extend ActiveSupport::Concern
+
+    included do
+      alias_method_chain(:host_title_actions, :run_ansible_roles)
+      alias_method_chain(:multiple_actions, :run_ansible_roles)
+    end
+
+    def host_title_actions_with_run_ansible_roles(*args)
+      button = link_to(
+        icon_text('play', ' ' + _('Ansible roles'), :kind => 'fa'),
+        play_roles_ansible_host_path(:id => args.first.id),
+        :id => :ansible_roles_button,
+        :class => 'btn btn-default')
+      title_actions(button_group(button)) if args.first.ansible_roles.present?
+      host_title_actions_without_run_ansible_roles(*args)
+    end
+
+    def multiple_actions_with_run_ansible_roles
+      multiple_actions_without_run_ansible_roles +
+        [[_('Play Ansible roles'),
+          multiple_play_roles_ansible_hosts_path,
+          false]]
+    end
+  end
+end

data/app/jobs/foreman_ansible/run_playbook_job.rb

@@ -0,0 +1,28 @@
+module ForemanAnsible
+  # Run the ansible-playbook binary, depends on a valid playbook and inventory
+  class RunPlaybookJob < ActiveJob::Base
+    queue_as :ansible
+    attr_reader :pid
+
+    after_perform do |job|
+      Foreman::Logging.
+        logger('foreman_ansible').
+        info('PID for playbook run for'\
+             " #{job.arguments.first} #{job.arguments.second}:"\
+             " #{pid}")
+    end
+
+    def perform(playbook_path, inventory_path)
+      @pid = spawn("ansible-playbook -i #{inventory_path} #{playbook_path}",
+                   :out => log_file,
+                   :err => log_file)
+    end
+
+    private
+
+    def log_file
+      "#{::Foreman::Logging.log_directory}/"\
+        "#{::Foreman::Logging.config[:filename]}"
+    end
+  end
+end

data/app/models/ansible_role.rb

@@ -0,0 +1,6 @@
+# Simple model to store basic info about the Ansible role
+class AnsibleRole < ActiveRecord::Base
+  validates :name, :presence => true, :uniqueness => true
+  has_many :host_ansible_roles
+  has_many_hosts :through => :host_ansible_roles, :dependent => :destroy
+end

data/app/models/concerns/foreman_ansible/host_managed_extensions.rb

@@ -0,0 +1,14 @@
+module ForemanAnsible
+  # Relations to make Host::Managed 'have' ansible roles
+  module HostManagedExtensions
+    extend ActiveSupport::Concern
+
+    included do
+      has_many :host_ansible_roles, :foreign_key => :host_id
+      has_many :ansible_roles, :through => :host_ansible_roles,
+                               :dependent => :destroy
+
+      attr_accessible :ansible_role_ids, :ansible_roles
+    end
+  end
+end

data/app/models/host_ansible_role.rb

@@ -0,0 +1,11 @@
+# Join model that hosts the connection between hosts and ansible_roles
+class HostAnsibleRole < ActiveRecord::Base
+  audited :associated_with => :host, :allow_mass_assignment => true
+  attr_accessible :host_id, :host, :ansible_role_id, :ansible_role
+
+  belongs_to_host
+  belongs_to :ansible_role
+
+  validates :ansible_role_id, :presence => true,
+                              :uniqueness => { :scope => :host_id }
+end

data/app/overrides/ansible_roles_tab.rb

@@ -0,0 +1,14 @@
+# Displays Ansible roles tab on Host form
+Deface::Override.new(
+  :virtual_path => 'hosts/_form',
+  :name => 'ansible_roles_tab',
+  :insert_after => 'li.active',
+  :partial => 'foreman_ansible/hosts/tab_title'
+)
+
+Deface::Override.new(
+  :virtual_path => 'hosts/_form',
+  :name => 'ansible_roles_tab_content',
+  :insert_after => 'div.tab-pane.active',
+  :partial => 'foreman_ansible/hosts/tab_content'
+)

data/app/services/foreman_ansible/inventory_creator.rb

@@ -0,0 +1,18 @@
+require 'securerandom'
+module ForemanAnsible
+  # Service to list an inventory to be passed to the ansible-playbook binary
+  class InventoryCreator
+    attr_reader :hosts
+
+    def initialize(hosts)
+      @hosts = hosts
+    end
+
+    def tempfile
+      tempfile = Tempfile.new("foreman-#{SecureRandom.uuid}-inventory")
+      tempfile.write(hosts.map(&:fqdn).join('\n'))
+      tempfile.close
+      tempfile
+    end
+  end
+end

data/app/services/foreman_ansible/playbook_creator.rb

@@ -0,0 +1,23 @@
+module ForemanAnsible
+  # Service to generate a playbook given roles and a list of hosts
+  class PlaybookCreator
+    attr_reader :fqdn, :role_names
+
+    def initialize(fqdn, role_names)
+      @fqdn = fqdn
+      @role_names = role_names
+    end
+
+    def roles_playbook
+      playbook = ['hosts' => fqdn, 'roles' => role_names]
+      playbook.to_yaml
+    end
+
+    def roles_tempfile
+      tempfile = Tempfile.new("foreman-ansible-#{fqdn}-roles")
+      tempfile.write(roles_playbook)
+      tempfile.close
+      tempfile
+    end
+  end
+end

data/app/services/foreman_ansible/role_player.rb

@@ -0,0 +1,26 @@
+module ForemanAnsible
+  # Sugar-coating so that playing a list of roles is easier and
+  # more understandable, it just requires a host and it figures out the rest
+  class RolePlayer
+    attr_reader :host
+
+    def initialize(host)
+      @host = host
+    end
+
+    def play
+      return if host.ansible_roles.empty?
+      inventory_tempfile = InventoryCreator.new([host]).tempfile
+      RunPlaybookJob.new(create_playbook.path,
+                         inventory_tempfile.path).enqueue
+    end
+
+    private
+
+    def create_playbook
+      PlaybookCreator.new(
+        host.fqdn,
+        host.ansible_roles.map(&:name)).roles_tempfile
+    end
+  end
+end

data/app/services/foreman_ansible/roles_importer.rb

@@ -0,0 +1,24 @@
+module ForemanAnsible
+  # Service to import roles from the filesystem.
+  # Should be extracted to a gem that both the proxy and Foreman can use.
+  class RolesImporter
+    class << self
+      def import!
+        list_roles_in_fs.each do |role_name|
+          role = AnsibleRole.new(:name => role_name)
+          next if role.save
+          Rails.logger.debug("Failed to save role #{role_name}: "\
+                            "#{role.errors.full_messages.join(', ')}")
+        end
+      end
+
+      private
+
+      def list_roles_in_fs
+        Dir.glob('/etc/ansible/roles/*').map do |path|
+          path.split('/').last
+        end
+      end
+    end
+  end
+end

data/app/views/foreman_ansible/hosts/_tab_content.html.erb

@@ -0,0 +1,4 @@
+<div class='tab-pane' id='ansible_roles'>
+  <%= multiple_checkboxes f, :ansible_roles, @host, ansible_roles,
+    :label => _('Roles') %>
+</div>

data/app/views/foreman_ansible/hosts/_tab_title.html.erb

@@ -0,0 +1 @@
+<li><a href="#ansible_roles" data-toggle="tab"><%= _('Ansible Roles') %></a></li>

data/config/routes.rb

@@ -0,0 +1,14 @@
+Rails.application.routes.draw do
+  scope :ansible, :path => '/ansible', :as => 'ansible' do
+    constraints(:id => /[^\/]+/) do
+      resources :hosts, :only => [] do
+        member do
+          get :play_roles
+        end
+        collection do
+          get :multiple_play_roles
+        end
+      end
+    end
+  end
+end

data/db/migrate/20160705082036_create_ansible_role.rb

@@ -0,0 +1,7 @@
+class CreateAnsibleRole < ActiveRecord::Migration
+  def change
+    create_table :ansible_roles do |t|
+      t.string :name, :null => false, :limit => 255
+    end
+  end
+end

data/db/migrate/20160706074540_create_join_table_hosts_ansible_roles.rb

@@ -0,0 +1,8 @@
+class CreateJoinTableHostsAnsibleRoles < ActiveRecord::Migration
+  def change
+    create_join_table :ansible_roles, :hosts do |t|
+      t.index [:host_id, :ansible_role_id]
+      t.index [:ansible_role_id, :host_id]
+    end
+  end
+end

data/db/migrate/20160707195442_create_host_ansible_roles.rb

@@ -0,0 +1,6 @@
+class CreateHostAnsibleRoles < ActiveRecord::Migration
+  def change
+    rename_table :ansible_roles_hosts, :host_ansible_roles
+    add_column :host_ansible_roles, :id, :primary_key
+  end
+end

data/db/seeds.d/62-ansible_proxy_feature.rb

@@ -0,0 +1,4 @@
+proxy_feature = Feature.where(:name => 'Ansible').first_or_create
+if proxy_feature.nil? || proxy_feature.errors.any?
+  raise "Unable to create proxy feature: #{format_errors proxy_feature}"
+end

data/lib/foreman_ansible/engine.rb

@@ -4,6 +4,7 @@ module ForemanAnsible
   class Engine < ::Rails::Engine
     engine_name 'foreman_ansible'
 
+    config.autoload_paths += Dir["#{config.root}/app/controllers/concerns"]
     config.autoload_paths += Dir["#{config.root}/app/helpers"]
     config.autoload_paths += Dir["#{config.root}/app/overrides"]
     config.autoload_paths += Dir["#{config.root}/app/services"]
@@ -11,7 +12,15 @@ module ForemanAnsible
 
     initializer 'foreman_ansible.register_plugin', :before => :finisher_hook do
       Foreman::Plugin.register :foreman_ansible do
-        requires_foreman '>= 1.9'
+        # We need ActiveJob, only available post-1.12 because of Rails 4.2
+        requires_foreman '>= 1.12'
+      end
+    end
+
+    # Add any db migrations
+    initializer 'foreman_remote_execution.load_app_instance_data' do |app|
+      ForemanAnsible::Engine.paths['db/migrate'].existent.each do |path|
+        app.config.paths['db/migrate'] << path
       end
     end
 
@@ -20,6 +29,10 @@ module ForemanAnsible
         ::FactImporter.register_fact_importer(:ansible,
                                               ForemanAnsible::FactImporter)
         ::FactParser.register_fact_parser(:ansible, ForemanAnsible::FactParser)
+        ::Host::Managed.send(:include, ForemanAnsible::HostManagedExtensions)
+        ::HostsHelper.send(:include, ForemanAnsible::HostsHelperExtensions)
+        ::HostsController.send(
+          :include, ForemanAnsible::Concerns::HostsControllerExtensions)
       rescue => e
         Rails.logger "Foreman Ansible: skipping engine hook (#{e})"
       end

data/lib/foreman_ansible/version.rb

@@ -2,5 +2,5 @@
 # This way other parts of Foreman can just call ForemanAnsible::VERSION
 # and detect what version the plugin is running.
 module ForemanAnsible
-  VERSION = '0.3'
+  VERSION = '1.0'
 end

data/lib/tasks/foreman_ansible_tasks.rake

@@ -5,7 +5,8 @@ namespace :test do
     test_dir = File.join(File.dirname(__FILE__), '../..', 'test')
     t.libs << ['test', test_dir]
     t.pattern = "#{test_dir}/**/*_test.rb"
-    t.verbose = true
+    t.verbose = false
+    t.warning = false
   end
 end
 

data/test/factories/ansible_roles.rb

@@ -0,0 +1,5 @@
+FactoryGirl.define do
+  factory :ansible_role, :class => ForemanAnsible::AnsibleRole do
+    sequence(:name) { |n| "ansible_role_#{n}"}
+  end
+end

data/test/functional/hosts_controller_test.rb

@@ -0,0 +1,36 @@
+require 'test_plugin_helper'
+
+class HostsControllerExtensionsTest < ActionController::TestCase
+  tests ::HostsController
+
+  setup do
+    @role = FactoryGirl.create(:ansible_role)
+  end
+
+  test 'create a host with ansible roles' do
+    host = { :name => 'foo',
+             :managed => false,
+             :ansible_role_ids => [@role.id] }
+    post :create, { :host => host },
+      set_session_user
+    assert_redirected_to host_url(assigns('host'))
+    assert assigns('host').ansible_roles, [@role]
+  end
+
+  test 'update a host with ansible roles' do
+    host = FactoryGirl.create(:host, :managed => false)
+    post :update, { :id => host.id, :ansible_role_ids => [@role.id] },
+      set_session_user
+    assert_redirected_to host_url(assigns('host'))
+    assert assigns('host').ansible_roles, [@role]
+  end
+
+  test 'delete a host with ansible roles' do
+    host = FactoryGirl.create(:host, :managed => false,
+                              :ansible_roles => [@role])
+    assert_include @role.hosts, host
+    delete :destroy, { :id => host.id }, set_session_user
+    assert_redirected_to hosts_url
+    assert @role.hosts.empty?
+  end
+end

data/test/test_plugin_helper.rb

@@ -8,3 +8,7 @@ end
 def facts_json
   HashWithIndifferentAccess.new(JSON.parse(sample_facts_file))
 end
+
+plugin_factories_path = File.join(File.dirname(__FILE__), 'factories')
+FactoryGirl.definition_file_paths << plugin_factories_path
+FactoryGirl.reload

data/test/unit/ansible_role_test.rb

@@ -0,0 +1,8 @@
+ require 'test_plugin_helper'
+
+class AnsibleRoleTest < ActiveSupport::TestCase
+  should have_many(:host_ansible_roles)
+  should have_many(:hosts).through(:host_ansible_roles).dependent(:destroy)
+  should validate_presence_of(:name)
+  should validate_uniqueness_of(:name)
+end

data/test/unit/host_ansible_role_test.rb

@@ -0,0 +1,7 @@
+require 'test_plugin_helper'
+
+class HostAnsibleRoleTest < ActiveSupport::TestCase
+  should belong_to(:host)
+  should belong_to(:ansible_role)
+  should validate_presence_of(:ansible_role_id)
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman_ansible
 version: !ruby/object:Gem::Version
-  version: '0.3'
+  version: '1.0'
 platform: ruby
 authors:
 - Daniel Lobato Garcia
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-10 00:00:00.000000000 Z
+date: 2016-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -48,14 +48,33 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- app/controllers/foreman_ansible/concerns/hosts_controller_extensions.rb
 - app/helpers/foreman_ansible/ansible_reports_helper.rb
+- app/helpers/foreman_ansible/ansible_roles_helper.rb
+- app/helpers/foreman_ansible/hosts_helper_extensions.rb
+- app/jobs/foreman_ansible/run_playbook_job.rb
+- app/models/ansible_role.rb
+- app/models/concerns/foreman_ansible/host_managed_extensions.rb
 - app/models/foreman_ansible/fact_name.rb
+- app/models/host_ansible_role.rb
+- app/overrides/ansible_roles_tab.rb
 - app/overrides/report_output.rb
 - app/services/foreman_ansible/fact_importer.rb
 - app/services/foreman_ansible/fact_parser.rb
 - app/services/foreman_ansible/fact_sparser.rb
+- app/services/foreman_ansible/inventory_creator.rb
+- app/services/foreman_ansible/playbook_creator.rb
+- app/services/foreman_ansible/role_player.rb
+- app/services/foreman_ansible/roles_importer.rb
 - app/views/foreman_ansible/config_reports/_ansible.html.erb
 - app/views/foreman_ansible/config_reports/_output.html.erb
+- app/views/foreman_ansible/hosts/_tab_content.html.erb
+- app/views/foreman_ansible/hosts/_tab_title.html.erb
+- config/routes.rb
+- db/migrate/20160705082036_create_ansible_role.rb
+- db/migrate/20160706074540_create_join_table_hosts_ansible_roles.rb
+- db/migrate/20160707195442_create_host_ansible_roles.rb
+- db/seeds.d/62-ansible_proxy_feature.rb
 - lib/foreman_ansible.rb
 - lib/foreman_ansible/engine.rb
 - lib/foreman_ansible/version.rb
@@ -64,12 +83,16 @@ files:
 - locale/en/foreman_ansible.po
 - locale/foreman_ansible.pot
 - locale/gemspec.rb
+- test/factories/ansible_roles.rb
 - test/fixtures/sample_facts.json
+- test/functional/hosts_controller_test.rb
 - test/test_plugin_helper.rb
+- test/unit/ansible_role_test.rb
 - test/unit/fact_importer_test.rb
 - test/unit/fact_parser_test.rb
 - test/unit/fact_sparser_test.rb
 - test/unit/helpers/foreman_ansible/ansible_reports_helper_test.rb
+- test/unit/host_ansible_role_test.rb
 homepage: https://github.com/theforeman/foreman_ansible
 licenses:
 - GPL-3
@@ -96,8 +119,12 @@ specification_version: 4
 summary: Ansible integration with Foreman (theforeman.org)
 test_files:
 - test/fixtures/sample_facts.json
+- test/factories/ansible_roles.rb
+- test/functional/hosts_controller_test.rb
 - test/test_plugin_helper.rb
 - test/unit/fact_parser_test.rb
+- test/unit/host_ansible_role_test.rb
+- test/unit/ansible_role_test.rb
 - test/unit/fact_importer_test.rb
 - test/unit/fact_sparser_test.rb
 - test/unit/helpers/foreman_ansible/ansible_reports_helper_test.rb