foreman_acd 0.9.7 → 0.11.0

data/webpack/components/ExistingHostSelection/__fixtures__/existingHostSelectionReducer.fixtures.js

@@ -1,15 +1,8 @@
 import Immutable from 'seamless-immutable';
-import {
-   cloneDeep,
-   findIndex,
-   findLastIndex,
-} from 'lodash';
 
-import {
-  existingHostSelectionConfData_1,
-} from '../__fixtures__/existingHostSelectionConfData_1.fixtures';
+import { existingHostSelectionConfData1 } from '../__fixtures__/existingHostSelectionConfData1.fixtures';
 
-export const successState = Immutable(existingHostSelectionConfData_1);
+export const successState = Immutable(existingHostSelectionConfData1);
 
 export const initExistingHostSelectionPayload = {
   payload: {
@@ -19,12 +12,12 @@ export const initExistingHostSelectionPayload = {
         value: 5,
         label: 'isaac-anselm',
         disabled: true,
-        tooltipText: 'Host already used for this application instance'
-      }
+        tooltipText: 'Host already used for this application instance',
+      },
     ],
     selectedHosts: [],
     hostsInHostgroup: {},
-  }
+  },
 };
 
 export const existingHostSelectionSelectionChangedPayload = {
@@ -33,7 +26,7 @@ export const existingHostSelectionSelectionChangedPayload = {
       label: 'isaar-anselm',
       value: 3,
     },
-  ]
+  ],
 };
 
 export const loadExistingHostSelectionSuccessPayload = {
@@ -84,9 +77,7 @@ export const loadExistingHostSelectionSuccessPayload = {
       compute_resource_name: null,
       compute_profile_id: null,
       compute_profile_name: null,
-      capabilities: [
-        'build'
-      ],
+      capabilities: ['build'],
       provision_method: 'build',
       certname: 'isaac-anselm.mylocal',
       image_id: null,
@@ -114,7 +105,7 @@ export const loadExistingHostSelectionSuccessPayload = {
       puppet_proxy: null,
       puppet_ca_proxy: null,
       hostgroup_name: 'base',
-      hostgroup_title: 'base'
+      hostgroup_title: 'base',
     },
     {
       ip: null,
@@ -162,9 +153,7 @@ export const loadExistingHostSelectionSuccessPayload = {
       compute_resource_name: null,
       compute_profile_id: null,
       compute_profile_name: null,
-      capabilities: [
-        'build'
-      ],
+      capabilities: ['build'],
       provision_method: 'build',
       certname: 'lllllll.mylocal',
       image_id: null,
@@ -192,12 +181,12 @@ export const loadExistingHostSelectionSuccessPayload = {
       puppet_proxy: null,
       puppet_ca_proxy: null,
       hostgroup_name: 'base',
-      hostgroup_title: 'base'
-    }
+      hostgroup_title: 'base',
+    },
   ],
-  serviceId: 1
+  serviceId: 1,
 };
 
 export const loadExistingHostSelectionFailurePayload = {
-  error: "Something really bad happend",
+  error: 'Something really bad happend',
 };

data/webpack/components/ExistingHostSelection/__tests__/ExistingHostSelection.test.js

@@ -6,12 +6,13 @@ const noop = () => {};
 
 const fixtures = {
   'should render existing host selection': {
-    location: "Default Location",
-    organization: "Default Organization",
+    location: 'Default Location',
+    organization: 'Default Organization',
     services: [],
     allHosts: [],
     initExistingHostSelection: noop,
     loadHostsOfHostgroup: noop,
+    hostSelectionChanged: noop,
   },
 };
 

data/webpack/components/ExistingHostSelection/__tests__/ExistingHostSelectionSelectors.test.js

@@ -8,9 +8,7 @@ import {
   selectHostsInHostgroup,
 } from '../ExistingHostSelectionSelectors';
 
-import {
-  existingHostSelectionConfData_1,
-} from '../__fixtures__/existingHostSelectionConfData_1.fixtures';
+import { existingHostSelectionConfData1 } from '../__fixtures__/existingHostSelectionConfData1.fixtures';
 
 const stateFactory = obj => ({
   foremanAcd: {
@@ -19,18 +17,17 @@ const stateFactory = obj => ({
 });
 
 const fixtures = {
-  'should return serviceId from existingHostSelectionConfData_1 fixtures': () =>
-    selectServiceId(stateFactory(existingHostSelectionConfData_1)),
-  'should return availableHosts from existingHostSelectionConfData_1 fixtures': () =>
-    selectAvailableHosts(stateFactory(existingHostSelectionConfData_1)),
-  'should return alreadyUsedHosts from existingHostSelectionConfData_1 fixtures': () =>
-    selectAlreadyUsedHosts(stateFactory(existingHostSelectionConfData_1)),
-  'should return selectedHosts from existingHostSelectionConfData_1 fixtures': () =>
-    selectSelectedHosts(stateFactory(existingHostSelectionConfData_1)),
-  'should return hostsInHostgroup from existingHostSelectionConfData_1 fixtures': () =>
-    selectHostsInHostgroup(stateFactory(existingHostSelectionConfData_1)),
+  'should return serviceId from existingHostSelectionConfData1 fixtures': () =>
+    selectServiceId(stateFactory(existingHostSelectionConfData1)),
+  'should return availableHosts from existingHostSelectionConfData1 fixtures': () =>
+    selectAvailableHosts(stateFactory(existingHostSelectionConfData1)),
+  'should return alreadyUsedHosts from existingHostSelectionConfData1 fixtures': () =>
+    selectAlreadyUsedHosts(stateFactory(existingHostSelectionConfData1)),
+  'should return selectedHosts from existingHostSelectionConfData1 fixtures': () =>
+    selectSelectedHosts(stateFactory(existingHostSelectionConfData1)),
+  'should return hostsInHostgroup from existingHostSelectionConfData1 fixtures': () =>
+    selectHostsInHostgroup(stateFactory(existingHostSelectionConfData1)),
 };
 
 describe('ExistingHostSelectionSelectors', () =>
   testSelectorsSnapshotWithFixtures(fixtures));
-

data/webpack/components/ExistingHostSelection/__tests__/__snapshots__/ExistingHostSelectionSelectors.test.js.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`ExistingHostSelectionSelectors should return alreadyUsedHosts from existingHostSelectionConfData_1 fixtures 1`] = `
+exports[`ExistingHostSelectionSelectors should return alreadyUsedHosts from existingHostSelectionConfData1 fixtures 1`] = `
 Array [
   Object {
     "disabled": true,
@@ -11,7 +11,7 @@ Array [
 ]
 `;
 
-exports[`ExistingHostSelectionSelectors should return availableHosts from existingHostSelectionConfData_1 fixtures 1`] = `
+exports[`ExistingHostSelectionSelectors should return availableHosts from existingHostSelectionConfData1 fixtures 1`] = `
 Array [
   Object {
     "label": "lllllll",
@@ -20,8 +20,8 @@ Array [
 ]
 `;
 
-exports[`ExistingHostSelectionSelectors should return hostsInHostgroup from existingHostSelectionConfData_1 fixtures 1`] = `undefined`;
+exports[`ExistingHostSelectionSelectors should return hostsInHostgroup from existingHostSelectionConfData1 fixtures 1`] = `undefined`;
 
-exports[`ExistingHostSelectionSelectors should return selectedHosts from existingHostSelectionConfData_1 fixtures 1`] = `Array []`;
+exports[`ExistingHostSelectionSelectors should return selectedHosts from existingHostSelectionConfData1 fixtures 1`] = `Array []`;
 
-exports[`ExistingHostSelectionSelectors should return serviceId from existingHostSelectionConfData_1 fixtures 1`] = `2`;
+exports[`ExistingHostSelectionSelectors should return serviceId from existingHostSelectionConfData1 fixtures 1`] = `2`;

data/webpack/components/ExistingHostSelection/components/ServiceSelector.js

@@ -1,9 +1,9 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import ExtSelect from '../../common/ExtSelect';
-import RailsData from '../../common/RailsData'
+import RailsData from '../../common/RailsData';
 
-const ServiceSelector= ({
+const ServiceSelector = ({
   label,
   hidden,
   viewText,
@@ -11,32 +11,31 @@ const ServiceSelector= ({
   onChange,
   options,
   additionalData,
-}) =>{
-  return (
-    <div className="form-group">
-      <label className="col-md-2 control-label">{label}</label>
-      <div className="col-md-4">
-        <ExtSelect
-          hidden={hidden}
-          editable={true}
-          viewText={viewText}
-          selectValue={selectValue}
-          onChange={onChange}
-          options={options}
-          additionalData={additionalData}
-        />
-        <RailsData
-          key='service_id'
-          view='existing_host_selection'
-          parameter='service_id'
-          value={selectValue}
-        />
-      </div>
+}) => (
+  <div className="form-group">
+    <label className="col-md-2 control-label">{label}</label>
+    <div className="col-md-4">
+      <ExtSelect
+        hidden={hidden}
+        editable
+        viewText={viewText}
+        selectValue={selectValue}
+        onChange={onChange}
+        options={options}
+        additionalData={additionalData}
+      />
+      <RailsData
+        key="service_id"
+        view="existing_host_selection"
+        parameter="service_id"
+        value={selectValue}
+      />
     </div>
-  );
-};
+  </div>
+);
 
 ServiceSelector.propTypes = {
+  hidden: PropTypes.bool.isRequired,
   label: PropTypes.string.isRequired,
   viewText: PropTypes.string,
   selectValue: PropTypes.string,
@@ -45,4 +44,11 @@ ServiceSelector.propTypes = {
   additionalData: PropTypes.object,
 };
 
+ServiceSelector.defaultProps = {
+  additionalData: {},
+  options: {},
+  selectValue: '',
+  viewText: undefined,
+};
+
 export default ServiceSelector;

data/webpack/components/ExistingHostSelection/components/__tests__/ServiceSelector.test.js

@@ -4,11 +4,6 @@ import ServiceSelector from '../ServiceSelector';
 
 const noop = () => {};
 
-const data = [
-  { name: 'report 1', status: 'done' },
-  { name: 'report 2', status: 'pending' }
-];
-
 const fixtures = {
   'should render the service selector': {
     hidden: false,
@@ -16,7 +11,7 @@ const fixtures = {
     viewText: 'view service',
     selectValue: '1',
     onChange: noop,
-    options: { first: 'first', second: 'second'},
+    options: { first: 'first', second: 'second' },
     additionalData: { moreData: 'moooore' },
   },
   'should render the hidden service selector': {
@@ -25,11 +20,10 @@ const fixtures = {
     viewText: 'view service',
     selectValue: '1',
     onChange: noop,
-    options: { first: 'first', second: 'second'},
-    additionalData: { },
+    options: { first: 'first', second: 'second' },
+    additionalData: {},
   },
 };
 
 describe('ServiceSelector', () =>
   testComponentSnapshotsWithFixtures(ServiceSelector, fixtures));
-