foreman_acd 0.9.5 → 0.10.0

data/webpack/components/common/ExtTextInput.js

@@ -2,14 +2,14 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import TextInput from 'foremanReact/components/common/forms/TextInput';
 
-const ExtTextInput= ({
+const ExtTextInput = ({
   hidden,
   editable,
   viewText,
   label,
   onChange,
   additionalData,
-}) =>{
+}) => {
   if (hidden) {
     return null;
   }
@@ -17,17 +17,17 @@ const ExtTextInput= ({
   if (!editable) {
     return (
       <div className="form-group">
-       <label className="col-md-2 control-label">{label}</label>
-       <div className="col-md-4">{viewText}</div>
+        <label className="col-md-2 control-label">{label}</label>
+        <div className="col-md-4">{viewText}</div>
       </div>
     );
   }
 
   return (
     <TextInput
-       label={label}
-       value={viewText}
-       onChange={e => onChange(e.target.value, additionalData) }
+      label={label}
+      value={viewText}
+      onChange={e => onChange(e.target.value, additionalData)}
     />
   );
 };
@@ -36,8 +36,13 @@ ExtTextInput.propTypes = {
   hidden: PropTypes.bool.isRequired,
   editable: PropTypes.bool.isRequired,
   viewText: PropTypes.string,
+  label: PropTypes.string.isRequired,
   onChange: PropTypes.func.isRequired,
   additionalData: PropTypes.object,
 };
+ExtTextInput.defaultProps = {
+  viewText: '',
+  additionalData: {},
+};
 
 export default ExtTextInput;

data/webpack/components/common/LockTableEntry.js

@@ -1,9 +1,6 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import {
-  Icon,
-  Button,
-} from 'patternfly-react';
+import { Icon, Button } from 'patternfly-react';
 import { translate as __ } from 'foremanReact/common/I18n';
 
 const LockTableEntry = ({
@@ -11,7 +8,7 @@ const LockTableEntry = ({
   disabled,
   onLockTableEntry,
   additionalData,
-}) =>{
+}) => {
   if (hidden) {
     return null;
   }
@@ -42,7 +39,7 @@ const LockTableEntry = ({
       <Button
         bsStyle="default"
         disabled={disabled}
-        onClick={() => onLockTableEntry(additionalData) }
+        onClick={() => onLockTableEntry(additionalData)}
       >
         <Icon type="pf" name={lockButton} title={__(lockButtonTitle)} />
       </Button>
@@ -56,5 +53,8 @@ LockTableEntry.propTypes = {
   onLockTableEntry: PropTypes.func.isRequired,
   additionalData: PropTypes.object.isRequired,
 };
+LockTableEntry.defaultProps = {
+  hidden: false,
+};
 
 export default LockTableEntry;

data/webpack/components/common/RailsData.js

@@ -1,27 +1,17 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 
-const RailsData = ({
-  view,
-  parameter,
-  value,
-}) => {
-  const id = "foreman_acd_"+ view +"_"+ parameter;
-  const name = "foreman_acd_"+ view +"["+ parameter +"]";
+const RailsData = ({ view, parameter, value }) => {
+  const id = `foreman_acd_${view}_${parameter}`;
+  const name = `foreman_acd_${view}[${parameter}]`;
 
-  return (
-    <input
-      id={id}
-      name={name}
-      value={value}
-      type="hidden"
-    />
-  );
-}
+  return <input id={id} name={name} value={value} type="hidden" />;
+};
 
 RailsData.propTypes = {
   view: PropTypes.string.isRequired,
   parameter: PropTypes.string.isRequired,
+  value: PropTypes.string.isRequired,
 };
 
 export default RailsData;

data/webpack/components/common/__tests__/ExtSelect.test.js

@@ -11,7 +11,7 @@ const fixtures = {
     viewText: '',
     selectValue: '1',
     onChange: noop,
-    options: { first: 'first', second: 'second'},
+    options: { first: 'first', second: 'second' },
     additionalData: { moreData: 'moooore' },
   },
   'should render hidden selection field': {
@@ -29,7 +29,7 @@ const fixtures = {
     viewText: 'Awesome Text',
     selectValue: '0',
     onChange: noop,
-    options: { first: 'first', second: 'second'},
+    options: { first: 'first', second: 'second' },
     additionalData: {},
   },
 };

data/webpack/components/common/__tests__/RailsData.test.js

@@ -2,8 +2,6 @@ import { testComponentSnapshotsWithFixtures } from 'react-redux-test-utils';
 
 import RailsData from '../RailsData';
 
-const noop = () => {};
-
 const fixtures = {
   'should render rails data input field': {
     view: 'nice_view',

data/webpack/global_test_setup.js

@@ -0,0 +1,11 @@
+// runs before each test to make sure console.error output will
+// fail a test (i.e. default PropType missing). Check the error
+// output and traceback for actual error.
+global.console.error = (error, stack) => {
+  /* eslint-disable-next-line no-console */
+  if (stack) console.log(stack); // Prints out original stack trace
+  throw new Error(error);
+};
+
+// Increase jest timeout as some tests using multiple http mocks can time out on CI systems.
+jest.setTimeout(10000);

data/webpack/helper.js

@@ -1,21 +1,11 @@
 import React from 'react';
-import {
-  Table,
-} from 'patternfly-react';
+import { Table } from 'patternfly-react';
 
 // Some small helper methods
 
 function arrayToObject(arr, id, value) {
-  var rv = {};
-  for (var i = 0; i < arr.length; ++i)
-    rv[arr[i][id]] = arr[i][value];
-  return rv;
-}
-
-function arrayToObjectObj(arr, id) {
-  var rv = {};
-  for (var i = 0; i < arr.length; ++i)
-    rv[arr[i][id]] = arr[i];
+  const rv = {};
+  for (let i = 0; i < arr.length; ++i) rv[arr[i][id]] = arr[i][value];
   return rv;
 }
 
@@ -26,20 +16,20 @@ function shortHostname(fqdn) {
 function EasyHeaderFormatter(value, { column }) {
   return (
     <Table.Heading aria-label={column.header.label} {...column.header.props}>
-    {value}
+      {value}
     </Table.Heading>
   );
 }
 
 function supportedPluginsToHiddenParameterTypes(supportedPlugins) {
-  let hiddenParameterTypes = [];
+  const hiddenParameterTypes = [];
 
-  if (supportedPlugins['puppet'] == false) {
-    hiddenParameterTypes.push("puppetenv");
+  if (supportedPlugins.puppet === false) {
+    hiddenParameterTypes.push('puppetenv');
   }
 
-  if (supportedPlugins['katello'] == false) {
-    hiddenParameterTypes.push("lifecycleenv");
+  if (supportedPlugins.katello === false) {
+    hiddenParameterTypes.push('lifecycleenv');
   }
 
   return hiddenParameterTypes;
@@ -47,8 +37,7 @@ function supportedPluginsToHiddenParameterTypes(supportedPlugins) {
 
 export {
   arrayToObject,
-  arrayToObjectObj,
   shortHostname,
   EasyHeaderFormatter,
-  supportedPluginsToHiddenParameterTypes
+  supportedPluginsToHiddenParameterTypes,
 };

data/webpack/helper.test.js

@@ -1,56 +1,44 @@
 import {
   arrayToObject,
-  arrayToObjectObj,
   EasyHeaderFormatter,
   supportedPluginsToHiddenParameterTypes,
 } from './helper';
 
 describe('helper', () => {
-  const testArray = []
+  const testArray = [];
   testArray[0] = { id: 'i1', value: 'v1' };
   testArray[1] = { id: 'i2', value: 'v2' };
   testArray[2] = { id: 'i3', value: 'v3' };
 
-  it('creates a object from an array', () => {
-    expect(arrayToObject(testArray, 'id', 'value')).toEqual(
-      {
-        i1: 'v1',
-        i2: 'v2',
-        i3: 'v3'
-      }
-    );
-  });
-
-  it('creates a object from an array', () => {
-    expect(arrayToObjectObj(testArray, 'id')).toEqual(
-      {
-        i1: { id: 'i1', value: 'v1' },
-        i2: { id: 'i2', value: 'v2' },
-        i3: { id: 'i3', value: 'v3' },
-      }
-    );
+  it('creates an object from an array and select value', () => {
+    expect(arrayToObject(testArray, 'id', 'value')).toEqual({
+      i1: 'v1',
+      i2: 'v2',
+      i3: 'v3',
+    });
   });
 
   it('formats a nice, easy header', () => {
-    expect(EasyHeaderFormatter('MyValue', { column: { header: { label: 'TheLabel', props: { p1: '1' } } } })).toMatchSnapshot();
+    expect(
+      EasyHeaderFormatter('MyValue', {
+        column: { header: { label: 'TheLabel', props: { p1: '1' } } },
+      })
+    ).toMatchSnapshot();
   });
 
   it('creates hidden parameter definition by supported plugins 1', () => {
-    expect(supportedPluginsToHiddenParameterTypes({ puppet: false})).toEqual(
-      ['puppetenv']
-    );
+    expect(supportedPluginsToHiddenParameterTypes({ puppet: false })).toEqual([
+      'puppetenv',
+    ]);
   });
 
   it('creates hidden parameter definition by supported plugins 2', () => {
-    expect(supportedPluginsToHiddenParameterTypes({ puppet: true})).toEqual(
+    expect(supportedPluginsToHiddenParameterTypes({ puppet: true })).toEqual(
       []
     );
   });
 
   it('creates hidden parameter definition by supported plugins 3', () => {
-    expect(supportedPluginsToHiddenParameterTypes({})).toEqual(
-      []
-    );
+    expect(supportedPluginsToHiddenParameterTypes({})).toEqual([]);
   });
 });
-

data/webpack/index.js

@@ -12,10 +12,28 @@ import reducer from './reducer';
 
 injectReducer('foremanAcd', reducer);
 
-componentRegistry.register({ name: 'ParameterSelection', type: ParameterSelection, });
-componentRegistry.register({ name: 'SyncGitRepo', type: SyncGitRepo, });
-componentRegistry.register({ name: 'ApplicationDefinition', type: ApplicationDefinition, });
-componentRegistry.register({ name: 'ApplicationDefinitionImport', type: ApplicationDefinitionImport, });
-componentRegistry.register({ name: 'ApplicationInstance', type: ApplicationInstance, });
-componentRegistry.register({ name: 'ApplicationInstanceReport', type: ApplicationInstanceReport, });
-componentRegistry.register({ name: 'ExistingHostSelection', type: ExistingHostSelection, });
+componentRegistry.register({
+  name: 'ParameterSelection',
+  type: ParameterSelection,
+});
+componentRegistry.register({ name: 'SyncGitRepo', type: SyncGitRepo });
+componentRegistry.register({
+  name: 'ApplicationDefinition',
+  type: ApplicationDefinition,
+});
+componentRegistry.register({
+  name: 'ApplicationDefinitionImport',
+  type: ApplicationDefinitionImport,
+});
+componentRegistry.register({
+  name: 'ApplicationInstance',
+  type: ApplicationInstance,
+});
+componentRegistry.register({
+  name: 'ApplicationInstanceReport',
+  type: ApplicationInstanceReport,
+});
+componentRegistry.register({
+  name: 'ExistingHostSelection',
+  type: ExistingHostSelection,
+});