foreman-tasks 9.1.0 → 9.2.0

data/test/unit/recurring_logic_test.rb

@@ -4,17 +4,17 @@ class RecurringLogicsTest < ActiveSupport::TestCase
   describe 'generating times' do
     it 'assembles cronline' do
       hash = {}
-      _(ForemanTasks::RecurringLogic.assemble_cronline(hash)).must_equal '* * * * *'
+      assert_equal '* * * * *', ForemanTasks::RecurringLogic.assemble_cronline(hash)
       hash.update :minutes => '*'
-      _(ForemanTasks::RecurringLogic.assemble_cronline(hash)).must_equal '* * * * *'
+      assert_equal '* * * * *', ForemanTasks::RecurringLogic.assemble_cronline(hash)
       hash.update :hours => '0,12'
-      _(ForemanTasks::RecurringLogic.assemble_cronline(hash)).must_equal '* 0,12 * * *'
+      assert_equal '* 0,12 * * *', ForemanTasks::RecurringLogic.assemble_cronline(hash)
       hash.update :days => '*/2'
-      _(ForemanTasks::RecurringLogic.assemble_cronline(hash)).must_equal '* 0,12 */2 * *'
+      assert_equal '* 0,12 */2 * *', ForemanTasks::RecurringLogic.assemble_cronline(hash)
       hash.update :months => '12'
-      _(ForemanTasks::RecurringLogic.assemble_cronline(hash)).must_equal '* 0,12 */2 12 *'
+      assert_equal '* 0,12 */2 12 *', ForemanTasks::RecurringLogic.assemble_cronline(hash)
       hash.update :days_of_week => '1,2,3,4,5,6,7'
-      _(ForemanTasks::RecurringLogic.assemble_cronline(hash)).must_equal '* 0,12 */2 12 1,2,3,4,5,6,7'
+      assert_equal '* 0,12 */2 12 1,2,3,4,5,6,7', ForemanTasks::RecurringLogic.assemble_cronline(hash)
     end
 
     it 'generates correct times' do
@@ -25,17 +25,17 @@ class RecurringLogicsTest < ActiveSupport::TestCase
       minute = 0
       reference_time = Time.utc(year, month, day, hour, minute)
       parser = ForemanTasks::RecurringLogic.new_from_cronline('* * * * *')
-      _(parser.next_occurrence_time(reference_time)).must_equal Time.utc(year, month, day, hour, minute)
+      assert_equal Time.utc(year, month, day, hour, minute), parser.next_occurrence_time(reference_time)
       parser = ForemanTasks::RecurringLogic.new_from_cronline('*/2 * * * *')
-      _(parser.next_occurrence_time(reference_time)).must_equal Time.utc(year, month, day, hour, minute)
+      assert_equal Time.utc(year, month, day, hour, minute), parser.next_occurrence_time(reference_time)
       parser = ForemanTasks::RecurringLogic.new_from_cronline('*/2 18,19 * * *')
-      _(parser.next_occurrence_time(reference_time)).must_equal Time.utc(year, month, day, 18)
+      assert_equal Time.utc(year, month, day, 18), parser.next_occurrence_time(reference_time)
       parser = ForemanTasks::RecurringLogic.new_from_cronline('*/2 18,19 10 * *')
-      _(parser.next_occurrence_time(reference_time)).must_equal Time.utc(year, month + 1, 10, 18, minute)
+      assert_equal Time.utc(year, month + 1, 10, 18, minute), parser.next_occurrence_time(reference_time)
       parser = ForemanTasks::RecurringLogic.new_from_cronline('*/2 18,19 10 11,12 *')
-      _(parser.next_occurrence_time(reference_time)).must_equal Time.utc(year, 11, 10, 18, 0)
+      assert_equal Time.utc(year, 11, 10, 18, 0), parser.next_occurrence_time(reference_time)
       parser = ForemanTasks::RecurringLogic.new_from_cronline('* * * * 1')
-      _(parser.next_occurrence_time(reference_time)).must_equal Time.utc(year, month + 1, 5)
+      assert_equal Time.utc(year, month + 1, 5), parser.next_occurrence_time(reference_time)
     end
 
     it 'creates correct cronline hash' do
@@ -48,10 +48,10 @@ class RecurringLogicsTest < ActiveSupport::TestCase
       expected_result_daily = { :minutes => minutes, :hours => hours }
       expected_result_weekly = { :minutes => minutes, :hours => hours, :days_of_week => '1,4,6' }
       expected_result_monthly = { :minutes => minutes, :hours => hours, :days => days }
-      _(ForemanTasks::RecurringLogic.cronline_hash(:hourly,  time_hash, days, days_of_week)).must_equal expected_result_hourly
-      _(ForemanTasks::RecurringLogic.cronline_hash(:daily,   time_hash, days, days_of_week)).must_equal expected_result_daily
-      _(ForemanTasks::RecurringLogic.cronline_hash(:weekly,  time_hash, days, days_of_week)).must_equal expected_result_weekly
-      _(ForemanTasks::RecurringLogic.cronline_hash(:monthly, time_hash, days, days_of_week)).must_equal expected_result_monthly
+      assert_equal expected_result_hourly, ForemanTasks::RecurringLogic.cronline_hash(:hourly, time_hash, days, days_of_week)
+      assert_equal expected_result_daily, ForemanTasks::RecurringLogic.cronline_hash(:daily, time_hash, days, days_of_week)
+      assert_equal expected_result_weekly, ForemanTasks::RecurringLogic.cronline_hash(:weekly, time_hash, days, days_of_week)
+      assert_equal expected_result_monthly, ForemanTasks::RecurringLogic.cronline_hash(:monthly, time_hash, days, days_of_week)
     end
 
     it 'validates cronline correctly' do
@@ -68,18 +68,18 @@ class RecurringLogicsTest < ActiveSupport::TestCase
     it 'can have limited number of repeats' do
       parser = ForemanTasks::RecurringLogic.new_from_cronline('* * * * *')
       parser.state = 'active'
-      _(parser).must_be :can_continue?
+      assert parser.can_continue?
       parser.max_iteration = 5
       parser.expects(:iteration).twice.returns(5)
-      _(parser).wont_be :can_continue?
+      assert_not parser.can_continue?
       parser.max_iteration = nil
       time = Time.utc(2015, 9, 29, 15, 0)
       parser.end_time = time
-      _(parser).wont_be :can_continue?, time
+      assert_not parser.can_continue?(time)
       parser.end_time = time + 120
-      _(parser).must_be :can_continue?, time
+      assert parser.can_continue?(time)
       parser.max_iteration = 5
-      _(parser).wont_be :can_continue?, time
+      assert_not parser.can_continue?(time)
     end
 
     it 'generates delay options' do
@@ -87,9 +87,8 @@ class RecurringLogicsTest < ActiveSupport::TestCase
       parser.stubs(:id).returns(1)
       reference_time = Time.utc(2015, 9, 29, 15)
       expected_hash = { :start_at => reference_time, :start_before => nil, :recurring_logic_id => parser.id, :frozen => false }
-      _(parser.generate_delay_options(reference_time)).must_equal expected_hash
-      _(parser.generate_delay_options(reference_time, 'start_before' => reference_time + 3600))
-        .must_equal expected_hash.merge(:start_before => reference_time + 3600)
+      assert_equal expected_hash, parser.generate_delay_options(reference_time)
+      assert_equal expected_hash.merge(:start_before => reference_time + 3600), parser.generate_delay_options(reference_time, 'start_before' => reference_time + 3600)
     end
 
     it 'can start' do
@@ -119,19 +118,19 @@ class RecurringLogicsTest < ActiveSupport::TestCase
     it 'has a task group associated to all tasks that were created as part of the recurring logic' do
       recurring_logic = ForemanTasks::RecurringLogic.new_from_cronline('* * * * *')
       recurring_logic.save
-      _(recurring_logic.task_group).must_be_kind_of ForemanTasks::TaskGroups::RecurringLogicTaskGroup
+      assert_kind_of ForemanTasks::TaskGroups::RecurringLogicTaskGroup, recurring_logic.task_group
       task = FactoryBot.build(:dynflow_task, :user_create_task)
       task.task_groups << Support::DummyTaskGroup.new
       task.save!
       recurring_logic.task_group.tasks << task
-      _(recurring_logic.task_groups).must_include(*task.task_groups)
+      assert_includes recurring_logic.task_groups, *task.task_groups
     end
 
     it 'can be created from triggering' do
       triggering = FactoryBot.build(:triggering, :recurring, :end_time_limited)
       logic = ForemanTasks::RecurringLogic.new_from_triggering(triggering)
       # Mysql coerces the times a bit
-      _(logic.end_time).must_be_close_to(triggering.end_time, 1.second)
+      assert_in_delta triggering.end_time, logic.end_time, 1.second
     end
 
     it 'cannot trigger tasks when cancelled' do
@@ -181,24 +180,24 @@ class RecurringLogicsTest < ActiveSupport::TestCase
       let(:logic) { FactoryBot.build(:recurring_logic) }
 
       it 'is valid by default' do
-        _(logic).must_be :valid?
+        assert_predicate logic, :valid?
       end
 
       it 'is invalid when end time in past' do
         logic.end_time = (Time.zone.now - 120)
-        _(logic).wont_be :valid?
+        assert_not_predicate logic, :valid?
       end
 
       it 'is invalid when iteration limit < 1' do
         logic.max_iteration = 0
-        _(logic).wont_be :valid?
+        assert_not_predicate logic, :valid?
       end
 
       it 'is valid when in active state' do
         logic.end_time = (Time.zone.now - 120)
-        _(logic).wont_be :valid?
+        assert_not_predicate logic, :valid?
         logic.state = 'active'
-        _(logic).must_be :valid?
+        assert_predicate logic, :valid?
       end
     end
   end

data/test/unit/remote_task_test.rb

@@ -24,8 +24,8 @@ module ForemanTasks
         RemoteTask.batch_trigger('a_operation', remote_tasks)
         remote_tasks.each do |remote_task|
           remote_task.reload
-          _(remote_task.state).must_equal 'triggered'
-          _(remote_task.remote_task_id).must_equal((remote_task.id + 5).to_s)
+          assert_equal 'triggered', remote_task.state
+          assert_equal (remote_task.id + 5).to_s, remote_task.remote_task_id
         end
       end
 
@@ -50,8 +50,8 @@ module ForemanTasks
         RemoteTask.batch_trigger('a_operation', remote_tasks)
         remote_tasks.each do |remote_task|
           remote_task.reload
-          _(remote_task.state).must_equal 'triggered'
-          _(remote_task.remote_task_id).must_equal((remote_task.id + 5).to_s)
+          assert_equal 'triggered', remote_task.state
+          assert_equal (remote_task.id + 5).to_s, remote_task.remote_task_id
         end
       end
     end

data/test/unit/task_groups_test.rb

@@ -59,18 +59,18 @@ module ForemanTasks
 
       it 'has the task group assigned' do
         task = spawn_task.call ChildAction
-        _(task.task_groups.map(&:id)).must_equal [1]
+        assert_equal [1], task.task_groups.map(&:id)
       end
 
       it 'tasks inherit task groups correctly' do
         children_count = 3
         task = spawn_task.call ParentAction, children_count
         # Parent task has task groups of its children
-        _(task.task_groups.map(&:id).sort).must_equal [1, 2, 3, 4]
+        assert_equal [1, 2, 3, 4], task.task_groups.map(&:id).sort
         # Children have the parent's and their own, they don't have their siblings' task groups
-        _(task.sub_tasks.count).must_equal children_count
+        assert_equal children_count, task.sub_tasks.count
         task.sub_tasks.each do |sub_task|
-          _(sub_task.task_groups.map(&:id).sort).must_equal [1, sub_task.input[:id]].sort
+          assert_equal [1, sub_task.input[:id]].sort, sub_task.task_groups.map(&:id).sort
         end
       end
     end

data/test/unit/task_test.rb

@@ -32,8 +32,8 @@ class TasksTest < ActiveSupport::TestCase
       end
 
       it 'cannot search by arbitrary key' do
-        _(proc { ForemanTasks::Task.search_for('user.my_key ~ 5') }).must_raise(ScopedSearch::QueryNotSupported)
-        _(proc { ForemanTasks::Task.search_for('user. = 5') }).must_raise(ScopedSearch::QueryNotSupported)
+        assert_raises(ScopedSearch::QueryNotSupported) { ForemanTasks::Task.search_for('user.my_key ~ 5') }
+        assert_raises(ScopedSearch::QueryNotSupported) { ForemanTasks::Task.search_for('user. = 5') }
       end
 
       test 'can search the tasks by negated user' do
@@ -59,8 +59,8 @@ class TasksTest < ActiveSupport::TestCase
       end
 
       test 'cannot glob on user\'s id' do
-        _(proc { ForemanTasks::Task.search_for("user.id ~ something") }).must_raise(ScopedSearch::QueryNotSupported)
-        _(proc { ForemanTasks::Task.search_for("user.id ~ 5") }).must_raise(ScopedSearch::QueryNotSupported)
+        assert_raises(ScopedSearch::QueryNotSupported) { ForemanTasks::Task.search_for("user.id ~ something") }
+        assert_raises(ScopedSearch::QueryNotSupported) { ForemanTasks::Task.search_for("user.id ~ 5") }
       end
 
       test 'can search the tasks by user with wildcards' do
@@ -105,28 +105,28 @@ class TasksTest < ActiveSupport::TestCase
 
       it 'can search by seconds ' do
         skip unless on_postgresql?
-        _(scope.search_for('duration < 2')).must_be :empty?
-        _(scope.search_for('duration = 2')).must_equal [@task_one, @task_two]
-        _(scope.search_for('duration < "2 seconds"')).must_be :empty?
-        _(scope.search_for('duration > "2 seconds"')).must_be :empty?
-        _(scope.search_for('duration = "2 seconds"')).must_equal [@task_one, @task_two]
-        _(scope.search_for('duration <= "2 seconds"')).must_equal [@task_one, @task_two]
-        _(scope.search_for('duration >= "2 seconds"')).must_equal [@task_one, @task_two]
+        assert_empty scope.search_for('duration < 2')
+        assert_equal [@task_one, @task_two], scope.search_for('duration = 2')
+        assert_empty scope.search_for('duration < "2 seconds"')
+        assert_empty scope.search_for('duration > "2 seconds"')
+        assert_equal [@task_one, @task_two], scope.search_for('duration = "2 seconds"')
+        assert_equal [@task_one, @task_two], scope.search_for('duration <= "2 seconds"')
+        assert_equal [@task_one, @task_two], scope.search_for('duration >= "2 seconds"')
       end
 
       it 'can search by other time intervals' do
         skip unless on_postgresql?
         %w[minutes hours days months years].each do |interval|
-          _(scope.search_for("duration < \"2 #{interval}\"")).must_equal [@task_one, @task_two]
-          _(scope.search_for("duration > \"2 #{interval}\"")).must_be :empty?
-          _(scope.search_for("duration = \"2 #{interval}\"")).must_be :empty?
-          _(scope.search_for("duration <= \"2 #{interval}\"")).must_equal [@task_one, @task_two]
-          _(scope.search_for("duration >= \"2 #{interval}\"")).must_be :empty?
+          assert_equal [@task_one, @task_two], scope.search_for("duration < \"2 #{interval}\"")
+          assert_empty scope.search_for("duration > \"2 #{interval}\"")
+          assert_empty scope.search_for("duration = \"2 #{interval}\"")
+          assert_equal [@task_one, @task_two], scope.search_for("duration <= \"2 #{interval}\"")
+          assert_empty scope.search_for("duration >= \"2 #{interval}\"")
         end
       end
 
       it 'raises an exception if duration is unknown' do
-        _(proc { ForemanTasks::Task.search_for('duration = "25 potatoes"') }).must_raise ScopedSearch::QueryNotSupported
+        assert_raises(ScopedSearch::QueryNotSupported) { ForemanTasks::Task.search_for('duration = "25 potatoes"') }
       end
     end
 
@@ -144,7 +144,7 @@ class TasksTest < ActiveSupport::TestCase
   describe 'users' do
     test 'users can be deleted even if they have tasks assigned' do
       user = FactoryBot.create(:user)
-      FactoryBot.create(:some_task, :user => user)
+      FactoryBot.create(:some_task, user: user)
       user.destroy!
     end
   end
@@ -152,14 +152,14 @@ class TasksTest < ActiveSupport::TestCase
   describe 'state_updated_at' do
     it 'updates the state_updated_at when the state changes' do
       task = FactoryBot.create(:some_task)
-      assert task.state_updated_at > Time.now.utc - 1.minute, "Newly created task has to have state_updated_at set"
+      assert_operator task.state_updated_at, :>, Time.now.utc - 1.minute, "Newly created task has to have state_updated_at set"
       task.update(state_updated_at: nil)
       task.result = 'error'
       task.save
-      assert_not task.state_updated_at, "Other than state change should not affect 'state_updated_at'"
+      assert_nil task.state_updated_at, "Other than state change should not affect 'state_updated_at'"
       task.state = 'running'
       task.save
-      assert task.state_updated_at, "State change should set 'state_updated_at'"
+      assert_not_nil task.state_updated_at, "State change should set 'state_updated_at'"
     end
   end
 
@@ -171,7 +171,7 @@ class TasksTest < ActiveSupport::TestCase
       permission = FactoryBot.build(:permission)
       permission.resource_type = 'ForemanTasks::Task'
       permission.save!
-      FactoryBot.create(:filter, :role => role, :permissions => [permission])
+      FactoryBot.create(:filter, role: role, permissions: [permission])
 
       User.current = user
       task = FactoryBot.create(:dynflow_task)
@@ -184,21 +184,21 @@ class TasksTest < ActiveSupport::TestCase
   describe 'consistency check' do
     it 'ensures the tasks marked as running are really running in Dynflow' do
       task = ForemanTasks.sync_task(Support::DummyDynflowAction)
-      task.update(:state => 'running') # Updating state updates the timestamp
-      task.update(:state_updated_at => Time.zone.now - 5.minutes)
+      task.update(state: 'running') # Updating state updates the timestamp
+      task.update(state_updated_at: Time.zone.now - 5.minutes)
 
       ForemanTasks::Task::DynflowTask.consistency_check
       task.reload
-      _(task.state).must_equal 'stopped'
+      assert_equal 'stopped', task.state
     end
   end
 
   describe 'active job task' do
     it 'when scheduled to the future, the label and action is set properly' do
-      job = Support::DummyActiveJob.set(:wait => 12.hours).perform_later
-      task = ForemanTasks::Task.find_by!(:external_id => job.provider_job_id)
-      _(task.action).must_equal "Dummy action"
-      _(task.label).must_equal "Support::DummyActiveJob"
+      job = Support::DummyActiveJob.set(wait: 12.hours).perform_later
+      task = ForemanTasks::Task.find_by!(external_id: job.provider_job_id)
+      assert_equal "Dummy action", task.action
+      assert_equal "Support::DummyActiveJob", task.label
     end
   end
 
@@ -214,9 +214,9 @@ class TasksTest < ActiveSupport::TestCase
     end
 
     it 'handles the error while loading the task and does not propagate errors unless necessary' do
-      task.cancellable?
-      task.resumable?
-      task.main_action
+      assert_nothing_raised { task.cancellable? }
+      assert_nothing_raised { task.resumable? }
+      assert_nothing_raised { task.main_action }
       assert_equal 'Support::DummyDynflowAction', task.get_humanized(:humanized_name)
       assert_equal 0, task.progress
       assert_raises(KeyError) { task.cancel }
@@ -226,19 +226,19 @@ class TasksTest < ActiveSupport::TestCase
   describe 'subtask count querying' do
     let(:result_base) do
       {
-        :error     => 0,
-        :warning   => 0,
-        :total     => 0,
-        :success   => 0,
-        :cancelled => 0,
-        :pending   => 0,
+        error: 0,
+        warning: 0,
+        total: 0,
+        success: 0,
+        cancelled: 0,
+        pending: 0,
       }
     end
     let(:task) { FactoryBot.create(:dynflow_task) }
 
     describe 'without sub tasks' do
       it 'calculates the progress report correctly' do
-        _(task.sub_tasks_counts).must_equal result_base
+        assert_equal result_base, task.sub_tasks_counts
       end
     end
 
@@ -248,22 +248,22 @@ class TasksTest < ActiveSupport::TestCase
       before { task.sub_tasks = [success, failed] }
 
       it 'calculate the progress report correctly' do
-        expected_result = result_base.merge(:success => 1, :error => 1, :total => 2)
-        _(task.sub_tasks_counts).must_equal expected_result
+        expected_result = result_base.merge(success: 1, error: 1, total: 2)
+        assert_equal expected_result, task.sub_tasks_counts
       end
 
       it 'calculates the progress report correctly when using batch planning' do
-        result_base = self.result_base.merge(:success => 1, :error => 1, :total => 25)
-        fake_action = OpenStruct.new(:total_count => 25)
+        result_base = self.result_base.merge(success: 1, error: 1, total: 25)
+        fake_action = OpenStruct.new(total_count: 25)
         task.stubs(:main_action).returns(fake_action)
 
         task.state = 'stopped'
-        expected_result = result_base.merge(:cancelled => 23)
-        _(task.sub_tasks_counts).must_equal expected_result
+        expected_result = result_base.merge(cancelled: 23)
+        assert_equal expected_result, task.sub_tasks_counts
 
         task.state = 'pending'
-        expected_result = result_base.merge(:pending => 23)
-        _(task.sub_tasks_counts).must_equal expected_result
+        expected_result = result_base.merge(pending: 23)
+        assert_equal expected_result, task.sub_tasks_counts
       end
     end
   end
@@ -284,11 +284,11 @@ class TasksTest < ActiveSupport::TestCase
     let(:task) { FactoryBot.create(:some_task) }
 
     it 'can indicate it is delayed' do
-      assert_not task.delayed?
-      _(task.execution_type).must_equal 'Immediate'
+      assert_not_predicate task, :delayed?
+      assert_equal 'Immediate', task.execution_type
       task.start_at = Time.now.utc + 100
-      assert task.delayed?
-      _(task.execution_type).must_equal 'Delayed'
+      assert_predicate task, :delayed?
+      assert_equal 'Delayed', task.execution_type
     end
   end
 

data/test/unit/triggering_test.rb

@@ -3,34 +3,34 @@ require 'foreman_tasks_test_helper'
 class TriggeringTest < ActiveSupport::TestCase
   describe 'validation' do
     it 'is valid when immediate' do
-      _(FactoryBot.build(:triggering)).must_be :valid?
+      assert_predicate(FactoryBot.build(:triggering), :valid?)
     end
 
     it 'is validates future execution' do
       triggering = FactoryBot.build(:triggering, :future)
-      _(triggering).must_be :valid?
+      assert_predicate(triggering, :valid?)
       triggering.start_before = triggering.start_at - 120
-      _(triggering).wont_be :valid?
+      assert_not_predicate(triggering, :valid?)
     end
 
     it 'is invalid when recurring logic is invalid' do
       triggering = FactoryBot.build(:triggering, :recurring)
-      _(triggering).must_be :valid?
+      assert_predicate(triggering, :valid?)
       triggering.recurring_logic.stubs(:valid?).returns(false)
-      _(triggering).wont_be :valid?
+      assert_not_predicate(triggering, :valid?)
     end
 
     it 'is valid when recurring logic has purpose' do
       logic = FactoryBot.build(:recurring_logic, :purpose => 'test', :state => 'active')
       triggering = FactoryBot.build(:triggering, :recurring_logic => logic, :mode => :recurring, :input_type => :cronline, :cronline => '* * * * *')
-      _(triggering).must_be :valid?
+      assert_predicate(triggering, :valid?)
     end
 
     it 'is invalid when recurring logic with given purpose exists' do
       FactoryBot.create(:recurring_logic, :purpose => 'test', :state => 'active')
       logic = FactoryBot.build(:recurring_logic, :purpose => 'test', :state => 'active')
       triggering = FactoryBot.build(:triggering, :recurring_logic => logic, :mode => :recurring, :input_type => :cronline, :cronline => '* * * * *')
-      _(triggering).wont_be :valid?
+      assert_not_predicate(triggering, :valid?)
     end
 
     it 'is valid when recurring logic with given purpose exists and is not active or disabled' do
@@ -39,14 +39,14 @@ class TriggeringTest < ActiveSupport::TestCase
       end
       logic = FactoryBot.build(:recurring_logic, :purpose => 'test')
       triggering = FactoryBot.build(:triggering, :recurring_logic => logic, :mode => :recurring, :input_type => :cronline, :cronline => '* * * * *')
-      _(triggering).must_be :valid?
+      assert_predicate(triggering, :valid?)
     end
   end
 
   it 'cannot have mode set to arbitrary value' do
     triggering = FactoryBot.build(:triggering)
-    _(triggering).must_be :valid?
-    _(proc { triggering.mode = 'bogus' }).must_raise ArgumentError
-    _(proc { triggering.mode = 27 }).must_raise ArgumentError
+    assert_predicate(triggering, :valid?)
+    assert_raises(ArgumentError) { triggering.mode = 'bogus' }
+    assert_raises(ArgumentError) { triggering.mode = 27 }
   end
 end

data/test/unit/troubleshooting_help_generator_test.rb

@@ -28,8 +28,8 @@ module ForemanTasks
 
     it 'generates html from the main action troubleshooting_info' do
       generated_html = subject.generate_html
-      _(generated_html).must_include "A paused task represents a process that has not finished properly"
-      _(generated_html).must_include %(See <a href="#{expected_troubleshooting_url}">troubleshooting documentation</a> for more details on how to resolve the issue)
+      assert_includes generated_html, "A paused task represents a process that has not finished properly"
+      assert_includes generated_html, %(See <a href="#{expected_troubleshooting_url}">troubleshooting documentation</a> for more details on how to resolve the issue)
     end
 
     it 'exposes link details' do
@@ -47,10 +47,10 @@ module ForemanTasks
 
       it 'includes additional description in generated html' do
         generated_html = subject.generate_html
-        _(generated_html).must_include 'A paused task represents a process that has not finished properly'
-        _(generated_html).must_match %r{See <a href=".*">troubleshooting documentation</a> for more details on how to resolve the issue}
-        _(generated_html).must_include 'This task requires special handling'
-        _(generated_html).must_include 'Investigate <a href="/additional_troubleshooting_page">custom link</a> on more details for this custom error'
+        assert_includes generated_html, 'A paused task represents a process that has not finished properly'
+        assert_match %r{See <a href=".*">troubleshooting documentation</a> for more details on how to resolve the issue}, generated_html
+        assert_includes generated_html, 'This task requires special handling'
+        assert_includes generated_html, 'Investigate <a href="/additional_troubleshooting_page">custom link</a> on more details for this custom error'
       end
 
       it 'includes additional links' do

data/test/unit/ui_notifications_test.rb

@@ -22,33 +22,33 @@ module ForemanTasks
       it 'notifies all admins about current amount of paused tasks when some paused task occurs' do
         trigger_task
         notification = user_notifications(admin_user).first
-        _(notification.message).must_equal "There is 1 paused task in the system that need attention"
+        assert_equal "There is 1 paused task in the system that need attention", notification.message
         links = notification.actions['links']
-        _(links).must_include('href' => '/foreman_tasks/tasks?search=state%3Dpaused',
-                           'title' => 'List of tasks')
-        _(links).must_include('name' => 'troubleshooting',
-                           'title' => 'Troubleshooting Documentation',
-                           'description' => 'See %{link} for more details on how to resolve the issue',
-                           'href' => "https://theforeman.org/manuals/#{SETTINGS[:version].short}/tasks_troubleshooting.html#",
-                           'external' => true)
+        assert_includes(links, { 'href' => '/foreman_tasks/tasks?search=state%3Dpaused',
+                                'title' => 'List of tasks' })
+        assert_includes(links, { 'name' => 'troubleshooting',
+                                'title' => 'Troubleshooting Documentation',
+                                'description' => 'See %{link} for more details on how to resolve the issue',
+                                'href' => "https://theforeman.org/manuals/#{SETTINGS[:version].short}/tasks_troubleshooting.html#",
+                                'external' => true })
       end
 
       it 'aggregates the notification when multiple tasks get paused' do
         trigger_task
         recipient1 = NotificationRecipient.find_by(user_id: admin_user)
-        _(recipient1.notification.message).must_match(/1 paused task/)
+        assert_match(/1 paused task/, recipient1.notification.message)
 
         new_admin_user = FactoryBot.create(:user, :admin)
 
         trigger_task
 
-        _(NotificationRecipient.find_by(id: recipient1.id)).must_be_nil
-        _(Notification.find_by(id: recipient1.notification.id)).must_be_nil
+        assert_nil NotificationRecipient.find_by(id: recipient1.id)
+        assert_nil Notification.find_by(id: recipient1.notification.id)
         recipient2 = NotificationRecipient.find_by(user_id: admin_user)
-        _(recipient2.notification.message).must_match(/2 paused tasks/)
+        assert_match(/2 paused tasks/, recipient2.notification.message)
 
         new_recipient = NotificationRecipient.find_by(user_id: new_admin_user)
-        _(new_recipient.notification).must_equal recipient2.notification
+        assert_equal recipient2.notification, new_recipient.notification
       end
     end
 
@@ -58,15 +58,14 @@ module ForemanTasks
         notifications = user_notifications(task_owner)
         assert_equal 1, notifications.size, 'Only notification for the main action should be triggered'
         notification = notifications.first
-        _(notification.message).must_equal "The task 'Dummy pause action' got paused"
+        assert_equal "The task 'Dummy pause action' got paused", notification.message
         links = notification.actions['links']
-        _(links).must_include("href" => "/foreman_tasks/tasks/#{task.id}",
-                           "title" => "Task Details")
-        _(links).must_include('name' => 'troubleshooting',
-                           'title' => 'Troubleshooting Documentation',
-                           'description' => 'See %{link} for more details on how to resolve the issue',
-                           'href' => "https://theforeman.org/manuals/#{SETTINGS[:version].short}/tasks_troubleshooting.html#Support::DummyPauseAction",
-                           'external' => true)
+        assert_includes(links, "href" => "/foreman_tasks/tasks/#{task.id}", "title" => "Task Details")
+        assert_includes(links, 'name' => 'troubleshooting',
+                        'title' => 'Troubleshooting Documentation',
+                        'description' => 'See %{link} for more details on how to resolve the issue',
+                        'href' => "https://theforeman.org/manuals/#{SETTINGS[:version].short}/tasks_troubleshooting.html#Support::DummyPauseAction",
+                        'external' => true)
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman-tasks
 version: !ruby/object:Gem::Version
-  version: 9.1.0
+  version: 9.2.0
 platform: ruby
 authors:
 - Ivan Nečas
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-02-14 00:00:00.000000000 Z
+date: 2024-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dynflow
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 1.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 1.9.0
 - !ruby/object:Gem::Dependency
   name: fugit
   requirement: !ruby/object:Gem::Requirement