foreman-tasks 9.1.0 → 9.1.1

data/test/unit/cleaner_test.rb

@@ -22,14 +22,14 @@ class TasksTest < ActiveSupport::TestCase
                          FactoryBot.create(:dynflow_task, :product_create_task)]
       cleaner.expects(:tasks_to_csv)
       cleaner.delete
-      _(ForemanTasks::Task.where(id: tasks_to_delete)).must_be_empty
-      _(ForemanTasks::Task.where(id: tasks_to_keep).order(:id).map(&:id)).must_equal tasks_to_keep.map(&:id).sort
+      assert_empty ForemanTasks::Task.where(id: tasks_to_delete)
+      assert_equal tasks_to_keep.map(&:id).sort, ForemanTasks::Task.where(id: tasks_to_keep).order(:id).map(&:id)
 
-      _(ForemanTasks.dynflow.world.persistence
-                  .find_execution_plans(filters: { 'uuid' => tasks_to_delete.map(&:external_id) }).size).must_equal 0
+      assert_equal 0, ForemanTasks.dynflow.world.persistence
+                                  .find_execution_plans(filters: { 'uuid' => tasks_to_delete.map(&:external_id) }).size
 
-      _(ForemanTasks.dynflow.world.persistence
-                  .find_execution_plans(filters: { 'uuid' => tasks_to_keep.map(&:external_id) }).size).must_equal tasks_to_keep.size
+      assert_equal tasks_to_keep.size, ForemanTasks.dynflow.world.persistence
+                                                   .find_execution_plans(filters: { 'uuid' => tasks_to_keep.map(&:external_id) }).size
     end
 
     describe "#orphaned_dynflow_tasks" do
@@ -67,11 +67,11 @@ class TasksTest < ActiveSupport::TestCase
 
       cleaner.expects(:tasks_to_csv)
       cleaner.delete
-      _(ForemanTasks::Task.where(id: tasks_to_delete)).must_be_empty
-      _(ForemanTasks::Task.where(id: tasks_to_keep)).must_equal tasks_to_keep
+      assert_empty ForemanTasks::Task.where(id: tasks_to_delete)
+      assert_equal tasks_to_keep, ForemanTasks::Task.where(id: tasks_to_keep)
 
-      _(ForemanTasks::Link.find_by(id: link_to_delete.id)).must_be_nil
-      _(ForemanTasks::Link.find_by(id: link_to_keep.id)).wont_be_nil
+      assert_nil ForemanTasks::Link.find_by(id: link_to_delete.id)
+      assert_not_nil ForemanTasks::Link.find_by(id: link_to_keep.id)
     end
 
     it 'supports passing empty filter (just delete all)' do
@@ -85,8 +85,8 @@ class TasksTest < ActiveSupport::TestCase
                        end]
       cleaner.expects(:tasks_to_csv)
       cleaner.delete
-      _(ForemanTasks::Task.where(id: tasks_to_delete)).must_be_empty
-      _(ForemanTasks::Task.where(id: tasks_to_keep)).must_equal tasks_to_keep
+      assert_empty ForemanTasks::Task.where(id: tasks_to_delete)
+      assert_equal tasks_to_keep, ForemanTasks::Task.where(id: tasks_to_keep)
     end
 
     it 'matches tasks with compound filters properly' do
@@ -100,8 +100,8 @@ class TasksTest < ActiveSupport::TestCase
       task_to_keep.update!(:result => 'pending', :state => 'planned')
       cleaner.expects(:tasks_to_csv)
       cleaner.delete
-      _(ForemanTasks::Task.where(id: tasks_to_delete)).must_be_empty
-      _(ForemanTasks::Task.where(id: task_to_keep)).must_equal [task_to_keep]
+      assert_empty ForemanTasks::Task.where(id: tasks_to_delete)
+      assert_equal [task_to_keep], ForemanTasks::Task.where(id: task_to_keep)
     end
 
     it 'backs tasks up before deleting' do
@@ -117,11 +117,11 @@ class TasksTest < ActiveSupport::TestCase
       cleaner.delete
       w.close
       header, *data = r.readlines.map(&:chomp)
-      _(header).must_equal ForemanTasks::Task.attribute_names.join(',')
+      assert_equal ForemanTasks::Task.attribute_names.join(','), header
       expected_lines = tasks_to_delete.map { |task| task.attributes.values.to_csv.chomp }
-      _(data.count).must_equal expected_lines.count
-      expected_lines.each { |line| _(data).must_include line }
-      _(ForemanTasks::Task.where(id: tasks_to_delete)).must_be_empty
+      assert_equal expected_lines.count, data.count
+      expected_lines.each { |line| assert_includes data, line }
+      assert_empty ForemanTasks::Task.where(id: tasks_to_delete)
     end
 
     class ActionWithCleanup < Actions::Base
@@ -135,7 +135,7 @@ class TasksTest < ActiveSupport::TestCase
         ForemanTasks::Cleaner.stubs(:cleanup_settings => {})
         actions = ForemanTasks::Cleaner.actions_with_default_cleanup
         example = actions.find { |rule| rule.klass == ActionWithCleanup }
-        _(example.after).must_equal '15d'
+        assert_equal '15d', example.after
       end
 
       it 'searches for the actions that have the cleanup_after defined' do
@@ -143,7 +143,7 @@ class TasksTest < ActiveSupport::TestCase
                                      { :actions => [{ :name => ActionWithCleanup.name, :after => '5d' }] })
         actions = ForemanTasks::Cleaner.actions_with_default_cleanup
         example = actions.find { |rule| rule.klass == ActionWithCleanup }
-        _(example.after).must_equal '5d'
+        assert_equal '5d', example.after
       end
 
       it 'generates filters from rules properly' do
@@ -157,10 +157,10 @@ class TasksTest < ActiveSupport::TestCase
                    :override_actions => true, :states => 'all' }]
         ForemanTasks::Cleaner.stubs(:cleanup_settings).returns(:rules => rules)
         r1, r2 = ForemanTasks::Cleaner.actions_by_rules actions_with_default
-        _(r1[:filter]).must_equal '(NOT ((label ^ (action1, action2)))) AND (label = something)'
-        _(r1[:states]).must_equal %w[stopped paused]
-        _(r2[:filter]).must_equal '(label = something_else)'
-        _(r2[:states]).must_equal []
+        assert_equal '(NOT ((label ^ (action1, action2)))) AND (label = something)', r1[:filter]
+        assert_equal %w[stopped paused], r1[:states]
+        assert_equal '(label = something_else)', r2[:filter]
+        assert_equal [], r2[:states]
       end
     end
   end

data/test/unit/locking_test.rb

@@ -32,14 +32,14 @@ module ForemanTasks
 
         it 'can lock a resource for a single task only once' do
           Lock.lock!(resource, task1)
-          _(Lock.for_resource(resource).count).must_equal 1
+          assert_equal 1, Lock.for_resource(resource).count
           Lock.lock!(resource, task1)
-          _(Lock.for_resource(resource).count).must_equal 1
+          assert_equal 1, Lock.for_resource(resource).count
         end
 
         it 'cannot lock a resource for multiple tasks' do
           lock = Lock.lock!(resource, task1)
-          _(Lock.colliding_locks(resource, task2)).must_equal [lock]
+          assert_equal [lock], Lock.colliding_locks(resource, task2)
           assert_raises Lock::LockConflict do
             Lock.lock!(resource, task2)
           end
@@ -52,13 +52,13 @@ module ForemanTasks
           exception = assert_raises Lock::LockConflict do
             Lock.lock!(resource, task2)
           end
-          _(exception.message).must_match(/#{lock.task_id}/)
+          assert_match(/#{lock.task_id}/, exception.message)
         end
 
         it 'creates a link when creating a lock for a resource' do
           Lock.lock!(resource, task1)
           link = Link.for_resource(resource).first
-          _(link.task_id).must_equal task1.id
+          assert_equal task1.id, link.task_id
         end
       end
 
@@ -69,15 +69,15 @@ module ForemanTasks
 
         it 'can link a resource for a single task only once' do
           Link.link!(resource, task1)
-          _(Link.for_resource(resource).count).must_equal 1
+          assert_equal 1, Link.for_resource(resource).count
           Link.link!(resource, task1)
-          _(Link.for_resource(resource).count).must_equal 1
+          assert_equal 1, Link.for_resource(resource).count
         end
 
         it 'can link a resource to multiple tasks' do
           Link.link!(resource, task1)
           Link.link!(resource, task2)
-          _(Link.for_resource(resource).count).must_equal 2
+          assert_equal 2, Link.for_resource(resource).count
         end
       end
     end

data/test/unit/proxy_selector_test.rb

@@ -18,22 +18,22 @@ describe ForemanTasks::ProxySelector do
         found << proxy_selector.select_by_jobs_count(proxies)
       end
 
-      _(available.count).must_equal count
-      _(available.uniq.count).must_equal count - 1
-      _(proxy_selector.offline.count).must_equal 1
+      assert_equal count, available.count
+      assert_equal count - 1, available.uniq.count
+      assert_equal 1, proxy_selector.offline.count
     end
 
     it 'returns nil for if no proxy is available' do
-      _(proxy_selector.select_by_jobs_count([])).must_be_nil
+      assert_nil proxy_selector.select_by_jobs_count([])
     end
   end
 
   describe '#determine_proxy' do
     it 'returns :not_defined when avialable proxies returns empty hash' do
       proxy_selector.stubs(:available_proxies => [])
-      _(proxy_selector.determine_proxy).must_equal :not_defined
+      assert_equal :not_defined, proxy_selector.determine_proxy
       proxy_selector.stubs(:available_proxies => { :global => [] })
-      _(proxy_selector.determine_proxy).must_equal :not_defined
+      assert_equal :not_defined, proxy_selector.determine_proxy
     end
 
     it 'returns :not_available when proxies are set but offline' do
@@ -41,7 +41,7 @@ describe ForemanTasks::ProxySelector do
       ProxyAPI::ForemanDynflow::DynflowProxy.any_instance.expects(:tasks_count).times(count).raises
       proxy_selector.stubs(:available_proxies =>
                            { :global => FactoryBot.create_list(:smart_proxy, count) })
-      _(proxy_selector.determine_proxy).must_equal :not_available
+      assert_equal :not_available, proxy_selector.determine_proxy
     end
 
     it 'returns first available proxy, prioritizing by strategy' do
@@ -51,9 +51,9 @@ describe ForemanTasks::ProxySelector do
       ForemanTasks::ProxySelector.any_instance.stubs(:available_proxies =>
                                                      { :fallback => [fallback_proxy],
                                                        :global => [global_proxy] })
-      _(ForemanTasks::ProxySelector.new.determine_proxy).must_equal fallback_proxy
+      assert_equal fallback_proxy, ForemanTasks::ProxySelector.new.determine_proxy
       ProxyAPI::ForemanDynflow::DynflowProxy.any_instance.expects(:tasks_count).raises.then.returns(0)
-      _(ForemanTasks::ProxySelector.new.determine_proxy).must_equal global_proxy
+      assert_equal global_proxy, ForemanTasks::ProxySelector.new.determine_proxy
     end
   end
 end

data/test/unit/recurring_logic_test.rb

@@ -4,17 +4,17 @@ class RecurringLogicsTest < ActiveSupport::TestCase
   describe 'generating times' do
     it 'assembles cronline' do
       hash = {}
-      _(ForemanTasks::RecurringLogic.assemble_cronline(hash)).must_equal '* * * * *'
+      assert_equal '* * * * *', ForemanTasks::RecurringLogic.assemble_cronline(hash)
       hash.update :minutes => '*'
-      _(ForemanTasks::RecurringLogic.assemble_cronline(hash)).must_equal '* * * * *'
+      assert_equal '* * * * *', ForemanTasks::RecurringLogic.assemble_cronline(hash)
       hash.update :hours => '0,12'
-      _(ForemanTasks::RecurringLogic.assemble_cronline(hash)).must_equal '* 0,12 * * *'
+      assert_equal '* 0,12 * * *', ForemanTasks::RecurringLogic.assemble_cronline(hash)
       hash.update :days => '*/2'
-      _(ForemanTasks::RecurringLogic.assemble_cronline(hash)).must_equal '* 0,12 */2 * *'
+      assert_equal '* 0,12 */2 * *', ForemanTasks::RecurringLogic.assemble_cronline(hash)
       hash.update :months => '12'
-      _(ForemanTasks::RecurringLogic.assemble_cronline(hash)).must_equal '* 0,12 */2 12 *'
+      assert_equal '* 0,12 */2 12 *', ForemanTasks::RecurringLogic.assemble_cronline(hash)
       hash.update :days_of_week => '1,2,3,4,5,6,7'
-      _(ForemanTasks::RecurringLogic.assemble_cronline(hash)).must_equal '* 0,12 */2 12 1,2,3,4,5,6,7'
+      assert_equal '* 0,12 */2 12 1,2,3,4,5,6,7', ForemanTasks::RecurringLogic.assemble_cronline(hash)
     end
 
     it 'generates correct times' do
@@ -25,17 +25,17 @@ class RecurringLogicsTest < ActiveSupport::TestCase
       minute = 0
       reference_time = Time.utc(year, month, day, hour, minute)
       parser = ForemanTasks::RecurringLogic.new_from_cronline('* * * * *')
-      _(parser.next_occurrence_time(reference_time)).must_equal Time.utc(year, month, day, hour, minute)
+      assert_equal Time.utc(year, month, day, hour, minute), parser.next_occurrence_time(reference_time)
       parser = ForemanTasks::RecurringLogic.new_from_cronline('*/2 * * * *')
-      _(parser.next_occurrence_time(reference_time)).must_equal Time.utc(year, month, day, hour, minute)
+      assert_equal Time.utc(year, month, day, hour, minute), parser.next_occurrence_time(reference_time)
       parser = ForemanTasks::RecurringLogic.new_from_cronline('*/2 18,19 * * *')
-      _(parser.next_occurrence_time(reference_time)).must_equal Time.utc(year, month, day, 18)
+      assert_equal Time.utc(year, month, day, 18), parser.next_occurrence_time(reference_time)
       parser = ForemanTasks::RecurringLogic.new_from_cronline('*/2 18,19 10 * *')
-      _(parser.next_occurrence_time(reference_time)).must_equal Time.utc(year, month + 1, 10, 18, minute)
+      assert_equal Time.utc(year, month + 1, 10, 18, minute), parser.next_occurrence_time(reference_time)
       parser = ForemanTasks::RecurringLogic.new_from_cronline('*/2 18,19 10 11,12 *')
-      _(parser.next_occurrence_time(reference_time)).must_equal Time.utc(year, 11, 10, 18, 0)
+      assert_equal Time.utc(year, 11, 10, 18, 0), parser.next_occurrence_time(reference_time)
       parser = ForemanTasks::RecurringLogic.new_from_cronline('* * * * 1')
-      _(parser.next_occurrence_time(reference_time)).must_equal Time.utc(year, month + 1, 5)
+      assert_equal Time.utc(year, month + 1, 5), parser.next_occurrence_time(reference_time)
     end
 
     it 'creates correct cronline hash' do
@@ -48,10 +48,10 @@ class RecurringLogicsTest < ActiveSupport::TestCase
       expected_result_daily = { :minutes => minutes, :hours => hours }
       expected_result_weekly = { :minutes => minutes, :hours => hours, :days_of_week => '1,4,6' }
       expected_result_monthly = { :minutes => minutes, :hours => hours, :days => days }
-      _(ForemanTasks::RecurringLogic.cronline_hash(:hourly,  time_hash, days, days_of_week)).must_equal expected_result_hourly
-      _(ForemanTasks::RecurringLogic.cronline_hash(:daily,   time_hash, days, days_of_week)).must_equal expected_result_daily
-      _(ForemanTasks::RecurringLogic.cronline_hash(:weekly,  time_hash, days, days_of_week)).must_equal expected_result_weekly
-      _(ForemanTasks::RecurringLogic.cronline_hash(:monthly, time_hash, days, days_of_week)).must_equal expected_result_monthly
+      assert_equal expected_result_hourly, ForemanTasks::RecurringLogic.cronline_hash(:hourly, time_hash, days, days_of_week)
+      assert_equal expected_result_daily, ForemanTasks::RecurringLogic.cronline_hash(:daily, time_hash, days, days_of_week)
+      assert_equal expected_result_weekly, ForemanTasks::RecurringLogic.cronline_hash(:weekly, time_hash, days, days_of_week)
+      assert_equal expected_result_monthly, ForemanTasks::RecurringLogic.cronline_hash(:monthly, time_hash, days, days_of_week)
     end
 
     it 'validates cronline correctly' do
@@ -68,18 +68,18 @@ class RecurringLogicsTest < ActiveSupport::TestCase
     it 'can have limited number of repeats' do
       parser = ForemanTasks::RecurringLogic.new_from_cronline('* * * * *')
       parser.state = 'active'
-      _(parser).must_be :can_continue?
+      assert parser.can_continue?
       parser.max_iteration = 5
       parser.expects(:iteration).twice.returns(5)
-      _(parser).wont_be :can_continue?
+      assert_not parser.can_continue?
       parser.max_iteration = nil
       time = Time.utc(2015, 9, 29, 15, 0)
       parser.end_time = time
-      _(parser).wont_be :can_continue?, time
+      assert_not parser.can_continue?(time)
       parser.end_time = time + 120
-      _(parser).must_be :can_continue?, time
+      assert parser.can_continue?(time)
       parser.max_iteration = 5
-      _(parser).wont_be :can_continue?, time
+      assert_not parser.can_continue?(time)
     end
 
     it 'generates delay options' do
@@ -87,9 +87,8 @@ class RecurringLogicsTest < ActiveSupport::TestCase
       parser.stubs(:id).returns(1)
       reference_time = Time.utc(2015, 9, 29, 15)
       expected_hash = { :start_at => reference_time, :start_before => nil, :recurring_logic_id => parser.id, :frozen => false }
-      _(parser.generate_delay_options(reference_time)).must_equal expected_hash
-      _(parser.generate_delay_options(reference_time, 'start_before' => reference_time + 3600))
-        .must_equal expected_hash.merge(:start_before => reference_time + 3600)
+      assert_equal expected_hash, parser.generate_delay_options(reference_time)
+      assert_equal expected_hash.merge(:start_before => reference_time + 3600), parser.generate_delay_options(reference_time, 'start_before' => reference_time + 3600)
     end
 
     it 'can start' do
@@ -119,19 +118,19 @@ class RecurringLogicsTest < ActiveSupport::TestCase
     it 'has a task group associated to all tasks that were created as part of the recurring logic' do
       recurring_logic = ForemanTasks::RecurringLogic.new_from_cronline('* * * * *')
       recurring_logic.save
-      _(recurring_logic.task_group).must_be_kind_of ForemanTasks::TaskGroups::RecurringLogicTaskGroup
+      assert_kind_of ForemanTasks::TaskGroups::RecurringLogicTaskGroup, recurring_logic.task_group
       task = FactoryBot.build(:dynflow_task, :user_create_task)
       task.task_groups << Support::DummyTaskGroup.new
       task.save!
       recurring_logic.task_group.tasks << task
-      _(recurring_logic.task_groups).must_include(*task.task_groups)
+      assert_includes recurring_logic.task_groups, *task.task_groups
     end
 
     it 'can be created from triggering' do
       triggering = FactoryBot.build(:triggering, :recurring, :end_time_limited)
       logic = ForemanTasks::RecurringLogic.new_from_triggering(triggering)
       # Mysql coerces the times a bit
-      _(logic.end_time).must_be_close_to(triggering.end_time, 1.second)
+      assert_in_delta triggering.end_time, logic.end_time, 1.second
     end
 
     it 'cannot trigger tasks when cancelled' do
@@ -181,24 +180,24 @@ class RecurringLogicsTest < ActiveSupport::TestCase
       let(:logic) { FactoryBot.build(:recurring_logic) }
 
       it 'is valid by default' do
-        _(logic).must_be :valid?
+        assert_predicate logic, :valid?
       end
 
       it 'is invalid when end time in past' do
         logic.end_time = (Time.zone.now - 120)
-        _(logic).wont_be :valid?
+        assert_not_predicate logic, :valid?
       end
 
       it 'is invalid when iteration limit < 1' do
         logic.max_iteration = 0
-        _(logic).wont_be :valid?
+        assert_not_predicate logic, :valid?
       end
 
       it 'is valid when in active state' do
         logic.end_time = (Time.zone.now - 120)
-        _(logic).wont_be :valid?
+        assert_not_predicate logic, :valid?
         logic.state = 'active'
-        _(logic).must_be :valid?
+        assert_predicate logic, :valid?
       end
     end
   end

data/test/unit/remote_task_test.rb

@@ -24,8 +24,8 @@ module ForemanTasks
         RemoteTask.batch_trigger('a_operation', remote_tasks)
         remote_tasks.each do |remote_task|
           remote_task.reload
-          _(remote_task.state).must_equal 'triggered'
-          _(remote_task.remote_task_id).must_equal((remote_task.id + 5).to_s)
+          assert_equal 'triggered', remote_task.state
+          assert_equal (remote_task.id + 5).to_s, remote_task.remote_task_id
         end
       end
 
@@ -50,8 +50,8 @@ module ForemanTasks
         RemoteTask.batch_trigger('a_operation', remote_tasks)
         remote_tasks.each do |remote_task|
           remote_task.reload
-          _(remote_task.state).must_equal 'triggered'
-          _(remote_task.remote_task_id).must_equal((remote_task.id + 5).to_s)
+          assert_equal 'triggered', remote_task.state
+          assert_equal (remote_task.id + 5).to_s, remote_task.remote_task_id
         end
       end
     end

data/test/unit/task_groups_test.rb

@@ -59,18 +59,18 @@ module ForemanTasks
 
       it 'has the task group assigned' do
         task = spawn_task.call ChildAction
-        _(task.task_groups.map(&:id)).must_equal [1]
+        assert_equal [1], task.task_groups.map(&:id)
       end
 
       it 'tasks inherit task groups correctly' do
         children_count = 3
         task = spawn_task.call ParentAction, children_count
         # Parent task has task groups of its children
-        _(task.task_groups.map(&:id).sort).must_equal [1, 2, 3, 4]
+        assert_equal [1, 2, 3, 4], task.task_groups.map(&:id).sort
         # Children have the parent's and their own, they don't have their siblings' task groups
-        _(task.sub_tasks.count).must_equal children_count
+        assert_equal children_count, task.sub_tasks.count
         task.sub_tasks.each do |sub_task|
-          _(sub_task.task_groups.map(&:id).sort).must_equal [1, sub_task.input[:id]].sort
+          assert_equal [1, sub_task.input[:id]].sort, sub_task.task_groups.map(&:id).sort
         end
       end
     end

data/test/unit/task_test.rb

@@ -32,8 +32,8 @@ class TasksTest < ActiveSupport::TestCase
       end
 
       it 'cannot search by arbitrary key' do
-        _(proc { ForemanTasks::Task.search_for('user.my_key ~ 5') }).must_raise(ScopedSearch::QueryNotSupported)
-        _(proc { ForemanTasks::Task.search_for('user. = 5') }).must_raise(ScopedSearch::QueryNotSupported)
+        assert_raises(ScopedSearch::QueryNotSupported) { ForemanTasks::Task.search_for('user.my_key ~ 5') }
+        assert_raises(ScopedSearch::QueryNotSupported) { ForemanTasks::Task.search_for('user. = 5') }
       end
 
       test 'can search the tasks by negated user' do
@@ -59,8 +59,8 @@ class TasksTest < ActiveSupport::TestCase
       end
 
       test 'cannot glob on user\'s id' do
-        _(proc { ForemanTasks::Task.search_for("user.id ~ something") }).must_raise(ScopedSearch::QueryNotSupported)
-        _(proc { ForemanTasks::Task.search_for("user.id ~ 5") }).must_raise(ScopedSearch::QueryNotSupported)
+        assert_raises(ScopedSearch::QueryNotSupported) { ForemanTasks::Task.search_for("user.id ~ something") }
+        assert_raises(ScopedSearch::QueryNotSupported) { ForemanTasks::Task.search_for("user.id ~ 5") }
       end
 
       test 'can search the tasks by user with wildcards' do
@@ -105,28 +105,28 @@ class TasksTest < ActiveSupport::TestCase
 
       it 'can search by seconds ' do
         skip unless on_postgresql?
-        _(scope.search_for('duration < 2')).must_be :empty?
-        _(scope.search_for('duration = 2')).must_equal [@task_one, @task_two]
-        _(scope.search_for('duration < "2 seconds"')).must_be :empty?
-        _(scope.search_for('duration > "2 seconds"')).must_be :empty?
-        _(scope.search_for('duration = "2 seconds"')).must_equal [@task_one, @task_two]
-        _(scope.search_for('duration <= "2 seconds"')).must_equal [@task_one, @task_two]
-        _(scope.search_for('duration >= "2 seconds"')).must_equal [@task_one, @task_two]
+        assert_empty scope.search_for('duration < 2')
+        assert_equal [@task_one, @task_two], scope.search_for('duration = 2')
+        assert_empty scope.search_for('duration < "2 seconds"')
+        assert_empty scope.search_for('duration > "2 seconds"')
+        assert_equal [@task_one, @task_two], scope.search_for('duration = "2 seconds"')
+        assert_equal [@task_one, @task_two], scope.search_for('duration <= "2 seconds"')
+        assert_equal [@task_one, @task_two], scope.search_for('duration >= "2 seconds"')
       end
 
       it 'can search by other time intervals' do
         skip unless on_postgresql?
         %w[minutes hours days months years].each do |interval|
-          _(scope.search_for("duration < \"2 #{interval}\"")).must_equal [@task_one, @task_two]
-          _(scope.search_for("duration > \"2 #{interval}\"")).must_be :empty?
-          _(scope.search_for("duration = \"2 #{interval}\"")).must_be :empty?
-          _(scope.search_for("duration <= \"2 #{interval}\"")).must_equal [@task_one, @task_two]
-          _(scope.search_for("duration >= \"2 #{interval}\"")).must_be :empty?
+          assert_equal [@task_one, @task_two], scope.search_for("duration < \"2 #{interval}\"")
+          assert_empty scope.search_for("duration > \"2 #{interval}\"")
+          assert_empty scope.search_for("duration = \"2 #{interval}\"")
+          assert_equal [@task_one, @task_two], scope.search_for("duration <= \"2 #{interval}\"")
+          assert_empty scope.search_for("duration >= \"2 #{interval}\"")
         end
       end
 
       it 'raises an exception if duration is unknown' do
-        _(proc { ForemanTasks::Task.search_for('duration = "25 potatoes"') }).must_raise ScopedSearch::QueryNotSupported
+        assert_raises(ScopedSearch::QueryNotSupported) { ForemanTasks::Task.search_for('duration = "25 potatoes"') }
       end
     end
 
@@ -144,7 +144,7 @@ class TasksTest < ActiveSupport::TestCase
   describe 'users' do
     test 'users can be deleted even if they have tasks assigned' do
       user = FactoryBot.create(:user)
-      FactoryBot.create(:some_task, :user => user)
+      FactoryBot.create(:some_task, user: user)
       user.destroy!
     end
   end
@@ -152,14 +152,14 @@ class TasksTest < ActiveSupport::TestCase
   describe 'state_updated_at' do
     it 'updates the state_updated_at when the state changes' do
       task = FactoryBot.create(:some_task)
-      assert task.state_updated_at > Time.now.utc - 1.minute, "Newly created task has to have state_updated_at set"
+      assert_operator task.state_updated_at, :>, Time.now.utc - 1.minute, "Newly created task has to have state_updated_at set"
       task.update(state_updated_at: nil)
       task.result = 'error'
       task.save
-      assert_not task.state_updated_at, "Other than state change should not affect 'state_updated_at'"
+      assert_nil task.state_updated_at, "Other than state change should not affect 'state_updated_at'"
       task.state = 'running'
       task.save
-      assert task.state_updated_at, "State change should set 'state_updated_at'"
+      assert_not_nil task.state_updated_at, "State change should set 'state_updated_at'"
     end
   end
 
@@ -171,7 +171,7 @@ class TasksTest < ActiveSupport::TestCase
       permission = FactoryBot.build(:permission)
       permission.resource_type = 'ForemanTasks::Task'
       permission.save!
-      FactoryBot.create(:filter, :role => role, :permissions => [permission])
+      FactoryBot.create(:filter, role: role, permissions: [permission])
 
       User.current = user
       task = FactoryBot.create(:dynflow_task)
@@ -184,21 +184,21 @@ class TasksTest < ActiveSupport::TestCase
   describe 'consistency check' do
     it 'ensures the tasks marked as running are really running in Dynflow' do
       task = ForemanTasks.sync_task(Support::DummyDynflowAction)
-      task.update(:state => 'running') # Updating state updates the timestamp
-      task.update(:state_updated_at => Time.zone.now - 5.minutes)
+      task.update(state: 'running') # Updating state updates the timestamp
+      task.update(state_updated_at: Time.zone.now - 5.minutes)
 
       ForemanTasks::Task::DynflowTask.consistency_check
       task.reload
-      _(task.state).must_equal 'stopped'
+      assert_equal 'stopped', task.state
     end
   end
 
   describe 'active job task' do
     it 'when scheduled to the future, the label and action is set properly' do
-      job = Support::DummyActiveJob.set(:wait => 12.hours).perform_later
-      task = ForemanTasks::Task.find_by!(:external_id => job.provider_job_id)
-      _(task.action).must_equal "Dummy action"
-      _(task.label).must_equal "Support::DummyActiveJob"
+      job = Support::DummyActiveJob.set(wait: 12.hours).perform_later
+      task = ForemanTasks::Task.find_by!(external_id: job.provider_job_id)
+      assert_equal "Dummy action", task.action
+      assert_equal "Support::DummyActiveJob", task.label
     end
   end
 
@@ -214,9 +214,9 @@ class TasksTest < ActiveSupport::TestCase
     end
 
     it 'handles the error while loading the task and does not propagate errors unless necessary' do
-      task.cancellable?
-      task.resumable?
-      task.main_action
+      assert_nothing_raised { task.cancellable? }
+      assert_nothing_raised { task.resumable? }
+      assert_nothing_raised { task.main_action }
       assert_equal 'Support::DummyDynflowAction', task.get_humanized(:humanized_name)
       assert_equal 0, task.progress
       assert_raises(KeyError) { task.cancel }
@@ -226,19 +226,19 @@ class TasksTest < ActiveSupport::TestCase
   describe 'subtask count querying' do
     let(:result_base) do
       {
-        :error     => 0,
-        :warning   => 0,
-        :total     => 0,
-        :success   => 0,
-        :cancelled => 0,
-        :pending   => 0,
+        error: 0,
+        warning: 0,
+        total: 0,
+        success: 0,
+        cancelled: 0,
+        pending: 0,
       }
     end
     let(:task) { FactoryBot.create(:dynflow_task) }
 
     describe 'without sub tasks' do
       it 'calculates the progress report correctly' do
-        _(task.sub_tasks_counts).must_equal result_base
+        assert_equal result_base, task.sub_tasks_counts
       end
     end
 
@@ -248,22 +248,22 @@ class TasksTest < ActiveSupport::TestCase
       before { task.sub_tasks = [success, failed] }
 
       it 'calculate the progress report correctly' do
-        expected_result = result_base.merge(:success => 1, :error => 1, :total => 2)
-        _(task.sub_tasks_counts).must_equal expected_result
+        expected_result = result_base.merge(success: 1, error: 1, total: 2)
+        assert_equal expected_result, task.sub_tasks_counts
       end
 
       it 'calculates the progress report correctly when using batch planning' do
-        result_base = self.result_base.merge(:success => 1, :error => 1, :total => 25)
-        fake_action = OpenStruct.new(:total_count => 25)
+        result_base = self.result_base.merge(success: 1, error: 1, total: 25)
+        fake_action = OpenStruct.new(total_count: 25)
         task.stubs(:main_action).returns(fake_action)
 
         task.state = 'stopped'
-        expected_result = result_base.merge(:cancelled => 23)
-        _(task.sub_tasks_counts).must_equal expected_result
+        expected_result = result_base.merge(cancelled: 23)
+        assert_equal expected_result, task.sub_tasks_counts
 
         task.state = 'pending'
-        expected_result = result_base.merge(:pending => 23)
-        _(task.sub_tasks_counts).must_equal expected_result
+        expected_result = result_base.merge(pending: 23)
+        assert_equal expected_result, task.sub_tasks_counts
       end
     end
   end
@@ -284,11 +284,11 @@ class TasksTest < ActiveSupport::TestCase
     let(:task) { FactoryBot.create(:some_task) }
 
     it 'can indicate it is delayed' do
-      assert_not task.delayed?
-      _(task.execution_type).must_equal 'Immediate'
+      assert_not_predicate task, :delayed?
+      assert_equal 'Immediate', task.execution_type
       task.start_at = Time.now.utc + 100
-      assert task.delayed?
-      _(task.execution_type).must_equal 'Delayed'
+      assert_predicate task, :delayed?
+      assert_equal 'Delayed', task.execution_type
     end
   end