foreman-tasks 4.1.6 → 5.0.0

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreman-tasks
 version: !ruby/object:Gem::Version
-  version: 4.1.6
+  version: 5.0.0
 platform: ruby
 authors:
 - Ivan Nečas
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-05-06 00:00:00.000000000 Z
+date: 2021-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dynflow
@@ -24,20 +24,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.2.3
-- !ruby/object:Gem::Dependency
-  name: foreman-tasks-core
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: get_process_mem
   requirement: !ruby/object:Gem::Requirement
@@ -147,6 +133,9 @@ files:
 - app/controllers/foreman_tasks/react_controller.rb
 - app/controllers/foreman_tasks/recurring_logics_controller.rb
 - app/controllers/foreman_tasks/tasks_controller.rb
+- app/graphql/types/recurring_logic.rb
+- app/graphql/types/task.rb
+- app/graphql/types/triggering.rb
 - app/helpers/foreman_tasks/foreman_tasks_helper.rb
 - app/helpers/foreman_tasks/tasks_helper.rb
 - app/lib/actions/action_with_sub_plans.rb
@@ -198,6 +187,7 @@ files:
 - app/models/foreman_tasks/task_groups/recurring_logic_task_group.rb
 - app/models/foreman_tasks/triggering.rb
 - app/models/setting/foreman_tasks.rb
+- app/services/foreman_tasks/dashboard_table_filter.rb
 - app/services/foreman_tasks/proxy_selector.rb
 - app/services/foreman_tasks/troubleshooting_help_generator.rb
 - app/services/ui_notifications/tasks.rb
@@ -273,6 +263,7 @@ files:
 - lib/foreman_tasks.rb
 - lib/foreman_tasks/authorizer_ext.rb
 - lib/foreman_tasks/cleaner.rb
+- lib/foreman_tasks/continuous_output.rb
 - lib/foreman_tasks/dynflow.rb
 - lib/foreman_tasks/dynflow/configuration.rb
 - lib/foreman_tasks/dynflow/console_authorizer.rb
@@ -306,14 +297,14 @@ files:
 - test/controllers/api/tasks_controller_test.rb
 - test/controllers/recurring_logics_controller_test.rb
 - test/controllers/tasks_controller_test.rb
-- test/core/unit/dispatcher_test.rb
-- test/core/unit/runner_test.rb
-- test/core/unit/task_launcher_test.rb
 - test/factories/recurring_logic_factory.rb
 - test/factories/task_factory.rb
 - test/factories/triggering_factory.rb
-- test/foreman_tasks_core_test_helper.rb
 - test/foreman_tasks_test_helper.rb
+- test/graphql/queries/recurring_logic_test.rb
+- test/graphql/queries/recurring_logics_query_test.rb
+- test/graphql/queries/task_query_test.rb
+- test/graphql/queries/tasks_query_test.rb
 - test/helpers/foreman_tasks/foreman_tasks_helper_test.rb
 - test/helpers/foreman_tasks/tasks_helper_test.rb
 - test/lib/actions/middleware/keep_current_request_id_test.rb
@@ -334,9 +325,9 @@ files:
 - test/unit/actions/recurring_action_test.rb
 - test/unit/cleaner_test.rb
 - test/unit/config/environment.rb
+- test/unit/dashboard_table_filter_test.rb
 - test/unit/dynflow_console_authorizer_test.rb
 - test/unit/locking_test.rb
-- test/unit/otp_manager_test.rb
 - test/unit/proxy_selector_test.rb
 - test/unit/recurring_logic_test.rb
 - test/unit/remote_task_test.rb
@@ -611,7 +602,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.1.2
 signing_key:
 specification_version: 4
 summary: Foreman plugin for showing tasks information for resources and users
@@ -620,14 +611,14 @@ test_files:
 - test/controllers/api/tasks_controller_test.rb
 - test/controllers/recurring_logics_controller_test.rb
 - test/controllers/tasks_controller_test.rb
-- test/core/unit/dispatcher_test.rb
-- test/core/unit/runner_test.rb
-- test/core/unit/task_launcher_test.rb
 - test/factories/recurring_logic_factory.rb
 - test/factories/task_factory.rb
 - test/factories/triggering_factory.rb
-- test/foreman_tasks_core_test_helper.rb
 - test/foreman_tasks_test_helper.rb
+- test/graphql/queries/recurring_logic_test.rb
+- test/graphql/queries/recurring_logics_query_test.rb
+- test/graphql/queries/task_query_test.rb
+- test/graphql/queries/tasks_query_test.rb
 - test/helpers/foreman_tasks/foreman_tasks_helper_test.rb
 - test/helpers/foreman_tasks/tasks_helper_test.rb
 - test/lib/actions/middleware/keep_current_request_id_test.rb
@@ -648,9 +639,9 @@ test_files:
 - test/unit/actions/recurring_action_test.rb
 - test/unit/cleaner_test.rb
 - test/unit/config/environment.rb
+- test/unit/dashboard_table_filter_test.rb
 - test/unit/dynflow_console_authorizer_test.rb
 - test/unit/locking_test.rb
-- test/unit/otp_manager_test.rb
 - test/unit/proxy_selector_test.rb
 - test/unit/recurring_logic_test.rb
 - test/unit/remote_task_test.rb

data/test/core/unit/dispatcher_test.rb

@@ -1,43 +0,0 @@
-require 'foreman_tasks_core_test_helper'
-require 'foreman_tasks/test_helpers'
-require 'foreman_tasks_core/runner'
-
-module ForemanTasksCore
-  module Runner
-    describe Dispatcher::RunnerActor do
-      include ForemanTasks::TestHelpers::WithInThreadExecutor
-
-      let(:dispatcher) { Dispatcher.instance }
-      let(:suspended_action) { mock }
-      let(:runner) { mock.tap { |r| r.stubs(:id) } }
-      let(:clock) { ForemanTasks.dynflow.world.clock }
-      let(:logger) { mock.tap { |l| l.stubs(:debug) } }
-      let(:actor) do
-        Dispatcher::RunnerActor.new dispatcher, suspended_action, runner, clock, logger
-      end
-
-      it 'delivers all updates to actions' do
-        targets = (0..2).map { mock }.each_with_index { |mock, index| mock.expects(:<<).with(index) }
-        updates = targets.each_with_index.reduce({}) { |acc, (cur, index)| acc.merge(cur => index) }
-        runner.expects(:run_refresh).returns(updates)
-        actor.expects(:plan_next_refresh)
-        actor.refresh_runner
-      end
-
-      it 'plans next refresh' do
-        runner.expects(:run_refresh).returns({})
-        actor.expects(:plan_next_refresh)
-        actor.refresh_runner
-      end
-
-      it 'does not plan next resfresh if done' do
-        update = Update.new(nil, 0)
-        suspended_action.expects(:<<).with(update)
-        runner.expects(:run_refresh).returns(suspended_action => update)
-        dispatcher.expects(:finish)
-        dispatcher.ticker.expects(:tell).never
-        actor.refresh_runner
-      end
-    end
-  end
-end

data/test/core/unit/runner_test.rb

@@ -1,116 +0,0 @@
-require 'foreman_tasks_core_test_helper'
-require 'foreman_tasks/test_helpers'
-require 'foreman_tasks_core/runner'
-require 'ostruct'
-
-module ForemanTasksCore
-  module Runner
-    class RunnerTest < ActiveSupport::TestCase
-      include ForemanTasks::TestHelpers::WithInThreadExecutor
-
-      describe Base do
-        let(:suspended_action) { Class.new }
-        let(:runner) { Base.new suspended_action: suspended_action }
-
-        describe '#generate_updates' do
-          it 'returns empty hash when there are no outputs' do
-            _(runner.generate_updates).must_be :empty?
-          end
-
-          it 'returns a hash with outputs' do
-            message = 'a message'
-            type = 'stdout'
-            runner.publish_data(message, type)
-            updates = runner.generate_updates
-            _(updates.keys).must_equal [suspended_action]
-            update = updates.values.first
-            _(update.exit_status).must_be :nil?
-            _(update.continuous_output.raw_outputs.count).must_equal 1
-          end
-
-          it 'works in compatibility mode' do
-            runner = Base.new
-            message = 'a message'
-            type = 'stdout'
-            runner.publish_data(message, type)
-            updates = runner.generate_updates
-            _(updates.keys).must_equal [nil]
-            update = updates.values.first
-            _(update.exit_status).must_be :nil?
-            _(update.continuous_output.raw_outputs.count).must_equal 1
-          end
-        end
-      end
-
-      describe Parent do
-        let(:suspended_action) { ::Dynflow::Action::Suspended.allocate }
-        let(:runner) { Parent.new targets, suspended_action: suspended_action }
-        let(:targets) do
-          { 'foo' => { 'execution_plan_id' => '123', 'run_step_id' => 2 },
-            'bar' => { 'execution_plan_id' => '456', 'run_step_id' => 2 } }
-        end
-
-        describe '#initialize_continuous_outputs' do
-          it 'initializes outputs for targets and parent' do
-            outputs = runner.initialize_continuous_outputs
-            _(outputs.keys.count).must_equal 2
-            outputs.values.each { |output| _(output).must_be_instance_of ContinuousOutput }
-          end
-        end
-
-        describe '#generate_updates' do
-          it 'returns only updates for hosts with pending outputs' do
-            _(runner.generate_updates).must_equal({})
-            runner.publish_data_for('foo', 'something', 'something')
-            updates = runner.generate_updates
-            _(updates.keys.count).must_equal 1
-          end
-
-          it 'works without compatibility mode' do
-            runner.broadcast_data('something', 'stdout')
-            updates = runner.generate_updates
-            _(updates.keys.count).must_equal 2
-            updates.keys.each do |key|
-              _(key).must_be_instance_of ::Dynflow::Action::Suspended
-            end
-          end
-        end
-
-        describe '#publish_data_for' do
-          it 'publishes data for a single host' do
-            runner.publish_data_for('foo', 'message', 'stdout')
-            _(runner.generate_updates.keys.count).must_equal 1
-          end
-        end
-
-        describe '#broadcast_data' do
-          it 'publishes data for all hosts' do
-            runner.broadcast_data('message', 'stdout')
-            _(runner.generate_updates.keys.count).must_equal 2
-          end
-        end
-
-        describe '#publish_exception' do
-          let(:exception) do
-            exception = RuntimeError.new
-            exception.stubs(:backtrace).returns([])
-            exception
-          end
-
-          before { runner.logger.stubs(:error) }
-
-          it 'broadcasts the exception to all targets' do
-            runner.expects(:publish_exit_status).never
-            runner.publish_exception('general failure', exception, false)
-            _(runner.generate_updates.keys.count).must_equal 2
-          end
-
-          it 'publishes exit status if fatal' do
-            runner.expects(:publish_exit_status)
-            runner.publish_exception('general failure', exception, true)
-          end
-        end
-      end
-    end
-  end
-end

data/test/core/unit/task_launcher_test.rb

@@ -1,56 +0,0 @@
-require 'foreman_tasks_core_test_helper'
-require 'foreman_tasks/test_helpers'
-
-module ForemanTasksCore
-  module TaskLauncher
-    class TaskLauncherTest < ActiveSupport::TestCase
-      include ForemanTasks::TestHelpers::WithInThreadExecutor
-
-      describe ForemanTasksCore::TaskLauncher do
-        let(:launcher) { launcher_class.new ForemanTasks.dynflow.world, {} }
-        let(:launcher_input) { { 'action_class' => Support::DummyDynflowAction.to_s, 'action_input' => input } }
-        let(:input) { { :do => :something } }
-        let(:expected_result) { input.merge(:callback_host => {}) }
-
-        describe ForemanTasksCore::TaskLauncher::Single do
-          let(:launcher_class) { Single }
-
-          it 'triggers an action' do
-            Support::DummyDynflowAction.any_instance.expects(:plan).with do |arg|
-              _(arg).must_equal(expected_result)
-            end
-            launcher.launch!(launcher_input)
-          end
-
-          it 'provides results' do
-            plan = launcher.launch!(launcher_input).finished.value!
-            _(launcher.results[:result]).must_equal 'success'
-            _(plan.result).must_equal :success
-          end
-        end
-
-        describe ForemanTasksCore::TaskLauncher::Batch do
-          let(:launcher_class) { Batch }
-
-          it 'triggers the actions' do
-            Support::DummyDynflowAction.any_instance.expects(:plan).with { |arg| arg == expected_result }.twice
-            parent = launcher.launch!('foo' => launcher_input, 'bar' => launcher_input)
-            plan = parent.finished.value!
-            _(plan.result).must_equal :success
-            _(plan.sub_plans.count).must_equal 2
-          end
-
-          it 'provides results' do
-            launcher.launch!('foo' => launcher_input, 'bar' => launcher_input)
-            _(launcher.results.keys).must_equal %w[foo bar]
-            launcher.results.values.each do |result|
-              plan = ForemanTasks.dynflow.world.persistence.load_execution_plan(result[:task_id])
-              _(result[:result]).must_equal 'success'
-              _(plan.result).must_equal :success
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/test/foreman_tasks_core_test_helper.rb

@@ -1,4 +0,0 @@
-require 'foreman_tasks_test_helper'
-require 'foreman_tasks_core'
-
-ForemanTasksCore.dynflow_setup ForemanTasks.dynflow.world

data/test/unit/otp_manager_test.rb

@@ -1,77 +0,0 @@
-require 'foreman_tasks_test_helper'
-require 'foreman_tasks_core/otp_manager'
-
-module ForemanTasksCore
-  class OtpManagerTest < ActiveSupport::TestCase
-    class TestOtpManager < OtpManager
-      def self.reset!
-        @passwords = nil
-      end
-    end
-
-    def try_to_authenticate(username, password)
-      TestOtpManager.authenticate(OtpManager.tokenize(username, password))
-    end
-
-    before do
-      TestOtpManager.reset!
-    end
-
-    let(:username) { 'myuser' }
-    let(:password) { '123456789' }
-    let(:base64)   { 'bXl1c2VyOjEyMzQ1Njc4OQ==' }
-
-    it 'it doesn\'t raise when no passwords were generated yet' do
-      assert_not try_to_authenticate('missing', 'password')
-    end
-
-    it 'generates OTPs using SecureRandom.hex and converts them to strings' do
-      otp = 4
-      SecureRandom.stubs(:hex).returns(otp)
-      _(TestOtpManager.generate_otp(username)).must_equal otp.to_s
-    end
-
-    it 'provides #drop_otp method that removes OTP only when correct username and password is provided' do
-      otp = TestOtpManager.generate_otp(username)
-      assert_not TestOtpManager.drop_otp('wrong_username', 'wrong_password')
-      assert_not TestOtpManager.drop_otp(username, 'wrong_password')
-      assert_not TestOtpManager.drop_otp('wrong_username', otp)
-      assert TestOtpManager.drop_otp(username, otp)
-    end
-
-    it 'authenticate removes OTP only when correct username and password is provided' do
-      otp = TestOtpManager.generate_otp(username)
-      assert_not try_to_authenticate('wrong_username', 'wrong_password')
-      assert_not try_to_authenticate(username, 'wrong_password')
-      assert_not try_to_authenticate(username, 'wrong_password')
-      assert_not try_to_authenticate('wrong_username', otp)
-      assert try_to_authenticate(username, otp)
-    end
-
-    it 'authenticates correctly' do
-      SecureRandom.stubs(:hex).returns(password)
-      TestOtpManager.generate_otp(username)
-
-      assert TestOtpManager.authenticate(base64)
-    end
-
-    it 'OTPs can be used only once' do
-      SecureRandom.stubs(:hex).returns(password)
-      TestOtpManager.generate_otp(username)
-
-      assert TestOtpManager.authenticate(base64)
-      assert_not TestOtpManager.authenticate(base64)
-    end
-
-    it 'creates token from username and password correctly' do
-      _(TestOtpManager.tokenize(username, password)).must_equal base64
-    end
-
-    it 'overwrites old OTP when generating a new one for the same username' do
-      old = TestOtpManager.generate_otp(username)
-      new = TestOtpManager.generate_otp(username)
-      assert_not try_to_authenticate(username, old)
-      assert try_to_authenticate(username, new)
-    end
-  end
-end