foreman-tasks 12.0.0 → 12.1.0

data/webpack/ForemanTasks/Components/TasksTable/__tests__/TasksTable.fixtures.js

@@ -1,45 +1,218 @@
 import { STATUS } from 'foremanReact/constants';
 
-export const minProps = {
-  getTableItems: jest.fn(),
-  getBreadcrumbs: jest.fn(),
-  itemCount: 2,
-  selectPage: jest.fn(),
-  selectAllRows: jest.fn(),
-  unselectAllRows: jest.fn(),
-  selectRow: jest.fn(),
-  unselectRow: jest.fn(),
-  reloadPage: jest.fn(),
-  selectedRows: [],
-  perPage: 10,
-  history: { location: { search: '' } },
-  results: ['a', 'b'],
-  sort: {
-    by: 'q',
-    order: 'w',
-  },
-  openClickedModal: jest.fn(),
-  openModalAction: jest.fn(),
-  openModal: jest.fn(),
-};
-
-export default {
-  'render with minimal Props': {
-    ...minProps,
-  },
-  'render with no results': {
-    ...minProps,
-    results: [],
-    status: STATUS.RESOLVED,
-  },
-  'render with error Props': {
-    ...minProps,
-    results: ['a'],
-    status: STATUS.ERROR,
-  },
-  'render with loading Props': {
-    ...minProps,
-    results: ['a'],
-    status: STATUS.PENDING,
+export const tasksSuccessResponse = {
+  status: STATUS.RESOLVED,
+  response: {
+    total: 1236,
+    subtotal: 1236,
+    page: 1,
+    per_page: 5,
+    search: null,
+    can_create: true,
+    can_edit: true,
+    sort: {
+      by: 'started_at',
+      order: 'DESC',
+    },
+    results: [
+      {
+        id: '0cf9deae-e5d9-44b6-a09a-abe59ac842b6',
+        label: 'Actions::RemoteExecution::RunHostsJob',
+        pending: false,
+        action: '»»Run hosts job««:',
+        username: 'admin',
+        started_at: null,
+        ended_at: '2025-01-28 12:00:10 +0000',
+        duration: '0',
+        state: 'stopped',
+        result: 'error',
+        progress: 1,
+        input: {},
+        output: {},
+        humanized: {
+          action: '»»Run hosts job««:',
+          input: '',
+          output: null,
+          errors: [
+            'undefined method `template_inputs_with_foreign\' for #<JobTemplate id: 192, name: "Demo template", template: "<%= input(\\"command\\") %>\\n<%= input(\\"search\\") %>", snippet: false, template_kind_id: nil, created_at: "2024-12-10 16:29:15.574825000 +0000", updated_at: "2025-01-24 18:07:07.794425000 +0000", locked: false, default: false, vendor: nil, type: "JobTemplate", os_family: nil, description: "", job_category: "Commands", provider_type: "script", description_format: "Run %{command}", execution_timeout_interval: nil, cloned_from_id: nil, ansible_callback_enabled: false>\nDid you mean?  template_inputs',
+          ],
+        },
+        cli_example: null,
+        start_at: '2025-01-28 12:00:10 +0000',
+        can_edit: true,
+        can_delete: true,
+        available_actions: {
+          cancellable: true,
+          resumable: false,
+        },
+      },
+      {
+        id: '0ff5124e-0851-430a-a831-7e50971a80dc',
+        label: 'StoredValuesCleanupJob',
+        pending: false,
+        action: 'StoredValuesCleanupJob',
+        username: 'admin',
+        started_at: null,
+        ended_at: '2025-11-17 10:51:21 +0000',
+        duration: '0',
+        state: 'stopped',
+        result: 'cancelled',
+        progress: 1,
+        input: null,
+        output: null,
+        humanized: {
+          action: 'StoredValuesCleanupJob',
+          input: null,
+          output: null,
+          errors: null,
+        },
+        cli_example: null,
+        start_at: '2025-11-17 22:50:45 +0000',
+        can_edit: true,
+        can_delete: true,
+        available_actions: {
+          cancellable: false,
+          resumable: false,
+        },
+      },
+      {
+        id: '4aa47ed6-dbfc-4262-8637-6b204e80a06d',
+        label: 'Actions::RemoteExecution::RunHostsJob',
+        pending: false,
+        action: '»»Run hosts job««: Run echo',
+        username: 'admin',
+        started_at: null,
+        ended_at: '2025-07-21 17:14:01 +0100',
+        duration: '0',
+        state: 'stopped',
+        result: 'cancelled',
+        progress: 1,
+        input: {
+          job_invocation: {
+            id: 62,
+            name: 'Commands',
+            description: 'Run echo',
+          },
+          current_request_id: '2503edc5-51e5-447d-bdd2-512468535eba',
+          current_timezone: 'Europe/London',
+          current_organization_id: null,
+          current_location_id: null,
+          current_user_id: 4,
+        },
+        output: {},
+        humanized: {
+          action: '»»Run hosts job««:',
+          input: 'Run echo',
+          output: null,
+          errors: [],
+        },
+        cli_example: null,
+        start_at: '2026-07-21 12:56:00 +0100',
+        can_edit: true,
+        can_delete: true,
+        available_actions: {
+          cancellable: false,
+          resumable: true,
+        },
+      },
+      {
+        id: '53bed58a-2cda-4047-bcf6-71141ca06ba5',
+        label: 'Actions::RemoteExecution::RunHostsJob',
+        pending: false,
+        action: '»»Run hosts job««: Run ls',
+        username: 'admin',
+        started_at: null,
+        ended_at: '2025-11-26 17:35:36 +0000',
+        duration: '0',
+        state: 'stopped',
+        result: 'cancelled',
+        progress: 1,
+        input: {
+          job_invocation: {
+            id: 70,
+            name: 'Commands',
+            description: 'Run ls',
+          },
+          current_request_id: '8cfe5ca7-c48b-4dfb-a1c4-29505300c4b9',
+          current_timezone: 'Europe/London',
+          current_organization_id: 1,
+          current_location_id: 2,
+          current_user_id: 4,
+        },
+        output: {},
+        humanized: {
+          action: '»»Run hosts job««:',
+          input: 'Run ls',
+          output: null,
+          errors: [],
+        },
+        cli_example: null,
+        start_at: '2026-09-25 15:17:00 +0100',
+        can_edit: true,
+        can_delete: true,
+        available_actions: {
+          cancellable: false,
+          resumable: false,
+        },
+      },
+      {
+        id: '58276bf0-67c3-4452-b5f3-6fd90c4997b3',
+        label: 'jobLabel1',
+        pending: false,
+        action: 'jobLabel1',
+        username: 'admin',
+        started_at: null,
+        ended_at: '2026-03-05 14:30:55 +0000',
+        duration: '0',
+        state: 'stopped',
+        result: 'pending',
+        progress: 1,
+        input: null,
+        output: null,
+        humanized: {
+          action: 'jobLabel1',
+          input: null,
+          output: null,
+          errors: null,
+        },
+        cli_example: null,
+        start_at: '2026-03-05 22:40:34 +0000',
+        can_edit: true,
+        can_delete: true,
+        available_actions: {
+          cancellable: false,
+          resumable: false,
+        },
+      },
+      {
+        id: 'a1b2c3d4-e5f6-7890-abcd-ef1234567890',
+        label: 'Actions::RemoteExecution::RunHostsJob',
+        pending: false,
+        action: 'Running job',
+        username: 'admin',
+        started_at: '2026-03-10 10:00:00 +0000',
+        ended_at: '2026-03-10 10:00:00 +0000',
+        duration: '0',
+        state: 'running',
+        result: 'pending',
+        progress: 0.5,
+        input: null,
+        output: null,
+        humanized: {
+          action: 'Running job',
+          input: null,
+          output: null,
+          errors: null,
+        },
+        cli_example: null,
+        start_at: '2026-03-10 10:00:00 +0000',
+        can_edit: true,
+        can_delete: true,
+        available_actions: {
+          cancellable: false,
+          resumable: false,
+        },
+      },
+    ],
   },
 };

data/webpack/ForemanTasks/Components/TasksTable/__tests__/TasksTableHelpers.test.js

@@ -5,8 +5,8 @@ describe('updateURlQuery', () => {
     const history = {
       push: jest.fn(),
       location: {
-        pathname:
-          '/foreman_tasks/tasks/?state=stopped&result=error&page=1&per_page=20',
+        pathname: '/foreman_tasks/tasks/',
+        search: '?state=stopped&result=error&page=1&per_page=20',
       },
     };
     const query = { time_mode: 'recent', per_page: 35 };
@@ -28,17 +28,25 @@ describe('updateURlQuery', () => {
 });
 
 describe('getCSVurl', () => {
-  it('should return currect url for tasks with search', () => {
-    const url = '/foreman_tasks/tasks';
-    const query = { state: 'stopped' };
-    expect(getCSVurl(url, query)).toEqual(
-      '/foreman_tasks/tasks.csv?search=%28state%3Dstopped%29'
-    );
+  const originalLocation = window.location;
+
+  beforeEach(() => {
+    delete window.location;
+  });
+
+  afterEach(() => {
+    window.location = originalLocation;
   });
-  it('should return currect url for subtasks', () => {
-    const url = '/foreman_tasks/tasks/some-id/sub_tasks';
-    expect(getCSVurl(url, {})).toEqual(
-      '/foreman_tasks/tasks/some-id/sub_tasks.csv'
+
+  it('should return correct url for subtasks', () => {
+    window.location = new URL(
+      'https://test.example.com/foreman_tasks/tasks/some-id/sub_tasks'
     );
+    expect(getCSVurl()).toEqual('/foreman_tasks/tasks/some-id/sub_tasks.csv');
+  });
+
+  it('should append .csv to current pathname', () => {
+    window.location = new URL('https://test.example.com/foreman_tasks/tasks');
+    expect(getCSVurl()).toMatch(/^\/foreman_tasks\/tasks\.csv/);
   });
 });

data/webpack/ForemanTasks/Components/TasksTable/__tests__/__snapshots__/TasksBulkActions.test.js.snap

@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`TasksTable bulk actions handles bulkCancelById requests 1`] = `
+exports[`TasksBulkActions Test reloadPage callback handles bulkCancelById requests 1`] = `
 Array [
   Array [
     Object {
@@ -23,16 +23,11 @@ Array [
       "type": "TOASTS_ADD",
     },
   ],
-  Array [
-    "TASKS_TABLE",
-  ],
-  Array [
-    [Function],
-  ],
 ]
 `;
 
-exports[`TasksTable bulk actions handles bulkCancelById requests that are not cancellable 1`] = `
+
+exports[`TasksBulkActions handles bulkCancelById requests that are not cancellable 1`] = `
 Array [
   Array [
     Object {
@@ -48,7 +43,7 @@ Array [
 ]
 `;
 
-exports[`TasksTable bulk actions handles bulkCancelById requests with canEdit false 1`] = `
+exports[`TasksBulkActions handles bulkCancelById requests with canEdit false 1`] = `
 Array [
   Array [
     Object {
@@ -64,7 +59,7 @@ Array [
 ]
 `;
 
-exports[`TasksTable bulk actions handles bulkCancelBySearch requests 1`] = `
+exports[`TasksBulkActions handles bulkCancelBySearch requests 1`] = `
 Array [
   Array [
     Object {
@@ -85,7 +80,7 @@ Array [
 ]
 `;
 
-exports[`TasksTable bulk actions handles bulkForceCancelById requests 1`] = `
+exports[`TasksBulkActions Test reloadPage callback handles bulkForceCancelById requests 1`] = `
 Array [
   Array [
     Object {
@@ -119,16 +114,11 @@ Array [
       "type": "TOASTS_ADD",
     },
   ],
-  Array [
-    "TASKS_TABLE",
-  ],
-  Array [
-    [Function],
-  ],
 ]
 `;
 
-exports[`TasksTable bulk actions handles bulkForceCancelById requests that are stopped 1`] = `
+
+exports[`TasksBulkActions handles bulkForceCancelById requests that are stopped 1`] = `
 Array [
   Array [
     Object {
@@ -144,7 +134,7 @@ Array [
 ]
 `;
 
-exports[`TasksTable bulk actions handles bulkForceCancelById requests that fail 1`] = `
+exports[`TasksBulkActions handles bulkForceCancelById requests that fail 1`] = `
 Array [
   Array [
     Object {
@@ -171,7 +161,7 @@ Array [
 ]
 `;
 
-exports[`TasksTable bulk actions handles bulkForceCancelById requests with canEdit false 1`] = `
+exports[`TasksBulkActions handles bulkForceCancelById requests with canEdit false 1`] = `
 Array [
   Array [
     Object {
@@ -187,7 +177,7 @@ Array [
 ]
 `;
 
-exports[`TasksTable bulk actions handles bulkForceCancelBySearch requests 1`] = `
+exports[`TasksBulkActions handles bulkForceCancelBySearch requests 1`] = `
 Array [
   Array [
     Object {
@@ -208,7 +198,7 @@ Array [
 ]
 `;
 
-exports[`TasksTable bulk actions handles bulkResumeById requests that are not resumable 1`] = `
+exports[`TasksBulkActions handles bulkResumeById requests that are not resumable 1`] = `
 Array [
   Array [
     Object {
@@ -224,7 +214,7 @@ Array [
 ]
 `;
 
-exports[`TasksTable bulk actions handles bulkResumeById requests that fail 1`] = `
+exports[`TasksBulkActions handles bulkResumeById requests that fail 1`] = `
 Array [
   Array [
     Object {
@@ -251,7 +241,7 @@ Array [
 ]
 `;
 
-exports[`TasksTable bulk actions handles bulkResumeById requests with canEdit false 1`] = `
+exports[`TasksBulkActions handles bulkResumeById requests with canEdit false 1`] = `
 Array [
   Array [
     Object {
@@ -267,7 +257,7 @@ Array [
 ]
 `;
 
-exports[`TasksTable bulk actions handles bulkResumeBySearch requests 1`] = `
+exports[`TasksBulkActions handles bulkResumeBySearch requests 1`] = `
 Array [
   Array [
     Object {
@@ -288,7 +278,7 @@ Array [
 ]
 `;
 
-exports[`TasksTable bulk actions handles resumable bulkResumeById requests 1`] = `
+exports[`TasksBulkActions Test reloadPage callback handles resumable bulkResumeById requests 1`] = `
 Array [
   Array [
     Object {
@@ -322,16 +312,9 @@ Array [
       "type": "TOASTS_ADD",
     },
   ],
-  Array [
-    "TASKS_TABLE",
-  ],
-  Array [
-    [Function],
-  ],
 ]
 `;
-
-exports[`TasksTable bulk actions handles skipped bulkCancelById requests 1`] = `
+exports[`TasksBulkActions handles skipped bulkCancelById requests 1`] = `
 Array [
   Array [
     Object {
@@ -357,7 +340,7 @@ Array [
 ]
 `;
 
-exports[`TasksTable bulk actions handles skipped bulkResumeById requests 1`] = `
+exports[`TasksBulkActions handles skipped bulkResumeById requests 1`] = `
 Array [
   Array [
     Object {

data/webpack/ForemanTasks/ForemanTasksReducers.js

@@ -1,13 +1,9 @@
 import { combineReducers } from 'redux';
 import { reducers as tasksDashboardReducers } from './Components/TasksDashboard';
-import { reducers as tasksTableReducers } from './Components/TasksTable';
-import { reducers as confirmModalReducers } from './Components/TasksTable/Components/ConfirmModal';
 
 const reducers = {
   foremanTasks: combineReducers({
     ...tasksDashboardReducers,
-    ...tasksTableReducers,
-    ...confirmModalReducers,
   }),
 };
 

data/webpack/Routes/routes.js

@@ -0,0 +1,22 @@
+import React from 'react';
+import TasksTableIndexPage from '../ForemanTasks/Components/TasksTable/TasksIndexPage';
+import ShowTask from '../ForemanTasks/Routes/ShowTask/ShowTask';
+
+const ForemanTasksRoutes = [
+  {
+    path: '/foreman_tasks/tasks',
+    exact: true,
+    render: props => <TasksTableIndexPage {...props} />,
+  },
+  {
+    path: '/foreman_tasks/tasks/:id/sub_tasks',
+    exact: true,
+    render: props => <TasksTableIndexPage {...props} />,
+  },
+  {
+    path: '/foreman_tasks/ex_tasks/:id',
+    render: props => <ShowTask {...props} />,
+  },
+];
+
+export default ForemanTasksRoutes;

data/webpack/Routes/routes.test.js

@@ -0,0 +1,95 @@
+import React from 'react';
+import { render, screen } from '@testing-library/react';
+import '@testing-library/jest-dom';
+
+import ForemanTasksRoutes from './routes';
+
+jest.mock(
+  '../ForemanTasks/Components/TasksTable/TasksIndexPage',
+  () =>
+    function TasksTableIndexPageStub() {
+      return <div data-testid="tasks-table-index-stub" />;
+    }
+);
+
+jest.mock(
+  '../ForemanTasks/Routes/ShowTask/ShowTask',
+  () =>
+    function ShowTaskStub() {
+      return <div data-testid="show-task-stub" />;
+    }
+);
+
+const routerProps = {
+  history: { push: jest.fn(), replace: jest.fn(), go: jest.fn() },
+  location: {
+    pathname: '/foreman_tasks/tasks',
+    search: '',
+    hash: '',
+    state: undefined,
+  },
+  match: {
+    params: {},
+    path: '/foreman_tasks/tasks',
+    url: '/foreman_tasks/tasks',
+    isExact: true,
+  },
+};
+
+describe('ForemanTasks routes', () => {
+  it('defines the foreman_tasks React paths', () => {
+    expect(
+      ForemanTasksRoutes.map(({ path, exact }) => ({ path, exact }))
+    ).toEqual([
+      { path: '/foreman_tasks/tasks', exact: true },
+      { path: '/foreman_tasks/tasks/:id/sub_tasks', exact: true },
+      { path: '/foreman_tasks/ex_tasks/:id', exact: undefined },
+    ]);
+  });
+
+  it('each route render returns a mountable page', () => {
+    const propsByIndex = [
+      {
+        ...routerProps,
+        match: {
+          ...routerProps.match,
+          params: {},
+          path: '/foreman_tasks/tasks',
+          url: '/foreman_tasks/tasks',
+        },
+      },
+      {
+        ...routerProps,
+        match: {
+          ...routerProps.match,
+          params: { id: '7' },
+          path: '/foreman_tasks/tasks/:id/sub_tasks',
+          url: '/foreman_tasks/tasks/7/sub_tasks',
+        },
+      },
+      {
+        ...routerProps,
+        match: {
+          ...routerProps.match,
+          params: { id: '42' },
+          path: '/foreman_tasks/ex_tasks/:id',
+          url: '/foreman_tasks/ex_tasks/42',
+        },
+      },
+    ];
+
+    ForemanTasksRoutes.forEach((route, index) => {
+      const { unmount } = render(route.render(propsByIndex[index]));
+
+      if (index === 2) {
+        expect(screen.getByTestId('show-task-stub')).toBeInTheDocument();
+      } else {
+        expect(
+          screen.getByTestId('tasks-table-index-stub')
+        ).toBeInTheDocument();
+      }
+
+      unmount();
+    });
+  });
+});

data/webpack/global_index.js

@@ -0,0 +1,10 @@
+import { registerRoutes } from 'foremanReact/routes/RoutingService';
+import { registerReducer } from 'foremanReact/common/MountingService';
+import routes from './Routes/routes';
+import reducers from './ForemanTasks/ForemanTasksReducers';
+
+Object.entries(reducers).forEach(([key, reducer]) =>
+  registerReducer(key, reducer)
+);
+
+registerRoutes('foreman_tasks', routes);

data/webpack/index.js

@@ -2,23 +2,9 @@
 /* eslint-disable import/no-extraneous-dependencies */
 /* eslint-disable import/extensions */
 import componentRegistry from 'foremanReact/components/componentRegistry';
-import { registerReducer } from 'foremanReact/common/MountingService';
-import reducers from './ForemanTasks/ForemanTasksReducers';
-import ForemanTasks from './ForemanTasks';
 import TasksDashboard from './ForemanTasks/Components/TasksDashboard';
 import TaskDetails from './ForemanTasks/Components/TaskDetails';
-import TasksTable from './ForemanTasks/Components/TasksTable';
 
-// register reducers
-Object.entries(reducers).forEach(([key, reducer]) =>
-  registerReducer(key, reducer)
-);
-
-// register components
-componentRegistry.register({
-  name: 'ForemanTasks',
-  type: ForemanTasks,
-});
 componentRegistry.register({
   name: 'TasksDashboard',
   type: TasksDashboard,
@@ -27,7 +13,3 @@ componentRegistry.register({
   name: 'TaskDetails',
   type: TaskDetails,
 });
-componentRegistry.register({
-  name: 'TasksTable',
-  type: TasksTable,
-});

data/webpack/test_setup.js

@@ -0,0 +1 @@
+import 'foremanJSTestSetup';