foreman-tasks 10.0.2 → 11.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 34be658746dd0f136ff054fa6b9f381b9d2ee3758715219f4709f8b745ea1807
-  data.tar.gz: e4240056a3707edfccf95f90ed86c970f6e76d8eb5f7c1273987786a2dc97fb8
+  metadata.gz: 79bd6594ab916273ed9721d27414688ac717fd041ba33fdc67a1531e0ff0e30c
+  data.tar.gz: 91de29666d6b045b9179f662bda4f645e4532683ec1ff5e397b6f90948e6f32a
 SHA512:
-  metadata.gz: b0a7729b58e671ce34f57adf83c052ca9af2e8e670e3302fa0d1dbee1ec82975f327a8a90fde202b2c68953dbdbdc1fd429330232911b002d2fdca77bf157bad
-  data.tar.gz: 2094c271990a108d4e804bf42f3e5b7464427674a4d46d26b130883ad057069141d2303286a0ee7fec7afbcc01bebd48d4d6c4955a64544107d2a2797cd558ad
+  metadata.gz: 81a6e7b9989f9becb04bf6486ded109c937e9395325ac060d9ce9b027343f44b2be70d44a1b997cb19c15520dabf7bdd654ddf7b017482b09e812fa980a7f103
+  data.tar.gz: ed7f40efaae46bbaec076deb15d0c7ff076fe661f5ad28bff67694070954eeac0229d3304a81375982cf96e9f11b60f7fb94402285310598837e52b0ffcec499

data/.github/workflows/js_tests.yml

@@ -1,33 +1,14 @@
 name: JavaScript Testing
+
 on:
+  push:
+    branches:
+      - master
   pull_request:
-    paths:
-      - 'webpack/**'
-      - 'package.json'
-      - '.github/workflows/js_tests.yml'
 
 jobs:
   test_js:
-    runs-on: ubuntu-latest
-    strategy:
-      fail-fast: false
-      matrix:
-        node-version:
-          - 12
-          - 14
-    steps:
-      - uses: actions/checkout@v2
-      - name: Setup Node
-        uses: actions/setup-node@v1
-        with:
-          node-version: ${{ matrix.node-version }}
-      - name: Npm install
-        run: npm install
-      - name: Run plugin linter
-        run: npm run lint
-      - name: Run plugin tests
-        run: npm run test
-      - name: Publish Coveralls
-        uses: coverallsapp/github-action@master
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
+    name: JavaScript
+    uses: theforeman/actions/.github/workflows/foreman_plugin_js.yml@v0
+    with:
+      plugin: foreman-tasks

data/.github/workflows/release.yml

@@ -0,0 +1,20 @@
+name: Release
+
+on:
+  push:
+    # Pattern matched against refs/tags
+    tags:
+      - '**'
+
+jobs:
+  release:
+    name: Release gem
+    runs-on: ubuntu-latest
+    environment: release
+    if: github.repository_owner == 'theforeman'
+
+    permissions:
+      id-token: write
+
+    steps:
+      - uses: voxpupuli/ruby-release@v0

data/app/models/foreman_tasks/triggering.rb

@@ -38,6 +38,7 @@ module ForemanTasks
                                :if => proc { |t| t.recurring? && t.input_type == :monthly } }
     validate :can_start_recurring, :if => :recurring?
     validate :can_start_future, :if => :future?
+    validate :start_at_is_not_past
 
     def self.new_from_params(params = {})
       new(params.except(:mode, :start_at, :start_before)).tap do |triggering|
@@ -121,5 +122,9 @@ module ForemanTasks
       parse_start_at!
       errors.add(:start_before_raw, _('The task could not be started')) if !start_before.nil? && start_before < start_at
     end
+
+    def start_at_is_not_past
+      errors.add(:start_at, _('is in the past')) if !start_at.nil? && start_at < Time.zone.now
+    end
   end
 end

data/lib/foreman_tasks/engine.rb

@@ -16,121 +16,122 @@ module ForemanTasks
       SETTINGS[:foreman_tasks] = { :assets => { :precompile => assets_to_precompile } }
     end
 
-    initializer 'foreman_tasks.register_plugin', :before => :finisher_hook do |app|
-      app.reloader.to_prepare do
-        Foreman::Plugin.register :"foreman-tasks" do
-          requires_foreman '>= 3.13'
-          divider :top_menu, :parent => :monitor_menu, :last => true, :caption => N_('Foreman Tasks')
-          menu :top_menu, :tasks,
-               :url_hash => { :controller => 'foreman_tasks/tasks', :action => :index },
-               :caption  => N_('Tasks'),
-               :parent   => :monitor_menu,
-               :last     => true
-
-          menu :top_menu, :recurring_logics,
-               :url_hash => { :controller => 'foreman_tasks/recurring_logics', :action => :index },
-               :caption  => N_('Recurring Logics'),
-               :parent   => :monitor_menu,
-               :last     => true
-
-          security_block :foreman_tasks do |_map|
-            permission :view_foreman_tasks, { :'foreman_tasks/tasks' => [:auto_complete_search, :sub_tasks, :index, :summary, :summary_sub_tasks, :show],
-                                              :'foreman_tasks/react' => [:index],
-                                              :'foreman_tasks/api/tasks' => [:bulk_search, :show, :index, :summary, :summary_sub_tasks, :details, :sub_tasks] }, :resource_type => 'ForemanTasks::Task'
-            permission :edit_foreman_tasks, { :'foreman_tasks/tasks' => [:resume, :unlock, :force_unlock, :cancel_step, :cancel, :abort],
-                                              :'foreman_tasks/api/tasks' => [:bulk_resume, :bulk_cancel, :bulk_stop] }, :resource_type => 'ForemanTasks::Task'
-
-            permission :create_recurring_logics, {}, :resource_type => 'ForemanTasks::RecurringLogic'
-
-            permission :view_recurring_logics, { :'foreman_tasks/recurring_logics' => [:auto_complete_search, :index, :show],
-                                                 :'foreman_tasks/api/recurring_logics' => [:index, :show] }, :resource_type => 'ForemanTasks::RecurringLogic'
-
-            permission :edit_recurring_logics, { :'foreman_tasks/recurring_logics' => [:cancel, :enable, :disable, :clear_cancelled],
-                                                 :'foreman_tasks/api/recurring_logics' => [:cancel, :update, :bulk_destroy] }, :resource_type => 'ForemanTasks::RecurringLogic'
-          end
+    initializer 'foreman_tasks.register_plugin', :before => :finisher_hook do
+      Foreman::Plugin.register :"foreman-tasks" do
+        requires_foreman '>= 3.15'
+        divider :top_menu, :parent => :monitor_menu, :last => true, :caption => N_('Foreman Tasks')
+        menu :top_menu, :tasks,
+             :url_hash => { :controller => 'foreman_tasks/tasks', :action => :index },
+             :caption  => N_('Tasks'),
+             :parent   => :monitor_menu,
+             :last     => true
+
+        menu :top_menu, :recurring_logics,
+             :url_hash => { :controller => 'foreman_tasks/recurring_logics', :action => :index },
+             :caption  => N_('Recurring Logics'),
+             :parent   => :monitor_menu,
+             :last     => true
+
+        security_block :foreman_tasks do |_map|
+          permission :view_foreman_tasks, { :'foreman_tasks/tasks' => [:auto_complete_search, :sub_tasks, :index, :summary, :summary_sub_tasks, :show],
+                                            :'foreman_tasks/react' => [:index],
+                                            :'foreman_tasks/api/tasks' => [:bulk_search, :show, :index, :summary, :summary_sub_tasks, :details, :sub_tasks] }, :resource_type => 'ForemanTasks::Task'
+          permission :edit_foreman_tasks, { :'foreman_tasks/tasks' => [:resume, :unlock, :force_unlock, :cancel_step, :cancel, :abort],
+                                            :'foreman_tasks/api/tasks' => [:bulk_resume, :bulk_cancel, :bulk_stop] }, :resource_type => 'ForemanTasks::Task'
+
+          permission :create_recurring_logics, {}, :resource_type => 'ForemanTasks::RecurringLogic'
+
+          permission :view_recurring_logics, { :'foreman_tasks/recurring_logics' => [:auto_complete_search, :index, :show],
+                                               :'foreman_tasks/api/recurring_logics' => [:index, :show] }, :resource_type => 'ForemanTasks::RecurringLogic'
+
+          permission :edit_recurring_logics, { :'foreman_tasks/recurring_logics' => [:cancel, :enable, :disable, :clear_cancelled],
+                                               :'foreman_tasks/api/recurring_logics' => [:cancel, :update, :bulk_destroy] }, :resource_type => 'ForemanTasks::RecurringLogic'
+        end
 
-          add_all_permissions_to_default_roles
-
-          settings do
-            category(:tasks, N_('Tasks')) do
-              setting('foreman_tasks_sync_task_timeout',
-                      type: :integer,
-                      description: N_('Number of seconds to wait for synchronous task to finish.'),
-                      default: 120,
-                      full_name: N_('Sync task timeout'))
-              setting('dynflow_enable_console',
-                      type: :boolean,
-                      description: N_('Enable the dynflow console (/foreman_tasks/dynflow) for debugging'),
-                      default: true,
-                      full_name: N_('Enable dynflow console'))
-              setting('dynflow_console_require_auth',
-                      type: :boolean,
-                      description: N_('Require user to be authenticated as user with admin rights when accessing dynflow console'),
-                      default: true,
-                      full_name: N_('Require auth for dynflow console'))
-              setting('foreman_tasks_proxy_action_retry_count',
-                      type: :integer,
-                      description: N_('Number of attempts to start a task on the smart proxy before failing'),
-                      default: 4,
-                      full_name: N_('Proxy action retry count'))
-              setting('foreman_tasks_proxy_action_retry_interval',
-                      type: :integer,
-                      description: N_('Time in seconds between retries'),
-                      default: 15,
-                      full_name: N_('Proxy action retry interval'))
-              setting('foreman_tasks_proxy_batch_trigger',
-                      type: :boolean,
-                      description: N_('Allow triggering tasks on the smart proxy in batches'),
-                      default: true,
-                      full_name: N_('Allow proxy batch tasks'))
-              setting('foreman_tasks_proxy_batch_size',
-                      type: :integer,
-                      description: N_('Number of tasks which should be sent to the smart proxy in one request, if foreman_tasks_proxy_batch_trigger is enabled'),
-                      default: 100,
-                      full_name: N_('Proxy tasks batch size'))
-              setting('foreman_tasks_troubleshooting_url',
-                      type: :string,
-                      description: N_('Url pointing to the task troubleshooting documentation. '\
-                                      'It should contain %{label} placeholder, that will be replaced with normalized task label '\
-                                      '(restricted to only alphanumeric characters)). %{version} placeholder is also available.'),
-                      default: nil,
-                      full_name: N_('Tasks troubleshooting URL'))
-              setting('foreman_tasks_polling_multiplier',
-                      type: :integer,
-                      description: N_('Polling multiplier which is used to multiply the default polling intervals. '\
-                           'This can be used to prevent polling too frequently for long running tasks.'),
-                      default: 1,
-                      full_name: N_("Polling intervals multiplier"),
-                      validate: { numericality: { greater_than: 0 } })
-            end
+        add_all_permissions_to_default_roles
+
+        settings do
+          category(:tasks, N_('Tasks')) do
+            setting('foreman_tasks_sync_task_timeout',
+                    type: :integer,
+                    description: N_('Number of seconds to wait for synchronous task to finish.'),
+                    default: 120,
+                    full_name: N_('Sync task timeout'))
+            setting('dynflow_enable_console',
+                    type: :boolean,
+                    description: N_('Enable the dynflow console (/foreman_tasks/dynflow) for debugging'),
+                    default: true,
+                    full_name: N_('Enable dynflow console'))
+            setting('dynflow_console_require_auth',
+                    type: :boolean,
+                    description: N_('Require user to be authenticated as user with admin rights when accessing dynflow console'),
+                    default: true,
+                    full_name: N_('Require auth for dynflow console'))
+            setting('foreman_tasks_proxy_action_retry_count',
+                    type: :integer,
+                    description: N_('Number of attempts to start a task on the smart proxy before failing'),
+                    default: 4,
+                    full_name: N_('Proxy action retry count'))
+            setting('foreman_tasks_proxy_action_retry_interval',
+                    type: :integer,
+                    description: N_('Time in seconds between retries'),
+                    default: 15,
+                    full_name: N_('Proxy action retry interval'))
+            setting('foreman_tasks_proxy_batch_trigger',
+                    type: :boolean,
+                    description: N_('Allow triggering tasks on the smart proxy in batches'),
+                    default: true,
+                    full_name: N_('Allow proxy batch tasks'))
+            setting('foreman_tasks_proxy_batch_size',
+                    type: :integer,
+                    description: N_('Number of tasks which should be sent to the smart proxy in one request, if foreman_tasks_proxy_batch_trigger is enabled'),
+                    default: 100,
+                    full_name: N_('Proxy tasks batch size'))
+            setting('foreman_tasks_troubleshooting_url',
+                    type: :string,
+                    description: N_('Url pointing to the task troubleshooting documentation. '\
+                                    'It should contain %{label} placeholder, that will be replaced with normalized task label '\
+                                    '(restricted to only alphanumeric characters)). %{version} placeholder is also available.'),
+                    default: nil,
+                    full_name: N_('Tasks troubleshooting URL'))
+            setting('foreman_tasks_polling_multiplier',
+                    type: :integer,
+                    description: N_('Polling multiplier which is used to multiply the default polling intervals. '\
+                         'This can be used to prevent polling too frequently for long running tasks.'),
+                    default: 1,
+                    full_name: N_("Polling intervals multiplier"),
+                    validate: { numericality: { greater_than: 0 } })
           end
+        end
 
-          register_graphql_query_field :task, '::Types::Task', :record_field
-          register_graphql_query_field :tasks, '::Types::Task', :collection_field
-          register_graphql_query_field :recurring_logic, '::Types::RecurringLogic', :record_field
-          register_graphql_query_field :recurring_logics, '::Types::RecurringLogic', :collection_field
-
-          register_graphql_mutation_field :cancel_recurring_logic, '::Mutations::RecurringLogics::Cancel'
+        register_graphql_query_field :task, '::Types::Task', :record_field
+        register_graphql_query_field :tasks, '::Types::Task', :collection_field
+        register_graphql_query_field :recurring_logic, '::Types::RecurringLogic', :record_field
+        register_graphql_query_field :recurring_logics, '::Types::RecurringLogic', :collection_field
 
-          logger :dynflow, :enabled => true
-          logger :action, :enabled => true
+        register_graphql_mutation_field :cancel_recurring_logic, '::Mutations::RecurringLogics::Cancel'
 
-          role 'Tasks Manager', [:view_foreman_tasks, :edit_foreman_tasks],
-               'Role granting permissions to inspect, cancel, resume and unlock tasks'
-          role 'Tasks Reader', [:view_foreman_tasks],
-               'Role granting permissions to inspect tasks'
+        logger :dynflow, :enabled => true
+        logger :action, :enabled => true
 
-          widget 'foreman_tasks/tasks/dashboard/tasks_status', :sizex => 6, :sizey => 1, :name => N_('Task Status')
-          widget 'foreman_tasks/tasks/dashboard/latest_tasks_in_error_warning', :sizex => 6, :sizey => 1, :name => N_('Latest Warning/Error Tasks')
+        role 'Tasks Manager', [:view_foreman_tasks, :edit_foreman_tasks],
+             'Role granting permissions to inspect, cancel, resume and unlock tasks'
+        role 'Tasks Reader', [:view_foreman_tasks],
+             'Role granting permissions to inspect tasks'
 
-          register_gettext domain: "foreman_tasks"
+        widget 'foreman_tasks/tasks/dashboard/tasks_status', :sizex => 6, :sizey => 1, :name => N_('Task Status')
+        widget 'foreman_tasks/tasks/dashboard/latest_tasks_in_error_warning', :sizex => 6, :sizey => 1, :name => N_('Latest Warning/Error Tasks')
 
-          ForemanTasks.dynflow.eager_load_actions!
-          extend_observable_events(::Dynflow::Action.descendants.select { |klass| klass <= ::Actions::ObservableAction }.map(&:namespaced_event_names))
-        end
+        register_gettext domain: "foreman_tasks"
       end
     end
 
+    config.after_initialize do
+      ForemanTasks.dynflow.eager_load_actions!
+      plugin = ::Foreman::Plugin.find("foreman-tasks")
+      plugin.extend_observable_events(::Dynflow::Action.descendants.select { |klass| klass <= ::Actions::ObservableAction }.map(&:namespaced_event_names))
+    end
+
     initializer 'foreman_tasks.apipie' do
       # this condition is here for compatibility reason to work with Foreman 1.4.x
       if Apipie.configuration.api_controllers_matcher.is_a?(Array) &&

data/lib/foreman_tasks/version.rb

@@ -1,3 +1,3 @@
 module ForemanTasks
-  VERSION = '10.0.2'.freeze
+  VERSION = '11.0.1'.freeze
 end

data/test/factories/triggering_factory.rb

@@ -3,7 +3,7 @@ FactoryBot.define do
     mode { :immediate }
 
     trait :future do
-      time = Time.zone.now
+      time = Time.zone.now + 1.year
       mode { :future }
       start_at { time }
       start_at_raw { time.strftime(ForemanTasks::Triggering::TIME_FORMAT) }

data/test/unit/triggering_test.rb

@@ -13,6 +13,13 @@ class TriggeringTest < ActiveSupport::TestCase
       assert_not_predicate(triggering, :valid?)
     end
 
+    it 'is invalid when future execution is in the past' do
+      triggering = FactoryBot.build(:triggering, :future)
+      assert_predicate(triggering, :valid?)
+      triggering.start_at = Time.zone.now - 1.day
+      assert_not_predicate(triggering, :valid?)
+    end
+
     it 'is invalid when recurring logic is invalid' do
       triggering = FactoryBot.build(:triggering, :recurring)
       assert_predicate(triggering, :valid?)

data/webpack/ForemanTasks/Components/TasksDashboard/Components/TasksCardsGrid/Components/StoppedTasksCard/OtherInfo.js

@@ -30,6 +30,7 @@ export const OtherInfo = ({ updateQuery, otherCount, query }) => {
         </span>
       </Tooltip>
       <Button
+        ouiaId="stopped-other-tasks-button"
         variant="link"
         onClick={() =>
           updateQuery({

data/webpack/ForemanTasks/Components/TasksDashboard/Components/TasksCardsGrid/Components/StoppedTasksCard/__snapshots__/OtherInfo.test.js.snap

@@ -12,9 +12,6 @@ exports[`OtherInfo render 1`] = `
     <span>
       <InfoCircleIcon
         className="pficon"
-        color="currentColor"
-        noVerticalAlign={false}
-        size="sm"
       />
       <span>
         Other:
@@ -24,6 +21,7 @@ exports[`OtherInfo render 1`] = `
   </Tooltip>
   <Button
     onClick={[Function]}
+    ouiaId="stopped-other-tasks-button"
     variant="link"
   >
     7

data/webpack/ForemanTasks/Components/TasksDashboard/Components/TasksLabelsRow/TasksLabelsRow.scss

@@ -1,4 +1,4 @@
-@import '~@theforeman/vendor/scss/variables';
+@import 'foremanReact/common/variables';
 
 .tasks-labels-row {
   margin: 0;

data/webpack/ForemanTasks/Components/TasksDashboard/TasksDashboard.scss

@@ -1,5 +1,5 @@
-@import '~@theforeman/vendor/scss/variables';
-@import '~@theforeman/vendor/scss/mixins';
+@import 'foremanReact/common/variables';
+@import 'foremanReact/common/scss/mixins';
 
 @mixin create-tasks-dashboard-column($columns: 12, $screen-min: 0, $gutter: $grid-gutter-width) {
   @media (min-width: $screen-min) {

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foreman-tasks
 version: !ruby/object:Gem::Version
-  version: 10.0.2
+  version: 11.0.1
 platform: ruby
 authors:
 - Ivan Nečas
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-03 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dynflow
@@ -118,11 +117,12 @@ email:
 executables: []
 extensions: []
 extra_rdoc_files:
-- README.md
 - LICENSE
+- README.md
 files:
 - ".eslintrc"
 - ".github/workflows/js_tests.yml"
+- ".github/workflows/release.yml"
 - ".github/workflows/ruby_tests.yml"
 - ".gitignore"
 - ".prettierrc"
@@ -626,7 +626,6 @@ homepage: https://github.com/theforeman/foreman-tasks
 licenses:
 - GPL-3.0
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -641,8 +640,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.27
-signing_key:
+rubygems_version: 3.6.7
 specification_version: 4
 summary: Foreman plugin for showing tasks information for resources and users
 test_files: