foreman-tasks 1.1.3 → 3.0.0

data/webpack/ForemanTasks/Components/TaskDetails/TaskDetailsConstants.js

@@ -1,18 +1,4 @@
-export const FOREMAN_TASK_DETAILS_INIT = 'FOREMAN_TASK_DETAILS_INIT';
+export const FOREMAN_TASK_DETAILS = 'FOREMAN_TASK_DETAILS';
+export const FOREMAN_TASK_DETAILS_SUCCESS = 'FOREMAN_TASK_DETAILS_SUCCESS';
 
-export const FOREMAN_TASK_DETAILS_FETCH_TASK_REQUEST =
-  'FOREMAN_TASK_DETAILS_FETCH_TASK_REQUEST';
-export const FOREMAN_TASK_DETAILS_FETCH_TASK_SUCCESS =
-  'FOREMAN_TASK_DETAILS_FETCH_TASK_SUCCESS';
-export const FOREMAN_TASK_DETAILS_FETCH_TASK_FAILURE =
-  'FOREMAN_TASK_DETAILS_FETCH_TASK_FAILURE';
-
-export const FOREMAN_TASK_DETAILS_STOP_POLLING =
-  'FOREMAN_TASK_DETAILS_STOP_POLLING';
-export const FOREMAN_TASK_DETAILS_START_POLLING =
-  'FOREMAN_TASK_DETAILS_START_POLLING';
-
-export const FOREMAN_TASK_DETAILS_TOGGLE_UNLOCK_MODAL =
-  'FOREMAN_TASK_DETAILS_TOGGLE_UNLOCK_MODAL';
-export const FOREMAN_TASK_DETAILS_TOGGLE_FORCE_UNLOCK_MODAL =
-  'FOREMAN_TASK_DETAILS_TOGGLE_FORCE_UNLOCK_MODAL';
+export const TASK_STEP_CANCEL = 'TASK_STEP_CANCEL';

data/webpack/ForemanTasks/Components/TaskDetails/TaskDetailsSelectors.js

@@ -1,88 +1,108 @@
+/* eslint-disable camelcase */
+import {
+  selectAPIResponse,
+  selectAPIByKey,
+} from 'foremanReact/redux/API/APISelectors';
+import { selectDoesIntervalExist } from 'foremanReact/redux/middlewares/IntervalMiddleware/IntervalSelectors';
+import { STATUS } from 'foremanReact/constants';
 import { selectForemanTasks } from '../../ForemanTasksSelectors';
+import { FOREMAN_TASK_DETAILS } from './TaskDetailsConstants';
 
 export const selectTaskDetails = state =>
   selectForemanTasks(state).taskDetails || {};
 
-export const selectStartAt = state => selectTaskDetails(state).start_at || null;
+export const selectTaskDetailsResponse = state =>
+  selectAPIResponse(state, FOREMAN_TASK_DETAILS);
+
+export const selectStartAt = state =>
+  selectTaskDetailsResponse(state)?.start_at;
 
 export const selectStartBefore = state =>
-  selectTaskDetails(state).start_before || null;
+  selectTaskDetailsResponse(state)?.start_before;
 
 export const selectStartedAt = state =>
-  selectTaskDetails(state).started_at || null;
+  selectTaskDetailsResponse(state)?.started_at;
 
-export const selectEndedAt = state => selectTaskDetails(state).ended_at || null;
+export const selectEndedAt = state =>
+  selectTaskDetailsResponse(state)?.ended_at;
 
-export const selectInput = state => selectTaskDetails(state).input || [];
+export const selectInput = state =>
+  selectTaskDetailsResponse(state).input || [];
 
-export const selectOutput = state => selectTaskDetails(state).output || {};
+export const selectOutput = state =>
+  selectTaskDetailsResponse(state).output || {};
 
 export const selectResumable = state =>
-  selectTaskDetails(state).resumable || false;
+  selectTaskDetailsResponse(state).resumable || false;
 
 export const selectCancellable = state =>
-  selectTaskDetails(state).cancellable || false;
+  selectTaskDetailsResponse(state).cancellable || false;
 
 export const selectErrors = state => {
-  const { humanized } = selectTaskDetails(state);
+  const { humanized } = selectTaskDetailsResponse(state);
   return humanized ? humanized.errors : [];
 };
 
 export const selectProgress = state =>
-  selectTaskDetails(state).progress
-    ? parseFloat((selectTaskDetails(state).progress * 100).toFixed(2))
+  selectTaskDetailsResponse(state).progress
+    ? Math.trunc(selectTaskDetailsResponse(state).progress * 100)
     : 0;
 
 export const selectUsername = state =>
-  selectTaskDetails(state).username || null;
+  selectTaskDetailsResponse(state)?.username;
 
-export const selectLabel = state => selectTaskDetails(state).label || null;
+export const selectLabel = state => selectTaskDetailsResponse(state)?.label;
 
 export const selectExecutionPlan = state =>
-  selectTaskDetails(state).execution_plan || {};
+  selectTaskDetailsResponse(state).execution_plan || {};
 
 export const selectFailedSteps = state =>
-  selectTaskDetails(state).failed_steps || [];
+  selectTaskDetailsResponse(state).failed_steps || [];
 
 export const selectRunningSteps = state =>
-  selectTaskDetails(state).running_steps || [];
+  selectTaskDetailsResponse(state).running_steps || [];
 
-export const selectHelp = state => selectTaskDetails(state).help || null;
+export const selectHelp = state => selectTaskDetailsResponse(state)?.help;
 
 export const selectHasSubTasks = state =>
-  selectTaskDetails(state).has_sub_tasks || false;
-
-export const selectAllowDangerousActions = state =>
-  selectTaskDetails(state).allowDangerousActions || false;
+  selectTaskDetailsResponse(state).has_sub_tasks || false;
 
-export const selectLocks = state => selectTaskDetails(state).locks || [];
+export const selectLocks = state =>
+  selectTaskDetailsResponse(state).locks || [];
 
 export const selectUsernamePath = state =>
-  selectTaskDetails(state).username_path || null;
+  selectTaskDetailsResponse(state)?.username_path;
 
-export const selectAction = state => selectTaskDetails(state).action || '';
+export const selectAction = state =>
+  selectTaskDetailsResponse(state).action || '';
 
-export const selectState = state => selectTaskDetails(state).state || null;
+export const selectState = state => selectTaskDetailsResponse(state)?.state;
 
-export const selectResult = state => selectTaskDetails(state).result || null;
+export const selectResult = state => selectTaskDetailsResponse(state)?.result;
 
 export const selectTimeoutId = state =>
-  selectTaskDetails(state).timeoutId || null;
+  selectTaskDetailsResponse(state)?.timeoutId;
 
 export const selectTaskReload = state =>
-  selectTaskDetails(state).taskReload || false;
+  !!selectDoesIntervalExist(state, FOREMAN_TASK_DETAILS);
 
 export const selectParentTask = state =>
-  selectTaskDetails(state).parent_task_id || '';
-
-export const selectShowUnlockModal = state =>
-  selectTaskDetails(state).showUnlockModal || false;
-
-export const selectShowForceUnlockModal = state =>
-  selectTaskDetails(state).showForceUnlockModal || false;
+  selectTaskDetailsResponse(state).parent_task_id || '';
 
 export const selectExternalId = state =>
-  selectTaskDetails(state).external_id || null;
+  selectTaskDetailsResponse(state)?.external_id;
 
 export const selectDynflowEnableConsole = state =>
-  selectTaskDetails(state).dynflow_enable_console || false;
+  selectTaskDetailsResponse(state).dynflow_enable_console || false;
+
+export const selectCanEdit = state =>
+  selectTaskDetailsResponse(state).can_edit || false;
+
+export const selectStatus = state => selectTaskDetailsResponse(state).status;
+
+export const selectAPIError = state =>
+  selectTaskDetailsResponse(state)?.APIerror;
+
+export const selectIsLoading = state =>
+  !!selectAPIByKey(state, FOREMAN_TASK_DETAILS).response &&
+  selectStatus(state) === STATUS.PENDING;

data/webpack/ForemanTasks/Components/TaskDetails/TasksDetailsHelper.js

@@ -1 +1,6 @@
-export const getTaskID = () => window.location.pathname.split('/').slice(-1)[0];
+// Get Task ID from URL. Split url by '/', filter non-empty values and get Task ID.
+export const getTaskID = () =>
+  window.location.pathname
+    .split('/')
+    .filter(i => i)
+    .slice(-1)[0];

data/webpack/ForemanTasks/Components/TaskDetails/__tests__/TaskDetails.fixtures.js

@@ -0,0 +1,8 @@
+export const minProps = {
+  cancelStep: jest.fn(),
+  taskReload: false,
+  taskReloadStop: jest.fn(),
+  taskReloadStart: jest.fn(),
+  taskProgressToggle: jest.fn(),
+  status: 'RESOLVED',
+};

data/webpack/ForemanTasks/Components/TaskDetails/__tests__/TaskDetails.test.js

@@ -1,11 +1,23 @@
 import { testComponentSnapshotsWithFixtures } from '@theforeman/test';
 
 import TaskDetails from '../TaskDetails';
+import { minProps } from './TaskDetails.fixtures';
 
 const fixtures = {
-  'render without Props': {},
+  'render with loading Props': { ...minProps, isLoading: true },
+  'render with error Props': {
+    ...minProps,
+    status: 'ERROR',
+    APIerror: { message: 'some-error' },
+  },
+  'render with min Props': minProps,
 };
 
+delete window.location;
+window.location = new URL(
+  'https://foreman.com/foreman_tasks/tasks/a15dd820-32f1-4ced-9ab7-c0fab8234c47/'
+);
+
 describe('TaskDetails', () => {
   describe('rendering', () =>
     testComponentSnapshotsWithFixtures(TaskDetails, fixtures));

data/webpack/ForemanTasks/Components/TaskDetails/__tests__/TaskDetailsActions.test.js

@@ -1,19 +1,19 @@
 import { testActionSnapshotWithFixtures } from '@theforeman/test';
-import API from 'foremanReact/API';
+import { API } from 'foremanReact/redux/API';
 import {
   taskReloadStop,
   taskReloadStart,
-  fetchTaskDetails,
+  cancelStep,
 } from '../TaskDetailsActions';
 
-jest.mock('foremanReact/API');
+jest.mock('foremanReact/redux/API');
 
-API.get.mockImplementation(async () => ({ data: 'some-data' }));
+API.post.mockImplementation(async () => ({ data: 'some-data' }));
 
 const fixtures = {
   'should start reload': () => taskReloadStart(1),
-  'should stop reload': () => taskReloadStop(2),
-  'should fetch-task-details and success': () => fetchTaskDetails(),
+  'should stop reload': () => taskReloadStop(),
+  'should cancelStep': () => cancelStep('task-id', 'step-id'),
 };
 
 describe('TaskDetails - Actions', () =>

data/webpack/ForemanTasks/Components/TaskDetails/__tests__/__snapshots__/TaskDetails.test.js.snap

@@ -1,6 +1,80 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`TaskDetails rendering render without Props 1`] = `
+exports[`TaskDetails rendering render with error Props 1`] = `
+<MessageBox
+  icontype="error-circle-o"
+  key="task-details-error"
+  msg="Could not receive data: some-error"
+/>
+`;
+
+exports[`TaskDetails rendering render with loading Props 1`] = `
+<div
+  className="task-details-react well"
+>
+  <ForwardRef
+    animation={false}
+    defaultActiveKey={1}
+    id="task-details-tabs"
+  >
+    <Tab
+      eventKey={1}
+      title="Task"
+    >
+      <TaskSkeleton />
+    </Tab>
+    <Tab
+      disabled={true}
+      eventKey={2}
+      title="Running Steps"
+    >
+      <RunningSteps
+        cancelStep={[MockFunction]}
+        id="a15dd820-32f1-4ced-9ab7-c0fab8234c47"
+        runningSteps={Array []}
+        taskReload={false}
+        taskReloadStart={[MockFunction]}
+      />
+    </Tab>
+    <Tab
+      disabled={true}
+      eventKey={3}
+      title="Errors"
+    >
+      <Errors
+        executionPlan={Object {}}
+        failedSteps={Array []}
+      />
+    </Tab>
+    <Tab
+      disabled={true}
+      eventKey={4}
+      title="Locks"
+    >
+      <Locks
+        locks={Array []}
+      />
+    </Tab>
+    <Tab
+      disabled={true}
+      eventKey={5}
+      title="Raw"
+    >
+      <Raw
+        endedAt=""
+        externalId=""
+        id="a15dd820-32f1-4ced-9ab7-c0fab8234c47"
+        input={Array []}
+        label=""
+        output={Object {}}
+        startedAt=""
+      />
+    </Tab>
+  </ForwardRef>
+</div>
+`;
+
+exports[`TaskDetails rendering render with min Props 1`] = `
 <div
   className="task-details-react well"
 >
@@ -15,42 +89,32 @@ exports[`TaskDetails rendering render without Props 1`] = `
     >
       <Task
         action=""
-        allowDangerousActions={false}
+        canEdit={false}
         cancelTaskRequest={[Function]}
         cancellable={false}
         dynflowEnableConsole={false}
         endedAt=""
-        error={Array []}
-        executionPlan={Object {}}
+        errors={Array []}
         externalId=""
-        failedSteps={Array []}
-        fetchTaskDetails={[Function]}
         hasSubTasks={false}
         help=""
-        id=""
+        id="a15dd820-32f1-4ced-9ab7-c0fab8234c47"
         input={Array []}
         label=""
-        locks={Array []}
         output={Object {}}
         parentTask=""
         progress={0}
-        refetchTaskDetails={[Function]}
         result="error"
         resumable={false}
         resumeTaskRequest={[Function]}
-        runningSteps={Array []}
-        showForceUnlockModal={false}
-        showUnlockModal={false}
         startAt=""
         startBefore=""
         startedAt=""
         state=""
+        status="RESOLVED"
+        taskProgressToggle={[Function]}
         taskReload={false}
-        taskReloadStart={[Function]}
-        taskReloadStop={[Function]}
-        timeoutId={null}
-        toggleForceUnlockModal={[Function]}
-        toggleUnlockModal={[Function]}
+        taskReloadStart={[MockFunction]}
         username=""
         usernamePath=""
       />
@@ -60,8 +124,11 @@ exports[`TaskDetails rendering render without Props 1`] = `
       title="Running Steps"
     >
       <RunningSteps
-        executionPlan={Object {}}
+        cancelStep={[MockFunction]}
+        id="a15dd820-32f1-4ced-9ab7-c0fab8234c47"
         runningSteps={Array []}
+        taskReload={false}
+        taskReloadStart={[MockFunction]}
       />
     </Tab>
     <Tab
@@ -88,7 +155,7 @@ exports[`TaskDetails rendering render without Props 1`] = `
       <Raw
         endedAt=""
         externalId=""
-        id=""
+        id="a15dd820-32f1-4ced-9ab7-c0fab8234c47"
         input={Array []}
         label=""
         output={Object {}}

data/webpack/ForemanTasks/Components/TaskDetails/__tests__/__snapshots__/TaskDetailsActions.test.js.snap

@@ -1,43 +1,47 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`TaskDetails - Actions should fetch-task-details and success 1`] = `
+exports[`TaskDetails - Actions should cancelStep 1`] = `
 Array [
   Array [
     Object {
-      "type": "FOREMAN_TASK_DETAILS_FETCH_TASK_REQUEST",
+      "payload": Object {
+        "message": Object {
+          "message": "Trying to cancel step step-id",
+          "type": "info",
+        },
+      },
+      "type": "TOASTS_ADD",
     },
   ],
   Array [
     Object {
-      "payload": "some-data",
-      "type": "FOREMAN_TASK_DETAILS_FETCH_TASK_SUCCESS",
+      "handleError": [Function],
+      "handleSuccess": [Function],
+      "key": "TASK_STEP_CANCEL",
+      "type": "post-some-type",
+      "url": "foreman/foreman_tasks/tasks/task-id/cancel_step?step_id=step-id",
     },
   ],
+]
+`;
+
+exports[`TaskDetails - Actions should start reload 1`] = `
+Array [
   Array [
     Object {
-      "payload": Object {
-        "timeoutId": 7,
-      },
-      "type": "FOREMAN_TASK_DETAILS_START_POLLING",
+      "handleError": [Function],
+      "handleSuccess": [Function],
+      "interval": 5000,
+      "key": "FOREMAN_TASK_DETAILS",
+      "type": "get-some-type",
+      "url": "foreman/foreman_tasks/api/tasks/1/details?include_permissions",
     },
   ],
 ]
 `;
 
-exports[`TaskDetails - Actions should start reload 1`] = `
-Object {
-  "payload": Object {
-    "timeoutId": 1,
-  },
-  "type": "FOREMAN_TASK_DETAILS_START_POLLING",
-}
-`;
-
 exports[`TaskDetails - Actions should stop reload 1`] = `
 Object {
-  "payload": Object {
-    "timeoutId": 2,
-  },
-  "type": "FOREMAN_TASK_DETAILS_STOP_POLLING",
+  "type": "stop",
 }
 `;