foreman-tasks-core 0.2.4 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: bce611af37009e959d490739b5e91a250d2ee97c
-  data.tar.gz: 3bde706553fae34bea7495cfd41d192ae1e0414b
+SHA256:
+  metadata.gz: 7ed79b3e3352fb7ea1fcb798fd4498514807289d642d55eee9e6a371638889b4
+  data.tar.gz: a2bc83a4d0d3e3f977ddf34a88e9d50be589f4b1d9977853acd162c7a4c3d216
 SHA512:
-  metadata.gz: c7f4c63c90d8235fb56e6133ae249b4a2b1524f7bc73e0d52447659c014c83a86adc06eb5e06b011b9dc6c4ba9c8f180cd7c8749d9ac11188254fdafd13a722d
-  data.tar.gz: 43788ece9ba029a630c63482cc35b9c100a9801b5c56517245acd38ee1fd9f7f84164f4486b7db4b7aa4d3f2498750ff52b6511485916b17f9e45877a87d2520
+  metadata.gz: a06f4cd323183c182c63cc491805c796dce8ef01af1e947f69382ef44916ad5880134daa1ad780b093dcd443f782997383e7926c2d8635b6463047e393b6420c
+  data.tar.gz: 6242f08a2e763c09973ea93813a50e2369b1f406a3041e10503f4ce5299cbdf9a1723071d058466ebe4c7622b8578f3e47f99396f1e54d94a82f74e3a01e91b2

data/lib/foreman_tasks_core/runner/action.rb

@@ -24,7 +24,7 @@ module ForemanTasksCore
 
       def finalize
         # To mark the task as a whole as failed
-        error! 'Script execution failed' if failed_run?
+        error! 'Script execution failed' if on_proxy? && failed_run?
       end
 
       def rescue_strategy_for_self

data/lib/foreman_tasks_core/runner/base.rb

@@ -4,7 +4,7 @@ module ForemanTasksCore
     # provide update data on refresh call.
     class Base
       attr_reader :id
-      attr_accessor :logger
+      attr_writer :logger
 
       def initialize(*_args)
         @id = SecureRandom.uuid

data/lib/foreman_tasks_core/shareable_action.rb

@@ -11,9 +11,15 @@ module ForemanTasksCore
 
       planned_action = plan_self(input)
       # code only applicable, when run with SmartProxyDynflowCore in place
-      if defined?(SmartProxyDynflowCore::Callback) && callback
+      if on_proxy? && callback
         plan_action(SmartProxyDynflowCore::Callback::Action, callback, planned_action.output)
       end
     end
+
+    private
+
+    def on_proxy?
+      defined?(SmartProxyDynflowCore::Callback)
+    end
   end
 end

data/lib/foreman_tasks_core/version.rb

@@ -1,3 +1,3 @@
 module ForemanTasksCore
-  VERSION = '0.2.4'.freeze
+  VERSION = '0.2.5'.freeze
 end

metadata

@@ -1,17 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: foreman-tasks-core
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
 platform: ruby
 authors:
 - Ivan Nečas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-19 00:00:00.000000000 Z
+date: 2018-05-15 00:00:00.000000000 Z
 dependencies: []
-description: |
-  Common code used both at Forman and Foreman proxy regarding tasks
+description: 'Common code used both at Forman and Foreman proxy regarding tasks
+
+'
 email:
 - inecas@redhat.com
 executables: []
@@ -51,7 +52,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.7.3
 signing_key: 
 specification_version: 4
 summary: Common code used both at Forman and Foreman proxy regarding tasks