foreign_key_validation 1.0.0 → 1.0.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZjUwMTlkNzAzZDliZTUxOGViNzJmNDA4YTVhNGY5NzEzNjdlYzJkZg==
+    MTRkMDgxMDUxZmJiN2ViODhiNjc2MjlkMjkwNzU3NWE1NGYyNDMxMw==
   data.tar.gz: !binary |-
-    OWJkZjlkM2I4NWIyYmY3Y2IyZDRjZDQ2NTk3MjBjZDQ0YzkyMjFmNw==
+    NWRmMDQzMmRkNTM4OTE5MGIzZTRmMjk3ODllMDU1ZmYyOGZjZTkyMw==
 SHA512:
   metadata.gz: !binary |-
-    OTBmZmRhZDZlZDI5MDc1ZWM3Y2ExOWMxODIzZmQ1YjI3YmFkZjJkYTg2OTI3
-    NTYxNWNhZmJmOTAyYzI2NjhiNTY4ODYzYjdhNjIxM2JiZTEyNjhhNTI0ZTcx
-    MDEwZDc5ZDc1ZWE2M2EyZDUxMmQyNDMxYTdkYzk0M2M3ZGFlMTQ=
+    M2NhODc1MzQ0NDEwNGMwZmU0MzRkN2E2ZWJjZDg5OTlhYzFkYzhlYWEyM2Yx
+    MTUwMTQ3ZWU3ZGM0OTIxNTZhZTQ1MTMyZTk5ZDUzOGI2NzhjZTA1Nzg0MTk2
+    NWNhNjQzYzllOTIwYWJlNGM1ODk1NjIwY2ZhZDc0YzczYjRiNmY=
   data.tar.gz: !binary |-
-    MmVhODBlOWU0MzQxNTRhYjIyN2U4MGJhNjViZDUwNzc3MTIyNDljY2M2MGE3
-    NjJjZjUwODEzNTJiMjM4ZGYwMTI2MTNmNWMwZmQ0YjhiY2FlMDVjOWM5OTFj
-    YmMwM2ZkN2NkZjMxOTc1Y2VlZDBhOThjNmI1YzZkZTMzMDJjNTk=
+    ODBhMWQ2MmZiMmE2N2NkZDc3YmJmYjU2MGQwYjQzYTliNjg3NzBlMGJjMGIw
+    OGVjYjQ2YTk2ZDA1MzdmNzFkNDdiMTU0ODE1MWUwYzlkNmJiMGY4ZDI0YTUy
+    ZjFiMjRhNWNmMjc0N2Y0NDNiYjhhMjljYTkyM2ZkZDM1NzI4Yzg=

data/README.md

@@ -3,6 +3,7 @@
 [![Coverage Status](https://coveralls.io/repos/marcusg/foreign_key_validation/badge.png?branch=master)](https://coveralls.io/r/marcusg/foreign_key_validation?branch=master)
 [![Code Climate](https://codeclimate.com/github/marcusg/foreign_key_validation/badges/gpa.svg)](https://codeclimate.com/github/marcusg/foreign_key_validation)
 [![Build Status](https://travis-ci.org/marcusg/foreign_key_validation.svg?branch=master)](https://travis-ci.org/marcusg/foreign_key_validation)
+[![Gem Version](https://badge.fury.io/rb/foreign_key_validation.svg)](http://badge.fury.io/rb/foreign_key_validation)
 
 Protect your models by specifying a collection of relations that should be tested for consistency with a predefined column (e.g. `user_id`).This is useful when the column `user_id` is used in multiple models. We can check if the `user_id` of *model A* matches `user_id` of *model B* before saving the records - if the IDs are different, an error will be attached to the errors hash of checked model.
 

data/lib/foreign_key_validation/collector.rb

@@ -0,0 +1,40 @@
+module ForeignKeyValidation
+
+  class Collector
+    attr_accessor :klass, :validate_against, :reflections, :reflection_names, :validate_against_key, :validate_with
+
+    DEFAULT_VALIDATE_AGAINST = :user
+
+    def initialize(opt={})
+      self.klass                 = opt[:klass]
+      self.validate_against      = find_validate_against(opt[:on])
+      self.reflections           = klass.reflect_on_all_associations(:belongs_to)
+      self.reflection_names      = reflections.map(&:name).map(&:to_s)
+      self.validate_against_key  = find_validate_against_key
+      self.validate_with         = find_validate_with(opt[:with])
+    end
+
+    def check!
+      raise Errors::NoReleationFoundError.new(klass.name) if reflection_names.empty?
+      raise Errors::NoForeignKeyFoundError.new(validate_against, klass.table_name) unless reflection_names.include?(validate_against)
+      raise Errors::UnknownRelationError.new(validate_with) unless validate_with.all? {|k| reflection_names.include?(k)}
+      true
+    end
+
+    private
+
+    def find_validate_against(on)
+      (on || DEFAULT_VALIDATE_AGAINST).to_s
+    end
+
+    def find_validate_with(with)
+      ((Array(with).map(&:to_s) if with) || reflection_names).reject {|n| n == validate_against}
+    end
+
+    def find_validate_against_key
+      reflections.select {|r| r.name.to_s == validate_against}.first.try(:foreign_key)
+    end
+
+  end
+
+end

data/lib/foreign_key_validation/filter.rb

@@ -0,0 +1,26 @@
+module ForeignKeyValidation
+
+  class Filter
+    attr_accessor :collector
+
+    def initialize(collector)
+      self.collector = collector
+    end
+
+    def before_filter(&block)
+      collector.klass.send :define_method, filter_name do
+        self.instance_eval &block
+      end
+      collector.klass.send :private, filter_name.to_sym
+      collector.klass.send :before_validation, filter_name
+    end
+
+    private
+
+    def filter_name
+      "validate_foreign_keys_on_#{collector.validate_against}"
+    end
+
+  end
+
+end

data/lib/foreign_key_validation/model_extension.rb

@@ -2,35 +2,19 @@ module ForeignKeyValidation
   module ModelExtension
     extend ActiveSupport::Concern
 
-    included do
-      private
-      def validate_foreign_key(validate_against_key, reflection_name)
-        return if send(reflection_name).try(validate_against_key).nil? or try(validate_against_key).nil?
-
-        if send(reflection_name).send(validate_against_key) != send(validate_against_key)
-          errors.add(validate_against_key, "#{validate_against_key} of #{reflection_name} does not match #{self.class.name.tableize} #{validate_against_key}.")
-        end
-      end
-    end
-
     module ClassMethods
+
       def validate_foreign_keys(opt={})
         subclasses.map {|klass| klass.send(:validate_foreign_keys, opt)}
 
-        validator = Validator.new(self, opt)
-        validator.check
+        collector = Collector.new(opt.merge(klass: self))
+        collector.check!
 
-        define_method validator.filter_method_name do
-          validator.validate_with.each do |reflection_name|
-            validate_foreign_key(validator.validate_against_key, reflection_name)
-          end
+        Filter.new(collector).before_filter do
+          Validator.validate(validate_against_key: collector.validate_against_key, reflection_names: collector.validate_with, object: self)
         end
-        private validator.filter_method_name.to_sym
-
-        before_validation validator.filter_method_name
       end
+
     end
   end
 end
-
-ActiveRecord::Base.send :include, ForeignKeyValidation::ModelExtension

data/lib/foreign_key_validation/validator.rb

@@ -1,41 +1,17 @@
 module ForeignKeyValidation
 
   class Validator
-    attr_accessor :klass, :validate_against, :reflections, :reflection_names, :validate_against_key, :validate_with
 
-    DEFAULT_VALIDATE_AGAINST = :user
+    def self.validate(opt={})
+      validate_against_key, reflection_names, object = opt[:validate_against_key], opt[:reflection_names], opt[:object]
 
-    def initialize(klass, opt={})
-      self.klass                 = klass
-      self.validate_against      = find_validate_against(opt[:on])
-      self.reflections           = klass.reflect_on_all_associations(:belongs_to)
-      self.reflection_names      = reflections.map(&:name).map(&:to_s)
-      self.validate_against_key  = find_validate_against_key
-      self.validate_with         = find_validate_with(opt[:with])
-    end
-
-    def check
-      raise Errors::NoReleationFoundError.new(klass.name) if reflection_names.empty?
-      raise Errors::NoForeignKeyFoundError.new(validate_against, klass.table_name) unless reflection_names.include?(validate_against)
-      raise Errors::UnknownRelationError.new(validate_with) unless validate_with.all? {|k| reflection_names.include?(k)}
-    end
-
-    def filter_method_name
-      "validate_foreign_keys_on_#{validate_against}"
-    end
-
-    private
-
-    def find_validate_against(opt_on)
-      (opt_on || DEFAULT_VALIDATE_AGAINST).to_s
-    end
-
-    def find_validate_with(opt_with)
-      ((Array(opt_with).map(&:to_s) if opt_with) || reflection_names).reject {|n| n == validate_against}
-    end
+      reflection_names.each do |reflection_name|
+        next if object.send(reflection_name).try(validate_against_key).nil? or object.try(validate_against_key).nil?
 
-    def find_validate_against_key
-      reflections.select {|r| r.name.to_s == validate_against}.first.try(:foreign_key)
+        if object.send(reflection_name).send(validate_against_key) != object.send(validate_against_key)
+          object.errors.add(validate_against_key, "#{validate_against_key} of #{reflection_name} does not match #{object.class.name.tableize} #{validate_against_key}.")
+        end
+      end
     end
 
   end

data/lib/foreign_key_validation/version.rb

@@ -1,3 +1,3 @@
 module ForeignKeyValidation
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/lib/foreign_key_validation.rb

@@ -1,4 +1,8 @@
 require "foreign_key_validation/version"
 require "foreign_key_validation/errors"
+require "foreign_key_validation/collector"
+require "foreign_key_validation/filter"
 require "foreign_key_validation/validator"
 require "foreign_key_validation/model_extension"
+
+ActiveRecord::Base.send :include, ForeignKeyValidation::ModelExtension

data/spec/models/validation_with_custom_attrs_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+
+describe ForeignKeyValidation::ModelExtension do
+
+  let(:user) { User.create }
+  let(:other_user) { User.create }
+
+  context "with calling validation with custom attributes hash" do
+    before do
+      Comment.class_eval do
+        validate_foreign_keys on: :user, with: :issue # member is not in list - should be editable
+      end
+    end
+
+    let(:project) { Project.create user: user }
+    let(:other_project) { Project.create user: other_user }
+    let(:issue) { Issue.create user: user, project: project }
+    let(:other_issue) { Issue.create user: other_user, project: other_project }
+    let(:comment) { Comment.create user: user, issue: issue }
+    let(:manager) { Manager.create user: user }
+    let(:other_manager) { Manager.create user: User.create }
+
+    it "uses same user ids by default" do
+      expect(project.user_id).to eq(user.id)
+      expect(issue.user_id).to eq(user.id)
+      expect(comment.user_id).to eq(user.id)
+      expect(manager.user_id).to eq(user.id)
+    end
+
+    it "does not allow to rewrite issue id of comment" do
+      comment.issue_id = other_issue.id
+      comment.save
+      expect(comment.errors.messages.values.flatten).to include("user_id of issue does not match comments user_id.")
+      expect(comment.reload.issue_id).to_not eq(other_issue.id)
+    end
+
+    # NOTE: this is possible here because Issue model is not configured to check ids
+    #       comment model can only check id against issue model if it is present
+    it "does allow to rewrite issue id of comment with random id" do
+      comment.issue_id = 42
+      comment.save
+      comment.reload
+      expect(comment.issue_id).to eq(42)
+    end
+
+    it "allow to rewrite member id of comment" do
+      comment.member_id = other_manager.id
+      comment.save
+      comment.reload
+      expect(comment.member_id).to eq(other_manager.id)
+    end
+
+    it "allow to rewrite user id of issue" do
+      issue.user_id = other_user.id
+      issue.save
+      issue.reload
+      expect(issue.user_id).to eq(other_user.id)
+    end
+
+    it "allow to rewrite user id of manager" do
+      manager.user_id = other_user.id
+      manager.save
+      manager.reload
+      expect(manager.user_id).to eq(other_user.id)
+    end
+
+  end
+
+end

data/spec/models/validation_with_exceptions_spec.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+
+describe ForeignKeyValidation::ModelExtension do
+
+  let(:user) { User.create }
+  let(:other_user) { User.create }
+
+  context "with calling private methods from model" do
+    before { Issue.send :validate_foreign_keys }
+
+    let(:issue) { Issue.create }
+
+    it "does not allow to call private validate_foreign_keys_on_* methods" do
+      expect{issue.validate_foreign_keys_on_user}.to raise_exception(/private method `validate_foreign_keys_on_user' called/)
+    end
+  end
+
+  context "with calling validation and wrong attributes hash" do
+
+    it "raises error due to wrong :on key" do
+      expect{Idea.class_eval { validate_foreign_keys on: :not_existing }}.to raise_error("No foreign key for relation not_existing on ideas table!")
+    end
+
+    it "raises error due to not related :on key" do
+      expect{Project.class_eval { validate_foreign_keys on: :comment }}.to raise_error("No foreign key for relation comment on projects table!")
+    end
+
+    it "raises error due to wrong :with key" do
+      expect{Idea.class_eval { validate_foreign_keys with: :not_existing }}.to raise_error('Unknown relation in ["not_existing"]!')
+    end
+
+  end
+
+  context "with calling validation and missing relations" do
+
+    it "raises error due to no existing relations" do
+      expect{Dummy.class_eval { validate_foreign_keys }}.to raise_error("Can't find any belongs_to relations for Dummy class. Put validation call below association definitions!")
+    end
+
+  end
+
+end

data/spec/models/validation_with_missing_foreign_key_spec.rb

@@ -0,0 +1,63 @@
+require 'spec_helper'
+
+describe ForeignKeyValidation::ModelExtension do
+
+  let(:user) { User.create }
+  let(:other_user) { User.create }
+
+  context "with calling validation and missing foreign key on relation" do
+
+    before do
+      Issue.class_eval do
+        validate_foreign_keys
+      end
+    end
+
+    let(:project) { Project.create }
+    let(:other_project) { Project.create }
+    let(:issue) { Issue.create project: project, user: user }
+
+    it "allow to rewrite user id of issue" do
+      issue.user_id = other_user.id
+      issue.save
+      issue.reload
+      expect(issue.user_id).to eq(other_user.id)
+    end
+
+    it "allow to rewrite project id of issue" do
+      issue.project_id = other_project.id
+      issue.save
+      issue.reload
+      expect(issue.project_id).to eq(other_project.id)
+    end
+
+  end
+
+  context "with calling validation and missing foreign key on self" do
+
+    before do
+      Issue.class_eval do
+        validate_foreign_keys
+      end
+    end
+
+    let(:project) { Project.create user: user }
+    let(:issue) { Issue.create project: project }
+
+    it "does not allow to rewrite user id of issue" do
+      issue.user_id = other_user.id
+      issue.save
+      expect(issue.errors.messages.values.flatten).to include("user_id of project does not match issues user_id.")
+      expect(issue.reload.user_id).to_not eq(other_user.id)
+    end
+
+    it "does not allow to rewrite user id of issue with random id" do
+      issue.user_id = 42
+      issue.save
+      expect(issue.errors.messages.values.flatten).to include("user_id of project does not match issues user_id.")
+      expect(issue.reload.user_id).to_not eq(42)
+    end
+
+  end
+
+end

data/spec/models/validation_without_attrs_spec.rb

@@ -0,0 +1,107 @@
+require 'spec_helper'
+
+describe ForeignKeyValidation::ModelExtension do
+
+  let(:user) { User.create }
+  let(:other_user) { User.create }
+
+  context "with calling validation" do
+    before do
+      Idea.send :validate_foreign_keys
+      Project.send :validate_foreign_keys
+      Issue.send :validate_foreign_keys
+      Comment.send :validate_foreign_keys
+      Member.send :validate_foreign_keys
+    end
+
+    let(:project) { Project.create user: user }
+    let(:other_project) { Project.create user: other_user }
+    let(:idea) { Idea.create user: user, project: project }
+    let(:issue) { Issue.create user: user, project: project }
+    let(:other_issue) { Issue.create user: other_user, project: other_project }
+    let(:comment) { Comment.create user: user, issue: issue }
+    let(:manager) { Manager.create user: user }
+    let(:other_manager) { Manager.create user: User.create }
+    let(:developer) { Developer.create user: user, boss: manager }
+
+    it "uses same user ids by default" do
+      expect(project.user_id).to eq(user.id)
+      expect(idea.user_id).to eq(user.id)
+      expect(issue.user_id).to eq(user.id)
+      expect(comment.user_id).to eq(user.id)
+      expect(manager.user_id).to eq(user.id)
+      expect(developer.user_id).to eq(user.id)
+    end
+
+    it "does not allow to rewrite user id of idea" do
+      idea.user_id = other_user.id
+      idea.save
+      expect(idea.errors.messages.values.flatten).to include("user_id of project does not match ideas user_id.")
+      expect(idea.reload.user_id).to_not eq(other_user.id)
+    end
+
+    it "does not allow to rewrite user id of idea with random id" do
+      idea.user_id = 42
+      idea.save
+      expect(idea.errors.messages.values.flatten).to include("user_id of project does not match ideas user_id.")
+      expect(idea.reload.user_id).to_not eq(42)
+    end
+
+    it "does not allow to rewrite project id of idea" do
+      idea.project_id = other_project.id
+      idea.save
+      expect(idea.errors.messages.values.flatten).to include("user_id of project does not match ideas user_id.")
+      expect(idea.reload.user_id).to_not eq(other_project.id)
+    end
+
+    it "does not allow to rewrite user id of issue" do
+      issue.user_id = other_user.id
+      issue.save
+      expect(issue.errors.messages.values.flatten).to include("user_id of project does not match issues user_id.")
+      expect(issue.reload.user_id).to_not eq(other_user.id)
+    end
+
+    it "does not allow to rewrite project id of issue" do
+      issue.project_id = other_project.id
+      issue.save
+      expect(issue.errors.messages.values.flatten).to include("user_id of project does not match issues user_id.")
+      expect(issue.reload.user_id).to_not eq(other_project.id)
+    end
+
+    it "does not allow to rewrite user id of comment" do
+      comment.user_id = other_user.id
+      comment.save
+      expect(comment.errors.messages.values.flatten).to include("user_id of issue does not match comments user_id.")
+      expect(comment.reload.user_id).to_not eq(other_user.id)
+    end
+
+    it "does not allow to rewrite issue id of comment" do
+      comment.issue_id = other_issue.id
+      comment.save
+      expect(comment.errors.messages.values.flatten).to include("user_id of issue does not match comments user_id.")
+      expect(comment.reload.user_id).to_not eq(other_issue.id)
+    end
+
+    it "does allow to rewrite user id of project" do
+      project.user_id = other_user.id
+      project.save
+      expect(project.errors).to be_empty
+      expect(project.reload.user_id).to eq(other_user.id)
+    end
+
+    it "does not allow to rewrite user id of developer" do
+      developer.user_id = other_user.id
+      developer.save
+      expect(developer.errors.messages.values.flatten).to include("user_id of boss does not match developers user_id.")
+      expect(developer.reload.user_id).to_not eq(other_user.id)
+    end
+
+    it "does not allow to rewrite boss id of developer" do
+      developer.custom_boss_id = other_manager.id
+      developer.save
+      expect(developer.errors.messages.values.flatten).to include("user_id of boss does not match developers user_id.")
+      expect(developer.reload.custom_boss_id).to_not eq(other_manager.id)
+    end
+
+  end
+end

data/spec/models/without_validation_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+
+describe ForeignKeyValidation::ModelExtension do
+
+  # NOTE: it's important to not create the objects through relation (user.projects.create...)
+  #       it looks like active_record is caching the classes - but we need to test different class configs
+
+  let(:user) { User.create }
+  let(:other_user) { User.create }
+
+  context "without calling validation" do
+
+    let(:project) { Project.create user: user }
+    let(:idea) { Idea.create user: user, project: project }
+    let(:issue) { Issue.create user: user, project: project }
+    let(:comment) { Comment.create user: user, issue: issue }
+    let(:manager) { Manager.create user: user }
+    let(:other_manager) { Manager.create user: User.create }
+    let(:developer) { Developer.create user: user, boss: manager }
+
+    it "uses same user ids by default" do
+      expect(project.user_id).to eq(user.id)
+      expect(idea.user_id).to eq(user.id)
+      expect(issue.user_id).to eq(user.id)
+      expect(comment.user_id).to eq(user.id)
+      expect(manager.user_id).to eq(user.id)
+      expect(developer.user_id).to eq(user.id)
+    end
+
+    it "allow to rewrite user id of idea with random id" do
+      idea.user_id = 42
+      idea.save
+      idea.reload
+      expect(idea.user_id).to eq(42)
+    end
+
+    it "allow to rewrite user id of idea" do
+      idea.user_id = other_user.id
+      idea.save
+      idea.reload
+      expect(idea.user_id).to eq(other_user.id)
+    end
+
+    it "allow to rewrite user id of project" do
+      project.user_id = other_user.id
+      project.save
+      project.reload
+      expect(project.user_id).to eq(other_user.id)
+    end
+
+    it "allow to rewrite user id of issue" do
+      issue.user_id = other_user.id
+      issue.save
+      issue.reload
+      expect(issue.user_id).to eq(other_user.id)
+    end
+
+    it "allow to rewrite user id of comment" do
+      comment.user_id = other_user.id
+      comment.save
+      comment.reload
+      expect(comment.user_id).to eq(other_user.id)
+    end
+
+    it "allow to rewrite user id of developer" do
+      developer.user_id = other_user.id
+      developer.save
+      developer.reload
+      expect(developer.user_id).to eq(other_user.id)
+    end
+
+    it "allow to rewrite boss id of developer" do
+      developer.custom_boss_id = other_user.id
+      developer.save
+      developer.reload
+      expect(developer.custom_boss_id).to eq(other_user.id)
+    end
+
+  end
+
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foreign_key_validation
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Marcus Geißler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-30 00:00:00.000000000 Z
+date: 2014-10-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -161,11 +161,17 @@ files:
 - gemfiles/4.1.gemfile
 - gemfiles/4.2.gemfile
 - lib/foreign_key_validation.rb
+- lib/foreign_key_validation/collector.rb
 - lib/foreign_key_validation/errors.rb
+- lib/foreign_key_validation/filter.rb
 - lib/foreign_key_validation/model_extension.rb
 - lib/foreign_key_validation/validator.rb
 - lib/foreign_key_validation/version.rb
-- spec/models/model_spec.rb
+- spec/models/validation_with_custom_attrs_spec.rb
+- spec/models/validation_with_exceptions_spec.rb
+- spec/models/validation_with_missing_foreign_key_spec.rb
+- spec/models/validation_without_attrs_spec.rb
+- spec/models/without_validation_spec.rb
 - spec/spec_helper.rb
 - spec/support/load_models.rb
 - spec/support/reset_models.rb
@@ -195,7 +201,11 @@ signing_key:
 specification_version: 4
 summary: Protect the foreign keys in your Rails models.
 test_files:
-- spec/models/model_spec.rb
+- spec/models/validation_with_custom_attrs_spec.rb
+- spec/models/validation_with_exceptions_spec.rb
+- spec/models/validation_with_missing_foreign_key_spec.rb
+- spec/models/validation_without_attrs_spec.rb
+- spec/models/without_validation_spec.rb
 - spec/spec_helper.rb
 - spec/support/load_models.rb
 - spec/support/reset_models.rb

data/spec/models/model_spec.rb

@@ -1,337 +0,0 @@
-require 'spec_helper'
-
-describe ForeignKeyValidation::ModelExtension do
-
-  # NOTE: it's important to not create the objects through relation (user.projects.create...)
-  #       it looks like active_record is caching the classes - but we need to test different class configs
-
-  let(:user) { User.create }
-  let(:other_user) { User.create }
-
-  context "without calling validation" do
-
-    let(:project) { Project.create user: user }
-    let(:idea) { Idea.create user: user, project: project }
-    let(:issue) { Issue.create user: user, project: project }
-    let(:comment) { Comment.create user: user, issue: issue }
-    let(:manager) { Manager.create user: user }
-    let(:other_manager) { Manager.create user: User.create }
-    let(:developer) { Developer.create user: user, boss: manager }
-
-    it "uses same user ids by default" do
-      expect(project.user_id).to eq(user.id)
-      expect(idea.user_id).to eq(user.id)
-      expect(issue.user_id).to eq(user.id)
-      expect(comment.user_id).to eq(user.id)
-      expect(manager.user_id).to eq(user.id)
-      expect(developer.user_id).to eq(user.id)
-    end
-
-    it "allow to rewrite user id of idea with random id" do
-      idea.user_id = 42
-      idea.save
-      idea.reload
-      expect(idea.user_id).to eq(42)
-    end
-
-    it "allow to rewrite user id of idea" do
-      idea.user_id = other_user.id
-      idea.save
-      idea.reload
-      expect(idea.user_id).to eq(other_user.id)
-    end
-
-    it "allow to rewrite user id of project" do
-      project.user_id = other_user.id
-      project.save
-      project.reload
-      expect(project.user_id).to eq(other_user.id)
-    end
-
-    it "allow to rewrite user id of issue" do
-      issue.user_id = other_user.id
-      issue.save
-      issue.reload
-      expect(issue.user_id).to eq(other_user.id)
-    end
-
-    it "allow to rewrite user id of comment" do
-      comment.user_id = other_user.id
-      comment.save
-      comment.reload
-      expect(comment.user_id).to eq(other_user.id)
-    end
-
-    it "allow to rewrite user id of developer" do
-      developer.user_id = other_user.id
-      developer.save
-      developer.reload
-      expect(developer.user_id).to eq(other_user.id)
-    end
-
-    it "allow to rewrite boss id of developer" do
-      developer.custom_boss_id = other_user.id
-      developer.save
-      developer.reload
-      expect(developer.custom_boss_id).to eq(other_user.id)
-    end
-
-  end
-
-  context "with calling validation" do
-    before do
-      Idea.send :validate_foreign_keys
-      Project.send :validate_foreign_keys
-      Issue.send :validate_foreign_keys
-      Comment.send :validate_foreign_keys
-      Member.send :validate_foreign_keys
-    end
-
-    let(:project) { Project.create user: user }
-    let(:other_project) { Project.create user: other_user }
-    let(:idea) { Idea.create user: user, project: project }
-    let(:issue) { Issue.create user: user, project: project }
-    let(:other_issue) { Issue.create user: other_user, project: other_project }
-    let(:comment) { Comment.create user: user, issue: issue }
-    let(:manager) { Manager.create user: user }
-    let(:other_manager) { Manager.create user: User.create }
-    let(:developer) { Developer.create user: user, boss: manager }
-
-    it "uses same user ids by default" do
-      expect(project.user_id).to eq(user.id)
-      expect(idea.user_id).to eq(user.id)
-      expect(issue.user_id).to eq(user.id)
-      expect(comment.user_id).to eq(user.id)
-      expect(manager.user_id).to eq(user.id)
-      expect(developer.user_id).to eq(user.id)
-    end
-
-    it "does not allow to rewrite user id of idea" do
-      idea.user_id = other_user.id
-      idea.save
-      expect(idea.errors.messages.values.flatten).to include("user_id of project does not match ideas user_id.")
-      expect(idea.reload.user_id).to_not eq(other_user.id)
-    end
-
-    it "does not allow to rewrite user id of idea with random id" do
-      idea.user_id = 42
-      idea.save
-      expect(idea.errors.messages.values.flatten).to include("user_id of project does not match ideas user_id.")
-      expect(idea.reload.user_id).to_not eq(42)
-    end
-
-    it "does not allow to rewrite project id of idea" do
-      idea.project_id = other_project.id
-      idea.save
-      expect(idea.errors.messages.values.flatten).to include("user_id of project does not match ideas user_id.")
-      expect(idea.reload.user_id).to_not eq(other_project.id)
-    end
-
-    it "does not allow to rewrite user id of issue" do
-      issue.user_id = other_user.id
-      issue.save
-      expect(issue.errors.messages.values.flatten).to include("user_id of project does not match issues user_id.")
-      expect(issue.reload.user_id).to_not eq(other_user.id)
-    end
-
-    it "does not allow to rewrite project id of issue" do
-      issue.project_id = other_project.id
-      issue.save
-      expect(issue.errors.messages.values.flatten).to include("user_id of project does not match issues user_id.")
-      expect(issue.reload.user_id).to_not eq(other_project.id)
-    end
-
-    it "does not allow to rewrite user id of comment" do
-      comment.user_id = other_user.id
-      comment.save
-      expect(comment.errors.messages.values.flatten).to include("user_id of issue does not match comments user_id.")
-      expect(comment.reload.user_id).to_not eq(other_user.id)
-    end
-
-    it "does not allow to rewrite issue id of comment" do
-      comment.issue_id = other_issue.id
-      comment.save
-      expect(comment.errors.messages.values.flatten).to include("user_id of issue does not match comments user_id.")
-      expect(comment.reload.user_id).to_not eq(other_issue.id)
-    end
-
-    it "does allow to rewrite user id of project" do
-      project.user_id = other_user.id
-      project.save
-      expect(project.errors).to be_empty
-      expect(project.reload.user_id).to eq(other_user.id)
-    end
-
-    it "does not allow to rewrite user id of developer" do
-      developer.user_id = other_user.id
-      developer.save
-      expect(developer.errors.messages.values.flatten).to include("user_id of boss does not match developers user_id.")
-      expect(developer.reload.user_id).to_not eq(other_user.id)
-    end
-
-    it "does not allow to rewrite boss id of developer" do
-      developer.custom_boss_id = other_manager.id
-      developer.save
-      expect(developer.errors.messages.values.flatten).to include("user_id of boss does not match developers user_id.")
-      expect(developer.reload.custom_boss_id).to_not eq(other_manager.id)
-    end
-
-  end
-
-  context "with calling private methods from model" do
-    before { Issue.send :validate_foreign_keys }
-
-    let(:issue) { Issue.create }
-
-    it "does not allow to call private validate_foreign_key method" do
-      expect{issue.validate_foreign_key("test", "unrat")}.to raise_exception(/private method `validate_foreign_key' called/)
-    end
-
-    it "does not allow to call private validate_foreign_keys_on_* methods" do
-      expect{issue.validate_foreign_keys_on_user}.to raise_exception(/private method `validate_foreign_keys_on_user' called/)
-    end
-  end
-
-  context "with calling validation with custom attributes hash" do
-    before do
-      Comment.class_eval do
-        validate_foreign_keys on: :user, with: :issue # member is not in list - should be editable
-      end
-    end
-
-    let(:project) { Project.create user: user }
-    let(:other_project) { Project.create user: other_user }
-    let(:issue) { Issue.create user: user, project: project }
-    let(:other_issue) { Issue.create user: other_user, project: other_project }
-    let(:comment) { Comment.create user: user, issue: issue }
-    let(:manager) { Manager.create user: user }
-    let(:other_manager) { Manager.create user: User.create }
-
-    it "uses same user ids by default" do
-      expect(project.user_id).to eq(user.id)
-      expect(issue.user_id).to eq(user.id)
-      expect(comment.user_id).to eq(user.id)
-      expect(manager.user_id).to eq(user.id)
-    end
-
-    it "does not allow to rewrite issue id of comment" do
-      comment.issue_id = other_issue.id
-      comment.save
-      expect(comment.errors.messages.values.flatten).to include("user_id of issue does not match comments user_id.")
-      expect(comment.reload.issue_id).to_not eq(other_issue.id)
-    end
-
-    # NOTE: this is possible here because Issue model is not configured to check ids
-    #       comment model can only check id against issue model if it is present
-    it "does allow to rewrite issue id of comment with random id" do
-      comment.issue_id = 42
-      comment.save
-      comment.reload
-      expect(comment.issue_id).to eq(42)
-    end
-
-    it "allow to rewrite member id of comment" do
-      comment.member_id = other_manager.id
-      comment.save
-      comment.reload
-      expect(comment.member_id).to eq(other_manager.id)
-    end
-
-    it "allow to rewrite user id of issue" do
-      issue.user_id = other_user.id
-      issue.save
-      issue.reload
-      expect(issue.user_id).to eq(other_user.id)
-    end
-
-    it "allow to rewrite user id of manager" do
-      manager.user_id = other_user.id
-      manager.save
-      manager.reload
-      expect(manager.user_id).to eq(other_user.id)
-    end
-
-  end
-
-  context "with calling validation and wrong attributes hash" do
-
-    it "raises error due to wrong :on key" do
-      expect{Idea.class_eval { validate_foreign_keys on: :not_existing }}.to raise_error("No foreign key for relation not_existing on ideas table!")
-    end
-
-    it "raises error due to not related :on key" do
-      expect{Project.class_eval { validate_foreign_keys on: :comment }}.to raise_error("No foreign key for relation comment on projects table!")
-    end
-
-    it "raises error due to wrong :with key" do
-      expect{Idea.class_eval { validate_foreign_keys with: :not_existing }}.to raise_error('Unknown relation in ["not_existing"]!')
-    end
-
-  end
-
-  context "with calling validation and missing relations" do
-
-    it "raises error due to no existing relations" do
-      expect{Dummy.class_eval { validate_foreign_keys }}.to raise_error("Can't find any belongs_to relations for Dummy class. Put validation call below association definitions!")
-    end
-
-  end
-
-
-  context "with calling validation and missing foreign key on self" do
-
-    before do
-      Issue.class_eval do
-        validate_foreign_keys
-      end
-    end
-
-    let(:project) { Project.create user: user }
-    let(:issue) { Issue.create project: project }
-
-    it "does not allow to rewrite user id of issue" do
-      issue.user_id = other_user.id
-      issue.save
-      expect(issue.errors.messages.values.flatten).to include("user_id of project does not match issues user_id.")
-      expect(issue.reload.user_id).to_not eq(other_user.id)
-    end
-
-    it "does not allow to rewrite user id of issue with random id" do
-      issue.user_id = 42
-      issue.save
-      expect(issue.errors.messages.values.flatten).to include("user_id of project does not match issues user_id.")
-      expect(issue.reload.user_id).to_not eq(42)
-    end
-
-
-  end
-
-  context "with calling validation and missing foreign key on relation" do
-
-    before do
-      Issue.class_eval do
-        validate_foreign_keys
-      end
-    end
-
-    let(:project) { Project.create }
-    let(:other_project) { Project.create }
-    let(:issue) { Issue.create project: project, user: user }
-
-    it "allow to rewrite user id of issue" do
-      issue.user_id = other_user.id
-      issue.save
-      issue.reload
-      expect(issue.user_id).to eq(other_user.id)
-    end
-
-    it "allow to rewrite project id of issue" do
-      issue.project_id = other_project.id
-      issue.save
-      issue.reload
-      expect(issue.project_id).to eq(other_project.id)
-    end
-
-  end
-
-end